[Libreoffice-commits] core.git: Changes to 'refs/changes/66/3066/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/65/3065/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/03/3203/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/03/3203/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/03/3203/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/04/3204/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/04/3204/4'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/04/3204/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/04/3204/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/platform/com_MSC_defs.mk | 34 - 1 file changed, 34 deletions(-) New commits: commit 8dd4db783ffe5a11b5bf427014a2f8524cc87cad Author: Petr Kraus petr_kr...@email.cz Date: Thu Apr 4 03:42:23 2013 +0200 fdo#42781 Do not unnecessarily ignore MSVC warnings Removed some ignored warnings for MSVC compiler that should not occur. MSVC 2010 can, but do not issue these for me. Some of them are disabled by default and should not occur unless -Wall C warnings: C4180, C4250, C4255, C4275, C4290, C4503, C4511, C4611, C4640 CXX warnings: C4180, C4242, C4265, C4503, C4511, C4626, C4640, C4996 Change-Id: I61b692a9c02a8900f80b019e11ad4acdea3e4dfc Reviewed-on: https://gerrit.libreoffice.org/3203 Reviewed-by: Fridrich Strba fridr...@documentfoundation.org Tested-by: Fridrich Strba fridr...@documentfoundation.org diff --git a/solenv/gbuild/platform/com_MSC_defs.mk b/solenv/gbuild/platform/com_MSC_defs.mk index 439afa5..e33f22e 100644 --- a/solenv/gbuild/platform/com_MSC_defs.mk +++ b/solenv/gbuild/platform/com_MSC_defs.mk @@ -80,8 +80,6 @@ gb_AFLAGS := $(AFLAGS) # C4127: conditional expression is constant -# C4180: qualifier applied to function type has no meaning; ignored - # C4189: 'identifier' : local variable is initialized but not referenced # C4242: 'identifier' : conversion from 'type1' to 'type2', possible @@ -98,12 +96,6 @@ gb_AFLAGS := $(AFLAGS) # C4251: 'identifier' : class 'type' needs to have dll-interface to be # used by clients of class 'type2' -# C4255: 'function' : no function prototype given: converting '()' to -# '(void)' - -# C4265: 'class' : class has virtual functions, but destructor is not -# virtual - # C4275: non-DLL-interface classkey 'identifier' used as base for # DLL-interface classkey 'identifier' @@ -119,13 +111,8 @@ gb_AFLAGS := $(AFLAGS) # of the compiler did not override when parameters only differed by # const/volatile qualifiers. -# C4503: 'identifier' : decorated name length exceeded, name was -# truncated - # C4505: 'function' : unreferenced local function has been removed -# C4511: 'class' : copy constructor could not be generated - # C4512: 'class' : assignment operator could not be generated # C4611: interaction between 'function' and C++ object destruction is @@ -134,15 +121,11 @@ gb_AFLAGS := $(AFLAGS) # C4626: 'derived class' : assignment operator could not be generated # because a base class assignment operator is inaccessible -# C4640: 'instance' : construction of local static object is not thread-safe - # C4706: assignment within conditional expression # C4800: 'type' : forcing value to bool 'true' or 'false' (performance # warning) -# C4996: 'function': was declared deprecated - gb_CFLAGS := \ -Gd \ -GR \ @@ -152,24 +135,15 @@ gb_CFLAGS := \ -nologo \ -W4 \ -wd4127 \ - -wd4180 \ -wd4189 \ -wd4242 \ -wd4244 \ -wd4245 \ - -wd4250 \ -wd4251 \ - -wd4255 \ - -wd4275 \ - -wd4290 \ -wd4355 \ - -wd4503 \ -wd4505 \ - -wd4511 \ -wd4512 \ - -wd4611 \ -wd4626 \ - -wd4640 \ -wd4706 \ -wd4800 \ -Zc:forScope,wchar_t- \ @@ -185,29 +159,21 @@ gb_CXXFLAGS := \ -nologo \ -W4 \ -wd4127 \ - -wd4180 \ -wd4189 \ - -wd4242 \ -wd4244 \ -wd4245 \ -wd4250 \ -wd4251 \ - -wd4265 \ -wd4275 \ -wd4290 \ -wd4351 \ -wd4355 \ -wd4373 \ - -wd4503 \ -wd4505 \ - -wd4511 \ -wd4512 \ -wd4611 \ - -wd4626 \ - -wd4640 \ -wd4706 \ -wd4800 \ - -wd4996 \ -Zc:forScope,wchar_t- \ -Zm500 \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#42781 Do not unnecessarily ignore MSVC warnings
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3203 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/3203/1 fdo#42781 Do not unnecessarily ignore MSVC warnings Removed some ignored warnings for MSVC compiler that should not occur. MSVC 2010 can, but do not issue these for me. Some of them are disabled by default and should not occur unless -Wall C warnings: C4250, C4255, C4275, C4290, C4503, C4511, C4611, C4640 CXX warnings: C4242, C4265, C4503, C4511, C4626, C4640 Change-Id: I61b692a9c02a8900f80b019e11ad4acdea3e4dfc --- M solenv/gbuild/platform/com_MSC_defs.mk 1 file changed, 0 insertions(+), 27 deletions(-) diff --git a/solenv/gbuild/platform/com_MSC_defs.mk b/solenv/gbuild/platform/com_MSC_defs.mk index e8488ef..9675e2d 100644 --- a/solenv/gbuild/platform/com_MSC_defs.mk +++ b/solenv/gbuild/platform/com_MSC_defs.mk @@ -98,12 +98,6 @@ # C4251: 'identifier' : class 'type' needs to have dll-interface to be # used by clients of class 'type2' -# C4255: 'function' : no function prototype given: converting '()' to -# '(void)' - -# C4265: 'class' : class has virtual functions, but destructor is not -# virtual - # C4275: non-DLL-interface classkey 'identifier' used as base for # DLL-interface classkey 'identifier' @@ -119,12 +113,7 @@ # of the compiler did not override when parameters only differed by # const/volatile qualifiers. -# C4503: 'identifier' : decorated name length exceeded, name was -# truncated - # C4505: 'function' : unreferenced local function has been removed - -# C4511: 'class' : copy constructor could not be generated # C4512: 'class' : assignment operator could not be generated @@ -133,8 +122,6 @@ # C4626: 'derived class' : assignment operator could not be generated # because a base class assignment operator is inaccessible - -# C4640: 'instance' : construction of local static object is not thread-safe # C4706: assignment within conditional expression @@ -157,19 +144,11 @@ -wd4242 \ -wd4244 \ -wd4245 \ - -wd4250 \ -wd4251 \ - -wd4255 \ - -wd4275 \ - -wd4290 \ -wd4355 \ - -wd4503 \ -wd4505 \ - -wd4511 \ -wd4512 \ - -wd4611 \ -wd4626 \ - -wd4640 \ -wd4706 \ -wd4800 \ -Zc:forScope,wchar_t- \ @@ -187,24 +166,18 @@ -wd4127 \ -wd4180 \ -wd4189 \ - -wd4242 \ -wd4244 \ -wd4245 \ -wd4250 \ -wd4251 \ - -wd4265 \ -wd4275 \ -wd4290 \ -wd4351 \ -wd4355 \ -wd4373 \ - -wd4503 \ -wd4505 \ - -wd4511 \ -wd4512 \ -wd4611 \ - -wd4626 \ - -wd4640 \ -wd4706 \ -wd4800 \ -wd4996 \ -- To view, visit https://gerrit.libreoffice.org/3203 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61b692a9c02a8900f80b019e11ad4acdea3e4dfc Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Petr Kraus petr_kr...@email.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#42781 WaE: C4101 unreferenced local variable
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3204
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/3204/1
fdo#42781 WaE: C4101 unreferenced local variable
ugly solution but consistent with rest of the file
Change-Id: I7fdb5a1b0a16ee7cfe15f7aee4b2fb95b9072c3d
---
M sw/source/core/tox/toxhlp.cxx
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sw/source/core/tox/toxhlp.cxx b/sw/source/core/tox/toxhlp.cxx
index 5dfc8dc..e729daf 100644
--- a/sw/source/core/tox/toxhlp.cxx
+++ b/sw/source/core/tox/toxhlp.cxx
@@ -35,7 +35,11 @@
try {
xIES = i18n::IndexEntrySupplier::create(xContext);
}
-catch (const uno::Exception e)
+catch (const uno::Exception
+#if OSL_DEBUG_LEVEL 0
+e
+#endif
+)
{
#if OSL_DEBUG_LEVEL 0
rtl::OStringBuffer aMsg(IndexEntrySupplierWrapper: Caught
exception\n);
--
To view, visit https://gerrit.libreoffice.org/3204
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fdb5a1b0a16ee7cfe15f7aee4b2fb95b9072c3d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Petr Kraus petr_kr...@email.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/tox/toxhlp.cxx | 69 +++---
1 file changed, 12 insertions(+), 57 deletions(-)
New commits:
commit f5928f09ad53de2c4683000619d29be140a97be8
Author: Petr Kraus petr_kr...@email.cz
Date: Thu Apr 4 19:12:46 2013 +0200
fdo#42781 WaE: C4101 unreferenced local variable
fixed by OSL_FAIL - SAL_WARN.
Rewritten rest of the file to match this style.
Change-Id: I7fdb5a1b0a16ee7cfe15f7aee4b2fb95b9072c3d
Reviewed-on: https://gerrit.libreoffice.org/3204
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/source/core/tox/toxhlp.cxx b/sw/source/core/tox/toxhlp.cxx
index 5dfc8dc..bdee756 100644
--- a/sw/source/core/tox/toxhlp.cxx
+++ b/sw/source/core/tox/toxhlp.cxx
@@ -20,10 +20,9 @@
#include com/sun/star/lang/XMultiServiceFactory.hpp
#include comphelper/processfactory.hxx
#include com/sun/star/i18n/IndexEntrySupplier.hpp
-#include rtl/strbuf.hxx
#include tools/string.hxx
#include toxwrap.hxx
-#include tools/diagnose_ex.h
+#include sal/log.hxx
using namespace ::com::sun::star;
@@ -37,11 +36,7 @@ IndexEntrySupplierWrapper::IndexEntrySupplierWrapper()
}
catch (const uno::Exception e)
{
-#if OSL_DEBUG_LEVEL 0
-rtl::OStringBuffer aMsg(IndexEntrySupplierWrapper: Caught
exception\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-OSL_FAIL( aMsg.getStr() );
-#endif
+SAL_WARN( sw.core, IndexEntrySupplierWrapper: Caught exception:
e.Message );
}
}
@@ -57,17 +52,9 @@ String IndexEntrySupplierWrapper::GetIndexKey( const String
rTxt,
try {
sRet = xIES-getIndexKey( rTxt, rTxtReading, rLocale );
}
-catch (const ::com::sun::star::uno::Exception
-#if OSL_DEBUG_LEVEL 0
-e
-#endif
-)
+catch (const uno::Exception e)
{
-#if OSL_DEBUG_LEVEL 0
-rtl::OStringBuffer aMsg(getIndexKey: Caught exception\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-OSL_FAIL( aMsg.getStr() );
-#endif
+SAL_WARN( sw.core, getIndexKey: Caught exception: e.Message );
}
return sRet;
}
@@ -78,17 +65,9 @@ String IndexEntrySupplierWrapper::GetFollowingText( sal_Bool
bMorePages ) const
try {
sRet = xIES-getIndexFollowPageWord( bMorePages, aLcl );
}
-catch (const ::com::sun::star::uno::Exception
-#if OSL_DEBUG_LEVEL 0
-e
-#endif
-)
+catch (const uno::Exception e)
{
-#if OSL_DEBUG_LEVEL 0
-rtl::OStringBuffer aMsg(getIndexFollowPageWord: Caught exception\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-OSL_FAIL( aMsg.getStr() );
-#endif
+SAL_WARN( sw.core, getIndexFollowPageWord: Caught exception:
e.Message );
}
return sRet;
}
@@ -101,17 +80,9 @@ IndexEntrySupplierWrapper::GetAlgorithmList( const
::com::sun::star::lang::Local
try {
sRet = xIES-getAlgorithmList( rLcl );
}
-catch (const ::com::sun::star::uno::Exception
-#if OSL_DEBUG_LEVEL 0
-e
-#endif
-)
+catch (const uno::Exception e)
{
-#if OSL_DEBUG_LEVEL 0
-rtl::OStringBuffer aMsg(getAlgorithmList: Caught exception\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-OSL_FAIL( aMsg.getStr() );
-#endif
+SAL_WARN( sw.core, getAlgorithmList: Caught exception:
e.Message );
}
return sRet;
}
@@ -124,17 +95,9 @@ sal_Bool IndexEntrySupplierWrapper::LoadAlgorithm(
try {
bRet = xIES-loadAlgorithm( rLcl, sSortAlgorithm, nOptions );
}
-catch (const ::com::sun::star::uno::Exception
-#if OSL_DEBUG_LEVEL 0
-e
-#endif
-)
+catch (const uno::Exception e)
{
-#if OSL_DEBUG_LEVEL 0
-rtl::OStringBuffer aMsg(loadAlgorithm: Caught exception\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-OSL_FAIL( aMsg.getStr() );
-#endif
+SAL_WARN( sw.core, loadAlgorithm: Caught exception: e.Message
);
}
return bRet;
}
@@ -150,17 +113,9 @@ sal_Int16 IndexEntrySupplierWrapper::CompareIndexEntry(
nRet = xIES-compareIndexEntry( rTxt1, rTxtReading1, rLocale1,
rTxt2, rTxtReading2, rLocale2 );
}
-catch (const ::com::sun::star::uno::Exception
-#if OSL_DEBUG_LEVEL 0
-e
-#endif
-)
+catch (const uno::Exception e)
{
-#if OSL_DEBUG_LEVEL 0
-rtl::OStringBuffer aMsg(compareIndexEntry: Caught exception\n);
-aMsg.append(rtl::OUStringToOString(e.Message, RTL_TEXTENCODING_UTF8));
-OSL_FAIL( aMsg.getStr() );
-#endif
+SAL_WARN( sw.core, compareIndexEntry: Caught exception:
e.Message );
}
return nRet;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr4.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 00e9accbc591791b6529105807a2944cd92dde78 Author: Petr Kraus petr_kr...@email.cz Date: Tue Mar 26 18:16:44 2013 +0100 fdo#42781 WaE: unreachable code Encapsulate whole switch case code by #if so it does not produce unreachable code when TRUE Also found second occurence in function overload. Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96 Reviewed-on: https://gerrit.libreoffice.org/3066 Reviewed-by: Christoph Brill egore...@gmail.com Reviewed-by: Tomáš Chvátal tchva...@suse.cz Tested-by: Tomáš Chvátal tchva...@suse.cz diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index bfd9494..a3d77ff 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -543,10 +543,10 @@ double ScInterpreter::GetCellValueOrZero( const ScAddress rPos, const ScBaseCel break; #if OSL_DEBUG_LEVEL 0 case CELLTYPE_DESTROYED: -#endif SetError(errCellNoValue); fValue = 0.0; break; +#endif } return fValue; @@ -610,10 +610,10 @@ double ScInterpreter::GetCellValueOrZero( ScCellIterator rIter ) break; #if OSL_DEBUG_LEVEL 0 case CELLTYPE_DESTROYED: -#endif SetError(errCellNoValue); fValue = 0.0; break; +#endif } return fValue; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#42781 WaE: unreachable code
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3065 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/3065/1 fdo#42781 WaE: unreachable code Encapsulate whole switch case code by #if so it does not produce unreachable code when TRUE Change-Id: Id6c843019d27ea621a4a2d0bdff88f5bbdc11ae7 --- M sc/source/core/tool/interpr4.cxx 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index bfd9494..9018c33 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -543,10 +543,10 @@ break; #if OSL_DEBUG_LEVEL 0 case CELLTYPE_DESTROYED: -#endif SetError(errCellNoValue); fValue = 0.0; break; +#endif } return fValue; -- To view, visit https://gerrit.libreoffice.org/3065 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6c843019d27ea621a4a2d0bdff88f5bbdc11ae7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Petr Kraus petr_kr...@email.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#42781 WaE: unreachable code
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3066 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3066/1 fdo#42781 WaE: unreachable code Encapsulate whole switch case code by #if so it does not produce unreachable code when TRUE Also found second occurence in function overload. Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96 --- M sc/source/core/tool/interpr4.cxx 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index bfd9494..a3d77ff 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -543,10 +543,10 @@ break; #if OSL_DEBUG_LEVEL 0 case CELLTYPE_DESTROYED: -#endif SetError(errCellNoValue); fValue = 0.0; break; +#endif } return fValue; @@ -610,10 +610,10 @@ break; #if OSL_DEBUG_LEVEL 0 case CELLTYPE_DESTROYED: -#endif SetError(errCellNoValue); fValue = 0.0; break; +#endif } return fValue; -- To view, visit https://gerrit.libreoffice.org/3066 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Petr Kraus petr_kr...@email.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] fdo#42781 WaE: unreachable code
Petr Kraus has abandoned this change. Change subject: fdo#42781 WaE: unreachable code .. Patch Set 1: Abandoned posted better patch https://gerrit.libreoffice.org/#/c/3066/ -- To view, visit https://gerrit.libreoffice.org/3065 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id6c843019d27ea621a4a2d0bdff88f5bbdc11ae7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Petr Kraus petr_kr...@email.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
