Re: HttpClient - HttpComponents

2013-12-31 Thread Pierre-André Jacquod
Hello, used to progamm a bit, but due to lack of time, was not able to contribute with the speeding up of the tree... But as it seems to be a very low level priority task, I will have a try. The Commons HttpClient project is now end of life, and is no to remove at least this dependency.

Re: internal compiler error: in connect_traces, at dwarf2cfi.c:2676

2013-12-30 Thread Pierre-André Jacquod
Hello, works fine by me. Did you try with another compiler / compiler version ? I have gcc version 4.7.2 20130108 [gcc-4_7-branch revision 195012] (SUSE Linux) and last commit in master being: d8dedc775cedf0e9daf9284bc7e3a0331ccd2963 EMF+: Integer coordinate values are signed. regards

Re: Beginner

2013-12-24 Thread Pierre-André Jacquod
Hello, if you want to contribute with coding, I would suggest you: - first (try to) build LibreOffice, depend on OS it can be tricky, but less than it used to be. This implies to download the source code, resolve dependencies and use the compiler - if not yet, get familiar with git (some basic

Re: Cppunit-1.13.0 released

2012-07-07 Thread Pierre-André Jacquod
hello, updated :-) http://en.wikipedia.org/wiki/CppUnit regards On 07/07/2012 04:19 AM, Markus Mohrhard wrote: Hey, after we have no longer any build issues with cppunit I have now officially tagged the 1.13.0 release of cppunit. I would like to thank everybody who helped during this release.

Re: Cppunit-1.13.0 released

2012-07-07 Thread Pierre-André Jacquod
hello, git clone git://anongit.freedesktop.org/git/libreoffice/cppunit/ or http://cgit.freedesktop.org/libreoffice/cppunit/ regards On 07/07/2012 09:40 AM, Andreas Radke wrote: Am Sat, 7 Jul 2012 04:19:39 +0200 schrieb Markus Mohrhard markus.mohrh...@googlemail.com: Hey, after we have no

bug 49610 in impress: suspicious commit found, but help needed

2012-06-21 Thread Pierre-André Jacquod
hello, this bug is a bad regression. Following with debugger, I had as suspect the function void Outliner::ProvideNextTextObject (void) line 979 in sd/source/ui/view/Outliner.cxx (or something called late from this) as main suspect. After bibisect from QA the commit

Re: [ANN] Please use Gerrit from now on for Patch Review

2012-06-21 Thread Pierre-André Jacquod
Hello, well as free time contributor with commit access to current repository, I followed this gerrit story. So not kind of surprise, but yeah, until THIS mail and posts, was me very unclear what it would mean. To say it, first I had a lot of doubt. Reading mails, entry in the wiki, looking

Re: [Libreoffice] What is bibisect? And what is it doing in my office?

2012-06-21 Thread Pierre-André Jacquod
Hi, just to say thanks for bibisect Impressive example with fdo49610 to find the problematic commit. Regards Pierre-André On 12/09/2011 02:59 PM, Bjoern Michaelsen wrote: Hi all, So I hope with this, we make regression finding some more fun and allow us -- QA and developers together -- to

Re: bug 49610 in impress: suspicious commit found, but help needed

2012-06-21 Thread Pierre-André Jacquod
that fit to my knowledge there. Or have you time to investigate it and fix it ? Sorry, this sounds not very constructive, but in this period I do not have a lot of free time, so I can not offer more. Tack regards Pierre-André On 06/20/2012 11:10 PM, Thorsten Behrens wrote: Pierre-André Jacquod

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Pierre-André Jacquod
Hello, On 05/20/2012 11:24 PM, Norbert Thiebaud wrote: On Wed, May 16, 2012 at 11:30 PM, Pierre-André Jacquod pjacq...@alumni.ethz.ch wrote: expecting to get symbols without optimization, not wanting all asserts outputs. If you are intending to debug why wouldn't you want the misnamed

Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-20 Thread Pierre-André Jacquod
hello, On 05/16/2012 04:07 PM, Lubos Lunak wrote: If somebody does a developer build, there are not many good reasons why -O2 should be used - it takes noticably more time and it makes debugging miserable. I can't think of anything else than final builds and profiling as a good

Re: [PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-05-18 Thread Pierre-André Jacquod
Hello, On 05/03/2012 11:30 AM, Thorsten Behrens wrote: So what I suggest is a more defensive fix (or some larger review across the code is in order): make GetLineArrow() return the B2DPolyPolygon right away, and have *that one* be empty (i.e. not a Since I do not intend to become a specialist

some license statement

2012-05-05 Thread Pierre-André Jacquod
Hello, just to confirm that all of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Best regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-04-30 Thread Pierre-André Jacquod
Hello, back again after a while. On 02/15/2012 11:30 AM, Thorsten Behrens wrote: Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to chase down why in the first place the ppt import creates polygons with empty sub-paths, that looks like a worthwhile

Re: [ANN] Referencing bugs in commits

2012-02-15 Thread Pierre-André Jacquod
hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean title line or would it works also as first line of

input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, I have quickly investigated the crash in fdo#45779 when saving an impress document. The reason of the crash is in basegfx/inc/basegfx/point/b2dpoint.hxx (line 82) where this is called: 2DPoint::B2DPoint (this=0xbfffc850, rPoint=...) : B2DTuple(rPoint) (from back-trace) It

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you thanks import creates polygons with empty sub-paths, that looks like a worthwhile optimization - code is around filter/source/msfilter/msdffimp.cxx probably. as soon as I have more spare time, I will have a try.

Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

2012-02-14 Thread Pierre-André Jacquod
hello, The bug reference has to have fdo#ABCDE form (where ABCDE is the bug number), and has to be at the first line of the commit (it does not matter where on that line). Sorry, one point is for me not clear: by the first line, do you mean title line or would it works also as first line of

Re: [Libreoffice] bug 36874 (label printing) further improvement?

2012-01-03 Thread Pierre-André Jacquod
Hello, Just to mix in the middle: from this and a previous mail from you: It would be much better if the label-definitions contain all dimensions, i.e. yes My calculation is based on the assumption (presumption?) that the page containing the labels is symmetrical, i.e. rotating the page

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 5 commits - filter/source sc/source sd/source vcl/inc vcl/source

2011-12-29 Thread Pierre-André Jacquod
filter/source/pdf/impdialog.cxx | 13 filter/source/pdf/impdialog.hrc |1 filter/source/pdf/impdialog.hxx |2 filter/source/pdf/impdialog.src | 12 filter/source/pdf/pdfexport.cxx |4 filter/source/pdf/pdfexport.hxx |1

[Libreoffice-commits] .: 4 commits - filter/source sc/source sd/source vcl/inc vcl/source

2011-12-28 Thread Pierre-André Jacquod
filter/source/pdf/impdialog.cxx | 13 filter/source/pdf/impdialog.hrc |1 filter/source/pdf/impdialog.hxx |2 filter/source/pdf/impdialog.src | 12 filter/source/pdf/pdfexport.cxx |4 filter/source/pdf/pdfexport.hxx |1

[Libreoffice-commits] .: vcl/inc

2011-12-28 Thread Pierre-André Jacquod
vcl/inc/vcl/pdfextoutdevdata.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9cc02548dec9b953eb186052d424d981cb2addea Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Thu Dec 29 00:02:18 2011 +0100 change order of var in PDFExtOutDevData to

[Libreoffice-commits] .: vcl/inc

2011-12-28 Thread Pierre-André Jacquod
vcl/inc/vcl/pdfextoutdevdata.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3bcee0e100e9fdadc2c5b15036caaf2ed53ac6dc Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Thu Dec 29 00:05:51 2011 +0100 Revert change order of var in PDFExtOutDevData

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-12-18 Thread Pierre-André Jacquod
Hi Eicke, The second one: 0001-fdo42286-extend-down-but-also-shrink-if-cells-are-em.patch For consistency it makes sense to also shrink the area, as re-initializing the filter area with only one cell or one row selected . erroneously included. Please go ahead with this one. OK

[Libreoffice-commits] .: 3 commits - sc/source

2011-12-04 Thread Pierre-André Jacquod
sc/source/core/data/table1.cxx | 82 - 1 file changed, 48 insertions(+), 34 deletions(-) New commits: commit e42ee773ffc12e38d596ce2aa016f0849c4e5ac6 Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Tue Nov 29 09:10:26 2011 +0100 reduce

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-12-04 Thread Pierre-André Jacquod
Hello, To give you a background, this extend range downward functionality was Thanks for your explanation. Following the remark of Eicke, I ended up with 3 possible patches :-/ which all have small differences in behaviour. I have a favorite, but do not want to choose alone. Please push the

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-29 Thread Pierre-André Jacquod
Hi Eike Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to not include newly appended columns of an area. half true: the condition is exactly that the newly appended column data touch by an angle the already defined area (like C3 to B2) and that all other cells below the

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-11-29 Thread Pierre-André Jacquod
Hello, sorry, I was sure there was more about it...but too early this morning, I could not sort out all points. Now you also changed bOnlyDown=false to bOnlyDown=true, which leads to not include newly appended columns of an area. Why? by the way, this reflect the comment in void

Re: [Libreoffice] final and override

2011-11-28 Thread Pierre-André Jacquod
Hello, However, given that override and final will only make it into GCC 4.7 (according to http://wiki.apache.org/stdcxx/C++0xCompilerSupport), it according to gcc.gnu.org too.. but since it seems that MSCV (according the same wiki) supports it / will support it, why not just wait a bit and

[Libreoffice-commits] .: sc/source

2011-11-27 Thread Pierre-André Jacquod
sc/source/core/data/table1.cxx |7 +-- sc/source/core/tool/dbdata.cxx |2 +- 2 files changed, 6 insertions(+), 3 deletions(-) New commits: commit 88611e702a18d2a281c22b6d9c28e881be3df223 Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Sun Nov 27 18:17:32 2011 +0100

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-27 Thread Pierre-André Jacquod
Hi, BUT this is a workaround, to compensate the not so correct behaviour of GetDataArea :-( The behaviour in bINcludeOld = false seems me strange (ergh I think wrong but you told me to be cautious), since it removes from the side of the area that has not yet been extended above the last

[Libreoffice] [PATCH] fdo#42286, do not shrink the selected area

2011-11-24 Thread Pierre-André Jacquod
hello, here attached an new patch (hopefully wiser) to solve the mentioned bug. This ensure that the call to ExtendDataArea does as commented in the code sc/source/core/tool/dbdata.cxx : // Extend the DB area to include data rows immediately below. and does not shrink the original area... So

Re: [Libreoffice] [PATCH] fdo 42286 in calc solved ?

2011-11-15 Thread Pierre-André Jacquod
Hello, Thanks for your hints. It took some times, but know I have clearly identified the problem , but I do not if my solution is right or could create more problems. In short, the problem is that GetAreadData is called each time the filter determines its values, instead of using the

[Libreoffice] some hints needed for fdo 42286 in calc

2011-11-01 Thread Pierre-André Jacquod
hello, I am trying to debug fdo 42286 in calc. It has to do with autofilter, where some empty lines (rows) are shown despite the filter criteria that is set. (and a strange filter behaviour). As entry point, I found sc/.. tools/queryparam.cxx dbdata.cxx but it seems that there all is Ok.

Re: [Libreoffice] some hints needed for fdo 42286 in calc

2011-11-01 Thread Pierre-André Jacquod
hello, and query information. The query is executed in ScDBDocFunc::Query and related functions. thanks I will look there come back if needed P.S. Do you know if this is a regression against 3.3? Then it might be No 3.3 available to test (and a bit short of place on HD). But happens on

Re: [Libreoffice] Declarations after statements

2011-10-10 Thread Pierre-André Jacquod
Hello, Declarations after statements are possible only in C99. And MSVC does not support C99 (refrain from bitching here, please). sorry Tor, I was not enthusiasm, just systematic and from *xes world. ... and I am - almost - too young to know there was a C89 before... If time allows, I will

Re: [Libreoffice] dmake/win95: deprecated directory ?

2011-10-09 Thread Pierre-André Jacquod
Hello, dmake is 3rd-party software, thanks, with One git, not being familiar with all part of the code and the structure, not always easy to know what is LO and 3rd-party. Should it not belongs to external/ ? Or what is the semantic there ? Or would it make sense to have at the top level a

Re: [Libreoffice] oox/source/drawingml/customshapepresets.cxx is just too much for gcc

2011-10-09 Thread Pierre-André Jacquod
On 10/07/2011 03:51 PM, Norbert Thiebaud wrote: 2011/10/7 Marc-André Laverdièremarc-an...@atc.tcs.com: Wow, I really missed the 'big debate' :) me too :- ) - I don't think we can expect developers to run a build before each push, Yes we absolutely can expect that. it is actually a bare

Re: [Libreoffice] master build fails in basegfx

2011-10-09 Thread Pierre-André Jacquod
hello, On 10/09/2011 02:04 PM, Jean-Baptiste Faure wrote: Le 09/10/2011 09:18, Matúš Kukan a écrit : On 9 October 2011 09:13, Jean-Baptiste Faurejbf.fa...@orange.fr : I try to build the master and I get an error in building basegfx. git revert 49861a0246547554e285b4d14f049a28addd4ddc But I

[Libreoffice-commits] .: vcl/aqua

2011-10-07 Thread Pierre-André Jacquod
vcl/aqua/source/gdi/salatsuifontutils.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 78b1cc1a08d712212152a1e57400c8b07654e471 Author: Pierre-André Jacquod pjacq...@alumni.ethz.ch Date: Fri Oct 7 20:40:01 2011 +0200 Revert cppcheck scope reduction in

[Libreoffice] dmake/win95: deprecated directory ?

2011-10-06 Thread Pierre-André Jacquod
hello, I found a directory that seems to be deprecated since win95 is not supported anymore. There is another directory: dmake/winnt which seems to be more or less the clone of dmake/win95. Since I am not able to compile under windows, -hence not able to check what I would break - I mention

[Libreoffice] scope of variable reduction, cppcheck-error free build and new bugs

2011-10-06 Thread Pierre-André Jacquod
Hello, since I had free time, I have taken over to eliminate the scope reduction warning from cppcheck in order to reduce the noise by checks. This has been done almost successfully, about 10 such warnings are still available due to #ifdefn or macros. This also allowed me to reduce other

[Libreoffice-commits] .: 13 commits - autodoc/source connectivity/workben rsc/source slideshow/source tools/source vcl/source

2011-09-26 Thread Pierre-André Jacquod
autodoc/source/display/html/hdimpl.cxx | 11 - autodoc/source/parser/cpp/cx_c_pp.cxx |4 connectivity/workben/testmoz/main.cxx |2 rsc/source/res/rscflag.cxx |

Re: [Libreoffice] [PUSHED][patch] memset used on struc with std::vector / Windows code

2011-09-13 Thread Pierre-André Jacquod
Hello, That should happen in a DdeInstData ctor instead. I intended to do something easier: struct DdeInstData { short x; DdeInstData(); // and of course implementing this } I've moved it into the ctor now. Thanks, I was not able to react very quickly, making this during free

Re: [Libreoffice] Cppcheck defect when @ is present

2011-09-11 Thread Pierre-André Jacquod
Hello, What's the best thing to do : - to keep objective C++ parts ? - to replace objective C++ by plain (with or without boost) C++ ? for me there are already too many languages and flavour of languages. I would stay with plain C++, not adding objective C++ on top Just my feelings

[Libreoffice] [patch] memset used on struc with std::vector / Windows code

2011-09-11 Thread Pierre-André Jacquod
hello, I allow me to send also this patch (I should really find out a Windows box in order to compile / test by myself). In short: since a39d4eae Remove DECLARE_LIST(DdeConnections,DdeConnection*) the struct DdeInstData contains a std::vector, but was initialized with memset(

Re: [Libreoffice] [PATCH] some cleaning for Windows part - need a review

2011-09-10 Thread Pierre-André Jacquod
Hello, I will have a look at your patches on Monday, unless somebody beats me to it during the weekend. Thanks, based on some remarks, here exactly the same patches, but with improved commit comments. Will be probably better to integrate these. Regards Pierre-André From

[Libreoffice] [PATCH] some cleaning for Windows part - need a review

2011-09-09 Thread Pierre-André Jacquod
hello, liking systematic work, I was cleaning the unreadVariable warning from cppchecker.:-) This also let improve my programming knowledge and style... Here a bunch of changes that touch only Win product,... that I am unable to test, having only unix. Neverless, I did it would it be to

[Libreoffice] code simplification: please logic review, to be sure

2011-08-26 Thread Pierre-André Jacquod
Hello, I am trying to wipe some unneeded calls and I see the following: while( ) { - SwFrm* pFrm; if( 0 != ( pONd = aIdx.GetNode().GetOLENode() ) aName.Equals( pONd-GetChartTblName() ) 0 != ( pFrm = pONd-getLayoutFrm( rVSh.GetLayout() )

[Libreoffice] how to handle this bug (if this is one?)

2011-08-26 Thread Pierre-André Jacquod
hello, in vcl/win/source/gdi/winlayout.cxx, around line 695 there is: long SimpleWinLayout::FillDXArray( long* pDXArray ) const { +if( !mnWidth ) +{ +long mnWidth = mnBaseAdv; +for( int i = 0; i mnGlyphCount; ++i ) +mnWidth += mpGlyphAdvances[ i ]; +}

[Libreoffice] [patch] unused variable in Windows build

2011-08-12 Thread Pierre-André Jacquod
Hello, a small patch to suppress an unused variable (within a WNT define) according cppchecker Since I can not build on Windows, if someone could review / compile it for me before pushing ? Thanks and regards Pierre-André 0001-unused-variable-in-Windows-build.patch Description:

Re: [Libreoffice] minutes of tech steering call ...

2011-05-06 Thread Pierre-André Jacquod
Hi, * announcing binfilter as deprecated in 3.4 + want to warn people in plenty of time + officially deprecate it, we drop save support in 3.4 The code cleaning is not yet finished, I still have commits (and done commits) that missed the 3.4 freeze (argh, missing free time)

Re: [Libreoffice] release plan : inconsistency between 3.3.3 and 3.4

2011-04-19 Thread Pierre-André Jacquod
Hello, jumping late into the subject, but On 04/11/2011 12:25 PM, Michael Meeks wrote: The plan is (of course), to keep releasing 3.3.x releases as long as people are interested in creating them I suppose[1] - we should come up May I disagree ?? This is not a very predictable use

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-03-25 Thread Pierre-André Jacquod
Hello, On 03/25/2011 10:12 PM, Caolán McNamara wrote: On Fri, 2011-03-25 at 22:09 +0100, Pierre-André Jacquod wrote: something... Hopefully my tests are good And make check was successful,.. at last :- ) in case you're relying on it as some oracle :-) No, the other way around: I run

Re: [Libreoffice] -Woverloaded-virtual

2011-03-25 Thread Pierre-André Jacquod
Hello, On 03/25/2011 02:13 PM, Lubos Lunak wrote: On Friday 25 of March 2011, Caolán McNamara wrote: argh!, I meant to say then things are *not* too bad, not *too* bad. I mean that's far less that I would have feared, quite manageable. Ok. In that case, if there are no objections, I'll

Re: [Libreoffice] [PUSHED] [PATCH] Remove commented out code

2011-03-08 Thread Pierre-André Jacquod
Hello, all seems to me OK, then I pushed. Thanks regards Pierre-André On 03/08/2011 12:19 PM, Bálint Dózsa wrote: Hi, I have removed some commented out code form// //xmloff/. My code is under the LGPLv3+/MPL dual license. Regards, Balint Dozsa

Re: [Libreoffice] Remove using namespace ::rtl

2011-03-06 Thread Pierre-André Jacquod
Hello, Finally since I'm not sure for the moment about what must be done on using namespace com::sun::star::uno, I did the work on binfilters. Thanks regards Pierre-André ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] [PATCH] [PUSHED] Easy Hacks: Translation of Comments from German to English

2011-03-06 Thread Pierre-André Jacquod
Hello, thanks, just changed a typo best regards Pierre-André On 03/06/2011 04:10 PM, Daniel Di Marco wrote: Hi, I translated some more comments. The patch is attached. Cheers, Daniel ___ LibreOffice mailing list

Re: [Libreoffice] Remove using namespace ::rtl

2011-03-05 Thread Pierre-André Jacquod
Hello, Even if binfilters is going to be extracted from LO, doesn't it worth I am doing, this, leting it be only an import filter. to purge using namespace ::rtl from it (I think about the people I think that when cross-module cleaning is done, this is worth to do it also within binfilter: to

Re: [Libreoffice] [PUSHED][PATCH]Cleanup comments

2011-02-28 Thread Pierre-André Jacquod
Hello, pushed, thanks, Maybe not forgetting the [patch] tag in subject will help not to miss your submission. best regards On 02/27/2011 04:51 PM, Arnaud Versini wrote: Hi, This patch remove some useless comments in msfilter. Thanks -- Arnaud Versini

Re: [Libreoffice] Nonsense comments?

2011-02-25 Thread Pierre-André Jacquod
On 02/25/2011 09:46 PM, Caolán McNamara wrote: po files can have translator-comments in them to help translators about ambiguous terms/words, while the .src/.sdf format doesn't though, translation with gettext would support this with comment using key-words / tags. Key words are configurable,

Re: [Libreoffice] Comment-translation of writer/sw/source/ui/config

2011-02-24 Thread Pierre-André Jacquod
On 02/24/2011 08:33 PM, Kohei Yoshida wrote: On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: Martin i think it would be easier as well as not to end up having ur email black listed for sending out large amounts of emails, but if its for a single module i would attach them all in

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-02-16 Thread Pierre-André Jacquod
Hello, after quite a long time, I have done a push again concerning this topic. Sorry, I was very busy at work and had barely the time to go ahead. Here is the following work in cleaning within binfilter/bf_sw the code allowing to write in StarWriter format. Without touching dependencies outside

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-01-24 Thread Pierre-André Jacquod
Hello, On 01/24/2011 03:43 PM, Caolán McNamara wrote: You also needed to adjust the smoketest make check because that has a save as staroffice binary file format test in it. I noticed this failed this morning and bodged it up to work again. Oops, sorry, I was not aware of it. Could you just

Re: [Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-01-24 Thread Pierre-André Jacquod
Hello, Wonderful :-) do you want help with this ? we could add an easy hack, and ask people to contact you, for impress / calc etc. Thanks for this point. I will think if this is easily feasible. But I am still myself on the (intensive) learning part, so I currently do not feel me yet

[Libreoffice] Announcement: StarOffice file-format not available any more for saving

2011-01-23 Thread Pierre-André Jacquod
Hello, from now I have started to delete within binfilter the code allowing to *save* using the StarOffice file format. The import (read) is still possible and will remain. Bye bye saving sdw, sxw This will of course not happens in one go... With this push, I have done the following

[Libreoffice] error compiling in libs-gui/canevas

2011-01-17 Thread Pierre-André Jacquod
hello, there is an error compiling canevas: the reason: in vcl/inc/vcl/sysdata.hxx there has been a change at line 125: -void* pRenderFormat; // render format for drawable +void* pXRenderFormat; // render format for drawable This produce the error (see below) in canevas compilation.

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

2011-01-14 Thread Pierre-André Jacquod
Hi, On 01/14/2011 07:33 PM, Regina Henschel wrote: Hi all, there is something wrong actually. Removing *Export*-filter is reasonable, but now in LibO RC3 I cannot *read* my SO5 files. Kind regards Regina Up to now, nothing has been committed. On trunk master, all is OK, I just tested it.

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Pierre-André Jacquod
Hi, Does setting #define MDDS_HASH_CONTAINER_STLPORT 1 before #include mdds/mixed_type_matrix.hpp help? I also saw someone having a similar issue in the same exact spot, which I haven't been able to reproduce. Maybe this is related. I had also a problem after having upgraded to mds

[Libreoffice] making binfilter aka StarOffice FileFormat read-only

2010-12-27 Thread Pierre-André Jacquod
Hello, these days, I have tried (and not really with full success) to understand how binfilter works... My goal: since it is an old legacy format, make StarOffice formats read-only, and clean binfilter component of all code used for writing files. Reason: with read-only, you will still be able

Re: [Libreoffice] binfilter and features...

2010-12-08 Thread Pierre-André Jacquod
Hi, There is alright, a phonecon typically once a week or so. maybe we can put this topic on the agenda would be great and you could dial in if its at a suitable time. doing this during free time, I may really depend if the possibility arise or not. But basically, we could think of a kind

[Libreoffice] fighting with debug macros...

2010-12-08 Thread Pierre-André Jacquod
Hello, still trying to learn a bit the code. Compiling without DEBUG on gives some new warnings:- ) This lead me to look at some code construct. Here is in pseudo-code a typical construct I am crossing: var y = ; var x = ; code if ( y MAXVALUE) { ASSERT(x, out of range); // only use

Re: [Libreoffice] binfilter and features...

2010-12-05 Thread Pierre-André Jacquod
On 12/05/2010 12:39 PM, Caolán McNamara wrote: All true. It was just a note that it might be easier, if you have an interest in binfilter, to just take the conservative approach and silence warnings with e.g converting I was thinking of taking a 2 steps approach: first silent warning in a

[Libreoffice] [PATCH 01/16] warning variable unused fix in binfilter bf_sw attr

2010-12-05 Thread Pierre-André Jacquod
Hi, here some patches to suppress warnings within binfilter. I took a - sometimes too - conservative approach for doing this. Hope I did not harm this module regards From 3c2cd665fe8a344626265f6c8a2a3b195556441d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=

[Libreoffice] [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp

2010-12-05 Thread Pierre-André Jacquod
regards From a03ec223cf70c17a1cd6bbf397dc954c8d9d13fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 10:25:53 +0100 Subject: [PATCH 02/16] warning fix unused variable in binfilter bf_sw bastyp ---

[Libreoffice] [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr

2010-12-05 Thread Pierre-André Jacquod
regards From fe0b41fe4378e18478263caf8d09af1f3adafa28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 11:12:21 +0100 Subject: [PATCH 03/16] fix warning unused var in binfilter bf_sw crsr this is fixing warning, not optimizing.

[Libreoffice] [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc

2010-12-05 Thread Pierre-André Jacquod
regards From 76026a3ef610c3b348f2fa514591e452eff3cd8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 14:56:23 +0100 Subject: [PATCH 04/16] warning fix for unused var in binfilter bf_sw doc This is warning removing, not code

[Libreoffice] [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode

2010-12-05 Thread Pierre-André Jacquod
regards From dafaabb2c38990bf4141c6074e15f0ca35d7e160 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 15:19:44 +0100 Subject: [PATCH 05/16] warning fix unused var in binfilter bf_sw docnode only warning removal, not code

[Libreoffice] [PATCH 06/16] warning fix unused var in binfilter bf_sw draw

2010-12-05 Thread Pierre-André Jacquod
regards From eac219396edebdf58deba912b02edac9a7999554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 15:30:11 +0100 Subject: [PATCH 06/16] warning fix unused var in binfilter bf_sw draw ---

[Libreoffice] [PATCH 07/16] fix warning unused var in binfilter bf_sw fields

2010-12-05 Thread Pierre-André Jacquod
regards From 0049d6aa3dd25887c742b51a764776103e67daf8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 15:44:52 +0100 Subject: [PATCH 07/16] fix warning unused var in binfilter bf_sw fields still only fixes, no optimization has

[Libreoffice] [PATCH 09/16] fix warning unused var in binfilter bf_sw ole

2010-12-05 Thread Pierre-André Jacquod
regards From 5a619e9399713a488eeadc484617e630ed9d06ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:02:57 +0100 Subject: [PATCH 09/16] fix warning unused var in binfilter bf_sw ole ---

[Libreoffice] [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io

2010-12-05 Thread Pierre-André Jacquod
regards From 18b052aa37f4adb95f3250de4967b739bd14be11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:07:52 +0100 Subject: [PATCH 10/16] fix warning unused var in binfilter bf_sw sw3io ---

[Libreoffice] [PATCH 11/16] fix warning unused var in binfilter bf_sw swg

2010-12-05 Thread Pierre-André Jacquod
regards From c8861cfc5de23428356c1a5cf6aaed6d2a0eced3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:13:44 +0100 Subject: [PATCH 11/16] fix warning unused var in binfilter bf_sw swg ---

[Libreoffice] [PATCH 12/16] fix warning unused var binfilter bf_sw text

2010-12-05 Thread Pierre-André Jacquod
regards From 22f6a25fcbba5eb41b73436f36a9542b2f898ef4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 20:38:53 +0100 Subject: [PATCH 12/16] fix warning unused var binfilter bf_sw text ---

[Libreoffice] [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore

2010-12-05 Thread Pierre-André Jacquod
regards From 151194c8a68754f9521bd485a9124f6e08f36239 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 21:58:35 +0100 Subject: [PATCH 15/16] fix warning unused var in binfilter - bf_sw unocore trying to stay on the safe side,

[Libreoffice] [PATCH 16/16] removing code due to endless loop

2010-12-05 Thread Pierre-André Jacquod
regards From 6551d69a5fbc85f3af92cada84bf543a083d4453 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 4 Dec 2010 22:05:10 +0100 Subject: [PATCH 16/16] removing code due to endless loop these part of code have been removed. The While(true)

[Libreoffice] binfilter and features...

2010-12-04 Thread Pierre-André Jacquod
Hi, currently trying to reduce the number of warning coming from binfilter, I found quite a lot functions like: func(var x) {} or func(var x) { ASSERT (lksd) }. sometimes func (var x) {return false} Would someone mind if I track down the call of such functions, remove the calls and at the end

[Libreoffice] crossing strange code: a little help

2010-12-04 Thread Pierre-André Jacquod
Hi within filters/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx line 955, I crossed this code construct: if() { . while (TRUE) { DBG_BF_ASSERT(0, STRIP); } } With and without debugging option on, if the if is entered, then this is an endless loop? Does it

[Libreoffice] [PATCH] making binfilter compiling again

2010-12-03 Thread Pierre-André Jacquod
Thanks to review and push it quite quickly if possible. Changes have been done (for RTL_OUSTRING_...) without looking that the namespace rtl is not declared. I did not introduced it but just corrected the entries, since I am not enough familiar to know which is the prefered situation within the

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Pierre-André Jacquod
Beware - I am a newcomer - maybe my point of view is quite wrong due to lack of understanding. But then at least I will understand something better :- ) My first remark: stepping in seems to me to be very difficult despite the very friendly behaviour of people here. un-documented code-base is

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

2010-11-30 Thread Pierre-André Jacquod
regards From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) ---

[Libreoffice] [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc

2010-11-29 Thread Pierre-André Jacquod
regards From 94ae830669bfc1df7b4235c45d0a6a72def30be2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sun, 28 Nov 2010 21:09:30 +0100 Subject: [PATCH 3/5] trivial warning fixes within binfilter bf_sw doc ---

[Libreoffice] [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2)

2010-11-29 Thread Pierre-André Jacquod
regards From 09642903881c193ff01f2801461dcddeae0931ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Mon, 29 Nov 2010 22:13:22 +0100 Subject: [PATCH 5/5] trivial warning cleaning in binfilter - unocore (2) ---

[Libreoffice] [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1)

2010-11-29 Thread Pierre-André Jacquod
regards From f5aac0dd10c586fbcdcd8e6a86e396601db8ad27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Mon, 29 Nov 2010 08:20:37 +0100 Subject: [PATCH 4/5] trivial warning cleaning in binfilter - unocore (1) ---

[Libreoffice] [PATCH 2/7] waring within binfilter - sw3io

2010-11-28 Thread Pierre-André Jacquod
regards From 0735f42a61482b094d054266ea83781ee122c91e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Fri, 26 Nov 2010 21:04:20 +0100 Subject: [PATCH 2/7] waring within binfilter - sw3io delete some compiler warning, some of them due to

[Libreoffice] [PATCH 3/7] binfilter sw3io - further shadowing warnings

2010-11-28 Thread Pierre-André Jacquod
regards From 2b6f503e9a8fc091dcfc216dc12175e646a76a68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Fri, 26 Nov 2010 22:44:38 +0100 Subject: [PATCH 3/7] binfilter sw3io - further shadowing warnings ---

[Libreoffice] [PATCH 4/7] binfilter - sw_sw3style.cxx (shadowing) warnings removal

2010-11-28 Thread Pierre-André Jacquod
regards From 0b31675885126537da8351ba747cd6c6e7ad03fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Sat, 27 Nov 2010 00:06:37 +0100 Subject: [PATCH 4/7] binfilter - sw_sw3style.cxx (shadowing) warnings removal ---

Re: [Libreoffice] [PUSHED] Re: [PATCH 9/9] binfilter sw3io warning fixes

2010-11-26 Thread Pierre-André Jacquod
Hi, First thanks for reviewing, catching my errors and correcting. I have learned a lot. Next time I do so many errors, please reject and I will correct it myself. Michael, I will wait making less errors in changes before requesting an account, if you don't mind. Just a question for: Err, you

[Libreoffice] warnig and coding, need a little help on C++

2010-11-25 Thread Pierre-André Jacquod
Hello, as I said, still in warm up phase and getting back familiar with C++.. So cleaning is a good exercise. I got a compiler warning: filters/binfilter/bf_sw/source/core/para/sw_paratr.cxx:214:26: warning: 'nTemp' may be used uninitialized in this function for this: case MID_DROPCAP_LINES :

[Libreoffice] [PATCH 1/9] suppress warning in binfilters sc_token

2010-11-25 Thread Pierre-André Jacquod
Hello, here some patches in binfilter to remove warnings by compiling... Since some changes could (will) look strange, I submit it in little chunks, often with compiler warning in comment. This may help the reviewer. Hope I did no mistake regards Pierre-André From

  1   2   >