[PATCH] Remove com.sun.star.comp.stoc.RegistryTypeDescriptionProvide...

2013-08-19 Thread Stephan Bergmann (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/5514 to look at the new patch set (#2). Change subject: Remove com.sun.star.comp.stoc.RegistryTypeDescriptionProvider

[PUSHED] Remove com.sun.star.comp.stoc.RegistryTypeDescriptionProvide...

2013-08-19 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5514 -- To view, visit https://gerrit.libreoffice.org/5514 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Turn basebmp::Format into a proper enum

2013-07-12 Thread Stephan Bergmann (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/4856 to look at the new patch set (#2). Change subject: Turn basebmp::Format into a proper enum .. Turn

[PUSHED] Turn basebmp::Format into a proper enum

2013-07-12 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4856 -- To view, visit https://gerrit.libreoffice.org/4856 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Avoid confusing wording in mails requesting a review

2013-07-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4828 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/gerrit-etc refs/changes/28/4828/1 Avoid confusing wording in mails requesting a review Given that NewChange.vm is not only used when user

[PUSHED] fdo#60724 change spelling error REMOVEABLE - REMOVABLE II

2013-05-29 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4078 -- To view, visit https://gerrit.libreoffice.org/4078 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] fdo#63254 UI:Horizontal scroll bar isn't displayed when RTL ...

2013-05-28 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/4024 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/4024 To unsubscribe,

[PATCH libreoffice-4-0] rhbz#961460: Don't needlessly pass URLs through INetURLObjec...

2013-05-24 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4019 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/4019/1 rhbz#961460: Don't needlessly pass URLs through INetURLObject The WebDAV UCP uses https/davs URLs that may

[PATCH libreoffice-3-6] rhbz#961460: Don't needlessly pass URLs through INetURLObjec...

2013-05-24 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4021 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/4021/1 rhbz#961460: Don't needlessly pass URLs through INetURLObject The WebDAV UCP uses https/davs URLs that may

[PUSHED] Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX checkpoint...

2013-05-22 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3894 -- To view, visit https://gerrit.libreoffice.org/3894 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-1] Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX checkpoint...

2013-05-22 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/4003 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/4003/1 Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX checkpoints f218110744cbb2ec79796d886042546e47334cca Get rid

[PATCH] TODO: Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX chec...

2013-05-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3894 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3894/1 TODO: Ensure SolarMutex is locked at DBG_TESTSOLARMUTEX checkpoints f218110744cbb2ec79796d886042546e47334cca

[ABANDONED] Create smart conversion constructor for UNO Reference

2013-05-07 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: Create smart conversion constructor for UNO Reference .. Patch Set 2: Abandoned Merged alternative approach https://gerrit.libreoffice.org/#/c/3699/ now. -- To

[ABANDONED] Proof of concept - conversion operator for uno::Reference

2013-05-07 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: Proof of concept - conversion operator for uno::Reference .. Patch Set 1: Abandoned Merged alternative approach https://gerrit.libreoffice.org/#/c/3699/ now. -- To

[PUSHED] Up-cast conversion constructor for css::uno::Reference

2013-05-07 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3699 Approvals: Stephan Bergmann: Verified; Looks good to me, approved LibreOffice gerrit bot: Verified -- To view, visit

[PATCH] Up-cast conversion constructor for css::uno::Reference

2013-05-06 Thread Stephan Bergmann (via Code Review)
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/3699 to look at the new rebased patch set (#2). Change subject: Up-cast conversion constructor for css::uno::Reference

[PATCH] Up-cast conversion constructor for css::uno::Reference

2013-04-30 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3699 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/3699/1 Up-cast conversion constructor for css::uno::Reference Based on a previous patch by Noel Grandin,

[PATCH libreoffice-4-0] rhbz#954991 Avoid static data (causing trouble at exit)

2013-04-22 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3556 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/3556/1 rhbz#954991 Avoid static data (causing trouble at exit) (cherry picked from commit

[PATCH libreoffice-3-6] rhbz#954991 Avoid static data (causing trouble at exit)

2013-04-22 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3557 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/3557/1 rhbz#954991 Avoid static data (causing trouble at exit) (cherry picked from commit

[PATCH libreoffice-4-0] fdo#63693 Do not force java -d32 for a 64-bit SDK

2013-04-19 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3480 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/3480/1 fdo#63693 Do not force java -d32 for a 64-bit SDK The test to determine JAVA_OPTIONS was already cheesy (e.g.,

[PATCH libreoffice-3-6] fdo#63693 Do not force java -d32 for a 64-bit SDK

2013-04-19 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3481 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/3481/1 fdo#63693 Do not force java -d32 for a 64-bit SDK The test to determine JAVA_OPTIONS was already cheesy (e.g.,

[PUSHED] sal: remove obsolete test/unloading

2013-04-19 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3314 -- To view, visit https://gerrit.libreoffice.org/3314 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] remove unused component_canUnload functions

2013-04-19 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3313 -- To view, visit https://gerrit.libreoffice.org/3313 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] Let juhx.dll export undecorated symbols on Windows

2013-04-18 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3455 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3455/1 Let juhx.dll export undecorated symbols on Windows ...otherwise preload.cxx in juh.dll will not be able to find

[PATCH libreoffice-3-6] Let juhx.dll export undecorated symbols on Windows

2013-04-18 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3459 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/3459/1 Let juhx.dll export undecorated symbols on Windows ...otherwise preload.cxx in juh.dll will not be able to find

[PUSHED] API CHANGE: remove some of useless rtl/unload.h functionalit...

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3317 -- To view, visit https://gerrit.libreoffice.org/3317 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] do not use deprecated rtl_registerModuleForUnloading

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3315 -- To view, visit https://gerrit.libreoffice.org/3315 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] stoc: do not use rtl/unload.h functionality

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3316 -- To view, visit https://gerrit.libreoffice.org/3316 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] rhbz#867808 Do not throw RuntimeException by pointer

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3418 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3418/1 rhbz#867808 Do not throw RuntimeException by pointer (cherry picked from commit

[PATCH libreoffice-3-6] rhbz#867808 Do not throw RuntimeException by pointer

2013-04-16 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3420 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/3420/1 rhbz#867808 Do not throw RuntimeException by pointer (cherry picked from commit

[PUSHED] do not set soversion for private ure libraries

2013-04-12 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3351 -- To view, visit https://gerrit.libreoffice.org/3351 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Introduce characters utilities in rtl/character.hxx

2013-04-10 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3224 -- To view, visit https://gerrit.libreoffice.org/3224 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] Adapt code to IllegalArgumentException being a RuntimeExcept...

2013-04-02 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3174 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/3174/1 Adapt code to IllegalArgumentException being a RuntimeException ...since

[PUSHED] Handle oveflow in O(U)String::toInt() functions

2013-03-25 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3029 -- To view, visit https://gerrit.libreoffice.org/3029 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] Missing dependency of librelogo on writer

2013-03-21 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2897 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/2897/1 Missing dependency of librelogo on writer ...at least due to dependency of librelogo.xcd on writer.xcd, see

[PATCH libreoffice-4-0-2] Missing dependency of librelogo on writer

2013-03-21 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2898 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/2898/1 Missing dependency of librelogo on writer ...at least due to dependency of librelogo.xcd on writer.xcd, see

[ABANDONED] this looks better

2013-03-20 Thread Stephan Bergmann (via Code Review)
Stephan Bergmann has abandoned this change. Change subject: this looks better .. Patch Set 1: Abandoned already seen committed as 5e2fd3b3c96362368a516f59555a42450126be85 -- To view, visit https://gerrit.libreoffice.org/2874

[PATCH libreoffice-4-0] deb#703486: Keep migrating more user extensions after one fa...

2013-03-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2877 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2877/1 deb#703486: Keep migrating more user extensions after one failed (cherry picked from commit

[PATCH libreoffice-4-0-2] deb#703486: Keep migrating more user extensions after one fa...

2013-03-20 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2878 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/2878/1 deb#703486: Keep migrating more user extensions after one failed (cherry picked from commit

[PUSHED] odk: do not pack unused component.map file

2013-03-19 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2838 -- To view, visit https://gerrit.libreoffice.org/2838 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH libreoffice-4-0] compareToAscii(RTL_CONSTASCII_STRINGPARAM(s)) != compareToAs...

2013-03-15 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2760 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/2760/1 compareToAscii(RTL_CONSTASCII_STRINGPARAM(s)) != compareToAscii(s) ...broken with

[PATCH] Tentative fix to make JunitTest_sc_unopai work again

2013-03-15 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2740 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/2740/1 Tentative fix to make JunitTest_sc_unopai work again ...which started to fail reproducibly at least for me with

[PATCH libreoffice-3-6] fdo#54275: Fix GVFS UCP, so saving docs works again

2013-03-14 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2729 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2729/1 fdo#54275: Fix GVFS UCP, so saving docs works again Similar to 8722f0e7ef690205d042c8a6b1fdf342a34ecbe1

[PATCH libreoffice-4-0] fdo#54275: Fix GVFS UCP, so saving docs works again

2013-03-14 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2730 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/2730/1 fdo#54275: Fix GVFS UCP, so saving docs works again Similar to 8722f0e7ef690205d042c8a6b1fdf342a34ecbe1

[PATCH libreoffice-4-0-2] fdo#54275: Fix GVFS UCP, so saving docs works again

2013-03-14 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2731 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/2731/1 fdo#54275: Fix GVFS UCP, so saving docs works again Similar to 8722f0e7ef690205d042c8a6b1fdf342a34ecbe1

[PATCH libreoffice-4-0] rhbz#895690: Make GIO UCP less brittle, so saving docs works...

2013-03-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2696 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/2696/1 rhbz#895690: Make GIO UCP less brittle, so saving docs works again 966d20e35d5a2be2fce6c204af5c156c3ead7063

[PATCH libreoffice-3-6] rhbz#895690: Make GIO UCP less brittle, so saving docs works...

2013-03-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2697 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/2697/1 rhbz#895690: Make GIO UCP less brittle, so saving docs works again 966d20e35d5a2be2fce6c204af5c156c3ead7063

[PATCH libreoffice-4-0-2] rhbz#895690: Make GIO UCP less brittle, so saving docs works...

2013-03-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2698 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/2698/1 rhbz#895690: Make GIO UCP less brittle, so saving docs works again 966d20e35d5a2be2fce6c204af5c156c3ead7063

[PATCH libreoffice-4-0-2] -Werror=shadow/-Werror=unused-variable

2013-03-13 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2699 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/2699/1 -Werror=shadow/-Werror=unused-variable ...picking the corresponding fix from

[PATCH libreoffice-4-0] fdo#60701: Properly quote shell parameter expansions

2013-03-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2661 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/2661/1 fdo#60701: Properly quote shell parameter expansions (cherry picked from commit

[PATCH libreoffice-3-6] fdo#60701: Properly quote shell parameter expansions

2013-03-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2666 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2666/1 fdo#60701: Properly quote shell parameter expansions (cherry picked from commit

[PATCH libreoffice-4-0] rhbz#915743: Avoid potentially blocking autocompletion for n...

2013-03-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2669 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/2669/1 rhbz#915743: Avoid potentially blocking autocompletion for non file URLs In theory, the logic of how

[PATCH libreoffice-3-6] rhbz#915743: Avoid potentially blocking autocompletion for n...

2013-03-11 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2670 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/2670/1 rhbz#915743: Avoid potentially blocking autocompletion for non file URLs In theory, the logic of how

[PUSHED] Simplify and speed-up logic for copying data

2013-03-08 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2523 Approvals: Stephan Bergmann: Verified; Looks good to me, approved Jørgen Nystad: Looks good to me, but someone else must approve

[PUSHED] simplify compareTo (now correct)

2013-03-08 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2591 -- To view, visit https://gerrit.libreoffice.org/2591 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] fdo#46808, Adapt UNO services to the new style, Part 1-2

2013-03-08 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2146 -- To view, visit https://gerrit.libreoffice.org/2146 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] fdo#60724 change spelling error REMOVEABLE - REMOVABLE

2013-03-06 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2505 -- To view, visit https://gerrit.libreoffice.org/2505 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] fix for fdo#61801

2013-03-05 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2553 Approvals: Stephan Bergmann: Verified; Looks good to me, approved Kohei Yoshida: Looks good to me, but someone else must approve -- To

[PATCH] Fiddle with hard-coded neon config.h to support USE_NONBLOCK...

2013-03-01 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2492 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2492/1 Fiddle with hard-coded neon config.h to support USE_NONBLOCKING_CONNECT ...see the condition in neon's

[PUSHED] Fiddle with hard-coded neon config.h to support USE_NONBLOCK...

2013-03-01 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2492 Approvals: Stephan Bergmann: Verified; Looks good to me, approved LibreOffice gerrit bot: Verified -- To view, visit

[PATCH libreoffice-4-0] rhbz#908674: Adapt rtl::Allocator::construct to C++11

2013-02-15 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2166 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/2166/1 rhbz#908674: Adapt rtl::Allocator::construct to C++11 ...otherwise, at least with some --with-system-boost

[PATCH libreoffice-3-6] rhbz#908674: Adapt rtl::Allocator::construct to C++11

2013-02-15 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2167 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/2167/1 rhbz#908674: Adapt rtl::Allocator::construct to C++11 ...otherwise, at least with some --with-system-boost

[PUSHED] WaE: strict-aliasing issues

2013-02-12 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2105 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2105 To unsubscribe,

[PUSHED libreoffice-4-0] Package the right pixman and cairo

2013-02-09 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2051 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2051 To unsubscribe,

[PATCH libreoffice-4-0] fdo#60139: Rename bundled extensions's Lightproof service im...

2013-02-08 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2032 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/dictionaries refs/changes/32/2032/1 fdo#60139: Rename bundled extensions's Lightproof service implementation names ... from

[PATCH libreoffice-3-6] fdo#60139: Rename bundled extensions's Lightproof service im...

2013-02-08 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2033 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/dictionaries refs/changes/33/2033/1 fdo#60139: Rename bundled extensions's Lightproof service implementation names ... from

[PATCH libreoffice-3-6] fdo#60353: Avoid impl name clashes with other PDF import ext...

2013-02-07 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2026 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/2026/1 fdo#60353: Avoid impl name clashes with other PDF import extensions This is only relevant for LO 3.6, as LO 4

[PATCH libreoffice-4-0] fdo#59025: Missing dependency

2013-02-06 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2002 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/2002/1 fdo#59025: Missing dependency (WriterWindowState.xcs is in writer.xcd) Change-Id:

[PATCH libreoffice-3-6] Cleanly remove an extension again that cannot be activated w...

2013-02-05 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1995 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/1995/1 Cleanly remove an extension again that cannot be activated while installing it ...otherwise, it will needlessly

[PATCH libreoffice-3-6] Cleanly remove components from rdb again that fail during li...

2013-02-05 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1996 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/1996/1 Cleanly remove components from rdb again that fail during live insertion Such failure happens e.g. for

[PATCH libreoffice-4-0] Avoid a SAL_WARN caused by IllegalArgumentEx now being a Run...

2013-02-05 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1997 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1997/1 Avoid a SAL_WARN caused by IllegalArgumentEx now being a RuntimeEx Change-Id:

[PATCH libreoffice-4-0] Cleanly remove an extension again that cannot be activated w...

2013-02-05 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1998 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1998/1 Cleanly remove an extension again that cannot be activated while installing it ...otherwise, it will needlessly

[PUSHED] Strings: boolean() as a replacement for valueOf(sal_Bool)

2013-02-04 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1981 -- To view, visit https://gerrit.libreoffice.org/1981 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

Change in core[libreoffice-4-0]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-29 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1912 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1912 To unsubscribe,

Change in core[libreoffice-4-0]: Do not call putenv with a temporary string argument

2013-01-29 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1917 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1917/1 Do not call putenv with a temporary string argument These bad calls to putenv suddenly caused the buildIdFile

Change in core[libreoffice-4-0-0]: Do not call putenv with a temporary string argument

2013-01-29 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1918 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1918/1 Do not call putenv with a temporary string argument These bad calls to putenv suddenly caused the buildIdFile

Change in core[master]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1909 Approvals: Stephan Bergmann: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1909 To unsubscribe,

Change in core[libreoffice-4-0]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1912 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1912/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6

Change in core[libreoffice-4-0-0]: Resolving crash in wizards fdo#59931 by NULL checking

2013-01-28 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1913 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1913/1 Resolving crash in wizards fdo#59931 by NULL checking Change-Id: Iccc3f3b2913f21a3831ce55c706aa4dd1da53ad6

[PATCH] Change in core[libreoffice-4-0]: fdo#59728: Fix encoding of .py files as UTF-8 for Python 3

2013-01-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1829 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1829/1 fdo#59728: Fix encoding of .py files as UTF-8 for Python 3 ...where it could default to something like CP 1252

[PATCH] Change in core[libreoffice-4-0-0]: fdo#59728: Fix encoding of .py files as UTF-8 for Python 3

2013-01-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1836 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/1836/1 fdo#59728: Fix encoding of .py files as UTF-8 for Python 3 ...where it could default to something like CP 1252

[PATCH] Change in core[libreoffice-4-0]: fdo#57061: Use a new MIGRATION4 flag file for profile migrat...

2013-01-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1867 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1867/1 fdo#57061: Use a new MIGRATION4 flag file for profile migration LO 3 - 4 ...to avoid missing migrations on

[PATCH] Change in core[libreoffice-4-0-0]: fdo#57061: Use a new MIGRATION4 flag file for profile migrat...

2013-01-25 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1868 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/1868/1 fdo#57061: Use a new MIGRATION4 flag file for profile migration LO 3 - 4 ...to avoid missing migrations on

[PATCH] Change in core[libreoffice-4-0-0]: Add link to additional sdk-examples

2013-01-23 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1819 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1819/1 Add link to additional sdk-examples Change-Id: Ifcc3594273de3507ec9b208e9e762bed0f969d72 (cherry picked from

[PATCH] Change in core[libreoffice-4-0]: Add link to additional sdk-examples

2013-01-22 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1808 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/1808/1 Add link to additional sdk-examples Change-Id: Ifcc3594273de3507ec9b208e9e762bed0f969d72 (cherry picked from

[PATCH] Change in core[libreoffice-3-6]: Add link to additional sdk-examples

2013-01-22 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1809 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1809/1 Add link to additional sdk-examples (cherry picked from commit 664e559abd472bf2b427e2c01144ea39fb5bc02b)

[PATCH] Detect SvStream::operator calls with bool args w/o using -...

2013-01-21 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1798 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1798/1 Detect SvStream::operator calls with bool args w/o using -Wsign-promo ...as -Wsign-promo caused other problems

[PATCH] Change in core[libreoffice-3-6]: Related fdo#33484: Terminate OfficeIPCThread by closing the ...

2013-01-17 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1734 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/1734/1 Related fdo#33484: Terminate OfficeIPCThread by closing the accepting pipe ... (and setting mbDowning to

[PATCH] Change in core[libreoffice-4-0]: fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

2013-01-16 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1719 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1719/1 fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure ...in osl_getFileStatus et al, it would leave the

[PATCH] Change in core[libreoffice-3-6]: fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure

2013-01-16 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1720 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1720/1 fdo#58415: Don't ignore osl_getFileURLFromSystemPath failure ...in osl_getFileStatus et al, it would leave the

[PATCH] Change in core[libreoffice-4-0]: fdo#59248: Remove remaining dangling view of ViewHandler.py

2013-01-14 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1670 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/1670/1 fdo#59248: Remove remaining dangling view of ViewHandler.py ...that had been left behind by

[PUSHED] Remove useless callback in unix socket implementation

2013-01-11 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1633 -- To view, visit https://gerrit.libreoffice.org/1633 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Change in core[libreoffice-4-0]: resolved fdo#58503 restore awkward handling of empty locale ...

2013-01-10 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1616 -- To view, visit https://gerrit.libreoffice.org/1616 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] turn some OSL_ENSURE into SAL_WARN_IF to avoid warnings abou...

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1600 -- To view, visit https://gerrit.libreoffice.org/1600 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PATCH] Change in core[libreoffice-4-0]: Always default-select English dictionary

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1614 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/1614/1 Always default-select English dictionary It was discovered that on a Russian Windows, by default only Russian

[PATCH] Change in core[libreoffice-3-6]: Always default-select English dictionary

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1613 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1613/1 Always default-select English dictionary It was discovered that on a Russian Windows, by default only Russian

[PATCH] Change in core[libreoffice-4-0]: Fix oo_sdk_ure_home calculation in SDK's cfgWin.js

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1620 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1620/1 Fix oo_sdk_ure_home calculation in SDK's cfgWin.js This appears to be broken at least since

[PATCH] Change in core[libreoffice-3-6]: Fix oo_sdk_ure_home calculation in SDK's cfgWin.js

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1619 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1619/1 Fix oo_sdk_ure_home calculation in SDK's cfgWin.js This appears to be broken at least since

[PUSHED] Add ability to send SAL_* messages to syslog

2012-12-20 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1417 -- To view, visit https://gerrit.libreoffice.org/1417 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] API CHANGE: Remove useless deprecated rtl/memory.h

2012-12-17 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1268 -- To view, visit https://gerrit.libreoffice.org/1268 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

  1   2   >