[PUSHED] fdo#60924 autoinstall - gbuild/scp2: Move more libs to OOO

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5571

Approvals:
  LibreOffice gerrit bot: Verified
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5571
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I973a66c6f805727cfaa5a5663ce4a9c200412a66
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[MERGE FAILED] enable binary package option for a set of 'stable' libraries

[Thorsten Behrens (via Code Review)]

Thorsten Behrens has submitted this change and it FAILED to merge.

Change subject: enable binary package option for a set of 'stable' libraries
..


Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for 
review.

-- 
To view, visit https://gerrit.libreoffice.org/4765
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merge-failed
Gerrit-Change-Id: I8924ba22d178aa4d8e500ae3f484af654a37e87e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Help button added to the aboutconfigvalue dialog

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/5421

Approvals:
  LibreOffice gerrit bot: Verified
  Thorsten Behrens: Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/5421
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id47fafe67c20de5b163f7a4a04d2475297664c54
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Efe Gürkan Yalaman efeyala...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] tb3: tinderbox coordinator

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4166

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4166
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5364dbb25cebd160a967995e2c96fad8fddd7e0b
Gerrit-PatchSet: 3
Gerrit-Project: buildbot
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Small (hopefully non-controversial) changes to the existing ...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4308

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4308
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I402448ef4ea77633fe4e1ad5d5f93952efb495af
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stefan Knorr heinzless...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] remove ShapeList::getNextShape(SdrObject* pObj)

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/4132

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/4132
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3896af2247f348153d62f2bcdd207c5a75239689
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: mhofmann bor...@web.de
Gerrit-Reviewer: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix fdo#64579 Don't assume dsp:dataModelExt has valid Drawin...

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3910

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3910/1

Fix fdo#64579 Don't assume dsp:dataModelExt has valid DrawingML.

Just don't assume the DSP_TOKEN( spTree ) was seen in input.

Change-Id: Iaabdcafdfcfc995198c1265e975df4dde8e0a39c
(cherry picked from commit 0f15a477aaba2f69a13c0bc61c5c8c7a47314680)
---
M oox/source/ppt/extdrawingfragmenthandler.cxx
1 file changed, 5 insertions(+), 2 deletions(-)



diff --git a/oox/source/ppt/extdrawingfragmenthandler.cxx 
b/oox/source/ppt/extdrawingfragmenthandler.cxx
index f065415..dc62bd6 100644
--- a/oox/source/ppt/extdrawingfragmenthandler.cxx
+++ b/oox/source/ppt/extdrawingfragmenthandler.cxx
@@ -86,8 +86,11 @@
 }
 void SAL_CALL ExtDrawingFragmentHandler::endDocument() throw 
(::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException)
 {
-mpShapePtr-moveAllToPosition( mpOrgShapePtr-getPosition() );
-mpShapePtr-setName( mpOrgShapePtr-getName() );
+if( mpShapePtr )
+{
+mpShapePtr-moveAllToPosition( mpOrgShapePtr-getPosition() );
+mpShapePtr-setName( mpOrgShapePtr-getName() );
+}
 }
 
 } }

-- 
To view, visit https://gerrit.libreoffice.org/3910
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaabdcafdfcfc995198c1265e975df4dde8e0a39c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Janitorial: indent code correctly

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3867

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3867
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9fcbeb5f60df1a977347076dac82d4b5f7aba2c1
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix fdo#40421 Take current clip into account for shape bound...

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3815

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/3815/1

Fix fdo#40421 Take current clip into account for shape bounds.

Seems with the extensive drawinglayer rework, we now get bitmap
fills rendered via clip polygon and subsequent bitmap tiles. To
get the true bound rect of the current metaaction, clip it against
outdev's clip region bounds (as some reasonably cheap best-effort
approximation).

Change-Id: I4ecf04e2d94da21acc97362a1a65a965c7176077
---
M vcl/source/gdi/print2.cxx
1 file changed, 8 insertions(+), 1 deletion(-)



diff --git a/vcl/source/gdi/print2.cxx b/vcl/source/gdi/print2.cxx
index 5f7ccad..3111ba3 100644
--- a/vcl/source/gdi/print2.cxx
+++ b/vcl/source/gdi/print2.cxx
@@ -627,7 +627,14 @@
 }
 
 if( !aActionBounds.IsEmpty() )
-return rOut.LogicToPixel( aActionBounds );
+{
+// fdo#40421 limit current action's output to clipped area
+if( rOut.IsClipRegion() )
+return rOut.LogicToPixel(
+rOut.GetClipRegion().GetBoundRect().Intersection( 
aActionBounds ) );
+else
+return rOut.LogicToPixel( aActionBounds );
+}
 else
 return Rectangle();
 }

-- 
To view, visit https://gerrit.libreoffice.org/3815
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ecf04e2d94da21acc97362a1a65a965c7176077
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#64150 don't segfault when there is no line

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3765

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3765
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#60780, refactor Save a Copy and fix

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3355

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3355
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I876dbe17e43b26a43f29e797fdb157e31889ee1e
Gerrit-PatchSet: 6
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ádám Király kiraly.adam.cs...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi
Gerrit-Reviewer: Ádám Király kiraly.adam.cs...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] fdo#53163 fix hatching for objects with curves

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3660

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3660
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec9d6aceb23da986fe2d2414dc2e7fd4bf835b4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-3-6] fdo#53163 fix hatching for objects with curves

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3661

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3661
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec9d6aceb23da986fe2d2414dc2e7fd4bf835b4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix fdo#64062 - can't assume para styles to be there.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3694

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/3694/1

Fix fdo#64062 - can't assume para styles to be there.

Change-Id: I5da53ff44fdf00ec6c0fdf1a722f806971b6683a
---
M xmloff/source/text/txtimp.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index b48225a..3abafb5 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -1803,7 +1803,7 @@
  style, if it has no direct list style property and (if 
exists) the
  automatic paragraph style has also no direct list style set.
 */
-if (m_pImpl-m_xParaStyles-hasByName(sStyleName))
+if (m_pImpl-m_xParaStyles.is()  
m_pImpl-m_xParaStyles-hasByName(sStyleName))
 {
 bool bOutlineStyleCandidate( false );
 

-- 
To view, visit https://gerrit.libreoffice.org/3694
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5da53ff44fdf00ec6c0fdf1a722f806971b6683a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Proof of concept - conversion operator for uno::Reference

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3698

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/3698/1

Proof of concept - conversion operator for uno::Reference

Change-Id: I589b57c0a54524460fc8518a456dc09797c3567a
---
M include/com/sun/star/uno/Reference.h
M include/com/sun/star/uno/Reference.hxx
2 files changed, 56 insertions(+), 5 deletions(-)



diff --git a/include/com/sun/star/uno/Reference.h 
b/include/com/sun/star/uno/Reference.h
index 94551a0..2b776b8 100644
--- a/include/com/sun/star/uno/Reference.h
+++ b/include/com/sun/star/uno/Reference.h
@@ -19,6 +19,8 @@
 #ifndef _COM_SUN_STAR_UNO_REFERENCE_H_
 #define _COM_SUN_STAR_UNO_REFERENCE_H_
 
+#include boost/config.hpp // for BOOST_NO_MEMBER_TEMPLATE_FRIENDS macro
+
 #include rtl/alloc.h
 
 
@@ -54,10 +56,6 @@
 class BaseReference
 {
 protected:
-/** the interface pointer
-*/
-XInterface * _pInterface;
-
 /** Queries given interface for type rType.
 
 @param pInterface interface pointer
@@ -77,6 +75,19 @@
 inline static XInterface * SAL_CALL iquery_throw( XInterface * pInterface, 
const Type  rType )
 SAL_THROW( (RuntimeException) );
 #endif
+
+// if member template friends don't work, make protected _pInterface
+// public, to allow template copy constructor from Reference to access
+// them.
+#ifndef BOOST_NO_MEMBER_TEMPLATE_FRIENDS
+templatetypename T friend class Reference;
+#else
+public:
+#endif
+
+/** the interface pointer
+*/
+XInterface * _pInterface;
 
 public:
 /** Gets interface pointer. This call does not acquire the interface.
@@ -332,6 +343,15 @@
 inline Reference( interface_type * pInterface, UnoReference_SetThrow dummy 
) SAL_THROW( (RuntimeException) );
 #endif
 
+/* Constructor: copy-construct from derived interface
+
+   @param rRef
+   Interface reference that must be convertible to interface_type
+   (typically, this implies that interface_type is a basetype of
+   the passed type)
+ */
+template class Ifc  inline Reference( const ReferenceIfc rRef );
+
 /** Cast operator to Reference XInterface : Reference objects are binary 
compatible and
 any interface must be derived from com.sun.star.uno.XInterface.
 This a useful direct cast possibility.
@@ -485,6 +505,18 @@
 */
 inline Reference interface_type   SAL_CALL operator = ( const 
Reference interface_type   rRef ) SAL_THROW(());
 
+/** Assignment operator for derived interfaces: Acquires given
+interface reference and sets reference.  An interface already
+set will be released.
+
+@param rRef
+Interface reference that must be convertible to interface_type
+(typically, this implies that interface_type is a basetype of
+the passed type)
+ */
+template class Ifc 
+inline Reference interface_type   SAL_CALL operator = ( const 
ReferenceIfc rRef );
+
 /** Queries given interface reference for type interface_type.
 
 @param rRef interface reference
diff --git a/include/com/sun/star/uno/Reference.hxx 
b/include/com/sun/star/uno/Reference.hxx
index aa39810..9b84809 100644
--- a/include/com/sun/star/uno/Reference.hxx
+++ b/include/com/sun/star/uno/Reference.hxx
@@ -193,7 +193,16 @@
 _pInterface = castToXInterface( iset_throw( pInterface ) );
 }
 #endif
-
+//__
+template class interface_type 
+template class Ifc 
+inline Reference interface_type ::Reference( const ReferenceIfc rRef )
+{
+interface_type* pTmp = reinterpret_cast Ifc* (rRef._pInterface);
+_pInterface = pTmp;
+if (_pInterface)
+_pInterface-acquire();
+}
 
//__
 template class interface_type 
 inline void Reference interface_type ::clear() SAL_THROW(())
@@ -332,6 +341,16 @@
 set( castFromXInterface( rRef._pInterface ) );
 return *this;
 }
+//__
+template class interface_type 
+template class Ifc 
+inline Reference interface_type   Reference interface_type ::operator = (
+const ReferenceIfc rRef )
+{
+interface_type* pTmp = reinterpret_cast Ifc* (rRef._pInterface);
+set( pTmp );
+return *this;
+}
 
 
//__
 template class interface_type 

-- 
To view, visit https://gerrit.libreoffice.org/3698
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I589b57c0a54524460fc8518a456dc09797c3567a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list

[PATCH libreoffice-4-0] Make uno any types explicit.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3703

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/3703/1

Make uno any types explicit.

This was previously sticking long types into Any - which yields
different sal types on different archs.

Change-Id: Ifc7a60a052b57f8a83739ec11a97ab32aaa2ee7c
---
M svx/source/unodraw/unoshape.cxx
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index dc41794..4c9a52e 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -2770,7 +2770,7 @@
 case OWN_ATTR_GLUEID_HEAD:
 case OWN_ATTR_GLUEID_TAIL:
 {
-rValue = pEdgeObj-getGluePointIndex( pProperty-nWID == 
OWN_ATTR_GLUEID_HEAD );
+rValue = (sal_Int32)pEdgeObj-getGluePointIndex( 
pProperty-nWID == OWN_ATTR_GLUEID_HEAD );
 break;
 }
 case OWN_ATTR_EDGE_POLYPOLYGONBEZIER:
@@ -2850,11 +2850,11 @@
 }
 
 case SDRATTR_ROTATEANGLE:
-rValue = mpObj-GetRotateAngle();
+rValue = (sal_Int32)mpObj-GetRotateAngle();
 break;
 
 case SDRATTR_SHEARANGLE:
-rValue = mpObj-GetShearAngle();
+rValue = (sal_Int32)mpObj-GetShearAngle();
 break;
 
 case SDRATTR_OBJMOVEPROTECT:

-- 
To view, visit https://gerrit.libreoffice.org/3703
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc7a60a052b57f8a83739ec11a97ab32aaa2ee7c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix import of images from pdf.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3690

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/3690/1

Fix import of images from pdf.

Seems poppler changed outputdev virt func signatures with version
12, so with system poppler, we never got any image import functions
called. Added override annotation to prevent this from happening in
the future.

Change-Id: I565de80ce218e831e276d3a1d88ded3baee876e7
---
M sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
M sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
2 files changed, 89 insertions(+), 72 deletions(-)



diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx 
b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
index 765d0be..03adf89 100644
--- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
+++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
@@ -836,6 +836,9 @@
 
 void PDFOutDev::drawImageMask(GfxState* pState, Object*, Stream* str,
   int width, int height, GBool invert,
+#if POPPLER_CHECK_VERSION(0, 12, 0)
+  GBool /*interpolate*/,
+#endif
   GBool /*inlineImg*/ )
 {
 OutputBuffer aBuf; initBuf(aBuf);
@@ -862,6 +865,9 @@
 
 void PDFOutDev::drawImage(GfxState*, Object*, Stream* str,
   int width, int height, GfxImageColorMap* colorMap,
+#if POPPLER_CHECK_VERSION(0, 12, 0)
+  GBool /*interpolate*/,
+#endif
   int* maskColors, GBool /*inlineImg*/ )
 {
 OutputBuffer aBuf; initBuf(aBuf);
@@ -908,9 +914,16 @@
 void PDFOutDev::drawMaskedImage(GfxState*, Object*, Stream* str,
 int width, int height,
 GfxImageColorMap* colorMap,
+#if POPPLER_CHECK_VERSION(0, 12, 0)
+GBool /*interpolate*/,
+#endif
 Stream* maskStr,
 int maskWidth, int maskHeight,
-GBool maskInvert)
+GBool maskInvert
+#if POPPLER_CHECK_VERSION(0, 12, 0)
+, GBool /*maskInterpolate*/
+#endif
+   )
 {
 OutputBuffer aBuf; initBuf(aBuf);
 printf( drawImage %d %d 0, width, height );
@@ -921,9 +934,16 @@
 void PDFOutDev::drawSoftMaskedImage(GfxState*, Object*, Stream* str,
 int width, int height,
 GfxImageColorMap* colorMap,
+#if POPPLER_CHECK_VERSION(0, 12, 0)
+GBool /*interpolate*/,
+#endif
 Stream* maskStr,
 int maskWidth, int maskHeight,
-GfxImageColorMap* maskColorMap )
+GfxImageColorMap* maskColorMap
+#if POPPLER_CHECK_VERSION(0, 12, 0)
+, GBool /*maskInterpolate*/
+#endif
+   )
 {
 OutputBuffer aBuf; initBuf(aBuf);
 printf( drawImage %d %d 0, width, height );
diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx 
b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
index e5e48fc..c0977cb7 100644
--- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
+++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx
@@ -46,6 +46,12 @@
 #pragma warning(pop)
 #endif
 
+#if HAVE_CXX11_OVERRIDE
+#define SAL_OVERRIDE override
+#else
+#define SAL_OVERRIDE
+#endif
+
 #include boost/unordered_map.hpp
 #include vector
 
@@ -157,125 +163,116 @@
 
 // Does this device use upside-down coordinates?
 // (Upside-down means (0,0) is the top left corner of the page.)
-virtual GBool upsideDown() { return gTrue; }
+virtual GBool upsideDown() SAL_OVERRIDE { return gTrue; }
 
 // Does this device use drawChar() or drawString()?
-virtual GBool useDrawChar() { return gTrue; }
+virtual GBool useDrawChar() SAL_OVERRIDE { return gTrue; }
 
 // Does this device use beginType3Char/endType3Char?  Otherwise,
 // text in Type 3 fonts will be drawn with drawChar/drawString.
-virtual GBool interpretType3Chars() { return gFalse; }
+virtual GBool interpretType3Chars() SAL_OVERRIDE { return gFalse; }
 
 // Does this device need non-text content?
-virtual GBool needNonText() { return gTrue; }
+virtual GBool needNonText() SAL_OVERRIDE { return gTrue; }
 
 //- initialization and control
 
 // Set default transform matrix.
-virtual void setDefaultCTM(double *ctm);
+virtual void setDefaultCTM(double *ctm) SAL_OVERRIDE;
 
 // Start a page.
-virtual void startPage(int pageNum, GfxState *state);
+virtual void startPage(int pageNum, GfxState *state) 

[PUSHED] script to create git tree with submodule setup from bundles

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3653

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3653
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia483039fcbafe8fc042877d6b610ee88a6097c0a
Gerrit-PatchSet: 2
Gerrit-Project: dev-tools
Gerrit-Branch: master
Gerrit-Owner: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix bnc#705982 - make animations inside SmartArt work.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3622

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/3622/1

Fix bnc#705982 - make animations inside SmartArt work.

With the fallback loading of extDrawing for SmartArt graphics,
slideshow animations into that drawingml fragment didn't work -
for it being modelId diagram references instead of plain shape IDs.

So use the modelId if present, and only then fallback to shape id.

Conflicts:
oox/source/ppt/animationspersist.cxx

Change-Id: Iac2b8bc16255611d7ab165b72fb251cd2a65073a
---
M oox/inc/oox/ppt/pptshape.hxx
M oox/source/ppt/animationspersist.cxx
M oox/source/ppt/pptshape.cxx
M oox/source/ppt/pptshapegroupcontext.cxx
M oox/source/ppt/timetargetelementcontext.cxx
5 files changed, 29 insertions(+), 5 deletions(-)



diff --git a/oox/inc/oox/ppt/pptshape.hxx b/oox/inc/oox/ppt/pptshape.hxx
index aa485ad..2a15dcd 100644
--- a/oox/inc/oox/ppt/pptshape.hxx
+++ b/oox/inc/oox/ppt/pptshape.hxx
@@ -27,6 +27,7 @@
 
 class PPTShape : public oox::drawingml::Shape
 {
+OUStringmsModelId;  // fallback dgs 
smartart shape reference
 ShapeLocation   meShapeLocation;// placeholdershapes 
(mnSubType != 0) on Master are never displayed
 sal_BoolmbReferenced;   // placeholdershapes 
on Layout are displayed only, if they are not referenced
 // placeholdershapes 
on Slide are displayed always
@@ -55,6 +56,7 @@
 sal_Bool isReferenced() const { return mbReferenced; };
 void setReferenced( sal_Bool bReferenced ){ mbReferenced = bReferenced; };
 void setPlaceholder( oox::drawingml::ShapePtr pPlaceholder ) { 
mpPlaceholder = pPlaceholder; }
+void setModelId( const OUString rId ) { msModelId = rId; }
 
 static oox::drawingml::ShapePtr findPlaceholder( const sal_Int32 
nMasterPlaceholder, std::vector oox::drawingml::ShapePtr  rShapes, bool 
bMasterOnly = false );
 static oox::drawingml::ShapePtr findPlaceholderByIndex( const sal_Int32 
nIdx, std::vector oox::drawingml::ShapePtr  rShapes, bool bMasterOnly = 
false );
diff --git a/oox/source/ppt/animationspersist.cxx 
b/oox/source/ppt/animationspersist.cxx
index bf2a53a..d2d79ab 100644
--- a/oox/source/ppt/animationspersist.cxx
+++ b/oox/source/ppt/animationspersist.cxx
@@ -98,9 +98,15 @@
 break;
 case XML_spTgt:
 {
+OUString sShapeName = msValue;
+
+// bnc#705982 - catch referenced diagram fallback shapes
+if( maShapeTarget.mnType == XML_dgm )
+sShapeName = maShapeTarget.msSubShapeId;
+
 Any rTarget;
-::oox::drawingml::ShapePtr pShape = pSlide-getShape(msValue);
-OSL_ENSURE( pShape, failed to locate Shape);
+::oox::drawingml::ShapePtr pShape = pSlide-getShape(sShapeName);
+SAL_WARN_IF( !pShape, oox.ppt, failed to locate Shape);
 if( pShape )
 {
 Reference XShape  xShape( pShape-getXShape() );
diff --git a/oox/source/ppt/pptshape.cxx b/oox/source/ppt/pptshape.cxx
index c0764e5..de0cdae 100644
--- a/oox/source/ppt/pptshape.cxx
+++ b/oox/source/ppt/pptshape.cxx
@@ -351,9 +351,18 @@
 
 }
 }
-if( pShapeMap  !msId.isEmpty() )
+if( pShapeMap )
 {
-(*pShapeMap)[ msId ] = shared_from_this();
+// bnc#705982 - if optional model id reference is
+// there, use that to obtain target shape
+if( !msModelId.isEmpty() )
+{
+(*pShapeMap)[ msModelId ] = shared_from_this();
+}
+else if( !msId.isEmpty() )
+{
+(*pShapeMap)[ msId ] = shared_from_this();
+}
 }
 
 // if this is a group shape, we have to add also each child 
shape
diff --git a/oox/source/ppt/pptshapegroupcontext.cxx 
b/oox/source/ppt/pptshapegroupcontext.cxx
index 9ade8fa..5a4e166 100644
--- a/oox/source/ppt/pptshapegroupcontext.cxx
+++ b/oox/source/ppt/pptshapegroupcontext.cxx
@@ -102,7 +102,7 @@
 case PPT_TOKEN( sp ):   // Shape
 {
 AttributeList aAttribs( xAttribs );
-oox::drawingml::ShapePtr pShape = oox::drawingml::ShapePtr( new 
PPTShape( meShapeLocation, com.sun.star.drawing.CustomShape ) );
+boost::shared_ptrPPTShape pShape( new PPTShape( meShapeLocation, 
com.sun.star.drawing.CustomShape ) );
 if( aAttribs.getBool( XML_useBgFill, false ) )
 {
 ::oox::drawingml::FillProperties aFill = 
pShape-getFillProperties();
@@ -111,6 +111,7 @@
 // TODO: We are using white here, because thats the closest we 
can assume (?)
  

[ABANDONED] Patch fdo#60265 - Document converter wizard fails to find po...

[Thorsten Behrens (via Code Review)]

Thorsten Behrens has abandoned this change.

Change subject: Patch fdo#60265 - Document converter wizard fails to find 
powerpoint files to convert
..


Patch Set 2: Abandoned

Superseded by 3598

-- 
To view, visit https://gerrit.libreoffice.org/3570
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If6667f2fb59902af64307b2510bed0e757ab2acd
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Anurag Kanungo anuragkanu...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#60834 Find and Replace dialog: fix replace box selection...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3202

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3202
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5256ae05d9b4646651e897b7d4c00d9a84329bb
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Cao Cuong Ngo cao.cuong@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#59071 Slideshow: allow automatic transitions with sub-se...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3176


-- 
To view, visit https://gerrit.libreoffice.org/3176
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1907a1baf30cede91a0438d021e003204ea06651
Gerrit-PatchSet: 6
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Cao Cuong Ngo cao.cuong@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] desktop: add --pidfile switch

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2928

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved
  Chris Sherlock: Looks good to me, but someone else must approve


-- 
To view, visit https://gerrit.libreoffice.org/2928
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a3c6cb920fc7b8e659a01975b4d457ce5525b17
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Gerrit-Reviewer: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62525: use cow_wrapper for ViewInformation2D

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3183

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3183
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide3bce3257c9fed7bbda7276dfb55fa179d74fdd
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#58807 bring Beep() for basic back

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3124

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3124
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ooxmlimport: conditional table styles fixed

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3175

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3175
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84f1d7c718dfc120b76364479ca68f63d2549b9f
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Sven Jacobi sven-jac...@gmx.de
Gerrit-Reviewer: Sven Jacobi sven-jac...@gmx.de
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62525: use cow_wrapper for FillHatchAttribute

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3073

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3073
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1581b4bca6f14bd27af12ff40a4f4c0fe08af133
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62525: use cow_wrapper for FontAttribute

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3074


-- 
To view, visit https://gerrit.libreoffice.org/3074
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic07da7c7cf225a910e6f0fa4f6d20c4700e7ec7a
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] kill './logerrit review'

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3070

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3070
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7a11fcdaf95386c451d0e6421d32de7d1d02721
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] touch --no-dereference is supported on mac but as the short-...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3050

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved

Objections:
  Petr Mladek: This need some tweaks before it is merged


-- 
To view, visit https://gerrit.libreoffice.org/3050
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63fa0c24317f683b8eb2bc0b7a1b3ab1ea455866
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com
Gerrit-Reviewer: Petr Mladek pmla...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] resolved fdo#44286 some historical dates were decremented

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3036

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3036
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3216b1c043fe5ab9035a558031f1a58efa0c3b3d
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Eike Rathke er...@redhat.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Fix spelling errors and typos: 'unkown' change to 'unknown'

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3030

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3030
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3ff77d2b99c9ef6c4c9b510bb30f349592c0b94
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0-2] fdo#62617 display groups on multiple layers correctly

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2963

Approvals:
  Petr Mladek: Verified; Looks good to me, but someone else must approve
  Thorsten Behrens: Verified; Looks good to me, approved
  Fridrich Strba: Looks good to me, but someone else must approve


-- 
To view, visit https://gerrit.libreoffice.org/2963
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ef75544a26817154642185864cafd4e6734fa38
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0-2
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Petr Mladek pmla...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#47576: Hyperlinks work for SVG Exports

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2957

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2957
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e034effe6c4a5025c27bd6408fd162bf5cf4859
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Moritz Kütt moritz.ku...@web.de
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] remove unused member maHelpFile and its getter/setter

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2965

Approvals:
  Thomas Arnhold: Looks good to me, but someone else must approve
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2965
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97b53be0a6110c6ca736de657cba48baa0445a12
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: mhofmann bor...@web.de
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] The tooltips of the slide sorter in impress should behave li...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2969

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2969
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2347d81620f0ced437beaaeb49d8ad7f41e9333
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: mhofmann bor...@web.de
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] coverity#704302 Logically dead code

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2977

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2977
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdea2ca5225ac13e80b0a76cd0fd79e463c32e37
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Give the number of slides also when more slides are selected

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2927

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2927
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a169831f2caada6d052edb697036a53ca67ddd0
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#47576: Support for textual links added (SVG Export)

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2936


-- 
To view, visit https://gerrit.libreoffice.org/2936
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id230618d2cc068b94eb0f0051d5db249a88a42f2
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Moritz Kütt moritz.ku...@web.de
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] Allow installation on external storage (SD card)

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2940

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2940
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I532f27aee60a2e60110e9edea75e7cbe7d614b1e
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Tor Lillqvist t...@iki.fi
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62525: use cow_wrapper for SdrShadowAttribute

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2946

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2946
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b5435d2326e9ebf340e88025eeea25ff6388ea2
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62525: use cow_wrapper for FillBitmapAttribute

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2948

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2948
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f666d4baaf6dc4e9f7ea30a518a8904f01d749f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] coverity#704247 Logically dead code

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2952

Approvals:
  Thomas Arnhold: Looks good to me, but someone else must approve
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2952
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaefddeb816d36d4a07234d903fafab3d6b83e1d2
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#62525: use cow_wrapper for FillGradientAttribute

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2951


-- 
To view, visit https://gerrit.libreoffice.org/2951
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85a9864820f49da8ebcc4a7d2c80a3c9d0c13b27
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] coverity#704243 Logically dead code

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2942

Approvals:
  Thomas Arnhold: Looks good to me, but someone else must approve
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2942
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Thomas Arnhold tho...@arnhold.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#62525: use cow_wrapper for FillGradientAttribute

[Thorsten Behrens (via Code Review)]

Thorsten Behrens has abandoned this change.

Change subject: fdo#62525: use cow_wrapper for FillGradientAttribute
..


Patch Set 1: Abandoned

Sorry, pushed with another change id - I85a9864820f49da8ebcc4a7d2c80a3c9d0c13b27

-- 
To view, visit https://gerrit.libreoffice.org/2954
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I13aa9817d7abd3753579f6825c166191a836eef3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Display the number of active slides in the statusbar

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2941


-- 
To view, visit https://gerrit.libreoffice.org/2941
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I788070fdf093ec8b9f875ea5e8190cd04501
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#62665 always consider slide show settings

[Thorsten Behrens (via Code Review)]

Thorsten Behrens has abandoned this change.

Change subject: fdo#62665 always consider slide show settings
..


Patch Set 1: Abandoned

Ah pity - seems that got involuntarily fixed with 
e8b924e440a8f82076389d2774d1c414c87924dc. Sorry.

-- 
To view, visit https://gerrit.libreoffice.org/2947
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I710e17a36d43dffc6b625ab0f6b2156e498d3d8c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: mhofmann bor...@web.de
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] coverity#735389 Copy-paste error

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2858

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2858
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74098cd2b58a64ff231d86549812d5a565835bed
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change Impress remote client target SDK version.

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2719

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2719
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9152fa06558eabd633ad0c19174f45ee2ee9
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Artur Dryomov artur.dryo...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#60604 - fix Impress remote client speaker notes encoding

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2723

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2723
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85414abac233186484078637073b97562b81aad2
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Artur Dryomov artur.dryo...@gmail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED libreoffice-4-0] Resolves: #119989# Support relative 3D pie chart height when...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2671

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2671
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc6f070021c79809c651ba789409a5fb5096c185
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fix fdo#61492: update sd:View with FONTHEIGHT attribute chan...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2433


-- 
To view, visit https://gerrit.libreoffice.org/2433
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf8c6423e64d194c2711d9c37b58de31f1c4c2dd
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: navin patidar pati...@kacst.edu.sa
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] resolve fdo#54335 type an existing style name into Style box...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2292

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2292
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2fd4eecec4f6f031b264a9a1b0c31e938194878
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Bosdonnat Cedric cedric.bosdon...@free.fr
Gerrit-Reviewer: Jan Holesovsky ke...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#39446 - Bloat Removal. Removing uncallable code with cal...

[Thorsten Behrens (via Code Review)]

Hello Miklos Vajna, Tor Lillqvist,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/1921

to look at the new patch set (#4).

Change subject: fdo#39446 - Bloat Removal. Removing uncallable code with 
callcatcher
..

fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher

Removed several unused methods.

Could not remove ScVbaFormatooo::vba::excel::XStyle::getAddIndent() and 
ScVbaFormatooo::vba::excel::XStyle::setAddIndent(com::sun::star::uno::Any 
const) because it breaks compilation (they are implementing pure virtual 
methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
---
M editeng/inc/editeng/editobj.hxx
M editeng/source/editeng/editobj.cxx
M l10ntools/inc/po.hxx
M l10ntools/source/po.cxx
M sfx2/inc/sfx2/templateabstractview.hxx
M sfx2/source/control/templateabstractview.cxx
M tools/inc/tools/line.hxx
M tools/source/generic/line.cxx
M unusedcode.easy
M vcl/inc/outfont.hxx
M vcl/inc/vcl/settings.hxx
M vcl/inc/vcl/svapp.hxx
M vcl/source/app/settings.cxx
M vcl/source/app/svapp.cxx
M vcl/source/gdi/outdev3.cxx
M writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
M writerfilter/source/resourcemodel/util.cxx
M writerfilter/source/rtftok/rtfsprm.cxx
M writerfilter/source/rtftok/rtfsprm.hxx
M xmlsecurity/source/xmlsec/mscrypt/sanextension_mscryptimpl.cxx
M xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx
21 files changed, 1 insertion(+), 204 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1921/4
-- 
To view, visit https://gerrit.libreoffice.org/1921
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jean-Noël Rouvignac jn.rouvig...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#39446 - Bloat Removal. Removing uncallable code with cal...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1921


-- 
To view, visit https://gerrit.libreoffice.org/1921
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jean-Noël Rouvignac jn.rouvig...@gmail.com
Gerrit-Reviewer: Caolán McNamara caol...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Fix fdo#59970 slowless of about box rendering

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2183

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/2183/1

Fix fdo#59970 slowless of about box rendering

Prevent creation of transparent bitmap at arbitrary scale, and
subsequent scaling down. For remote X, that even has to fetch
pixel back from remote side for manual scaling.

Change-Id: I58e011231f2b81b913a6b02dd973385ef5664379
---
M cui/Library_cui.mk
M cui/source/dialogs/about.cxx
2 files changed, 103 insertions(+), 23 deletions(-)



diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 404e72f..b367ad1 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -50,6 +50,7 @@
 comphelper \
 cppu \
 cppuhelper \
+drawinglayer \
 editeng \
 i18nisolang1 \
 jvmfwk \
diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx
index 2c9df74..7179110 100644
--- a/cui/source/dialogs/about.cxx
+++ b/cui/source/dialogs/about.cxx
@@ -20,6 +20,7 @@
 #include vcl/svapp.hxx
 #include vcl/msgbox.hxx
 
+#include osl/process.h
 #include tools/stream.hxx
 #include rtl/bootstrap.hxx
 #include unotools/configmgr.hxx
@@ -35,6 +36,13 @@
 #include comphelper/anytostring.hxx
 #include cppuhelper/exc_hlp.hxx
 #include cppuhelper/bootstrap.hxx
+#include com/sun/star/graphic/XPrimitive2DRenderer.hpp
+#include basegfx/numeric/ftools.hxx
+#include vcl/canvastools.hxx
+#include com/sun/star/geometry/RealRectangle2D.hpp
+#include com/sun/star/rendering/XIntegerReadOnlyBitmap.hpp
+#include basegfx/matrix/b2dhommatrixtools.hxx
+#include drawinglayer/primitive2d/transformprimitive2d.hxx
 
 #include sfx2/sfxuno.hxx
 #include sfx2/sfxcommands.h
@@ -183,6 +191,91 @@
 aCancelButton.GrabFocus();
 }
 
+static bool loadBrandSvg(const char *pName, BitmapEx rBitmap, int nWidth )
+{
+// Load from disk
+// -
+rtl::OUString aBaseName = ( rtl::OUString(/) +
+rtl::OUString::createFromAscii( pName ) );
+rtl::OUString aSvg( .svg );
+
+rtl_Locale *pLoc = NULL;
+osl_getProcessLocale (pLoc);
+LanguageTag aLanguageTag( *pLoc);
+
+rtl::OUString aName = aBaseName + aSvg;
+rtl::OUString aLocaleName = ( aBaseName + rtl::OUString(-) +
+  aLanguageTag.getBcp47() +
+  aSvg );
+rtl::OUString uri = rtl::OUString::createFromAscii( 
$BRAND_BASE_DIR/program ) + aBaseName+aSvg;
+rtl::Bootstrap::expandMacros( uri );
+INetURLObject aObj( uri );
+SvgData aSvgData(aObj.PathToFileName());
+
+// transform into [0,0,width,width*aspect] std dimensions
+// -
+basegfx::B2DRange aRange(aSvgData.getRange());
+const double fAspectRatio(aRange.getWidth()/aRange.getHeight());
+basegfx::B2DHomMatrix aTransform(
+basegfx::tools::createTranslateB2DHomMatrix(
+-aRange.getMinX(),
+-aRange.getMinY()));
+aTransform.scale(
+nWidth / aRange.getWidth(),
+nWidth / fAspectRatio / aRange.getHeight());
+const drawinglayer::primitive2d::Primitive2DReference xTransformRef(
+new drawinglayer::primitive2d::TransformPrimitive2D(
+aTransform,
+aSvgData.getPrimitive2DSequence()));
+
+// UNO dance to render from drawinglayer
+// -
+uno::Reference lang::XMultiServiceFactory  
xFactory(::comphelper::getProcessServiceFactory());
+const rtl::OUString aServiceName(com.sun.star.graphic.Primitive2DTools);
+
+try
+{
+const uno::Reference graphic::XPrimitive2DRenderer  
xPrimitive2DRenderer(
+xFactory-createInstance(aServiceName),
+uno::UNO_QUERY_THROW);
+
+if(xPrimitive2DRenderer.is())
+{
+// cancel out rasterize's mm2pixel conversion
+const double fFakeDPI=1000.0/2.54;
+
+geometry::RealRectangle2D aRealRect(
+0, 0,
+nWidth, nWidth / fAspectRatio);
+
+const uno::Reference rendering::XBitmap  xBitmap(
+xPrimitive2DRenderer-rasterize(
+
drawinglayer::primitive2d::Primitive2DSequence(xTransformRef, 1),
+uno::Sequence beans::PropertyValue (),
+fFakeDPI,
+fFakeDPI,
+aRealRect,
+50));
+
+if(xBitmap.is())
+{
+const uno::Reference rendering::XIntegerReadOnlyBitmap 
xIntBmp(xBitmap, uno::UNO_QUERY_THROW);
+
+if(xIntBmp.is())
+{
+rBitmap = vcl::unotools::bitmapExFromXBitmap(xIntBmp);
+return true;
+}
+}
+}
+}
+catch(const uno::Exception)
+{
+

[PATCH libreoffice-4-0] Only escape double-quotes for ulf files.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2172

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/2172/1

Only escape double-quotes for ulf files.

On second thought, this was needlessly overbroad. Missed the fact
that the code is strictly for ulf.

Change-Id: I96773d6e2a9af473e8c8309421b4900c0b76667f
---
M l10ntools/source/lngmerge.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/l10ntools/source/lngmerge.cxx b/l10ntools/source/lngmerge.cxx
index 812c436..71f68ef 100644
--- a/l10ntools/source/lngmerge.cxx
+++ b/l10ntools/source/lngmerge.cxx
@@ -269,7 +269,7 @@
 rtl::OString sText1( sLang );
 sText1 +=  = \;
 // escape quotes, unescape double escaped 
quotes fdo#56648
-sText1 += 
sNewText.replaceAll(\,\\\).replaceAll(\,\\\).replaceAll(\',\\\').replaceAll(\',\\\');
+sText1 += 
sNewText.replaceAll(\,\\\).replaceAll(\,\\\);
 sText1 += \;
 *pLine = sText1;
 Text[ sLang ] = sNewText;
@@ -307,7 +307,7 @@
 sLine += sCur;
 sLine +=  = \;
 // escape quotes, unescape double escaped quotes 
fdo#56648
-sLine += 
sNewText.replaceAll(\,\\\).replaceAll(\,\\\).replaceAll(\',\\\').replaceAll(\',\\\');
+sLine += 
sNewText.replaceAll(\,\\\).replaceAll(\,\\\);
 sLine += \;
 
 nLastLangPos++;

-- 
To view, visit https://gerrit.libreoffice.org/2172
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96773d6e2a9af473e8c8309421b4900c0b76667f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH libreoffice-4-0] Proper escaping of quotes for android xml resource files.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2173

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/2173/1

Proper escaping of quotes for android xml resource files.

Change-Id: I9f76986465af5798f1451d44af6765f4e5d1bb09
---
M l10ntools/source/stringmerge.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/l10ntools/source/stringmerge.cxx b/l10ntools/source/stringmerge.cxx
index 26aabcb..378548e 100644
--- a/l10ntools/source/stringmerge.cxx
+++ b/l10ntools/source/stringmerge.cxx
@@ -161,7 +161,7 @@
 {
 OString sNewText;
 pEntrys-GetText( sNewText, STRING_TYP_TEXT, m_sLang );
-sNewText = 
sNewText.replaceAll(\,quot;).replaceAll(\,\\\).replaceAll(\',apos;).replaceAll(\',\\\');
+sNewText = 
sNewText.replaceAll(\',\\\').replaceAll(\,\\\);
 xmlNodeSetContent(
 pCurrent,
 xmlEncodeSpecialChars( NULL,

-- 
To view, visit https://gerrit.libreoffice.org/2173
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f76986465af5798f1451d44af6765f4e5d1bb09
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] use md5 for scp2 stamp

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1241


-- 
To view, visit https://gerrit.libreoffice.org/1241
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib416077c6a866c265f7346df8a86ac7bc254c37d
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: DO NOT USE pefol...@gmail.com
Gerrit-Reviewer: DO NOT USE pefol...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Matúš Kukan matus.ku...@gmail.com
Gerrit-Reviewer: Peter Foley pefol...@verizon.net
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] resolve fdo#60379 Impress Remote: Options look disabled

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/2029

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/2029
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb760fd0a0fa1430b77838a0340cc0956a0201a7
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1986


-- 
To view, visit https://gerrit.libreoffice.org/1986
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6504abf50f6193db52d101ec856bcaf1ee2a982c
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ioan Radu ioan.rad...@gmail.com
Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Change in core[libreoffice-4-0-0]: fdo#59881 - sdremote: give up on threaded / UNO usage.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1915

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1915/1

fdo#59881 - sdremote: give up on threaded / UNO usage.

Process incoming commands in the main thread in a Timeout, build
thumbnail / previews there too - to avoid the deadlocks mentioned
in the bug.

The following commits got squashed into one:

(cherry picked from commit f07efaa3bbeb6c2160d6ccbe83ea4183df7115a3)
(cherry picked from commit 88cb36db72775c116c4721163763beb1b2ec0ea3)
(cherry picked from commit 9b696a67f92c7206fe947996931995a70229752e)

Change-Id: I7e825228fcc7ba4e1c40a161c29a0f9a371abdfb
Signed-off-by: Thorsten Behrens tbehr...@suse.com
---
M sd/source/ui/remotecontrol/Communicator.cxx
M sd/source/ui/remotecontrol/ImagePreparer.cxx
M sd/source/ui/remotecontrol/ImagePreparer.hxx
M sd/source/ui/remotecontrol/Listener.cxx
M sd/source/ui/remotecontrol/Receiver.cxx
M sd/source/ui/remotecontrol/Receiver.hxx
6 files changed, 55 insertions(+), 33 deletions(-)



diff --git a/sd/source/ui/remotecontrol/Communicator.cxx 
b/sd/source/ui/remotecontrol/Communicator.cxx
index f567b10..3e3e7bc 100644
--- a/sd/source/ui/remotecontrol/Communicator.cxx
+++ b/sd/source/ui/remotecontrol/Communicator.cxx
@@ -81,7 +81,7 @@
 }
 else
 {
-aReceiver.parseCommand( aCommand );
+aReceiver.pushCommand( aCommand );
 aCommand.clear();
 }
 }
diff --git a/sd/source/ui/remotecontrol/ImagePreparer.cxx 
b/sd/source/ui/remotecontrol/ImagePreparer.cxx
index 66b2791..3530a4a 100644
--- a/sd/source/ui/remotecontrol/ImagePreparer.cxx
+++ b/sd/source/ui/remotecontrol/ImagePreparer.cxx
@@ -50,36 +50,29 @@
  :  xController( rxController ),
 pTransmitter( aTransmitter )
 {
+SetTimeout( 50 );
+mnSendingSlide = 0;
+Start();
 }
 
 ImagePreparer::~ImagePreparer()
 {
+Stop();
 }
 
-void SAL_CALL ImagePreparer::run()
+void ImagePreparer::Timeout()
 {
 sal_uInt32 aSlides = xController-getSlideCount();
-for ( sal_uInt32 i = 0; i  aSlides; i++ )
+if ( xController-isRunning()  // not stopped/disposed of.
+ mnSendingSlide  aSlides )
 {
-if ( !xController-isRunning() ) // stopped/disposed of.
-{
-break;
-}
-sendPreview( i );
+sendPreview( mnSendingSlide );
+sendNotes( mnSendingSlide );
+mnSendingSlide++;
+Start();
 }
-for ( sal_uInt32 i = 0; i  aSlides; i++ )
-{
-if ( !xController-isRunning() ) // stopped/disposed of.
-{
-break;
-}
-sendNotes( i );
-}
-}
-
-void SAL_CALL ImagePreparer::onTerminated()
-{
-delete this;
+else
+Stop();
 }
 
 void ImagePreparer::sendPreview( sal_uInt32 aSlideNumber )
diff --git a/sd/source/ui/remotecontrol/ImagePreparer.hxx 
b/sd/source/ui/remotecontrol/ImagePreparer.hxx
index aa013d7..66b30ae 100644
--- a/sd/source/ui/remotecontrol/ImagePreparer.hxx
+++ b/sd/source/ui/remotecontrol/ImagePreparer.hxx
@@ -10,7 +10,7 @@
 #define _SD_IMPRESSREMOTE_IMAGEPREPARER_HXX
 
 #include osl/thread.hxx
-
+#include vcl/timer.hxx
 #include com/sun/star/presentation/XSlideShowController.hpp
 
 #include Transmitter.hxx
@@ -18,9 +18,9 @@
 namespace sd
 {
 
-class ImagePreparer:
-public osl::Thread
+class ImagePreparer : Timer
 {
+sal_uInt32 mnSendingSlide;
 public:
 ImagePreparer( const
 css::uno::Referencecss::presentation::XSlideShowController
@@ -31,9 +31,7 @@
 css::uno::Referencecss::presentation::XSlideShowController xController;
 Transmitter *pTransmitter;
 
-// Thread method
-virtual void SAL_CALL run();
-virtual void SAL_CALL onTerminated();
+virtual void Timeout();
 
 void sendPreview( sal_uInt32 aSlideNumber );
 css::uno::Sequencesal_Int8 preparePreview( sal_uInt32 aSlideNumber,
diff --git a/sd/source/ui/remotecontrol/Listener.cxx 
b/sd/source/ui/remotecontrol/Listener.cxx
index 30b29a9..2052fbf 100644
--- a/sd/source/ui/remotecontrol/Listener.cxx
+++ b/sd/source/ui/remotecontrol/Listener.cxx
@@ -10,11 +10,12 @@
 #include comphelper/processfactory.hxx
 #include com/sun/star/presentation/XPresentationSupplier.hpp
 #include com/sun/star/presentation/XPresentation2.hpp
-
 #include rtl/strbuf.hxx
+#include vcl/svapp.hxx
 
 #include Listener.hxx
 #include ImagePreparer.hxx
+
 
 using namespace sd;
 using namespace ::com::sun::star::presentation;
@@ -53,8 +54,10 @@
 pTransmitter-addMessage( aBuffer.makeStringAndClear(),
   Transmitter::PRIORITY_HIGH );
 
-ImagePreparer* pPreparer = new ImagePreparer( aController, 
pTransmitter );
-pPreparer-create();
+{
+SolarMutexGuard aGuard;
+/* ImagePreparer* pPreparer = */ new ImagePreparer( aController, 
pTransmitter );
+}
 }
 else
 {
diff --git a/sd/source/ui/remotecontrol/Receiver.cxx 

[PATCH] Change in core[libreoffice-4-0]: Fix fdo#59616 - ensure BitmapEx has same-sized subbitmaps

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1821

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1821/1

Fix fdo#59616 - ensure BitmapEx has same-sized subbitmaps

Lots of code relies on the fact that the two bitmaps inside a
BitmapEx actually have the same size. Enforce that convention during
import.

Change-Id: I436ccc33b06c627cd6347747d22c24bfaf7ca932
---
M vcl/source/gdi/bitmapex.cxx
1 file changed, 18 insertions(+), 0 deletions(-)



diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index e717d0b..f699432 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -806,6 +806,24 @@
 
 if( !!aMask)
 {
+// fdo#59616 enforce same size for both mask and content
+if( aMask.GetSizePixel() != aBmp.GetSizePixel() )
+{
+Bitmap aNewMask;
+const Size aNominalSize=aBmp.GetSizePixel();
+BitmapReadAccess aAcc(aMask);
+if( aAcc.HasPalette() )
+aNewMask = Bitmap(aNominalSize,
+  aMask.GetBitCount(),
+  aAcc.GetPalette());
+else
+aNewMask = Bitmap(aNominalSize,
+  aMask.GetBitCount());
+const Rectangle aCopyArea(Point(0,0), aNominalSize);
+aNewMask.CopyPixel(aCopyArea, aCopyArea, aMask);
+aMask = aNewMask;
+}
+
 // do we have an alpha mask?
 if( ( 8 == aMask.GetBitCount() )  aMask.HasGreyPalette() 
)
 {

-- 
To view, visit https://gerrit.libreoffice.org/1821
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I436ccc33b06c627cd6347747d22c24bfaf7ca932
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: Fix fdo#59616 - ensure BitmapEx has same-sized subbitmaps

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1822

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/1822/1

Fix fdo#59616 - ensure BitmapEx has same-sized subbitmaps

Lots of code relies on the fact that the two bitmaps inside a
BitmapEx actually have the same size. Enforce that convention during
import.

Change-Id: I436ccc33b06c627cd6347747d22c24bfaf7ca932
---
M vcl/source/gdi/bitmapex.cxx
1 file changed, 18 insertions(+), 0 deletions(-)



diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx
index d1d4262..133448c 100644
--- a/vcl/source/gdi/bitmapex.cxx
+++ b/vcl/source/gdi/bitmapex.cxx
@@ -904,6 +904,24 @@
 
 if( !!aMask)
 {
+// fdo#59616 enforce same size for both mask and content
+if( aMask.GetSizePixel() != aBmp.GetSizePixel() )
+{
+Bitmap aNewMask;
+const Size aNominalSize=aBmp.GetSizePixel();
+BitmapReadAccess aAcc(aMask);
+if( aAcc.HasPalette() )
+aNewMask = Bitmap(aNominalSize,
+  aMask.GetBitCount(),
+  aAcc.GetPalette());
+else
+aNewMask = Bitmap(aNominalSize,
+  aMask.GetBitCount());
+const Rectangle aCopyArea(Point(0,0), aNominalSize);
+aNewMask.CopyPixel(aCopyArea, aCopyArea, aMask);
+aMask = aNewMask;
+}
+
 // do we have an alpha mask?
 if( ( 8 == aMask.GetBitCount() )  aMask.HasGreyPalette() 
)
 {

-- 
To view, visit https://gerrit.libreoffice.org/1822
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I436ccc33b06c627cd6347747d22c24bfaf7ca932
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Remove linked-git functionality.

[Thorsten Behrens (via Code Review)]

Thorsten Behrens has abandoned this change.

Change subject: Remove linked-git functionality.
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/1333
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4226a6d5648090fbcbeac16e1cfca98c7e5a936d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: Christian Lohmaier lohmaier+libreoff...@googlemail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6-5]: one more improvement around cond format rendering, fdo#57896

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1710

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved
  Fridrich Strba: Looks good to me, but someone else must approve


-- 
To view, visit https://gerrit.libreoffice.org/1710
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb267ec2d1666edd53f5b9d58fd2a0cec044aa1
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-5
Gerrit-Owner: Markus Mohrhard markus.mohrh...@googlemail.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Noel Power noel.po...@suse.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove linked-git functionality.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1333

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/1333/1

Remove linked-git functionality.

This is not working properly anymore after the submodules change.

Change-Id: I4226a6d5648090fbcbeac16e1cfca98c7e5a936d
---
D bin/git-new-workdir
M configure.ac
2 files changed, 0 insertions(+), 105 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1333
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4226a6d5648090fbcbeac16e1cfca98c7e5a936d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#56877 CRASH when profile contains invalid RecentlyUsedMa...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1224

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1224
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia875d6b04b5ce6a026a57aaef2c17fc02a503ae9
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#55430 allow clicking objects in front of selected ones

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/927

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/927
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee4abf4eddf79ef7ed331221b0a0b23d3370ae2b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lennard Wasserthal wassert...@nefkom.net
Gerrit-Reviewer: Radek Doulík r...@novell.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: fdo#55931 Fix renderding of subscript/superscript with Autof...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/866

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/866
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idba62f1e3f40802651b93f1344e376048866b1b6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Jan Holesovsky ke...@suse.cz
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: Fix fdo#55142 - use proper output offsets.

[Thorsten Behrens (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/853

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/853/1

Fix fdo#55142 - use proper output offsets.

Change-Id: I49cd72a91cd31ddc8b3d57000210523a73926d1f
---
M vcl/aqua/source/gdi/salatslayout.cxx
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/853
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49cd72a91cd31ddc8b3d57000210523a73926d1f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Add back compatible Hungarian date format acceptance

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/720

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/720
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b6d62cda241250db89cdcabaa04952d36e1acfd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Németh László nem...@numbertext.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-5]: fdo#49678: ODF export: add svg:viewBox to draw:connector

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/618

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/618
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ea2294e0796546dcbb245993c01c2dd2b2a755a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-5
Gerrit-Owner: Michael Stahl mst...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] - fdo#35973 - Remember the state of the sidebar pane in Impr...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/526

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/526
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd45a289a5a7b0cb87100e1ff3854ec72143019c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: avoid writing empty p:childTnLst elements, fixes rest of fdo...

[Thorsten Behrens (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/600

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/600
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc09103bb8e4dbd580b5ae53f7929b4700f2c818
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Radek Doulík r...@novell.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice