[PUSHED] Bug # 51154: cppunit warning cleaning
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/5424 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/5424 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f1cae812c58e3791c2386a1288501cf2f559610 Gerrit-PatchSet: 3 Gerrit-Project: cppunit Gerrit-Branch: master Gerrit-Owner: Tobias Lippert d...@fastmail.fm Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com Gerrit-Reviewer: Tobias Lippert d...@fastmail.fm Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Remove dead log-area
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3992 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3992 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d718d1a18bb405e72b198ced548fc7cb885c6d7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] sal osl_getGlobalTimer: Don't confuse start and current time...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3979 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3979 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I575dd70d6b80d4f3279476037e509550cfa23fde Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Mark Wielaard m...@klomp.org Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Let's assume nobody needs the sbase, scalc etc scripts on OS...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3930 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/3930/1 Let's assume nobody needs the sbase, scalc etc scripts on OS X It's always possible to run the soffice executable from the same location with a --base, --calc etc command-line option instead. (That is not the normal way for Mac users to open an empty document for the specific aspect of LibreOffice (Calc, Writer, etc) either. Instead, the usual way (says cloph) is to keep a corresponding template document in the Dock and click that.) Change-Id: Iceea270c03a63f674e7dfdfa95117cb3bdd15184 --- M scp2/source/base/file_base.scp M scp2/source/calc/file_calc.scp M scp2/source/draw/file_draw.scp M scp2/source/impress/file_impress.scp M scp2/source/math/file_math.scp M scp2/source/writer/file_writer.scp 6 files changed, 12 insertions(+), 0 deletions(-) diff --git a/scp2/source/base/file_base.scp b/scp2/source/base/file_base.scp index fb1a230..122353e 100644 --- a/scp2/source/base/file_base.scp +++ b/scp2/source/base/file_base.scp @@ -27,12 +27,14 @@ #include macros.inc +#ifndef MACOSX File gid_File_Exe_Sbase BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(sbase); Styles = (PACKED); End +#endif #if defined WNT File gid_File_Exe_Odbcconfig diff --git a/scp2/source/calc/file_calc.scp b/scp2/source/calc/file_calc.scp index 8f5dfbb..6aa84de 100644 --- a/scp2/source/calc/file_calc.scp +++ b/scp2/source/calc/file_calc.scp @@ -77,9 +77,11 @@ End #endif +#ifndef MACOSX File gid_File_Exe_Scalc BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(scalc); Styles = (PACKED); End +#endif diff --git a/scp2/source/draw/file_draw.scp b/scp2/source/draw/file_draw.scp index 4b7c4db..c757a05 100644 --- a/scp2/source/draw/file_draw.scp +++ b/scp2/source/draw/file_draw.scp @@ -42,9 +42,11 @@ End #endif +#ifndef MACOSX File gid_File_Exe_Sdraw BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(sdraw); Styles = (PACKED); End +#endif diff --git a/scp2/source/impress/file_impress.scp b/scp2/source/impress/file_impress.scp index bff0354..5bcb34d5 100644 --- a/scp2/source/impress/file_impress.scp +++ b/scp2/source/impress/file_impress.scp @@ -54,12 +54,14 @@ End #endif +#ifndef MACOSX File gid_File_Exe_Simpress BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(simpress); Styles = (PACKED); End +#endif // configuration files for custom animation effects diff --git a/scp2/source/math/file_math.scp b/scp2/source/math/file_math.scp index 455c9ca..0c016ee 100644 --- a/scp2/source/math/file_math.scp +++ b/scp2/source/math/file_math.scp @@ -48,9 +48,11 @@ End #endif +#ifndef MACOSX File gid_File_Exe_Smath BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(smath); Styles = (PACKED); End +#endif diff --git a/scp2/source/writer/file_writer.scp b/scp2/source/writer/file_writer.scp index 19e4efa..43b8127 100644 --- a/scp2/source/writer/file_writer.scp +++ b/scp2/source/writer/file_writer.scp @@ -27,12 +27,14 @@ #include macros.inc +#ifndef MACOSX File gid_File_Exe_Swriter BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Name = EXENAME(swriter); Styles = (PACKED); End +#endif #ifdef WNT File gid_File_Exe_Sweb -- To view, visit https://gerrit.libreoffice.org/3930 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iceea270c03a63f674e7dfdfa95117cb3bdd15184 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] No need for the soffice.bin identical copy of soffice on OS ...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3931 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3931/1 No need for the soffice.bin identical copy of soffice on OS X Change-Id: I1e133fb53e58da4ad5e3eb02163eb6082d895b15 --- M scp2/source/ooo/common_brand.scp 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp index d5d39e0..f549000 100644 --- a/scp2/source/ooo/common_brand.scp +++ b/scp2/source/ooo/common_brand.scp @@ -511,12 +511,14 @@ End #endif +#ifndef MACOSX File gid_Brand_File_Bin_Soffice_Bin BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; Styles = (PACKED); Name = soffice.bin; End +#endif #if defined UNX ! defined MACOSX -- To view, visit https://gerrit.libreoffice.org/3931 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e133fb53e58da4ad5e3eb02163eb6082d895b15 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Documentation update of README.cross
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3916 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3916 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc0d34f21de661139e622a34d760a6683f394643 Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Get rid of GlobalEditData::GetStdRefDevice()
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3886
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/3886/1
Get rid of GlobalEditData::GetStdRefDevice()
This avoids a crash on exit in a dbgutil build on OS X.
The horrible bOwnerOfRefDev crack screams out for boost::shared_ptr, I think?
Change-Id: Icf3ae3c28da0583a44472f36312b07766734bf7b
---
M editeng/source/editeng/eerdll.cxx
M editeng/source/editeng/eerdll2.hxx
M editeng/source/editeng/impedit2.cxx
3 files changed, 11 insertions(+), 24 deletions(-)
diff --git a/editeng/source/editeng/eerdll.cxx
b/editeng/source/editeng/eerdll.cxx
index c6a008d..704573a 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -79,7 +79,6 @@
}
GlobalEditData::GlobalEditData()
-:
m_aStdRefDevice(::com::sun::star::uno::Referencecom::sun::star::lang::XComponent(::comphelper::getProcessComponentContext(),
::com::sun::star::uno::UNO_QUERY_THROW))
{
ppDefItems = NULL;
}
@@ -186,16 +185,6 @@
xLanguageGuesser = linguistic2::LanguageGuessing::create(
comphelper::getProcessComponentContext() );
}
return xLanguageGuesser;
-}
-
-OutputDevice* GlobalEditData::GetStdRefDevice()
-{
-if ( !m_aStdRefDevice )
-{
-m_aStdRefDevice.reset(new VirtualDevice);
-m_aStdRefDevice-SetMapMode( MAP_TWIP );
-}
-return m_aStdRefDevice.get();
}
EditResId::EditResId( sal_uInt16 nId ):
diff --git a/editeng/source/editeng/eerdll2.hxx
b/editeng/source/editeng/eerdll2.hxx
index ae592c3..2c53b96 100644
--- a/editeng/source/editeng/eerdll2.hxx
+++ b/editeng/source/editeng/eerdll2.hxx
@@ -23,7 +23,6 @@
#include com/sun/star/linguistic2/XLanguageGuessing.hpp
#include editeng/forbiddencharacterstable.hxx
#include rtl/ref.hxx
-#include comphelper/scoped_disposing_ptr.hxx
class SfxPoolItem;
@@ -32,7 +31,6 @@
private:
::com::sun::star::uno::Reference
::com::sun::star::linguistic2::XLanguageGuessing xLanguageGuesser;
-comphelper::scoped_disposing_solar_mutex_reset_ptrOutputDevice
m_aStdRefDevice;
SfxPoolItem** ppDefItems;
rtl::ReferenceSvxForbiddenCharactersTable xForbiddenCharsTable;
@@ -42,13 +40,11 @@
~GlobalEditData();
SfxPoolItem** GetDefItems();
-OutputDevice* GetStdRefDevice();
rtl::ReferenceSvxForbiddenCharactersTable GetForbiddenCharsTable();
voidSetForbiddenCharsTable(
rtl::ReferenceSvxForbiddenCharactersTable xForbiddenChars ) {
xForbiddenCharsTable = xForbiddenChars; }
::com::sun::star::uno::Reference
::com::sun::star::linguistic2::XLanguageGuessing GetLanguageGuesser();
};
-
#endif //_EERDLL2_HXX
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index b46b23c..8bd7306 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -150,10 +150,8 @@
aOnlineSpellTimer.SetTimeout( 100 );
aOnlineSpellTimer.SetTimeoutHdl( LINK( this, ImpEditEngine, OnlineSpellHdl
) );
-pRefDev = EE_DLL().GetGlobalData()-GetStdRefDevice();
-
// Access data already from here on!
-SetRefDevice( pRefDev );
+SetRefDevice( NULL );
InitDoc( sal_False );
bCallParaInsertedOrDeleted = true;
@@ -190,11 +188,16 @@
if ( bOwnerOfRefDev )
delete pRefDev;
-pRefDev = pRef;
-bOwnerOfRefDev = false;
-
if ( !pRef )
-pRefDev = EE_DLL().GetGlobalData()-GetStdRefDevice();
+{
+pRefDev = new VirtualDevice;
+pRefDev-SetMapMode( MAP_TWIP );
+bOwnerOfRefDev = true;
+} else
+{
+pRefDev = pRef;
+bOwnerOfRefDev = false;
+}
nOnePixelInRef = (sal_uInt16)pRefDev-PixelToLogic( Size( 1, 0 ) ).Width();
@@ -210,8 +213,7 @@
if ( GetRefDevice()-GetMapMode() == rMapMode )
return;
-// When RefDev == GlobalRefDev = create own!
-if ( !bOwnerOfRefDev ( pRefDev ==
EE_DLL().GetGlobalData()-GetStdRefDevice() ) )
+if ( !bOwnerOfRefDev )
{
pRefDev = new VirtualDevice;
pRefDev-SetMapMode( MAP_TWIP );
--
To view, visit https://gerrit.libreoffice.org/3886
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf3ae3c28da0583a44472f36312b07766734bf7b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] dev-install: create the 'install' link in the builddir not i...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3887 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3887 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d1e7ac746928c2a793ac05d932af60d0c8edc06 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Support IMR_QUERYCHARPOSITION in Writer and Calc.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3849 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3849 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53a344a78688060004cc8bcbbf1127f22a468e20 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Yohei Yukawa yuk...@google.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] [coretext] Fix drawing fallback fonts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3846 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3846 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4d7098cb7bd3464cba6abab22be3ac3942c8889 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Khaled Hosny khaledho...@eglug.org Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] codesign --timestamp=none is not supported on 10.6
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3806 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3806 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1e853fd1dd3154c6805eb8129c35a49150b458c Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Convert EMFP_DEBUG to SAL_INFO, etc.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3782 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3782 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6db0021807634070cfa2fee0f07e32d235b3d2f3 Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#64003 - added rmi and snd to insert - movie sound lis...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3727 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3727 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3241f1cdd8972fb3da85e8e2bdd26b25f61a53ec Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Joel Madero jmadero@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Convert from EMFP_DEBUG to SAL_INFO
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3726 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3726 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d710725339f58a111a2f3494c3a72f685624322 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix fdo#64085 : set proper alignment for justified align tex...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3704 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3704 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91e1c52f1aa13a806e2a91dc7120960a4cc3f5c1 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Update pch
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3736 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3736 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia400389ca7c4fbe752e19ca2d38f2fee00f6ee7d Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Aurimas Fišeras auri...@members.fsf.org Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Revert Added Tango colors to palette
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3738 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3738 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id19d869ce8744cf55e64f4d003b8011f9df0023f Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Andres Gomez ago...@igalia.com Gerrit-Reviewer: Alexander Wilms alexander.wi...@zoho.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Clang cleanup, unused mutex variables
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3678 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3678 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I444d13f8b6c50e526cce8d69d09aeaf240e5c6ca Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Noel Grandin noelgran...@gmail.com Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz Gerrit-Reviewer: Noel Grandin noelgran...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] Fix fdo#64062 - can't assume para styles to be there.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3694 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3694 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5da53ff44fdf00ec6c0fdf1a722f806971b6683a Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Thorsten Behrens tbehr...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#35785: don't rely on the old apps fallback mechanism to ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3639 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3639 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0967358956868538f7563c51f7ed5e106771302 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#35785: LibreOffice is One for now
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3638 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3638 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4a5a76f980eb458a2b6d4558a553b8508fd990 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#63546: set appropriate alignment when wrt direction of c...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3549 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3549 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie98a46af97236ab4303d030f11bd167939dde32b Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: navin patidar pati...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] UpdateTableShape() is called when we call SetAttrToSelectedC...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3391 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3391 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bb0bb616cc978717a1494e01f257631aadd613c Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: gokul s gswaminat...@kacst.edu.sa Gerrit-Reviewer: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: gokul s gswaminat...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#61060 - Freezing now marks spreadsheet as unsaved.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3641 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3641 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b479500938e185fb6d163837b29e6e36e823260 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Sameer Deshmukh sameer.deshmuk...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] Make the Mac installation tree more Mac-like in structure
Tor Lillqvist has abandoned this change. Change subject: Make the Mac installation tree more Mac-like in structure .. Patch Set 2: Abandoned No point keeping this here any longer (even for reference), it just clutters up gerrit; will need lots of rework presumably to apply and work any longer. -- To view, visit https://gerrit.libreoffice.org/2310 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5e7a3c1e32a870364d41a07a4c6e94362eabec5f Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Stephan Bergmann sberg...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fixing Indentation RTL bug
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3651 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3651 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8c3d30cb28afb97d4ded4ac67241ed18ab9e50c Gerrit-PatchSet: 6 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Adam Co rattles2...@gmail.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Clang cleanup, unaligned if statement
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3677 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3677 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f7c312d2c0167a17e31624e197ae75b77fa0c2f Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Noel Grandin noelgran...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] add fallback for Merge-Modules directory (when not found in ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3680 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3680 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f58b8a1d453c8628c6eb66c2cea37ab3da913a Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Christian Lohmaier lohmaier+libreoff...@googlemail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#33370 Readme file could be easier to follow
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3679 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3679 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25794499711845cb8183664d1345e5513587d81c Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jan Bobisud bobis...@fel.cvut.cz Gerrit-Reviewer: Jan Bobisud bobis...@fel.cvut.cz Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] Fix import of images from pdf.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3690 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3690 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I565de80ce218e831e276d3a1d88ded3baee876e7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Thorsten Behrens tbehr...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Bin CLOOK comments and un-split one large switch statement
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3640 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/3640/1 Bin CLOOK comments and un-split one large switch statement CLOOK = Compiler Limit: Out Of Keys, an error reported by Microsoft's compiler a long time ago. No such problem in those versions we support. No need to mention CLOOK in comments any more. While at it, re-combine one large switch statement that was split to avoid CLOOK. Change-Id: Id93d973a5fb3c81b6c754eef0ba3b0bd55a649d2 --- M include/editeng/outliner.hxx M include/svx/compressgraphicdialog.hxx M sc/inc/document.hxx M sc/source/ui/app/scdll.cxx M sc/source/ui/drawfunc/drawsh5.cxx M sc/source/ui/view/tabview5.cxx M sc/source/ui/view/tabvwsh9.cxx M sc/source/ui/view/tabvwshe.cxx M sd/source/ui/inc/DrawViewShell.hxx M sd/source/ui/view/drviews2.cxx M sd/source/ui/view/drviews6.cxx M sd/source/ui/view/drviews8.cxx M sd/source/ui/view/drviewsb.cxx M sd/source/ui/view/drviewsc.cxx M sw/inc/doc.hxx M sw/source/core/doc/docnew.cxx M sw/source/core/inc/rolbck.hxx 17 files changed, 1,936 insertions(+), 1,992 deletions(-) -- To view, visit https://gerrit.libreoffice.org/3640 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id93d973a5fb3c81b6c754eef0ba3b0bd55a649d2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Better text for Insert as Link Checkbox
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3602 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3602 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84fbc182cc9b432cd38ccb044c0479ced119d97f Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#56832 Explicitly mention Ogg Audio and Video
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3609 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3609 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb5f3b7016b58beaf915673181369530a3d0709e Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Resolves fdo#62673 Table cells non-editable on cell merge
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3273 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3273 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d9244115d08e31b46dbe1a4998e6a763ee38361 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Karthikeyan Krishnamurthi karthike...@kacst.edu.sa Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Petr Mladek pmla...@suse.cz Gerrit-Reviewer: Radek Doulík r...@novell.com Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Use div instead of multicol when exporting multi-column ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3610 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3610 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55bea40326904de7f137e996a000a7d213fa0593 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Harri Pitkänen hatap...@iki.fi Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] gbuild: MSVC: only re-link libraries if exported symbols cha...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3612 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3612 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I874abec0e8bb8d1ec2894fd6e94bc78b48e384e1 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#60625 - Document converter wizard fails to find powerpoi...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3617 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3617 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6083a9048ada870178753cd4ba523c9d3916cf11 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Anurag Kanungo anuragkanu...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] fdo#61060 - Freeze and unfreeze now mark document as unsaved...
Tor Lillqvist has abandoned this change. Change subject: fdo#61060 - Freeze and unfreeze now mark document as unsaved. .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3620 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie1377e42430a6608c0d316d5bf1f2a2dd2f35df9 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Sameer Deshmukh sameer.deshmuk...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fix fdo#35785: recent documents feature of the Windows 7 Sta...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3623 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3623 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61cffeaf661db7e7b8f642bbbd9457203f75cb9a Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fix scrolling performance of listboxes with hundreds of entr...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3611 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3611 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c284c360f06ac383e8c38045fc4c2946f505b35 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Eike Rathke er...@redhat.com Gerrit-Reviewer: Kohei Yoshida kohei.yosh...@suse.de Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] Try one approach to compile a class as one compilation unit
Tor Lillqvist has abandoned this change. Change subject: Try one approach to compile a class as one compilation unit .. Patch Set 1: Abandoned OK, the consensus seems to be that trying hard to preserve git log continuity at the expense of clarity is not worth it. Thus, if I at some point feel the urge to combine some pointlessly split source files into one compilation unit, I will just do it the logical way, combining them into one source file. -- To view, visit https://gerrit.libreoffice.org/3373 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I79e299ba397c1466a08cbc9bc31817e76a2d67f5 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Try one approach to compile a class as one compilation unit
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3373 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/3373/1 Try one approach to compile a class as one compilation unit In many cases the sources for some class have been split up into several source files, typically suffixed with a number 0, 1, 2 etc. Presumably this has been done because some compiler years ago was not capable of compiling all the source for that class at one time, or some other no longer relevant reason. It would be nice to get rid of this convention, so that clever compilers have a better chance of noticing unused private fields in a class, for instance. On the other hand, just combining the source files in question into one source file and removing the old source files from git leads to a discontinuity in version control history. Maybe a good compromise would be to introduce one new source file what would include the existing numbered source files? Or, as in this case, include the others into one already appropriately named source file? Change-Id: I79e299ba397c1466a08cbc9bc31817e76a2d67f5 --- M basic/Library_sb.mk M basic/source/runtime/runtime.cxx M basic/source/runtime/step0.cxx M basic/source/runtime/step1.cxx M basic/source/runtime/step2.cxx 5 files changed, 51 insertions(+), 75 deletions(-) diff --git a/basic/Library_sb.mk b/basic/Library_sb.mk index 3568056..a3acbda 100644 --- a/basic/Library_sb.mk +++ b/basic/Library_sb.mk @@ -100,9 +100,6 @@ basic/source/runtime/sbdiagnose \ basic/source/runtime/stdobj \ basic/source/runtime/stdobj1 \ - basic/source/runtime/step0 \ - basic/source/runtime/step1 \ - basic/source/runtime/step2 \ )) endif diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx index 815030d..ba80ce4 100644 --- a/basic/source/runtime/runtime.cxx +++ b/basic/source/runtime/runtime.cxx @@ -17,25 +17,61 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include vcl/svapp.hxx +#include stdlib.h + +#include algorithm + +#include boost/unordered_map.hpp + +#include com/sun/star/beans/XPropertySet.hpp +#include com/sun/star/container/XEnumerationAccess.hpp +#include com/sun/star/container/XIndexAccess.hpp +#include com/sun/star/script/XDefaultMethod.hpp +#include com/sun/star/uno/Any.hxx +#include com/sun/star/util/SearchOptions.hpp + +#include comphelper/processfactory.hxx +#include comphelper/string.hxx + +#include sal/log.hxx + #include tools/wldcrd.hxx + +#include vcl/msgbox.hxx +#include vcl/svapp.hxx + +#include rtl/instance.hxx +#include rtl/math.hxx +#include rtl/ustrbuf.hxx + #include svl/zforlist.hxx + #include unotools/syslocale.hxx -#include runtime.hxx -#include sbintern.hxx -#include opcodes.hxx +#include unotools/textsearch.hxx + +#include basic/sbuno.hxx + +#include basrid.hxx #include codegen.hxx -#include iosys.hxx -#include image.hxx +#include comenumwrapper.hxx #include ddectrl.hxx #include dllmgr.hxx -#include comphelper/processfactory.hxx -#include com/sun/star/container/XEnumerationAccess.hpp -#include sbunoobj.hxx #include errobject.hxx -#include sal/log.hxx +#include image.hxx +#include iosys.hxx +#include opcodes.hxx +#include runtime.hxx +#include sb.hrc +#include sbintern.hxx +#include sbunoobj.hxx -#include comenumwrapper.hxx +using com::sun::star::uno::Reference; + +using namespace com::sun::star::uno; +using namespace com::sun::star::container; +using namespace com::sun::star::lang; +using namespace com::sun::star::beans; +using namespace com::sun::star::script; SbxVariable* getDefaultProp( SbxVariable* pRef ); @@ -1288,4 +1324,8 @@ return pImg-GetBase(); } +#include step0.cxx +#include step1.cxx +#include step2.cxx + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/basic/source/runtime/step0.cxx b/basic/source/runtime/step0.cxx index 37e2116..0be0c90 100644 --- a/basic/source/runtime/step0.cxx +++ b/basic/source/runtime/step0.cxx @@ -17,28 +17,8 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include comphelper/string.hxx -#include vcl/msgbox.hxx - -#include errobject.hxx -#include runtime.hxx -#include sbintern.hxx -#include iosys.hxx -#include sb.hrc -#include basrid.hxx -#include sbunoobj.hxx -#include image.hxx -#include com/sun/star/uno/Any.hxx -#include com/sun/star/util/SearchOptions.hpp -#include rtl/instance.hxx -#include vcl/svapp.hxx -#include unotools/textsearch.hxx - Reference XInterface createComListener( const Any aControlAny, const OUString aVBAType, const OUString aPrefix, SbxObjectRef xScopeObj ); - -#include algorithm -#include boost/unordered_map.hpp // for a patch forward declaring these methods below makes sense // but, #FIXME lets really just move the methods to the top diff --git a/basic/source/runtime/step1.cxx b/basic/source/runtime/step1.cxx index 7b72129..2ccfbe3
[PATCH libreoffice-4-0] Turn on Neon debug output (if enabled in Neon) when building...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3166 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3166/1 Turn on Neon debug output (if enabled in Neon) when building for debugging Also add NE_DBG_LOCKS and NE_DBG_SSL to the debugging mask. (cherry picked from commit be2ce85e9539debc7c40680a6616c7dbe461d74c) Change-Id: I6757954ea3ad53df855935930de176c222bff0ed --- M ucb/source/ucp/webdav-neon/NeonSession.cxx 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx b/ucb/source/ucp/webdav-neon/NeonSession.cxx index 3ac4700..f1f3b9f 100644 --- a/ucb/source/ucp/webdav-neon/NeonSession.cxx +++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx @@ -695,7 +695,7 @@ // #122205# - libxml2 needs to be initialized once if used by // multithreaded programs like OOo. xmlInitParser(); -#if 0 +#if OSL_DEBUG_LEVEL 0 // for more debug flags see ne_utils.h; NE_DEBUGGING must be defined // while compiling neon in order to actually activate neon debug // output. @@ -705,7 +705,8 @@ // | NE_DBG_HTTPAUTH // | NE_DBG_XML // | NE_DBG_XMLPARSE - // | NE_DBG_LOCKS + | NE_DBG_LOCKS + | NE_DBG_SSL ); #endif m_bGlobalsInited = true; -- To view, visit https://gerrit.libreoffice.org/3166 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6757954ea3ad53df855935930de176c222bff0ed Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] Adapt code to IllegalArgumentException being a RuntimeExcept...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3174 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3174 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I849b5cf496cc7dff7b3c17d2d4d54f0194553e27 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Stephan Bergmann sberg...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] SFX_VISIBILITY_PLUGCLIENT and SERVER are unused
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3147 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3147/1 SFX_VISIBILITY_PLUGCLIENT and SERVER are unused Change-Id: I33926a960d1fba8f68737879a6e58ef38ad1ee62 --- M sfx2/inc/sfx2/shell.hxx M sfx2/source/appl/workwin.cxx 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/sfx2/inc/sfx2/shell.hxx b/sfx2/inc/sfx2/shell.hxx index 344294a..68cbd28 100644 --- a/sfx2/inc/sfx2/shell.hxx +++ b/sfx2/inc/sfx2/shell.hxx @@ -336,8 +336,6 @@ #define SFX_POSITION_MASK 0x000F #define SFX_VISIBILITY_MASK 0xFFF0 #define SFX_VISIBILITY_UNVISIBLE0x // Never visible -#define SFX_VISIBILITY_PLUGSERVER 0x0010 -#define SFX_VISIBILITY_PLUGCLIENT 0x0020 #define SFX_VISIBILITY_VIEWER 0x0040 // One is still free! #define SFX_VISIBILITY_RECORDING0x0200 diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx index 0a379df..6672302 100644 --- a/sfx2/source/appl/workwin.cxx +++ b/sfx2/source/appl/workwin.cxx @@ -1207,8 +1207,6 @@ return sal_True; case SFX_VISIBILITY_UNVISIBLE: return sal_False; -case SFX_VISIBILITY_PLUGSERVER: -case SFX_VISIBILITY_PLUGCLIENT: case SFX_VISIBILITY_CLIENT: case SFX_VISIBILITY_SERVER: return !!(nMode nUpdateMode); -- To view, visit https://gerrit.libreoffice.org/3147 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33926a960d1fba8f68737879a6e58ef38ad1ee62 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] SFX_VISIBILITY_PLUGCLIENT, SERVER and RECORDING are unused
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3148 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3148/1 SFX_VISIBILITY_PLUGCLIENT, SERVER and RECORDING are unused Change-Id: I1fd581c8ca44cfb48184d8a17e6077707f038bd4 --- M sfx2/inc/sfx2/shell.hxx M sfx2/source/appl/workwin.cxx 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/sfx2/inc/sfx2/shell.hxx b/sfx2/inc/sfx2/shell.hxx index 344294a..cba6efa 100644 --- a/sfx2/inc/sfx2/shell.hxx +++ b/sfx2/inc/sfx2/shell.hxx @@ -336,11 +336,7 @@ #define SFX_POSITION_MASK 0x000F #define SFX_VISIBILITY_MASK 0xFFF0 #define SFX_VISIBILITY_UNVISIBLE0x // Never visible -#define SFX_VISIBILITY_PLUGSERVER 0x0010 -#define SFX_VISIBILITY_PLUGCLIENT 0x0020 #define SFX_VISIBILITY_VIEWER 0x0040 -// One is still free! -#define SFX_VISIBILITY_RECORDING0x0200 #define SFX_VISIBILITY_READONLYDOC 0x0400 #define SFX_VISIBILITY_DESKTOP 0x0800 #define SFX_VISIBILITY_STANDARD 0x1000 diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx index 0a379df..6672302 100644 --- a/sfx2/source/appl/workwin.cxx +++ b/sfx2/source/appl/workwin.cxx @@ -1207,8 +1207,6 @@ return sal_True; case SFX_VISIBILITY_UNVISIBLE: return sal_False; -case SFX_VISIBILITY_PLUGSERVER: -case SFX_VISIBILITY_PLUGCLIENT: case SFX_VISIBILITY_CLIENT: case SFX_VISIBILITY_SERVER: return !!(nMode nUpdateMode); -- To view, visit https://gerrit.libreoffice.org/3148 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1fd581c8ca44cfb48184d8a17e6077707f038bd4 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] SFX_VISIBILITY_PLUGCLIENT and SERVER are unused
Tor Lillqvist has abandoned this change. Change subject: SFX_VISIBILITY_PLUGCLIENT and SERVER are unused .. Patch Set 1: Abandoned Re-submitted with different Change-Id for some reason. -- To view, visit https://gerrit.libreoffice.org/3147 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I33926a960d1fba8f68737879a6e58ef38ad1ee62 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Get rid of the slots.cfg mechanism
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3118
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/3118/1
Get rid of the slots.cfg mechanism
I very much doubt anybody is using it. It has never been documented as far as
I can see for OpenOffice.org and even less for LibreOffice. I only found it
mentioned in the StarOffice 6.0 Software Administration Guide.
Change-Id: I03f272427ef6717e3e3ff957f32ffe1f696d93c9
---
M sfx2/inc/sfx2/app.hxx
M sfx2/inc/sfx2/dispatch.hxx
M sfx2/source/appl/appmisc.cxx
M sfx2/source/control/dispatch.cxx
4 files changed, 3 insertions(+), 150 deletions(-)
diff --git a/sfx2/inc/sfx2/app.hxx b/sfx2/inc/sfx2/app.hxx
index ab88440..bc8613f 100644
--- a/sfx2/inc/sfx2/app.hxx
+++ b/sfx2/inc/sfx2/app.hxx
@@ -251,8 +251,9 @@
SAL_DLLPRIVATE void Registrations_Impl();
SAL_DLLPRIVATE SfxWorkWindow* GetWorkWindow_Impl(const SfxViewFrame
*pFrame=0) const;
-// TODO/CLEANUP: still needed?
-SAL_DLLPRIVATE std::vectorsal_uInt16* GetDisabledSlotList_Impl();
+// TODO/CLEANUP: still needed? -- unclear whether this comment
+// refers to the GetDisabledSlotList_Impl() method which was
+// already removed, or the below methods?
SAL_DLLPRIVATE SfxSlotPool GetAppSlotPool_Impl() const;
SAL_DLLPRIVATE SfxModule* GetModule_Impl();
SAL_DLLPRIVATE ResMgr* GetOffResManager_Impl();
diff --git a/sfx2/inc/sfx2/dispatch.hxx b/sfx2/inc/sfx2/dispatch.hxx
index f871838..c7aaae3 100644
--- a/sfx2/inc/sfx2/dispatch.hxx
+++ b/sfx2/inc/sfx2/dispatch.hxx
@@ -182,7 +182,6 @@
SfxItemStateQueryState( sal_uInt16 nSID, const SfxPoolItem*
rpState );
SfxItemStateQueryState( sal_uInt16 nSID,
::com::sun::star::uno::Any rAny );
-sal_BoolIsAllowed( sal_uInt16 nSlot ) const;
::com::sun::star::frame::XDispatch* GetDispatchInterface( const
String );
voidSetDisableFlags( sal_uInt32 nFlags );
sal_uInt32 GetDisableFlags() const;
diff --git a/sfx2/source/appl/appmisc.cxx b/sfx2/source/appl/appmisc.cxx
index bd55b24..2cd1336 100644
--- a/sfx2/source/appl/appmisc.cxx
+++ b/sfx2/source/appl/appmisc.cxx
@@ -155,88 +155,6 @@
return pAppData_Impl-pProgress;
}
-//
-
-std::vectorsal_uInt16* SfxApplication::GetDisabledSlotList_Impl()
-{
-sal_Bool bError = sal_False;
-std::vectorsal_uInt16* pList = pAppData_Impl-pDisabledSlotList;
-if ( !pList )
-{
-// Is there a slot file?
-INetURLObject aUserObj( SvtPathOptions().GetUserConfigPath() );
-aUserObj.insertName( slots.cfg );
-SvStream* pStream = ::utl::UcbStreamHelper::CreateStream(
aUserObj.GetMainURL( INetURLObject::NO_DECODE ), STREAM_STD_READ );
-if ( !pStream || pStream-GetError() == ERRCODE_IO_NOTEXISTS )
-{
-delete pStream;
-INetURLObject aObj( SvtPathOptions().GetConfigPath() );
-aObj.insertName( slots.cfg );
-pStream = ::utl::UcbStreamHelper::CreateStream( aObj.GetMainURL(
INetURLObject::NO_DECODE ), STREAM_STD_READ );
-}
-
-sal_Bool bSlotsEnabled = SvtInternalOptions().SlotCFGEnabled();
-sal_Bool bSlots = ( pStream !pStream-GetError() );
-if( bSlots bSlotsEnabled )
-{
-// Read Slot file
-String aTitle =
pStream-ReadUniOrByteString(pStream-GetStreamCharSet());
-if ( aTitle.CompareToAscii(SfxSlotFile ) == COMPARE_EQUAL )
-{
-sal_uInt16 nCount;
-(*pStream) nCount;
-pList = pAppData_Impl-pDisabledSlotList =
-new std::vectorsal_uInt16;
-
-sal_uInt16 nSlot;
-for ( sal_uInt16 n=0; nnCount; n++ )
-{
-(*pStream) nSlot;
-pList-push_back( nSlot );
-}
-
-aTitle =
pStream-ReadUniOrByteString(pStream-GetStreamCharSet());
-if ( aTitle.CompareToAscii(END ) != COMPARE_EQUAL ||
pStream-GetError() )
-{
-// Read failed
-DELETEZ( pList );
-bError = sal_True;
-}
-}
-else
-{
-// Stream detection failure
-bError = sal_True;
-}
-}
-else if ( bSlots != bSlotsEnabled )
-{
-// If no slot list entry, then no slot file shall exist
-bError = sal_True;
-}
-
-delete pStream;
-}
-else if ( pList == (std::vectorsal_uInt16*) -1L )
-{
-return NULL;
-}
-
-if ( !pList )
-pAppData_Impl-pDisabledSlotList = (std::vectorsal_uInt16*) -1L;
-
-if ( bError )
-{
-// If an entry slot is present, but no or faulty slot file, or
[PATCH] Make autogen.sh prefer to read an autogen.input file
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/3111
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3111/1
Make autogen.sh prefer to read an autogen.input file
An autogen.lastrun file will still be used if it exists (and autogen.input
does not exist). The recommended workflow is now to keep the configuration
parametets in autogen.input which is never written by autogen.sh.
Most (?) developers used to treat autogen.lastrun as a valuable parameter file
to be edited manually anyway, and not as an ad-hoc backup copy of command-line
parameters last used. The name autogen.input better reflects this usage.
Change-Id: I7e3c747fa95e9f2f0bc44036419aaab8f4ad01e7
---
M autogen.sh
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/autogen.sh b/autogen.sh
index fa77b73..f5960e3 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -21,7 +21,7 @@
{
system (rm -Rf autom4te.cache);
system (rm -f missing install-sh mkinstalldirs libtool ltmain.sh);
-print cleaned the build tree\n;
+print Cleaned the build tree\n;
}
my $aclocal;
@@ -108,9 +108,18 @@
}
my @cmdline_args = ();
-if (!@ARGV) {
-my $lastrun = autogen.lastrun;
-@cmdline_args = read_args ($lastrun) if (-f $lastrun);
+
+my $input = autogen.input;
+my $lastrun = autogen.lastrun;
+
+if (-f $input) {
+warn Ignoring command-line arguments, using $input.\n if (@ARGV);
+warn Ignoring $lastrun, using $input.\n if (-f $lastrun);
+@cmdline_args = read_args ($input);
+} elsif (-f $lastrun) {
+warn Ignoring command-line arguments, using $lastrun.\n if (@ARGV);
+print STDERR Reading $lastrun. Please rename it to $input to avoid this
message.\n;
+@cmdline_args = read_args ($lastrun);
} else {
@cmdline_args = @ARGV;
}
@@ -118,7 +127,7 @@
my @args;
my $default_config = $src_path/distro-configs/default.conf;
if (-f $default_config) {
-print STDERR Reading default config file: $default_config\n;
+print STDERR Reading default config file: $default_config.\n;
push @args, read_args ($default_config);
}
for my $arg (@cmdline_args) {
@@ -164,40 +173,35 @@
system ($aclocal $aclocal_flags) die Failed to run aclocal;
unlink (configure);
system (autoconf -I ${src_path}) die Failed to run autoconf;
-die failed to generate configure if (! -f configure);
+die Failed to generate the configure script if (! -f configure);
if (defined $ENV{NOCONFIGURE}) {
print Skipping configure process.;
} else {
# Save autogen.lastrun only if we did get some arguments on the
command-line
-if (@ARGV) {
+if (! -f $input @ARGV) {
if (scalar(@cmdline_args) 0) {
# if there's already an autogen.lastrun, make a backup first
-if (-e autogen.lastrun) {
-open (my $fh, autogen.lastrun) || warn can't open
autogen.lastrun. \n;
-open (BAK, autogen.lastrun.bak) || warn can't create
backup file. \n;
+if (-e $lastrun) {
+open (my $fh, $lastrun) || warn Can't open $lastrun.\n;
+open (BAK, $lastrun.bak) || warn Can't create backup file
$lastrun.bak.\n;
while ($fh) {
print BAK;
}
close (BAK) close ($fh);
}
-# print writing args to autogen.lastrun\n;
+# print Saving command-line args to $lastrun\n;
my $fh;
-open ($fh, autogen.lastrun) || die can't open autogen.lastrun:
$!;
+open ($fh, autogen.lastrun) || die Can't open autogen.lastrun:
$!;
for my $arg (@cmdline_args) {
print $fh $arg\n;
}
close ($fh);
}
}
-elsif ( ! -e autogen.lastrun)
-{
-open (my $fh, autogen.lastrun) || die can't create
autogen.lastrun;
-close ($fh);
-}
push @args, --srcdir=$src_path;
-print running ./configure with ' . join (' ', @args), '\n;
+print Running ./configure with ' . join (' ', @args), '\n;
system (./configure, @args) die Error running configure;
}
--
To view, visit https://gerrit.libreoffice.org/3111
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e3c747fa95e9f2f0bc44036419aaab8f4ad01e7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ABANDONED] Use an 8bpp virtual device (instead of a 1bpp one) in sw and...
Tor Lillqvist has abandoned this change. Change subject: Use an 8bpp virtual device (instead of a 1bpp one) in sw and sc .. Patch Set 3: Abandoned -- To view, visit https://gerrit.libreoffice.org/2979 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia34927cf728d4be05a31e88b7da78200d0b799ba Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Christoph Brill egore...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use an 8bpp virtual device (instead of a 1bpp one) in sw and...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2979
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/2979/1
Use an 8bpp virtual device (instead of a 1bpp one) in sw and sc
The reason why a 1bpp virtual device is used is unclear to me. Using an 8bpp
one instead doesn't seem to cause any harm, and in the iOS port a 1bpp virtual
device actually does cause complications.
Change-Id: Ia34927cf728d4be05a31e88b7da78200d0b799ba
---
M sc/source/core/data/documen8.cxx
M sw/source/core/doc/docnew.cxx
M vcl/source/gdi/virdev.cxx
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index f535235..dea44ec 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -207,7 +207,7 @@
{
if (!pVirtualDevice_100th_mm)
{
-pVirtualDevice_100th_mm = new VirtualDevice( 1 );
+pVirtualDevice_100th_mm = new VirtualDevice( 8 );
pVirtualDevice_100th_mm-SetReferenceDevice(VirtualDevice::REFDEV_MODE_MSO1);
MapMode aMapMode( pVirtualDevice_100th_mm-GetMapMode() );
aMapMode.SetMapUnit( MAP_100TH_MM );
diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index 7ffacc3..48c5895 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@ -698,7 +698,7 @@
VirtualDevice SwDoc::CreateVirtualDevice_() const
{
-VirtualDevice* pNewVir = new VirtualDevice( 1 );
+VirtualDevice* pNewVir = new VirtualDevice( 8 );
pNewVir-SetReferenceDevice( VirtualDevice::REFDEV_MODE_MSO1 );
diff --git a/vcl/source/gdi/virdev.cxx b/vcl/source/gdi/virdev.cxx
index 87a7487..5083a1b 100644
--- a/vcl/source/gdi/virdev.cxx
+++ b/vcl/source/gdi/virdev.cxx
@@ -39,6 +39,8 @@
void VirtualDevice::ImplInitVirDev( const OutputDevice* pOutDev,
long nDX, long nDY, sal_uInt16 nBitCount,
const SystemGraphicsData *pData )
{
+SAL_INFO( vcl.virdev, ImplInitVirDev( nDX , nDY ,
nBitCount ) );
+
if ( nDX 1 )
nDX = 1;
@@ -126,8 +128,8 @@
: mpVirDev( NULL ),
meRefDevMode( REFDEV_NONE )
{
-SAL_WARN_IF( nBitCount 1, vcl.gdi,
-VirtualDevice::VirtualDevice(): Only 0 or 1 is for BitCount
allowed );
+SAL_WARN_IF( (nBitCount 1 nBitCount != 8), vcl.gdi,
+VirtualDevice::VirtualDevice(): Only 0, 1 or 8 allowed for
BitCount );
SAL_INFO( vcl.gdi, VirtualDevice::VirtualDevice( nBitCount )
);
ImplInitVirDev( Application::GetDefaultDevice(), 1, 1, nBitCount );
@@ -139,8 +141,8 @@
: mpVirDev( NULL ),
meRefDevMode( REFDEV_NONE )
{
-SAL_WARN_IF( nBitCount 1, vcl.gdi,
-VirtualDevice::VirtualDevice(): Only 0 or 1 is for BitCount
allowed );
+SAL_WARN_IF( (nBitCount 1 nBitCount != 8), vcl.gdi,
+VirtualDevice::VirtualDevice(): Only 0, 1 or 8 allowed for
BitCount );
SAL_INFO( vcl.gdi, VirtualDevice::VirtualDevice( nBitCount )
);
ImplInitVirDev( rCompDev, 1, 1, nBitCount );
@@ -152,8 +154,8 @@
: mpVirDev( NULL ),
meRefDevMode( REFDEV_NONE )
{
-SAL_WARN_IF( nBitCount 1, vcl.gdi,
-VirtualDevice::VirtualDevice(): Only 0 or 1 is for BitCount
allowed );
+SAL_WARN_IF( (nBitCount 1 nBitCount != 8), vcl.gdi,
+VirtualDevice::VirtualDevice(): Only 0, 1 or 8 allowed for
BitCount );
SAL_INFO( vcl.gdi,
VirtualDevice::VirtualDevice( nBitCount ,
nAlphaBitCount ) );
--
To view, visit https://gerrit.libreoffice.org/2979
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia34927cf728d4be05a31e88b7da78200d0b799ba
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0] Allow installation on external storage (SD card)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2940 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/2940/1 Allow installation on external storage (SD card) Change-Id: I532f27aee60a2e60110e9edea75e7cbe7d614b1e --- M android/sdremote/AndroidManifest.xml 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/android/sdremote/AndroidManifest.xml b/android/sdremote/AndroidManifest.xml index 572c5abb9..0efbc23 100644 --- a/android/sdremote/AndroidManifest.xml +++ b/android/sdremote/AndroidManifest.xml @@ -2,7 +2,8 @@ manifest xmlns:android=http://schemas.android.com/apk/res/android; package=org.libreoffice.impressremote android:versionCode=7 -android:versionName=1.0.5+ Impress Remote +android:versionName=1.0.5+ Impress Remote +android:installLocation=auto uses-permission android:name=android.permission.INTERNET / uses-permission android:name=android.permission.BLUETOOTH / -- To view, visit https://gerrit.libreoffice.org/2940 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I532f27aee60a2e60110e9edea75e7cbe7d614b1e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Use the system root certificates in Neon's ne_ssl_trust_defa...
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2741
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/2741/1
Use the system root certificates in Neon's ne_ssl_trust_default_ca() on Win32
Fixes a problem that was noticed when working on bnc#805901, which is about
documents opened from WebDAV (using https) not being locked (in the WebDAV
sense).
For some reason, at least in the 3.6 branch, I noticed that LibreOffice did
not manage to open any connection to the WebDAV server. The error message
Server error message: Server certificate verification failed: issuer is not
trusted was displayed.
Turning on Neon logging I saw the OpenSSL error code 19
(X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN) passing by.
Some googling turned up
http://stackoverflow.com/questions/4103472/ssl-handshake-fails-with-a-verisign-chain-certificate-that-contains-two-ca-s
. If I understand correctly, root certificates (which are the final ones in a
certificate chain) are by definition self-signed.
One can try this on Linux (or even on Windows, using the openssl command built
as part of the LibreOffice built):
openssl s_client -connect vibe.novell.com:443 -showcerts
and see that it also displays a message about this error: verify
error:num=19:self signed certificate in certificate chain
One can get around that by passing the -CApath option:
openssl s_client -connect vibe.novell.com:443 -showcerts -CApath /etc/ssl/certs
on Linux. There is no corresponding directory with trusted certificates as
files on Windows.
This tells OpenSSL where to find a list of trusted root certificates.
Apparently when OpenSSL is used by LibreOffice it does not use the list of
trusted root certificates that Windows knows automatically. This patch makes
it do that when ne_ssl_trust_default_ca() is called.
Change-Id: Iddbd3d61413aa52adbed3f9a0239a364e70668d8
---
M neon/neon.patch
1 file changed, 48 insertions(+), 0 deletions(-)
diff --git a/neon/neon.patch b/neon/neon.patch
index 21e66d9..95d6b55 100644
--- a/neon/neon.patch
+++ b/neon/neon.patch
@@ -373,3 +373,51 @@
/* Returns non-zero if library is built with support for the given
* NE_FEATURE_* feature code 'code'. */
+--- src/ne_openssl.c
src/ne_openssl.c
+@@ -41,6 +41,13 @@
+ #include pthread.h
+ #endif
+
++#ifdef WIN32
++#define X509_NAME WIN32_X509_NAME
++#include windows.h
++#include wincrypt.h
++#undef X509_NAME
++#endif
++
+ #include ne_ssl.h
+ #include ne_string.h
+ #include ne_session.h
+@@ -798,6 +798,31 @@
+ X509_STORE_load_locations(store, NE_SSL_CA_BUNDLE, NULL);
+ #else
+ X509_STORE_set_default_paths(store);
++#ifdef WIN32
++{
++ HCERTSTORE hStore;
++ PCCERT_CONTEXT pContext = NULL;
++ X509 *x509;
++
++ hStore = CertOpenSystemStore(0, ROOT);
++ if (hStore)
++ {
++ while (pContext = CertEnumCertificatesInStore(hStore, pContext))
++ {
++ x509 = d2i_X509(NULL, pContext-pbCertEncoded,
pContext-cbCertEncoded);
++ if (x509)
++ {
++ X509_STORE_add_cert(store, x509);
++ X509_free(x509);
++ }
++ }
++ }
++
++ CertFreeCertificateContext(pContext);
++ CertCloseStore(hStore, 0);
++}
++#endif
++
+ #endif
+ }
+
--
To view, visit https://gerrit.libreoffice.org/2741
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddbd3d61413aa52adbed3f9a0239a364e70668d8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] Resolves: #i119943 Underline can not work with ; in format...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2694 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2694 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1112739fb27939a66d22f198ec9c3a34f383bd9c Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Fridrich Strba fridr...@documentfoundation.org Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] delete previous uncommented comments in positionhelper.cxx
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2571 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2571 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f177a078b915c1220423ea583e749de4d02e384 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove dead voice command code
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2452
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/2452/1
Remove dead voice command code
I don't see voice input commands being generated anywhere. Nobody seems to
know what this code has been used for.
Change-Id: I4e4221dd4dff76086d0268be286c3605e669bae7
---
M editeng/source/editeng/impedit2.cxx
M sc/source/ui/app/inputwin.cxx
M sc/source/ui/view/gridwin.cxx
M sw/inc/pch/precompiled_sw.hxx
M sw/source/ui/docvw/edtwin.cxx
M vcl/Package_inc.mk
D vcl/inc/vcl/cmdevt.h
M vcl/inc/vcl/cmdevt.hxx
M vcl/source/control/edit.cxx
9 files changed, 2 insertions(+), 366 deletions(-)
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index 8129570..d34a387 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -49,7 +49,6 @@
#include editeng/frmdiritem.hxx
#include editeng/fontitem.hxx
#include editeng/justifyitem.hxx
-#include vcl/cmdevt.h
#include com/sun/star/i18n/CharacterIteratorMode.hpp
#include com/sun/star/i18n/WordType.hpp
@@ -348,110 +347,7 @@
{
GetSelEngine().SetCurView( pView );
SetActiveView( pView );
-if ( rCEvt.GetCommand() == COMMAND_VOICE )
-{
-const CommandVoiceData* pData = rCEvt.GetVoiceData();
-if ( pData-GetType() == VOICECOMMANDTYPE_DICTATION )
-{
-// Turn functions into KeyEvent if no corresponding method to
-// EditView/EditEngine so that Undo remains consistent.
-SfxPoolItem* pNewAttr = NULL;
-
-switch ( pData-GetCommand() )
-{
-case DICTATIONCOMMAND_UNKNOWN:
-{
-pView-InsertText( pData-GetText() );
-}
-break;
-case DICTATIONCOMMAND_NEWPARAGRAPH:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_RETURN, 0 )
) );
-}
-break;
-case DICTATIONCOMMAND_NEWLINE:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_RETURN,
KEY_SHIFT ) ) );
-}
-break;
-case DICTATIONCOMMAND_TAB:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_TAB, 0 ) )
);
-}
-break;
-case DICTATIONCOMMAND_LEFT:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_LEFT,
KEY_MOD1 ) ) );
-}
-break;
-case DICTATIONCOMMAND_RIGHT:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_RIGHT,
KEY_MOD1 ) ) );
-}
-break;
-case DICTATIONCOMMAND_UP:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_UP, 0 ) ) );
-}
-break;
-case DICTATIONCOMMAND_DOWN:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_UP, 0 ) ) );
-}
-break;
-case DICTATIONCOMMAND_UNDO:
-{
-pView-Undo();
-}
-break;
-case DICTATIONCOMMAND_DEL:
-{
-pView-PostKeyEvent( KeyEvent( 0, KeyCode( KEY_LEFT,
KEY_MOD1|KEY_SHIFT ) ) );
-pView-DeleteSelected();
-}
-break;
-case DICTATIONCOMMAND_BOLD_ON:
-{
-pNewAttr = new SvxWeightItem( WEIGHT_BOLD, EE_CHAR_WEIGHT
);
-}
-break;
-case DICTATIONCOMMAND_BOLD_OFF:
-{
-pNewAttr = new SvxWeightItem( WEIGHT_NORMAL,
EE_CHAR_WEIGHT );
-}
-break;
-case DICTATIONCOMMAND_ITALIC_ON:
-{
-pNewAttr = new SvxPostureItem( ITALIC_NORMAL,
EE_CHAR_ITALIC );
-}
-break;
-case DICTATIONCOMMAND_ITALIC_OFF:
-{
-pNewAttr = new SvxPostureItem( ITALIC_NORMAL,
EE_CHAR_ITALIC );
-}
-break;
-case DICTATIONCOMMAND_UNDERLINE_ON:
-{
-pNewAttr = new SvxUnderlineItem( UNDERLINE_SINGLE,
EE_CHAR_UNDERLINE );
-}
-break;
-case DICTATIONCOMMAND_UNDERLINE_OFF:
-{
-pNewAttr = new SvxUnderlineItem( UNDERLINE_NONE,
EE_CHAR_UNDERLINE );
-}
-break;
-}
-
-if ( pNewAttr )
-{
-SfxItemSet aSet( GetEmptyItemSet() );
-aSet.Put( *pNewAttr );
-pView-SetAttribs(
[PUSHED] [PUSHED] fdo#56886 EMF: Fixes some scaling problems of clipped region...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1886 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1886 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0139853961eb338476a9e3a5e08d3f87225f2e Gerrit-PatchSet: 5 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lennard Wasserthal wassert...@nefkom.net Gerrit-Reviewer: Lennard Wasserthal wassert...@nefkom.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Radek Doulík r...@novell.com Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] remove zenity configure option
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2174 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2174 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7769528af7987e43fee8707ce5b4e2214d43c5b4 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Matúš Kukan matus.ku...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix build
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2154 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2154 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7d228139126b3e60370b85c106bc970f4e68cce Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Luboš Luňák l.lu...@suse.cz Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] MODKEY_BigOrtho is never defined
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2126 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2126 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd7c7f634860ced0021bf6c6b99d1e0ea0615a7c Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Julien Nabet serval2...@yahoo.fr Gerrit-Reviewer: Julien Nabet serval2...@yahoo.fr Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Removed several useless macros: UNISTRING, USTR, USTR_ASCII, ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1954 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1954 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96d690bf9f9b319e9eeafcf218ec5ce87f21215f Gerrit-PatchSet: 5 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jean-Noël Rouvignac jn.rouvig...@gmail.com Gerrit-Reviewer: Jean-Noël Rouvignac jn.rouvig...@gmail.com Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0] Let's try to enable compiling the Bluetooth code for Windows
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2129 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/2129/1 Let's try to enable compiling the Bluetooth code for Windows (cherry picked from commit 17f7ee8442472e3ef743891b4d4f1a6a8c063472) Change-Id: Ic761c6c7dd17b42098adc44f7f4435b83ed3d009 --- M configure.ac 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index e7c06f2..bb3f96c 100644 --- a/configure.ac +++ b/configure.ac @@ -862,9 +862,8 @@ AC_ARG_ENABLE(sdremote-bluetooth, AS_HELP_STRING([--disable-sdremote-bluetooth], -[Determines whether to build sdremote with bluetooth support - Requires: dbus]), -,enable_sdremote_bluetooth=yes) +[Determines whether to build sdremote with bluetooth support. + Requires dbus on Linux.])) AC_ARG_ENABLE(gconf, AS_HELP_STRING([--disable-gconf], @@ -9298,12 +9297,28 @@ fi AC_SUBST(ENABLE_PACKAGEKIT) -AC_MSG_CHECKING([whether to enable sd remotecontrol]) +AC_MSG_CHECKING([whether to enable Impress remote control]) if test -n $enable_sdremote -a $enable_sdremote != no; then AC_MSG_RESULT([yes]) ENABLE_SDREMOTE=YES -AC_MSG_CHECKING([whether to enable bluetooth support in sdremote]) -if test -n $enable_sdremote_bluetooth -a $enable_sdremote_bluetooth != no; then +AC_MSG_CHECKING([whether to enable Bluetooth support in Impress remote control]) + +# If not explicitly enabled or disabled, default +if test -z $enable_sdremote_bluetooth; then +case $OS in +LINUX|WNT) +# Default to yes for these +enable_sdremote_bluetooth=yes +;; +*) +# otherwise no +enable_sdremote_bluetooth=no +;; +esac +fi +# $enable_sdremote_bluetooth is guaranteed non-empty now + +if test $enable_sdremote_bluetooth != no; then if test $OS = LINUX; then if test $ENABLE_DBUS = TRUE; then AC_MSG_RESULT([yes]) @@ -9311,7 +9326,7 @@ dnl === dnl Check for system bluez dnl === -AC_MSG_CHECKING([which bluetooth header to use]) +AC_MSG_CHECKING([which Bluetooth header to use]) if test $with_system_bluez = yes; then AC_MSG_RESULT([external]) AC_CHECK_HEADER(bluetooth/bluetooth.h, [], @@ -9325,9 +9340,8 @@ ENABLE_SDREMOTE_BLUETOOTH=NO fi else -# FIXME: should this really be disabled in everything non-Linux? -AC_MSG_RESULT([no]) -ENABLE_SDREMOTE_BLUETOOTH=NO +AC_MSG_RESULT([yes]) +ENABLE_SDREMOTE_BLUETOOTH=YES fi else AC_MSG_RESULT([no]) -- To view, visit https://gerrit.libreoffice.org/2129 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic761c6c7dd17b42098adc44f7f4435b83ed3d009 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] remove Basque autotext files, they were in English
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2116 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2116 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01d30f2cc714e0b2e283e738abd7955919c070d2 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix cross compiling with icu 50.1.2
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2112 Approvals: Joren De Cuyper: Looks good to me, but someone else must approve Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2112 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib112a2d3f9a75890591137a78b46be982b7d43df Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Ostrovsky david.ostrov...@gmx.de Gerrit-Reviewer: Joren De Cuyper joren.libreoff...@telenet.be Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] Fixed SfxDocTplService_Impl::setTitleForURL to keep all stre...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2107 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2107 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9b6abfc112f102e2bd2ae9d3080c4ed827200df Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Bosdonnat Cedric cedric.bosdon...@free.fr Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] add more missing adodb constants
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2106 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2106 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia43e1c63aa3a1f72deaa20351f9fe59fcc021b62 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Noel Power noel.po...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#55430 switches off text mode when clicking an other obje...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1344 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1344 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c8cdedbfae58165ebeda5887c1b6573832eb495 Gerrit-PatchSet: 11 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Lennard Wasserthal wassert...@nefkom.net Gerrit-Reviewer: Lennard Wasserthal wassert...@nefkom.net Gerrit-Reviewer: Radek Doulík r...@novell.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] export different first page header/footer to doc/docx
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2062 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2062 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba39bf12c2419bb480e91ccb45851ec869c40e01 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Luke Deller l...@deller.id.au Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] import different first page header/footer from doc
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2065 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2065 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6df7e9abc8f2a327a3b33e06322ca943f6f24605 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Luke Deller l...@deller.id.au Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#39370 - Fixed RTL/LTR and alignment buttons location on ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2077 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2077 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b3715e134bb45a7500b87a9e926d7940690a9af Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Issa Alkurtass ialkurt...@kacst.edu.sa Gerrit-Reviewer: Michael Meeks michael.me...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] add unittest for fdo#59240
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2078 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2078 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic287228f578c9ecb0f69a47380c890e337203b31 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Korrawit Pruegsanusak detective.conan.1...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fdo#60491: scp2: always package emboleobj library on non-WNT...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2095 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2095 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2373386102373cb49e8cd0c6bf807da2f805dda Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#38838 Some removal/replacement of the String/UniString w...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1962 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1962 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6daea312198fae3a9717bd8d4fea6371aa4cd275 Gerrit-PatchSet: 5 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jean-Noël Rouvignac jn.rouvig...@gmail.com Gerrit-Reviewer: Jean-Noël Rouvignac jn.rouvig...@gmail.com Gerrit-Reviewer: Luboš Luňák l.lu...@suse.cz Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Resolves fdo#59889 fault in dragging edge of RTL table
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1979 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1979 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If412b443ec8f82942ff80ba3aec24a9bfc053ac9 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Karthikeyan Krishnamurthi karthike...@kacst.edu.sa Gerrit-Reviewer: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH libreoffice-4-0] Add support for codesigning on Mac OS X
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2031
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/2031/1
Add support for codesigning on Mac OS X
Only sign the .app. Presumably that's enough here in the 4.0 branch.
Change-Id: I7a25c6b7bfa2047b1cb6bcb913750b1b476124f6
---
M config_host.mk.in
M configure.ac
M solenv/bin/modules/installer/simplepackage.pm
3 files changed, 73 insertions(+), 0 deletions(-)
diff --git a/config_host.mk.in b/config_host.mk.in
index d7ede5a..7b9834d 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -312,6 +312,7 @@
export LINK_X64_BINARY=@LINK_X64_BINARY@
@x_Cygwin@ export LS=@WIN_LS@
export MANDIR=@MANDIR@
+export MACOSX_CODESIGNING_IDENTITY=@MACOSX_CODESIGNING_IDENTITY@
export MACOSX_DEPLOYMENT_TARGET=@MACOSX_DEPLOYMENT_TARGET@
export MACOSX_DEPLOYMENT_TARGET_FOR_BUILD=@MACOSX_DEPLOYMENT_TARGET_FOR_BUILD@
export MACOSX_SDK_PATH=@MACOSX_SDK_PATH@
diff --git a/configure.ac b/configure.ac
index 5bdbd37..e7c06f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1081,6 +1081,15 @@
[Enable MSI with LIMITUI=1 (silent install).]),
,)
+AC_ARG_ENABLE(macosx-code-signing,
+AS_HELP_STRING([--enable-macosx-code-signing=identity],
+[Sign the app bundle being stored in the disk image. The
+ default is to do signing if there is a suitable certificate
+ in your keychain, so if you don't want that, use the
+ corresponding --disable option. Experimental work in
+ progress, don't use unless you are working on this.]),
+,)
+
AC_ARG_ENABLE(postgresql-sdbc,
AS_HELP_STRING([--disable-postgresql-sdbc],
[Disable the build of the PostgreSQL-SDBC driver.])
@@ -2822,6 +2831,31 @@
fi
AC_MSG_NOTICE([MAC_OS_X_VERSION_MIN_REQUIRED=$MAC_OS_X_VERSION_MIN_REQUIRED])
AC_MSG_NOTICE([MAC_OS_X_VERSION_MAX_ALLOWED=$MAC_OS_X_VERSION_MAX_ALLOWED])
+
+AC_MSG_CHECKING([whether to do code signing])
+
+if test -z $enable_macosx_code_signing -o $enable_macosx_code_signing
= yes; then
+# By default use the first suitable certificate (?).
+
+#
http://stackoverflow.com/questions/13196291/difference-between-mac-developer-and-3rd-party-mac-developer-application
+# says that the Mac Developer certificate is useful just for
self-testing. For distribution
+# outside the Mac App Store, use the Developer ID Application one,
and for distribution in
+# the App Store, the 3rd Party Mac Developer one. I think it works
best to the the
+# Developer ID Application one.
+
+identity=`security find-identity -p codesigning -v 2/dev/null | grep
'Developer ID Application:' | awk '{print $2}' |head -1`
+if test -n $identity; then
+MACOSX_CODESIGNING_IDENTITY=$identity
+pretty_name=`security find-identity -p codesigning -v | grep
$MACOSX_CODESIGNING_IDENTITY | sed -e 's/^[[^]]*//' -e 's///'`
+AC_MSG_RESULT([yes, using the identity
$MACOSX_CODESIGNING_IDENTITY for $pretty_name])
+fi
+elif test -n $enable_macosx_code_signing; then
+MACOSX_CODESIGNING_IDENTITY=$enable_macosx_code_signing
+pretty_name=`security find-identity -p codesigning -v | grep
$MACOSX_CODESIGNING_IDENTITY | sed -e 's/^[[^]]*//' -e 's///'`
+AC_MSG_RESULT([yes, using the identity $MACOSX_CODESIGNING_IDENTITY
for $pretty_name])
+else
+AC_MSG_RESULT([no])
+fi
fi
AC_SUBST(FRAMEWORKSHOME)
AC_SUBST(MACOSX_SDK_PATH)
@@ -2830,6 +2864,7 @@
AC_SUBST(MAC_OS_X_VERSION_MIN_REQUIRED)
AC_SUBST(MAC_OS_X_VERSION_MAX_ALLOWED)
AC_SUBST(XCRUN)
+AC_SUBST(MACOSX_CODESIGNING_IDENTITY)
dnl ===
dnl Windows specific tests and stuff
diff --git a/solenv/bin/modules/installer/simplepackage.pm
b/solenv/bin/modules/installer/simplepackage.pm
index 561b0fe..26911a4 100755
--- a/solenv/bin/modules/installer/simplepackage.pm
+++ b/solenv/bin/modules/installer/simplepackage.pm
@@ -418,6 +418,43 @@
chdir $localfrom;
}
+ else
+ {
+ if (defined($ENV{'MACOSX_CODESIGNING_IDENTITY'}))
+ {
+ # Just sign the .app as a whole, which means signing
+ # the CFBundleExecutable from Info.plist,
+ # i.e. soffice, plus the contents of the Resources
+ # treee (which is not much, far from all of our
+ # non-code resources).
+
+ # Don't bother here in the 4.0 branch to sign each
+ # individual .dylib, or each additional binary. See
+ # master for more work plus possibly eventually
+ # re-organising the app bundle structure to be more
+ # Mac-like (the program symlink, eek!) and actually
+ # putting all non-code resources (including extension
+ # scripts!) into Resources so that they participate
[PUSHED libreoffice-4-0] resolve fdo#60379 Impress Remote: Options look disabled
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2030 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2030 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb760fd0a0fa1430b77838a0340cc0956a0201a7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Joren De Cuyper joren.libreoff...@telenet.be Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[libreoffice-4-0]: fdo#46706 Windows 2000 is not supported any more
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1939 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1939 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeb45c0c2e7aef67d2e68bb5d104c5c3c2752dc4 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Andras Timar ati...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[libreoffice-4-0]: Do not call putenv with a temporary string argument
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1917 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1917 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93fd4e1caef016bd0e00bf09800b9532824ac4b Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Stephan Bergmann sberg...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[libreoffice-4-0]: fdo#51232: i#119987# fix Impress crash when pasting text und...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1897 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1897/1 fdo#51232: i#119987# fix Impress crash when pasting text under Outline view Patch by: Wang Zhe Testing by: Yan Ji Review by: hdu (cherry picked from commit 484621239c7f743f44579d2b199b0347dc4734cd) Change-Id: I340de4f1b626defa52ecc48938c63ec4d1ce5c1d Signed-off-by: Tor Lillqvist t...@iki.fi --- M sd/source/ui/view/outlnvs2.cxx 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/sd/source/ui/view/outlnvs2.cxx b/sd/source/ui/view/outlnvs2.cxx index 5a2061e..a514bb2 100644 --- a/sd/source/ui/view/outlnvs2.cxx +++ b/sd/source/ui/view/outlnvs2.cxx @@ -243,6 +243,7 @@ else xPresentation-rehearseTimings(); } +Cancel(); rReq.Done(); } break; -- To view, visit https://gerrit.libreoffice.org/1897 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I340de4f1b626defa52ecc48938c63ec4d1ce5c1d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] default to --without-help and --without-myspell-dicts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1791 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1791 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I446e912d607ce7358fd11f54a3de025dc3f25144 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] disable odk if not explicitly requested and doxygen not in P...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1789 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1789 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f04ecc8dbe959001f6dfdccf0c97b61f79faff6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Kill the ancient StarOffice patch concept
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1605 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1605/1 Kill the ancient StarOffice patch concept For Windows, superseded by Windows Installer patching (i.e., creating .msp files), which is something completely different. (And quite hard to get working... but still a saner approach, I think.) For Linux, many distros use delta RPMs or similar, so no home-grown LO-specific patching mechanism is needed. Remove the -patch and -patchinc command-line options to make_installer.pl and all code that was invoked only when using those. Remove the PATCH and PATCH_ONLY flags in scp2. Remove the patchmsi.dll Windows Installer custom action. Change-Id: I09e949e601a969f88eff60067faa2352f4f89537 --- M android/experimental/DocumentLoader/Makefile M android/experimental/LibreOffice4Android/Makefile M android/qa/desktop/Makefile M ios/CustomTarget_Viewer_app.mk M scp2/inc/macros.inc M scp2/source/activex/file_activex.scp M scp2/source/calc/registryitem_calc.scp M scp2/source/draw/registryitem_draw.scp M scp2/source/impress/registryitem_impress.scp M scp2/source/ooo/common_brand.scp M scp2/source/ooo/directory_ooo_macosx.scp M scp2/source/ooo/file_library_ooo.scp M scp2/source/ooo/file_ooo.scp M scp2/source/ooo/module_hidden_ooo.scp M scp2/source/ooo/windowscustomaction_ooo.scp M scp2/source/smoketest/smoketest.scp M scp2/source/writer/registryitem_writer.scp M setup_native/prj/build.lst M setup_native/source/win32/customactions/languagepacks/respintest.cxx D setup_native/source/win32/customactions/patch/exports.dxp D setup_native/source/win32/customactions/patch/makefile.mk D setup_native/source/win32/customactions/patch/swappatchfiles.cxx M solenv/bin/modules/installer.pm M solenv/bin/modules/installer/archivefiles.pm M solenv/bin/modules/installer/control.pm M solenv/bin/modules/installer/epmfile.pm M solenv/bin/modules/installer/globals.pm M solenv/bin/modules/installer/parameter.pm M solenv/bin/modules/installer/scriptitems.pm M solenv/bin/modules/installer/simplepackage.pm M solenv/bin/modules/installer/systemactions.pm M solenv/bin/modules/installer/windows/createfolder.pm M solenv/bin/modules/installer/windows/directory.pm M solenv/bin/modules/installer/windows/feature.pm M solenv/bin/modules/installer/windows/idtglobal.pm M solenv/bin/modules/installer/windows/inifile.pm M solenv/bin/modules/installer/windows/mergemodule.pm M solenv/bin/modules/installer/windows/msiglobal.pm M solenv/bin/modules/installer/windows/property.pm M solenv/bin/modules/installer/windows/upgrade.pm M solenv/bin/modules/installer/worker.pm M solenv/bin/modules/installer/ziplist.pm D solenv/bin/oochkpatch D solenv/bin/oochkpatch.pl 44 files changed, 65 insertions(+), 2,554 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1605 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I09e949e601a969f88eff60067faa2352f4f89537 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[libreoffice-4-0]: Make sure that *in this branch* we don't use too new tools
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1573
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1573/1
Make sure that *in this branch* we don't use too new tools
This is the branch for 4.0.x and we want to use the VS 2010 compiler
here.
I think that we also don't want to use anyhing newer than Windows SDK
7.1, and .NET Framework 3.5, just to be sure.
Change-Id: I1b94af040829182c0f74edb94843b308251ad8a4
---
M oowintool
1 file changed, 21 insertions(+), 84 deletions(-)
diff --git a/oowintool b/oowintool
index 26221f0..6eed9cb 100755
--- a/oowintool
+++ b/oowintool
@@ -87,25 +87,11 @@
sub print_windows_sdk_home()
{
-my ($value, $key);
+my ($value);
-# This is for the Windows SDK 8 distributed with MSVS 2012
-$value = reg_get_value ('HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Windows
Kits/Installed Roots/KitsRoot');
-
- if (!defined $value) {
-$value = reg_get_value
('HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Microsoft
SDKs/Windows/CurrentInstallFolder');
-}
-if (!defined $value) {
-$value = reg_get_value
('HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/Directories/Install Dir');
-}
-
-if (!defined $value) {
-# Unclear whether we ever get here, don't the above match any
-# recent Windows SDK?
-foreach $key
(File::Glob::bsd_glob('/proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/InstalledSDKs/*/Install
Dir')) {
-$value = reg_get_value ($key);
-last if defined $value;
-}
+foreach $ver (qw(7.1A 7.1 7.0A 7.0 6.0A)) {
+$value = reg_get_value
(HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Microsoft
SDKs/Windows/v$ver/InstallationFolder);
+last if defined $value;
}
defined $value || die Windows SDK not found;
@@ -121,52 +107,19 @@
my ($value, $key);
-foreach $key
(File::Glob::bsd_glob('/proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Microsoft
SDKs/Windows/*/WinSDK-NetFx40Tools/InstallationFolder')) {
-$key =~ s!^/proc/registry/!!;
-$value = reg_get_value ($key);
+$value = reg_get_value('HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Microsoft
SDKs/Windows/v7.0A/WinSDK-NetFx35Tools/InstallationFolder');
-# Sigh, the same test that configure does for al.exe
-# being either directly in it, or in a bin subdir... But on
-# the other hand we don't want to be mislead by a registry key
-# that matches the above but points to a directory that does
-# in fact not contain an al.exe. For me,
-# HKLM/SOFTWARE/Microsoft/Microsoft
SDKs/Windows/v7.0A/WinSDK-NetFx40Tools/InstallationFolder
-# contains
-# c:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\NETFX 4.0
Tools\
-# but that then does not contain any al.exe.
+if (!defined $value) {
+$value =
reg_get_value('HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/Microsoft
SDKs/Windows/v6.0A/WinSDKNetFxTools/InstallationFolder');
+}
-if (-f $value/bin/al.exe || -f $value/al.exe) {
-print cygpath ($value, 'w', $output_format);
-return;
-}
+if (-f $value/bin/al.exe || -f $value/al.exe) {
+print cygpath ($value, 'w', $output_format);
+return;
}
die Can't find al.exe;
}
-my %msvs_2008 = (
-'ver' = '9.0',
-'key' = 'Microsoft/VisualStudio/9.0/Setup/VS/ProductDir',
-'dll_path' = 'VC/redist/x86/Microsoft.VC90.CRT',
-'dll_suffix' = '90'
-);
-my %msvc_2008 = (
-'ver' = '9.0',
-'key' = 'Microsoft/VisualStudio/9.0/Setup/VC/ProductDir',
-'dll_path' = 'redist/x86/Microsoft.VC90.CRT',
-'dll_suffix' = '90'
-);
-my %msvs_express_2008 = (
-'ver' = '9.0',
-'key' = 'Microsoft/VCExpress/9.0/Setup/VS/ProductDir',
-'dll_path' = 'VC/redist/x86/Microsoft.VC90.CRT',
-'dll_suffix' = '90'
-);
-my %msvc_express_2008 = (
-'ver' = '9.0',
-'key' = 'Microsoft/VCExpress/9.0/Setup/VC/ProductDir',
-'dll_path' = 'redist/x86/Microsoft.VC90.CRT',
-'dll_suffix' = '90'
-);
my %msvs_2010 = (
'ver' = '10.0',
'key' = 'Microsoft/VisualStudio/10.0/Setup/VS/ProductDir',
@@ -179,22 +132,10 @@
'dll_path' = 'redist/x86/Microsoft.VC100.CRT',
'dll_suffix' = '100'
);
-my %msvs_2012 = (
-'ver' = '11.0',
-'key' = 'Microsoft/VisualStudio/11.0/Setup/VS/ProductDir',
-'dll_path' = 'VC/redist/x86/Microsoft.VC110.CRT',
-'dll_suffix' = '110'
-);
-my %msvc_2012 = (
-'ver' = '11.0',
-'key' = 'Microsoft/VisualStudio/11.0/Setup/VC/ProductDir',
-'dll_path' = 'redist/x86/Microsoft.VC110.CRT',
-'dll_suffix' = '110'
-);
sub find_msvs()
{
-my @ms_versions = ( \%msvs_2010, \%msvs_2012, \%msvs_2008,
\%msvs_express_2008 );
+my @ms_versions = ( \%msvs_2010 );
for $ver (@ms_versions) {
my $install = reg_get_value (HKEY_LOCAL_MACHINE/SOFTWARE/ .
$ver-{'key'});
@@
[PATCH] Change in core[libreoffice-4-0]: Use MSBuild from .NET Framework 4.0
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1591 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/1591/1 Use MSBuild from .NET Framework 4.0 Otherwise building these external projects fails, at least for me. Change-Id: I20ea889537badf2713101b3296604a855451ae2f --- M lcms2/ExternalProject_lcms2.mk M libcdr/ExternalProject_libcdr.mk M liborcus/ExternalProject_liborcus.mk M libvisio/ExternalProject_libvisio.mk M libwpd/ExternalProject_libwpd.mk M python3/ExternalProject_python3.mk 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lcms2/ExternalProject_lcms2.mk b/lcms2/ExternalProject_lcms2.mk index c8d93eb..80a98e1 100644 --- a/lcms2/ExternalProject_lcms2.mk +++ b/lcms2/ExternalProject_lcms2.mk @@ -20,7 +20,7 @@ ifeq ($(filter-out 14 13,$(COMEX)),) $(call gb_ExternalProject_get_state_target,lcms2,build): cd $(EXTERNAL_WORKDIR)/Projects/VC2010/lcms2_DLL \ -MSBuild.exe lcms2_DLL.vcxproj /p:Configuration=Release /p:Platform=Win32 /p:TargetName=lcms2 \ +'/cygdrive/c/Windows/Microsoft.NET/Framework/v4.0.30319/MSBuild.exe' lcms2_DLL.vcxproj /p:Configuration=Release /p:Platform=Win32 /p:TargetName=lcms2 \ $(if $(filter 14,$(COMEX)),/p:PlatformToolset=v110) \ touch $@ else diff --git a/libcdr/ExternalProject_libcdr.mk b/libcdr/ExternalProject_libcdr.mk index f4dcab5..9d46d56 100644 --- a/libcdr/ExternalProject_libcdr.mk +++ b/libcdr/ExternalProject_libcdr.mk @@ -39,7 +39,7 @@ export LIBWPG_INCLUDE_DIR=$(OUTDIR)/inc/external \ export LCMS2_INCLUDE_DIR=$(call gb_UnpackedTarball_get_dir,lcms2/include) \ export ZLIB_INCLUDE_DIR=$(OUTDIR)/inc/external/zlib \ -msbuild.exe libcdr.vcxproj /p:Configuration=Release \ +'/cygdrive/c/Windows/Microsoft.NET/Framework/v4.0.30319/msbuild.exe' libcdr.vcxproj /p:Configuration=Release \ touch $@ else $(call gb_ExternalProject_get_state_target,libcdr,build) : diff --git a/liborcus/ExternalProject_liborcus.mk b/liborcus/ExternalProject_liborcus.mk index 0c64d86..ebdfd4d 100644 --- a/liborcus/ExternalProject_liborcus.mk +++ b/liborcus/ExternalProject_liborcus.mk @@ -34,7 +34,7 @@ export ZLIB_INCLUDE_DIR=$(OUTDIR)/inc/external/zlib \ export BOOST_LIB_DIR=$(OUTDIR)/lib \ $(COMPATH)/../Common7/Tools/vcupgrade.exe liborcus-static-nozip.vcproj \ -MSBuild.exe liborcus-static-nozip.vcxproj /p:Configuration=Release /p:OutDir=Release/ /p:TargetName=orcus /p:WholeProgramOptimization=no \ +'/cygdrive/c/Windows/Microsoft.NET/Framework/v4.0.30319/MSBuild.exe' liborcus-static-nozip.vcxproj /p:Configuration=Release /p:OutDir=Release/ /p:TargetName=orcus /p:WholeProgramOptimization=no \ touch $@ endif diff --git a/libvisio/ExternalProject_libvisio.mk b/libvisio/ExternalProject_libvisio.mk index 191a712..48aaf8a 100644 --- a/libvisio/ExternalProject_libvisio.mk +++ b/libvisio/ExternalProject_libvisio.mk @@ -39,7 +39,7 @@ export LIBWPG_INCLUDE_DIR=$(OUTDIR)/inc/external \ export LIBXML_INCLUDE_DIR=$(OUTDIR)/inc/extrenal \ export ZLIB_INCLUDE_DIR=$(OUTDIR)/inc/external/zlib \ -msbuild.exe libvisio.vcxproj /p:Configuration=Release \ +'/cygdrive/c/Windows/Microsoft.NET/Framework/v4.0.30319/msbuild.exe' libvisio.vcxproj /p:Configuration=Release \ touch $@ else $(call gb_ExternalProject_get_state_target,libvisio,build) : diff --git a/libwpd/ExternalProject_libwpd.mk b/libwpd/ExternalProject_libwpd.mk index 08d506c..4d11ff1 100644 --- a/libwpd/ExternalProject_libwpd.mk +++ b/libwpd/ExternalProject_libwpd.mk @@ -25,7 +25,7 @@ else ifeq ($(VCVER),100) $(call gb_ExternalProject_get_state_target,libwpd,build) : cd $(EXTERNAL_WORKDIR)/build/win32 \ -msbuild.exe libwpd.vcxproj /p:Configuration=Release \ +'/cygdrive/c/Windows/Microsoft.NET/Framework/v4.0.30319/msbuild.exe' libwpd.vcxproj /p:Configuration=Release \ touch $@ else $(call gb_ExternalProject_get_state_target,libwpd,build) : diff --git a/python3/ExternalProject_python3.mk b/python3/ExternalProject_python3.mk index 2bde4cf..e4ba16d 100644 --- a/python3/ExternalProject_python3.mk +++ b/python3/ExternalProject_python3.mk @@ -32,7 +32,7 @@ touch $@ else ifeq ($(VCVER),100) cd $(EXTERNAL_WORKDIR)/PCbuild \ -MAKEFLAGS= MSBuild.exe pcbuild.sln /t:Build /p:Configuration=Release /ToolsVersion:4.0 \ +MAKEFLAGS= '/cygdrive/c/Windows/Microsoft.NET/Framework/v4.0.30319/MSBuild.exe' pcbuild.sln /t:Build /p:Configuration=Release /ToolsVersion:4.0 \ cd $(EXTERNAL_WORKDIR) \ ln -s PCbuild LO_lib \ touch $@ -- To view, visit https://gerrit.libreoffice.org/1591 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20ea889537badf2713101b3296604a855451ae2f Gerrit-PatchSet: 1 Gerrit-Project: core
Change in core[libreoffice-4-0]: Use MSBuild from .NET Framework 4.0
Tor Lillqvist has abandoned this change. Change subject: Use MSBuild from .NET Framework 4.0 .. Patch Set 1: Abandoned . -- To view, visit https://gerrit.libreoffice.org/1591 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I20ea889537badf2713101b3296604a855451ae2f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Get rid of nsinstall hackery
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1534 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1534 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c9fdb575223f2940d3e4eda00e77ba9158f2b7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#50415: Add Catalan translations of keyboard shortcuts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1543 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1543 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Change in core[libreoffice-4-0]: fdo#50415: Add Catalan translations of keyboard shortcuts
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1544 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1544 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeab5b84674d26e4d29324614641813d8b65c517 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Jesús Corrius jcorr...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Change in core[libreoffice-3-6]: fix for fdo#57836 throw when attempting to store basicide mo...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1538 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1538 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8769a63be61d45817757be3ad23ffc7b01173041 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Noel Power noel.po...@suse.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Change in core[libreoffice-4-0]: Minimal fix fdo#58766 Macro Recorder opt not saved
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1540 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1540 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic405387248071ac2f5b47601eb1364bf0d7ea5d6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: LeMoyne Castle lemoyne.cas...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Paren fix for Ubu 10.04 build (and fdo#58417 ?)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1531 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1531 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d8b979df0fc827758b1e9a336031671425486ea Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: LeMoyne Castle lemoyne.cas...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix 'DEBUGCPPUNIT=TRUE make subsequenttest'
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1532 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1532 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3f81ba3fc3e5260142d7e9c2d4a78e9ca63382c Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Noel Grandin noelgran...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Minimal fix fdo#58766 Macro Recorder opt not saved
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1523 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1523 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If99e0aa89e82ffc362f5e4bda712881a546e510a Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: LeMoyne Castle lemoyne.cas...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1519 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1519 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I192994238b949ffc51697a356a2f49072d5cedb2 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ioan.rad...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#57950: remove consecutive append in basctl with StringBu...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1486 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1486 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43464dd702c6b4a63df39b6a4b35bec63712d5e6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] convert icu to gbuild and add to tail_build
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1488 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1488 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7d8bc05b1393cc2bae4a531c8a47f62df24b1d6 Gerrit-PatchSet: 5 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: Peter Foley pefol...@verizon.net Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Replase GUIBASE checks with equivalent OS checks
Tor Lillqvist has abandoned this change. Change subject: Replase GUIBASE checks with equivalent OS checks .. Patch Set 1: Abandoned Superseded. -- To view, visit https://gerrit.libreoffice.org/1303 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie27f05d29e08d6d28a2de81db530811b63fa4b69 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Michael Stahl mst...@redhat.com Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[libreoffice-4-0]: fdo#56937 - mac a11y hang related to traversing vast, broken...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1401 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1401/1 fdo#56937 - mac a11y hang related to traversing vast, broken hierarchies. Change-Id: Iff0537a69b2c6ae929da6a05f26c0d55415d6d8a Signed-off-by: Tor Lillqvist t...@iki.fi --- M sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx M sc/source/ui/Accessibility/AccessibleTableBase.cxx M vcl/aqua/source/a11y/aqua11ywrapper.mm 3 files changed, 44 insertions(+), 15 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1401 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iff0537a69b2c6ae929da6a05f26c0d55415d6d8a Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Tor Lillqvist t...@iki.fi Gerrit-Reviewer: Michael Meeks michael.me...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Replase GUIBASE checks with equivalent OS checks
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1303 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1303/1 Replase GUIBASE checks with equivalent OS checks The idea is to get rid of GUIBASE and GUI checks as much as possible. GUIBASE=aqua = OS=MACOSX GUIBASE=WIN = OS=WNT GUIBASE=cocoatouch = OS=IOS GUIBASE=android = OS=ANDROID Don't set GUIBASE to these values any more in configure.ac either. GUIBASE_FOR_BUILD is not used anywhere. Change-Id: Ie27f05d29e08d6d28a2de81db530811b63fa4b69 --- M Repository.mk M apple_remote/Module_apple_remote.mk M avmedia/Module_avmedia.mk M cairo/cairo/makefile.mk M cairo/pixman/makefile.mk M config_host.mk.in M configure.ac M desktop/Library_sofficeapp.mk M extensions/Library_pl.mk M extensions/Module_extensions.mk M fpicker/Module_fpicker.mk M lingucomponent/Module_lingucomponent.mk M np_sdk/StaticLibrary_nputils.mk M postprocess/packcomponents/makefile.mk M postprocess/packregistry/makefile.mk M solenv/inc/lang.mk M toolkit/Library_tk.mk M vcl/Library_vcl.mk M vcl/Module_vcl.mk M writerfilter/qa/cppunittests/odiapi/makefile.mk 20 files changed, 39 insertions(+), 44 deletions(-) -- To view, visit https://gerrit.libreoffice.org/1303 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie27f05d29e08d6d28a2de81db530811b63fa4b69 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Get rid of (most uses of) GUI
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1304 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1304/1 Get rid of (most uses of) GUI GUI only takes values UNX or WNT, so it is fairly pointless. One can check whether OS is WNT or not instead. Change-Id: I78ae32c03536a496a563e5deeb0fca78aebf9c34 --- M RepositoryExternal.mk M autodoc/source/exes/adc_uni/makefile.mk M avmedia/Library_avmediagst.mk M avmedia/Library_avmediagst_0_10.mk M basic/CppunitTest_basic_coverage.mk M basic/CppunitTest_basic_enable.mk M basic/CppunitTest_basic_nested_struct.mk M basic/CppunitTest_basic_scanner.mk M basic/Library_sb.mk M bean/Library_officebean.mk M bean/test/applet/oooapplet/makefile.mk M bootstrap M bridges/Library_java_uno.mk M bridges/test/java_uno/acquire/makefile.mk M bridges/test/java_uno/any/makefile.mk M bridges/test/java_uno/equals/makefile.mk M bridges/test/java_uno/nativethreadpool/makefile.mk M cairo/cairo/makefile.mk M cairo/pixman/makefile.mk M canvas/workben/makefile.mk M connectivity/Library_postgresql-sdbc-impl.mk M connectivity/Module_connectivity.mk M cppuhelper/test/bootstrap/makefile.mk M cppuhelper/test/loader/makefile.mk M cppuhelper/test/makefile.mk M cppuhelper/test/testcmp/makefile.mk M cppuhelper/test/testdefaultbootstrapping.pl M cppuhelper/test/testlib/makefile.mk M cui/Library_cui.mk M curl/ExternalPackage_curl.mk M curl/ExternalProject_curl.mk M dbaccess/Library_dbu.mk M dbaccess/Module_dbaccess.mk M desktop/Executable_oosplash.mk M desktop/Library_sofficeapp.mk M dtrans/Library_mcnttype.mk M extensions/Executable_nsplugin.mk M extensions/Library_npsoplugin.mk M extensions/Library_pl.mk M extensions/Library_scn.mk M extensions/Module_extensions.mk M extensions/StaticLibrary_plugcon.mk M extensions/qa/complex/extensions/makefile.mk M external/mingw-dlls/makefile.mk M helpcompiler/source/HelpCompiler.cxx M hunspell/ExternalProject_hunspell.mk M icu/makefile.mk M instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk M instsetoo_native/util/makefile.mk M jvmfwk/Library_sunjavaplugin.mk M jvmfwk/Package_rcfiles.mk M liblangtag/ExternalPackage_langtag.mk M liblangtag/ExternalProject_langtag.mk M liblangtag/UnpackedTarball_langtag.mk M libxslt/makefile.mk M lpsolve/ExternalPackage_lpsolve.mk M lpsolve/ExternalProject_lpsolve.mk M lpsolve/UnpackedTarball_lpsolve.mk M lpsolve/lp_solve_5.5.patch M mysqlc/source/makefile.mk M mysqlcppconn/mysql-connector-c++-1.1.0.patch M mysqlcppconn/mysql_config.pmk M nss/makefile.mk M odk/pack/copying/makefile.mk M odk/util/makefile.pmk M postprocess/packcomponents/makefile.mk M postprocess/signing/makefile.mk M pyuno/CustomTarget_zipcore.mk M pyuno/Library_pyuno_wrapper.mk M pyuno/Module_pyuno.mk M pyuno/Package_python_scripts.mk M readlicense_oo/CustomTarget_readme.mk M readlicense_oo/Package_readme.mk M redland/raptor/makefile.mk M redland/rasqal/makefile.mk M redland/redland/makefile.mk M registry/workben/makefile.mk M rsc/Executable_rsc.mk M sal/Library_sal.mk M sal/qa/buildall.pl M sal/qa/osl/socket/osl_AcceptorSocket.cxx M sal/qa/osl/socket/osl_ConnectorSocket.cxx M sal/qa/osl/socket/osl_DatagramSocket.cxx M sal/qa/osl/socket/osl_Socket.cxx M sal/qa/osl/socket/osl_Socket2.cxx M sal/qa/osl/socket/osl_SocketAddr.cxx M sal/qa/osl/socket/osl_StreamSocket.cxx M sal/test/bootstrap.pl M sal/test/makefile.mk M sal/workben/makefile.mk M sane/Module_sane.mk M sc/workben/makefile.mk M scp2/InstallModule_javafilter.mk M scp2/InstallModule_ooo.mk M scp2/InstallModule_python.mk M scp2/InstallScript_setup_osl.mk M scp2/Module_scp2.mk M sd/Library_sd.mk M sd/Library_sdui.mk M sd/workben/testdll/makefile M setup_native/source/win32/customactions/indexingfilter/makefile.mk M setup_native/source/win32/customactions/javafilter/makefile.mk M setup_native/source/win32/customactions/languagepacks/makefile.mk M setup_native/source/win32/customactions/patch/makefile.mk M setup_native/source/win32/customactions/quickstarter/makefile.mk M setup_native/source/win32/customactions/reg4allmsdoc/makefile.mk M setup_native/source/win32/customactions/regactivex/makefile.mk M setup_native/source/win32/customactions/regpatchactivex/makefile.mk M setup_native/source/win32/customactions/sellang/makefile.mk M setup_native/source/win32/customactions/shellextensions/makefile.mk M setup_native/source/win32/customactions/thesaurus/makefile.mk M setup_native/source/win32/customactions/tools/makefile.mk M shell/Module_shell.mk M solenv/Module_solenv.mk M solenv/bin/build.pl M solenv/bin/deliver.pl M solenv/bin/modules/installer/control.pm M solenv/bin/modules/installer/environment.pm M solenv/bin/ooinstall M solenv/inc/_tg_app.mk M solenv/inc/_tg_def.mk M solenv/inc/_tg_lib.mk M solenv/inc/_tg_rslb.mk M solenv/inc/_tg_shl.mk M solenv/inc/_tg_zip.mk M solenv/inc/extension_post.mk M solenv/inc/extension_pre.mk M solenv/inc/lang.mk M solenv/inc/libs.mk M solenv/inc/pstrules.mk M solenv/inc/rules.mk M
