core.git: sc/inc sc/source

2024-02-16 Thread Winfried Donkers (via logerrit)
(-) New commits: commit 88ba9fab08514b96f458bb8c0ace175b2790638e Author: Winfried Donkers AuthorDate: Sun Feb 11 16:18:44 2024 +0100 Commit: Balazs Varga CommitDate: Fri Feb 16 11:01:17 2024 +0100 Prepare search code for other functions than MATCH and XLOOKUP. Purpose

core.git: formula/inc include/formula sc/inc sc/qa sc/README.md sc/source

2024-01-31 Thread Winfried Donkers (via logerrit)
/source/filter/excel/xlformula.cxx| 13 sc/source/filter/oox/formulabase.cxx| 15 20 files changed, 5816 insertions(+), 343 deletions(-) New commits: commit f7039822c7ad3987326e1c20ea4a745c158f9682 Author: Winfried Donkers AuthorDate: Wed Jun 28 16:13

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sc/qa sc/source

2023-01-16 Thread Winfried Donkers (via logerrit)
- 4 files changed, 152 insertions(+), 23 deletions(-) New commits: commit a5103adc413fb2cc8811c8691de5bfbe2df51961 Author: Winfried Donkers AuthorDate: Sat Dec 31 15:54:57 2022 +0100 Commit: Xisco Fauli CommitDate: Mon Jan 16 08:40:21 2023 + tdf#152774 Fix incorrect result

[Libreoffice-commits] core.git: sc/qa sc/source

2023-01-15 Thread Winfried Donkers (via logerrit)
bf432958c1d6d204511a6bb32e2c06161d811676 Author: Winfried Donkers AuthorDate: Sat Jan 14 18:01:12 2023 +0100 Commit: Eike Rathke CommitDate: Sun Jan 15 16:02:49 2023 + tdf#152774 Fix incorrect result with HLOOKUP and VLOOKUP. Use case now complies with ODF 6.9.5 (HLOOKUP

[Libreoffice-commits] core.git: sc/qa sc/source

2023-01-12 Thread Winfried Donkers (via logerrit)
sc/qa/unit/data/functions/spreadsheet/fods/match.fods | 46 +- sc/source/core/tool/interpr1.cxx |6 +- 2 files changed, 40 insertions(+), 12 deletions(-) New commits: commit 0ce4c1e6898ba83d487f1b225dc9ee0bbc00d9fc Author: Winfried Donkers

Re: behaviour of Calc function MATCH

2022-12-21 Thread Winfried Donkers
Hi Eike, the functions MATCH and VLOOKUP. =MATCH("b";{1,2,"d","e"};1) returns 2, which is in accordance with https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#__RefHeading__1018430_715980110 But =MATCH("b",B1:B4;1) with B1:B4

behaviour of Calc function MATCH

2022-12-16 Thread Winfried Donkers
I am working on implementing XLOOKUP in Calc. Therefore I need to change some existing code (to avoid lots of nearly identical code) and I came across a behaviour that I don't understand with the functions MATCH and VLOOKUP. =MATCH("b";{1,2,"d","e"};1) returns 2, which is in accordance with

ScQueryCellIteratorBase::BinarySearch

2022-11-01 Thread Winfried Donkers
Hi, To implement the function XLOOKUP in Calc (tdf127293) I need to change ScQueryCellIteratorBase::BinarySearch(). In BinarySearch() at each iteration a check is performed to see whether the range really is sorted; if not orderBroken gets the value true. The current check is not reliable.

Re: Need help with ScLookupCache

2022-06-29 Thread Winfried Donkers
Luboš, Eike, Op 21-06-2022 om 15:12 schreef Winfried Donkers: Am I correct when stating that ScLookupCache currently cannot cope with the combinations   eOp SC_GREATER_EQUAL and sorted in ascending order and   eOp SC_LESSER_EQUAL and sorted in descending order? As Luboš already said

Re: Need help with ScLookupCache

2022-06-21 Thread Winfried Donkers
Am I correct when stating that ScLookupCache currently cannot cope with the combinations eOp SC_GREATER_EQUAL and sorted in ascending order and eOp SC_LESSER_EQUAL and sorted in descending order? As Luboš already said, ScLookupCache just caches results of lookups, to be able to reuse them

Re: Need help with ScLookupCache

2022-06-20 Thread Winfried Donkers
Hi Luboš, Am I correct when stating that ScLookupCache currently cannot cope with the combinations eOp SC_GREATER_EQUAL and sorted in ascending order and eOp SC_LESSER_EQUAL and sorted in descending order? No, it's not correct, why would you think that would be the case? As the name

Need help with ScLookupCache

2022-06-16 Thread Winfried Donkers
Hi, I am implementing Excel function XLOOKUP in Calc (at a slow pace), and need some help with ScLookupCache. Am I correct when stating that ScLookupCache currently cannot cope with the combinations eOp SC_GREATER_EQUAL and sorted in ascending order and eOp SC_LESSER_EQUAL and sorted in

gerrit: pull, change, commit --amend and submit after many changes in master since first submit to gerrit

2022-04-20 Thread Winfried Donkers
Hi, I have submitted a patch to gerrit weeks ago and I now want to change some of it (the patch in gerrit is still active). When pulling the patch from gerrit, I get a merge commit. I can change my patch, but how do I update the patch (I normally use 'git commit path_or_-a --amend' for this,

[Libreoffice-commits] core.git: sc/qa sc/source

2022-02-10 Thread Winfried Donkers (via logerrit)
sc/qa/unit/data/functions/text/fods/clean.fods | 1085 ++--- sc/source/core/tool/interpr1.cxx | 19 2 files changed, 833 insertions(+), 271 deletions(-) New commits: commit 61f4250ee9f43902107e4d2e6322cbf54f52dd8e Author: Winfried Donkers AuthorDate: Mon

[Libreoffice-commits] core.git: sc/qa sc/source

2022-01-24 Thread Winfried Donkers (via logerrit)
sc/qa/unit/data/functions/text/fods/clean.fods | 3438 ++--- sc/source/core/tool/interpr1.cxx |3 2 files changed, 2532 insertions(+), 909 deletions(-) New commits: commit 34412339f863b35508842a3bf20fcc7341a006e7 Author: Winfried Donkers AuthorDate

Re: submit a revised patch to an abandoned gerrit change

2022-01-12 Thread Winfried Donkers
I have the same menu, but just next to the menu button (the vertical ...), on the left side, there is also a RESTORE button. Might only work for own patches. OK, thanks all, I'll simply submit a new patch and refer to the abandoned one (I have no need for elevated permissions). Winfried

Re: submit a revised patch to an abandoned gerrit change

2022-01-11 Thread Winfried Donkers
Is it possible to reopen an abandoned gerrit change when you're not the original contributor? I see a restore button for every abandoned patch. But why not simply try? I can't see any restore button; in menu I see Cherry pick, Download patch and Ignore. Winfried

submit a revised patch to an abandoned gerrit change

2022-01-11 Thread Winfried Donkers
In 2017 a contributor submitted several patches to gerrit, but in the end didn't succeed in fixing the bug and gave up. The contributor gave up and gerrit (Pootle bot) changed the status of the gerrit change to abandoned. Last month I received a question whether I could do something with the

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/qa sc/source

2021-12-10 Thread Winfried Donkers (via logerrit)
: commit 1db4d3c869dbd4d68c0ab7b15c60bb2dad0a9f67 Author: Winfried Donkers AuthorDate: Thu Dec 9 17:39:58 2021 +0100 Commit: Xisco Fauli CommitDate: Fri Dec 10 13:52:37 2021 +0100 tdf#133353, Make 2nd argument optional for DCOUNT and DCOUNTA. The functions accept empty second

[Libreoffice-commits] core.git: sc/qa sc/source

2021-12-09 Thread Winfried Donkers (via logerrit)
: commit 885465bc0ae6029d8adad57015fb0ff6c26a6ba6 Author: Winfried Donkers AuthorDate: Thu Dec 9 17:39:58 2021 +0100 Commit: Eike Rathke CommitDate: Fri Dec 10 01:18:43 2021 +0100 tdf#133353, Make 2nd argument optional for DCOUNT and DCOUNTA. The functions accept empty second

[Libreoffice-commits] core.git: scaddins/source sc/qa

2021-11-29 Thread Winfried Donkers (via logerrit)
sc/qa/unit/data/functions/date_time/fods/weeks.fods | 652 +++- scaddins/source/datefunc/datefunc.cxx | 71 -- 2 files changed, 659 insertions(+), 64 deletions(-) New commits: commit 105196aa00bc0d3e426796f6729a8e7e51271e56 Author: Winfried Donkers

[no subject]

2020-10-14 Thread Winfried Donkers
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Accessing code for Calc functions

2019-11-26 Thread Winfried Donkers
Hi Steve, On 26.11.2019 17:15, Steve Fanning wrote: I am currently working as a member of the Documentation Team, updating Chapter 18 of the Calc Guide (Description of Functions). From time to time during this task, I would benefit from viewing the code that implements individual functions but

a developer's goodbye

2019-10-11 Thread Winfried Donkers
Hi all, The past 8 years I have had the honour and pleasure to contribute as developer to LibreOffice (mainly Calc). Alas, because of health reasons I must end my contributions. It was great to be part of a large community focussed on making a great open source project a success. Thank

[Libreoffice-commits] core.git: chart2/Library_chartcore.mk chart2/source officecfg/registry

2019-05-20 Thread Winfried Donkers (via logerrit)
f6f27ae31a26bf6cecbf9205ef28a6bad3d06864 Author: Winfried Donkers AuthorDate: Sat Feb 2 13:05:03 2019 +0100 Commit: Eike Rathke CommitDate: Mon May 20 12:58:31 2019 +0200 tdf#90180 Add option to show errors as rectangles in diagrams with error bars. The option is saved in registrymodifications.xcu

wanted: reviewer(s) for https://gerrit.libreoffice.org/67280

2019-05-16 Thread Winfried Donkers
Hi, I am looking for at least one extra reviewer for https://gerrit.libreoffice.org/67280. It would be great, if still possible, to have this extra feature added to Calc in version 6.3. The feature (see tdf90180) allows the user to have either a cross bar (current, default) or rectangle

tdf124710 convert Calc functions IFS and SWITCH to jump functions

2019-05-07 Thread Winfried Donkers
Hi Eike, all, I have been concentrating on converting IFS functions to their equivalent with nested IF functions, e.g. IFS(b1;r1;b2;r2) to IF(b1;r1;IF(b2;r2;#NA)). I now think I know where to insert ocIf tokens in the IFS-function string when looking at FormulaCompiler::Factor(), but I

tdf124710 convert Calc function IFS (and SWITCH) to jump function

2019-04-30 Thread Winfried Donkers
Hi Eike, Some time ago (when I submitted a draft patch) you suggested an alternative, possible easier way, to convert IFS and SWITCH to jump functions. The idea was not to extend the jump functionality, but to internally convert IFS and SWITCH to IF: IFS( b1, r1, b2, r2 ) should become IF( b1,

confusing use of 'OpCode' in formula/source/core/api/FormulaCompiler.cxx

2019-04-30 Thread Winfried Donkers
Hi, I stumbled over an inconsistency in the use of opcodes in formula/source/core/api/FormulaCompiler.cxx: in two locations SC_OPCODE_xxx is used for functions, whereas in all other code (apart from the definitions, formula/inc/core_resource.hrc, sc/inc/scfuncs.hrc and

RE: is gerrit #26348 still somewhere?

2019-04-29 Thread Winfried Donkers
Hi Christian, Mike, Eike, (Combining mails into one reply) > Not on gerrit anymore, but is available on jenkins mirror... > Attached is the change v1 - if there was a second revision, then that is lost. First of all, thank you, Christian, for retrieving the change v1. That'll help preventing

RE: is gerrit #26348 still somewhere?

2019-04-26 Thread Winfried Donkers
Hi Xisco, > This is the list of abandonded patch own by you -> > https://gerrit.libreoffice.org/#/q/status:abandoned+owner:%22Winfried+Donkers+%253Cwinfrieddonkers%2540libreoffice.org%253E%22 > is it in there? I can't find anything looking for 'tdf#124710' No, it isn't in there. The gerrit

is gerrit #26348 still somewhere?

2019-04-26 Thread Winfried Donkers
Hi, I am working on tdf#124710, which means that I need to convert functions IFS and SWITCH to 'jump functions'. I tried this before, but abandoned my work, which was in gerrit #26348. Somehow I cannot retrieve that 'commit'. Is there any way to retrieve it (so that I can read the comments and

Re: tdf124710, unexpected result for function IFS when argument NA() is followed by an argument that needs interpreting

2019-04-17 Thread Winfried Donkers
The actual root cause here is that IFS() and SWITCH() are not compiled into jumps so only the needed result would be calculated, but instead all arguments are calculated beforehand as in usual function calls. We had that discussion some while ago (and there exists some bug about it), but I

tdf124710, unexpected result for function IFS when argument NA() is followed by an argument that needs interpreting

2019-04-17 Thread Winfried Donkers
Hi Eike, Upon debugging IFS( 0, NA(), 1+0, "output" ) I came to the following preliminary conclusions: Before ScInterpreter::ScIfs_MS() is called, ScInterpreter::Interpret is called for argument '1+0' . That leads to a call to scInterpreter::CalculateAddSub( false ) and there the problem

RE: use of DBG_UNHANDLED_EXCEPTION

2019-04-05 Thread Winfried Donkers
Hi Stephan, >> It won't compile. > It would help to show (link to?) your exact changes and the exact failure. Yes, that would have been be helpfull. Luckily Noel remembered and it seems that the 4 files in stoc/test/ that use '<< rExc' in the call to DBG_UNHANDLED_EXCEPTION are not examples

RE: use of DBG_UNHANDLED_EXCEPTION

2019-04-05 Thread Winfried Donkers
Hi Noel, >> just as you used it in stoc/test/testconv.cxx (and 3 other files in >> stoc/test). > I don't think the code in those files stoc/test files are even compiled as > part of > our build, certainly that style of code doesn't work anymore. > The way to use the DBG_UNHANDLED_EXCEPTION

use of DBG_UNHANDLED_EXCEPTION

2019-04-05 Thread Winfried Donkers
Hi Noel, I hope you can help me solve a problem with DBG_UNHANDLED_EXCEPTION, as in your commit 48fbfe38f60de (5 April 2018). I tried to use DBG_UNHANDLED_EXCEPTION("chart2", "Exception occurred : " << e); in chart2/source/view/charttypes/VSeriesPlotter.cxx, just as you used it in

[Libreoffice-commits] core.git: sc/qa sc/source

2019-03-28 Thread Winfried Donkers (via logerrit)
++--- 4 files changed, 66 insertions(+), 10 deletions(-) New commits: commit edcbe8c4e02a67c74ec6f85f28899431dbfa0765 Author: Winfried Donkers AuthorDate: Tue Mar 26 16:27:09 2019 +0100 Commit: Eike Rathke CommitDate: Thu Mar 28 23:18:37 2019 +0100 tdf#124286 fix annoying rounding error

RE: Boolean configuration settings not editable in tools - advanced - expert configuration

2019-02-05 Thread Winfried Donkers
>> When using LO on a Linux machine, I need to double click a setting to edit >> it. In all cases, a dialog >> appears. For string and int type settings, I can change/replace the value. >> For boolean seeting, a >> dialog appears, bu I cannot change true to false or vice versa. > i just built

RE: Boolean configuration settings not editable in tools - advanced - expert configuration

2019-02-04 Thread Winfried Donkers
Hi Mike, >> I noticed a general unexpected behaviour when working with LibreOffice in >> Tools-Advanced-Expert Configuration. >> When the setting is of type boolean, I cannot change the setting. I tried >> various existing settings, mainly in org.openoffice.Office.Calc and both >> with current

Boolean configuration settings not editable in tools - advanced - expert configuration

2019-02-04 Thread Winfried Donkers
(moving discussion from https://gerrit.libreoffice.org/#/c/67280/ to mailing list) >> For reasons unknown to me, boolean configuration settings are read only on >> the >> expert configuration dialog, int/long values can be edited. This is not just >> in master, >> but e.g. in version 6.0 as

RE: How do I add a new configuration item to registrymodifications.xcu

2019-02-01 Thread Winfried Donkers
Hi Heiko, > I wrote a blog post some time ago about how to make a feature optional. It > comes from a > non-developer/layman perspective to encourage people to look into the code. > Perhaps it’s > a bit helpful. >

RE: How do I add a new configuration item to registrymodifications.xcu

2019-02-01 Thread Winfried Donkers
Hi Michael, >>> utl::ConfigItem is sort of deprecated and you should have a really good >>> excuse to use it in new code. >> >> I have no better excuse than that it existed in the same component. >> Which method should I use instead (or where can I find good examples of code >> to use as

RE: How do I add a new configuration item to registrymodifications.xcu

2019-01-31 Thread Winfried Donkers
Including the mailing list this time... Winfried - Hi Michael, Stephan, Thank you for your quick responses. >> Therefore I need to add a configuration item to registrymodifications.xcu. >> I have created a class to obtain the configuration item, using a derivative >> of

How do I add a new configuration item to registrymodifications.xcu

2019-01-31 Thread Winfried Donkers
Hi, I am working on an enhancement for Calc, tdf90180. Therefore I need to add a configuration item to registrymodifications.xcu. I have created a class to obtain the configuration item, using a derivative of ::com::sun::star::utl::ConfigItem and copying/adapting existing code to retrieve

RE: Gerrit, provider not supported (Yahoo)

2019-01-23 Thread Winfried Donkers
> Since yesterday, I can't log on gerrit with my Yahoo account, I got : > "Provider is not supported, or was incorrectly entered." I have the same problem and are equally interested in solutions. Winfried ___ LibreOffice mailing list

Calc : (date)time parts, cell format and difference with other applications

2018-12-12 Thread Winfried Donkers
Hi all, I added an attachment (https://bugs.documentfoundation.org/attachment.cgi?id=147433) to bug report tdf118800, with a comparison of the (date)time part functions (YEAR, MONTH, DAY, HOUR, MINUTE, SECOND) and some (date)time cell formats. I made this comparison before submitting a patch

RE: tdf#69569 ODFFv1.2 part 2 incorrect

2018-12-03 Thread Winfried Donkers
Hi Eike, > > c) The constraint date1 >= date2 is missing in §4.11.7. > > It's date1 <= date2, isn't it? As stated for the other procedures as > "If date1> date2, then swap the values of date1 and date2." > I think that's missing for procedure E. Yes, it should be " c) The constraint date1 <=

RE: tdf#69569 ODFFv1.2 part 2 incorrect

2018-11-28 Thread Winfried Donkers
Hi Eike, Have you been able to form an opinion yet re the conclusions/suggestions below? Winfried > woensdag 14 november 2018 11:38 > > Hi Eike, > > I have been studying ODFFv1.2 part 2 §4.11.7.7 with > https://bugs.documentfoundation.org/show_bug.cgi?id=69569#c17 , lines 1..5. > in mind. >

tdf#69569 ODFFv1.2 part 2 incorrect

2018-11-14 Thread Winfried Donkers
Hi Eike, I have been studying ODFFv1.2 part 2 §4.11.7.7 with https://bugs.documentfoundation.org/show_bug.cgi?id=69569#c17 , lines 1..5. in mind. My conclusions are that a) Line 8 should be " 8.Otherwise, if _(not A)_ and is-leap-year(year(date1)) then return 366 "; b) Lines 9 and 10 can

Re: Calc functions and Calc option 'convert text to number'

2018-07-13 Thread Winfried Donkers
Hi Eike, I'm working on tdf64132, which is about SUM and text values that are not converted to numbers. That bug is wrong and not a bug, I'll explain there, so all further speculations about changing behaviour and implied problems are moot ;-) Well, then some additional help text will

Calc functions and Calc option 'convert text to number'

2018-07-12 Thread Winfried Donkers
Hi Eike, I'm working on tdf64132, which is about SUM and text values that are not converted to numbers. SUM uses ScInterpreter::IterateParameters(), which is used by various other Calc functions as well. ScInterpreter::IterateParameters() does not handle the configuration settings for

Calc functions and Calc option 'convert text to number'

2018-07-12 Thread Winfried Donkers
Hi Eike, I'm working on tdf64132, which is about SUM and text values that are not converted to numbers. SUM uses ScInterpreter::IterateParameters(), which is used by various other Calc functions as well. ScInterpreter::IterateParameters() does not handle the configuration settings for

[Libreoffice-commits] core.git: sc/qa

2018-06-20 Thread Winfried Donkers
sc/qa/unit/data/functions/spreadsheet/fods/column.fods | 79 +++--- sc/qa/unit/data/functions/spreadsheet/fods/row.fods| 134 +++-- 2 files changed, 186 insertions(+), 27 deletions(-) New commits: commit 3613990eaae645e0489660be2dab8a61cab8a69c Author: Winfried Donkers

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

2018-06-20 Thread Winfried Donkers
sc/source/core/tool/interpr1.cxx | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) New commits: commit ad6bdc81f3b47cc46a7751e93e59fb92edd28baf Author: Winfried Donkers Date: Thu Jun 14 20:55:23 2018 +0200 tdf#77517 make Calc function ROW

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source

2018-06-19 Thread Winfried Donkers
sc/source/core/tool/interpr1.cxx | 40 ++- 1 file changed, 31 insertions(+), 9 deletions(-) New commits: commit d5c8199a94d0e2f722fff6637b930205a6641adf Author: Winfried Donkers Date: Mon Jun 18 19:31:47 2018 +0200 tdf#77517 make Calc function COLUMN

[Libreoffice-commits] core.git: sc/source

2018-06-19 Thread Winfried Donkers
sc/source/core/tool/interpr1.cxx | 40 ++- 1 file changed, 31 insertions(+), 9 deletions(-) New commits: commit 28f3e44e99283ede636c28c68bffb2b9df0bbcf8 Author: Winfried Donkers Date: Mon Jun 18 19:31:47 2018 +0200 tdf#77517 make Calc function COLUMN

[Libreoffice-commits] core.git: sc/source

2018-06-15 Thread Winfried Donkers
sc/source/core/tool/interpr1.cxx | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) New commits: commit b1740fba0d1e6e3d69c3781734509317f42a0e4f Author: Winfried Donkers Date: Thu Jun 14 20:55:23 2018 +0200 tdf#77517 make Calc function ROW

tdf97815 switching to English function names does not work with _ADD functions

2018-05-28 Thread Winfried Donkers
Hi Eike, As I did some work in the past on this aspect, I try to fix this bug, even though I am not a big fan of the Add-In functions ;-). I came across code that I don't understand enough: 1. /scaddins/source/analysis/deffuncname.hxx contains a lot of static const char*[2], with German and

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/qa sc/source

2018-05-11 Thread Winfried Donkers
sc/qa/unit/data/functions/statistical/fods/countif.fods | 22 sc/source/core/data/dociter.cxx |2 - 2 files changed, 18 insertions(+), 6 deletions(-) New commits: commit 9b2ebcfe80900b2f6299851d3a271bdcaa85049a Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2018-05-09 Thread Winfried Donkers
sc/qa/unit/data/functions/statistical/fods/countif.fods | 22 sc/source/core/data/dociter.cxx |2 - 2 files changed, 18 insertions(+), 6 deletions(-) New commits: commit 1a8febcaa4f932124d417877a3b08bd059c0362d Author: Winfried Donkers <winfriedd

tdf117433 COUNIF doesn't count cells after first column in range for empty criteria

2018-05-08 Thread Winfried Donkers
Hi Eike, I found what causes the problem of bug tdf117443, but I don't understand why the code is as it is now and therefore I am reluctant to change it. In sc/source/core/data/dociter.cxx:ScQueryValueIterator::GetThis() there is a loop in lines 1132-1143 that is entered as soon as the first

Re: tdf117433 COUNIF doesn't count cells after first column in range for empty criteria

2018-05-08 Thread Winfried Donkers
Hi Eike, On 05/08/2018 02:52 PM, Eike Rathke wrote: In sc/source/core/data/dociter.cxx:ScQueryValueIterator::GetThis() ScQueryCellIterator::GetThis() that is.. Sorry for that.. Would it be a good idea to add a boolean mbDontSkipEmptyCols to ScQueryValueIterator which is only set to true for

[Libreoffice-commits] core.git: sc/qa sc/source

2018-05-03 Thread Winfried Donkers
sc/qa/unit/data/functions/statistical/fods/hypgeomdist.fods | 145 sc/source/core/tool/interpr3.cxx|2 2 files changed, 146 insertions(+), 1 deletion(-) New commits: commit 5cee94308b8dbceb11de4ac02e1d7c9808ccdb02 Author: Winfried Donkers

[Libreoffice-commits] core.git: sc/source

2018-04-25 Thread Winfried Donkers
sc/source/core/tool/interpr6.cxx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit a985d4c2977ca23971f145b93a0155827bebfcdf Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Wed Apr 25 16:35:04 2018 +0200 Check if ref

[Libreoffice-commits] core.git: sc/qa sc/source

2018-04-25 Thread Winfried Donkers
sc/qa/unit/data/functions/statistical/fods/hypgeomdist.fods | 73 ++-- sc/source/core/tool/interpr3.cxx| 20 +-- 2 files changed, 71 insertions(+), 22 deletions(-) New commits: commit e58b3f987681d0034f692db82345af06de217836 Author: Winfried Donkers

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/qa sc/source

2018-04-09 Thread Winfried Donkers
sc/qa/unit/data/functions/mathematical/fods/aggregate.fods | 40 - sc/source/core/tool/interpr6.cxx |6 + 2 files changed, 42 insertions(+), 4 deletions(-) New commits: commit 2c51260d91490a6fc512875d8befb38367bf3227 Author: Winfried Donkers

[Libreoffice-commits] core.git: sc/qa sc/source

2018-04-09 Thread Winfried Donkers
sc/qa/unit/data/functions/mathematical/fods/aggregate.fods | 40 - sc/source/core/tool/interpr6.cxx |6 + 2 files changed, 42 insertions(+), 4 deletions(-) New commits: commit 0a4c1fb68c3619e61099a7c548f550b0d3fd7a53 Author: Winfried Donkers

[Libreoffice-commits] core.git: sc/qa sc/source

2018-03-29 Thread Winfried Donkers
/core/tool/interpr5.cxx | 63 - 5 files changed, 81 insertions(+), 106 deletions(-) New commits: commit fc121c32ca0effb47d219066a6848435cba562cc Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Wed Mar 21 16:57:36 2018 +0100 tdf#9797

[Libreoffice-commits] core.git: sc/qa sc/source

2018-03-15 Thread Winfried Donkers
changed, 151 insertions(+), 14 deletions(-) New commits: commit c71e8df90b916f32a1d7d3a0849d0cdf14924475 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Thu Mar 1 17:34:23 2018 +0100 tdf#97977 related : make MODE.SNGL comply with Excel. MODE.SNGL is to

[Libreoffice-commits] core.git: sc/source

2018-03-08 Thread Winfried Donkers
sc/source/core/tool/interpr3.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 754d1053d37feb2bc91eaa74b3c3b111a0f8d859 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Wed Mar 7 17:54:58 2018 +0100 Load arguments in array in the order of the arg

[Libreoffice-commits] core.git: i18nutil/source sc/qa

2018-02-02 Thread Winfried Donkers
6c79c9053e3090df09fc2c0a24f1fec26ac8bf02 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Thu Feb 1 15:39:56 2018 +0100 Clean up of dirty hack. Follow up of tdf#103550. The conversion from half to full width characters and vice versa happens per character according to a

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - i18nutil/source sc/qa

2018-01-26 Thread Winfried Donkers
i18nutil/source/utility/widthfolding_data.h |1 + sc/qa/unit/data/functions/text/fods/jis.fods | 15 +-- 2 files changed, 10 insertions(+), 6 deletions(-) New commits: commit 8c01c25ac4f85266719dc04e9809da2f3eb5b10e Author: Winfried Donkers <winfrieddonk...@libreoffice.

[Libreoffice-commits] core.git: i18nutil/source sc/qa

2018-01-26 Thread Winfried Donkers
i18nutil/source/utility/widthfolding_data.h |1 + sc/qa/unit/data/functions/text/fods/jis.fods | 15 +-- 2 files changed, 10 insertions(+), 6 deletions(-) New commits: commit 484d0ea842da586a4cf51b6d11683b04f234474c Author: Winfried Donkers <winfrieddonk...@libreoffice.

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - i18npool/source

2018-01-26 Thread Winfried Donkers
e18cb8bebf47f95bd036822490f12daba35d6cec Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Thu Jan 25 16:52:30 2018 +0100 Change TimeSeparator for locale la_VA, lld_IT and vec_IT. Change-Id: I0afc3a08a31216efdbddc389dc23f0b04bc92b37 Reviewed-on:

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - 2 commits - i18npool/source

2018-01-26 Thread Winfried Donkers
Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Thu Jan 25 16:26:46 2018 +0100 Fix incorrect AM/PM symbols in locale it_CH and vec_IT. Follow up of tdf#105226. Change-Id: I31816a36e427338034a30492f2a7ac7f2d0fddd2 Reviewed-on:

[Libreoffice-commits] core.git: i18npool/source

2018-01-25 Thread Winfried Donkers
80ac1dc53ba2aac97bce067495f7f60c6acabadd Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Thu Jan 25 16:52:30 2018 +0100 Change TimeSeparator for locale la_VA, lld_IT and vec_IT. Change-Id: I0afc3a08a31216efdbddc389dc23f0b04bc92b37 Reviewed-on:

[Libreoffice-commits] core.git: i18npool/source

2018-01-25 Thread Winfried Donkers
i18npool/source/localedata/data/it_IT.xml | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit c97d67631724c29fa665c5f0aaad0a0fd9a061ee Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Thu Jan 25 16:22:24 2018 +0100 tdf#

[Libreoffice-commits] core.git: i18npool/source

2018-01-25 Thread Winfried Donkers
i18npool/source/localedata/data/it_CH.xml |4 ++-- i18npool/source/localedata/data/vec_IT.xml |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 8ff3d8821ef68069c1bdcf1a123b0c929d745566 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: T

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - i18npool/source

2018-01-22 Thread Winfried Donkers
i18npool/source/localedata/data/it_IT.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9a86daba30a60f478c4d2c430cd5607301e4f252 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Sat Jan 20 19:24:48 2018 +0100 tdf#105226 fix incorr

[Libreoffice-commits] core.git: i18npool/source

2018-01-22 Thread Winfried Donkers
i18npool/source/localedata/data/it_IT.xml |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b6c0356ac9d59a4599d15f8d2f001d39010b3e48 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Sat Jan 20 19:24:48 2018 +0100 tdf#105226 fix incorr

[Libreoffice-commits] core.git: sal/rtl sc/qa

2018-01-16 Thread Winfried Donkers
/data/functions/statistical/fods/tinv.fods | 60 +++--- 9 files changed, 243 insertions(+), 217 deletions(-) New commits: commit b97a0df0f3234b4c1140ba1418d4b96a592afa4a Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Sat Dec 30 18:25:02 2017 +0100 tdf#96821 fix

Re: tests sc_array_functions_test fail due to floating point precision

2017-12-10 Thread Winfried Donkers
Hi Milton, I've also opened the other test documents in sc/qa/unit/data/functions/array/fods/ using LibreOffice. The documents which fail are linest.fods and also logest.fods. The others succeed. If your build completed ignoring these tests (i.e. produced a usable office under ./instdir/),

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

2017-12-01 Thread Winfried Donkers
sc/source/core/tool/interpr1.cxx | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) New commits: commit 664d40fb24bf500a22efd1f1aff58a96b3c3cf2c Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Wed Nov 29 17:43:14 2017 +0100 tdf#97198 fol

[Libreoffice-commits] core.git: sc/source

2017-11-30 Thread Winfried Donkers
sc/source/core/tool/interpr1.cxx | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) New commits: commit c5d0cffbf42f41349a8575ba52456d9cb07e91c7 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Wed Nov 29 17:43:14 2017 +0100 tdf#97198 fol

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/qa sc/source

2017-11-29 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/replace.fods | 230 +-- sc/source/core/tool/interpr1.cxx | 17 + 2 files changed, 227 insertions(+), 20 deletions(-) New commits: commit 44487fee8646c0ded5c2b2ffaaa70e75a7af7e04 Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-29 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/replace.fods | 230 +-- sc/source/core/tool/interpr1.cxx | 17 + 2 files changed, 227 insertions(+), 20 deletions(-) New commits: commit aaba725b466950f47c4e93d790986d209e80ead3 Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/left.fods | 88 +- sc/source/core/tool/interpr1.cxx |7 +- 2 files changed, 92 insertions(+), 3 deletions(-) New commits: commit 4e3530b4f870e0470c23ae89cdb8b9a09af54d59 Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/search.fods | 160 +--- sc/source/core/tool/interpr1.cxx| 11 + 2 files changed, 156 insertions(+), 15 deletions(-) New commits: commit 78b7e5f76e72647e0cab662ad2c9342d4538704f Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/len.fods | 100 +-- sc/source/core/tool/interpr1.cxx | 10 ++ 2 files changed, 102 insertions(+), 8 deletions(-) New commits: commit 47155ce8fb4302d377b374d39b501d0a0f7577c5 Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/find.fods | 148 +- sc/source/core/tool/interpr1.cxx | 11 + 2 files changed, 156 insertions(+), 3 deletions(-) New commits: commit 5e2a3eed69060d63070d72df60cd84247ca0bc9e Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/right.fods | 112 ++--- sc/source/core/tool/interpr1.cxx | 26 + 2 files changed, 108 insertions(+), 30 deletions(-) New commits: commit 09455734727daa3774158795febd910b33b1d784 Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers
sc/qa/unit/data/functions/text/fods/mid.fods | 175 ++- sc/source/core/tool/interpr1.cxx | 28 +++- 2 files changed, 166 insertions(+), 37 deletions(-) New commits: commit e78f508997f9384518c2dd1a005c5306ccd24783 Author: Winfried Donkers <winfriedd

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

2017-11-13 Thread Winfried Donkers
(+), 10 deletions(-) New commits: commit 76c2e3efe751d42f7b352bebdddfe33bd37d9e06 Author: Winfried Donkers <winfrieddonk...@libreoffice.org> Date: Sun Nov 12 11:47:11 2017 +0100 tdf#113768 Fix opposite argument description for Calc function VDB. Also, use self-explaining variabl

Re: tdf106013 Add-In functions that are also Excel2013 OOXML functions

2017-10-24 Thread Winfried Donkers
Hi Eike,>> There is a group of Add-In functions that were newly defined in Excel 2013 (IMCOSH, IMCOT, IMCSC, IMCSCH, IMSEC, IMSECH, IMSINH and IMTAN, I'll call them IMxx). In Calc these functions are defined in scaddins and also mentioned in sc/source/filter/oox/formulabase.cxx in

RE: ODFF1.2 interpretation of function WEEKNUM

2017-09-26 Thread Winfried Donkers
Hi Eike, > > Which bug# btw? > > Never mind, found it, > https://bugs.documentfoundation.org/show_bug.cgi?id=112320 > > > I'll bring this to the attention of the ODF-TC and, depending on the > > outcome, we may have to change implementation, or introduce some > > WEEKNUM_EXCEL function. > I

RE: ODFF1.2 interpretation of function WEEKNUM

2017-09-25 Thread Winfried Donkers
Hi Wol, > This reads to me exactly like the ODF spec, so it seems that Excel is not > abiding by the Excel spec if it returns 29-dec as week 53 ... > > To quote the Excel spec, "System 1The week containing January 1 is > the first week of the year, and is numbered week 1." That says to me -

ODFF1.2 interpretation of function WEEKNUM

2017-09-18 Thread Winfried Donkers
Hi Eike, I'm working on tdf112320 and I think that ODFF1.2 may be ambiguous with respect to WEEKNUM (http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#WEEKNUM) My interpretation of the Semantics for Mode 1,2,11-17 was that 'every week starts on Sunday..Saturday,

RE: ODFF1.2 GEOMEAN

2017-09-14 Thread Winfried Donkers
Hi Eike, As we now have changed GEOMEAN, I think it would be wise to try to improve ODFF1.2 as well for GEOMEAN. Winfried Van: LibreOffice [mailto:libreoffice-boun...@lists.freedesktop.org] Namens Winfried Donkers Verzonden: woensdag 26 juli 2017 12:06 Aan: libreoffice@lists.freedesktop.org

[Libreoffice-commits] core.git: sc/qa sc/source

2017-09-13 Thread Winfried Donkers
sc/qa/unit/data/functions/statistical/fods/geomean.fods | 83 ++-- sc/source/core/tool/interpr3.cxx| 50 + 2 files changed, 124 insertions(+), 9 deletions(-) New commits: commit 65ea925d173db0f319a8ca78855587d089e5270d Author: Winfried Donkers

  1   2   3   4   5   6   7   8   9   >