[Libreoffice-commits] core.git: sw/source uitest/writer_tests5

[Xisco Faulí (via logerrit)]

 sw/source/uibase/inc/conttree.hxx|5 -
 sw/source/uibase/uitest/uiobject.cxx |1 -
 uitest/writer_tests5/tdf114724.py|   18 +++---
 3 files changed, 3 insertions(+), 21 deletions(-)

New commits:
commit 0b48cee16d459d27ebd090d008ec9398c86fc581
Author: Xisco Faulí 
AuthorDate: Wed Apr 22 12:02:38 2020 +0200
Commit: Xisco Faulí 
CommitDate: Wed Apr 22 13:50:26 2020 +0200

Revert "tdf114724: uitest: make test less time.sleep dependent"

This reverts commit 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b.

See https://gerrit.libreoffice.org/c/core/+/92616

Change-Id: I642843ab16450d1a6b15d5e955495efbbfa7822a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92539
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sw/source/uibase/inc/conttree.hxx 
b/sw/source/uibase/inc/conttree.hxx
index 59df0d51c3ea..28ea07a1c1de 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -247,11 +247,6 @@ public:
 m_xTreeView->grab_focus();
 }
 
-OUString get_selected_text() const
-{
-return m_xTreeView->get_selected_text();
-}
-
 int count_selected_rows() const
 {
 return m_xTreeView->count_selected_rows();
diff --git a/sw/source/uibase/uitest/uiobject.cxx 
b/sw/source/uibase/uitest/uiobject.cxx
index baa9e79bafb8..a0b8da9e9d97 100644
--- a/sw/source/uibase/uitest/uiobject.cxx
+++ b/sw/source/uibase/uitest/uiobject.cxx
@@ -139,7 +139,6 @@ StringMap SwNavigationPIUIObject::get_state()
 StringMap aMap = WindowUIObject::get_state();
 
 aMap["selectioncount"] = 
OUString::number(mxSwNavigationPI->m_xContentTree->count_selected_rows());
-aMap["selectedtext"] = 
mxSwNavigationPI->m_xContentTree->get_selected_text();
 
 return aMap;
 }
diff --git a/uitest/writer_tests5/tdf114724.py 
b/uitest/writer_tests5/tdf114724.py
index f5947a21e321..390e53b3ac37 100644
--- a/uitest/writer_tests5/tdf114724.py
+++ b/uitest/writer_tests5/tdf114724.py
@@ -26,28 +26,16 @@ class tdf114724(UITestCase):
 xNavigatorPanel.executeAction("ROOT", tuple())
 
 xWriterEdit.executeAction("FOCUS", tuple())
+time.sleep(2)
 self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectioncount"], 
"1")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectedtext"], 
"Headings")
-
 for _ in range(0,3):
 xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"DOWN"}))
+time.sleep(2)
 
self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectioncount"], "1")
-
-timeout = time.time() + 2
-while get_state_as_dict(xNavigatorPanel)["selectedtext"] != "HEADING 
4" and time.time() < timeout:
-time.sleep(0.1)
-
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectedtext"], 
"HEADING 4")
-
 for _ in range(0,3):
 xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"UP"}))
+time.sleep(2)
 
self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectioncount"], "1")
 
-timeout = time.time() + 2
-while get_state_as_dict(xNavigatorPanel)["selectedtext"] != "HEADING 
1" and time.time() < timeout:
-time.sleep(0.1)
-
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectedtext"], 
"HEADING 1")
-
 self.xUITest.executeCommand(".uno:Sidebar")
 self.ui_test.close_doc()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - chart2/source sw/qa

[Xisco Faulí (via logerrit)]

 chart2/source/inc/ChartTypeHelper.hxx|3 ++
 chart2/source/tools/ChartTypeHelper.cxx  |9 +++
 chart2/source/view/charttypes/AreaChart.cxx  |3 +-
 chart2/source/view/charttypes/VSeriesPlotter.cxx |5 +++-
 chart2/source/view/inc/VDataSeries.hxx   |1 
 chart2/source/view/main/ChartView.cxx|   28 +++
 chart2/source/view/main/VDataSeries.cxx  |   16 -
 dev/null |binary
 sw/qa/extras/layout/layout.cxx   |   16 -
 9 files changed, 48 insertions(+), 33 deletions(-)

New commits:
commit 2af4d304992d2a508e0d79cd855b93ca7559ebef
Author: Xisco Faulí 
AuthorDate: Wed Mar 11 17:59:40 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Mar 16 10:38:17 2020 +0100

tdf#131291: Revert "tdf#129173 tdf#129175 Fix number format of data labels"

This reverts commit d979eb16b9144c7ed230d7b0a4d0c1474664d7d0.

Revert it only in libreoffice-6-3 branch

Change-Id: Ib73a0344932eeec792935f46e4a86041ed448287
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90284
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/chart2/source/inc/ChartTypeHelper.hxx 
b/chart2/source/inc/ChartTypeHelper.hxx
index b97a256802c3..c2945dfb9380 100644
--- a/chart2/source/inc/ChartTypeHelper.hxx
+++ b/chart2/source/inc/ChartTypeHelper.hxx
@@ -78,6 +78,9 @@ public:
 static OUString getRoleOfSequenceForDataLabelNumberFormatDetection( const 
css::uno::Reference<
 css::chart2::XChartType >& xChartType );
 
+static bool shouldLabelNumberFormatKeyBeDetectedFromYAxis( const 
css::uno::Reference<
+css::chart2::XChartType >& xChartType );
+
 static bool isSupportingOnlyDeepStackingFor3D( const css::uno::Reference< 
css::chart2::XChartType >& xChartType );
 };
 
diff --git a/chart2/source/tools/ChartTypeHelper.cxx 
b/chart2/source/tools/ChartTypeHelper.cxx
index c8efc90b3f0f..78d841755374 100644
--- a/chart2/source/tools/ChartTypeHelper.cxx
+++ b/chart2/source/tools/ChartTypeHelper.cxx
@@ -657,6 +657,15 @@ OUString 
ChartTypeHelper::getRoleOfSequenceForDataLabelNumberFormatDetection( co
 return aRet;
 }
 
+bool ChartTypeHelper::shouldLabelNumberFormatKeyBeDetectedFromYAxis( const 
uno::Reference< XChartType >& xChartType )
+{
+bool bRet = true;
+OUString aChartTypeName = xChartType->getChartType();
+if( aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_BUBBLE) )
+bRet = false;
+return bRet;
+}
+
 bool ChartTypeHelper::isSupportingOnlyDeepStackingFor3D( const uno::Reference< 
XChartType >& xChartType )
 {
 bool bRet = false;
diff --git a/chart2/source/view/charttypes/AreaChart.cxx 
b/chart2/source/view/charttypes/AreaChart.cxx
index 89ba4db47b2f..2699121ed357 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -724,7 +724,6 @@ void AreaChart::createShapes()
 if( m_nDimension==3 && m_bArea && 
rXSlot.m_aSeriesVector.size()!=1 )
 fLogicY = fabs( fLogicY );
 
-double fLogicValueForLabeDisplay = fLogicY;
 std::map< sal_Int32, double >& rLogicYSumMap = 
aLogicYSumMapByX[nIndex];
 if (rPosHelper.isPercentY() && 
rLogicYSumMap[nAttachedAxisIndex] != 0.0)
 {
@@ -752,6 +751,8 @@ void AreaChart::createShapes()
 if( rLogicYForNextSeriesMap.find(nAttachedAxisIndex) == 
rLogicYForNextSeriesMap.end() )
 rLogicYForNextSeriesMap[nAttachedAxisIndex] = 0.0;
 
+double fLogicValueForLabeDisplay = fLogicY;
+
 fLogicY += rLogicYForNextSeriesMap[nAttachedAxisIndex];
 rLogicYForNextSeriesMap[nAttachedAxisIndex] = fLogicY;
 
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx 
b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index 16fc40428b5a..6a3b142a0ce9 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -367,7 +367,10 @@ OUString VSeriesPlotter::getLabelTextForValue( VDataSeries 
const & rDataSeries
 }
 else
 {
-nNumberFormatKey = rDataSeries.detectNumberFormatKey( nPointIndex 
);
+if( rDataSeries.shouldLabelNumberFormatKeyBeDetectedFromYAxis() && 
m_aAxesNumberFormats.hasFormat(1,rDataSeries.getAttachedAxisIndex()) ) //y-axis
+nNumberFormatKey = 
m_aAxesNumberFormats.getFormat(1,rDataSeries.getAttachedAxisIndex());
+else
+nNumberFormatKey = rDataSeries.detectNumberFormatKey( 
nPointIndex );
 }
 if(nNumberFormatKey<0)
 nNumberFormatKey=0;
diff --git a/chart2/source/view/inc/VDataSeries.hxx 
b/chart2/source/vie

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4-1' - svx/source

[Xisco Faulí (via logerrit)]

 svx/source/svdraw/svdxcgv.cxx |   13 ++---
 1 file changed, 2 insertions(+), 11 deletions(-)

New commits:
commit 25937732b9ef881651611f99d4178e90888642a2
Author: Xisco Faulí 
AuthorDate: Wed Feb 12 11:51:34 2020 +0100
Commit: Xisco Faulí 
CommitDate: Tue Feb 18 10:01:48 2020 +0100

tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as 
Copy'"

This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371.

Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 09e6824bc868990095233825c415556399dd0652)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88500
Reviewed-by: Xisco Faulí 
(cherry picked from commit d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88502
Reviewed-by: Samuel Mehrbrodt 
Reviewed-by: Mike Kaganski 
Tested-by: Xisco Faulí 

diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index f18d536b7bf2..8fcd742ec71f 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -744,17 +744,8 @@ std::unique_ptr 
SdrExchangeView::CreateMarkedObjModel() const
 
 if(nullptr == pNewObj)
 {
-// not cloned yet
-if (pObj->GetObjIdentifier() == OBJ_OLE2)
-{
-// tdf#125520
-pNewObj = 
pObj->CloneSdrObject(pObj->getSdrModelFromSdrObject());
-}
-else
-{
-// use default way
-pNewObj = pObj->CloneSdrObject(*pNewModel);
-}
+// not cloned yet, use default way
+pNewObj = pObj->CloneSdrObject(*pNewModel);
 }
 
 if(pNewObj)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - svx/source

[Xisco Faulí (via logerrit)]

 svx/source/svdraw/svdxcgv.cxx |   13 ++---
 1 file changed, 2 insertions(+), 11 deletions(-)

New commits:
commit d3e77bd112c3f7084b0dd92c36ff60f1fd1ddc2f
Author: Xisco Faulí 
AuthorDate: Wed Feb 12 11:51:34 2020 +0100
Commit: Xisco Faulí 
CommitDate: Thu Feb 13 07:41:21 2020 +0100

tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as 
Copy'"

This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371.

Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 09e6824bc868990095233825c415556399dd0652)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88500
Reviewed-by: Xisco Faulí 

diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index f18d536b7bf2..8fcd742ec71f 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -744,17 +744,8 @@ std::unique_ptr 
SdrExchangeView::CreateMarkedObjModel() const
 
 if(nullptr == pNewObj)
 {
-// not cloned yet
-if (pObj->GetObjIdentifier() == OBJ_OLE2)
-{
-// tdf#125520
-pNewObj = 
pObj->CloneSdrObject(pObj->getSdrModelFromSdrObject());
-}
-else
-{
-// use default way
-pNewObj = pObj->CloneSdrObject(*pNewModel);
-}
+// not cloned yet, use default way
+pNewObj = pObj->CloneSdrObject(*pNewModel);
 }
 
 if(pNewObj)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Xisco Faulí (via logerrit)]

 svx/source/svdraw/svdxcgv.cxx |   13 ++---
 1 file changed, 2 insertions(+), 11 deletions(-)

New commits:
commit 09e6824bc868990095233825c415556399dd0652
Author: Xisco Faulí 
AuthorDate: Wed Feb 12 11:51:34 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Feb 12 22:28:22 2020 +0100

tdf#130614: Revert "tdf#125520 Fix OLE objects drag with 'Insert as 
Copy'"

This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371.

Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/svx/source/svdraw/svdxcgv.cxx b/svx/source/svdraw/svdxcgv.cxx
index 827b0720b69d..f55e964a6223 100644
--- a/svx/source/svdraw/svdxcgv.cxx
+++ b/svx/source/svdraw/svdxcgv.cxx
@@ -744,17 +744,8 @@ std::unique_ptr 
SdrExchangeView::CreateMarkedObjModel() const
 
 if(nullptr == pNewObj)
 {
-// not cloned yet
-if (pObj->GetObjIdentifier() == OBJ_OLE2)
-{
-// tdf#125520
-pNewObj = 
pObj->CloneSdrObject(pObj->getSdrModelFromSdrObject());
-}
-else
-{
-// use default way
-pNewObj = pObj->CloneSdrObject(*pNewModel);
-}
+// not cloned yet, use default way
+pNewObj = pObj->CloneSdrObject(*pNewModel);
 }
 
 if(pNewObj)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sfx2/source

[Xisco Faulí (via logerrit)]

 sfx2/source/notebookbar/SfxNotebookBar.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2b73347194dde360d9e4be4526657efb511e72ef
Author: Xisco Faulí 
AuthorDate: Mon Jan 27 13:32:07 2020 +0100
Commit: Xisco Faulí 
CommitDate: Mon Jan 27 18:37:07 2020 +0100

Revert "tdf#118526 Reload Notebookbar if read mode has switched"

This reverts commit 69310348a6d65a49b406ec5ac2062ad5659bfcf4.

Reason for revert: tdf#130187.
tdf#130187 may give more problems than tdf#118526.
Reverting it in libreoffice-6-3 before 6.3.5 is released

Change-Id: I2b5ce4c54a92153454a1fe394e1757598616950e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87521
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sfx2/source/notebookbar/SfxNotebookBar.cxx 
b/sfx2/source/notebookbar/SfxNotebookBar.cxx
index 59eca1bc7e4e..402874ccb4ef 100644
--- a/sfx2/source/notebookbar/SfxNotebookBar.cxx
+++ b/sfx2/source/notebookbar/SfxNotebookBar.cxx
@@ -289,7 +289,7 @@ bool SfxNotebookBar::StateMethod(SfxBindings& rBindings, 
const OUString& rUIFile
 {
 SfxFrame& rFrame = rBindings.GetDispatcher_Impl()->GetFrame()->GetFrame();
 return StateMethod(rFrame.GetSystemWindow(), rFrame.GetFrameInterface(), 
rUIFile,
-   bReloadNotebookbar || 
rBindings.GetDispatcher_Impl()->IsUpdated_Impl());
+   bReloadNotebookbar);
 }
 
 bool SfxNotebookBar::StateMethod(SystemWindow* pSysWindow,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4-0' - sfx2/source

[Xisco Faulí (via logerrit)]

 sfx2/source/control/recentdocsviewitem.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 0768fa976bd44f6a9c96720dcc1a0272c0364e8b
Author: Xisco Faulí 
AuthorDate: Fri Jan 17 14:44:21 2020 +0100
Commit: Christian Lohmaier 
CommitDate: Tue Jan 21 23:20:33 2020 +0100

tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem"

This reverts commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137.

Similar to 5c54778aad677d6bb6e6687f0f43dffad1aefa1e

Change-Id: Ibb4daa702df1f683888b92b8b8041f28e25e6b04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86998
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit d720e120b6534ff2fdf6cb11f0b46eca454d4e34)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87051
Reviewed-by: Michael Stahl 
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/sfx2/source/control/recentdocsviewitem.cxx 
b/sfx2/source/control/recentdocsviewitem.cxx
index 908a679a5629..85d84ddc699d 100644
--- a/sfx2/source/control/recentdocsviewitem.cxx
+++ b/sfx2/source/control/recentdocsviewitem.cxx
@@ -91,7 +91,8 @@ RecentDocsViewItem::RecentDocsViewItem(sfx2::RecentDocsView 
, const OUStri
 }
 
 // create empty, and copy the default thumbnail in
-aThumbnail = BitmapEx(aThumbnailSize, 24);
+sal_uInt8 nAlpha = 255;
+aThumbnail = BitmapEx(Bitmap(aThumbnailSize, 24), 
AlphaMask(aThumbnailSize, ));
 
 aThumbnail.CopyPixel(
 ::tools::Rectangle(Point((aThumbnailSize.Width() - 
aExtSize.Width()) / 2, (aThumbnailSize.Height() - aExtSize.Height()) / 2), 
aExtSize),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sfx2/source

[Xisco Faulí (via logerrit)]

 sfx2/source/control/recentdocsviewitem.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d720e120b6534ff2fdf6cb11f0b46eca454d4e34
Author: Xisco Faulí 
AuthorDate: Fri Jan 17 14:44:21 2020 +0100
Commit: Noel Grandin 
CommitDate: Fri Jan 17 20:50:26 2020 +0100

tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem"

This reverts commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137.

Similar to 5c54778aad677d6bb6e6687f0f43dffad1aefa1e

Change-Id: Ibb4daa702df1f683888b92b8b8041f28e25e6b04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86998
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/control/recentdocsviewitem.cxx 
b/sfx2/source/control/recentdocsviewitem.cxx
index 908a679a5629..85d84ddc699d 100644
--- a/sfx2/source/control/recentdocsviewitem.cxx
+++ b/sfx2/source/control/recentdocsviewitem.cxx
@@ -91,7 +91,8 @@ RecentDocsViewItem::RecentDocsViewItem(sfx2::RecentDocsView 
, const OUStri
 }
 
 // create empty, and copy the default thumbnail in
-aThumbnail = BitmapEx(aThumbnailSize, 24);
+sal_uInt8 nAlpha = 255;
+aThumbnail = BitmapEx(Bitmap(aThumbnailSize, 24), 
AlphaMask(aThumbnailSize, ));
 
 aThumbnail.CopyPixel(
 ::tools::Rectangle(Point((aThumbnailSize.Width() - 
aExtSize.Width()) / 2, (aThumbnailSize.Height() - aExtSize.Height()) / 2), 
aExtSize),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Xisco Faulí (via logerrit)]

 sfx2/source/control/recentdocsviewitem.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit be638ffb1ed82530162d18784e31c3506575ad7b
Author: Xisco Faulí 
AuthorDate: Fri Jan 17 14:44:21 2020 +0100
Commit: Xisco Faulí 
CommitDate: Fri Jan 17 19:37:12 2020 +0100

tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem"

This reverts commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137.

Similar to 5c54778aad677d6bb6e6687f0f43dffad1aefa1e

Change-Id: Ibb4daa702df1f683888b92b8b8041f28e25e6b04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86981
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sfx2/source/control/recentdocsviewitem.cxx 
b/sfx2/source/control/recentdocsviewitem.cxx
index 908a679a5629..85d84ddc699d 100644
--- a/sfx2/source/control/recentdocsviewitem.cxx
+++ b/sfx2/source/control/recentdocsviewitem.cxx
@@ -91,7 +91,8 @@ RecentDocsViewItem::RecentDocsViewItem(sfx2::RecentDocsView 
, const OUStri
 }
 
 // create empty, and copy the default thumbnail in
-aThumbnail = BitmapEx(aThumbnailSize, 24);
+sal_uInt8 nAlpha = 255;
+aThumbnail = BitmapEx(Bitmap(aThumbnailSize, 24), 
AlphaMask(aThumbnailSize, ));
 
 aThumbnail.CopyPixel(
 ::tools::Rectangle(Point((aThumbnailSize.Width() - 
aExtSize.Width()) / 2, (aThumbnailSize.Height() - aExtSize.Height()) / 2), 
aExtSize),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa sw/source

[Xisco Faulí (via logerrit)]

 dev/null |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |   17 -
 sw/source/core/fields/fldbas.cxx |2 +-
 3 files changed, 1 insertion(+), 18 deletions(-)

New commits:
commit 332a37ebf3eeb7546ef0972035d72c6e836bcc7d
Author: Xisco Faulí 
AuthorDate: Tue Sep 24 18:48:29 2019 +0200
Commit: Xisco Faulí 
CommitDate: Tue Sep 24 20:59:51 2019 +0200

Revert "tdf#107784: DOCX Import: Show citation's title in fields"

This reverts commit 417d993b8b8a86c019758ee0850e4b42967e2afa.

it breaks the bibliography entries, so it needs more work than I initially 
thought. Reverting for the time being.

Change-Id: Idd75fd6794dedc5f2d4b7f1c262ba8d12aee5036
Reviewed-on: https://gerrit.libreoffice.org/79472
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf107784.docx 
b/sw/qa/extras/ooxmlimport/data/tdf107784.docx
deleted file mode 100644
index 2dc868246ac0..
Binary files a/sw/qa/extras/ooxmlimport/data/tdf107784.docx and /dev/null differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index f5c85890e3b2..f90d894b0f1e 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -685,23 +685,6 @@ DECLARE_OOXMLIMPORT_TEST(testTdf105975formula, 
"tdf105975.docx")
 CPPUNIT_ASSERT_EQUAL(OUString("25"), 
xEnumerationAccess->getPresentation(false).trim());
 }
 
-DECLARE_OOXMLIMPORT_TEST(testTdf107784, "tdf107784.docx")
-{
-// Make sure the field displays the citation's title and not the identifier
-uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
-uno::Reference 
xFieldsAccess(xTextFieldsSupplier->getTextFields());
-uno::Reference 
xFields(xFieldsAccess->createEnumeration());
-
-if( !xFields->hasMoreElements() ) {
-CPPUNIT_ASSERT(false);
-return;
-}
-
-uno::Reference 
xEnumerationAccess(xFields->nextElement(), uno::UNO_QUERY);
-CPPUNIT_ASSERT_EQUAL(OUString("Bibliography entry"), 
xEnumerationAccess->getPresentation(true).trim());
-CPPUNIT_ASSERT_EQUAL(OUString("(Smith, 1950)"), 
xEnumerationAccess->getPresentation(false).trim());
-}
-
 DECLARE_OOXMLIMPORT_TEST(testTdf115883, "tdf115883.docx")
 {
 // Import failed due to an unhandled exception when getting the Surround
diff --git a/sw/source/core/fields/fldbas.cxx b/sw/source/core/fields/fldbas.cxx
index 0d8894141506..c46e5bfd3824 100644
--- a/sw/source/core/fields/fldbas.cxx
+++ b/sw/source/core/fields/fldbas.cxx
@@ -418,7 +418,7 @@ SwField::ExpandField(bool const bCached, SwRootFrame 
const*const pLayout) const
 if (GetTypeId() == SwFieldTypesEnum::Authority)
 {
 const SwAuthorityField* pAuthorityField = static_cast(this);
-m_Cache = pAuthorityField->ExpandCitation(AUTH_FIELD_TITLE, 
pLayout);
+m_Cache = 
pAuthorityField->ConditionalExpandAuthIdentifier(pLayout);
 }
 else
 m_Cache = ExpandImpl(pLayout);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/qa sw/source

[Xisco Faulí (via logerrit)]

 dev/null |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |   17 -
 sw/source/core/fields/fldbas.cxx |2 +-
 3 files changed, 1 insertion(+), 18 deletions(-)

New commits:
commit 1d6429fb86d0ba8c03da8621512f3b675d1bcb81
Author: Xisco Faulí 
AuthorDate: Tue Sep 24 16:15:54 2019 +0200
Commit: Xisco Faulí 
CommitDate: Tue Sep 24 18:00:26 2019 +0200

Revert "tdf#107784: DOCX Import: Show citation's title in fields"

This reverts commit fadce0c9a7ccbd7222df90e41d8fc16d9d67045f.

it needs more work. better not to have it in 6.3

Change-Id: Ia6e0d90cf5e56d87aa83903fd787d548c0514ecd
Reviewed-on: https://gerrit.libreoffice.org/79459
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf107784.docx 
b/sw/qa/extras/ooxmlimport/data/tdf107784.docx
deleted file mode 100644
index 2dc868246ac0..
Binary files a/sw/qa/extras/ooxmlimport/data/tdf107784.docx and /dev/null differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 4ee66606b7a6..b49583b3b4d0 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -687,23 +687,6 @@ DECLARE_OOXMLIMPORT_TEST(testTdf105975formula, 
"tdf105975.docx")
 CPPUNIT_ASSERT_EQUAL(OUString("25"), 
xEnumerationAccess->getPresentation(false).trim());
 }
 
-DECLARE_OOXMLIMPORT_TEST(testTdf107784, "tdf107784.docx")
-{
-// Make sure the field displays the citation's title and not the identifier
-uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
-uno::Reference 
xFieldsAccess(xTextFieldsSupplier->getTextFields());
-uno::Reference 
xFields(xFieldsAccess->createEnumeration());
-
-if( !xFields->hasMoreElements() ) {
-CPPUNIT_ASSERT(false);
-return;
-}
-
-uno::Reference 
xEnumerationAccess(xFields->nextElement(), uno::UNO_QUERY);
-CPPUNIT_ASSERT_EQUAL(OUString("Bibliography entry"), 
xEnumerationAccess->getPresentation(true).trim());
-CPPUNIT_ASSERT_EQUAL(OUString("(Smith, 1950)"), 
xEnumerationAccess->getPresentation(false).trim());
-}
-
 DECLARE_OOXMLIMPORT_TEST(testTdf115883, "tdf115883.docx")
 {
 // Import failed due to an unhandled exception when getting the Surround
diff --git a/sw/source/core/fields/fldbas.cxx b/sw/source/core/fields/fldbas.cxx
index f24542012707..a5008b4c4e3a 100644
--- a/sw/source/core/fields/fldbas.cxx
+++ b/sw/source/core/fields/fldbas.cxx
@@ -418,7 +418,7 @@ SwField::ExpandField(bool const bCached, SwRootFrame 
const*const pLayout) const
 if (GetTypeId() == TYP_AUTHORITY)
 {
 const SwAuthorityField* pAuthorityField = static_cast(this);
-m_Cache = pAuthorityField->ExpandCitation(AUTH_FIELD_TITLE, 
pLayout);
+m_Cache = 
pAuthorityField->ConditionalExpandAuthIdentifier(pLayout);
 }
 else
 m_Cache = ExpandImpl(pLayout);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/source

[Xisco Faulí (via logerrit)]

 vcl/source/control/button.cxx |   10 --
 1 file changed, 10 deletions(-)

New commits:
commit ab5da884b16aa54aab8e9773a6e8dbf24e752c36
Author: Xisco Faulí 
AuthorDate: Wed Sep 4 16:22:10 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Sep 5 05:08:43 2019 +0200

tdf#125610: Revert "tdf#125088 Make button text white for blue buttons on 
macOS"

This reverts commit 89775fd396e413daaf0e71710211075450bdc0ed.

Change-Id: I0ddbd454e53bcd442fdf2330661136e041c7d260
Reviewed-on: https://gerrit.libreoffice.org/78611
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 15f80be207b6..146b6402a7f4 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -812,16 +812,6 @@ void PushButton::ImplDrawPushButtonContent(OutputDevice* 
pDev, DrawFlags nDrawFl
 
 if ( nDrawFlags & DrawFlags::Mono )
 aColor = COL_BLACK;
-#ifdef MACOSX
-else if ((nButtonFlags & DrawButtonFlags::Default) && !(GetStyle() & 
WB_FLATBUTTON))
-{
-// Make text color white if the button is a default control on macOS.
-// Without this you get a button with a blue background and blue text
-// which stands out as not looking right on macOS where default buttons
-// have white text and a blue background.
-aColor = COL_WHITE;
-}
-#endif
 else if( (nButtonFlags & DrawButtonFlags::Highlight) && 
IsNativeControlSupported(ControlType::Pushbutton, ControlPart::Entire) )
 {
 if (nButtonFlags & DrawButtonFlags::Pressed)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Xisco Faulí (via logerrit)]

 vcl/source/control/button.cxx |   10 --
 1 file changed, 10 deletions(-)

New commits:
commit ebd7af9aebb5b76255aa299dd8047cb4266215a4
Author: Xisco Faulí 
AuthorDate: Wed Sep 4 16:22:10 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Sep 5 05:02:52 2019 +0200

tdf#125610: Revert "tdf#125088 Make button text white for blue buttons on 
macOS"

This reverts commit 89775fd396e413daaf0e71710211075450bdc0ed.

Change-Id: I0ddbd454e53bcd442fdf2330661136e041c7d260
Reviewed-on: https://gerrit.libreoffice.org/78605
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 4c18207e0844..91141d35cc4e 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -795,16 +795,6 @@ void PushButton::ImplDrawPushButtonContent(OutputDevice* 
pDev, DrawFlags nDrawFl
 
 if ( nDrawFlags & DrawFlags::Mono )
 aColor = COL_BLACK;
-#ifdef MACOSX
-else if ((nButtonFlags & DrawButtonFlags::Default) && !(GetStyle() & 
WB_FLATBUTTON))
-{
-// Make text color white if the button is a default control on macOS.
-// Without this you get a button with a blue background and blue text
-// which stands out as not looking right on macOS where default buttons
-// have white text and a blue background.
-aColor = COL_WHITE;
-}
-#endif
 else if( (nButtonFlags & DrawButtonFlags::Highlight) && 
IsNativeControlSupported(ControlType::Pushbutton, ControlPart::Entire) )
 {
 if (nButtonFlags & DrawButtonFlags::Pressed)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source vcl/source

[Xisco Faulí (via logerrit)]

 sfx2/source/control/unoctitm.cxx |2 
 vcl/source/uitest/logger.cxx |   82 ++-
 vcl/source/uitest/uiobject.cxx   |   68 ++--
 vcl/source/window/dialog.cxx |6 +-
 4 files changed, 31 insertions(+), 127 deletions(-)

New commits:
commit 32bf6bec39748e64ca84a03e7488abe755747081
Author: Xisco Faulí 
AuthorDate: Sat Jun 29 23:37:18 2019 +0200
Commit: Xisco Faulí 
CommitDate: Sun Jun 30 01:13:19 2019 +0200

Revert "Rewrite all the logger statements with the new grammar syntax"

This reverts commit 624530549f30572cb7fb137cbadecfab9a75fc8c.

Change-Id: I4bc0216cc12af637ad291f3ba6af090d1d34f107
Reviewed-on: https://gerrit.libreoffice.org/74916
Tested-by: Jenkins
Reviewed-by: Xisco Faulí 

diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 71cccb05d4e2..aba1357b0ddc 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -601,7 +601,7 @@ void collectUIInformation(const util::URL& rURL, const 
css::uno::Sequence< css::
 if (!pFile)
 return;
 
-UITestLogger::getInstance().logCommand("Send UNO Command (\"" + 
rURL.Complete + "\") ", rArgs);
+UITestLogger::getInstance().logCommand("CommandSent Name:" + 
rURL.Complete, rArgs);
 }
 
 }
diff --git a/vcl/source/uitest/logger.cxx b/vcl/source/uitest/logger.cxx
index 742d8f4ab63a..d100d1bbf125 100644
--- a/vcl/source/uitest/logger.cxx
+++ b/vcl/source/uitest/logger.cxx
@@ -213,21 +213,8 @@ void UITestLogger::logKeyInput(VclPtr const & 
xUIElement, const Key
 
 OUString aParentID = pParent->get_id();
 
-OUString aContent;
-
-if(pUIObject->get_type()=="EditUIObject"){
-aContent =  "Type on '" + rID + "' " + aKeyCode + " from " + aParentID 
;
-}
-else if(pUIObject->get_type()=="SwEditWinUIObject" && rID=="writer_edit"){
-aContent = "Type on writer " + aKeyCode ;
-}
-else if(pUIObject->get_type()=="ScGridWinUIObject" && rID=="grid_window"){
-aContent = "Type on current cell " + aKeyCode ;
-}
-else{
-aContent= pUIObject->get_type() + " Action:TYPE Id:" +
-rID + " Parent:"+ aParentID +" " + aKeyCode;
-}
+OUString aContent = pUIObject->get_type() + " Action:TYPE Id:" +
+rID + " Parent:"+ aParentID +" " + aKeyCode;
 maStream.WriteLine(OUStringToOString(aContent, RTL_TEXTENCODING_UTF8));
 }
 
@@ -253,75 +240,16 @@ OUString StringMapToOUString(const std::map& rParameters)
 return aParameterString.makeStringAndClear();
 }
 
-OUString GetValueInMapWithIndex(const std::map& 
rParameters,sal_Int32 index)
-{
-sal_Int32 j=0;
-
-std::map::const_iterator itr = rParameters.begin();
-
-for ( ; itr != rParameters.end() && jsecond;
-}
-
-
-OUString GetKeyInMapWithIndex(const std::map& 
rParameters,sal_Int32 index)
-{
-sal_Int32 j=0;
-
-std::map::const_iterator itr = rParameters.begin();
-
-for ( ; itr != rParameters.end() && jfirst;
-}
-
 }
 
 void UITestLogger::logEvent(const EventDescription& rDescription)
 {
 OUString aParameterString = StringMapToOUString(rDescription.aParameters);
 
-//here we will customize our statments depending on the caller of this 
function
-OUString aLogLine ;
-
-if(rDescription.aID=="writer_edit"){
-
-if(rDescription.aAction=="GOTO"){
-aLogLine = "GOTO page number " + 
GetValueInMapWithIndex(rDescription.aParameters,0);
-}
-else if(rDescription.aAction=="SET"){
-aLogLine =  "Set Zoom to be "  + 
GetValueInMapWithIndex(rDescription.aParameters,0);
-}
-else if(rDescription.aAction=="SELECT"){
-OUString to = GetValueInMapWithIndex(rDescription.aParameters,0);
-OUString from =   
GetValueInMapWithIndex(rDescription.aParameters,1);
-aLogLine =  "Select from Pos "  +  from + " to " + to ;
-}
-}
-else if(rDescription.aID=="grid_window"){
+OUString aLogLine = rDescription.aKeyWord + " Action:" +
+rDescription.aAction + " Id:" + rDescription.aID +
+" Parent:" + rDescription.aParent + aParameterString;
 
-if(rDescription.aAction=="SELECT"){
-OUString type = GetKeyInMapWithIndex(rDescription.aParameters,0);
-if(type=="CELL" || type=="RANGE"){
-aLogLine = "Select from calc" + aParameterString ;
-}
-else if(type=="TABLE")
-{
- 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0-3' - sd/source

[Xisco Faulí]

 sd/source/ui/sidebar/SlideBackground.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 08ed147729b4b5a4f884b300b0d2e99b6267936a
Author: Xisco Faulí <xiscofa...@libreoffice.org>
Date:   Fri Mar 16 12:22:19 2018 +0100

tdf#116364: Revert "tdf#113660: show Master Slide label in handout view"

This reverts commit 605b01dc591eaa72788be255baf1f9b9dde76414.

Change-Id: I99a2de6a425b1ecd2e9059a9867adac3fc75e619
Reviewed-on: https://gerrit.libreoffice.org/51404
Tested-by: Jenkins <c...@libreoffice.org>
    Reviewed-by: Xisco Faulí <xiscofa...@libreoffice.org>
(cherry picked from commit 855ae519db73b81a64d991b99c8993e6a192df08)
Reviewed-on: https://gerrit.libreoffice.org/51574
Reviewed-by: Eike Rathke <er...@redhat.com>
Reviewed-by: Miklos Vajna <vmik...@collabora.co.uk>
Reviewed-by: Adolfo Jayme Barrientos <fit...@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fit...@ubuntu.com>

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 76da35ddd0b0..d7d93d75755b 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -261,7 +261,6 @@ void SlideBackground::HandleContextChange(
 }
 else if ( maContext == maImpressHandoutContext )
 {
-SetPanelTitle(SdResId(STR_MASTERSLIDE_NAME));
 mpCloseMaster->Hide();
 mpEditMaster->Hide();
 mpMasterSlide->Disable();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sd/source

[Xisco Faulí]

 sd/source/ui/sidebar/SlideBackground.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 855ae519db73b81a64d991b99c8993e6a192df08
Author: Xisco Faulí <xiscofa...@libreoffice.org>
Date:   Fri Mar 16 12:22:19 2018 +0100

tdf#116364: Revert "tdf#113660: show Master Slide label in handout view"

This reverts commit 605b01dc591eaa72788be255baf1f9b9dde76414.

Change-Id: I99a2de6a425b1ecd2e9059a9867adac3fc75e619
Reviewed-on: https://gerrit.libreoffice.org/51404
Tested-by: Jenkins <c...@libreoffice.org>
    Reviewed-by: Xisco Faulí <xiscofa...@libreoffice.org>

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 76da35ddd0b0..d7d93d75755b 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -261,7 +261,6 @@ void SlideBackground::HandleContextChange(
 }
 else if ( maContext == maImpressHandoutContext )
 {
-SetPanelTitle(SdResId(STR_MASTERSLIDE_NAME));
 mpCloseMaster->Hide();
 mpEditMaster->Hide();
 mpMasterSlide->Disable();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Xisco Faulí]

 sd/source/ui/sidebar/SlideBackground.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit b120932c77332f95ae40d7bd96b972ce87e7693a
Author: Xisco Faulí <xiscofa...@libreoffice.org>
Date:   Fri Mar 16 12:22:19 2018 +0100

tdf#116364: Revert "tdf#113660: show Master Slide label in handout view"

This reverts commit 605b01dc591eaa72788be255baf1f9b9dde76414.

Change-Id: I99a2de6a425b1ecd2e9059a9867adac3fc75e619
Reviewed-on: https://gerrit.libreoffice.org/51403
Tested-by: Jenkins <c...@libreoffice.org>
    Reviewed-by: Xisco Faulí <xiscofa...@libreoffice.org>

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index dff9f050a81a..16024b23115a 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -261,7 +261,6 @@ void SlideBackground::HandleContextChange(
 }
 else if ( maContext == maImpressHandoutContext )
 {
-SetPanelTitle(SdResId(STR_MASTERSLIDE_NAME));
 mpCloseMaster->Hide();
 mpEditMaster->Hide();
 mpMasterSlide->Disable();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Fwd: [Libreoffice-qa] Fwd: QA Meeting @ Brno Libreoffice Conference. Wed 19.00-20.00(UTC+2)

[Xisco Faulí]

Hi all,

taking into account that some of us are present at Brno Libreoffice 
Conference this week, we're going to have a face-to-face QA meeting from 
19.00 to 20.00 UTC+2 at the Red Hat Offices while the hackfest session 
is taking place.


Therefore, I invite everybody present at the Libreoffice Conference to 
join the meeting as we would like to hear anything you have to say with 
regards to QA.


On the other hand,  we would also like to try something Gabriel proposed 
yesterday. Basically, we would like to offer the possibility for 
non-QA/non-developer people to report bugs in person, mainly thinking of 
FOSDEM and the incoming Libreoffice Conferences, so we can also show 
them how doing QA looks like at the same time. We plan to do a public 
announcement in the social networks during the course of the day and 
it's going to take place today from 20.00 to 22.00 to see whether 
someone is showing up or not.


I'll keep you updated.

Regards
Xisco
___
List Name: Libreoffice-qa mailing list
Mail address: libreoffice...@lists.freedesktop.org
Change settings: 
https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? 
http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/

Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Fwd: QA Meeting @ Brno Libreoffice Conference. Wed 19.00-20.00(UTC+2)

[Xisco Faulí]

Hi,

Below you can find some notes I took of the main topics we talked 
yesterday during the QA meeting, which eventually lasted from 19.30 to 
23:00.


Attendees: Aaron, Beluga, Robinson, Zdenek, Cor, Timur, Yousuf ( 
hangouts), Xisco


* Rework GetInvolved page ( 
https://wiki.documentfoundation.org/QA/GetInvolved ):

- Focus on newcomers
- Keep it as simple as possible ( easy-to-follow steps )
- Explain just 2 actions:
-- How to confirm bugs
 -- How to retest old bugs (untouched for more than a year)

* Add a new status 'TRIAGE':
- Set when a 'NEW' bug meets the following conditions:
-- Checked it isn't duplicated
-- Checked whether it is a regression
-- Tested in at least two different OSs
-- Priority and Severity have been set

- The barrier shouldn't be too high otherwise it could discourage 
people to do it
- A notification should be sent when a bug has been changed from 
'NEW' to 'TRIAGE' to verify the criteria has been met


the idea behind it would be that newcomers could focus on confirming 
bugs and QA contributors on triaging those confirmed bugs. However, 
newcomers should be able to triage bugs as well, as we want to avoid 
setting limitations for newcomers.


* Send a welcoming email to newcomers:
- Showing gratitude for their work
- Add link to the wiki
- Add link to IRC
- it shouldn't be sent to everyone (be a bit selective)

* Send a polite ping to old QA contributors who have been inactive for a 
while:
- Check who is active nowadays ( useful to check current's QA team 
status too )

- Check who did some great work in the past and send it to them
- Do it recursive over time in order to keep contributors in the 
project
-- A small questionnaire could help us to know if there was 
any specific reason why they left us.


* Social Networks:
- Use reddit to recruit new contributors ( Done once by Beluga with 
positive results )

- Use reddit as a channel where end-users can report bugs
-- a Banner could be added to our bugzilla's mainpage
-- it could be done in youtube too. Example: 
http://ubuntuonair.com/


* Visibility of QA members
- Create a list where QA member are listed
-- Sorted alphabetically ( it's not a competition )
- Add QA numbers to the release notes
- Add QA numbers to under the hood

* Moztrap
- Could be improved. Sample: 
https://shinglyu.github.io/moztrap-new-ui/index.html#/caseversion/search/suite:%22[TV]%20Firefox%20Account%22


* Bibisect Repositories
- Bibisect-5.1max and Bibisect-5.2max for linux on their way
- Mac and Windows repositories created recursively in gerrit
-- Could be interesting to have them for linux too, specially 
for bibisect master.


* Bugzilla Voting System
- Probably it would be better to have a bug heat system where other 
parameters would count as well.

-- Probably not possible in bugzilla
-- Number of subscribers might help here. it's worth a try.

I think I've mentioned all the main topics we covered yesterday. 
However, I may have forgotten something, so feel free to extend this 
email if  it's needed.


Regards,
Xisco

On 07.09.2016 10:05, Xisco Faulí wrote:

 Original Message 
Subject: QA Meeting @ Brno Libreoffice Conference. Wed 
19.00-20.00(UTC+2)

Date: 07.09.2016 09:42
From: Xisco Faulí <xiscofa...@libreoffice.org>
To: libreoffice-qa@lists.freedesktop.org

Hi all,

taking into account that some of us are present at Brno Libreoffice
Conference this week, we're going to have a face-to-face QA meeting
from 19.00 to 20.00 UTC+2 at the Red Hat Offices while the hackfest
session is taking place.

Therefore, I invite everybody present at the Libreoffice Conference to
join the meeting as we would like to hear anything you have to say
with regards to QA.

On the other hand,  we would also like to try something Gabriel
proposed yesterday. Basically, we would like to offer the possibility
for non-QA/non-developer people to report bugs in person, mainly
thinking of FOSDEM and theincoming Libreoffice Conferences, so we can
also show them how doing QA looks like at the same time. We plan to do
a public announcement in the social networks during the course of the
day and it's going to take place today from 20.00 to 22.00 to see
whether someone is showing up or not.

I'll keep you updated.

Regards
Xisco
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: 
https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? 
http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: 
http://wiki.documentfoundation.org/Netiquette

List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

___
List Name: Libreoffice-qa mailing list
Mail a

Re: Fwd: [Libreoffice-qa] Fwd: QA Meeting @ Brno Libreoffice Conference. Wed 19.00-20.00(UTC+2)

[Xisco Faulí]

Hi,

Below you can find some notes I took of the main topics we talked 
yesterday during the QA meeting, which eventually lasted from 19.30 to 
23:00.


Attendees: Aaron, Beluga, Robinson, Zdenek, Cor, Timur, Yousuf ( 
hangouts), Xisco


* Rework GetInvolved page ( 
https://wiki.documentfoundation.org/QA/GetInvolved ):

- Focus on newcomers
- Keep it as simple as possible ( easy-to-follow steps )
- Explain just 2 actions:
-- How to confirm bugs
-- How to retest old bugs (untouched for more than a year)

* Add a new status 'TRIAGE':
- Set when a 'NEW' bug meets the following conditions:
-- Checked it isn't duplicated
-- Checked whether it is a regression
-- Tested in at least two different OSs
-- Priority and Severity have been set

	- The barrier shouldn't be too high otherwise it could discourage 
people to do it
	- A notification should be sent when a bug has been changed from 'NEW' 
to 'TRIAGE' to verify the criteria has been met


the idea behind it would be that newcomers could focus on confirming 
bugs and QA contributors on triaging those confirmed bugs. However, 
newcomers should be able to triage bugs as well, as we want to avoid 
setting limitations for newcomers.


* Send a welcoming email to newcomers:
- Showing gratitude for their work
- Add link to the wiki
- Add link to IRC
- it shouldn't be sent to everyone (be a bit selective)

* Send a polite ping to old QA contributors who have been inactive for a 
while:
	- Check who is active nowadays ( useful to check current's QA team 
status too )

- Check who did some great work in the past and send it to them
	- Do it recursive over time in order to keep contributors in the 
project
-- A small questionnaire could help us to know if there was 
any specific reason why they left us.


* Social Networks:
	- Use reddit to recruit new contributors ( Done once by Beluga with 
positive results )

- Use reddit as a channel where end-users can report bugs
-- a Banner could be added to our bugzilla's mainpage
-- it could be done in youtube too. Example: 
http://ubuntuonair.com/

* Visibility of QA members
- Create a list where QA member are listed
-- Sorted alphabetically ( it's not a competition )
- Add QA numbers to the release notes
- Add QA numbers to under the hood

* Moztrap
	- Could be improved. Sample: 
https://shinglyu.github.io/moztrap-new-ui/index.html#/caseversion/search/suite:%22[TV]%20Firefox%20Account%22


* Bibisect Repositories
- Bibisect-5.1max and Bibisect-5.2max for linux on their way
- Mac and Windows repositories created recursively in gerrit
		-- Could be interesting to have them for linux too, specially for 
bibisect master.


* Bugzilla Voting System
	- Probably it would be better to have a bug heat system where other 
parameters would count as well.

-- Probably not possible in bugzilla
-- Number of subscribers might help here. it's worth a try.

I think I've mentioned all the main topics we covered yesterday. 
However, I may have forgotten something, so feel free to extend this 
email if  it's needed.


Regards,
Xisco

On 07.09.2016 10:50, Xisco Faulí wrote:

Hi all,

taking into account that some of us are present at Brno Libreoffice
Conference this week, we're going to have a face-to-face QA meeting
from 19.00 to 20.00 UTC+2 at the Red Hat Offices while the hackfest
session is taking place.

Therefore, I invite everybody present at the Libreoffice Conference to
join the meeting as we would like to hear anything you have to say
with regards to QA.

On the other hand,  we would also like to try something Gabriel
proposed yesterday. Basically, we would like to offer the possibility
for non-QA/non-developer people to report bugs in person, mainly
thinking of FOSDEM and the incoming Libreoffice Conferences, so we can
also show them how doing QA looks like at the same time. We plan to do
a public announcement in the social networks during the course of the
day and it's going to take place today from 20.00 to 22.00 to see
whether someone is showing up or not.

I'll keep you updated.

Regards
Xisco
___
List Name: Libreoffice-qa mailing list
Mail address: libreoffice...@lists.freedesktop.org
Change settings: 
https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? 
http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: 
http://wiki.documentfoundation.org/Netiquette

List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Fwd: [Libreoffice-qa] Fwd: QA Meeting @ Brno Libreoffice Conference. Wed 19.00-20.00(UTC+2)

[Xisco Faulí]

Hi all,

taking into account that some of us are present at Brno Libreoffice 
Conference this week, we're going to have a face-to-face QA meeting from 
19.00 to 20.00 UTC+2 at the Red Hat Offices while the hackfest session 
is taking place.


Therefore, I invite everybody present at the Libreoffice Conference to 
join the meeting as we would like to hear anything you have to say with 
regards to QA.


On the other hand,  we would also like to try something Gabriel proposed 
yesterday. Basically, we would like to offer the possibility for 
non-QA/non-developer people to report bugs in person, mainly thinking of 
FOSDEM and the incoming Libreoffice Conferences, so we can also show 
them how doing QA looks like at the same time. We plan to do a public 
announcement in the social networks during the course of the day and 
it's going to take place today from 20.00 to 22.00 to see whether 
someone is showing up or not.


I'll keep you updated.

Regards
Xisco
___
List Name: Libreoffice-qa mailing list
Mail address: libreoffice...@lists.freedesktop.org
Change settings: 
https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? 
http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/

Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] Fwd: QA Meeting @ Brno Libreoffice Conference. Wed 19.00-20.00(UTC+2)

[Xisco Faulí]

 Original Message 
Subject: QA Meeting @ Brno Libreoffice Conference. Wed 
19.00-20.00(UTC+2)

Date: 07.09.2016 09:42
From: Xisco Faulí <xiscofa...@libreoffice.org>
To: libreoffice-qa@lists.freedesktop.org

Hi all,

taking into account that some of us are present at Brno Libreoffice 
Conference this week, we're going to have a face-to-face QA meeting from 
19.00 to 20.00 UTC+2 at the Red Hat Offices while the hackfest session 
is taking place.


Therefore, I invite everybody present at the Libreoffice Conference to 
join the meeting as we would like to hear anything you have to say with 
regards to QA.


On the other hand,  we would also like to try something Gabriel proposed 
yesterday. Basically, we would like to offer the possibility for 
non-QA/non-developer people to report bugs in person, mainly thinking of 
FOSDEM and theincoming Libreoffice Conferences, so we can also show them 
how doing QA looks like at the same time. We plan to do a public 
announcement in the social networks during the course of the day and 
it's going to take place today from 20.00 to 22.00 to see whether 
someone is showing up or not.


I'll keep you updated.

Regards
Xisco
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: Crash test update

[Xisco Faulí]

Hi Markus,

2016-04-20 20:46 GMT+02:00 Markus Mohrhard <markus.mohrh...@googlemail.com>:

> Hey Xisco,
>
> On Wed, Apr 20, 2016 at 3:55 PM, Xisco Faulí <aniste...@gmail.com> wrote:
>
>> Hi Caolan,
>>
>> Noob question, should the crash testing detect failures like this one:
>> https://bugs.documentfoundation.org/show_bug.cgi?id=76115
>>
>
>
> No, it is not a crash and just a normal rejected document. It would show
> up if we would for example hit an assert while loading the file but not as
> long as we just reject the file during loading. Also the crash testing has
> a timeout for any document which currently means that crashes in documents
> taking minutes to open will not be discovered.
>
>
In test-bugzilla-files.py, I see that when a timeout is reached, it's just
printed in console, do you think it would be a good idea to at least print
the rejected documents into a file so we can keep track of them over the
time to see if the number of them is increasing or decreasing?

Another noob question: Even if download pdfs use lot of space in disk,
don't you think it would be worth it to test wether they crash at
import/export time? Right now it's disabled:
https://cgit.freedesktop.org/libreoffice/core/tree/bin/get-bugzilla-attachments-by-mimetype#n501


> Regards
> Markus
>
>
>>
>> Best Regards,
>> Xisco
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Crash test update

[Xisco Faulí]

Hi Caolan,

Noob question, should the crash testing detect failures like this one:
https://bugs.documentfoundation.org/show_bug.cgi?id=76115

Best Regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svgio/qa

[Xisco Faulí]

 svgio/qa/cppunit/SvgImportTest.cxx |   36 
 svgio/qa/cppunit/data/tdf97538.svg |   10 --
 2 files changed, 46 deletions(-)

New commits:
commit af46264bccbc16bf1edf9c5cbe944a4b883a1353
Author: Xisco Faulí 
Date:   Mon Mar 7 15:22:59 2016 +

Revert "tdf#97538: SVGIO: Add unittest"

It fails in Tinderbox Linux-rpm_deb-x86@71-TDF
This reverts commit 3c465c259c617e30b01c5ea25b5203a605cd4269.

Change-Id: I20fc69dd785354cc6567b73251ee9161a811bdf0
Reviewed-on: https://gerrit.libreoffice.org/22987
Tested-by: Jenkins 
Reviewed-by: Xisco Faulí 

diff --git a/svgio/qa/cppunit/SvgImportTest.cxx 
b/svgio/qa/cppunit/SvgImportTest.cxx
index f560816..3b0c772 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -53,7 +53,6 @@ class Test : public test::BootstrapFixture, public 
XmlTestTools
 void testRGBColor();
 void testRGBAColor();
 void testTdf97936();
-void testTdf97538();
 
 Primitive2DSequence parseSvg(const char* aSource);
 
@@ -77,7 +76,6 @@ public:
 CPPUNIT_TEST(testRGBColor);
 CPPUNIT_TEST(testRGBAColor);
 CPPUNIT_TEST(testTdf97936);
-CPPUNIT_TEST(testTdf97538);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -405,40 +403,6 @@ void Test::testTdf97936()
 assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[2]", 
"maxx", "60");
 assertXPath(pDocument, "/primitive2D/transform/polypolygoncolor[2]", 
"maxy", "100");
 }
-
-void Test::testTdf97538()
-{
-// check that both rectangles are rendered in the viewBox
-Primitive2DSequence aSequenceTdf97538 = 
parseSvg("/svgio/qa/cppunit/data/tdf97538.svg");
-CPPUNIT_ASSERT_EQUAL(1, (int)aSequenceTdf97538.getLength());
-
-Primitive2dXmlDump dumper;
-xmlDocPtr pDocument = 
dumper.dumpAndParse(comphelper::sequenceToContainer(aSequenceTdf97538));
-
-CPPUNIT_ASSERT (pDocument);
-
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "color", "#ff");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "height", "200");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "width", "199");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "minx", "145");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "miny", "-24");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "maxx", "345");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[1]/polypolygoncolor", "maxy", "175");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "color", "#ff");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "height", "200");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "width", "199");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "minx", "145");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "miny", "-24");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "maxx", "345");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[2]/polypolygoncolor", "maxy", "175");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "color", "#008000");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "height", "200");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "width", "199");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "minx", "145");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "miny", "-24");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "maxx", "345");
-assertXPath(pDocument, 
"/primitive2D/transform/transform[3]/polypolygoncolor", "maxy", "175");
-}
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 }
diff --git a/svgio/qa/cppunit/data/tdf97538.svg 
b/svgio/qa/cppunit/data/tdf97538.svg
deleted file mode 100644
index ef2936e..000
--- a/svgio/qa/cppunit/data/tdf97538.svg
+++ /dev/null
@@ -1,10 +0,0 @@
-
-http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd;>
-http://www.w3.org/2000/svg;>
-  
-
-
-
-  
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svgio/inc svgio/source

[Xisco Faulí]

 svgio/inc/svgio/svgreader/svgstyleattributes.hxx |2 +-
 svgio/source/svgreader/svgstyleattributes.cxx|   17 -
 2 files changed, 1 insertion(+), 18 deletions(-)

New commits:
commit 85fcf15ff41ceb95f46dee586ff7187551be4955
Author: Xisco Faulí 
Date:   Sat Feb 27 00:17:25 2016 +

Revert "SVGIO: tdf#97539: clip-path elements might contain..."

This reverts commit 7b7ffedfa6357b902a5e354d986dac39a3b2f462.

Change-Id: I018830e17cb83c5fe3574b76939673877ac2004d
Reviewed-on: https://gerrit.libreoffice.org/22726
Tested-by: Jenkins 
Reviewed-by: Xisco Faulí 

diff --git a/svgio/inc/svgio/svgreader/svgstyleattributes.hxx 
b/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
index 011b5f3..33258d5 100644
--- a/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
+++ b/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
@@ -441,7 +441,7 @@ namespace svgio
 void setDesc(const OUString& rNew) { maDesc = rNew; }
 
 // ClipPathXLink content
-OUString getClipPathXLink() const;
+const OUString getClipPathXLink() const { return maClipPathXLink; }
 
 // MaskXLink content
 const OUString getMaskXLink() const { return maMaskXLink; }
diff --git a/svgio/source/svgreader/svgstyleattributes.cxx 
b/svgio/source/svgreader/svgstyleattributes.cxx
index 56a1ac5..3e454e4 100644
--- a/svgio/source/svgreader/svgstyleattributes.cxx
+++ b/svgio/source/svgreader/svgstyleattributes.cxx
@@ -2659,23 +2659,6 @@ namespace svgio
 return nullptr;
 }
 
-OUString SvgStyleAttributes::getClipPathXLink() const
-{
-if(!maClipPathXLink.isEmpty())
-{
-return maClipPathXLink;
-}
-
-const SvgStyleAttributes* pSvgStyleAttributes = getParentStyle();
-
-if(pSvgStyleAttributes)
-{
-return pSvgStyleAttributes->getClipPathXLink();
-}
-
-return OUString();
-}
-
 OUString SvgStyleAttributes::getMarkerStartXLink() const
 {
 if(!maMarkerStartXLink.isEmpty())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Problem with assertXPath and doubles

[Xisco Faulí]

Hi all,

I'm writing you this email because I came across a problem when trying to
use assetXPath to check a double value.
I created this test https://gerrit.libreoffice.org/#/c/22196/ to cover the
opacity attribute, which is 0.5, however, If I do

assertXPath(pDocument, "/primitive2D/transform/mask/unifiedtransparence",
"transparence", "0.5");

it fails because the value it returns is 0 and the decimals are lost on
they way.

I've tried to debug it but I see that at this point:
http://opengrok.libreoffice.org/xref/core/test/source/xmltesttools.cxx#74,
it's already returning 0 so I don't know where else to see.

My question is: is this behavior intentioned? if not, could anybody give a
hint where the problem could be?

Best Regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] Bugzilla Idea: Issues assign to me

[Xisco Faulí]

Hi all,

Do you think it would be plausible to have a link in bugzilla's menu to
quickly check the issues assign to oneself like the link 'My bugs'? Right
now, the only way I found to check this is in 'Advanced Search' - Custom
Search -  Assignee equals to 'user' which IMHO, is quite tedious.

On the other hand, I found that taking an issue doesn't change the status
to ASSIGNED. Could bugzilla be hacked to do it automatically or it's
intentioned?

BR
Xisco
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Two svg import filters

[Xisco Faulí]

Hi all,

Recently I've been working on some fixes for filter/source/svg/* and my
intention would be to spend some more time to fix other issues in this
filter as there's plenty of room for improvements. However, I'd like to
know if a decision is going to be make wrt this topic before I do other
fixes as I wouldn't like to work on something that, eventually, is going to
be drop.
>From my point of view, I find svgio to support more svg elements and
atributtes than svg filter but, as mentioned before, they do different
things, svgio imports the file as svg and the filter as a draw document so
it can be edited afterwards, so either we drop one or the other we are
going to lose some already implemented features. On the other hand, it's
also a pain to have 2 filters that do more or less the same.
With regards to the missing support in svg filter, I don't think it
wouldn't be to difficult to improve it, as other filters already implement
similar features, so they can be taken as a guidance.

Regards

*
https://gerrit.libreoffice.org/#/q/owner:%22Xisco+Faul%25C3%25AD+Tarazona+%253Canistenis%2540gmail.com%253E%22
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Two svg import filters

[Xisco Faulí]

Hi,

it would be nice if this topic can be dicussed today at the ESC meeting.

Regards

2015-11-05 12:22 GMT+01:00 Armin Le Grand <armin_le_gr...@me.com>:

> Hi,
>
> Am 05.11.2015 um 10:30 schrieb Xisco Faulí:
>
> Hi all,
>
> Recently I've been working on some fixes for filter/source/svg/* and my
> intention would be to spend some more time to fix other issues in this
> filter as there's plenty of room for improvements. However, I'd like to
> know if a decision is going to be make wrt this topic before I do other
> fixes as I wouldn't like to work on something that, eventually, is going to
> be drop.
> From my point of view, I find svgio to support more svg elements and
> atributtes than svg filter but, as mentioned before, they do different
> things, svgio imports the file as svg and the filter as a draw document so
> it can be edited afterwards, so either we drop one or the other we are
> going to lose some already implemented features. On the other hand, it's
> also a pain to have 2 filters that do more or less the same.
>
>
> SVG added as GraphicObject using svgio can also be edited - that's why
> there is a 'break' command in the context menu for this objects. Not sure
> if this command is available in all Apps from the UI perspective (the core
> can always break SVGs), but you may try in draw/impress. Breaking creates
> all SdrObjects needed to represent the SVG.
>
> With regards to the missing support in svg filter, I don't think it
> wouldn't be to difficult to improve it, as other filters already implement
> similar features, so they can be taken as a guidance.
>
> Regards
>
> *
> https://gerrit.libreoffice.org/#/q/owner:%22Xisco+Faul%25C3%25AD+Tarazona+%253Canistenis%2540gmail.com%253E%22
>
>
> ___
> LibreOffice mailing 
> listLibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
> --
> ALG (PGP Key: EE1C 4B3F E751 D8BC C485 DEC1 3C59 F953 D81C F4A2)
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] minutes of ESC call ...

[Xisco Faulí]

>
> * Hackfests (Bjoern)
> + Could we join the GNOME hack-fest in Madrid ? (Bjoern)
> + booked a room.
> + if they get 5x more LibreOffice hackers - would be good.
> + 3x confirmed people: Bubli, JanI, Bjoern.
> + volunteers are invited.
> + may attend the hack-fest (Jacobo)
> + no wiki page yet Dec 2nd -> 4th planned.
> + waiting for confirmation.
>

Hi,

I'm currently living in Madrid and I'd like to attempt the meeting. It goes
without saying that I can give a hand on the field if help is needed.

Regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] minutes of ESC call ...

[Xisco Faulí]

>
> * Hackfests (Bjoern)
> + Could we join the GNOME hack-fest in Madrid ? (Bjoern)
> + booked a room.
> + if they get 5x more LibreOffice hackers - would be good.
> + 3x confirmed people: Bubli, JanI, Bjoern.
> + volunteers are invited.
> + may attend the hack-fest (Jacobo)
> + no wiki page yet Dec 2nd -> 4th planned.
> + waiting for confirmation.
>

Hi,

I'm currently living in Madrid and I'd like to attempt the meeting. It goes
without saying that I can give a hand on the field if help is needed.

Regards
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Patch for 55185

[Xisco Faulí]

Hi all,

going through some issues in bugzilla, I found that
https://bugs.documentfoundation.org//show_bug.cgi?id=55185 has a patch
attached that was never reviewed.

Could any dev take a look at it and review it please?

Regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Idea] Add files from SVG Test Suite Overview to get-bugzilla-attachments-by-mimetype (crashtest)

[Xisco Faulí]

Hello again,

Thanks for your interest Caolán. It's cold that those files has been added
to the crashtesting archive.
Here comes another idea: For some reasons, some users just upload the
documents to bugzilla compressed ( Ie:
https://bugs.documentfoundation.org/show_bug.cgi?id=82624)
Do you think it would be worth to improve the downloader script to download
those compressed files and uncompress the files that can be used for the
testing?

Regards

2015-08-28 12:23 GMT+02:00 Caolán McNamara <caol...@redhat.com>:

> On Wed, 2015-08-26 at 16:59 +0200, Xisco Faulí wrote:
> > Hello,
> >
> > Reviewing some issues in bugzilla, I found that some of them make
> > mention of files in the SVG Test Suite Overview(1), so I thought it
> > could be a good a idea to include the files from the different test
> > suite editions into get-bugzilla-attachments-by-mimetype.
>
> What I've done is to take the suite archive and just add it manually to
> the crashtesting archive rather than hack the downloader, which is more
> for scraping documents out of bugzillas.
>
> C.
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Idea] Add files from SVG Test Suite Overview to get-bugzilla-attachments-by-mimetype (crashtest)

[Xisco Faulí]

Hello,

Reviewing some issues in bugzilla, I found that some of them make mention
of files in the SVG Test Suite Overview(1), so I thought it could be a good
a idea to include the files from the different test suite editions into
get-bugzilla-attachments-by-mimetype.

Do you think it would be worth to do so?


1. http://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview

Regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] New Whiteboard Statuses

[Xisco Faulí]

Hello all,

does it make sense to include another status for the regression issues
where the problematic commit has been identified ? I'm asking it because
yesterday I spent some time on this task and I could chase down two
regressions, one of them made by a Collabora developer ( I've already sent
him an email ) and the other by a merged AOO commit.

Regards,
Xisco


2014-06-05 4:49 GMT+02:00 Joel Madero jmadero@gmail.com:


 On 06/04/2014 07:45 PM, Jay Philips wrote:
  Hi All,
 
  I think it might be a good idea to include the following whiteboard
  keywords -
 
  HasDebug or HasBacktrace  HasStrace - When the bug reporter or
  commenter has included the backtrace or strace output, so devs can
  easily see this list
 I like all of these
 
  ConfirmedCrashHalt or ConfirmedCrash  ConfirmedHalt- similar to
  ConfirmedRegression, this would be used by the QA team to assign that
  they have confirmed the crash or halt of the UI, and we dont have to
  rely on search for random keywords to pull up an already vetted list of
  results
 Don't like these as much - a good bug title is sufficient to say crash
 IMHO and a triager can edit a title easy.
  WinOnly, LinOnly  MacOnly - MacOnly would be very helpful to me so i
  can filter out the reports that i've confirmed dont happen on windows
  and linux, and priority can be given to these bugs by the QA team who
  have macs as someone already from the QA team has already confirmed its
  existence to be limited to mac, and also because 'Mac OS X (All)'
  doesn't indicate that it wont also happen on other OSes - fdo#79460
 I think we should just use the OS field for this. Already we have way
 too many whiteboard status'. If we do this then OS field becomes useless
 and redundant.
 
  LanguageSpecific:jp - a means of filtering reports that can only be
  properly tested by an individuals who know a particular language and i
  think it would be useful when we expand the bug submission beyond just
  english. - fdo#77489
 +1


 Best,
 Joel
 ___
 List Name: Libreoffice-qa mailing list
 Mail address: Libreoffice-qa@lists.freedesktop.org
 Change settings:
 http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
 Problems?
 http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
 Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
 List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: Euro Converter Wizard

[Xisco Faulí]

Hello,

In that case we should add those currencies to the wizard because they
aren't present right now.
What about creating an extension of this wizard and dropping it from core
so libreoffice wouldn't ship it by default to a large amount of user who
are not using it?

Regard


2013/5/15 Caolán McNamara caol...@redhat.com

 On Tue, 2013-05-14 at 13:44 +0200, Cedric Bosdonnat wrote:
  On Tue, 2013-05-14 at 12:54 +0200, Xisco Faulí wrote:
   Euro Converter Wizard has become a bit outdated nowadays and I'm
   wondering if it'd convenient to get rid of it.
  
  
   Personally I'd do so, but I'd like to hear from you, especially from
   the libreoffice expect to decide together what's the best.
   So please, I'd appreciate if you could share your thoughts about it.
 
  I'ld be in favor of dropping it too... who is still using that? And if
  someone wants it, then there are other tools providing that function.

 FWIW, Euro area enlargment is an ongoing thing, e.g. Latvia and
 Lithuania are scheduled to join in 2014/2015 (while the last one was
 Estonia in 2011) so if adding the euro wizard in the first place was a
 good idea, then presumably its still a good idea to keep it for the
 purposes of converting lats and litas to euros.

 C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Euro Converter Wizard

[Xisco Faulí]

Hello all,

Euro Converter Wizard has become a bit outdated nowadays and I'm wondering
if it'd convenient to get rid of it.

Personally I'd do so, but I'd like to hear from you, especially from the
libreoffice expect to decide together what's the best.
So please, I'd appreciate if you could share your thoughts about it.

Regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Implementing alternate compatibility functions (such as 0^0 = ERROR)

[Xisco Faulí]

Hello,

I've seen this was implemented in Apache Openoffice recently. Probably we
can just merge it into Libreoffice.

Commit:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=aoo/trunkid=908088f614cda46d9c996e40579611df27276394

Regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing alternate compatibility functions (such as 0^0 = ERROR)

[Xisco Faulí]

I'm sorry, I didn't know about that discussion.
You're right, it's pointless to do the same here, so it's better just to
stop the discussion.

Please accept my apologies
Xisco


2013/2/22 Tor Lillqvist t...@iki.fi

  I've seen this was implemented in Apache Openoffice recently. Probably we
  can just merge it into Libreoffice.

 And you did not notice the flood of useless discussion that ensued on
 the AOO list, with one contributor (partially) leaving AOO?

 PLEASE STOP THIS DISCUSSION NOW! ;)

 --tml

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Wizards and Java

[Xisco Faulí]

Hi,

Yes, we should pop up a 'you need Java' message too. This wizard still uses
Java.

Regards,
Xisco

2013/1/21 Bjoern Michaelsen bjoern.michael...@canonical.com

 Hi,

 just checking lp#780399 on libreoffice4beta1 and trying to launch the
 wizards
 without Java installed, I either:

 - get a wizard (awesome! Thanks Xisco and Python)
 - or a 'you need to install Java' (better than before, were nothing
 happend)

 except for the 'Web Wizard'. Is any plan on this right now, or should we
 pop up
 a 'you need Java' message there too?

 Best,

 Bjoern

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Duplicated default templates

[Xisco Faulí]

Hello again,

I found out why agenda templates are duplicated. The reason is we need a
reference template to link the different sections of the template to toggle
their text. The java code is here:
http://opengrok.libreoffice.org/xref/core/wizards/com/sun/star/wizards/text/TextSectionHandler.java#175

Regards,
Xisco

2013/1/18 Xisco Faulí aniste...@gmail.com

 Hello everybody,

 working on agenda wizard I came across this
 folder install/share/template/common/wizard/agenda where all default agenda
 templates are duplicated. Is there any reason why they are duplicated ?
 None of the other wizard's templates are. If noone yeld about it I'd like
 to proceed and delete them. It'll let us save ~180kb.

 Regards,
 Xisco

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Duplicated default templates

[Xisco Faulí]

Hello everybody,

working on agenda wizard I came across this
folder install/share/template/common/wizard/agenda where all default agenda
templates are duplicated. Is there any reason why they are duplicated ?
None of the other wizard's templates are. If noone yeld about it I'd like
to proceed and delete them. It'll let us save ~180kb.

Regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Pyuno ImportError

[Xisco Faulí]

Hello,

I rebuilt master and it doesn't happen anymore. Probably I did something
wrong because noone but me complained about it.
Sorry for the inconvience.

Regards

2013/1/16 Caolán McNamara caol...@redhat.com

 On Sat, 2013-01-05 at 02:51 +0100, Xisco Faulí wrote:
  Hello everybody,
 
 
  I've just built libreoffice after a couple of weeks and now pyuno
  fails to import elements from the API, like from
  com.sun.star.awt.VclWindowPeerAttribute import OK.
  It worked well before Christmas. Any regression introduced during this
  time?

 Is this still a problem ?, and if it is can you file a bug with an
 easy-to-reproduce example ?

 C.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Pyuno ImportError

[Xisco Faulí]

Hello everybody,

I've just built libreoffice after a couple of weeks and now pyuno fails to
import elements from the API, like from
com.sun.star.awt.VclWindowPeerAttribute import OK.
It worked well before Christmas. Any regression introduced during this time?

regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: problems with python3.3 and UNO components

[Xisco Faulí]

 Hi there,

 On Mon, 2012-11-26 at 10:07 +0100, Xisco Faulí wrote:
  I rebuilt master with the latest changes made by Michael Stahl,
  Michael Meeks and Julien Nabet and
  desktop.addTerminateListener(TerminateListenerProcAdapter(test)) does
  not fail anymore. However, print(dir(desktop)) still yells the same
  problem.

 Did we get this all sorted out in the end ? :-)


print(dir(desktop)) doesn't work yet. It'd be interesting to have it fixed
because sometimes it's really useful to check the names defined by an api
function.


  Anyway, I could already launch fax wizard using python3.3 so this is a
  big step foward. Thank you to all of you guys.

 Cool - thank you for all your great work there for 4.0 - it's
 wonderful
 to see progress in the python migration. Incidentally - any chance you
 could update:

 http://wiki.documentfoundation.org/ReleaseNotes/4.0

 To add your work  credit in there ? :-)


Done!


 Thanks !

 Michael.

 --
 michael.me...@suse.com  , Pseudo Engineer, itinerant idiot


Regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Python Wizard for Agenda - unclickable text insert placeholders ?

[Xisco Faulí]

Hello Alex,

Agenda Wizard hasn't been ported to python yet. There's already a python
version of this wizard but some parts of it do not work as expected so for
now File  Wizards  Agenda calls the java wizard. I always try to work on
it in my free time but I don't have much recently :(
Anyway, I appreaciate your feedback and I'll make sure it works properly in
python.

Regards,
Xisco
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: problems with python3.3 and UNO components

[Xisco Faulí]

Hello all,

I rebuilt master with the latest changes made by Michael Stahl, Michael
Meeks and Julien Nabet and
desktop.addTerminateListener(TerminateListenerProcAdapter(test)) does not
fail anymore. However, print(dir(desktop)) still yells the same problem.
Anyway, I could already launch fax wizard using python3.3 so this is a big
step foward. Thank you to all of you guys.

Regards,
Xisco Faulí
2012/11/22 Xisco Faulí aniste...@gmail.com

 Hello all,

 I built libreoffice with python3.3 today in order to adapt python code to
 this version and I realized python3.3 has a different behaviour interacting
 with UNO components than python2.7 does. Just to check it I created a
 simple script:

 import unohelper

 def test():
 localContext = uno.getComponentContext()
 resolver = localContext.ServiceManager.createInstanceWithContext(
 com.sun.star.bridge.UnoUrlResolver, localContext )
 ctx = resolver.resolve(
 uno:socket,host=localhost,port=2002;urp;StarOffice.ComponentContext )
 smgr = ctx.ServiceManager
 desktop = smgr.createInstanceWithContext(
 com.sun.star.frame.Desktop,ctx)
 print(dir(desktop))
 desktop.addTerminateListener(TerminateListenerProcAdapter(test))
 model = desktop.getCurrentComponent()
 text = model.Text
 cursor = text.createTextCursor()
 text.insertString( cursor, Hello World, 0 )
 ctx.ServiceManager

 from com.sun.star.frame import XTerminateListener
 class TerminateListenerProcAdapter(unohelper.Base, XTerminateListener):
 def __init__( self, oProcToCall):
 self.oProcToCall = oProcToCall

 if __name__ == __main__:
 test()

 in python2.7 it works perfecty but in python3.3 it throws 2 exceptions.

 print(dir(desktop)):

 Traceback (most recent call last):
   File test.py, line 25, in module
 test()
   File test.py, line 11, in test
 print(dir(desktop))
 TypeError: object does not provide __dir__
 Error in sys.excepthook:
 Traceback (most recent call last):
   File /home/xisco/libo/install/program/uno.py, line 286, in _uno_import
 d[x] = pyuno.getClass( name + . + x )
 uno.RuntimeException: pyuno.getClass: uno exception
 apport.fileutils.likely_packaged is unknown

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File /home/xisco/libo/install/program/uno.py, line 290, in _uno_import
 d[x] = Enum( name , x )
   File /home/xisco/libo/install/program/uno.py, line 123, in __init__
 pyuno.checkEnum( self )
 uno.RuntimeException: attributes typeName and/or value of uno.Enum are not
 strings

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File /home/xisco/libo/install/program/uno.py, line 294, in _uno_import
 d[x] = getConstantByName( name + . + x )
   File /home/xisco/libo/install/program/uno.py, line 48, in
 getConstantByName
 return pyuno.getConstantByName( constant )
 uno.RuntimeException: apport.fileutils.likely_packaged

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File /usr/lib/python3/dist-packages/apport_python_hook.py, line 64, in
 apport_excepthook
 from apport.fileutils import likely_packaged, get_recent_crashes
   File /home/xisco/libo/install/program/uno.py, line 297, in _uno_import
 raise ImportError( type + name + . +x +  is unknown )
 ImportError: type apport.fileutils.likely_packaged is unknown

 Original exception was:
 Traceback (most recent call last):
   File test.py, line 25, in module
 test()
   File test.py, line 11, in test
 print(dir(desktop))
 TypeError: object does not provide __dir__

 and desktop.addTerminateListener(TerminateListenerProcAdapter(test)) (
 comenting previous line):

 Traceback (most recent call last):
   File test.py, line 25, in module
 test()
   File test.py, line 12, in test
 desktop.addTerminateListener(TerminateListenerProcAdapter(test))
 uno.RuntimeException: Couldn't convert
 __main__.TerminateListenerProcAdapter object at 0xb70cb9ec to a UNO type;
 caught exception: attributes typeName and/or value of uno.Enum are not
 strings
 Error in sys.excepthook:
 Traceback (most recent call last):
   File /home/xisco/libo/install/program/uno.py, line 286, in _uno_import
 d[x] = pyuno.getClass( name + . + x )
 uno.RuntimeException: pyuno.getClass: uno exception
 apport.fileutils.likely_packaged is unknown

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File /home/xisco/libo/install/program/uno.py, line 290, in _uno_import
 d[x] = Enum( name , x )
   File /home/xisco/libo/install/program/uno.py, line 123, in __init__
 pyuno.checkEnum( self )
 uno.RuntimeException: attributes typeName and/or value of uno.Enum are not
 strings

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File /home/xisco/libo/install/program

problems with python3.3 and UNO components

[Xisco Faulí]

/install/program/uno.py, line 297, in _uno_import
raise ImportError( type + name + . +x +  is unknown )
ImportError: type apport.fileutils.likely_packaged is unknown

Original exception was:
Traceback (most recent call last):
  File test.py, line 25, in module
test()
  File test.py, line 12, in test
desktop.addTerminateListener(TerminateListenerProcAdapter(test))
uno.RuntimeException: Couldn't convert
__main__.TerminateListenerProcAdapter object at 0xb70cb9ec to a UNO type;
caught exception: attributes typeName and/or value of uno.Enum are not
strings


any idea ?

Regards,
Xisco Faulí
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ANNOUNCE] Fax wizard replaced

[Xisco Faulí]

Hello all,

I've just pushed a commit to master that replace the java fax wizard with
the python wizard(1). The wizard works pretty well for me on linux but I
haven't been able to test it on windows nor mac. I'd appreciate if you can
give it a try and give me some feedbacks. Go to file - wizards - fax and
play a bit.
Probably you'll have to enable python debugging (2) to see the exceptions
in case they're raised.

Greetings

1:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=500edb98783fea1d8f244b0ca0d2eb5b099985e5
2: http://opengrok.libreoffice.org/xref/core/pyuno/README
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

License Statement

[Xisco Faulí]

Dear All,

I'm still alive but still travelling so I can't code at the moment.
I'm coming back in a few months and I'm looking forward to finish the
work I did during the last GSOC. For now, here you have my license
statement:

All of my past  future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.

Greetings from Honduras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] how to call python code from the menu

[Xisco Faulí]

Hello,

I've tried your patch and it works perfectly. What i'm trying now is to
import from CallWizard.py another file.
Let's imagine I have a file in fax/ called Test.py that looks like this:

class Test():

def __init__(self):
print it works

I add it to Pyuno_fax.mk

$(eval $(call gb_Pyuno_add_files,fax,\
CallWizard.py \
Test.py \
))

and then I import it in CallWizard.py like: from Test import Test but it
doesn't work ( I've also tried from com.sun.star.wizards.fax.Test import
Test )

any idea ?

2011/9/7 Caolán McNamara caol...@redhat.com

 On Wed, 2011-09-07 at 11:24 +0100, Caolán McNamara wrote:
  On Tue, 2011-09-06 at 19:49 +0200, Xisco Faulí wrote:
   Hello,
  
  
   I've tried to follow your steps but placing the code in
   wizards/com/sun/star/wizards/fax/CallWizard.py. So far I haven't been
   able to build it successfully. It complains and says: ERROR: File not
   found: CallWizard.py
 
  I see that wizards has been converted to gmake in the meantime, so it no
  longer uses dmake makefile.mk stuff, we need some gbuild support for
  copying .py files into their final locations with some form of
  pyuno .component file support support.

 dtardon was good enough to put together the gmake stuff needed to get
 this bootstrapped, which are now committed to master.

 So here's your patch back again, except gbuildified so this should
 work to make wizards-fax stick hello world into writer.

 There's still a lot of nasty things, dumping the .py directly into
 program as opposed to making some sort of subdir into which they can
 go, but maybe it'll help

 C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] make dev-install reruns the build

[Xisco Faulí]

Hello,

I chatted with scarabeus and we both agreed that there's a problem when
running make dev-install because it reruns the build for install targets
when It shouldn't.

Let's me know if any further information is needed

Cheers
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build error in moz

[Xisco Faulí]

it works. Thanks ;)

2011/9/15 Norbert Thiebaud nthieb...@gmail.com

 On Wed, Sep 14, 2011 at 8:47 PM, Norbert Thiebaud nthieb...@gmail.com
 wrote:
  On Wed, Sep 14, 2011 at 7:25 PM, Xisco Faulí aniste...@gmail.com
 wrote:
  I pulled master to the last commit and built it again but it still fails
 
 
  How did you 'build again'? did you do a clean build? if not, did you
  redelivered moz ? if neither then that is expected.

 I meant: redeliver nss, not moz ...
 
  Norbert
 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] build error in moz

[Xisco Faulí]

log:

/usr/bin/ld: cannot find -lcrmf
collect2: ld returned 1 exit status
make[4]: *** [libpipnss.so] Error 1
make[4]: Leaving directory `/home/xisco/libo/moz/
unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager/ssl/src'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/home/xisco/libo/moz/
unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager/ssl'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/home/xisco/libo/moz/
unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager'
make[1]: *** [tier_50] Error 2
make[1]: Leaving directory `/home/xisco/libo/moz/
unxlngi6.pro/misc/build/mozilla/I_objdir'
make: *** [default] Error 2
dmake:  Error code 2, while making './
unxlngi6.pro/misc/build/so_built_ooo_mozab'

I searched in google and i found this old post:
http://vijayk.blogspot.com/2006/12/failure-in-moz-while-building.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] build error in moz

[Xisco Faulí]

I pulled master to the last commit and built it again but it still fails

2011/9/15 Norbert Thiebaud nthieb...@gmail.com

 On Wed, Sep 14, 2011 at 4:19 PM, Xisco Faulí aniste...@gmail.com wrote:
  log:
  /usr/bin/ld: cannot find -lcrmf
  collect2: ld returned 1 exit status
  make[4]: *** [libpipnss.so] Error 1
  make[4]: Leaving directory
  `/home/xisco/libo/moz/
 unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager/ssl/src'
  make[3]: *** [libs] Error 2
  make[3]: Leaving directory
  `/home/xisco/libo/moz/
 unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager/ssl'
  make[2]: *** [libs] Error 2
  make[2]: Leaving directory
  `/home/xisco/libo/moz/
 unxlngi6.pro/misc/build/mozilla/I_objdir/security/manager'
  make[1]: *** [tier_50] Error 2
  make[1]: Leaving directory
  `/home/xisco/libo/moz/unxlngi6.pro/misc/build/mozilla/I_objdir'
  make: *** [default] Error 2
  dmake:  Error code 2, while making
  './unxlngi6.pro/misc/build/so_built_ooo_mozab'
  I searched in google and i found this old
  post:
 http://vijayk.blogspot.com/2006/12/failure-in-moz-while-building.html

 Should be fixed on master with commit
 032fca6818f4a034a4352159d5f9977eecbe6dad

 let us know if that solve it for you.

 Norbert

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] how to call python code from the menu

[Xisco Faulí]

Hello,

I've tried to follow your steps but placing the code in
wizards/com/sun/star/wizards/fax/CallWizard.py. So far I haven't been able
to build it successfully. It complains and says: ERROR: File not found:
CallWizard.py

I attach a file with the changes I've done.

Greetings

2011/8/17 Caolán McNamara caol...@redhat.com

 On Wed, 2011-08-17 at 09:06 +0100, Caolán McNamara wrote:
  I imagine that if you basically opengrok for mailmerge.py and
  mailmerge.component and follow the same pattern for your one that it'll
  get you a lot closer.

 Seeing as this is a bit tricky to get up and running, attached is a
 rough-and-ready patch to turn wizards-letter into hello world in
 python.

 i.e.

 a) add a hello_world.component (which gets run through the usual xslt
 script via the local makefile.mk to tweak it to give the right location
 where the .py will finally get installed) that describes a
 hello_world.py component. The .component has the implementation name,
 e.g. org.openoffice.comp.pyuno.demo.HelloWorld in it and the services it
 implements, e.g. com.sun.star.task.Job

 b) I added a hello_world.py that implements that, see its
 g_ImplementationHelper.addImplementation for the matching implementation
 name and services

 c) add that hello_world.component to postprocess where it will be
 basically added as an entry into the services.rdb in the final install
 sets install/program/services.rdb (which is an xml file these days. That
 should end up having component loader=com.sun.star.loader.Python
 uri=vnd.openoffice.pymodule:hello_worldimplementation
 name=org.openoffice.comp.pyuno.demo.HelloWorldservice
 name=com.sun.star.task.Job//implementation/component/components
 in it).

 d) change the wizards-letter line in officecfg to call it

 e) modify scp2 to install it

 f) I haven't a clue what the entry in instsetoo_native does anymore, I
 think I used to know :-)

 hope this helps.

 C.

From ac490d5f468ad36041ecd03e2761481be281c56a Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Tue, 6 Sep 2011 19:39:20 +0200
Subject: [PATCH] call callwizard

---
 .../registry/data/org/openoffice/Office/Common.xcu |2 +-
 postprocess/packcomponents/makefile.mk |2 +-
 scp2/source/ooo/file_ooo.scp   |   12 ++
 scp2/source/ooo/module_hidden_ooo.scp  |1 +
 scripting/prj/d.lst|1 +
 wizards/com/sun/star/wizards/fax/CallWizard.py |  175 
 wizards/com/sun/star/wizards/fax/fax.component |6 +-
 wizards/com/sun/star/wizards/fax/makefile.mk   |8 +-
 8 files changed, 56 insertions(+), 151 deletions(-)

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 998ab38..85d4480 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -400,7 +400,7 @@
   /node
   node oor:name=m1 oor:op=replace install:module=writer
 prop oor:name=URL  oor:type=xs:string
-  value service:com.sun.star.wizards.fax.CallWizard?start/value
+  value service:com.sun.star.wizards.fax.CallWizard?insert/value
 /prop
 prop oor:name=Title
   value xml:lang=en-US~Fax.../value
diff --git a/postprocess/packcomponents/makefile.mk b/postprocess/packcomponents/makefile.mk
index addc3a2..ff264c8 100644
--- a/postprocess/packcomponents/makefile.mk
+++ b/postprocess/packcomponents/makefile.mk
@@ -364,7 +364,7 @@ my_components += evoab
 my_components += component/avmedia/source/gstreamer/avmediagstreamer
 .END
 
-my_ooo_components = mailmerge
+my_ooo_components = mailmerge component/wizards/com/sun/star/wizards/fax/fax
 
 .INCLUDE: target.mk
 
diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index e77bdcf..3bc1eee 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -471,6 +471,18 @@ STD_JAR_FILE( gid_File_Jar_Saxon, saxon9 )
 #endif
 #endif
 
+#ifndef AIX
+#ifndef DISABLE_PYUNO
+File gid_File_PyFax
+TXT_FILE_BODY;
+Dir = gid_Dir_Program;
+Name = CallWizard.py;
+Styles = (PACKED);
+End
+#endif
+#endif
+
+
 #ifndef SYSTEM_LIBTEXTCAT_DATA
 // fingerprint files (lm)
 
diff --git a/scp2/source/ooo/module_hidden_ooo.scp b/scp2/source/ooo/module_hidden_ooo.scp
index 9dd3ab1..287e277 100644
--- a/scp2/source/ooo/module_hidden_ooo.scp
+++ b/scp2/source/ooo/module_hidden_ooo.scp
@@ -139,6 +139,7 @@ Module gid_Module_Root_Files_3
 	gid_File_Jar_Table,
 	gid_File_Jar_Letter,
 	gid_File_Jar_Form,
+	gid_File_PyFax,
 	gid_File_Jar_Agenda,
 	gid_File_Jar_Web,
 	gid_File_Jar_Query,
diff --git a/scripting/prj/d.lst b/scripting/prj/d.lst
index f1caf45..5deedbe 100644
--- a/scripting/prj/d.lst
+++ b/scripting/prj/d.lst
@@ -16,6 +16,7 @@ mkdir: %_DEST%\bin\pyuno
 
 ..\%__SRC%\lib\lib*static*.dylib %_DEST%\lib\lib*static*.dylib
 ..\%__SRC%\misc\mailmerge.component 

Re: [Libreoffice] [GSOC] how to call python code from the menu

[Xisco Faulí]

Thank you for pointing out this file but I don't really understand how it
works.
The wizard is called here :
http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu#441
where
MailMergeWizard is the service register in Writer.xcu (
http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/Writer.xcu#30
)
but then how libo knows that this service refers to mailmerge.py ?

Greetings

2011/8/16 Caolán McNamara caol...@redhat.com

 On Mon, 2011-08-15 at 19:02 +0200, Xisco Faulí wrote:
  Hello everybody,
 
 
  before I merge the gsoc branch into master I'd like to integrate the
  python code into libo and get rid of the java code.
  I know i have to edit this file
 
 http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/Common.xcubut
  i can't figure out how to call the python code.  I've tried to call this
 file
 http://opengrok.libreoffice.org/xref/core/pyuno/demo/hello_world_comp.pyusing 
 this value:
 valueservice:org.openoffice.comp.pyuno.demo.HelloWorld?insert/value but
 it doesn't work. Any idea ?

 Perhaps hello_world_comp.py isn't registered as a service ?

 Did you look at how the mailmerge.py example is installed ?, i.e.
 http://opengrok.libreoffice.org/search?q=mailmerge.py for a python
 component which is bundled into LibreOffice.

 You may have to do pretty much the same thing for it be available via
 service:...?foo out-of-the-box. There's some preamble at the top of
 mailmerge.py about how to manually register that component for testing
 purposes, which is probably the archaic way to do it these-days, but
 probably still works.

 C.




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] how to call python code from the menu

[Xisco Faulí]

Hello everybody,

before I merge the gsoc branch into master I'd like to integrate the python
code into libo and get rid of the java code.
I know i have to edit this file
http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/Common.xcu
but
i can't figure out how to call the python code.  I've tried to call this
file
http://opengrok.libreoffice.org/xref/core/pyuno/demo/hello_world_comp.py using
this value: 
valueservice:org.openoffice.comp.pyuno.demo.HelloWorld?insert/value
but it doesn't work. Any idea ?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Report #10. Wizards

[Xisco Faulí]

Hello everybody,

I finished last weekend the agenda wizard ( perhaps there're still some
 minor not-really-relevant issues to fix) and I'm already working on the
last wizard, the web one. I also have in mind that I still have to create
the make files for calling the python code within libo but i'm going to be
quite busy this week because I'm moving back to Spain so I don't know how
 much time I'll have to work on it.

You can take a look to my last commits here:
http://cgit.freedesktop.org/libreoffice/components/log/?h=feature/gsoc2011_wizards

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Report #8. Wizard

[Xisco Faulí]

Hello,

What have I done this week?

- Work on the agenda wizard. I wanted it to be done about last weekend but
there's a bug ( which affects the java wizard on master too ) and it took me
a while to find it out. I reported the bug here:
https://bugs.freedesktop.org/show_bug.cgi?id=39313. I don't think it affects
the 3.4 branch but it would be nice if someone can try it and check that the
wizard runs properly ( File  Wizards  Agenda ) because it crashes Libo on
master.

- Take a look to this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=38451 . I already know how to
fix it but I'm waiting for cédric's answer ( I think he's on holidays)

- As I said in my previous report, there is something ( i haven't been able
to figure it out ) that breaks Adress Data Source. Here some information:
http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg13235.html .
Should i create a new bug ?

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] LibreOffice Python -- how to create a simple inputbox?

[Xisco Faulí]

you can use the model com.sun.star.awt.UnoControlEditModel.
Take a look to this page:
http://wiki.services.openoffice.org/wiki/ES/Desarrollo/Add-on_de_Soporte . I
couldn't find it in english but the code fits your needs pretty well ;)

Greetings

2011/7/15 Stanislav Pika stasp...@gmail.com

 Hi!

 How to create an inputbox in LibreOffice Python? I've spent many days
 trying to figure that out, and it seems that while there is an interface
 XMessageBoxFactory, there is nothing like XInputBox. That is, something
 that allows user text input.

 XMessageBoxFactory allows only the following messagebox types:

  * infobox
  * warningbox
  * errorbox
  * querybox
  * messagebox

 None of these has an input field.


 Best regards
 Stanislav Pika

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #7: Wizards

[Xisco Faulí]

2011/7/14 Matúš Kukan matus.ku...@gmail.com

 Hi Xisco,

 On 14 July 2011 00:41, Xisco Faulí aniste...@gmail.com wrote:
  Hello,
  I took a look to the problem related to the Adress Data Souce Wizard (
 it's
  not loaded on master ) and it's not caused by the changes i've been
 working
  on. I moved git to a commit before the one I merged the feature branch
 into
  master and it still fails.
  The code fails here
  :
 http://opengrok.libreoffice.org/xref/components/wizards/source/template/Correspondence.xba#110

 That's not good. I'm sorry, hopefully you didn't waste much time with that.
 You can revert commits

 http://cgit.freedesktop.org/libreoffice/components/commit/?id=c707c7a19a0bef0075f3ba10366e0fc05c96702a

 http://cgit.freedesktop.org/libreoffice/components/commit/?id=7d23e260cce288878b61e78a1db523b7678ba299
 locally for now. It should work without them. If not let me know.

I don't think those commit are the problem because I tried : git reset
--hard HEAD~20 ( right a moment before a merge my branch into master ) and
it failed as well.


  The error:
  __main__.CannotActivateFactoryException:
  file:///home/xisco/libo/solver/350/
 unxlngi6.pro/installation/opt/program/../basis-link/program/libabplo.sohttp://unxlngi6.pro/installation/opt/basis-link/program/libabplo.so
 :
  cannot get factory of demanded implementation:
  org.openoffice.comp.abp.OAddressBookSourcePilot

 How can I reproduce the error?
 I'm not sure what to do about that now.


well, If you go to File  Wizards  Adress Data Source none error will be
raised and the wizard won't be loaded, but if you create a Personal Fax
(File  Wizards  Fax) the fax wizard will try to load the adress data
source after it's created and the error will be raised

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #7: Wizards

[Xisco Faulí]

Hello,

I took a look to the problem related to the Adress Data Souce Wizard ( it's
not loaded on master ) and it's not caused by the changes i've been working
on. I moved git to a commit before the one I merged the feature branch into
master and it still fails.

The code fails here :
http://opengrok.libreoffice.org/xref/components/wizards/source/template/Correspondence.xba#110

http://opengrok.libreoffice.org/xref/components/wizards/source/template/Correspondence.xba#110The
error:

__main__.CannotActivateFactoryException: file:///home/xisco/libo/solver/350/
unxlngi6.pro/installation/opt/program/../basis-link/program/libabplo.so:
cannot get factory of demanded implementation:
org.openoffice.comp.abp.OAddressBookSourcePilot

Greetings

2011/7/12 Michael Meeks michael.me...@novell.com

 Hi Xisco,

First - again nice to hear of your good work :-)

 On Tue, 2011-07-12 at 01:24 +0200, Xisco Faulí wrote:
  - Migrate basic to the new resource service rewrote by Björn a while
  ago.

 Ooh - right :-) and I assume we've merged this all to master ?

  By the way, I was wondering whether it would be better to convert the
  basic code into python as well. There's some code duplicated in python
  and in basic, it could save us some lines of code. Anyway, I'd like to
  hear your opinion first.

 Of course, the priority is to convert Java - python, to reduce our
 dependency / warning-on-start problems on Windows, but after that
 certainly, I'd personally love to see some StarBasic - Python migration
 goodness as well.

ATB,

Michael.

 --
  michael.me...@novell.com  , Pseudo Engineer, itinerant idiot



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Report #7: Wizards

[Xisco Faulí]

Hello there,

Here's what i've done this week:

- Fix a visualitation problem related to Letter Wizard
- Start to work on Agenda Wizard
- Talk with Björn about adding the python files into the makefile so we can
call it from File  Wizards and remove the Java code
- a bit of cleaning
- Migrate basic to the new resource service rewrote by Björn a while ago.
Now the Document and the Euro Converter work good and show the dialog ( they
didn't before because they couldn't load the resources). For some strange
reason, Address Data Source doesn't work. I'll take a look this week. by the
way, I was wondering whether it would be better to convert the basic code
into python as well. There's some code duplicated in python and in basic, it
could save us some lines of code. Anyway, I'd like to hear your opinion
first.

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #5. Wizards

[Xisco Faulí]

Wow, thank Peter for this amazing explanation. I'm currently sumerged into
the gsoc project too so I can't give it a try right now but I'm sure I will
once I finish it. The problem right now is I don't know most of the things
you're talking about so I'll need first to get my feet wet. I'll let you
know when I start to work on it.

Greetings

2011/7/7 Peter Jentsch pj...@guineapics.de

 Hi Xisco,

 one more thing: I looked at at XSLTFilter code again and noticed that
 although a lot of data get's passed in to the import call, only a tiny
 fragment of that makes it to the actual transformation, so you won't be
 able to use any parameters in the transformation. I don't like that
 situation, and if you'd chose to investigate deeper into the approach I
 sketched out I'd extend the XSLT Filter call to pass parameters to the
 transformation.

 We get a MediaDescriptor struct handed in there, which has a string
 field FilterOptions that can be passed unmodified to any
 transformation. That should be sufficient if the total amount of
 information to get into the transformation remains small.

 Cheers,

 Peter

 Am 04.07.11 12:42, schrieb Michael Meeks:
  Hi Xisco,
 
Peter - Xisco is working on re-writing the wizards in Java :-)
 
  On Fri, 2011-07-01 at 16:05 +0200, Xisco Faulí wrote:
  Michael wrote:
 Weelll - so you're both right; but really we need to
  grub about inside the templates themselves to add some
  improved translation scheme I think; now we have fast native
  XSLTs - I guess we could use the native XSLT filters to allow
  the templates to be self-standing, and yet adapt
  to the locale nicely.
 But - your task is primarily the Java - python
  conversion I guess :-)
  Xisco wrote:
  Yes, you're right but if I have some time before gsoc finishes (or
  even after) I'd like to  take a look to it. Who should I get in
  contact with in order to get my feet wet ?
Ah - so the XSLT expert is Peter Jentsch who has done a load of
 great
  work in this area, writing the much faster / smaller native C++ filter
  etc. He can prolly help out with some code pointers, and/or perhaps some
  simple example XSLTs that might be useful for translating attributes /
  elements (?), and ways to get feed the required data to them elegantly.
 
HTH,
 
Michael.
 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Report #6. Wizards

[Xisco Faulí]

Hello,

I've been working this week on converting the letter wizard and as Cedric
suggested me in the last report, I merged the feature branch into master.
You can find the code in the component repository. Fax and Letter wizards
aren't fully functional yet but I'd appreciate if someone gives it a try and
give me some feedbacks.

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #5. Wizards

[Xisco Faulí]

2011/6/30 Michael Meeks michael.me...@novell.com

 Hi Xisco,

 On Thu, 2011-06-30 at 18:28 +0200, Xisco Faulí wrote:
  Correct me if i'm wrong but as i've seen in the fax wizard,each kind
  of template has its own template so I believe it's the same for the
  letter templates and every localize has a different template, right ?

 Um ;-) in theory yes, but in reality no - having a duplicated ODF
 file
 for each and every translation (duplicating all the XML, all embedded
 images etc. etc.) bloated our install sets to some huge size for no good
 reason :-)

   In that case, the templates are the ones that should be changed,
  right ?

 Weelll - so you're both right; but really we need to grub about
 inside
 the templates themselves to add some improved translation scheme I
 think; now we have fast native XSLTs - I guess we could use the native
 XSLT filters to allow the templates to be self-standing, and yet adapt
 to the locale nicely.

But - your task is primarily the Java - python conversion I guess
 :-)


Yes, you're right but if I have some time before gsoc finishes (or even
after) I'd like to  take a look to it. Who should I get in contact with in
order to get my feet wet ?



   All the best,

Michael.

 --
  michael.me...@novell.com  , Pseudo Engineer, itinerant idiot



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #5. Wizards

[Xisco Faulí]

2011/6/29 Cedric Bosdonnat cedric.bosdonnat@free.fr

 Hi Xisco,

 On Wed, 2011-06-29 at 01:23 +0200, Xisco Faulí wrote:
  Sorry for the delay but I had a visit last weekend and I wasn't able
  to work on it until yesterday night.
  What I've done during the week:
  - Improve the boot speed
  - Clean a bit the code
  - Show a message when a file is going to be overwritten
  - Load the previous configuration

 Where is your work available ATM? Could you please start merging it with
 master to get a build with all GSoc projects for midterms?


http://cgit.freedesktop.org/libreoffice/components/?h=feature/gsoc2011_wizards




The idea behind that isn't to have something 100% complete and working,
 but to show to the world what you've already done and get feedback.

  Now i'm working on saving the configuration after the wizard is
  finnished. I think it'll be done tomorrow.

 Cool, then it would be nice to have it in master!


Ok, i'll merge it next week.


  Furthermore, I've already started to work on the letter wizard. Let's
  see If I can already commit something by the end of the week.

 I would be awesome if you could improve that wizard to get something
 based on localised templates... Letters aren't formatted in the same way
 across the world and that wasn't taken into account by the old wizard.


Correct me if i'm wrong but as i've seen in the fax wizard,each kind of
template has its own template so I believe it's the same for the letter
templates and every localize has a different template, right ? In that case,
the templates are the ones that should be changed, right ?

Greetings


 --
 Cédric Bosdonnat
 LibreOffice hacker
 http://documentfoundation.org
 OOo Eclipse Integration developer
 http://cedric.bosdonnat.free.fr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Report #5. Wizards

[Xisco Faulí]

Hello,

Sorry for the delay but I had a visit last weekend and I wasn't able to work
on it until yesterday night.
What I've done during the week:
- Improve the boot speed
- Clean a bit the code
- Show a message when a file is going to be overwritten
- Load the previous configuration

Now i'm working on saving the configuration after the wizard is finnished. I
think it'll be done tomorrow.
Furthermore, I've already started to work on the letter wizard. Let's see If
I can already commit something by the end of the week.

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Report #3: Wizards

[Xisco Faulí]

Hi,

I'm sorry I didn't say anything yesterday but I was all day long at my
university and I didn't have time to test anything. Before i went to sleep I
did a make clean  make ( why ? I guess i didn't have anything to loose )
and now everything works correctly. it looks like the problem was fixed
yesterday. Thank you anyway.

@John, yeah, you're right but this time was different. Even make clean
didn't work so at that point I decided to compile it from scratch.

2011/6/14 John LeMoyne Castle lemoyne.cas...@gmail.com

 Actually not at all sure where to clean+build to get missing uno symbols in
 the log
 Looks like an assortment of dirs may be involved
 Help would be appreciated as it is ~necessary for me to proceed here.
 -- jlc

 --
 View this message in context:
 http://nabble.documentfoundation.org/GSOC-Report-3-Wizards-tp3060259p3064324.html
 Sent from the Dev mailing list archive at Nabble.com.
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Report #3: Wizards

[Xisco Faulí]

Hi,

After i did my first commit last tuesday i worked for 2 days on adding the
button listeners and fixing some errors:
http://cgit.freedesktop.org/libreoffice/components/?h=feature%2Fgsoc2011_wizards
Then,
on Thursday and on Friday I started to optimize it ( it takes 10 sec for
showing the dialog ) but I made a mess in the git tree ( git and I aren't
good friends ) and I decided eventually to delete the source and download it
again from scratch. Now I already have it compiled but when I run libo I get
this error: terminate called after throwing an instance of
'com::sun::star::loader::CannotActivateFactoryException'. Any idea ?

Cheers
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Weekly Report: Wizards....

[Xisco Faulí]

Hello,

I keep doing. I can't say anything specific because all i'm doing is that,
converting the code. I'm working now on the files in ui/event/.  it's taking
me some time because it's a bit confused but i think It'd take me much
longer. After I complete it, I'd like to create a git repository so it would
be easier for you to follow my evolution.

Grettings

2011/5/24 Xisco Faulí aniste...@gmail.com

 Yes, that's right, i'm focusing on the fax wizard first, anyway it uses
 other classes, such as UI components or document handlers, which are mostly
 placed in common and ui. The way I've been converting it is really simple:
 first I converted the class CallWizard.java which has the method trigger
 which initializes the wizard. This method creates an instance of
 FaxWizardDialogImpl. I converted this class and saw which other classes this
 class uses and I converted them as well and so on. I'm basically expanding
 little by little up to the moment I'll already have all the files needed for
 creating the fax wizard converted.

 2011/5/24 Michael Meeks michael.me...@novell.com


 On Tue, 2011-05-24 at 00:18 +0200, Xisco Faulí wrote:
  Anyway I spent some time working on the google project last week as
  well. So far I've already converted ~40 files.

 Oooh ... can you test the results ? are they working (ie. with the
 translation stuff stubbed out) ? I assume you're going deep first (ie.
 get one wizard working), rather than broad - getting all
 semi-working :-) particularly with automated code translation, depth,
 then width is best I'm sure [ you may need to improve the translation
 tool etc. ].

  Apart from that, everything is going well and as expected.

 Great news ! :-) looking forward to your results, good to hit the
 ground running too ...

Thanks !

Michael.

 --
  michael.me...@novell.com  , Pseudo Engineer, itinerant idiot




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Java Python, problem with uno.invoke

[Xisco Faulí]

Hello,

It's funny how close I was to the solution and the time it took me to find
it.

uno.invoke(xPSet, setPropertyValue, (PropertyName,
uno.Any( \
[]string,PropertyValue)))

Thank you John for your answer.

2011/5/28 John LeMoyne Castle j...@mail2lee.com

 Hi Xisco,
 I think your Java-Python porting project is awesome.  My experience is
 thin
 on many counts here: Java, Python, pyuno and LibreOffice, but I have been
 curious about them all, so I dove in a little on your question.

 My short answer of encouragement: Yes, you can solve it!

 One question is how are you treating PropertyValue?
 If PropertyValue can still be either boolean or a list of strings (in your
 Python as in the Java) then your initial test If PropertyValue: may
 prevent setting *any* property to false.  I think this safety check is moot
 anyway: Python will complain and quit before calling the setControlProperty
 function with nothing as the third argument object.

 I see that the invoke call is new - nice to see the setControlProperty
 function actually setting the property on the control ;-)  I think the path
 that call takes is through the extern C static invoke at:

 http://opengrok.libreoffice.org/xref/ure/pyuno/source/module/pyuno_module.cxx#596
 through PYUNO_invoke at:
 http://opengrok.libreoffice.org/xref/ure/pyuno/source/module/pyuno.cxx#335
 where it seems that the Any wrapper is optional (!!).  If you do pass
 PYUNO_invoke a tuple of Anys it just unpacks them before making a call
 like:
 object.name(tuple of args)

 I see that the Any wrapper is required to make calls through the
 Adapter::invoke here:

 http://opengrok.libreoffice.org/xref/ure/pyuno/source/module/pyuno_adapter.cxx#194
 --- but I'm sure you are not calling that invoke as it has a very different
 signature.  The extern C static invoke function requires the third arg to
 be
 a tuple, so I think it is sufficient to test for tuple type and then make
 the singletons a tuple of 1 before the invoke call.

 Finally, from the way PYUNO_invoke turns the ControlName and PropertyName
 into the callable function object, I think that passing the PropertyName as
 the second argument is sufficient - it doesn't need to go in the tuple as
 well.

 My understanding is that Java needs the Any foo to pass both simple types
 and objects as generic objects whereas everything in Python is an object so
 ... your Python glue code may often be simpler than the original Java.

 Please remember I'm no expert -- I just spent a few hours on this to start
 to dig into pyuno while doing a full LibreOffice build ...

 Hope This Helps,
 LeMoyne



 --
 View this message in context:
 http://nabble.documentfoundation.org/GSOC-Java-Python-problem-with-uno-invoke-tp2994887p2995406.html
 Sent from the Dev mailing list archive at Nabble.com.
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Java Python, problem with uno.invoke

[Xisco Faulí]

Hello,

I have converted the method setControlProperty in  UnoDialog:
http://opengrok.libreoffice.org/xref/components/wizards/com/sun/star/wizards/ui/UnoDialog.java#149
as follow:

def setControlProperty(self, ControlName, PropertyName, PropertyValue):
try:
if PropertyValue:

if self.xDialogModel.hasByName(ControlName) == False:
return
xPSet = self.xDialogModel.getByName(ControlName)
if isinstance(PropertyValue,tuple):
uno.invoke(xPSet, setPropertyValue, (PropertyName,
uno.Any( \
com.sun.star.beans.PropertyValue,PropertyValue)))
else:
xPSet.setPropertyValue(PropertyName, PropertyValue)

except Exception, exception:
traceback.print_exc()

but I get this Exception:

  File /usr/lib/python2.6/dist-packages/uno.py, line 249, in invoke
return pyuno.invoke( object, methodname, argTuple )
com.sun.star.uno.RuntimeException: value is not of same or derived type!

as vmiklos told me in IRC the third parameter of invoke should be a tuple of
PropertyValue but in the Java code the variable PropertyValue  is a Bool or
a list of strings.

Anybody knows can I solve it ?

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Weekly Report: Wizards....

[Xisco Faulí]

Hello everybody,

I'm sorry for the one day delay in the weekly report but I had a project
deadline today and I was working hard on it. Anyway I spent some time
working on the google project last week as well.
So far I've already converted ~40 files. I'll still need more time in order
to summit the first results. Expecially now, in the beginning, that most
files in common and UI folders must be converted. About the problem I
commented last week, Michael and Björn found what the problem was and as
Björn mailed today, it should be fixed during this week. Apart from that,
everything is going well and as expected.

Cheers
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Wizards, Java to Python report #2

[Xisco Faulí]

AFAICS this line causes troubles: xResource =
smgr.createInstance(com.sun.star.resource.VclStringResourceLoader) .
When I try to use any XInvocation method on it, i get a Segmentation Fault
error ( I have the OS in german so the current message is
Speicherzugriffsfehler. I don't speak much german so I guess Segmentation
Fault is the right translation ).
Anyway, when I run the MRI againt this line I get:


URP_Bridge : disposed
(tid=3) Unexpected connection closure


Well, I've tried several things but I've been able to make it run. I guess
I'm missing something.


Greetings.

2011/5/17 Xisco Faulí aniste...@gmail.com

 AFAICS this line causes troubles: xResource =
 smgr.createInstance(com.sun.star.resource.VclStringResourceLoader) .
 When I try to use any XInvocation method on it, i get a Segmentation Fault
 error ( I have the OS in german so the current message
 is Speicherzugriffsfehler. I don't speak much german so I guess Segmentation
 Fault is the right translation ).
 Anyway, when I run the MRI againt this line I get:

  URP_Bridge : disposed
 (tid=3) Unexpected connection closure

 Well, I've tried several things but I've been able to make it run. I guess
 I'm missing something.

 Greetings.


 2011/5/16 Alexander Thurgood alex.thurg...@gmail.com

 Le 16/05/11 10:19, Xisco Faulí a écrit :

 Hi Xisco,

 
  The only thing I haven't been able to convert is the method
  initResources in common/resource.java :
 
 http://opengrok.libreoffice.org/xref/components/wizards/com/sun/star/wizards/common/Resource.java#111
 
  I can't find any information in the api about VclStringResourceLoader.
  any idea ?
 

 Trawling through previous API discussions in the OOo lists came up with
 these :


 http://openoffice.2283327.n4.nabble.com/XResourceBundle-Loader-td2929318.html


 http://openoffice.2283327.n4.nabble.com/XResourceBundle-Loader-td2929318.html


 http://openoffice.org.sourcearchive.com/documentation/1.1.3/Tools_8java-source.html

 But you're right, there doesn't seem to be very much information around
 about how to use it...maybe using Bernard Marcelly's XRay/MRI
 introspection tool might reveal what's available ?


 http://extensions.services.openoffice.org/en/project/MRI




 Alex

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Wizards, Java to Python report #2

[Xisco Faulí]

Hello everybody,

As Michael Meeks suggested in my first report, I'm using a Java to Python
converter, which name is Yava2python. So far, I've already converted all the
files in the folder fax and some in ui and common. It's not
straightforward, so it takes some time and some researches.

The only thing I haven't been able to convert is the method initResources in
common/resource.java :
http://opengrok.libreoffice.org/xref/components/wizards/com/sun/star/wizards/common/Resource.java#111

I can't find any information in the api about VclStringResourceLoader. any
idea ?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GSOC] Progress Report

[Xisco Faulí]

Hello there,

Finally I made yava2python run. I only needed to download txl from
http://www.txl.ca/
http://www.txl.ca/I've already tried to convert some files. It's not
straight, and in fact, it needs quite work but, I think it makes things much
easier. Thanks Michael.
Btw, I've just realized I only sent the last email to Andras, shit .

2011/5/9 Xisco Faulí aniste...@gmail.com

 I think it could be  a good idea to use a python to java converter too but
 unfortunately I couldn't run any converter againt the code.
 First I tried with java2python but it doesn't work with java 5 grammer. I
 suppose java2python with j2p is the way to make it works, but I couldn't
 make them run. Then I found out another coverter called yava2python but
 everytime I run it, it says: txl: not found.
 Today I didn't have too much time so I'll try it again tomorrow. Anyway, if
 anybody can give me a hand with it, i'll appreciate it.
 Btw, I couldn't reach Björn today, he's in a conference, so the decision of
 using a java to python converter is completely up to him.
 The same about generating fax templates on runtime. From my point of view,
 I'd try to get the wizards working on python first and then, make it
 possible to create the templates on runtime, but as I said, this isn't up to
 me.

 Greetings

 2011/5/9 Andras Timar tima...@gmail.com

 Hi,

 2011/5/8 Xisco Faulí aniste...@gmail.com:
  My task during the GSOC period is going to be the conversion of the
 Wizard
  menus into python.
  I met Björn Michäelsen last monday and we decided, on broad lines, the
  course to follow. First I'll create a basic fax design using pyuno, then
  I'll make it customized and finally I'll create the GUI. Once the fax
 wizard
  is done, I'll move on with the other wizards.

 I wonder if it would be possible to generate fax templates runtime
 from the locale data (page size, date format) and from localized
 strings. This way we could get rid of the numerous template files in
 our packages, and we could have them localized easier. I know it's out
 of scope of the original project. :) I just wanted to let you know
 about this. I can help you in all localization related problems.

 Best regards,
 Andras



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSOC] Progress Report

[Xisco Faulí]

Hello everybody,

My task during the GSOC period is going to be the conversion of the Wizard
menus into python.
I met Björn Michäelsen last monday and we decided, on broad lines, the
course to follow. First I'll create a basic fax design using pyuno, then
I'll make it customized and finally I'll create the GUI. Once the fax wizard
is done, I'll move on with the other wizards.
This week I've been studying the java code in order to see what things do
and playing around a bit with Pyuno and the GUI. I've tried to create some
text components and some GUI dialogs. So far it's going good although I've
had problem with a few things I have to take a deeper look.

Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] use RTL_CONSTASCII_USTRINGPARAM

[Xisco Faulí]

Licesed under LGPLv3 and GPL.
From e7cbf2c25e1b08a2421663eaf5639df30a536ee4 Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Wed, 6 Apr 2011 16:53:52 +0200
Subject: [PATCH] use RTL_CONSTASCII_USTRINGPARAM

---
 xmloff/source/chart/SchXMLAxisContext.cxx|   88 +-
 xmloff/source/chart/SchXMLChartContext.cxx   |2 +-
 xmloff/source/chart/SchXMLExport.cxx |4 +-
 xmloff/source/chart/SchXMLLegendContext.cxx  |6 +-
 xmloff/source/chart/SchXMLSeries2Context.cxx |2 +-
 5 files changed, 51 insertions(+), 51 deletions(-)

diff --git a/xmloff/source/chart/SchXMLAxisContext.cxx b/xmloff/source/chart/SchXMLAxisContext.cxx
index b4efdbb..149b6e1 100644
--- a/xmloff/source/chart/SchXMLAxisContext.cxx
+++ b/xmloff/source/chart/SchXMLAxisContext.cxx
@@ -178,18 +178,18 @@ Reference drawing::XShape  SchXMLAxisContext::getTitleShape()
 {
 case SCH_XML_AXIS_X:
 if( m_aCurrentAxis.nAxisIndex == 0 )
-aPropName = OUString::createFromAscii( HasXAxisTitle );
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM( HasXAxisTitle ));
 else
-aPropName = OUString::createFromAscii( HasSecondaryXAxisTitle );
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM( HasSecondaryXAxisTitle ));
 break;
 case SCH_XML_AXIS_Y:
 if( m_aCurrentAxis.nAxisIndex == 0 )
-aPropName = OUString::createFromAscii( HasYAxisTitle );
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM( HasYAxisTitle ));
 else
-aPropName = OUString::createFromAscii( HasSecondaryYAxisTitle );
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM( HasSecondaryYAxisTitle ));
 break;
 case SCH_XML_AXIS_Z:
-aPropName = OUString::createFromAscii( HasZAxisTitle );
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM( HasZAxisTitle ));
 break;
 case SCH_XML_AXIS_UNDEF:
 OSL_TRACE( Invalid axis );
@@ -212,21 +212,21 @@ void SchXMLAxisContext::CreateGrid( OUString sAutoStyleName, bool bIsMajor )
 {
 case SCH_XML_AXIS_X:
 if( bIsMajor )
-aPropName = OUString::createFromAscii(HasXAxisGrid);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasXAxisGrid));
 else
-aPropName = OUString::createFromAscii(HasXAxisHelpGrid);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasXAxisHelpGrid));
 break;
 case SCH_XML_AXIS_Y:
 if( bIsMajor )
-aPropName = OUString::createFromAscii(HasYAxisGrid);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasYAxisGrid));
 else
-aPropName = OUString::createFromAscii(HasYAxisHelpGrid);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasYAxisHelpGrid));
 break;
 case SCH_XML_AXIS_Z:
 if( bIsMajor )
-aPropName = OUString::createFromAscii(HasZAxisGrid);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasZAxisGrid));
 else
-aPropName = OUString::createFromAscii(HasZAxisHelpGrid);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasZAxisHelpGrid));
 break;
 case SCH_XML_AXIS_UNDEF:
 OSL_TRACE( Invalid axis );
@@ -418,21 +418,21 @@ void SchXMLAxisContext::CreateAxis()
 {
 case SCH_XML_AXIS_X:
 if( m_aCurrentAxis.nAxisIndex == 0 )
-aPropName = OUString::createFromAscii(HasXAxis);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasXAxis));
 else
-aPropName = OUString::createFromAscii(HasSecondaryXAxis);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasSecondaryXAxis));
 break;
 case SCH_XML_AXIS_Y:
 if( m_aCurrentAxis.nAxisIndex == 0 )
-aPropName = OUString::createFromAscii(HasYAxis);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasYAxis));
 else
-aPropName = OUString::createFromAscii(HasSecondaryYAxis);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasSecondaryYAxis));
 break;
 case SCH_XML_AXIS_Z:
 if( m_aCurrentAxis.nAxisIndex == 0 )
-aPropName = OUString::createFromAscii(HasXAxis);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasXAxis));
 else
-aPropName = OUString::createFromAscii(HasSecondaryXAxis);
+aPropName = OUString(RTL_CONSTASCII_USTRINGPARAM(HasSecondaryXAxis));
 break;
 case SCH_XML_AXIS_UNDEF:
 OSL_TRACE( Invalid axis );
@@ -468,7 +468,7 @@ void SchXMLAxisContext::CreateAxis()
 {
 try
 {
-

Re: [Libreoffice] [PATCH] [PUSHED] use RTL_CONSTASCII_USTRINGPARAM

[Xisco Faulí]

Here it goes another patch, Same licence.

2011/4/6 Tor Lillqvist tlillqv...@novell.com

 Thanks, pushed!

 --tml


From 6e2b921ea0d5a780bf910cb6bd1a2abc856a78f8 Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Thu, 7 Apr 2011 00:17:14 +0200
Subject: [PATCH] use RTL_CONSTASCII_USTRINGPARAM

---
 framework/source/fwe/helper/undomanagerhelper.cxx |4 +-
 framework/source/layoutmanager/helpers.cxx|2 +-
 framework/source/lomenubar/FrameHelper.cxx|   56 ++---
 framework/source/lomenubar/FrameJob.cxx   |   14 +++---
 4 files changed, 37 insertions(+), 39 deletions(-)

diff --git a/framework/source/fwe/helper/undomanagerhelper.cxx b/framework/source/fwe/helper/undomanagerhelper.cxx
index 1bbd58b..2781bc2 100644
--- a/framework/source/fwe/helper/undomanagerhelper.cxx
+++ b/framework/source/fwe/helper/undomanagerhelper.cxx
@@ -651,7 +651,7 @@ namespace framework
 ?   rUndoManager.GetUndoActionCount( IUndoManager::TopLevel )
 :   rUndoManager.GetRedoActionCount( IUndoManager::TopLevel );
 if ( nElements == 0 )
-throw EmptyUndoStackException( ::rtl::OUString::createFromAscii( stack is empty ), getXUndoManager() );
+throw EmptyUndoStackException( ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( stack is empty )), getXUndoManager() );
 
 aGuard.clear();
 // --- SYNCHRONIZED
@@ -1116,7 +1116,7 @@ namespace framework
 
 IUndoManager rUndoManager = m_pImpl-getUndoManager();
 if ( rUndoManager.IsUndoEnabled() )
-throw NotLockedException( ::rtl::OUString::createFromAscii( Undo manager is not locked ), m_pImpl-getXUndoManager() );
+throw NotLockedException( ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( Undo manager is not locked )), m_pImpl-getXUndoManager() );
 rUndoManager.EnableUndo( true );
 // --- SYNCHRONIZED
 }
diff --git a/framework/source/layoutmanager/helpers.cxx b/framework/source/layoutmanager/helpers.cxx
index a855e04..652cf15 100644
--- a/framework/source/layoutmanager/helpers.cxx
+++ b/framework/source/layoutmanager/helpers.cxx
@@ -381,7 +381,7 @@ void impl_setDockingWindowVisibility( const css::uno::Reference css::lang::XMul
 xDispatcher-executeDispatch(
 xProvider,
 aDockWinCommand,
-::rtl::OUString::createFromAscii(_self),
+::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(_self)),
 0,
 aArgs);
 }
diff --git a/framework/source/lomenubar/FrameHelper.cxx b/framework/source/lomenubar/FrameHelper.cxx
index 7008cb3..8bc9372 100644
--- a/framework/source/lomenubar/FrameHelper.cxx
+++ b/framework/source/lomenubar/FrameHelper.cxx
@@ -131,9 +131,9 @@ item_about_to_show (DbusmenuMenuitem *item, gpointer user_data)
 FrameHelper *helper = (FrameHelper*)user_data;
 Reference  XFrame  xFrame  = helper-getFrame ();
 Reference XPropertySet  frameProps (xFrame, UNO_QUERY);
-Reference  XLayoutManager  xLayoutManager(frameProps-getPropertyValue(OUString::createFromAscii(LayoutManager)),
+Reference  XLayoutManager  xLayoutManager(frameProps-getPropertyValue(OUString(RTL_CONSTASCII_USTRINGPARAM(LayoutManager))),
 UNO_QUERY);
-Reference  XUIElement  menuBar(xLayoutManager-getElement (OUString::createFromAscii(private:resource/menubar/menubar)),
+Reference  XUIElement  menuBar(xLayoutManager-getElement (OUString(RTL_CONSTASCII_USTRINGPARAM(private:resource/menubar/menubar))),
  UNO_QUERY);
 Reference  XPropertySet  menuPropSet (menuBar, UNO_QUERY);
 
@@ -142,7 +142,7 @@ item_about_to_show (DbusmenuMenuitem *item, gpointer user_data)
 return FALSE;
 }
 
-Reference  XMenu  xMenu(menuPropSet-getPropertyValue(OUString::createFromAscii(XMenuBar)),
+Reference  XMenu  xMenu(menuPropSet-getPropertyValue(OUString(RTL_CONSTASCII_USTRINGPARAM(XMenuBar))),
   UNO_QUERY);
 if (!xMenu.is())
 {
@@ -204,14 +204,14 @@ FrameHelper::FrameHelper(const Reference XMultiServiceFactory   rServiceManag
 this-m_server = server;
 
 //Get xUICommands database (to retrieve labels, see FrameJob::getLabelFromCommandURL ())  
-Reference  XNameAccess  xNameAccess (m_xMSF-createInstance(OUString::createFromAscii(com.sun.star.frame.UICommandDescription)),
+Reference  XNameAccess  xNameAccess (m_xMSF-createInstance(OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.frame.UICommandDescription))),
UNO_QUERY);
-m_xMM = Reference  XModuleManager (m_xMSF-createInstance(OUString::createFromAscii(com.sun.star.frame.ModuleManager)),
+m_xMM = Reference  XModuleManager (m_xMSF-createInstance(OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.frame.ModuleManager))),
   

[Libreoffice] Questions about measure units.

[Xisco Faulí]

Hello there,
I've been taking a look to this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=34899 and i've realized that Km
and Miles can be never used because the maximum value is set to 20 cm and
the number of decimals to 2: DecimalDigits = 2 ; So whatever value I use,I
always get 0.00km or 0.00 miles. This problem can be check in draw, Tools -
Options - Libreoffice Impress - General. It also appens in others.
However, in Writer there're only these measure units: mm, cm, Inch, pica,
point.
So I'm wondering whether all the suites should have the same measure units
and if not, What's the point of having km or miles when they always return
0.00.

Grettings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Questions about measure units.

[Xisco Faulí]

Ouch, sorry ! this bug https://bugs.freedesktop.org/show_bug.cgi?id=34396

2011/4/4 Christian Lohmaier lohmaier+libreoff...@googlemail.com

 Hi *,

 On Mon, Apr 4, 2011 at 10:57 PM, Xisco Faulí aniste...@gmail.com wrote:
  Hello there,
  I've been taking a look to this
  bug: https://bugs.freedesktop.org/show_bug.cgi?id=34899

 Is that really the correct number?

  and i've realized
  that Km and Miles can be never used

 Nah, that's wrong - you can use km, but you have to use a scaling
 factor. like 1:25000 then you can easily create drawings in the
 km-scale.

 (how useful it is in other apps - well... :-))

 ciao
 Christan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Questions about measure units.

[Xisco Faulí]

Anyway how do you set the scale ? Drawing scale ? if so, in grid option is
still shown 0.00 km. Besides in Impress doesn't exist such an option.

Greetings

2011/4/5 Xisco Faulí aniste...@gmail.com

 Ouch, sorry ! this bug https://bugs.freedesktop.org/show_bug.cgi?id=34396


 2011/4/4 Christian Lohmaier lohmaier+libreoff...@googlemail.com

 Hi *,

 On Mon, Apr 4, 2011 at 10:57 PM, Xisco Faulí aniste...@gmail.com wrote:
  Hello there,
  I've been taking a look to this
  bug: https://bugs.freedesktop.org/show_bug.cgi?id=34899

 Is that really the correct number?

  and i've realized
  that Km and Miles can be never used

 Nah, that's wrong - you can use km, but you have to use a scaling
 factor. like 1:25000 then you can easily create drawings in the
 km-scale.

 (how useful it is in other apps - well... :-))

 ciao
 Christan



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove obsolete macro

[Xisco Faulí]

Last time It was used was back in 2000.
From a4b55d6390006b032a34cc6a252726d3e35e2dcf Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Mon, 28 Mar 2011 17:03:18 +0200
Subject: [PATCH] Remove unotest macro

---
 basic/source/app/mybasic.cxx |   22 --
 1 files changed, 0 insertions(+), 22 deletions(-)

diff --git a/basic/source/app/mybasic.cxx b/basic/source/app/mybasic.cxx
index adf1322..c26bce8 100755
--- a/basic/source/app/mybasic.cxx
+++ b/basic/source/app/mybasic.cxx
@@ -32,14 +32,6 @@
 #include vcl/msgbox.hxx
 #include basic/sbx.hxx
 
-// AB-Uno-Test
-//#define unotest
-#ifdef unotest
-#include usr/uno.hxx
-#include basic/sbuno.hxx
-#include sbunoobj.hxx
-#endif
-
 #include sbintern.hxx
 
 #include basic/ttstrhlp.hxx
@@ -90,20 +82,6 @@ MyBasic::MyBasic() : StarBASIC()
 p-SetName( CUniString(Objects) );
 Insert( p );
 
-// AB-Uno-Test
-#ifdef unotest
-// Get Uno-Service-Manager and Reflection Service
-createAndSetDefaultServiceManager();		// done later
-
-// Get Uno-Test-Object
-UsrAny aObjAny = getIntrospectionTestObject();
-
-// Box object into SbUnoObject
-String aName( UnoObject );
-SbxObjectRef xSbUnoObj = GetSbUnoObject( aName, aObjAny );
-Insert( (SbxObject*)xSbUnoObj );
-#endif
-
 pTestObject = NULL;
 }
 
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Error building smoketestoo_native

[Xisco Faulí]

Hello,
I'm trying to build this module with valgrind ( export VALGRIND=memcheck )
and I get an error in cpptest.
You can find the debug's output here:
http://dl.dropbox.com/u/1274885/debugoutput
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove DBG_TRACE_BASIC

[Xisco Faulí]

Hi,

This macro is never defined so I delete it.

Bye
From 6281ffb378d83ef0a44e17f7da3de88d8d284c8a Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Fri, 25 Mar 2011 20:44:20 +0100
Subject: [PATCH] Remove DBG_TRACE_BASIC

---
 basic/source/classes/sbxmod.cxx   |4 -
 basic/source/comp/sbcomp.cxx  |  198 -
 basic/source/inc/sbtrace.hxx  |   44 
 basic/source/runtime/methods1.cxx |7 --
 basic/source/runtime/rtlproto.hxx |5 -
 basic/source/runtime/stdobj.cxx   |4 -
 6 files changed, 0 insertions(+), 262 deletions(-)
 delete mode 100755 basic/source/inc/sbtrace.hxx

diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 15c6989..c7c7135 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -1223,10 +1223,6 @@ sal_uInt16 SbModule::Run( SbMethod* pMeth )
 // VBA always ensures screenupdating is enabled after completing
 if ( mbVBACompat )
 VBAUnlockDocuments( PTR_CAST( StarBASIC, GetParent() ) );
-
-#ifdef DBG_TRACE_BASIC
-dbg_DeInitTrace();
-#endif
 }
 }
 else
diff --git a/basic/source/comp/sbcomp.cxx b/basic/source/comp/sbcomp.cxx
index 729ec83..b433acd 100755
--- a/basic/source/comp/sbcomp.cxx
+++ b/basic/source/comp/sbcomp.cxx
@@ -34,204 +34,6 @@
 #include image.hxx
 #include basic/sbobjmod.hxx
 
-// To activate tracing enable in sbtrace.hxx
-#ifdef DBG_TRACE_BASIC
-
-// Trace Settings, used if no ini file / not found in ini file
-static char		GpTraceFileNameDefault[] = d:\\zBasic.Asm\\BasicTrace.txt;
-static char*	GpTraceFileName = GpTraceFileNameDefault;
-
-// GbTraceOn:
-// true = tracing is active, false = tracing is disabled, default = true
-// Set to false initially if you want to activate tracing on demand with
-// TraceCommand( TraceOn ), see below
-static bool	GbTraceOn = true;
-
-// GbIncludePCodes:
-// true = PCodes are written to trace, default = false, correspondents
-// with TraceCommand( PCodeOn / PCodeOff ), see below
-static bool	GbIncludePCodes = false;
-
-static int	GnIndentPerCallLevel = 4;
-static int	GnIndentForPCode = 2;
-
-/*
-With trace enabled the runtime function TraceCommand
-can be used to influence the trace functionality
-from within the running Basic macro.
-
-Format: TraceCommand( command as String [, param as Variant] )
-
-Supported commands (command is NOT case sensitive):
-TraceCommand TraceOn			sets GbTraceOn = true
-TraceCommand TraceOff			sets GbTraceOn = false
-
-TraceCommand PCodeOn			sets GbIncludePCodes = true
-TraceCommand PCodeOff			sets GbIncludePCodes = false
-
-TraceCommand Print, aVal		writes aVal into the trace file as
-long as it can be converted to string
-*/
-
-static void lcl_skipWhites( char* rpc )
-{
-while( *rpc == ' ' || *rpc == '\t' )
-++rpc;
-}
-
-inline void lcl_findNextLine( char* rpc, char* pe )
-{
-// Find line end
-while( rpc  pe  *rpc != 13  *rpc != 10 )
-++rpc;
-
-// Read all
-while( rpc  pe  (*rpc == 13 || *rpc == 10) )
-++rpc;
-}
-
-inline bool lcl_isAlpha( char c )
-{
-bool bRet = (c = 'a'  c = 'z') || (c = 'A'  c = 'Z');
-return bRet;
-}
-
-static void lcl_ReadIniFile( const char* pIniFileName )
-{
-const int BUF_SIZE = 1000;
-static sal_Char TraceFileNameBuffer[BUF_SIZE];
-sal_Char Buffer[BUF_SIZE];
-sal_Char VarNameBuffer[BUF_SIZE];
-sal_Char ValBuffer[BUF_SIZE];
-
-FILE* pFile = fopen( pIniFileName ,rb );
-if( pFile == NULL )
-return;
-
-size_t nRead = fread( Buffer, 1, BUF_SIZE, pFile );
-
-// Scan
-char* pc = Buffer;
-char* pe = Buffer + nRead;
-while( pc  pe )
-{
-lcl_skipWhites( pc ); if( pc == pe ) break;
-
-// Read variable
-char* pVarStart = pc;
-while( pc  pe  lcl_isAlpha( *pc ) )
-++pc;
-int nVarLen = pc - pVarStart;
-if( nVarLen == 0 )
-{
-lcl_findNextLine( pc, pe );
-continue;
-}
-strncpy( VarNameBuffer, pVarStart, nVarLen );
-VarNameBuffer[nVarLen] = '\0';
-
-// Check =
-lcl_skipWhites( pc ); if( pc == pe ) break;
-if( *pc != '=' )
-continue;
-++pc;
-lcl_skipWhites( pc ); if( pc == pe ) break;
-
-// Read value
-char* pValStart = pc;
-while( pc  pe  *pc != 13  *pc != 10 )
-++pc;
-int nValLen = pc - pValStart;
-if( nValLen == 0 )
-{
-lcl_findNextLine( pc, pe );
-continue;
-}
-strncpy( ValBuffer, pValStart, nValLen );
-ValBuffer[nValLen] = '\0';
-
-// Match variables
-if( strcmp( VarNameBuffer, GpTraceFileName) == 0 )
-{
-strcpy( TraceFileNameBuffer, ValBuffer );
-GpTraceFileName = 

Re: [Libreoffice] Error building smoketestoo_native

[Xisco Faulí]

It also fails without valgrind. This time I get:

Backtrace: [42] /home/xisco/libo/solver/300/
unxlngi6.pro/installation/opt/program/soffice.bin: ???+0xda1
Exited with code '-1'
officeconnection.cxx:140:Assertion
Test name: N12_GLOBAL__N_14TestE::test
setUp() failed
- equality assertion failed
- Expected: 2
- Actual  : 0

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0
dmake:  Error code 1, while making 'cpptest'

I attach the output of ./g log --one-1

2011/3/25 Caolán McNamara caol...@redhat.com

 On Fri, 2011-03-25 at 19:06 +0100, Xisco Faulí wrote:
  Hello,
  I'm trying to build this module with valgrind ( export
  VALGRIND=memcheck ) and I get an error in cpptest.

 Without VALGRIND=memcheck do you get an error ? The crucial bit looks
 right at the top with Failed to connect to pipe: and exit -1 so lets
 disentangle a possible smoketest doesn't work for me vs smoketest in
 a debugging build doesn't work for me vs smoketest doesn't work under
 valgrind.

 There was a little bit of fiddling around with the launcher
 script/program over the last few days, which I think should have settled
 down now. Hard to tell what someone is talking about at any given time,
 but the last time I checked under VALGRIND yesterday or so smoketest
 worked fine under valgrind for me  something like ./g log --oneline -1
 might help there.


 C.





log
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] comment unnecessary?

[Xisco Faulí]

yeah, it's right, the code looks as follow:

OSL_ENSURE( aInfo.mpOldBasicPassword,
ImplRepository::impl_createManagerForModel: wrong BasicLibraries
implementation! );
pBasicManager-SetLibraryContainerInfo( aInfo );
//pBasicCont-setBasicManager( pBasicManager );
// that's not needed anymore today. The containers will retrieve
their associated
// BasicManager from the BasicManagerRepository, when needed.

// initialize the containers
impl_initDocLibraryContainers_nothrow( xBasicLibs, xDialogLibs );

So it can be deleted because it refers to //pBasicCont-setBasicManager(
pBasicManager );

2011/3/20 Christina Roßmanith chrrossman...@web.de

 Hi,

 I'm reviewing and applying patches removing commented code. What about the
 following lines from source/basmgr/basicmanagerrepository.cxx?

   //pBasicCont-setBasicManager( pBasicManager );
 // that's not needed anymore today. The containers will
 retrieve their associated
 // BasicManager from the BasicManagerRepository, when needed.


 I have the feeling, that the text-comment belongs to the commented line of
 code above. Is that true? In that case it can be removed as well (I'll do
 that if I get an ok for that).

 Christina
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [WIP] Remove most of dead code in libs-core

[Xisco Faulí]

Here we go with the first round of patches.
Whitespaces are not deleted anymore and all the bogus have been deleted.
Everything builds allright.
Part 1 --
http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz
I'll post the second part soon

Greetings

2011/3/18 Christina Roßmanith chrrossman...@web.de

  Patch 0025 now is already pushed but I'll wait until I see a new version
 on the ML.

 Christina

 Am 18.03.2011 22:01, schrieb Xisco Faulí:

 Well, i'm working on it again, so it would be better to forget this patches
 and wait for the new ones i'm working on.
 I'll let you know asap

 2011/3/18 Christina Roßmanith chrrossman...@web.de

  Hi,

 I've applied patch-0025 locally waiting for a successful build. As
 mentioned earlier whitespace-only changes were skipped. I'd suggest that you
 break patch-0001 into smaller pieces because 1 lines are simply too
 much.

 Christina



 Am 08.03.2011 21:06, schrieb Xisco Faulí:

  Hello,

  I've been working on removing dead code in libs-core for a while ago.
 I'd say libs-core it's now 98-99% dead code free. I built all the modules I
 worked in, and everything is allright.
 I tried to attach the patches into a previous email but it was too big so
 the mailing list refused it. I copy a rar file with 25 patches in my
 dropbox:  http://dl.dropbox.com/u/1274885/remove-dead-code.zip . I swear
 it's 100% virus free.

  Cheers



 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice



 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice



 ___
 LibreOffice mailing 
 listLibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice



 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Doubt about bogus and commented code

[Xisco Faulí]

 // #FIXME this *MUST* be wrong documents::close surely closes ALL documents
// in the collection, use of getCurrentDocument here is totally wrong
-/*
- uno::Reference lang::XMultiComponentFactory  xSMgr(
- mxContext-getServiceManager(), uno::UNO_QUERY_THROW );
- uno::Reference frame::XModel  xModel( getCurrentDocument(),
uno::UNO_QUERY_THROW );
- rtl::OUString url = rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
.uno:CloseDoc));
- dispatchRequests(xModel,url);
-*/


2011/3/17 Jan Holesovsky ke...@suse.cz

 Hi Xisco,

 On 2011-03-12 at 02:25 +0100, Xisco Faulí wrote:

  I've seen quite often something like this:
 
  -/*
  - #i2345#
  - if ( nSlotId = SID_SFX_START  !
  SfxMenuManager::IsPopupFunction(nSlotId) )
  - {
  - // Echte Popups sollen keine SlotIds haben; leider sind
  - // da noch Altlasten mit herumzuschleppen ...
  - String aTitle = pSVMenu-GetItemText( nSlotId );
  - pSVMenu-SetPopupMenu( nSlotId, NULL );
  - USHORT nPos = pSVMenu-GetItemPos( nSlotId );
  - pSVMenu-RemoveItem( nPos );
  - nSlotId = 1;- while ( pSVMenu-GetItemPos(nSlotId) !=
  MENU_ITEM_NOTFOUND ) - nSlotId++; - pSVMenu-InsertItem( nSlotId,
  aTitle, 0, nPos ); - pSVMenu-SetPopupMenu( nSlotId, pPopup ); - } -*/
  What should I do with it ? leave it like that ? delete it completery ?
  or delete the code and leave the bogus ?

 Delete entirely :-)

  Btw, what about the peaces which say, FIXME ?

 Do you have an example, please?

 Regards,
 Kendy



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Doubt about bogus and commented code

[Xisco Faulí]

Hello there,

I've seen quite often something like this:

-/*
- #i2345#
- if ( nSlotId = SID_SFX_START  !SfxMenuManager::IsPopupFunction(nSlotId)
)
- {
- // Echte Popups sollen keine SlotIds haben; leider sind
- // da noch Altlasten mit herumzuschleppen ...
- String aTitle = pSVMenu-GetItemText( nSlotId );
- pSVMenu-SetPopupMenu( nSlotId, NULL );
- USHORT nPos = pSVMenu-GetItemPos( nSlotId );
- pSVMenu-RemoveItem( nPos );
- nSlotId = 1;- while ( pSVMenu-GetItemPos(nSlotId) != MENU_ITEM_NOTFOUND )
- nSlotId++; - pSVMenu-InsertItem( nSlotId, aTitle, 0, nPos ); -
pSVMenu-SetPopupMenu( nSlotId, pPopup ); - } -*/ What should I do with it ?
leave it like that ? delete it completery ? or delete the code and leave the
bogus ?

Btw, what about the peaces which say, FIXME ?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH] Remove most of dead code in libs-core

[Xisco Faulí]

Hello,

I've been working on removing dead code in libs-core for a while ago. I'd
say libs-core it's now 98-99% dead code free. I built all the modules I
worked in, and everything is allright.
I tried to attach the patches into a previous email but it was too big so
the mailing list refused it. I copy a rar file with 25 patches in my
dropbox:  http://dl.dropbox.com/u/1274885/remove-dead-code.zip . I swear
it's 100% virus free.

Cheers
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Revert some changing from last commit

[Xisco Faulí]

Well, I don't know what fails at that moment but i've built it again and
everything is allright.
The patch doesn't need to be applied.

2011/2/27 Xisco Faulí aniste...@gmail.com

 In a previous commit, OSL_ASSERT were changed into OSL_FAIL but 2 of them
 created the build fail.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Revert some changing from last commit

[Xisco Faulí]

In a previous commit, OSL_ASSERT were changed into OSL_FAIL but 2 of them
created the build fail.
From 6a1c81ffb1bfdb5361cf885a89d29b8fcb362e2d Mon Sep 17 00:00:00 2001
From: Xisco Fauli aniste...@gmail.com
Date: Sun, 27 Feb 2011 21:12:58 +0100
Subject: [PATCH] Revert 2 OSL_FAIL

---
 sfx2/source/doc/guisaveas.cxx |2 +-
 sfx2/source/doc/objstor.cxx   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sfx2/source/doc/guisaveas.cxx b/sfx2/source/doc/guisaveas.cxx
index 940e3e9..aa68646 100644
--- a/sfx2/source/doc/guisaveas.cxx
+++ b/sfx2/source/doc/guisaveas.cxx
@@ -230,7 +230,7 @@ public:
 }
 catch( uno::Exception )
 {
-OSL_FAIL( Unexpected exception! );
+OSL_ASSERT( Unexpected exception! );
 }
 }
 }
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index e6cb611..eb45ce0 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -1605,7 +1605,7 @@ sal_Bool SfxObjectShell::SaveTo_Impl
 {
 // it should not happen, the copies signature is invalid!
 // throw the changes away
-OSL_FAIL( An invalid signature was copied! );
+OSL_ASSERT( An invalid signature was copied! );
 }
 }
 }
-- 
1.7.1

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fix cppcheck errors and warnings

[Xisco Faulí]

Some non-compiladed code have been deleted as well.

Grettings
From 04b66c4fc3bfdf6a95d3933a813868c1e28cf195 Mon Sep 17 00:00:00 2001
From: Xisco xisco@Xisco-PC.(none)
Date: Sun, 6 Feb 2011 21:33:22 +0100
Subject: [PATCH] fix cppcheck errors and warnings

---
 i18npool/source/localedata/localedata.cxx |   77 ++---
 1 files changed, 27 insertions(+), 50 deletions(-)

diff --git a/i18npool/source/localedata/localedata.cxx b/i18npool/source/localedata/localedata.cxx
index 7c488b0..1b4f09a 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -287,12 +287,12 @@ LocaleData::~LocaleData()
 LocaleDataItem SAL_CALL
 LocaleData::getLocaleItem( const Locale rLocale ) throw(RuntimeException)
 {
-sal_Int16 dataItemCount = 0;
 sal_Unicode **dataItem = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getLocaleItem );
 
 if ( func ) {
+sal_Int16 dataItemCount = 0;
 dataItem = func(dataItemCount);
 
 LocaleDataItem item(
@@ -499,12 +499,12 @@ Sequence Calendar  SAL_CALL
 LocaleData::getAllCalendars( const Locale rLocale ) throw(RuntimeException)
 {
 
-sal_Int16 calendarsCount = 0;
 sal_Unicode **allCalendars = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getAllCalendars );
 
 if ( func ) {
+sal_Int16 calendarsCount = 0;
 allCalendars = func(calendarsCount);
 
 Sequence Calendar  calendarsSeq(calendarsCount);
@@ -571,13 +571,12 @@ LocaleData::getAllCalendars( const Locale rLocale ) throw(RuntimeException)
 Sequence Currency2  SAL_CALL
 LocaleData::getAllCurrencies2( const Locale rLocale ) throw(RuntimeException)
 {
-
-sal_Int16 currencyCount = 0;
 sal_Unicode **allCurrencies = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getAllCurrencies );
 
 if ( func ) {
+sal_Int16 currencyCount = 0;
 allCurrencies = func(currencyCount);
 
 Sequence Currency2  seq(currencyCount);
@@ -673,7 +672,7 @@ LocaleData::getAllFormats( const Locale rLocale ) throw(RuntimeException)
 formatArray = func( formatCount, from, to);
 return formatCount;
 }
-} section[SECTIONS];
+} section[SECTIONS] = NULL;
 
 sal_Int32 formatCount  = section[0].getFunc( *this, rLocale, getAllFormats0);
   formatCount += section[1].getFunc( *this, rLocale, getAllFormats1);
@@ -725,12 +724,12 @@ LocaleData::getCollatorRuleByAlgorithm( const Locale rLocale, const OUString a
 Sequence Implementation  SAL_CALL
 LocaleData::getCollatorImplementations( const Locale rLocale ) throw(RuntimeException)
 {
-sal_Int16 collatorCount = 0;
 sal_Unicode **collatorArray = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getCollatorImplementation );
 
 if ( func ) {
+sal_Int16 collatorCount = 0;
 collatorArray = func(collatorCount);
 Sequence Implementation  seq(collatorCount);
 for(sal_Int16 i = 0; i  collatorCount; i++) {
@@ -750,12 +749,12 @@ LocaleData::getCollatorImplementations( const Locale rLocale ) throw(RuntimeExc
 Sequence OUString  SAL_CALL
 LocaleData::getCollationOptions( const Locale rLocale ) throw(RuntimeException)
 {
-sal_Int16 optionsCount = 0;
 sal_Unicode **optionsArray = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getCollationOptions );
 
 if ( func ) {
+sal_Int16 optionsCount = 0;
 optionsArray = func(optionsCount);
 Sequence OUString  seq(optionsCount);
 for(sal_Int16 i = 0; i  optionsCount; i++) {
@@ -772,12 +771,12 @@ LocaleData::getCollationOptions( const Locale rLocale ) throw(RuntimeException)
 Sequence OUString  SAL_CALL
 LocaleData::getSearchOptions( const Locale rLocale ) throw(RuntimeException)
 {
-sal_Int16 optionsCount = 0;
 sal_Unicode **optionsArray = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getSearchOptions );
 
 if ( func ) {
+sal_Int16 optionsCount = 0;
 optionsArray = func(optionsCount);
 Sequence OUString  seq(optionsCount);
 for(sal_Int16 i = 0; i  optionsCount; i++) {
@@ -888,12 +887,12 @@ LocaleData::getIndexModuleByAlgorithm( const Locale rLocale, const OUString al
 Sequence UnicodeScript  SAL_CALL
 LocaleData::getUnicodeScripts( const Locale rLocale ) throw(RuntimeException)
 {
-sal_Int16 scriptCount = 0;
 sal_Unicode **scriptArray = NULL;
 
 MyFunc_Type func = (MyFunc_Type) getFunctionSymbol( rLocale, getUnicodeScripts );
 
 if ( func ) {
+sal_Int16 scriptCount = 0;
 scriptArray = func(scriptCount);
 Sequence UnicodeScript  seq(scriptCount);