Re: About coverity 441020 (templdlg.cxx in sfx2)
Salut Julien, On Sat, 2013-03-30 at 12:23 -0700, julien2412 [via Document Foundation Mail Archive] wrote: So I pushed a patch here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=cab7f6476f7d0f17bf2f1400bf93fb1b7fbd1625 - StartListening(*pOldStyleSheetPool); + StartListening(*pStyleSheetPool); If it's ok, could it be interesting to cherry-pick it into 4.0 branch? (I don't have 4.0 sources, only master) I just pushed it to libreoffice-4-0 branch, thanks a lot for drawing my attention to this patch. -- Cedric -- View this message in context: http://nabble.documentfoundation.org/About-coverity-441020-templdlg-cxx-in-sfx2-tp4047124p4047478.html Sent from the Dev mailing list archive at Nabble.com.___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly
Hello, Please accept my apologies for not being responsive in patch reviewing these days. ya...@mknada.sakura.ne.jp wrote: This patch will solve the problem that a thin line is drawn instead dotted and dashed line. In addition, to solve the problem when drawing thick dotted and dashed lines. Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=37129 My patch is being submitted under LGPLv3+/MPL. You're patch is nice, many thanks for it! I pushed it to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c2902ecbf135fae070ea032fa10a59bb76ec1b0 Feel free to continue providing good patches like this one :D Regards, -- Cedric -- View this message in context: http://nabble.documentfoundation.org/PATCH-fix-for-fdo-37129-Dotted-and-Dashed-table-borders-are-not-drawn-correctly-tp3406649p3437131.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick in 3.4.2?
Caolán McNamara wrote: On Thu, 2011-08-11 at 15:36 +0200, Cedric Bosdonnat wrote: I fixed fdo#37403 a while ago, and Rainer asked if we could cherry-pick http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=21ec661d09ed9d7bbbec5e52ee2b382d8c465324 to 3.4.2. Forgot all about that one. Don't you end up with one single mpXPoly polygon shared between two different SdrRectObj so changes to the held polygon in one SdrRectObj is seen in the other ? i.e. should give SdrRectObj a proper copy ctor/assignment operator instead/additionally rather than using the compiler generated one, which is presumably why two SdrRects ended up holding the same raw mpXPoly in the first place. Indeed that remembers me of a discussion like that with Lubos... though I'm not good enough in C++ to see those subtleties. I reverted the above mentioned patch and replaced it by http://cgit.freedesktop.org/libreoffice/core/commit/?id=c3852d41a419331277d0b98b02792f0bbf704d5b All is now working fine, and that later commit could be applied to 3.4 safely. Thanks for the reminder -- Cedric -- View this message in context: http://nabble.documentfoundation.org/REVIEW-Cherry-pick-in-3-4-2-tp3245931p3258528.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] fix for fdo#37771
Caolán McNamara wrote: On Thu, 2011-06-16 at 18:39 +0200, Andras Timar wrote: Hi, Writer requires a password with random number characters. Instead of fixing the code in Writer (SfxPasswordDialog::SetMinLen was not called somewhere) I set a default minimum password length in constructor of the dialog. Please review it for 3-4 and 3-4-1. http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=6ab5952f6d952e5f96428b631e91a208ea21d4aa Looks sane, +1, one more needed for 3.4.1. Looks sane to me too. -- View this message in context: http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37771-tp3072743p3075345.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
