Re: [Libreoffice] Do we still need to support non-XKB X11 systems ?
Hi Michael, On Fri, Jul 08, 2011 at 09:40:44AM +0100, Michael Meeks wrote: > On Fri, 2011-07-08 at 08:10 +0200, Francois Tigeot wrote: > > > #if defined(LINUX) || defined(FREEBSD) || defined(MACOSX) || > > defined(NETBSD) || \ > > defined(OPENBSD) || defined(DRAGONFLY) > > #define __XKeyboardExtension__ 1 > > So - reading the above it really looks like an: > > #ifndef defined(SOLARIS) And also AIX, even though not many people may try to run X applications on it these days... > which is somewhat odd, since it should have XKB too. :-) > Lets kill that :-) Done in master. Cheers ! -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Do we still need to support non-XKB X11 systems ?
Hi Francois, On Fri, 2011-07-08 at 08:10 +0200, Francois Tigeot wrote: > The file libs-gui/tools/inc/tools/prex.h tries to detect the presence of > the X11 keyboard extension (XKB) in a completely bogus way - by hardcoding > a value depending on the operating system it is build for: Lol ;-) > // FIXME: should really check for xfree86 or for X11R6.1 and higher > #if defined(LINUX) || defined(FREEBSD) || defined(MACOSX) || > defined(NETBSD) || \ > defined(OPENBSD) || defined(DRAGONFLY) > #define __XKeyboardExtension__ 1 So - reading the above it really looks like an: #ifndef defined(SOLARIS) which is somewhat odd, since it should have XKB too. > Now, I could try to use something less brain damaged to detect the presence > of the XKB extension but it has been part of X since X11R6.1 which has been > released in March 1996 ... Lets kill that :-) ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Do we still need to support non-XKB X11 systems ?
Hi, The file libs-gui/tools/inc/tools/prex.h tries to detect the presence of the X11 keyboard extension (XKB) in a completely bogus way - by hardcoding a value depending on the operating system it is build for: // FIXME: should really check for xfree86 or for X11R6.1 and higher #if defined(LINUX) || defined(FREEBSD) || defined(MACOSX) || defined(NETBSD) || \ defined(OPENBSD) || defined(DRAGONFLY) #define __XKeyboardExtension__ 1 #else #define __XKeyboardExtension__ 0 #endif It has been done that way since this file was created. Now, I could try to use something less brain damaged to detect the presence of the XKB extension but it has been part of X since X11R6.1 which has been released in March 1996 ... Would anybody object if I remove the test and consider XKB present on all X11 systems ? -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
