[Libreoffice-commits] core.git: canvas/source canvas/workben chart2/qa chart2/source
canvas/source/opengl/ogl_spritedevicehelper.cxx |4 -
canvas/source/simplecanvas/simplecanvasimpl.cxx |5 -
canvas/source/vcl/devicehelper.cxx |2
canvas/workben/canvasdemo.cxx | 18
+
chart2/qa/extras/chart2dump/chart2dump.cxx |7 -
chart2/qa/extras/chart2import.cxx | 11 +--
chart2/source/controller/accessibility/AccessibleBase.cxx |6 -
chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx |6 -
chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx | 24
+++---
chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx |4 -
chart2/source/controller/chartapiwrapper/LegendWrapper.cxx |4 -
chart2/source/controller/chartapiwrapper/TitleWrapper.cxx |6 -
chart2/source/controller/dialogs/ChartTypeDialogController.cxx |8 --
chart2/source/controller/dialogs/DataBrowserModel.cxx |8 +-
chart2/source/controller/dialogs/DialogModel.cxx| 13 +--
chart2/source/controller/dialogs/ObjectNameProvider.cxx | 16 ++--
chart2/source/controller/dialogs/RangeSelectionHelper.cxx |4 -
chart2/source/controller/dialogs/tp_ChartType.cxx |5 -
chart2/source/controller/drawinglayer/ViewElementListProvider.cxx |3
chart2/source/controller/main/ChartController.cxx |9 --
chart2/source/controller/main/ChartController_Insert.cxx| 36
+-
chart2/source/controller/main/ChartController_Properties.cxx|2
chart2/source/controller/main/ChartController_Tools.cxx |2
chart2/source/controller/main/ControllerCommandDispatch.cxx |4 -
chart2/source/controller/main/StatusBarCommandDispatch.cxx |5 -
chart2/source/controller/sidebar/ChartAxisPanel.cxx |8 +-
chart2/source/controller/sidebar/ChartSeriesPanel.cxx | 24
+++---
chart2/source/model/filter/XMLFilter.cxx|7 -
chart2/source/model/main/ChartModel.cxx |2
chart2/source/tools/AxisHelper.cxx |2
chart2/source/tools/DiagramHelper.cxx | 14 +--
chart2/source/tools/InternalDataProvider.cxx|2
chart2/source/tools/OPropertySet.cxx|3
chart2/source/tools/ObjectIdentifier.cxx|4 -
chart2/source/tools/ReferenceSizeProvider.cxx |4 -
chart2/source/tools/TitleHelper.cxx |2
chart2/source/view/main/ShapeFactory.cxx|7 -
37 files changed, 132 insertions(+), 159 deletions(-)
New commits:
commit 836c40904f4424a5b7ae708171a7aab53141761a
Author: Noel Grandin
AuthorDate: Fri Jul 19 09:50:11 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Jul 19 11:31:51 2019 +0200
loplugin:referencecasting in canvas..chart2
Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc
Reviewed-on: https://gerrit.libreoffice.org/75935
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx
b/canvas/source/opengl/ogl_spritedevicehelper.cxx
index 304414bfeea1..285afa973574 100644
--- a/canvas/source/opengl/ogl_spritedevicehelper.cxx
+++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx
@@ -361,9 +361,7 @@ namespace oglcanvas
uno::Reference SpriteDeviceHelper::getColorSpace()
const
{
// always the same
-return uno::Reference(
-::canvas::tools::getStdColorSpace(),
-uno::UNO_QUERY);
+return ::canvas::tools::getStdColorSpace();
}
void SpriteDeviceHelper::notifySizeUpdate( const awt::Rectangle& rBounds )
diff --git a/canvas/source/simplecanvas/simplecanvasimpl.cxx
b/canvas/source/simplecanvas/simplecanvasimpl.cxx
index 9e209b5cf3e5..724e4dbb5372 100644
--- a/canvas/source/simplecanvas/simplecanvasimpl.cxx
+++ b/canvas/source/simplecanvas/simplecanvasimpl.cxx
@@ -72,9 +72,8 @@ namespace
uno::Sequence< uno::Sequence< geometry::RealPoint2D > >
sequenceSequence( 1 );
sequenceSequence[0] = rectSequence;
-uno::Reference< rendering::XPolyPolygon2D > xRes(
-xDevice->createCompatibleLinePolyPolygon( sequenceSequence ),
-uno::UNO_QUERY );
+uno::Reference< rendering::XPolyPolygon2D > xRes =
+xDevice->createCompatibleLinePolyPolygon( sequenceSequence );
if( xRes.is() )
xRes->setClosed( 0, true );
return xRes;
diff --git a/canvas/source/vcl/devicehelper.cxx
b/canvas/source/vcl/devicehelper.cxx
index d5961df2b777..904b565af80e 100644
---
[Libreoffice-commits] core.git: canvas/source canvas/workben chart2/qa chart2/source
canvas/source/cairo/cairo_spritecanvashelper.cxx |3 +-
canvas/source/tools/spriteredrawmanager.cxx |3 +-
canvas/workben/canvasdemo.cxx|2 -
chart2/qa/extras/charttest.hxx |2 -
chart2/source/controller/dialogs/tp_AxisLabel.cxx|2 -
chart2/source/controller/main/ChartController_Properties.cxx |4 +--
chart2/source/controller/main/ControllerCommandDispatch.cxx |6 ++---
chart2/source/controller/main/ShapeController.cxx|2 -
chart2/source/model/main/DataSeriesProperties.cxx|2 -
chart2/source/model/main/Diagram.cxx | 12 +--
chart2/source/model/main/PageBackground.cxx |2 -
chart2/source/tools/ChartTypeHelper.cxx |4 +--
chart2/source/tools/DiagramHelper.cxx|2 -
chart2/source/tools/LinePropertiesHelper.cxx |2 -
chart2/source/tools/PotentialRegressionCurveCalculator.cxx | 10 -
chart2/source/view/main/ShapeFactory.cxx |2 -
16 files changed, 31 insertions(+), 29 deletions(-)
New commits:
commit 21b224211c998e756a7eb03de30d0737e07b2350
Author: Noel Grandin
AuthorDate: Fri Feb 8 09:29:48 2019 +0200
Commit: Noel Grandin
CommitDate: Fri Feb 8 10:01:20 2019 +0100
loplugin:indentation in canvas..chart2
Change-Id: I9ef57a2e9aaf298f4cfd029aa9b8143871b1bc21
Reviewed-on: https://gerrit.libreoffice.org/67526
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/source/cairo/cairo_spritecanvashelper.cxx
b/canvas/source/cairo/cairo_spritecanvashelper.cxx
index 149643d432cc..b964db61eed9 100644
--- a/canvas/source/cairo/cairo_spritecanvashelper.cxx
+++ b/canvas/source/cairo/cairo_spritecanvashelper.cxx
@@ -337,7 +337,8 @@ namespace cairocanvas
const
::canvas::SpriteRedrawManager::SpriteConnectedRanges::ComponentListType::const_iterator
aFirst( rUpdateArea.maComponentList.begin() );
::canvas::SpriteRedrawManager::SpriteConnectedRanges::ComponentListType::const_iterator
- aSecond( aFirst ); ++aSecond;
+ aSecond( aFirst );
+++aSecond;
ENSURE_OR_THROW( aFirst->second.getSprite().is(),
"VCLCanvas::scrollUpdate(): no sprite" );
diff --git a/canvas/source/tools/spriteredrawmanager.cxx
b/canvas/source/tools/spriteredrawmanager.cxx
index f24ef41caf53..b414b8a7ac01 100644
--- a/canvas/source/tools/spriteredrawmanager.cxx
+++ b/canvas/source/tools/spriteredrawmanager.cxx
@@ -335,7 +335,8 @@ namespace canvas
const SpriteConnectedRanges::ComponentListType::const_iterator aFirst(
rUpdateArea.maComponentList.begin() );
SpriteConnectedRanges::ComponentListType::const_iterator aSecond(
-aFirst ); ++aSecond;
+aFirst );
+++aSecond;
if( !aFirst->second.isPureMove() ||
!aSecond->second.isPureMove() ||
diff --git a/canvas/workben/canvasdemo.cxx b/canvas/workben/canvasdemo.cxx
index e144c67b0047..bfb9f400ab28 100644
--- a/canvas/workben/canvasdemo.cxx
+++ b/canvas/workben/canvasdemo.cxx
@@ -123,7 +123,7 @@ class DemoRenderer
0, 1 );
rendering::FontRequest aFontRequest( aFontInfo, 12.0, 0.0, aLocale
);
uno::Sequence< beans::PropertyValue > aExtraFontProperties;
- mxDefaultFont = xCanvas->createFont( aFontRequest,
aExtraFontProperties, aFontMatrix );
+mxDefaultFont = xCanvas->createFont( aFontRequest,
aExtraFontProperties, aFontMatrix );
if( !mxDefaultFont.is() )
fprintf( stderr, "Failed to create font\n" );
}
diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx
index 84d74de2c117..2141ff8a828d 100644
--- a/chart2/qa/extras/charttest.hxx
+++ b/chart2/qa/extras/charttest.hxx
@@ -593,7 +593,7 @@ awt::Size ChartTest::getPageSize( const Reference<
chart2::XChartDocument > & xC
uno::Reference< com::sun::star::embed::XVisualObject > xVisualObject(
xChartDoc, uno::UNO_QUERY );
CPPUNIT_ASSERT( xVisualObject.is() );
aSize = xVisualObject->getVisualAreaSize(
com::sun::star::embed::Aspects::MSOLE_CONTENT );
-return aSize;
+return aSize;
}
awt::Size ChartTest::getSize(css::uno::Reference xDiagram,
const awt::Size& rPageSize)
diff --git a/chart2/source/controller/dialogs/tp_AxisLabel.cxx
b/chart2/source/controller/dialogs/tp_AxisLabel.cxx
index 46e277159bdb..36062526cdd4 100644
--- a/chart2/source/controller/dialogs/tp_AxisLabel.cxx
+++ b/chart2/source/controller/dialogs/tp_AxisLabel.cxx
@@ -136,7 +136,7 @@ bool SchAxisLabelTabPage::FillItemSet( SfxItemSet*
rOutAttrs )
void SchAxisLabelTabPage::Reset( const SfxItemSet* rInAttrs )
{
- const SfxPoolItem* pPoolItem =
