Re: Add AdjustX method to basegfx::B2DPoint

2019-04-08 Thread Alexander Farrow
Hi Noel, Noel Grandin wrote: >Are we going to be doing this behind the >   VCL_FLOAT_DEVICE_PIXEL >define and using the DeviceCoordinate typedef ? I'm assuming your referring to my recent patch: https://gerrit.libreoffice.org/#/c/70329/ That's a good

Re: Add AdjustX method to basegfx::B2DPoint

2019-04-08 Thread Alexander Farrow
Hi Thorsten, Thanks for your reply. Thorsten Behrens wrote: >tools::Point is not exactly a role model for a nicely designed class, >so I'd hesitate to take any literal bits out of that. ;) Good to know, I'm new to the codebase so I'll keep that in mind. >Many places using AdjustX() also call

Re: Add AdjustX method to basegfx::B2DPoint

2019-04-06 Thread Noel Grandin
Are we going to be doing this behind the VCL_FLOAT_DEVICE_PIXEL define and using the DeviceCoordinate typedef ? I have no skin in the game either way, just making sure we don't end up with overlapping functionality. (as a side note I had no idea we had this enabled on mac and ios already)

Re: Add AdjustX method to basegfx::B2DPoint

2019-04-05 Thread Thorsten Behrens
Hi Alex, Alexander Farrow wrote: > basegfx::B2DPoint > > does not have such a method. So calls to AdjustX(nHorzMove) are > being replaced by something like setX(getX() + nHorzMove). > tools::Point is not exactly a role

Add AdjustX method to basegfx::B2DPoint

2019-04-05 Thread Alexander Farrow
Hi everybody, Recently for GSoC I have been looking into resolving "Use floating point for glyph positioning in VCL" This involves changing the types of variables from tools::Point to basegfx::B2DPoint. tools::Point