[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Vasily Melenchuk vasily.melenc...@cib.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||449 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Vasily Melenchuk vasily.melenc...@cib.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #12 from Jean-Baptiste Faure jbfa...@libreoffice.org --- (In reply to Commit Notification from comment #10) Vasily Melenchuk committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/ ?id=4327b7882c38005d89b07e76814705d1c53f3161h=libreoffice-4-4 tdf#76291 write encoded URL as href in html output This commit seems to make failing the build of LO 4.4.1.0.0+ : [build CUT] sw_htmlimport File tested,Execution Time (ms) HTML parser error : Opening and ending tag mismatch: a and font ce=SimSunfont size=2 style=font-size: 10ptspan lang=zh-CN粵語/a ^ HTML parser error : Opening and ending tag mismatch: a and font ce=SimSunfont size=2 style=font-size: 10ptspan lang=zh-CN粵語/a ^ HTML parser error : Unexpected end tag : span Sunfont size=2 style=font-size: 10ptspan lang=zh-CN粵語/a/span ^ HTML parser error : Unexpected end tag : font ont size=2 style=font-size: 10ptspan lang=zh-CN粵語/a/span/font ^ HTML parser error : Unexpected end tag : font e=2 style=font-size: 10ptspan lang=zh-CN粵語/a/span/font/font ^ tdf76291.odt,/home/[..]/lo44/test/source/xmltesttools.cxx:53:testExportUrlEncoding::Import_Export equality assertion failed - Expected: 1 - Actual : 2 - In file:///home/[..]/tmp/luup6jlk.tmp, XPath '/html/body/p/a' number of nodes is incorrect File tested,Execution Time (ms) checkbox-radiobutton.doc,346 File tested,Execution Time (ms) HTMLImage.odt,199 File tested,Execution Time (ms) skipimage-embedded-document.docx,315 File tested,Execution Time (ms) skipimage-embedded.doc,382 File tested,Execution Time (ms) textAndImage.docx,171 File tested,Execution Time (ms) textAndImage.docx,86 File tested,Execution Time (ms) charborder.odt,94 File tested,Execution Time (ms) charborder.odt,232 File tested,Execution Time (ms) fdo86857.html,43 File tested,Execution Time (ms) fdo86857.html,134 File tested,Execution Time (ms) fdo62336.docx,336 File tested,Execution Time (ms) fdo81276.html,17 File tested,Execution Time (ms) fdo81276.html,93 xmltesttools.cxx:53:Assertion Test name: testExportUrlEncoding::Import_Export equality assertion failed - Expected: 1 - Actual : 2 - In file:///home/[..]/tmp/luup6jlk.tmp, XPath '/html/body/p/a' number of nodes is incorrect Failures !!! Run: 15 Failure total: 1 Failures: 1 Errors: 0 Error: a unit test failed, please do one of: export DEBUGCPPUNIT=TRUE# for exception catching export CPPUNITTRACE=gdb --args# for interactive debugging on Linux export CPPUNITTRACE=\[full path to devenv.exe]\ /debugexe # for interactive debugging in Visual Studio export VALGRIND=memcheck# for memory checking and retry using: make CppunitTest_sw_htmlexport /home/[..]/lo44/solenv/gbuild/CppunitTest.mk:81: recipe for target '/home/[..]/lo44/workdir/CppunitTest/sw_htmlexport.test' failed make[1]: *** [/home/[..]/lo44/workdir/CppunitTest/sw_htmlexport.test] Error 1 make[1]: *** Attente des tâches non terminées Makefile:237: recipe for target 'build' failed make: *** [build] Error 2 It was an incremental build. Is it useful to retry with a complete rebuild ? Best regards. JBF -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 --- Comment #13 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Andras Timar committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=72812676b419b8d5fa32d06e5c45af73d08eac59h=libreoffice-4-4 tdf#76291 adapt unit test to libreoffice-4-4 It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vasily Melenchuk committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=675e1fe198298702ced8eab02a7df5164d66a8f0 tdf#76291 unit test for html export href encoding It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 --- Comment #11 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vasily Melenchuk committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=fafd6cd4f784e5b65548af699bc25502f10a4b8dh=libreoffice-4-4 tdf#76291 unit test for html export href encoding It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 --- Comment #10 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vasily Melenchuk committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4327b7882c38005d89b07e76814705d1c53f3161h=libreoffice-4-4 tdf#76291 write encoded URL as href in html output It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA EasyHack SkillCpp |BSA EasyHack SkillCpp |target:4.5.0|target:4.5.0 target:4.4.1 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vasily Melenchuk committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0706b5756e06b7773a78e3046a47efc2c81d92b1 tdf#76291 write encoded URL as href in html output It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA EasyHack SkillCpp |BSA EasyHack SkillCpp ||target:4.5.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||sberg...@redhat.com --- Comment #7 from Stephan Bergmann sberg...@redhat.com --- (In reply to Kevin Suo from comment #4) The link changed to http://www.youtube.com/results?search_query=粵語mvamp;sm=12 LO internally converts a URI entered into the Hyperlink dialog into an IRI (cf. http://cgit.freedesktop.org/libreoffice/core/commit/?id=abb5e84c74b781f3615862695db4e5eaadc12cfe Do not corrupt URIs entered into the Hyperlink dialog). It is written out as an IRI at least into ODT documents (and XLink allows for IRIs, so that appears to be OK). But at least the HTML 4.01 spec appears to only allow for URIs, not IRIs, in a href= So it's probably good to explicitly convert from IRI to URI upon exporting at least to HTML (as proposed in https://gerrit.libreoffice.org/#/c/14223), short of revisiting the decision to store as IRI rather than URI internally in LO. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Vasily Melenchuk vasily.melenc...@cib.de changed: What|Removed |Added CC||vasily.melenc...@cib.de --- Comment #6 from Vasily Melenchuk vasily.melenc...@cib.de --- (In reply to Eric Wang from comment #2) I'm going to try to take on this one for my first hack. I'll drop it in the next few days if it turns out too much to handle. No activity on this task for a long time. I'll try to resolve it. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.documentfoundation.org/show_bug.cgi?id=76291 Vasily Melenchuk vasily.melenc...@cib.de changed: What|Removed |Added Assignee|eric.w0lo...@gmail.com |vasily.melenc...@cib.de -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.freedesktop.org/show_bug.cgi?id=76291 --- Comment #5 from Björn Michaelsen bjoern.michael...@canonical.com --- adding LibreOffice developer list as CC to unresolved Writer EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.freedesktop.org/show_bug.cgi?id=76291 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Blocks||83066 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.freedesktop.org/show_bug.cgi?id=76291 Kevin Suo suokunl...@gmail.com changed: What|Removed |Added CC||suokunl...@gmail.com --- Comment #4 from Kevin Suo suokunl...@gmail.com --- (In reply to comment #0) 2. Insert a hyperlink containing: http://www.youtube.com/results?search_query=%E7%B2%B5%E8%AA%9Emvsm=12; Just for info: On Fedora 20, libreoffice 4.3.0.2, When I insert a link with the following and save as HTML: http://www.youtube.com/results?search_query=%E7%B2%B5%E8%AA%9Emvsm=12; The link changed to http://www.youtube.com/results?search_query=粵語mvamp;sm=12 (i.e, Only the char is changed to amp;. it's becoming better?) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.freedesktop.org/show_bug.cgi?id=76291 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added CC||libreoffice@lists.freedeskt ||op.org --- Comment #3 from Björn Michaelsen bjoern.michael...@canonical.com --- adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.freedesktop.org/show_bug.cgi?id=76291 Eric Wang eric.w0lo...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |eric.w0lo...@gmail.com |desktop.org | --- Comment #2 from Eric Wang eric.w0lo...@gmail.com --- I'm going to try to take on this one for my first hack. I'll drop it in the next few days if it turns out too much to handle. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76291] FILESAVE: Chinese hyperlinks modified upon Saving
https://bugs.freedesktop.org/show_bug.cgi?id=76291 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Whiteboard|BSA |BSA EasyHack SkillCpp Ever confirmed|0 |1 --- Comment #1 from Andras Timar tima...@gmail.com --- This is an Easy Hack. see SwHTMLWriter::OutHyperlinkHRefValue() in sw/source/filter/html/wrthtml.cxx see HTML URL Encoding reference at: http://www.w3schools.com/tags/ref_urlencode.asp see also http://tools.ietf.org/html/rfc3986 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
