Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-30 Thread Thorsten Behrens
Marco wrote: > Ok sorry, I have no knowledge of software legal issues. > So should I remove such a change ? > Yes please. > Yep, I was thinking of that by a while, what stopped me from > deploying such a solution is: - it is not clear to me how to get > the python script executed automatically (m

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-30 Thread Marco
On Tue, 30 Aug 2011 09:36:00 +0200, Thorsten Behrens wrote: Marco wrote: skip Well, I understand this one and your other comments, but I think you should take into account that all the script is embedded into the svg document. If a user incurs into a problem with the animation engine a

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-30 Thread Thorsten Behrens
Marco wrote: > When I go to switch to OneGit which patches of mine will I find > already merged ? > Yes, except for the 0019- one. Let's rework that to have svgscript.hxx auto-generated there. Cheers, -- Thorsten pgpfEEYWFV6JL.pgp Description: PGP signature

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-30 Thread Thorsten Behrens
Marco wrote: > >Since all patches from your tarbomb except > >0019-Fixed-a-bug-in-the-JavaScript-animation-engi-filters.patch are > >pushed, > > Do you mean pushed on OneGit master branch ? > Yep :) > Well, I understand this one and your other comments, but I think you should > take into account

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-30 Thread Thorsten Behrens
Kohei Yoshida wrote: > > I'm planning to switch to OneGit, anyway I'm not sure where my patches > > have been pushed at present. > > I see several commits under your name in the svg-export branch: > > http://cgit.freedesktop.org/libreoffice/core/log/?h=svg-export > > Perhaps this is where Thorst

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-29 Thread Kohei Yoshida
On Mon, 2011-08-29 at 21:34 +0200, Marco wrote: > I'm planning to switch to OneGit, anyway I'm not sure where my patches > have been pushed at present. I see several commits under your name in the svg-export branch: http://cgit.freedesktop.org/libreoffice/core/log/?h=svg-export Perhaps this is

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-29 Thread Marco
On Mon, 29 Aug 2011 10:04:34 +0200, Tor Lillqvist wrote: I attached a new patch set based on the master branch, as it was on Monday July 7, Hmm, I am afraid that is a quite long time ago, and the all-over whitespace cleanup done when we did the OneGit conversion overlaps a lot with the

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-29 Thread Marco
On Mon, 29 Aug 2011 10:04:55 +0200, Thorsten Behrens wrote: Marco wrote: skip I attached a new patch set based on the master branch, as it was on Monday July 7, that includes a bug fix: in my haste I missed to make animations on the starting slide work properly. Since all patches from y

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-29 Thread Thorsten Behrens
Marco wrote: > It seems that I have passed the final evaluation!! :) > Indeed - congrats, well done! :) > I attached a new patch set based on the master branch, as it was on > Monday July 7, that includes a bug fix: in my haste I missed to > make animations on the starting slide work properly. >

Re: [Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

2011-08-29 Thread Tor Lillqvist
> I attached a new patch set based on the master branch, as it was on > Monday July 7, Hmm, I am afraid that is a quite long time ago, and the all-over whitespace cleanup done when we did the OneGit conversion overlaps a lot with the whitespace fixes in your patches, for instance. Do you think