Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source WaE: fix misc. SvStream operator problems.
Le 19/01/2012 23:51, Stephan Bergmann a écrit : Hi Stephan, On 01/19/2012 11:19 PM, Alex Thurgood wrote: In file included from /home/alex/LODEV/core/tools/source/stream/strmsys.cxx:33:0: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx: In static member function ‘static sal_Bool InternalStreamLock::LockFile(sal_Size, sal_Size, SvFileStream*)’: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx:149:19: erreur: ‘class osl::DirectoryItem’ has no member named ‘isIdenticalTo’ Sounds like recent tml/mmeeks changes? Sorry about that, have posted a separate thread now for this. Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source WaE: fix misc. SvStream operator problems.
On Thu, 2012-01-19 at 11:10 +0100, Stephan Bergmann wrote: --- a/connectivity/source/drivers/dbase/DTable.cxx ... (*m_pFileStream) cTyp; if ( nDbaseType == VisualFoxPro ) -(*m_pFileStream) (nRecLength-1); +(*m_pFileStream) sal_uInt16(nRecLength-1); This would previously have been written as four bytes. Are you sure that writing it as two bytes is what is wanted? Oh - I didn't want to change anything, beyond fixing the compilation bug. nRecLength is a sal_uInt16 - so subtracting one turns it into an int ? if so please do fix that up. else m_pFileStream-Write(aBuffer, 4); I guess that would be the equivalent as zeros for non-VisualFoxPro :-) Any chance you can fix it up ? Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source WaE: fix misc. SvStream operator problems.
On 01/19/2012 01:50 PM, Michael Meeks wrote: nRecLength is a sal_uInt16 - so subtracting one turns it into an int ? sure it does if so please do fix that up. done -- hopefully this *is* right now (hard to tell from the code); see https://bugs.freedesktop.org/show_bug.cgi?id=39428#c4 and following for making confusion like this go away in the future Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source WaE: fix misc. SvStream operator problems.
On Thu, 2012-01-19 at 20:58 +0100, Stephan Bergmann wrote: sure it does Ah ! fair cop; thanks for fixing that. I fixed a dozen other places and now it builds for me again :-) hopefully the tinderboxen will recover too. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source WaE: fix misc. SvStream operator problems.
Le 19/01/2012 11:10, Stephan Bergmann a écrit : Hi Stephan, Don't know whether it is linked, but I get a build faliure on Oneiric with the latest pull : In file included from /home/alex/LODEV/core/tools/source/stream/strmsys.cxx:33:0: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx: In static member function ‘static sal_Bool InternalStreamLock::LockFile(sal_Size, sal_Size, SvFileStream*)’: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx:149:19: erreur: ‘class osl::DirectoryItem’ has no member named ‘isIdenticalTo’ Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: connectivity/source WaE: fix misc. SvStream operator problems.
On 01/19/2012 11:19 PM, Alex Thurgood wrote: In file included from /home/alex/LODEV/core/tools/source/stream/strmsys.cxx:33:0: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx: In static member function ‘static sal_Bool InternalStreamLock::LockFile(sal_Size, sal_Size, SvFileStream*)’: /home/alex/LODEV/core/tools/source/stream/strmunx.cxx:149:19: erreur: ‘class osl::DirectoryItem’ has no member named ‘isIdenticalTo’ Sounds like recent tml/mmeeks changes? Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
