Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] Word count dialog modeless
Hi all, FWIW, I just [pushed] a change to fix this, along with some other minor updates to the UI, I hope that's fine with everyone: First, since the dialog is now non-modal, the OK button does not have the desired meaning anymore. Close is more appropriate in this case - could you please update that? Next,... Next, I played a bit and run into an issue when working with the Writer Comments. Steps to reproduce: 1. Prepare a document with text, and comments - set the cursor into the text 2. Open the word count dialog - the word count is correctly displayed 3. Click into any note - the word count dialog disappears 4. Press ESC to exit the note Expected result: The word count dialog appears and shows the correct values. The cursor is back in the document (to continue typing). (Mmh, is it possible to show the dialog also when editing the comments?) Current result: The word count dialog appears, but shows no numbers. The cursor is not in the document. (To me, it seems the Word Count dialog gets the focus instead of the document). Can reliably reproduce with my as-of-now very current build. Have you opened a bug for that already, Christoph? Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] Word count dialog modeless
Hi Matt, Kevin, Michael, Astron ... all! First and foremost, Matt, thank you for the extremely helpful patch ... or (speaking as a non-developer), for the great improvement. Awesome! I finally had some time to test it and I'd like to point out three (mostly tiny) things... First, since the dialog is now non-modal, the OK button does not have the desired meaning anymore. Close is more appropriate in this case - could you please update that? Second, the menu item Word Count is now a toggle for the dialog - that's fine. But in this case we need a checkbox in front of the menu item (true = dialog is enabled, false = dialog is not disabled). Next, I played a bit and run into an issue when working with the Writer Comments. Steps to reproduce: 1. Prepare a document with text, and comments - set the cursor into the text 2. Open the word count dialog - the word count is correctly displayed 3. Click into any note - the word count dialog disappears 4. Press ESC to exit the note Expected result: The word count dialog appears and shows the correct values. The cursor is back in the document (to continue typing). (Mmh, is it possible to show the dialog also when editing the comments?) Current result: The word count dialog appears, but shows no numbers. The cursor is not in the document. (To me, it seems the Word Count dialog gets the focus instead of the document). Can you reproduce that? Shall I create an issue for that? Matt, I hope you find that information somehow helpful. It would be cool if some things could be implemented ... thank you again! Cheers, Christoph Am Mittwoch, den 16.11.2011, 13:44 -0500 schrieb Kevin Hunter: At 12:51pm -0500 Wed, 16 Nov 2011, Astron wrote: On 15 November 2011 19:15, Michael Meeks wrote: :-) sounds reasonable. My only concern would be to make it discoverable and of course performance: would we take a per-keystroke hit there ? so perhaps having it easy-to-enable but disabled by default would make sense. How large is the hit? Has anyone measured already? Personally, I can't really perceive anything when comparing writing with the Word Count window open v/ without it. It seems to me to be an issue of how one implements the word count statistics collection. Are the word count statistics constantly kept up-to-date via a incrementers/decrementers per key-stroke? Or are they only collected upon request? From a brief and unscientific test of copying 10MiB of copy and paste text into a Writer document, waiting while it paginates to 2250 pages, then timing how long it takes for the Word Count dialog to give results, it would appear the former: every keystroke /already/ calculates the these statistics. Thus, my first un-educated guess is that this should have very little performance impact. Cheers, Kevin ___ Libreoffice-ux-advise mailing list libreoffice-ux-adv...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] Word count dialog modeless
Hi everyone, First of all: very nice feature indeed! On 15 November 2011 19:15, Michael Meeks michael.me...@suse.com wrote: :-) sounds reasonable. My only concern would be to make it discoverable and of course performance: would we take a per-keystroke hit there ? so perhaps having it easy-to-enable but disabled by default would make sense. How large is the hit? Has anyone measured already? Personally, I can't really perceive anything when comparing writing with the Word Count window open v/ without it. eg. Page 1/2 (354 words) Would that be an acceptable UI change? Sounds fine to me - but we have the ux-advise list for this sort of thing. I think Kendy is gunning to allow people to remove the status bar altogether ;-) but ... no doubt that is not to everyone's taste. I tend to agree with Kendy here. We also already have a lot of things in the status bar already, to the point where it looks cluttered on smaller screens. I think MS Word has something I this, but I no idea if it on by default or some soft of option or dock. Interesting question of course. Clearly docking the word-count window is an easy option wrt. adding new UI. I like this as a solution much better, that's for two reasons: * currently we don't use the space to sides of the pages at all (except for the ruler and the scrollbar) * more information can be presented in a much more coherent manner than in a status bar Would it be possible to add the word count as a Tasks sidebar element (see Impress/Draw)? (This is possible in Writer, see the recently released AccessODF extension [1] which also uses the tasks sidebar. I think the interface is also XML based there, no idea if that tells us anything about how easy relayouting is.) Astron. [1] sourceforge.net/p/accessodf ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH] Word count dialog modeless
At 12:51pm -0500 Wed, 16 Nov 2011, Astron wrote: On 15 November 2011 19:15, Michael Meeks wrote: :-) sounds reasonable. My only concern would be to make it discoverable and of course performance: would we take a per-keystroke hit there ? so perhaps having it easy-to-enable but disabled by default would make sense. How large is the hit? Has anyone measured already? Personally, I can't really perceive anything when comparing writing with the Word Count window open v/ without it. It seems to me to be an issue of how one implements the word count statistics collection. Are the word count statistics constantly kept up-to-date via a incrementers/decrementers per key-stroke? Or are they only collected upon request? From a brief and unscientific test of copying 10MiB of copy and paste text into a Writer document, waiting while it paginates to 2250 pages, then timing how long it takes for the Word Count dialog to give results, it would appear the former: every keystroke /already/ calculates the these statistics. Thus, my first un-educated guess is that this should have very little performance impact. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
