Re: [Libreoffice] [PATCH] [PUSHED] Replace List with vector in svx
And a reply with the [PUSHED] marker so people can kill the thread unread... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Replace List with vector in SC
Hi Rafael, All patched pushed to master, with some follow-up corrections. The rationale for my corrections are given in those commit messages. Thanks a lot! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Replace List for vector in sc
Rafael Dominguez píše v Út 07. 06. 2011 v 19:05 -0430: Made a new patch, with the fixes now im using size_t to handle size, also ensuring we dont add a null object. I have pushed it as http://cgit.freedesktop.org/libreoffice/calc/commit/?id=31a268eb01d9d808a35ffe3161acbec7d4134519 Well, I have pushed the older patch and just replaced sal_uInt16 with size_t. IMHO, the check for existing pObj is not needed. It seems that the method Add is always called with valid objects... If we start supporting NULL parameter, do we really want to return 0 or the current vector size? Well, this whole code need some clean up and get rid of the sal_uInt16 limit... Anyway, this was the last patch from this set = adding PUSHED into the subject. Thanks a lot for the contribution! It helps a lot to make the code cleaner. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH][PUSHED] Replace List for vector
Once again with the correct subject. Rafael Dominguez píše v Čt 02. 06. 2011 v 12:41 -0430: Pushed into master. Thanks for the nice work! Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice