Re: [Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-08-08 Thread Laurent Godard
Hi all first sorry for my silence. Holidays with bad connectivity (and wife and children veto for using computers ;) ) I just want to thank all of you for finalizing this (and sorry kohei for missing the content thing) hacking libO is not that difficult but requires time. i'll try to propose

Re: [Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-07-18 Thread Michael Meeks
Hi Laurent, On Fri, 2011-07-15 at 19:41 +0200, Laurent Godard wrote: Here is my first patch and want at first thanks a lot everybody who helped me starting my build and especially Kohei for his patience and deep knowledge in calc. Kohei is a great mentor :-) First - welcome ! :-) it's

Re: [Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-07-18 Thread Kohei Yoshida
Hi Laurent, On Fri, 2011-07-15 at 19:41 +0200, Laurent Godard wrote: thanks in advance for your review and thank a lot again to Kohei Oh, thanks a lot for working on this performance optimization! :-) As I've already been involved in reviewing your changes giving you code pointers etc, your

Re: [Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-07-18 Thread Kohei Yoshida
On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote: I'd also like to push this to the -3-4 branch, but let me just do a quick test on ODS import of named ranges to make sure if works, then I'll push. And I'm glad I did. This change unfortunately causes a problem on global named range

Re: [Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-07-18 Thread Kohei Yoshida
On Mon, 2011-07-18 at 11:47 -0400, Kohei Yoshida wrote: On Mon, 2011-07-18 at 10:25 -0400, Kohei Yoshida wrote: I'd also like to push this to the -3-4 branch, but let me just do a quick test on ODS import of named ranges to make sure if works, then I'll push. And I'm glad I did. This

[Libreoffice] [PATCH][REVIEW] SetNamedRanges speedup fdo#35357

2011-07-15 Thread Laurent Godard
Hi all Here is my first patch and want at first thanks a lot everybody who helped me starting my build and especially Kohei for his patience and deep knowledge in calc. Kohei is a great mentor :-) The purpose of this patch is to speed up things when sheet.link is used. It is based on the 3.4