Hi all,

I'm not much familiar with perl, but I think the previous implementation of
build.pl had bugs.
For example, --skip option would always be rejected before 'next'
statement, because get_modules_passed() always returns nothing (evaluated
as false). As a result --skip would be incorrectly pushed to @dmake_args.
The same is true for other options, when rhs of assignment is something
evaluated as false (including "0" and '').

I also think it is not good behaviour to push options to @dmake_args when
it fails to parse.
However, I didn't fix it because that could possibly introduce incosistency
with existing scripts.

Cheers,

-- 
Daisuke Nishino

Attachment: 0001-Fix-bug-in-build.pl-option-parser.core.patch
Description: Binary data

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to