Re: [Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image

2010-10-20 Thread Harri Pitkänen
On Wednesday 20 October 2010, Caolán McNamara wrote: > What would be awesome of course is to work on supporting those current > unknown formats :-) Thanks, I will check if there is something I could do to extend the range of supported formats. Harri __

Re: [Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image

2010-10-20 Thread Caolán McNamara
On Tue, 2010-10-19 at 20:25 +0300, Harri Pitkänen wrote: > This patch has been tested on a 64 bit Linux system using the samples > in the bug and some images from libtiff sample collection at > ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz I ran through this one, and yeah fixes a pile

[Libreoffice] [PATCH] Fix for #i93300#: Crash when inserting 32 bit TIFF image

2010-10-19 Thread Harri Pitkänen
The sample documents in the bug had two problems: 32 bit sample size and use of floating point sample format[1]. Neither is supported so this patch adds checks to reject images that have either of these properties. Additionally a sanity check is added to make sure that similar crash (division by z