Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Guys I have fixed and pushed in master this issue, but it should be cherry-picked into 3.5 It will look ugly if we don't. https://bugs.freedesktop.org/show_bug.cgi?id=44110 Regards Olivier Em 04-01-2012 13:55, Michael Meeks escreveu: On Tue, 2012-01-03 at 12:12 -0200, Olivier Hallot wrote: WRT to this patch, there are two files; the binary file opens.ttf and the text file OpenSymbol.sfd. Right - the original / authoritative version should be the .sdf file which (IIRC) as well as being 'diff -u' able - so we can see what changed, is/was also more descriptive complete :-) I used fontforge tool under ubuntu to draw the new characters. Great - that's the right approach. The sfd file is generated based on the ttf binaries. So - IMHO it should be the other way around ;-) at least, when I last edited that font; if we've fluffed that up I suggest we load the original sfd, copy in the new glyphs from the TTF, save it as sfd, and re-export as ttf ;-) Of course - it'd be nice to do that compilation to TTF during the build, but ... it's not so easy without fontforge installed. HTH, Michael. - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPHfwMAAoJEJp3R7nH3vLxXrsH/iLuV/G9HxuewdwICgIeLlUY m/N1/2P+94FEoWkHyRQHO8K5dxknqvvm6qUBK3smMGgWgx/QLRDh4iu1DO2h5b9D DXcZnSFmHKm4vbFCKC/9WItVDkvOA5SobHyAYj50GPJGLBLW3ylCwR1SQsntwlP9 hZGD0ac1ySL/83hw1LdahnF1F7BReJ6uTZRYQ/I3apol73kopUFWIQ9KWdHX1uXo O/piU96FDeDrxkGV3llXKPwedmTYPyNG7rRNhnySKhqfZQ9jurl9bEZpQ98JKQsc /RibIjRdCP5hrmJ0/7ENaH/4o1PvhNB3SNqqYJNJw+ZXwX0qAj4leRxooW31unU= =T1yN -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
Hi Olivier, On 2012-01-04 at 15:55 +, Michael Meeks wrote: WRT to this patch, there are two files; the binary file opens.ttf and the text file OpenSymbol.sfd. Right - the original / authoritative version should be the .sdf file which (IIRC) as well as being 'diff -u' able - so we can see what changed, is/was also more descriptive complete :-) I used fontforge tool under ubuntu to draw the new characters. Great - that's the right approach. The sfd file is generated based on the ttf binaries. So - IMHO it should be the other way around ;-) at least, when I last edited that font; if we've fluffed that up I suggest we load the original sfd, copy in the new glyphs from the TTF, save it as sfd, and re-export as ttf ;-) I am sorry, but I have just reverted the push of your change based on what Michael wrote (and I previously too). Please note that .sfd is the source, and .ttf is generated. When you use .sfd as the source in fontforge, the change will be minimal, not a 85k lines long patch. Can you please re-try with editing the .sfd in fontforge? [If you use .ttf as the source, and generate .sfd out of that, it is similar as if you import .pdf in LO, and export it to .odf - ie. it is possible, but not what we want, provided that we have the .sfd source.] Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Kendy This commit was a newbie mistake. Thanks for reverting it. I will try to fix the sdf issue. regards Olivier Em 06-01-2012 14:34, Jan Holesovsky escreveu: Hi Olivier, On 2012-01-04 at 15:55 +, Michael Meeks wrote: WRT to this patch, there are two files; the binary file opens.ttf and the text file OpenSymbol.sfd. Right - the original / authoritative version should be the .sdf file which (IIRC) as well as being 'diff -u' able - so we can see what changed, is/was also more descriptive complete :-) I used fontforge tool under ubuntu to draw the new characters. Great - that's the right approach. The sfd file is generated based on the ttf binaries. So - IMHO it should be the other way around ;-) at least, when I last edited that font; if we've fluffed that up I suggest we load the original sfd, copy in the new glyphs from the TTF, save it as sfd, and re-export as ttf ;-) I am sorry, but I have just reverted the push of your change based on what Michael wrote (and I previously too). Please note that .sfd is the source, and .ttf is generated. When you use .sfd as the source in fontforge, the change will be minimal, not a 85k lines long patch. Can you please re-try with editing the .sfd in fontforge? [If you use .ttf as the source, and generate .sfd out of that, it is similar as if you import .pdf in LO, and export it to .odf - ie. it is possible, but not what we want, provided that we have the .sfd source.] Regards, Kendy - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPByP8AAoJEJp3R7nH3vLxjXQIAItFOSto9mz/UCS3D5HgmCI1 QIIbFu8r1/Jx1Hlc+X8cQBy8FiQleTbXV2SJm1qx6ja21HQx2VJzuba84GjHBTpJ Y1HTJ0XPiU4SwNo/zH5W0Ma7hl+quEO9DRtu84f7FK51bv23/oSnc3Npz6NNUI4h rdWvEVuM4EdUV/2pSkTiuF0L2875F1hvgifVc4HkoXZYqUKcRJy0N1fMVJl3BZM3 DIBm97wQIH7Q1vRyjG67DZlVqX6uHgyx+/HtTMk1lCTc9RtA0A2UcmiW9b7FQbho z1M7BqgDONtdvS3CFYGNPCRq726tVMMeSOzypL2/aEtMqrlb9Vr7YA/jouVK/fM= =F/Hc -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
On Tue, 2012-01-03 at 12:12 -0200, Olivier Hallot wrote: WRT to this patch, there are two files; the binary file opens.ttf and the text file OpenSymbol.sfd. Right - the original / authoritative version should be the .sdf file which (IIRC) as well as being 'diff -u' able - so we can see what changed, is/was also more descriptive complete :-) I used fontforge tool under ubuntu to draw the new characters. Great - that's the right approach. The sfd file is generated based on the ttf binaries. So - IMHO it should be the other way around ;-) at least, when I last edited that font; if we've fluffed that up I suggest we load the original sfd, copy in the new glyphs from the TTF, save it as sfd, and re-export as ttf ;-) Of course - it'd be nice to do that compilation to TTF during the build, but ... it's not so easy without fontforge installed. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Kendy Em 30-12-2011 06:36, Jan Holesovsky escreveu: Hi Olivier, On 2011-12-24 at 00:13 -0200, Olivier Hallot wrote: Please find the patch attached in bug 44110, together with the description of the issue and fix. https://bugs.freedesktop.org/show_bug.cgi?id=44110 Terribly sorry for being late with reviewing :-( I looked at the patch, and it seems to me as if it changes much more than just the affected characters. I think the biggest change that seems to make it huge is changing Encoding: from Custom to UnicodeBmp. Was that deliberate? If yes, I think we should split the commit into 2 - the huge change, and the fix of the math symbols. Can you please have a look? Thank you, Kendy WRT to this patch, there are two files; the binary file opens.ttf and the text file OpenSymbol.sfd. I used fontforge tool under ubuntu to draw the new characters. This tool apparently needs only the binary ttf file to let you edit and draw fonts. The sfd file is generated based on the ttf binaries. For what it worth, LibreOffice needs only the ttf file and the sfd is not even packed into the distribuables. So actually I am not sure how to handle the sfd file.It appears to be superfluous. Please advise. - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPAwzFAAoJEJp3R7nH3vLxn1QIAIqzjTBlev5PrDxp9Zv5nW+t IAuizqZRb0yNTFdanI533WrcReVqaiYQF3WAklrNX3wKx3fXm0V171sR9wIRZF6T Qy+8VmwSUiB1Lq4zTXCjswt/C9VZxZE0Okn5Hpmz+FQvMrNzkRmEnU/1f14pXH+L GqPPUJhhe5ttBK81RcqjohOSlDDuPrW08KpLe7UNcgYIn9R1ITvZfTkJjKj4qguy Rd7b3UCL4pkCfaU2RttU3w0p3tfCIJbGzPHNGCw4UmIUhVWLEAtkJyXE3C5vEsBQ 9oq9OD8TT1ojfaeTsGzH+sLaH/DCUvhoZFxwcW2xBUn/hRiIbYONac2sSLDXWI0= =cRJZ -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
Hi Olivier, On 2011-12-24 at 00:13 -0200, Olivier Hallot wrote: Please find the patch attached in bug 44110, together with the description of the issue and fix. https://bugs.freedesktop.org/show_bug.cgi?id=44110 Terribly sorry for being late with reviewing :-( I looked at the patch, and it seems to me as if it changes much more than just the affected characters. I think the biggest change that seems to make it huge is changing Encoding: from Custom to UnicodeBmp. Was that deliberate? If yes, I think we should split the commit into 2 - the huge change, and the fix of the math symbols. Can you please have a look? Thank you, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
Hi Kendy Must be due to the software I used to draw the characters (FontForge). I think it tries to enhance the font definition file, turning it into a very large one, athough the result (Opensymbol.ttf) is not directly affected by these enhancements. Let me see if I can reduce the size of the font defiition file. Kind regards and Happy New Year! Olivier 2011/12/30 Jan Holesovsky ke...@suse.cz Hi Olivier, On 2011-12-24 at 00:13 -0200, Olivier Hallot wrote: Please find the patch attached in bug 44110, together with the description of the issue and fix. https://bugs.freedesktop.org/show_bug.cgi?id=44110 Terribly sorry for being late with reviewing :-( I looked at the patch, and it seems to me as if it changes much more than just the affected characters. I think the biggest change that seems to make it huge is changing Encoding: from Custom to UnicodeBmp. Was that deliberate? If yes, I think we should split the commit into 2 - the huge change, and the fix of the math symbols. Can you please have a look? Thank you, Kendy -- Olivier Hallot Founder and Steering Commitee Member The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
On Sat, Dec 24, 2011 at 12:13:22AM -0200, Olivier Hallot olivier.hal...@documentfoundation.org wrote: Please find the patch attached Hi Oliver, Forgot to attach it? pgpFclcT8RnOq.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Miklos The patch is attached in bug 44110... It is 1,4MB so I thought it was a bit hefty for the list... Let me know is I have to attach here anyway. Merry Christmas Olivier Em 24-12-2011 09:44, Miklos Vajna escreveu: On Sat, Dec 24, 2011 at 12:13:22AM -0200, Olivier Hallot olivier.hal...@documentfoundation.org wrote: Please find the patch attached Hi Oliver, Forgot to attach it? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO9caHAAoJEJp3R7nH3vLxZ0EH/3lToR+14Ioz6lRTk0WUgciz UB/CoEkka4KKSBWZ4tA0qJEMNzvNsjsOMo35FkiRwjLQnbRntnfSj1SGESweRy3o VjvlMu5HrZbCbJKG6Ca4t0doubhR2RWQylEkoh40prNsgjz3XWhW4Vaifsx9J2z3 TOm/sBIiMQqGrY67j+M/G2yrp9eWsAYX2G+6yMoOoPQBeDcI7MSqGMCXHl8dJBLw 7+TUoGHzV5gbhYeClLVPWc6xHtNFE2zBYPCb0a0TWnJEnwQ3/EQxfXR021nXSm2c WhVxRh049FVpD8X1HGFD7bc4vud2MmVa701kdclVTYzeDi5EwMahaNtJk3o3bFM= =BwqG -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
On Sat, Dec 24, 2011 at 6:33 AM, Olivier Hallot olivier.hal...@documentfoundation.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Miklos The patch is attached in bug 44110... It is 1,4MB so I thought it was a bit hefty for the list... Let me know is I have to attach here anyway. no, do not bother... you did right. 1.4 MB is too big for the list... putting it in bugzilla is the right thing to do in that case :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please find the patch attached in bug 44110, together with the description of the issue and fix. https://bugs.freedesktop.org/show_bug.cgi?id=44110 Thanks you - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO9TVCAAoJEJp3R7nH3vLxLXIH/R8C4Y8d1BrDO8tpkpk6ODTL feNUhobIHpcLZN/sFTwj4X1i/cGVGXUBtZ7DWUYKXyFKoQaiLI8kC+WXJ2tldusU zc71qOumVCuYwhxBCkf3vnePY1g+iYbTt9jxWjP6n0uNXtp57aKx6LI1Nba/XGdl Q8ikPOzByZSq5ryv/czuJufsDxhZZQgU9NkGfb8DeAOM3TL4ieMo5Kgs6MgnbUmU sEW3FMAW/SwLWGHLIvAwqaoYjOvT+7Tytv8sGQE9KrTBP3d97FxQ5zu7TWW+Tewu 0B0Zh79sj4tQ13hCvdF6rOp2ORLB07Ms+aDSBam1TW0kW8IrRcVY77C0bay+Ed8= =8J+g -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
