On 20/10/10 11:15, Noel Power wrote:
I've looked at the basic part, looks good to me, currently I am in the
middle of a build, I will apply it later, check again and push it (
will post here about that ). Thanks again!!! much apprecialted
Noel
done, and thanks,
Noel
sending again :/
On 18/10/10 14:06, Povilas Kanapickas wrote:
Hello,
I've done some work on entry level tasks. Specifically, I've removed
all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus
comments like /*N*/, /*?*/ and so on were removed. As more than
thousand of files ha
On 18/10/10 14:06, Povilas Kanapickas wrote:
Hello,
I've done some work on entry level tasks. Specifically, I've removed
all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus
comments like /*N*/, /*?*/ and so on were removed. As more than
thousand of files have been changed I
On Wed, 2010-10-20 at 04:46 -0500, Norbert Thiebaud wrote:
> On Wed, Oct 20, 2010 at 4:24 AM, Kohei Yoshida wrote:
> > On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
> >> On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
> >> > Everything except the 'filters' patch has been
On Wed, Oct 20, 2010 at 4:24 AM, Kohei Yoshida wrote:
> On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
>> On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
>> > Everything except the 'filters' patch has been either pushed,
>> > or sent
>> > to the component maintainer for re
On Mon, 2010-10-18 at 14:06 -0400, Kohei Yoshida wrote:
> On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
> > Everything except the 'filters' patch has been either pushed,
> > or sent
> > to the component maintainer for review.
>
> And I'm reviewing the calc part of your patch. A
On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote:
> Hello,
>
>
> I've done some work on entry level tasks. Specifically, I've removed
> all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus
> comments like /*N*/, /*?*/ and so on were removed.
I took a look at the sw bi
Michael Meeks wrote:
> Everything except the 'filters' patch has been either pushed, or sent
> to the component maintainer for review.
>
libs-gui parts (basebmp & basegfx) just pushed. Kept a few useful
bits in the */test, */workben subdirs, those are often playgrounds /
staging areas for co
On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote:
> Everything except the 'filters' patch has been either pushed,
> or sent
> to the component maintainer for review.
And I'm reviewing the calc part of your patch. At first glance there
are several hunks that I'd like to keep, but I'
> I was also interested in things like the UI string changes
> in binfilters - what was all that about ? :-)
That was certainly not intended. It seems my editor has screwed up as it
somehow didn't like some files. It couldn't open them using UTF-8, so I
forced another encoding. That might be the
> Ok - so, one thing that is helpful is: if you use a script - can you
> post the script instead of a patch ? :-) that way we save a lot of
> reviewer time.
>
I used a graphical find/replace manager. I don't remember how exactly the
regexp looked, but at first I removed all '/*.*/ ' commen
Hi there,
On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote:
> I've done some work on entry level tasks. Specifically, I've removed
> all #if 0 blocks in the LibreOffice source tree.
So - I did some more review; I left a few useful / commented pieces in
that were removed, but so
Hi there,
On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote:
> I've done some work on entry level tasks. Specifically, I've removed
> all #if 0 blocks in the LibreOffice source tree.
Wow.
> Also, a lot of bogus comments like /*N*/, /*?*/ and so on were
> removed.
Ok -
Hello,
I've done some work on entry level tasks. Specifically, I've removed all #if
0 blocks in the LibreOffice source tree. Also, a lot of bogus comments like
/*N*/, /*?*/ and so on were removed. As more than thousand of files have
been changed I didn't try to make a separate patch for each one.
14 matches
Mail list logo
