Re: [Libreoffice] [PATCH] some cleaning for Windows part - need a review

2011-09-10 Thread Pierre-André Jacquod
Hello, I will have a look at your patches on Monday, unless somebody beats me to it during the weekend. Thanks, based on some remarks, here exactly the same patches, but with improved commit comments. Will be probably better to integrate these. Regards Pierre-André >From 94bed68189f2298d039

Re: [Libreoffice] [PATCH] some cleaning for Windows part - need a review

2011-09-09 Thread Tor Lillqvist
> By the way, just a question: from which version is Windows supported? Only NT-based ones, WIndows 2000 or later. And even the Windows 2000 support is in my opinion "don't break it on purpose" only, I don't think anybody regularly checks that it works on Windows 2000. So in practice I think we wo

[Libreoffice] [PATCH] some cleaning for Windows part - need a review

2011-09-09 Thread Pierre-André Jacquod
hello, liking systematic work, I was cleaning the unreadVariable warning from cppchecker.:-) This also let improve my programming knowledge and style... Here a bunch of changes that touch only Win product,... that I am unable to test, having only unix. Neverless, I did it would it be to redu