Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-09-05 Thread Caolán McNamara
On Fri, 2011-09-02 at 17:06 +0100, Caolán McNamara wrote: > On Fri, 2011-09-02 at 17:51 +0200, Matúš Kukan wrote: > > Maybe this could be pushed? or something similar ? > > I think you're out of luck with an ifdef U_JG_FARSI_YEH because its an > enum, how about... pushed something now that should

Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-09-02 Thread Caolán McNamara
On Fri, 2011-09-02 at 17:51 +0200, Matúš Kukan wrote: > Maybe this could be pushed? or something similar ? I think you're out of luck with an ifdef U_JG_FARSI_YEH because its an enum, how about (typed directly, fix syntax, whatever) #if (( U_ICU_VERSION_MAJOR_NUM < 4 ) || (( U_ICU_VERSION_MAJOR_N

Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-09-02 Thread Matúš Kukan
Hi, On 1 September 2011 02:54, Eike Rathke wrote: > Hi Khaled, > > On Thursday, 2011-09-01 01:28:28 +0200, Khaled Hosny wrote: > >> While trying to fix the eternal brokenness of Kashida justification code, >> I found some low hanging cleanups. See attached patches. > > Nice clean-up, pushed to ma

Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-09-01 Thread Caolán McNamara
On Thu, 2011-09-01 at 01:28 +0200, Khaled Hosny wrote: > Hello all, > > While trying to fix the eternal brokenness of Kashida justification code, > I found some low hanging cleanups. See attached patches. Great that someone is working on that, IIRC Martin was particular exercised about the Kashid

Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-08-31 Thread Eike Rathke
Hi Khaled, On Thursday, 2011-09-01 01:28:28 +0200, Khaled Hosny wrote: > While trying to fix the eternal brokenness of Kashida justification code, > I found some low hanging cleanups. See attached patches. Nice clean-up, pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=68

[Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-08-31 Thread Khaled Hosny
Hello all, While trying to fix the eternal brokenness of Kashida justification code, I found some low hanging cleanups. See attached patches. Regards, Khaled -- Khaled Hosny Egyptian Arab >From 7c237af83055a9b892e7349ee08af92b7202b09c Mon Sep 17 00:00:00 2001 From: Khaled Hosny Date: Wed,