Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Kohei Yoshida
Hi Noel, On Sat, 2012-01-21 at 00:01 +0200, Noel Grandin wrote: > I hereby confirm that this and my future contributions are licensed > under GPLv3+/LGPLv3+/MPL1.1+ Thanks for the confirmation. Just pushed to master, with my follow-up changes (as I mentioned in my earlier post). > The problem w

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Noel Grandin
I hereby confirm that this and my future contributions are licensed under GPLv3+/LGPLv3+/MPL1.1+ The problem was in ScColumn::Resize I was calling vector::resize when the correct call is vector::reserve At some point I should rename the ScColumn::Resize method to match the std::vector naming --

Re: [Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

2012-01-20 Thread Kohei Yoshida
On Fri, 2012-01-20 at 15:15 +0200, Noel Grandin wrote: > Hi > > this patch passes valgrind tests in the sc module, and passes a global > make check. Yup. All looks green. Nice work. :-) Before I push, could you verify that you are submitting this patch under GPLv3+/LGPLv3+/MPL1.1+ licenses?