Re: [Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg

2010-12-07 Thread Noel Power
Hi Julien On 06/12/10 21:40, Julien Nabet wrote: Hello, Here's a small patch for dbaccess/source/ui/dlg This is a strange one, it seems SERVICE_UI_FOLDERPICKER is not a simple const char but an instance of ConstAsciiString ( defined in dbaccess/source/inc/constasciistring.hxx ) so I changed

Re: [Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg

2010-12-07 Thread Caolán McNamara
On Tue, 2010-12-07 at 12:53 +, Noel Power wrote: presumeably RTL_CONSTASCII_USTRINGPARAM would try to take sizeof( ConstAsciiString ) in that case Soon enough I'll commit in a compile time test that will catch if that happens by accident. Though it can only be enabled with gcc 4.5.0 and