Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Thu, Nov 03, 2011 at 10:46:36PM +0100, Philipp Weissenbacher wrote: On 29 October 2011 01:02, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? You never ran autogen.sh ? never try to make the product ? ah... that would explain it indeed. In any case it might be a good exercise to try to actually do a build, since it is good practice to try to at least compile when doing any sort of change to the source code. Sure, I will try to build it. I wasn't sure if translating comments was serious enough a change to do that. I would tend to think that indeed, building LibreOffice just to translate comments is rather onerous a cost; I would like that we do not ask that of people. I've modified the Patch Handling Guidelines with instructions on how to enable the git hooks without building. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Mon, 2011-11-21 at 13:54 +0100, Lionel Elie Mamane wrote: I would tend to think that indeed, building LibreOffice just to translate comments is rather onerous a cost. Agreed, no point in stumbling over that. Having said that - comment translation patches should be -only- comments + whitespace + obvious stuff in this case; no substantive code changes. I would like that we do not ask that of people. I've modified the Patch Handling Guidelines with instructions on how to enable the git hooks without building. Lovely - thanks ! :-) Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 29 October 2011 01:02, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? You never ran autogen.sh ? never try to make the product ? ah... that would explain it indeed. At least it explain the cat: /home/philipp/Projekte/LibreOffice/core/bin/repo-list: No such file or directory but not why the hook for core are not set-up anyway... In any case it might be a good exercise to try to actually do a build, since it is good practice to try to at least compile when doing any sort of change to the source code. Sure, I will try to build it. I wasn't sure if translating comments was serious enough a change to do that. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 28/10/11 03:25, Norbert Thiebaud wrote: On Thu, Oct 27, 2011 at 8:19 PM, Norbert Thiebaudnthieb...@gmail.com wrote: On Thu, Oct 27, 2011 at 7:38 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Thanks, applied and pushed. I hit sent a bit fast... One thing I forgot to mention. I did clean-up some trailing spaces... did you have to over-ride the commit hook or did it fail to warn you of the trailing spaces ? I didn't get any such message. Also, searching in vim for /\s\+$ turned up only one trailing space on line 291. I used gedit; maybe that's the culprit? Also, can you add yourself to http://wiki.documentfoundation.org/Development/Developers, referencing your post above that indicate the license. Don't be intimidated with the 'Developper' page title. This is to try to keep track of licensing declaration of committed stuff. Done! Thanks, Philipp Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Fri, Oct 28, 2011 at 9:19 AM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: I didn't get any such message. Also, searching in vim for /\s\+$ turned up only one trailing space on line 291. I used gedit; maybe that's the culprit? yes that was it. for gedit, google pointed me to: http://www.linuxuk.org/2009/05/trim-trailing-spaces-in-gedit/ https://github.com/jonleighton/gedit-trailsave ... Still I'm a bit concerned that the commit-hook did not complain can you sent the result of ls -l .git/hooks Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 28/10/11 16:33, Norbert Thiebaud wrote: On Fri, Oct 28, 2011 at 9:19 AM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: I didn't get any such message. Also, searching in vim for /\s\+$ turned up only one trailing space on line 291. I used gedit; maybe that's the culprit? yes that was it. for gedit, google pointed me to: http://www.linuxuk.org/2009/05/trim-trailing-spaces-in-gedit/ https://github.com/jonleighton/gedit-trailsave ... Thanks, but it doesn't work with gedit 3 for me. I'll switch to vim for now anyway and use the remove whitespace on save autocmd. Still I'm a bit concerned that the commit-hook did not complain can you sent the result of ls -l .git/hooks -rwxrwxr-x. 1 philipp philipp 452 Oct 21 03:00 applypatch-msg.sample -rwxrwxr-x. 1 philipp philipp 896 Oct 21 03:00 commit-msg.sample -rwxrwxr-x. 1 philipp philipp 160 Oct 21 03:00 post-commit.sample -rwxrwxr-x. 1 philipp philipp 548 Oct 21 03:00 post-receive.sample -rwxrwxr-x. 1 philipp philipp 189 Oct 21 03:00 post-update.sample -rwxrwxr-x. 1 philipp philipp 398 Oct 21 03:00 pre-applypatch.sample -rwxrwxr-x. 1 philipp philipp 1578 Oct 21 03:00 pre-commit.sample -rwxrwxr-x. 1 philipp philipp 1239 Oct 21 03:00 prepare-commit-msg.sample -rwxrwxr-x. 1 philipp philipp 4951 Oct 21 03:00 pre-rebase.sample -rwxrwxr-x. 1 philipp philipp 3611 Oct 21 03:00 update.sample Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Fri, Oct 28, 2011 at 12:09 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: ls -l .git/hooks -rwxrwxr-x. 1 philipp philipp 452 Oct 21 03:00 applypatch-msg.sample -rwxrwxr-x. 1 philipp philipp 896 Oct 21 03:00 commit-msg.sample -rwxrwxr-x. 1 philipp philipp 160 Oct 21 03:00 post-commit.sample -rwxrwxr-x. 1 philipp philipp 548 Oct 21 03:00 post-receive.sample -rwxrwxr-x. 1 philipp philipp 189 Oct 21 03:00 post-update.sample -rwxrwxr-x. 1 philipp philipp 398 Oct 21 03:00 pre-applypatch.sample -rwxrwxr-x. 1 philipp philipp 1578 Oct 21 03:00 pre-commit.sample -rwxrwxr-x. 1 philipp philipp 1239 Oct 21 03:00 prepare-commit-msg.sample -rwxrwxr-x. 1 philipp philipp 4951 Oct 21 03:00 pre-rebase.sample -rwxrwxr-x. 1 philipp philipp 3611 Oct 21 03:00 update.sample oh... that is not good! can you run ./g -z please, and verify that after that you have, afterward, something like $ ll .git/hooks/ total 112 -rwxr-xr-x 1 n_th staff 452 Aug 6 15:41 applypatch-msg.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 commit-msg - ../../git-hooks/commit-msg -rwxr-xr-x 1 n_th staff 896 Aug 6 15:41 commit-msg.sample -rwxr-xr-x 1 n_th staff 160 Aug 6 15:41 post-commit.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 post-merge - ../../git-hooks/post-merge -rwxr-xr-x 1 n_th staff 552 Aug 6 15:41 post-receive.sample -rwxr-xr-x 1 n_th staff 189 Aug 6 15:41 post-update.sample -rwxr-xr-x 1 n_th staff 398 Aug 6 15:41 pre-applypatch.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 pre-commit - ../../git-hooks/pre-commit -rwxr-xr-x 1 n_th staff 1578 Aug 6 15:41 pre-commit.sample -rwxr-xr-x 1 n_th staff 4951 Aug 6 15:41 pre-rebase.sample -rwxr-xr-x 1 n_th staff 1239 Aug 6 15:41 prepare-commit-msg.sample -rwxr-xr-x 1 n_th staff 3611 Aug 6 15:41 update.sample Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On 28/10/11 20:12, Norbert Thiebaud wrote: On Fri, Oct 28, 2011 at 12:09 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: ls -l .git/hooks -rwxrwxr-x. 1 philipp philipp 452 Oct 21 03:00 applypatch-msg.sample -rwxrwxr-x. 1 philipp philipp 896 Oct 21 03:00 commit-msg.sample -rwxrwxr-x. 1 philipp philipp 160 Oct 21 03:00 post-commit.sample -rwxrwxr-x. 1 philipp philipp 548 Oct 21 03:00 post-receive.sample -rwxrwxr-x. 1 philipp philipp 189 Oct 21 03:00 post-update.sample -rwxrwxr-x. 1 philipp philipp 398 Oct 21 03:00 pre-applypatch.sample -rwxrwxr-x. 1 philipp philipp 1578 Oct 21 03:00 pre-commit.sample -rwxrwxr-x. 1 philipp philipp 1239 Oct 21 03:00 prepare-commit-msg.sample -rwxrwxr-x. 1 philipp philipp 4951 Oct 21 03:00 pre-rebase.sample -rwxrwxr-x. 1 philipp philipp 3611 Oct 21 03:00 update.sample oh... that is not good! can you run ./g -z please, and verify that after that you have, afterward, something like $ ll .git/hooks/ total 112 -rwxr-xr-x 1 n_th staff 452 Aug 6 15:41 applypatch-msg.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 commit-msg - ../../git-hooks/commit-msg -rwxr-xr-x 1 n_th staff 896 Aug 6 15:41 commit-msg.sample -rwxr-xr-x 1 n_th staff 160 Aug 6 15:41 post-commit.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 post-merge - ../../git-hooks/post-merge -rwxr-xr-x 1 n_th staff 552 Aug 6 15:41 post-receive.sample -rwxr-xr-x 1 n_th staff 189 Aug 6 15:41 post-update.sample -rwxr-xr-x 1 n_th staff 398 Aug 6 15:41 pre-applypatch.sample lrwxr-xr-x 1 n_th staff26 Aug 6 16:04 pre-commit - ../../git-hooks/pre-commit -rwxr-xr-x 1 n_th staff 1578 Aug 6 15:41 pre-commit.sample -rwxr-xr-x 1 n_th staff 4951 Aug 6 15:41 pre-rebase.sample -rwxr-xr-x 1 n_th staff 1239 Aug 6 15:41 prepare-commit-msg.sample -rwxr-xr-x 1 n_th staff 3611 Aug 6 15:41 update.sample No, I just get: cat: /home/philipp/Projekte/LibreOffice/core/bin/repo-list: No such file or directory Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Fri, Oct 28, 2011 at 3:11 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Out of curiosity, how did you set-up your repos ? (pure git clone, using the tar.gz primer method ? ) I used git clone git://anongit.freedesktop.org/git/core/ And then followed the patch handling guideline to generate the patches. Am I doing it wrong? You never ran autogen.sh ? never try to make the product ? ah... that would explain it indeed. At least it explain the cat: /home/philipp/Projekte/LibreOffice/core/bin/repo-list: No such file or directory but not why the hook for core are not set-up anyway... In any case it might be a good exercise to try to actually do a build, since it is good practice to try to at least compile when doing any sort of change to the source code. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Thu, Oct 27, 2011 at 7:38 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Thanks, applied and pushed. Cheers, Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH]: Translate German Comments
On Thu, Oct 27, 2011 at 8:19 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Thu, Oct 27, 2011 at 7:38 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Hi all, Here is my first patch. It translates the German comments found in sw/source/core/doc/acmplwrd.cxx to English. I also translated messages within OSL_ENSURE; wasn't sure if that's permissible. This patch and any future work is licensed under LGPLv3+/MPL. Thanks, applied and pushed. I hit sent a bit fast... One thing I forgot to mention. I did clean-up some trailing spaces... did you have to over-ride the commit hook or did it fail to warn you of the trailing spaces ? Also, can you add yourself to http://wiki.documentfoundation.org/Development/Developers, referencing your post above that indicate the license. Don't be intimidated with the 'Developper' page title. This is to try to keep track of licensing declaration of committed stuff. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Translate German comments.
Bookkeeping. -- Thorsten pgpSitna7zHXe.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
