Re: [Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

2011-02-08 Thread Francois Tigeot
On Tue, Feb 08, 2011 at 01:47:17PM +, Caolán McNamara wrote: > On Sun, 2011-02-06 at 15:47 +0100, Francois Tigeot wrote: > > > Oh, and by the way, createRegistryServiceFactory() used in saxparser.cxx > > is deprecated in OpenOffice: > > A lot of things that are deprecated remain in there, not

Re: [Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

2011-02-08 Thread Caolán McNamara
On Sun, 2011-02-06 at 15:47 +0100, Francois Tigeot wrote: > What was it ? The specific thing that Fridrich fixed was a dubious hash_map/unordered_map::erase on the results of a hash_map/unordered_map::find when find returns the end iterator to indicate that nothing was found > Oh, and by the way,

Re: [Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

2011-02-06 Thread Francois Tigeot
On Sun, Feb 06, 2011 at 03:47:07PM +0100, Francois Tigeot wrote: > On Sun, Feb 06, 2011 at 02:32:32PM +, Caolán McNamara wrote: > > On Sun, 2011-02-06 at 15:10 +0100, Francois Tigeot wrote: > > > > The attached patch prints the exception message in saxparser.cxx. > > > > It would be useful to h

Re: [Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

2011-02-06 Thread Francois Tigeot
On Sun, Feb 06, 2011 at 02:32:32PM +, Caolán McNamara wrote: > On Sun, 2011-02-06 at 15:10 +0100, Francois Tigeot wrote: > > > The attached patch prints the exception message in saxparser.cxx. > > > It would be useful to have it in tree. > Looks reasonable to me, pushed, thanks for this. Great

[Libreoffice] [PUSHED] Re: [PATCH] Build fails in i18npool

2011-02-06 Thread Caolán McNamara
On Sun, 2011-02-06 at 15:10 +0100, Francois Tigeot wrote: > > The attached patch prints the exception message in saxparser.cxx. > > > > It would be useful to have it in tree. > > Sorry, forgot to attach the file. Looks reasonable to me, pushed, thanks for this. Though Fridrich tracked down the f