Re: [Libreoffice] [REVIEW] Easy patch on l10ntools

2012-01-03 Thread Eike Rathke
Hi Andras, On Tuesday, 2012-01-03 20:09:42 +0100, Andras Timar wrote: > >> diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx > >> @@ -1475,7 +1475,7 @@ void Export::InsertListEntry( const ByteString > >> &rText, > >> const ByteString &rLine ) > >>              (*pCurEntry)[

Re: [Libreoffice] [REVIEW] Easy patch on l10ntools

2012-01-03 Thread Andras Timar
2012/1/3 Eike Rathke : > Hi julien2412, > > On Wednesday, 2011-12-28 14:31:21 -0800, julien2412 wrote: > >> Cppcheck report tells this : >> 1474  duplicateBranch style   Found duplicate branches for if and else >> for l10ntools/source/export.cxx >> >> >> Even if this seems easy, perhaps it could be

Re: [Libreoffice] [REVIEW] Easy patch on l10ntools

2012-01-03 Thread Eike Rathke
Hi julien2412, On Wednesday, 2011-12-28 14:31:21 -0800, julien2412 wrote: > Cppcheck report tells this : > 1474 duplicateBranch style Found duplicate branches for if and else > for l10ntools/source/export.cxx > > > Even if this seems easy, perhaps it could be something else than just > "rTex

[Libreoffice] [REVIEW] Easy patch on l10ntools

2011-12-28 Thread julien2412
Hello, Cppcheck report tells this : 1474duplicateBranch style Found duplicate branches for if and else for l10ntools/source/export.cxx Even if this seems easy, perhaps it could be something else than just "rText" here. diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx