Re: [Libreoffice] [REVIEW] Fix for fdo#37767

2011-07-18 Thread Michael Meeks
Hi Kohei, On Fri, 2011-07-15 at 09:48 +0100, Noel Power wrote: looks fine to me +1, one more needed for 3.4.2 Ditto here; much preferred to creating that new temporary DPObject :-) I've merged to libreoffice-3-4-2. I closed the bug too ;-) Thanks, Michael. --

Re: [Libreoffice] [REVIEW] Fix for fdo#37767

2011-07-15 Thread Noel Power
On 14/07/11 23:42, Kohei Yoshida wrote: Hi there, I would like to commit the attached change to the -3-4 branch and hopefully to the 3-4-2 branch as well. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=37767 The refresh of data pilot table (or pivot table) was broken from the UNO

[Libreoffice] [REVIEW] Fix for fdo#37767

2011-07-14 Thread Kohei Yoshida
Hi there, I would like to commit the attached change to the -3-4 branch and hopefully to the 3-4-2 branch as well. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=37767 The refresh of data pilot table (or pivot table) was broken from the UNO API because the code there had not been

Re: [Libreoffice] [REVIEW] Fix for fdo#37767

2011-07-14 Thread Markus Mohrhard
Looks sane to me. Pushed to the 3-4 branch. Two more reviews for 3.4.2 needed. 2011/7/15 Kohei Yoshida kohei.yosh...@gmail.com Hi there, I would like to commit the attached change to the -3-4 branch and hopefully to the 3-4-2 branch as well. This fixes