[Libreoffice] [REVIEW] fix for fdo#38593: crash when paste nested table from html to calc

2011-06-23 Thread Markus Mohrhard
Hello all,

I would like to get this patch into the 3-4 branch because it prevents a
crash that was introduced by a DeclareList removal.
We can not call vector::back on an empty vector.

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=70d01893e713fa730acd73a28fbf5ee29651215c

Regards, Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW] fix for fdo#38593: crash when paste nested table from html to calc

2011-06-23 Thread Caolán McNamara
On Thu, 2011-06-23 at 17:20 +0200, Markus Mohrhard wrote:
 Hello all,
 
 I would like to get this patch into the 3-4 branch because it prevents
 a crash that was introduced by a DeclareList removal.
 We can not call vector::back on an empty vector.

+1, done into 3-4. Not into 3-4-X yet however. Next reviewer can do
that :-)

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [REVIEW] fix for fdo#38593: crash when paste nested table from html to calc

2011-06-23 Thread Michael Meeks

On Thu, 2011-06-23 at 16:26 +0100, Caolán McNamara wrote:
  I would like to get this patch into the 3-4 branch because it prevents
  a crash that was introduced by a DeclareList removal.
  We can not call vector::back on an empty vector.
 
 +1, done into 3-4. Not into 3-4-X yet however. Next reviewer can do
 that :-)

Patch looks fine for me; if we have to re-spin 3.4.1 I'm happy to have
this too.

ATB,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice