Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-27 Thread Noel Power
I've commited this to 3.4 http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4id=ab802aee181ca6df397ca53e461d5f53808cef9d and like the subject says. one more needed for 3.4.4 Noel ___ LibreOffice mailing list

Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-27 Thread Stephan Bergmann
On 10/27/2011 11:58 AM, Noel Power wrote: and like the subject says. one more needed for 3.4.4 With the same caveat like the other reviewers -- I'm rather illiterate with COM/OLE -- the change does look reasonable to me. So go ahead! Stephan

[Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-26 Thread Michael Meeks
On Wed, 2011-10-26 at 19:49 +0200, Michael Stahl wrote: On 26/10/11 18:55, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fcb94311fd7dd40c05ca132e3a30a888316cbbe .. have no clue when it comes to OLE automation, but after reading the bug your patch looks like it

Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-26 Thread Noel Power
On 26/10/11 20:26, Michael Meeks wrote: The code is similarly opaque to me :-) if you're happy it is tested and works I don't know that we'll find any more competent reviewers. It is slightly concerning to me that this method has seemingly been using a SAFEARRAY since 2000: SAFEARRAY is

Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)

2011-10-26 Thread Noel Power
On 26/10/11 20:43, Noel Power wrote: type of a variant containing a SAFEARRAY is set to VT_VARIANT regardless of the type of the SAFEARRAY meant to say SAFEARRAY is set to array of VT_VARIANT e.g. ( VT_ARRAY | VT_VARIANT ) ___ LibreOffice mailing