Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)
I've commited this to 3.4 http://cgit.freedesktop.org/libreoffice/components/commit/?h=libreoffice-3-4id=ab802aee181ca6df397ca53e461d5f53808cef9d and like the subject says. one more needed for 3.4.4 Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)
On 10/27/2011 11:58 AM, Noel Power wrote: and like the subject says. one more needed for 3.4.4 With the same caveat like the other reviewers -- I'm rather illiterate with COM/OLE -- the change does look reasonable to me. So go ahead! Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)
On Wed, 2011-10-26 at 19:49 +0200, Michael Stahl wrote: On 26/10/11 18:55, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fcb94311fd7dd40c05ca132e3a30a888316cbbe .. have no clue when it comes to OLE automation, but after reading the bug your patch looks like it could help and even if not it doesn't break anything that isn't already broken :) The code is similarly opaque to me :-) if you're happy it is tested and works I don't know that we'll find any more competent reviewers. It is slightly concerning to me that this method has seemingly been using a SAFEARRAY since 2000: commit 5840ee38df56933c54dcaaa6ec4e4ba01f173f6c Author: Joachim Lingner j...@openoffice.org Date: Thu Oct 12 12:15:53 2000 + Sequences can now be converted into SAFEARRAYs of a specified type. SequenceSequence.. etc. can be converted into SAFEARRAY with multiple dimensions. Which doesn't tally well with talk of this working in 3.2 and breaking in 3.3 / 3.4 ... but if it improves life markedly and the users are happy ... :-) ATB, Michael -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)
On 26/10/11 20:26, Michael Meeks wrote: The code is similarly opaque to me :-) if you're happy it is tested and works I don't know that we'll find any more competent reviewers. It is slightly concerning to me that this method has seemingly been using a SAFEARRAY since 2000: SAFEARRAY is not the problem, it is the fact type of a variant containing a SAFEARRAY is set to VT_VARIANT regardless of the type of the SAFEARRAY, the following commit is the cause commit 627f5293a95a31a3b90632c01116eeb8c78829d5 Author: Mikhail Voytenko m...@openoffice.org Date: Thu Jul 8 21:33:48 2010 +0200 mib17: #162917# let basic byte use one byte, let olebridge convert sequence to safearray correctly ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW-3-4-4] )one more needed) fix ole automation bridge handling of SAFEARRAY (fdo#38441)
On 26/10/11 20:43, Noel Power wrote: type of a variant containing a SAFEARRAY is set to VT_VARIANT regardless of the type of the SAFEARRAY meant to say SAFEARRAY is set to array of VT_VARIANT e.g. ( VT_ARRAY | VT_VARIANT ) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
