Re: [Libreoffice] [REVIEWED] + Cherrypick request for 3.4.2

2011-07-12 Thread Muthu Subramanian K
hmm...there are 2 things in pie chart - one to show the values and second to show the percentages. (the user can choose to display both). While the data store in impress doesn't seem to hold much of the formatting information. I assumed it is the responsibility of the importer (in this case pptx),

[Libreoffice] [REVIEWED] + Cherrypick request for 3.4.2

2011-07-11 Thread Michael Meeks
Hi Muthu, On Thu, 2011-07-07 at 18:39 +0530, Muthu Subramanian K wrote: It would be great if somebody can review and cherry pick these fixes: http://cgit.freedesktop.org/libreoffice/filters/commit/?id=8faf3f2e8b085285b51bd6a993efd2c9f68714d1 This sort of stuff: +if( bShowValue +

Re: [Libreoffice] [REVIEWED] + Cherrypick request for 3.4.2

2011-07-11 Thread Muthu Subramanian K
Hi, Thank you! This sort of stuff: +if( bShowValue +!bShowPercent rTypeInfo.meTypeCategory == TYPECATEGORY_PIE +rDataLabel.maNumberFormat.maFormatCode.indexOfAsciiL(%, 1) = 0 ) +{ +bShowValue = false; +bShowPercent = true; +}

Re: [Libreoffice] [REVIEWED] + Cherrypick request for 3.4.2

2011-07-11 Thread Michael Meeks
On Mon, 2011-07-11 at 17:21 +0530, Muthu Subramanian K wrote: makes me wonder if we don't want that in our own pie chart implementation rather than in the filter though ... :-) But I picked it for -3-4. Sorry, but I didn't understand this. Did you mean the filter code (oox), please?