Re: [Libreoffice] Duplicate code: libs-core/framework/test/typecfg/cfgview.cxx

2011-06-23 Thread Caolán McNamara 
On Tue, 2011-06-14 at 14:13 +0100, Caolán McNamara wrote:
 Yeah, that framework/test dir isn't built. I'm unconvinced that its
 recoverable to turn into a modern cppunit test. I suggest you go ahead
 and git rm -rf that dir and just ditch it.

I removed that dir now in framework.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Duplicate code: libs-core/framework/test/typecfg/cfgview.cxx

2011-06-14 Thread Caolán McNamara 
On Thu, 2011-06-02 at 22:07 +0200, Chr. Rossmanith wrote:
 Hi,
 
 while waiting for a successful build I had a look at cfgview.cxx which 
 has two very similar methods 
 CFGView::impl_generateFilter{Modul}?ListHTML(). Shall I continue or is 
 it only a test?

Yeah, that framework/test dir isn't built. I'm unconvinced that its
recoverable to turn into a modern cppunit test. I suggest you go ahead
and git rm -rf that dir and just ditch it.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Duplicate code: libs-core/framework/test/typecfg/cfgview.cxx

2011-06-10 Thread Michael Meeks 

On Thu, 2011-06-02 at 22:07 +0200, Chr. Rossmanith wrote:
 CFGView::impl_generateFilter{Modul}?ListHTML(). Shall I continue or is 
 it only a test?

I guess I'd look at the makefiles to see if it is linked into the main
binary at all (apparently a git grep for cfgview show it is not).

So I'd abandon it; much of that test code is not run, used, and much of
it doesn't compile either :-)

Thanks,

Michael.

-- 
 michael.me...@novell.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Duplicate code: libs-core/framework/test/typecfg/cfgview.cxx

2011-06-03 Thread Chr. Rossmanith 

Hi,

binfilter can be omitted from simian?

Christina


Am 02.06.2011 22:07, schrieb Chr. Rossmanith:

Hi,

while waiting for a successful build I had a look at cfgview.cxx which 
has two very similar methods 
CFGView::impl_generateFilter{Modul}?ListHTML(). Shall I continue or is 
it only a test?


Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice