Re: [Libreoffice] PATCH - change default KDE from 3 to 4

2010-10-26 Thread Sebastian Spaeth
On Mon, 25 Oct 2010 13:46:25 +0100, Michael Meeks wrote: ---disable-kde4 +--enable-kde4 so - really I would like to avoid this. This fix is better than nothing. Defaulting to qt3 confused many (who rightfully think they have kde-dev installed). I agree that auto-detection is the

Re: [Libreoffice] [PATCH] - change default KDE from 3 to 4

2010-10-25 Thread Thorsten Behrens
Wols Lists wrote: Resubmit with brackets in subject - I think I need them for the patchmeister to pick up? Thanks a lot for the fix, pushed! -- Thorsten pgpvML4yXRas7.pgp Description: PGP signature ___ LibreOffice mailing list

Re: [Libreoffice] PATCH - change default KDE from 3 to 4

2010-10-25 Thread Rene Engelhard
Hi, On Mon, Oct 25, 2010 at 01:46:25PM +0100, Michael Meeks wrote: This patch (in the top level build dir) makes the development system compile with KDE4 switched on and KDE3 switched off. That sounds reasonable. ACK. My ideal is to have neither an enable or disable flag for

Re: [Libreoffice] PATCH - change default KDE from 3 to 4

2010-10-25 Thread Norbert Thiebaud
On Mon, Oct 25, 2010 at 7:46 AM, Michael Meeks michael.me...@novell.com wrote: Hi Wols, On Fri, 2010-10-22 at 23:29 +0100, Wols Lists wrote: This patch (in the top level build dir) makes the development system compile with KDE4 switched on and KDE3 switched off.        That sounds

Re: [Libreoffice] PATCH - change default KDE from 3 to 4

2010-10-25 Thread Michael Meeks
On Mon, 2010-10-25 at 15:37 +0200, Rene Engelhard wrote: My ideal is to have neither an enable or disable flag for any of the optional pieces: KDE3 / KDE4 / GNOME etc. - but have a default of auto-detection, so we only build if they are there. I disagree. Even if you had

Re: [Libreoffice] PATCH - change default KDE from 3 to 4

2010-10-25 Thread Wols Lists
On 25/10/10 17:19, Michael Meeks wrote: On Mon, 2010-10-25 at 15:37 +0200, Rene Engelhard wrote: My ideal is to have neither an enable or disable flag for any of the optional pieces: KDE3 / KDE4 / GNOME etc. - but have a default of auto-detection, so we only build if they are there. I