Re: [Libreoffice] SCID_NEWDOCUMENT
On Fri, 2011-01-28 at 21:22 +, Nigel Hawkins wrote: On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx itself. Does that mean that the constant can be removed (and probably a lot of similar constants too)? As I discovered earlier today, opengrok doesn't index binfilter. So it might get used in there (though if it does, it may well duplicate the definition there). Kohei suggested using git grep (or g grep) to look for it instead. He binfilter is skipped for the simple reason that it generates quite a lot of noise in general when you look for code bits as almost everything there is a copy. I don't know if any other modules are skipped by opengrok. No, no other module is skipped. Regards, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SCID_NEWDOCUMENT
Hi Christina, On Fri, 2011-01-28 at 22:25 +0100, Christina Roßmanith wrote: and how could I find out if a constant like SCID_NEWDOCUMENT is still referenced? Or does that require some more experience with the code base? In general running 'g grep' in the top-level is reliable; although I suppose some pre-processor pasting might be used for some symbols that may hide things, but - be bold - we can always revert things that break the build later :-) Thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SCID_NEWDOCUMENT
Hi, I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx http://opengrok.go-oo.org/xref/calc/sc/inc/rechead.hxx itself. Does that mean that the constant can be removed (and probably a lot of similar constants too)? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SCID_NEWDOCUMENT
Hi Christina, On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: Hi, I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx itself. Does that mean that the constant can be removed (and probably a lot of similar constants too)? Probably yes. Those constants are likely a leftover of the old, binary staroffice filters that are now superseded by the binfilter. We can't remove all of them yet as some of them are still referenced (only by the DDE data transfer code), but we can probably remove the majority of them. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] SCID_NEWDOCUMENT
Hi Kohei, and how could I find out if a constant like SCID_NEWDOCUMENT is still referenced? Or does that require some more experience with the code base? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SCID_NEWDOCUMENT
On Fri, 2011-01-28 at 21:59 +0100, Christina Roßmanith wrote: I'm still translating comments and came across a constant named SCID_NEWDOCUMENT. When I asked opengrok the only place where this constant was found was the file rechead.hxx itself. Does that mean that the constant can be removed (and probably a lot of similar constants too)? As I discovered earlier today, opengrok doesn't index binfilter. So it might get used in there (though if it does, it may well duplicate the definition there). Kohei suggested using git grep (or g grep) to look for it instead. I don't know if any other modules are skipped by opengrok. Nigel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] SCID_NEWDOCUMENT
On Fri, 2011-01-28 at 22:35 +0100, Christina Roßmanith wrote: Hi Nigel, thank you for your hint. Now I've found a file in filters where the constant is referenced (and a lot of dead code too :-) ). Yup, it's still referenced; however, binfilter also has its own definition of SCID_NEWDOCUMENT in binfilter/inc/bf_sc/rechead.hxx, so we can still safely remove the one in sc/inc/rechead.hxx without affecting binfilter. The same applies to other SCID_* too. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
