Re: [Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-04 Thread Christian Lohmaier
Hi Caolán, *, On Thu, Feb 2, 2012 at 11:10 AM, Caolán McNamara caol...@redhat.com wrote: On Thu, 2012-02-02 at 09:26 +0100, Jan Holesovsky wrote: On 2012-02-01 at 22:21 -0500, Kohei Yoshida wrote: http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 [...] This is

Re: [Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-02 Thread Jan Holesovsky
Hi Kohei, On 2012-02-01 at 22:21 -0500, Kohei Yoshida wrote: Looking at this http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 We still have some code left in sc that appears to handle import of the now defunct StarCalc binary file format. I believe this

Re: [Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-02 Thread Caolán McNamara
On Thu, 2012-02-02 at 09:26 +0100, Jan Holesovsky wrote: Hi Kohei, On 2012-02-01 at 22:21 -0500, Kohei Yoshida wrote: Looking at this http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 We still have some code left in sc that appears to handle import of

Re: [Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-02 Thread Eike Rathke
Hi, On Thursday, 2012-02-02 10:10:08 +, Caolán McNamara wrote: That said, there appears to be a specific quirk/bug with Star Calc 1.0 format, calc_StarCalc_10.xcu still has com.sun.star.comp.calc.FormatDetector as its DetectService instead of com.sun.star.comp.sfx2.BinaryFormatDetector

Re: [Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-02 Thread Kohei Yoshida
Hi Caolan, On Thu, 2012-02-02 at 10:10 +, Caolán McNamara wrote: binfilter has its *own* typedetection implementation, i.e. binfilter/binfilterdetect/source/bindetect BinFilterDetect::detect so, in theory at least, it self-contains what it needs to detect the formats it imports. So you

Re: [Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-02 Thread Kohei Yoshida
On Thu, 2012-02-02 at 11:01 -0500, Kohei Yoshida wrote: Hi Caolan, On Thu, 2012-02-02 at 10:10 +, Caolán McNamara wrote: binfilter has its *own* typedetection implementation, i.e. binfilter/binfilterdetect/source/bindetect BinFilterDetect::detect so, in theory at least, it

[Libreoffice] StarCalc 1.0 to 5.0 filters

2012-02-01 Thread Kohei Yoshida
Hi there, Looking at this http://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/docsh.cxx#162 We still have some code left in sc that appears to handle import of the now defunct StarCalc binary file format. I believe this stuff has been moved to binfilter so I guess it's okay to