Re: [Libreoffice] code simplification: please logic review, to be sure

2011-08-27 Thread Eike Rathke
Hi Pierre-André, On Friday, 2011-08-26 22:23:07 +0200, Pierre-André Jacquod wrote: > But this basically, this just ensure that the return value is not > NULL (comparing the pointer SwFrm* with 0 ) > > So I though the final version to be: > if( 0 != ( pONd = aIdx.GetNode().GetOLENode() ) && >

[Libreoffice] code simplification: please logic review, to be sure

2011-08-26 Thread Pierre-André Jacquod
Hello, I am trying to wipe some unneeded calls and I see the following: while( ) { - SwFrm* pFrm; if( 0 != ( pONd = aIdx.GetNode().GetOLENode() ) && aName.Equals( pONd->GetChartTblName() ) && 0 != ( pFrm = pONd->getLayoutFrm( rVSh.GetLayout