Re: [Libreoffice] rtl::O[U]StringBuffer now has a remove method

2011-07-04 Thread Lubos Lunak
On Saturday 02 of July 2011, Caolán McNamara wrote: On Fri, 2011-07-01 at 17:53 +0200, Lubos Lunak wrote: On Thursday 30 of June 2011, Caolán McNamara wrote: Do we have a preference ?, I'm easy either way. Since nobody seems to have a preference, I'd like to point out that also

Re: [Libreoffice] rtl::O[U]StringBuffer now has a remove method

2011-07-02 Thread Caolán McNamara
On Fri, 2011-07-01 at 17:53 +0200, Lubos Lunak wrote: On Thursday 30 of June 2011, Caolán McNamara wrote: Do we have a preference ?, I'm easy either way. Since nobody seems to have a preference, I'd like to point out that also std::string uses start+len (even though there one could expect

Re: [Libreoffice] rtl::O[U]StringBuffer now has a remove method

2011-07-01 Thread Lubos Lunak
On Thursday 30 of June 2011, Caolán McNamara wrote: On Thu, 2011-06-30 at 13:46 +0200, Lubos Lunak wrote: O[U]StringBuffer don't have any other range function, but O[U]String uses start+len for such cases (copy, replaceAt), so this seems inconsistent. hmm, yeah, that's true. java doesn't

[Libreoffice] rtl::O[U]StringBuffer now has a remove method

2011-06-30 Thread Caolán McNamara
I've added a remove method to the O[U]StringBuffers to make it easy to remove text from them without painful assembly of a new one by copying segments out of an old one. These StringBuffers were originally modelled after the Java equivalents. Since the sal ones were written Java added delete

Re: [Libreoffice] rtl::O[U]StringBuffer now has a remove method

2011-06-30 Thread Caolán McNamara
On Thu, 2011-06-30 at 13:46 +0200, Lubos Lunak wrote: It takes start position and end position in usual half-open [x,y) style, not start position and length though this is clearly the same for an x of 0 Usual style in what way? Well, usual in the if you're going to use start and end