Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-21 Thread Michael Meeks

On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote:
  On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote:
WaE: add missing sal and cppunit dependencies causing tinderbox 
  failure
  ...
  Yes, as you say - it was for the unit test that was failing to compile
  without sal / cppunit :-)
 
 What puzzled me was the WaE prefix.

Ah - I always read 'WaE' as Warnings and Errors ;-) but if you suggest
it means Warnings -as- Errors ;-) then that'd be wrong I guess.

:-)

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-21 Thread Stephan Bergmann

On 02/21/2012 09:21 AM, Michael Meeks wrote:

On Mon, 2012-02-20 at 21:24 +0100, Stephan Bergmann wrote:

On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote:

   WaE: add missing sal and cppunit dependencies causing tinderbox failure

...
Yes, as you say - it was for the unit test that was failing to compile
without sal / cppunit :-)


What puzzled me was the WaE prefix.


Ah - I always read 'WaE' as Warnings and Errors ;-) but if you suggest
it means Warnings -as- Errors ;-) then that'd be wrong I guess.


Yes, I always took it to mean the latter.  Anyway, reverted the commit 
now, as it is obsolete and only addressed the symptoms rather than the 
cause.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-20 Thread Stephan Bergmann

On 02/18/2012 04:29 PM, Michael Meeks wrote:

  officecfg/prj/build.lst |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8c67428341d42ada42f9186bbfe3d6f25a0edaef
Author: Michael Meeksmichael.me...@suse.com
Date:   Sat Feb 18 15:28:35 2012 +

 WaE: add missing sal and cppunit dependencies causing tinderbox failure

diff --git a/officecfg/prj/build.lst b/officecfg/prj/build.lst
index f4a9142..2f05a62 100644
--- a/officecfg/prj/build.lst
+++ b/officecfg/prj/build.lst
@@ -1,2 +1,2 @@
-oc  officecfg   :TRANSLATIONS:translations soltools solenv LIBXSLT:libxslt 
NULL
+oc  officecfg   :TRANSLATIONS:translations soltools solenv LIBXSLT:libxslt 
sal CPPUNIT:cppunit NULL
  oc  officecfg\prj nmake - all oc_prj   NULL


Michael, do you remember the exact reason why you added these 
dependencies?  They probably got irrelevant again with Norbert's later 
e69b8a758061c695b4daa9029f58a1cd7f715ef6 (disabled officecfg unittest 
due to dependencies problems)?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-20 Thread Michael Meeks

On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote:
   WaE: add missing sal and cppunit dependencies causing tinderbox failure
...
  @@ -1,2 +1,2 @@
  -oc  officecfg   :TRANSLATIONS:translations soltools solenv 
  LIBXSLT:libxslt NULL
  +oc  officecfg   :TRANSLATIONS:translations soltools solenv 
  LIBXSLT:libxslt sal CPPUNIT:cppunit NULL
oc  officecfg\prj nmake - all oc_prj   NULL
 
 Michael, do you remember the exact reason why you added these 
 dependencies?  They probably got irrelevant again with Norbert's later 
 e69b8a758061c695b4daa9029f58a1cd7f715ef6 (disabled officecfg unittest 
 due to dependencies problems)?

Yes, as you say - it was for the unit test that was failing to compile
without sal / cppunit :-)

HTH,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-commits] .: WaE: add missing sal and cppunit dependencies causing tinderbox failure

2012-02-20 Thread Stephan Bergmann

On 02/20/2012 08:52 PM, Michael Meeks wrote:


On Mon, 2012-02-20 at 17:23 +0100, Stephan Bergmann wrote:

  WaE: add missing sal and cppunit dependencies causing tinderbox failure

...

@@ -1,2 +1,2 @@
-oc  officecfg   :TRANSLATIONS:translations soltools solenv LIBXSLT:libxslt 
NULL
+oc  officecfg   :TRANSLATIONS:translations soltools solenv LIBXSLT:libxslt 
sal CPPUNIT:cppunit NULL
   oc  officecfg\prj nmake - all oc_prj   NULL


Michael, do you remember the exact reason why you added these
dependencies?  They probably got irrelevant again with Norbert's later
e69b8a758061c695b4daa9029f58a1cd7f715ef6 (disabled officecfg unittest
due to dependencies problems)?


Yes, as you say - it was for the unit test that was failing to compile
without sal / cppunit :-)


What puzzled me was the WaE prefix.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice