Re: [Libreoffice-commits] core.git: accessibility/source basctl/source basic/source canvas/source chart2/source comphelper/source dbaccess/source framework/source include/o3tl include/sfx2 sc/inc sc/s

2015-08-29 Thread Noel Grandin
Use a configure.ac check?
On Sun, 30 Aug 2015 at 01:26, Thorsten Behrens 
wrote:

> Daniel Robertson wrote:
> > --- a/include/o3tl/cow_wrapper.hxx
> > +++ b/include/o3tl/cow_wrapper.hxx
> > @@ -199,7 +199,10 @@ int cow_wrapper_client::queryUnmodified() const
> >  void release()
> >  {
> >  if( m_pimpl &&
> !MTPolicy::decrementCount(m_pimpl->m_ref_count) )
> > -boost::checked_delete(m_pimpl), m_pimpl = nullptr;
> > +{
> > +delete m_pimpl;
> > +m_pimpl = nullptr;
> > +}
> >  }
> >
> Hi Stephan, all,
>
> Daniel reduced boost dependencies a bit with the above, nominally w/o
> losing functionality.
>
> I find -Werror=delete-incomplete for gcc and -Wdelete-incomplete for
> clang - that's supposedly a much more universal way of catching the
> issues checked_delete was there for?
>
> What's the best way to enable that in tinderboxes, I'm afraid
> gbuild-wide enabling might fail on older compilers?
>
> Cheers,
>
> -- Thorsten
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-commits] core.git: accessibility/source basctl/source basic/source canvas/source chart2/source comphelper/source dbaccess/source framework/source include/o3tl include/sfx2 sc/inc sc/s

2015-08-29 Thread Thorsten Behrens
Daniel Robertson wrote:
> --- a/include/o3tl/cow_wrapper.hxx
> +++ b/include/o3tl/cow_wrapper.hxx
> @@ -199,7 +199,10 @@ int cow_wrapper_client::queryUnmodified() const
>  void release()
>  {
>  if( m_pimpl && !MTPolicy::decrementCount(m_pimpl->m_ref_count) )
> -boost::checked_delete(m_pimpl), m_pimpl = nullptr;
> +{
> +delete m_pimpl;
> +m_pimpl = nullptr;
> +}
>  }
>
Hi Stephan, all,

Daniel reduced boost dependencies a bit with the above, nominally w/o
losing functionality.

I find -Werror=delete-incomplete for gcc and -Wdelete-incomplete for
clang - that's supposedly a much more universal way of catching the
issues checked_delete was there for?

What's the best way to enable that in tinderboxes, I'm afraid
gbuild-wide enabling might fail on older compilers?

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice