[Libreoffice-commits] core.git: bridges/source include/sal

2022-03-08 Thread Stephan Bergmann (via logerrit)
 bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx |3 ---
 include/sal/log-areas.dox|1 -
 2 files changed, 4 deletions(-)

New commits:
commit 42b37ba1d19a0543b7edda2c9d8bbb9b80507a7c
Author: Stephan Bergmann 
AuthorDate: Tue Mar 8 09:25:52 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Mar 8 13:57:22 2022 +0100

Drop some debug code

...that had been introduced with 7e8e85adbee73346403c364326544487677cd5c6 
"Add
codeSnippet debugging output when dbglevel>1" and reinforced with
6f121860d0537060084278da11842732a748d6b7 "tdf#130924 replace debugging 
printf
calls with SAL_INFO/SAL_WARN"

Change-Id: I9529bfdedd3d1a3dd623fdb28e01d6bd96c92d97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131169
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
index 48d8d174fb6a..f400c766a2e6 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
@@ -442,9 +442,6 @@ static unsigned char * codeSnippet( unsigned char * code,
 // jmpq *%r11
 *reinterpret_cast( code + 20 ) = 0x00e3ff49;
 
-SAL_INFO("bridges.debug", "==> codeSnippet, functionIndex=" << 
nFunctionIndex
-<< (bHasHiddenParam ? "|0x8000":"") << ", vtableOffset=" << 
nVtableOffset);
-
 return code + codeSnippetSize;
 }
 
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index b0e10c48fa2d..7d61cfd3d3cd 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -47,7 +47,6 @@ certain functionality.
 @li @c bridges
 @li @c bridges.ios
 @li @c bridges.osx
-@li @c bridges.debug
 
 @section canvas
 


[Libreoffice-commits] core.git: bridges/source include/sal

2022-03-04 Thread pragat-pandya (via logerrit)
 bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx |7 ++-
 include/sal/log-areas.dox|1 +
 2 files changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 6f121860d0537060084278da11842732a748d6b7
Author: pragat-pandya 
AuthorDate: Tue Mar 1 16:56:06 2022 +0530
Commit: Luboš Luňák 
CommitDate: Sat Mar 5 08:35:23 2022 +0100

tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARN

Change-Id: Iaef5eec6508d031ab711a71c0d8ecebb18112ef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130764
Tested-by: Luboš Luňák 
Reviewed-by: Luboš Luňák 

diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
index de393582f99a..48d8d174fb6a 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
@@ -442,11 +442,8 @@ static unsigned char * codeSnippet( unsigned char * code,
 // jmpq *%r11
 *reinterpret_cast( code + 20 ) = 0x00e3ff49;
 
-#if OSL_DEBUG_LEVEL > 1
-fprintf(stderr,
-"==> codeSnippet, functionIndex=%d%s, vtableOffset=%d\n",
-nFunctionIndex, (bHasHiddenParam ? "|0x8000":""), 
nVtableOffset);
-#endif
+SAL_INFO("bridges.debug", "==> codeSnippet, functionIndex=" << 
nFunctionIndex
+<< (bHasHiddenParam ? "|0x8000":"") << ", vtableOffset=" << 
nVtableOffset);
 
 return code + codeSnippetSize;
 }
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 7d61cfd3d3cd..b0e10c48fa2d 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -47,6 +47,7 @@ certain functionality.
 @li @c bridges
 @li @c bridges.ios
 @li @c bridges.osx
+@li @c bridges.debug
 
 @section canvas
 


[Libreoffice-commits] core.git: bridges/source include/sal

2013-12-23 Thread Tor Lillqvist
 bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx |   30 +++
 include/sal/log-areas.dox|7 +++-
 2 files changed, 24 insertions(+), 13 deletions(-)

New commits:
commit 86a372ade0b7d416d4ff97a94ea350f56610da61
Author: Tor Lillqvist t...@collabora.com
Date:   Mon Dec 23 21:12:05 2013 +0200

More informative logging in codeSnippet()

Change-Id: I6909ed60b39a65e6a6464427b2f839aa2bff3863

diff --git a/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
index 4fe5377..52911af 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
@@ -361,6 +361,8 @@ extern C typedef void (*PrivateSnippetExecutor)();
 int const codeSnippetSize = 16;
 
 unsigned char * codeSnippet(
+const typelib_InterfaceTypeDescription *type,
+const typelib_TypeDescription *member,
 unsigned char * code, sal_Int32 functionIndex, sal_Int32 vtableOffset,
 typelib_TypeDescriptionReference * pReturnTypeRef)
 {
@@ -427,18 +429,19 @@ unsigned char * codeSnippet(
 = ((unsigned char *) exec) - p - sizeof (sal_Int32);
 p += sizeof (sal_Int32);
 OSL_ASSERT(p - code = codeSnippetSize);
-#if OSL_DEBUG_LEVEL  1
-fprintf(stderr,
-== codeSnippet to %s, functionIndex=%lu%s, 
vtableOffset=%SAL_PRIdINT32\n,
-(exec == privateSnippetExecutorGeneral ? General :
- (exec == privateSnippetExecutorVoid ? Void :
-  (exec == privateSnippetExecutorHyper ? Hyper :
-   (exec == privateSnippetExecutorFloat ? Float :
-(exec == privateSnippetExecutorDouble ? Double :
- (exec == privateSnippetExecutorClass ? Class :
-  ???)),
-(functionIndex  ~0x8000), (functionIndex  0x8000) ? 
|0x8000:, vtableOffset);
-#endif
+
+SAL_INFO( bridges.osx, codeSnippet(
+   OUString(type-aBase.pTypeName)  ::  
OUString(member-pTypeName)  ): [
+   (functionIndex  ~0x8000)  ((functionIndex  
0x8000) ? |0x8000:)  ,  vtableOffset  ,
+   (exec == privateSnippetExecutorGeneral ? General :
+  (exec == privateSnippetExecutorVoid ? Void :
+   (exec == privateSnippetExecutorHyper ? Hyper :
+(exec == privateSnippetExecutorFloat ? Float :
+ (exec == privateSnippetExecutorDouble ? Double :
+  (exec == privateSnippetExecutorClass ? Class :
+   ???))
+   ]=  (void *)(code + codeSnippetSize) );
+
 return code + codeSnippetSize;
 }
 
@@ -484,6 +487,7 @@ unsigned char * 
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
 // Getter:
 (s++)-fn = code;
 code = codeSnippet(
+type, member,
 code, functionOffset++, vtableOffset,
 reinterpret_cast typelib_InterfaceAttributeTypeDescription * 
(
 member)-pAttributeTypeRef);
@@ -494,6 +498,7 @@ unsigned char * 
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
 {
 (s++)-fn = code;
 code = codeSnippet(
+type, member,
 code, functionOffset++, vtableOffset,
 0 /* indicates VOID */);
 }
@@ -502,6 +507,7 @@ unsigned char * 
bridges::cpp_uno::shared::VtableFactory::addLocalFunctions(
 case typelib_TypeClass_INTERFACE_METHOD:
 (s++)-fn = code;
 code = codeSnippet(
+type, member,
 code, functionOffset++, vtableOffset,
 reinterpret_cast typelib_InterfaceMethodTypeDescription * (
 member)-pReturnTypeRef);
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 5168e81..a53727b 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -40,6 +40,12 @@ certain functionality.
 @li @c basic
 @li @c basic.sbx
 
+@section bridges
+
+@li @c bridges
+@li @c bridges.ios
+@li @c bridges.osx
+
 @section canvas
 
 @li @c canvas
@@ -426,7 +432,6 @@ certain functionality.
 @li @c avmedia
 @li @c basebmp
 @li @c binaryurp
-@li @c bridges
 @li @c configmgr
 @li @c cppcanvas
 @li @c cppcanvas.emf
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits