compilerplugins/clang/unusedfields.only-used-in-constructor.results |   78 
++++------
 compilerplugins/clang/unusedfields.readonly.results                 |   16 --
 compilerplugins/clang/unusedfields.untouched.results                |   42 
++---
 compilerplugins/clang/unusedfields.writeonly.results                |   28 +--
 include/vcl/accel.hxx                                               |    1 
 sc/qa/extras/anchor.cxx                                             |   15 -
 sc/qa/unit/scshapetest.cxx                                          |   15 -
 vcl/source/window/accel.cxx                                         |    2 
 vcl/source/window/accmgr.cxx                                        |    4 
 9 files changed, 76 insertions(+), 125 deletions(-)

New commits:
commit b83b4f967f8cbee208e44600821aa1a5518e34ac
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Thu Feb 27 09:20:25 2020 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Thu Feb 27 09:52:09 2020 +0100

    loplugin:unusedfields
    
    Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git 
a/compilerplugins/clang/unusedfields.only-used-in-constructor.results 
b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index 069b0766f54f..b02a68e3ae25 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -9,9 +9,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
     libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-    libvlc_event_t::(anonymous) padding struct (anonymous struct at 
/home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+    libvlc_event_t::(anonymous) padding struct (anonymous struct at 
/media/disk2/libo4/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-    libvlc_event_t u union (anonymous union at 
/home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+    libvlc_event_t u union (anonymous union at 
/media/disk2/libo4/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
     libvlc_track_description_t psz_name char *
 basegfx/source/polygon/b2dtrapezoid.cxx:205
@@ -31,17 +31,17 @@ chart2/source/controller/inc/dlg_View3D.hxx:44
 chart2/source/controller/inc/RangeSelectionListener.hxx:63
     chart::RangeSelectionListener m_aControllerLockGuard class 
chart::ControllerLockGuardUNO
 connectivity/source/commontools/RowFunctionParser.cxx:372
-    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
unaryFunction ::boost::spirit::rule<ScannerT>
+    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
unaryFunction ::boost::spirit::classic::rule<ScannerT>
 connectivity/source/commontools/RowFunctionParser.cxx:373
-    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
assignment ::boost::spirit::rule<ScannerT>
+    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
assignment ::boost::spirit::classic::rule<ScannerT>
 connectivity/source/commontools/RowFunctionParser.cxx:374
-    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
argument ::boost::spirit::rule<ScannerT>
+    connectivity::(anonymous namespace)::ExpressionGrammar::definition integer 
::boost::spirit::classic::rule<ScannerT>
 connectivity/source/commontools/RowFunctionParser.cxx:374
-    connectivity::(anonymous namespace)::ExpressionGrammar::definition integer 
::boost::spirit::rule<ScannerT>
+    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
argument ::boost::spirit::classic::rule<ScannerT>
 connectivity/source/commontools/RowFunctionParser.cxx:375
-    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
orExpression ::boost::spirit::rule<ScannerT>
+    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
andExpression ::boost::spirit::classic::rule<ScannerT>
 connectivity/source/commontools/RowFunctionParser.cxx:375
-    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
andExpression ::boost::spirit::rule<ScannerT>
+    connectivity::(anonymous namespace)::ExpressionGrammar::definition 
orExpression ::boost::spirit::classic::rule<ScannerT>
 connectivity/source/drivers/evoab2/EApi.h:122
     (anonymous) address_format char *
 connectivity/source/drivers/evoab2/EApi.h:126
@@ -308,10 +308,10 @@ include/sfx2/msg.hxx:144
     SfxType14 pType const std::type_info *
 include/sfx2/msg.hxx:144
     SfxType14 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:145
-    SfxType16 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:145
     SfxType16 aAttrib struct SfxTypeAttrib [16]
+include/sfx2/msg.hxx:145
+    SfxType16 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:145
     SfxType16 nAttribs sal_uInt16
 include/sfx2/msg.hxx:145
@@ -319,11 +319,11 @@ include/sfx2/msg.hxx:145
 include/sfx2/msg.hxx:146
     SfxType17 pType const std::type_info *
 include/sfx2/msg.hxx:146
-    SfxType17 nAttribs sal_uInt16
+    SfxType17 aAttrib struct SfxTypeAttrib [17]
 include/sfx2/msg.hxx:146
     SfxType17 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:146
-    SfxType17 aAttrib struct SfxTypeAttrib [17]
+    SfxType17 nAttribs sal_uInt16
 include/sfx2/msg.hxx:147
     SfxType23 nAttribs sal_uInt16
 include/sfx2/msg.hxx:147
@@ -334,8 +334,6 @@ include/sfx2/msg.hxx:147
     SfxType23 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/svl/ondemand.hxx:55
     OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
-include/svtools/valueset.hxx:199
-    ValueSet maTimer class Timer
 include/svx/ClassificationDialog.hxx:31
     svx::ClassificationDialog m_bPerParagraph const _Bool
 include/svx/imapdlg.hxx:91
@@ -426,6 +424,8 @@ pyuno/source/module/pyuno_impl.hxx:323
     pyuno::stRuntimeImpl ob_base PyObject
 reportdesign/source/core/api/ReportDefinition.cxx:250
     reportdesign::(anonymous namespace)::OStyle m_aSize awt::Size
+reportdesign/source/filter/xml/xmlExport.cxx:1241
+      sal_Int32
 sal/qa/osl/condition/osl_Condition.cxx:72
     osl_Condition::ctors bRes1 _Bool
 sal/qa/osl/condition/osl_Condition.cxx:202
@@ -637,17 +637,17 @@ slideshow/source/engine/opengl/TransitionImpl.hxx:300
 slideshow/source/engine/opengl/TransitionImpl.hxx:301
     Vertex texcoord glm::vec2
 slideshow/source/engine/smilfunctionparser.cxx:491
-    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
multiplicativeExpression ::boost::spirit::rule<ScannerT>
+    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
multiplicativeExpression ::boost::spirit::classic::rule<ScannerT>
 slideshow/source/engine/smilfunctionparser.cxx:492
-    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
unaryExpression ::boost::spirit::rule<ScannerT>
+    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
unaryExpression ::boost::spirit::classic::rule<ScannerT>
 slideshow/source/engine/smilfunctionparser.cxx:493
-    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
basicExpression ::boost::spirit::rule<ScannerT>
+    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
basicExpression ::boost::spirit::classic::rule<ScannerT>
 slideshow/source/engine/smilfunctionparser.cxx:494
-    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
unaryFunction ::boost::spirit::rule<ScannerT>
+    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
unaryFunction ::boost::spirit::classic::rule<ScannerT>
 slideshow/source/engine/smilfunctionparser.cxx:495
-    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
binaryFunction ::boost::spirit::rule<ScannerT>
+    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
binaryFunction ::boost::spirit::classic::rule<ScannerT>
 slideshow/source/engine/smilfunctionparser.cxx:496
-    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
identifier ::boost::spirit::rule<ScannerT>
+    slideshow::internal::(anonymous namespace)::ExpressionGrammar::definition 
identifier ::boost::spirit::classic::rule<ScannerT>
 starmath/inc/view.hxx:216
     SmViewShell maGraphicController const class SmGraphicController
 starmath/source/accessibility.hxx:268
@@ -664,32 +664,30 @@ svl/source/crypto/cryptosign.cxx:284
     (anonymous namespace)::PKIStatusInfo statusString SECItem
 svl/source/crypto/cryptosign.cxx:285
     (anonymous namespace)::PKIStatusInfo failInfo SECItem
-svtools/source/control/valueimp.hxx:62
-    ValueSetItem mpData void *
 svx/inc/GalleryControl.hxx:42
     svx::sidebar::GalleryControl mpGallery class Gallery *
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1083
-    (anonymous namespace)::ExpressionGrammar::definition 
multiplicativeExpression ::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition 
multiplicativeExpression ::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1084
-    (anonymous namespace)::ExpressionGrammar::definition unaryExpression 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition unaryExpression 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1085
-    (anonymous namespace)::ExpressionGrammar::definition basicExpression 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition basicExpression 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1086
-    (anonymous namespace)::ExpressionGrammar::definition unaryFunction 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition unaryFunction 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1087
-    (anonymous namespace)::ExpressionGrammar::definition binaryFunction 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition binaryFunction 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1088
-    (anonymous namespace)::ExpressionGrammar::definition ternaryFunction 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition ternaryFunction 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1089
-    (anonymous namespace)::ExpressionGrammar::definition funcRef_decl 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition funcRef_decl 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1090
-    (anonymous namespace)::ExpressionGrammar::definition functionReference 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition functionReference 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1091
-    (anonymous namespace)::ExpressionGrammar::definition modRef_decl 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition modRef_decl 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1092
-    (anonymous namespace)::ExpressionGrammar::definition modifierReference 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition modifierReference 
::boost::spirit::classic::rule<ScannerT>
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1093
-    (anonymous namespace)::ExpressionGrammar::definition identifier 
::boost::spirit::rule<ScannerT>
+    (anonymous namespace)::ExpressionGrammar::definition identifier 
::boost::spirit::classic::rule<ScannerT>
 svx/source/dialog/contimp.hxx:75
     SvxSuperContourDlg aContourItem class SvxContourDlgItem
 svx/source/dialog/framelinkarray.cxx:385
@@ -714,9 +712,7 @@ sw/inc/unosett.hxx:145
     SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl>
 sw/qa/core/test_ToxTextGenerator.cxx:145
     (anonymous namespace)::ToxTextGeneratorWithMockedChapterField 
mChapterFieldType class SwChapterFieldType
-sw/qa/extras/uiwriter/uiwriter2.cxx:70
-      class SwUiWriterTest2 *
-sw/qa/extras/uiwriter/uiwriter.cxx:4159
+sw/qa/extras/uiwriter/uiwriter.cxx:4184
     (anonymous namespace)::IdleTask maIdle class Idle
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState const class 
SwCursorSaveState
@@ -774,6 +770,8 @@ vcl/inc/salmenu.hxx:43
     SalMenuButtonItem maImage class Image
 vcl/inc/salmenu.hxx:44
     SalMenuButtonItem maToolTipText class rtl::OUString
+vcl/inc/salvtables.hxx:520
+    SalInstanceEntry m_aTextFilter class WeldTextFilter
 vcl/inc/skia/packedsurfaceatlas.hxx:37
     SkiaPackedSurface mSurface sk_sp<class SkSurface>
 vcl/inc/skia/packedsurfaceatlas.hxx:38
@@ -804,10 +802,8 @@ vcl/inc/WidgetThemeLibrary.hxx:93
     vcl::ControlDrawParameters eState enum ControlState
 vcl/inc/WidgetThemeLibrary.hxx:109
     vcl::WidgetThemeLibrary_t nSize uint32_t
-vcl/source/app/salvtables.cxx:3387
-    (anonymous namespace)::SalInstanceEntry m_aTextFilter class (anonymous 
namespace)::WeldTextFilter
-vcl/source/app/salvtables.cxx:6274
-    (anonymous namespace)::SalInstanceComboBoxWithEdit m_aTextFilter class 
(anonymous namespace)::WeldTextFilter
+vcl/source/app/salvtables.cxx:5793
+    (anonymous namespace)::SalInstanceComboBoxWithEdit m_aTextFilter class 
WeldTextFilter
 vcl/source/gdi/jobset.cxx:37
     (anonymous namespace)::ImplOldJobSetupData cDeviceName char [32]
 vcl/source/gdi/jobset.cxx:38
@@ -828,7 +824,7 @@ vcl/unx/gtk3/gtk3gloactiongroup.cxx:27
     (anonymous namespace)::GLOAction parent_instance GObject
 vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:5120
+vcl/unx/gtk3/gtk3gtkinst.cxx:5143
     (anonymous namespace)::CrippledViewport viewport GtkViewport
 writerfilter/source/dmapper/PropertyMap.hxx:220
     writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
diff --git a/compilerplugins/clang/unusedfields.readonly.results 
b/compilerplugins/clang/unusedfields.readonly.results
index 6a4b26146d35..3071b96d5a38 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -340,16 +340,8 @@ include/svx/svdoedge.hxx:160
     SdrEdgeObj mbBoundRectCalculationRunning _Bool
 include/svx/svdpntv.hxx:160
     SdrPaintView maDrawinglayerOpt const class SvtOptionsDrawinglayer
-include/test/sheet/xdatapilottable.hxx:31
-    apitest::XDataPilotTable xCellForChange 
css::uno::Reference<css::table::XCell>
-include/test/sheet/xdatapilottable.hxx:32
-    apitest::XDataPilotTable xCellForCheck 
css::uno::Reference<css::table::XCell>
-include/test/sheet/xnamedranges.hxx:49
-    apitest::XNamedRanges xSheet css::uno::Reference<css::sheet::XSpreadsheet>
-include/test/sheet/xspreadsheets2.hxx:47
-    apitest::XSpreadsheets2 xDocument 
css::uno::Reference<css::sheet::XSpreadsheetDocument>
 include/unoidl/unoidl.hxx:443
-    unoidl::ConstantValue  union unoidl::ConstantValue::(anonymous at 
/home/noel/libo2/include/unoidl/unoidl.hxx:443:5)
+    unoidl::ConstantValue  union unoidl::ConstantValue::(anonymous at 
/media/disk2/libo4/include/unoidl/unoidl.hxx:443:5)
 include/unoidl/unoidl.hxx:444
     unoidl::ConstantValue::(anonymous) booleanValue _Bool
 include/unoidl/unoidl.hxx:445
@@ -427,13 +419,15 @@ sc/inc/attarray.hxx:68
 sc/inc/compiler.hxx:129
     ScRawToken::(anonymous union)::(anonymous) eItem const class 
ScTableRefToken::Item
 sc/inc/compiler.hxx:130
-    ScRawToken::(anonymous) table const struct (anonymous struct at 
/home/noel/libo2/sc/inc/compiler.hxx:127:9)
+    ScRawToken::(anonymous) table const struct (anonymous struct at 
/media/disk2/libo4/sc/inc/compiler.hxx:127:9)
 sc/inc/compiler.hxx:135
     ScRawToken::(anonymous) pMat class ScMatrix *const
 sc/inc/formulagroup.hxx:39
     sc::FormulaGroupEntry::(anonymous) mpCells class ScFormulaCell **const
 sc/inc/reordermap.hxx:21
     sc::ColRowReorderMapType maData sc::ColRowReorderMapType::DataType
+sc/qa/extras/anchor.cxx:61
+    sc_apitest::ScAnchorTest mxComponent uno::Reference<lang::XComponent>
 sc/qa/unit/scshapetest.cxx:43
     sc_apitest::ScShapeTest mxComponent uno::Reference<lang::XComponent>
 sc/source/core/inc/adiasync.hxx:42
@@ -978,7 +972,7 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
 vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:1610
+vcl/unx/gtk3/gtk3gtkinst.cxx:1611
      out gpointer *
 writerfilter/inc/ooxml/QNameToString.hxx:38
     writerfilter::QNameToString mMap writerfilter::QNameToString::Map
diff --git a/compilerplugins/clang/unusedfields.untouched.results 
b/compilerplugins/clang/unusedfields.untouched.results
index cafa4fcd4517..2f94798d9bb1 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -5,9 +5,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
     libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-    libvlc_event_t::(anonymous) padding struct (anonymous struct at 
/home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+    libvlc_event_t::(anonymous) padding struct (anonymous struct at 
/media/disk2/libo4/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-    libvlc_event_t u union (anonymous union at 
/home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+    libvlc_event_t u union (anonymous union at 
/media/disk2/libo4/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
     libvlc_track_description_t psz_name char *
 basctl/source/inc/dlged.hxx:122
@@ -64,30 +64,30 @@ include/sfx2/msg.hxx:117
     SfxType0 createSfxPoolItemFunc const std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:119
     SfxType0 nAttribs const sal_uInt16
+include/sfx2/msg.hxx:132
+    SfxType1 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:132
     SfxType1 pType const std::type_info *
 include/sfx2/msg.hxx:132
     SfxType1 nAttribs sal_uInt16
-include/sfx2/msg.hxx:132
-    SfxType1 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:132
     SfxType1 aAttrib struct SfxTypeAttrib [1]
 include/sfx2/msg.hxx:133
     SfxType2 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:133
-    SfxType2 nAttribs sal_uInt16
 include/sfx2/msg.hxx:133
     SfxType2 pType const std::type_info *
+include/sfx2/msg.hxx:133
+    SfxType2 nAttribs sal_uInt16
 include/sfx2/msg.hxx:133
     SfxType2 aAttrib struct SfxTypeAttrib [2]
-include/sfx2/msg.hxx:134
-    SfxType3 pType const std::type_info *
 include/sfx2/msg.hxx:134
     SfxType3 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:134
     SfxType3 nAttribs sal_uInt16
 include/sfx2/msg.hxx:134
     SfxType3 aAttrib struct SfxTypeAttrib [3]
+include/sfx2/msg.hxx:134
+    SfxType3 pType const std::type_info *
 include/sfx2/msg.hxx:135
     SfxType4 aAttrib struct SfxTypeAttrib [4]
 include/sfx2/msg.hxx:135
@@ -98,20 +98,20 @@ include/sfx2/msg.hxx:135
     SfxType4 pType const std::type_info *
 include/sfx2/msg.hxx:136
     SfxType5 nAttribs sal_uInt16
+include/sfx2/msg.hxx:136
+    SfxType5 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:136
     SfxType5 aAttrib struct SfxTypeAttrib [5]
 include/sfx2/msg.hxx:136
     SfxType5 pType const std::type_info *
-include/sfx2/msg.hxx:136
-    SfxType5 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:137
     SfxType6 nAttribs sal_uInt16
 include/sfx2/msg.hxx:137
-    SfxType6 pType const std::type_info *
+    SfxType6 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:137
     SfxType6 aAttrib struct SfxTypeAttrib [6]
 include/sfx2/msg.hxx:137
-    SfxType6 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
+    SfxType6 pType const std::type_info *
 include/sfx2/msg.hxx:138
     SfxType7 nAttribs sal_uInt16
 include/sfx2/msg.hxx:138
@@ -148,10 +148,10 @@ include/sfx2/msg.hxx:143
     SfxType13 pType const std::type_info *
 include/sfx2/msg.hxx:143
     SfxType13 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:143
-    SfxType13 nAttribs sal_uInt16
 include/sfx2/msg.hxx:143
     SfxType13 aAttrib struct SfxTypeAttrib [13]
+include/sfx2/msg.hxx:143
+    SfxType13 nAttribs sal_uInt16
 include/sfx2/msg.hxx:144
     SfxType14 pType const std::type_info *
 include/sfx2/msg.hxx:144
@@ -188,8 +188,6 @@ include/svtools/genericunodialog.hxx:156
     svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard
 include/svtools/unoevent.hxx:163
     SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
-include/svtools/valueset.hxx:199
-    ValueSet maTimer class Timer
 include/svx/imapdlg.hxx:91
     SvxIMapDlg aIMapItem class SvxIMapDlgItem
 include/unotest/macros_test.hxx:50
@@ -254,6 +252,8 @@ pyuno/source/module/pyuno_impl.hxx:223
     pyuno::(anonymous) ob_base PyObject
 pyuno/source/module/pyuno_impl.hxx:323
     pyuno::stRuntimeImpl ob_base PyObject
+reportdesign/source/filter/xml/xmlExport.cxx:1241
+      sal_Int32
 reportdesign/source/ui/inc/ReportWindow.hxx:54
     rptui::OReportWindow m_pObjFac std::unique_ptr<DlgEdFactory, 
o3tl::default_delete<DlgEdFactory> >
 sal/qa/osl/condition/osl_Condition.cxx:72
@@ -348,12 +348,12 @@ sfx2/source/doc/doctempl.cxx:102
     DocTempl::(anonymous namespace)::DocTempl_EntryData_Impl mxObjShell const 
class SfxObjectShellLock
 sfx2/source/inc/sfxpicklist.hxx:33
     SfxPickList mxImpl std::unique_ptr<SfxPickListImpl>
-slideshow/source/engine/opengl/TransitionImpl.cxx:1989
-    (anonymous namespace)::ThreeFloats x GLfloat
 slideshow/source/engine/opengl/TransitionImpl.cxx:1989
     (anonymous namespace)::ThreeFloats z GLfloat
 slideshow/source/engine/opengl/TransitionImpl.cxx:1989
     (anonymous namespace)::ThreeFloats y GLfloat
+slideshow/source/engine/opengl/TransitionImpl.cxx:1989
+    (anonymous namespace)::ThreeFloats x GLfloat
 starmath/inc/smmod.hxx:69
     SmModule mpLocSymbolData std::unique_ptr<SmLocalizedSymbolData>
 starmath/inc/view.hxx:216
@@ -370,16 +370,12 @@ svl/source/crypto/cryptosign.cxx:284
     (anonymous namespace)::PKIStatusInfo statusString SECItem
 svl/source/crypto/cryptosign.cxx:285
     (anonymous namespace)::PKIStatusInfo failInfo SECItem
-svtools/source/control/valueimp.hxx:62
-    ValueSetItem mpData void *
 svx/source/dialog/contimp.hxx:75
     SvxSuperContourDlg aContourItem class SvxContourDlgItem
 svx/source/dialog/weldeditview.cxx:312
     (anonymous namespace)::WeldEditSource m_rEditAcc class WeldEditAccessible &
 svx/source/tbxctrls/layctrl.cxx:433
     (anonymous namespace)::ColumnsWindow mxControl 
rtl::Reference<SvxColumnsToolBoxControl>
-sw/qa/extras/uiwriter/uiwriter2.cxx:70
-      class SwUiWriterTest2 *
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState const class 
SwCursorSaveState
 sw/source/core/frmedt/fetab.cxx:75
@@ -446,7 +442,7 @@ vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:31
     (anonymous namespace)::HyperLink atk_hyper_link const AtkHyperlink
 vcl/unx/gtk3/gtk3gloactiongroup.cxx:27
     (anonymous namespace)::GLOAction parent_instance GObject
-vcl/unx/gtk3/gtk3gtkinst.cxx:5120
+vcl/unx/gtk3/gtk3gtkinst.cxx:5143
     (anonymous namespace)::CrippledViewport viewport GtkViewport
 writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43
     writerfilter::ooxml::OOXMLStreamImpl mxFastParser 
css::uno::Reference<css::xml::sax::XFastParser>
diff --git a/compilerplugins/clang/unusedfields.writeonly.results 
b/compilerplugins/clang/unusedfields.writeonly.results
index 828a5d6c8186..0da880763305 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -56,10 +56,10 @@ bridges/source/jni_uno/jni_java2uno.cxx:153
     jni_uno::(anonymous namespace)::largest p void *
 bridges/source/jni_uno/jni_java2uno.cxx:154
     jni_uno::(anonymous namespace)::largest a uno_Any
-canvas/inc/rendering/irendermodule.hxx:35
-    canvas::Vertex r float
 canvas/inc/rendering/irendermodule.hxx:35
     canvas::Vertex g float
+canvas/inc/rendering/irendermodule.hxx:35
+    canvas::Vertex r float
 canvas/inc/rendering/irendermodule.hxx:35
     canvas::Vertex a float
 canvas/inc/rendering/irendermodule.hxx:35
@@ -222,7 +222,7 @@ cppuhelper/source/access_control.cxx:80
     cppu::(anonymous namespace)::permission m_str2 rtl_uString *
 cppuhelper/source/typemanager.cxx:825
     (anonymous namespace)::BaseOffset set_ std::set<OUString>
-cui/source/inc/cfg.hxx:408
+cui/source/inc/cfg.hxx:409
     SvxConfigPage m_xDropTargetHelper 
std::unique_ptr<SvxConfigPageFunctionDropTarget>
 cui/source/inc/cuihyperdlg.hxx:46
     SvxHlinkCtrl aRdOnlyForwarder class SfxStatusForwarder
@@ -246,9 +246,9 @@ dbaccess/source/ui/browser/dbloader.cxx:71
     (anonymous namespace)::DBContentLoader m_xListener Reference<class 
com::sun::star::frame::XLoadEventListener>
 desktop/qa/desktop_lib/test_desktop_lib.cxx:250
     DesktopLOKTest m_bModified _Bool
-desktop/source/app/app.cxx:1202
+desktop/source/app/app.cxx:1210
     desktop::(anonymous namespace)::ExecuteGlobals pLanguageOptions 
std::unique_ptr<SvtLanguageOptions>
-desktop/source/app/app.cxx:1203
+desktop/source/app/app.cxx:1211
     desktop::(anonymous namespace)::ExecuteGlobals pPathOptions 
std::unique_ptr<SvtPathOptions>
 desktop/source/deployment/gui/dp_gui_extlistbox.hxx:138
     dp_gui::ExtensionBox_Impl m_vRemovedEntries std::vector<TEntry_Impl>
@@ -418,6 +418,8 @@ include/test/beans/xpropertyset.hxx:56
     apitest::XPropertySet::PropsToTest constrained std::vector<OUString>
 include/unotools/fontcfg.hxx:158
     utl::FontSubstConfiguration maSubstHash 
utl::FontSubstConfiguration::UniqueSubstHash
+include/vcl/accel.hxx:42
+    Accelerator maCurKeyCode vcl::KeyCode
 include/vcl/menu.hxx:454
     MenuBar::MenuBarButtonCallbackArg bHighlight _Bool
 include/vcl/NotebookBarAddonsMerger.hxx:54
@@ -756,17 +758,17 @@ svx/inc/sdr/overlay/overlaytools.hxx:41
     drawinglayer::primitive2d::OverlayStaticRectanglePrimitive mfRotation 
const double
 svx/inc/sdr/primitive2d/sdrolecontentprimitive2d.hxx:46
     drawinglayer::primitive2d::SdrOleContentPrimitive2D mnGraphicVersion const 
sal_uInt32
-svx/source/form/dataaccessdescriptor.cxx:42
+svx/source/form/dataaccessdescriptor.cxx:39
     svx::ODADescriptorImpl m_bSetOutOfDate _Bool
-svx/source/form/formcontroller.cxx:217
+svx/source/form/formcontroller.cxx:211
     svxform::(anonymous namespace)::ColumnInfo nNullable sal_Int32
 svx/source/inc/docrecovery.hxx:131
     svx::DocRecovery::TURLInfo Module class rtl::OUString
 svx/source/sdr/attribute/sdrformtextattribute.cxx:153
     drawinglayer::attribute::ImpSdrFormTextAttribute mnFormTextShdwTransp 
const sal_uInt16
-svx/source/sdr/attribute/sdrtextattribute.cxx:51
+svx/source/sdr/attribute/sdrtextattribute.cxx:49
     drawinglayer::attribute::ImpSdrTextAttribute maPropertiesVersion sal_uInt32
-svx/source/sdr/attribute/sdrtextattribute.cxx:65
+svx/source/sdr/attribute/sdrtextattribute.cxx:63
     drawinglayer::attribute::ImpSdrTextAttribute mbWrongSpell const _Bool
 svx/source/sidebar/line/LinePropertyPanel.hxx:81
     svx::sidebar::LinePropertyPanel maStyleControl 
sfx2::sidebar::ControllerItem
@@ -845,7 +847,7 @@ sw/source/filter/inc/rtf.hxx:29
 sw/source/filter/inc/rtf.hxx:30
     RTFSurround::(anonymous union)::(anonymous) nJunk sal_uInt8
 sw/source/filter/inc/rtf.hxx:31
-    RTFSurround::(anonymous) Flags struct (anonymous struct at 
/home/noel/libo2/sw/source/filter/inc/rtf.hxx:27:9)
+    RTFSurround::(anonymous) Flags struct (anonymous struct at 
/media/disk2/libo4/sw/source/filter/inc/rtf.hxx:27:9)
 sw/source/uibase/inc/glossary.hxx:63
     SwGlossaryDlg m_xGroupData std::vector<std::unique_ptr<GroupUserData> >
 sw/source/uibase/inc/maildispatcher.hxx:146
@@ -1024,9 +1026,9 @@ vcl/inc/WidgetThemeLibrary.hxx:95
     vcl::ControlDrawParameters bIsAction _Bool
 vcl/inc/WidgetThemeLibrary.hxx:96
     vcl::ControlDrawParameters nValue int64_t
-vcl/source/filter/graphicfilter.cxx:660
+vcl/source/filter/graphicfilter.cxx:613
     (anonymous namespace)::ImpFilterLibCacheEntry maFiltername const class 
rtl::OUString
-vcl/source/filter/graphicfilter.cxx:763
+vcl/source/filter/graphicfilter.cxx:716
     (anonymous namespace)::ImpFilterLibCache mpLast struct (anonymous 
namespace)::ImpFilterLibCacheEntry *
 vcl/source/filter/jpeg/Exif.hxx:51
     Exif::ExifIFD tag sal_uInt8 [2]
@@ -1060,7 +1062,7 @@ vcl/unx/gtk3/a11y/gtk3atkutil.cxx:138
     DocumentFocusListener m_aRefList std::set<uno::Reference<uno::XInterface> >
 vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:1610
+vcl/unx/gtk3/gtk3gtkinst.cxx:1611
      in char *
 vcl/unx/gtk3/gtk3hudawareness.cxx:18
     (anonymous namespace)::HudAwarenessHandle connection GDBusConnection *
diff --git a/include/vcl/accel.hxx b/include/vcl/accel.hxx
index 4ea6714e8083..0d7ec95ad072 100644
--- a/include/vcl/accel.hxx
+++ b/include/vcl/accel.hxx
@@ -39,7 +39,6 @@ private:
     Link<Accelerator&,void> maSelectHdl;
 
     // Will be set by AcceleratorManager
-    vcl::KeyCode            maCurKeyCode;
     sal_uInt16              mnCurId;
     bool*                   mpDel;
 
diff --git a/sc/qa/extras/anchor.cxx b/sc/qa/extras/anchor.cxx
index 5a9d35d18674..8801e9690b3d 100644
--- a/sc/qa/extras/anchor.cxx
+++ b/sc/qa/extras/anchor.cxx
@@ -35,8 +35,6 @@ class ScAnchorTest : public CalcUnoApiTest
 public:
     ScAnchorTest();
 
-    virtual void tearDown() override;
-
     void testUndoAnchor();
     void testTdf76183();
     void testODFAnchorTypes();
@@ -56,9 +54,6 @@ public:
     CPPUNIT_TEST(testTdf129552);
     CPPUNIT_TEST(testTdf130556);
     CPPUNIT_TEST_SUITE_END();
-
-private:
-    uno::Reference<lang::XComponent> mxComponent;
 };
 
 ScAnchorTest::ScAnchorTest()
@@ -416,16 +411,6 @@ void ScAnchorTest::testTdf130556()
     xComponent->dispose();
 }
 
-void ScAnchorTest::tearDown()
-{
-    if (mxComponent.is())
-    {
-        closeDocument(mxComponent);
-    }
-
-    CalcUnoApiTest::tearDown();
-}
-
 CPPUNIT_TEST_SUITE_REGISTRATION(ScAnchorTest);
 }
 
diff --git a/sc/qa/unit/scshapetest.cxx b/sc/qa/unit/scshapetest.cxx
index 8e3cbe2c7802..4a9288acddac 100644
--- a/sc/qa/unit/scshapetest.cxx
+++ b/sc/qa/unit/scshapetest.cxx
@@ -29,8 +29,6 @@ class ScShapeTest : public CalcUnoApiTest
 public:
     ScShapeTest();
 
-    virtual void tearDown() override;
-
     void testFitToCellSize();
     void testCustomShapeCellAnchoredRotatedShape();
 
@@ -38,9 +36,6 @@ public:
     CPPUNIT_TEST(testFitToCellSize);
     CPPUNIT_TEST(testCustomShapeCellAnchoredRotatedShape);
     CPPUNIT_TEST_SUITE_END();
-
-private:
-    uno::Reference<lang::XComponent> mxComponent;
 };
 
 ScShapeTest::ScShapeTest()
@@ -171,16 +166,6 @@ void ScShapeTest::testCustomShapeCellAnchoredRotatedShape()
     pDocSh->DoClose();
 }
 
-void ScShapeTest::tearDown()
-{
-    if (mxComponent.is())
-    {
-        closeDocument(mxComponent);
-    }
-
-    CalcUnoApiTest::tearDown();
-}
-
 CPPUNIT_TEST_SUITE_REGISTRATION(ScShapeTest);
 }
 
diff --git a/vcl/source/window/accel.cxx b/vcl/source/window/accel.cxx
index 1795d0496829..c580679bd8b0 100644
--- a/vcl/source/window/accel.cxx
+++ b/vcl/source/window/accel.cxx
@@ -220,7 +220,6 @@ Accelerator::Accelerator()
 }
 
 Accelerator::Accelerator(const Accelerator& rAccel)
-    : maCurKeyCode( rAccel.maCurKeyCode )
 {
     ImplInit();
     mpData.reset(new ImplAccelData);
@@ -284,7 +283,6 @@ Accelerator& Accelerator::operator=( const Accelerator& 
rAccel )
         return *this;
 
     // assign new data
-    maCurKeyCode    = vcl::KeyCode();
     mnCurId         = 0;
 
     // delete and copy tables
diff --git a/vcl/source/window/accmgr.cxx b/vcl/source/window/accmgr.cxx
index f7a3ea0545a1..003e09343bc3 100644
--- a/vcl/source/window/accmgr.cxx
+++ b/vcl/source/window/accmgr.cxx
@@ -138,7 +138,6 @@ bool ImplAccelManager::IsAccelKey( const vcl::KeyCode& 
rKeyCode )
                     // set accelerator of the actual item
                     // and call the handler
                     bool bDel = false;
-                    pAccel->maCurKeyCode    = rKeyCode;
                     pAccel->mnCurId         = pEntry->mnId;
                     pAccel->mpDel           = &bDel;
                     pAccel->Select();
@@ -146,7 +145,6 @@ bool ImplAccelManager::IsAccelKey( const vcl::KeyCode& 
rKeyCode )
                     // did the accelerator survive the call
                     if ( !bDel )
                     {
-                        pAccel->maCurKeyCode    = vcl::KeyCode();
                         pAccel->mnCurId         = 0;
                         pAccel->mpDel           = nullptr;
                     }
@@ -206,7 +204,6 @@ bool ImplAccelManager::IsAccelKey( const vcl::KeyCode& 
rKeyCode )
                     // define accelerator of the actual item
                     // and call the handler
                     bool bDel = false;
-                    pAccel->maCurKeyCode    = rKeyCode;
                     pAccel->mnCurId         = pEntry->mnId;
                     pAccel->mpDel           = &bDel;
                     pAccel->Select();
@@ -214,7 +211,6 @@ bool ImplAccelManager::IsAccelKey( const vcl::KeyCode& 
rKeyCode )
                     // if the accelerator did survive the call
                     if ( !bDel )
                     {
-                        pAccel->maCurKeyCode    = vcl::KeyCode();
                         pAccel->mnCurId         = 0;
                         pAccel->mpDel           = nullptr;
                     }
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Reply via email to