[Libreoffice-commits] core.git: compilerplugins/clang include/vcl sw/source vcl/inc
compilerplugins/clang/unnecessaryvirtual.results | 30 ---
include/vcl/toolkit/menubtn.hxx |2 -
sw/source/core/inc/MarkManager.hxx |2 -
vcl/inc/jsdialog/jsdialogbuilder.hxx |2 -
4 files changed, 24 insertions(+), 12 deletions(-)
New commits:
commit e549d811466c6e77815f60b64dd0a9f949e7f518
Author: Noel
AuthorDate: Tue Feb 23 12:42:01 2021 +0200
Commit: Noel Grandin
CommitDate: Tue Feb 23 14:56:44 2021 +0100
loplugin:unnecessaryvirtual
Change-Id: I792a717306c232cf200940f9e3944f91885e426a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111387
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/unnecessaryvirtual.results
b/compilerplugins/clang/unnecessaryvirtual.results
index 1d3821d7c2af..59268ce03547 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -296,8 +296,10 @@ include/vbahelper/vbareturntypes.hxx:39
type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
include/vcl/customweld.hxx:45
class rtl::OUString weld::CustomWidgetController::GetHelpText()const
-include/vcl/toolkit/dialog.hxx:98
+include/vcl/toolkit/dialog.hxx:99
void Dialog::set_content_area(class VclBox *,)
+include/vcl/toolkit/menubtn.hxx:67
+void MenuButton::Select()
include/vcl/weld.hxx:100
void weld::Widget::set_visible(_Bool,)
sc/source/core/opencl/formulagroupcl.cxx:1061
@@ -400,18 +402,26 @@ slideshow/source/inc/shape.hxx:221
void slideshow::internal::Shape::setIsForeground(const _Bool,)
sw/inc/flypos.hxx:37
void SwPosFlyFrame::~SwPosFlyFrame()
+sw/source/core/inc/MarkManager.hxx:104
+void sw::mark::MarkManager::LOKUpdateActiveField(class SfxViewShell *,)
toolkit/inc/controls/geometrycontrolmodel.hxx:182
void OGeometryControlModel::fillProperties(class
com::sun::star::uno::Sequence &,class
com::sun::star::uno::Sequence &,)const
-vcl/inc/jsdialog/jsdialogbuilder.hxx:190
+vcl/inc/jsdialog/jsdialogbuilder.hxx:90
+void JSDialogSender::sendFullUpdate(_Bool,)
+vcl/inc/jsdialog/jsdialogbuilder.hxx:92
+void JSDialogSender::sendUpdate(class VclPtr,_Bool,)
+vcl/inc/jsdialog/jsdialogbuilder.hxx:250
void JSWidget::show()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:196
+vcl/inc/jsdialog/jsdialogbuilder.hxx:256
void JSWidget::hide()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:203
+vcl/inc/jsdialog/jsdialogbuilder.hxx:263
void JSWidget::set_sensitive(_Bool,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:209
+vcl/inc/jsdialog/jsdialogbuilder.hxx:271
class com::sun::star::uno::Reference JSWidget::get_drop_target()
-vcl/inc/salbmp.hxx:118
-void SalBitmap::updateChecksum()const
+vcl/inc/jsdialog/jsdialogbuilder.hxx:279
+void JSWidget::freeze()
+vcl/inc/jsdialog/jsdialogbuilder.hxx:285
+void JSWidget::thaw()
vcl/inc/salframe.hxx:145
void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
vcl/inc/salframe.hxx:194
@@ -424,9 +434,11 @@ vcl/inc/salobj.hxx:49
void SalObject::Enable(_Bool,)
vcl/inc/salprn.hxx:116
enum SalPrinterError SalPrinter::GetErrorCode()
+vcl/inc/salvtables.hxx:1577
+_Bool SalInstanceTreeView::get_iter_abs_pos(class weld::TreeIter
&,int,)const
vcl/inc/skia/gdiimpl.hxx:236
void SkiaSalGraphicsImpl::createSurface()
-vcl/inc/unx/gtk/gtkdata.hxx:121
+vcl/inc/unx/gtk/gtkdata.hxx:180
int GtkSalDisplay::CaptureMouse(class SalFrame *,)
vcl/inc/unx/saldata.hxx:50
void X11SalData::Init()
@@ -450,7 +462,7 @@ vcl/inc/unx/saldisp.hxx:197
_Bool SalXLib::CheckTimeout(_Bool,)
vcl/inc/unx/saldisp.hxx:404
void SalX11Display::Yield()
-vcl/inc/unx/salframe.h:207
+vcl/inc/unx/salframe.h:206
void X11SalFrame::updateGraphics(_Bool,)
vcl/inc/unx/salinst.h:41
class SalX11Display * X11SalInstance::CreateDisplay()const
diff --git a/include/vcl/toolkit/menubtn.hxx b/include/vcl/toolkit/menubtn.hxx
index 234383b68b2e..db4f9f44f5d6 100644
--- a/include/vcl/toolkit/menubtn.hxx
+++ b/include/vcl/toolkit/menubtn.hxx
@@ -64,7 +64,7 @@ public:
virtual voidKeyInput( const KeyEvent& rKEvt ) override;
virtual voidActivate() override;
-virtual voidSelect();
+voidSelect();
voidExecuteMenu();
boolInPopupMode() const;
diff --git a/sw/source/core/inc/MarkManager.hxx
b/sw/source/core/inc/MarkManager.hxx
index 94cd907b0f12..11db9719d439 100644
--- a/sw/source/core/inc/MarkManager.hxx
+++ b/sw/source/core/inc/MarkManager.hxx
@@ -101,7 +101,7 @@ namespace sw::mark {
virtual void NotifyCursorUpdate(const SwCursorShell& rCursorShell)
override;
virtual void ClearFieldActivation() override;
-virtual void LOKUpdateActiveField(SfxViewShell* pViewShell);
+void LOKUpdateActiveField(SfxViewShell* pViewShell);
void dumpAsXml(xmlTextWriterPtr pWriter) const;
diff --git
[Libreoffice-commits] core.git: compilerplugins/clang include/vcl sw/source vcl/inc vcl/source
compilerplugins/clang/unusedmethods.results| 170 - include/vcl/toolbox.hxx|1 sw/source/uibase/inc/workctrl.hxx |2 sw/source/uibase/sidebar/PageMarginControl.cxx | 35 - sw/source/uibase/sidebar/PageMarginControl.hxx |1 vcl/inc/listbox.hxx|1 vcl/source/control/imp_listbox.cxx | 15 -- vcl/source/window/toolbox2.cxx | 14 -- 8 files changed, 87 insertions(+), 152 deletions(-) New commits: commit 01702f7d5f52b72a890f6a0173d42199c587e01f Author: Noel Grandin AuthorDate: Mon Jan 20 14:28:59 2020 +0200 Commit: Noel Grandin CommitDate: Mon Jan 20 14:35:55 2020 +0100 loplugin:unusedmethods Change-Id: Ie5e90b3c834a1154ec49dc765a5031f6bdd35923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87070 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index ab53820ef05a..53009519ec54 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -148,14 +148,10 @@ drawinglayer/source/tools/emfpstringformat.hxx:100 _Bool emfplushelper::EMFPStringFormat::NoClip() const drawinglayer/source/tools/emfpstringformat.hxx:101 _Bool emfplushelper::EMFPStringFormat::BypassGDI() const -editeng/inc/edtspell.hxx:105 +editeng/inc/edtspell.hxx:104 class __gnu_debug::_Safe_iterator > >, class std::__debug::vector >, struct std::random_access_iterator_tag> WrongList::begin() const -editeng/inc/edtspell.hxx:106 +editeng/inc/edtspell.hxx:105 class __gnu_debug::_Safe_iterator > >, class std::__debug::vector >, struct std::random_access_iterator_tag> WrongList::end() const -extensions/source/propctrlr/inspectorhelpwindow.hxx:48 -long pcr::InspectorHelpWindow::impl_getMinimalTextWindowHeight() -extensions/source/propctrlr/inspectorhelpwindow.hxx:49 -long pcr::InspectorHelpWindow::impl_getMaximalTextWindowHeight() extensions/source/scanner/scanner.hxx:85 void ScannerManager::SetData(void *) framework/inc/tabwin/tabwindow.hxx:64 @@ -380,8 +376,6 @@ include/codemaker/global.hxx:60 class FileStream & operator<<(class FileStream &,const class rtl::OStringBuffer *) include/codemaker/global.hxx:61 class FileStream & operator<<(class FileStream &,const class rtl::OStringBuffer &) -include/comphelper/AccessibleImplementationHelper.hxx:43 -class rtl::OUString comphelper::GetkeyBindingStrByXkeyBinding(const class com::sun::star::uno::Sequence &) include/comphelper/asyncquithandler.hxx:45 _Bool AsyncQuitHandler::IsForceQuit() const include/comphelper/automationinvokedzone.hxx:28 @@ -602,9 +596,9 @@ include/opencl/openclconfig.hxx:57 _Bool OpenCLConfig::ImplMatcher::operator!=(const struct OpenCLConfig::ImplMatcher &) const include/opencl/OpenCLZone.hxx:47 _Bool OpenCLZone::isInInitialTest() -include/sfx2/charwin.hxx:64 +include/sfx2/charwin.hxx:63 void SvxCharView::connect_focus_in(const class Link &) -include/sfx2/charwin.hxx:65 +include/sfx2/charwin.hxx:64 void SvxCharView::connect_focus_out(const class Link &) include/sfx2/childwin.hxx:164 void SfxChildWindow::ClearController() @@ -616,8 +610,6 @@ include/sfx2/lokcharthelper.hxx:42 void LokChartHelper::Invalidate() include/sfx2/msg.hxx:120 const class std::type_info * SfxType0::Type() const -include/sfx2/sidebar/SidebarToolBox.hxx:57 -class com::sun::star::uno::Reference sfx2::sidebar::SidebarToolBox::GetFirstController() include/svl/itempool.hxx:171 const type-parameter-?-? * SfxItemPool::GetItem2Default(TypedWhichId) const include/svl/itempool.hxx:207 @@ -628,9 +620,9 @@ include/svtools/asynclink.hxx:44 void svtools::AsynchronLink::LinkStubHandleCall_Idle(void *,class Timer *) include/svtools/DocumentToGraphicRenderer.hxx:106 _Bool DocumentToGraphicRenderer::isImpress() const -include/svtools/toolbarmenu.hxx:195 +include/svtools/toolbarmenu.hxx:194 class weld::Container * ToolbarPopupContainer::getContainer() -include/svtools/toolbarmenu.hxx:212 +include/svtools/toolbarmenu.hxx:211 class weld::Container * InterimToolbarPopup::getContainer() include/svx/autoformathelper.hxx:145 _Bool AutoFormatBase::operator==(const class AutoFormatBase &) @@ -644,10 +636,6 @@ include/svx/ClassificationField.hxx:47 const class rtl::OUString & svx::ClassificationResult::getDisplayText() const include/svx/ClassificationField.hxx:52 _Bool svx::ClassificationResult::operator==(const class svx::ClassificationResult &) const -include/svx/colorwindow.hxx:99 -void SvxColorWindow::StartSelection() -include/svx/colorwindow.hxx:109 -void SvxColorWindow::SetSelectedHdl(const class Link &, void> &) include/svx/DiagramDataInterface.hxx:33 class rtl::OUString DiagramDataInterface::getString() const
