subject:"\[Libreoffice\-commits\] core.git\: compilerplugins\/clang solenv\/clang\-format"

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

2023-09-15 Thread Noel Grandin (via logerrit)

 compilerplugins/clang/test/weakbase.cxx  |   51 +++-
 compilerplugins/clang/test/weakobject.cxx|   31 -
 compilerplugins/clang/weakbase.cxx   |   74 ---
 compilerplugins/clang/weakobject.cxx |   85 ---
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 solenv/clang-format/excludelist  |1 
 6 files changed, 113 insertions(+), 130 deletions(-)

New commits:
commit 2876b31eee9b2946dfaa74b17645c6812c7a20db
Author: Noel Grandin 
AuthorDate: Fri Sep 15 11:03:18 2023 +0200
Commit: Noel Grandin 
CommitDate: Fri Sep 15 12:48:29 2023 +0200

loplugin, merge weakobject into weakbase

and make them support virtual bases, even though the bridge code does
not support that (yet)

Change-Id: I247e795391fa452dea2922869b15ab043eb2bdd1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156941
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/test/weakbase.cxx 
b/compilerplugins/clang/test/weakbase.cxx
index a59a5372891e..3d5284ef543c 100644
--- a/compilerplugins/clang/test/weakbase.cxx
+++ b/compilerplugins/clang/test/weakbase.cxx
@@ -25,10 +25,59 @@ struct Foo2 : public tools::WeakBase
 virtual ~Foo2();
 };
 
-// expected-error@+1 {{multiple copies of WeakBase, through inheritance paths 
Bar->Foo1->WeakBase, Bar->Foo2->WeakBase [loplugin:weakbase]}}
+// expected-error@+1 {{found multiple copies of tools::WeakBase, through 
inheritance paths Bar->Foo1->WeakBase, Bar->Foo2->WeakBase [loplugin:weakbase]}}
 struct Bar : public Foo1, public Foo2
 {
 virtual ~Bar();
 };
 
+namespace cppu
+{
+class OWeakObject
+{
+};
+}
+
+namespace test2
+{
+class Foo1 : public cppu::OWeakObject
+{
+};
+class Foo2 : public cppu::OWeakObject
+{
+};
+// expected-error@+1 {{found multiple copies of cppu::OWeakObject, through 
inheritance paths Foo3->Foo1->OWeakObject, Foo3->Foo2->OWeakObject 
[loplugin:weakbase]}}
+class Foo3 : public Foo1, public Foo2
+{
+};
+}
+
+namespace test3
+{
+class Foo1 : public virtual cppu::OWeakObject
+{
+};
+class Foo2 : public virtual cppu::OWeakObject
+{
+};
+// no warning expected
+class Foo3 : public Foo1, public Foo2
+{
+};
+}
+
+namespace test4
+{
+class Foo1 : public cppu::OWeakObject
+{
+};
+class Foo2 : public virtual cppu::OWeakObject
+{
+};
+// expected-error@+1 {{found one virtual base and one or more normal bases of 
cppu::OWeakObject, through inheritance paths Foo3->Foo1->OWeakObject, 
Foo3->Foo2->OWeakObject [loplugin:weakbase]}}
+class Foo3 : public Foo1, public Foo2
+{
+};
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/compilerplugins/clang/test/weakobject.cxx 
b/compilerplugins/clang/test/weakobject.cxx
deleted file mode 100644
index 7c7da55664d2..
--- a/compilerplugins/clang/test/weakobject.cxx
+++ /dev/null
@@ -1,31 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include "config_clang.h"
-
-namespace cppu
-{
-class OWeakObject
-{
-};
-}
-
-class Foo1 : public cppu::OWeakObject
-{
-};
-class Foo2 : public cppu::OWeakObject
-{
-};
-
-// expected-error@+1 {{more than one copy of cppu::OWeakObject inherited 
[loplugin:weakobject]}}
-class Foo3 : public Foo1, public Foo2
-{
-};
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/compilerplugins/clang/weakbase.cxx 
b/compilerplugins/clang/weakbase.cxx
index 666444ff7ffb..f6f7c8db01be 100644
--- a/compilerplugins/clang/weakbase.cxx
+++ b/compilerplugins/clang/weakbase.cxx
@@ -15,6 +15,7 @@
 #include 
 
 #include "plugin.hxx"
+#include "check.hxx"
 #include "clang/AST/CXXInheritance.h"
 
 /**
@@ -69,7 +70,11 @@ bool WeakBase::VisitCXXRecordDecl(CXXRecordDecl const* 
recordDecl)
 return true;
 
 int noWeakBases = 0;
-std::string basePaths;
+int noWeakObjects = 0;
+bool foundVirtualWeakBase = false;
+bool foundVirtualOWeakObject = false;
+std::string basePaths1;
+std::string basePaths2;
 auto BaseMatchesCallback = [&](const CXXBaseSpecifier* cxxBaseSpecifier, 
CXXBasePath& Paths) {
 if (!cxxBaseSpecifier->getType().getTypePtr())
 return false;
@@ -78,9 +83,30 @@ bool WeakBase::VisitCXXRecordDecl(CXXRecordDecl const* 
recordDecl)
 return false;
 if (baseCXXRecordDecl->isInvalidDecl())
 return false;
-if (baseCXXRecordDecl->getName() != "WeakBase")
+bool isWeakBase(loplugin::DeclCheck(baseCXXRecordDecl)
+.Struct("WeakBase")
+.Namespace("tools")
+

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

2023-02-28 Thread Stephan Bergmann (via logerrit)

 compilerplugins/clang/test/cppunitassertequals.cxx |6 -
 compilerplugins/clang/test/cppunitassertequals.hxx |   23 -
 solenv/clang-format/excludelist|1 
 3 files changed, 5 insertions(+), 25 deletions(-)

New commits:
commit a7affc26f3ee2c1449c41d88a0b18fd640577b39
Author: Stephan Bergmann 
AuthorDate: Tue Feb 28 16:32:32 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Feb 28 20:12:55 2023 +

Remove compilerplugins/clang/test/cppunitassertequals.hxx

...which isn't needed anymore to suppress warnings from other plugins like
loplugin:external ever since 45c06838e95c94445359536d84c6328fa8b17a66 "only
unit-test one loplugin at a time".  Also, the declaration of the function 
test
in cppunitassertequals.hxx had already started to deviate from its 
definition in
cppunitassertequals.cxx.

Change-Id: I3fbc8a9a805bd5bc4d8afbf958edff04b89add3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148010
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/test/cppunitassertequals.cxx 
b/compilerplugins/clang/test/cppunitassertequals.cxx
index ea68a77e9628..401105465635 100644
--- a/compilerplugins/clang/test/cppunitassertequals.cxx
+++ b/compilerplugins/clang/test/cppunitassertequals.cxx
@@ -9,16 +9,20 @@
 
 #include "sal/config.h"
 
+#include 
+
 #include 
 #include 
 #include 
 #include 
 
-#include "cppunitassertequals.hxx"
+#include "rtl/ustring.hxx"
 
 #define TEST1 CPPUNIT_ASSERT(b1 == b2)
 #define TEST2(x) x
 
+struct T { bool operator ==(T); };
+
 void test(
 bool b1, bool b2, OUString const & s1, OUString const & s2, T t, void * p, 
std::nullptr_t n,
 double d, int i)
diff --git a/compilerplugins/clang/test/cppunitassertequals.hxx 
b/compilerplugins/clang/test/cppunitassertequals.hxx
deleted file mode 100644
index 2448d64e93e7..
--- a/compilerplugins/clang/test/cppunitassertequals.hxx
+++ /dev/null
@@ -1,23 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#pragma once
-
-#include "sal/config.h"
-
-#include 
-
-#include "rtl/ustring.hxx"
-
-struct T { bool operator ==(T); };
-
-void test(
-bool b1, bool b2, OUString const & s1, OUString const & s2, T t, void * p, 
std::nullptr_t n);
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index a26ac1400c8d..f0f0773d7fef 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -1563,7 +1563,6 @@ compilerplugins/clang/test/commaoperator.cxx
 compilerplugins/clang/test/constmethod.cxx
 compilerplugins/clang/test/constparams.cxx
 compilerplugins/clang/test/cppunitassertequals.cxx
-compilerplugins/clang/test/cppunitassertequals.hxx
 compilerplugins/clang/test/dodgyswitch.cxx
 compilerplugins/clang/test/expressionalwayszero.cxx
 compilerplugins/clang/test/faileddyncast.cxx

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format svx/source

2022-12-16 Thread Stephan Bergmann (via logerrit)

 compilerplugins/clang/mergeclasses.results |1 
 solenv/clang-format/excludelist|1 
 svx/source/inc/celltypes.hxx   |9 --
 svx/source/table/sdrtableobjimpl.hxx   |  103 +
 svx/source/table/svdotable.cxx |   64 --
 svx/source/table/tabledesign.cxx   |4 -
 6 files changed, 108 insertions(+), 74 deletions(-)

New commits:
commit a0133459ada8bdc03fd6ae7e509a908ff9581793
Author: Stephan Bergmann 
AuthorDate: Thu Dec 15 21:34:39 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Dec 16 12:45:55 2022 +

Merge sdr::table::TableDesignUser into sdr::table::SdrTableObjImpl

Change-Id: Ia7841447df4a7db1b5dd9fad93cab66fbca48981
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144316
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/mergeclasses.results 
b/compilerplugins/clang/mergeclasses.results
index 6757b4070506..793b6f10bef8 100644
--- a/compilerplugins/clang/mergeclasses.results
+++ b/compilerplugins/clang/mergeclasses.results
@@ -400,7 +400,6 @@ merge sdext::presenter::PresenterScrollBar with 
sdext::presenter::PresenterVerti
 merge sdext::presenter::PresenterSlidePreview with 
sdext::presenter::(anonymous namespace)::NextSlidePreview
 merge sdr::SelectionController with sdr::table::SvxTableController
 merge sdr::contact::ObjectContactOfPagePainter with 
sdr::contact::PagePrimitiveExtractor
-merge sdr::table::TableDesignUser with sdr::table::SdrTableObjImpl
 merge sfx2::IXmlIdRegistry with sfx2::XmlIdRegistry
 merge slideshow::internal::(anonymous namespace)::EventContainer with 
slideshow::internal::ClickEventHandler
 merge slideshow::internal::AnimationFunction with 
slideshow::internal::ExpressionNode
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 2a2788ce34c1..e3079aec34e9 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -11845,6 +11845,7 @@ svx/source/table/cellrange.cxx
 svx/source/table/cellrange.hxx
 svx/source/table/propertyset.cxx
 svx/source/table/propertyset.hxx
+svx/source/table/sdrtableobjimpl.hxx
 svx/source/table/svdotable.cxx
 svx/source/table/tablecolumn.cxx
 svx/source/table/tablecolumn.hxx
diff --git a/svx/source/inc/celltypes.hxx b/svx/source/inc/celltypes.hxx
index acc5bdec7caf..f70e386db8a4 100644
--- a/svx/source/inc/celltypes.hxx
+++ b/svx/source/inc/celltypes.hxx
@@ -39,15 +39,6 @@ typedef std::vector CellVector;
 typedef std::vector RowVector;
 typedef std::vector ColumnVector;
 
-class SAL_LOPLUGIN_ANNOTATE("crosscast") TableDesignUser
-{
-public:
-virtual bool isInUse() = 0;
-
-protected:
-~TableDesignUser() {}
-};
-
 template  class RangeIterator
 {
 public:
diff --git a/svx/source/table/sdrtableobjimpl.hxx 
b/svx/source/table/sdrtableobjimpl.hxx
new file mode 100644
index ..5d9ef6969fbd
--- /dev/null
+++ b/svx/source/table/sdrtableobjimpl.hxx
@@ -0,0 +1,103 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+namespace sdr::table {
+
+class SVXCORE_DLLPUBLIC SdrTableObjImpl : public ::cppu::WeakImplHelper< 
css::util::XModifyListener >
+{
+public:
+CellRef mxActiveCell;
+TableModelRef mxTable;
+SdrTableObj* mpTableObj;
+std::unique_ptr mpLayouter;
+CellPos maEditPos;
+TableStyleSettings maTableStyle;
+css::uno::Reference< css::container::XIndexAccess > mxTableStyle;
+std::vector> maUndos;
+bool mbSkipChangeLayout;
+
+void CropTableModelToSelection(const CellPos& rStart, const CellPos& rEnd);
+
+CellRef getCell( const CellPos& rPos ) const;
+void LayoutTable( tools::Rectangle& rArea, bool bFitWidth, bool bFitHeight 
);
+
+void ApplyCellStyles();
+void UpdateCells( tools::Rectangle const & rArea );
+
+SdrTableObjImpl();
+virtual ~SdrTableObjImpl() override;
+
+void init( SdrTableObj* pTable, sal_Int32 nColumns,

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format vcl/Library_vcl.mk vcl/source

2022-09-23 Thread Noel Grandin (via logerrit)

 compilerplugins/clang/constantparam.booleans.results |4 
 solenv/clang-format/excludelist  |2 
 vcl/Library_vcl.mk   |1 
 vcl/source/fontsubset/list.cxx   |  229 ---
 vcl/source/fontsubset/list.h |   89 ---
 5 files changed, 325 deletions(-)

New commits:
commit 1cfa1e7a0976dce86a8b4168119c9c6f015ff5ce
Author: Noel Grandin 
AuthorDate: Thu Sep 22 15:32:36 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Sep 23 12:55:11 2022 +0200

remove some dead code

after
commit 590796ca0866168e3129d2abd0a0197114cddcdc
Author: Noel Grandin 
Date:   Wed Sep 21 20:44:42 2022 +0200
convert TrueTypeTable to C++ class

Change-Id: I5c656011ebe37529788cea6a749c07ada2378385
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140433
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/constantparam.booleans.results 
b/compilerplugins/clang/constantparam.booleans.results
index e34c49f419b8..8f04e67d03ec 100644
--- a/compilerplugins/clang/constantparam.booleans.results
+++ b/compilerplugins/clang/constantparam.booleans.results
@@ -4178,10 +4178,6 @@ vcl/source/filter/wmf/wmfwr.hxx:162
 void WMFWriter::WMFRecord_SetBkMode(_Bool)
 _Bool bTransparent
 1
-vcl/source/fontsubset/list.h:64
-int listSkipForward(struct list_ *,int)
-int n
-1
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx:102
 _Bool getSettingValueBool(class std::basic_string_view >,_Bool)
 _Bool bDefault
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 3ad66572897a..9efe16dda8d8 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -14819,8 +14819,6 @@ vcl/source/font/fontcharmap.cxx
 vcl/source/font/fontmetric.cxx
 vcl/source/fontsubset/cff.cxx
 vcl/source/fontsubset/fontsubset.cxx
-vcl/source/fontsubset/list.cxx
-vcl/source/fontsubset/list.h
 vcl/source/fontsubset/sft.cxx
 vcl/source/fontsubset/ttcr.cxx
 vcl/source/fontsubset/ttcr.hxx
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 2b12fabe987b..a432ceb09146 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -493,7 +493,6 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/font/font \
 vcl/source/fontsubset/cff \
 vcl/source/fontsubset/fontsubset \
-vcl/source/fontsubset/list \
 vcl/source/fontsubset/sft \
 vcl/source/fontsubset/ttcr \
 vcl/source/fontsubset/xlat \
diff --git a/vcl/source/fontsubset/list.cxx b/vcl/source/fontsubset/list.cxx
deleted file mode 100644
index aca585678e9c..
--- a/vcl/source/fontsubset/list.cxx
+++ /dev/null
@@ -1,229 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-/*[]---[]*/
-/*| |*/
-/*| list.c - bidirectional list class   |*/
-/*| |*/
-/*| |*/
-/*|  Author: Alexander Gelfenbain   |*/
-/*[]---[]*/
-
-#include 
-#include 
-
-#include "list.h"
-
-namespace {
-
-/*- private data types */
-struct lnode {
-struct lnode *next;
-struct lnode *prev;
-
-void *value;
-
-};
-
-}
-
-struct list_ {
-lnode *head, *tail, *cptr;
-size_t aCount;
-list_destructor eDtor;
-};
-
-/*- private methods */
-
-static lnode *newNode(void *el)
-{
-lnode *ptr = static_cast(std::malloc(sizeof(lnode)));
-assert(ptr != nullptr);
-
-ptr->value = el;
-
-return ptr;
-}
-
-static lnode *appendPrim(list pThis, void *el)
-{
-lnode *ptr = newNode(el);
-lnode **flink, *blink;
-
-if (pThis->tail != nullptr) {
-flink = &(pThis->tail->next);
-blink = pThis->tail;
-} else {
-flink = >head;
-blink = nullptr;
-pThis->cptr = ptr; /*- list was empty - set 
current to this

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

2022-07-06 Thread Noel Grandin (via logerrit)

 solenv/CompilerTest_compilerplugins_clang.mk |   14 --
 solenv/clang-format/excludelist  |   22 +++---
 2 files changed, 11 insertions(+), 25 deletions(-)

New commits:
commit c6923103a2d952aecb154223663688a085065b05
Author: Noel Grandin 
AuthorDate: Wed Jul 6 10:35:59 2022 +0200
Commit: Noel Grandin 
CommitDate: Wed Jul 6 15:48:29 2022 +0200

move old/unused plugins to store

noting that I have only plugins that I wrote or worked on extensively

Change-Id: Ic4931a6ac2df7902cac3968900330a7ce4eb2d57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136841
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/checkunusedparams.cxx 
b/compilerplugins/clang/store/checkunusedparams.cxx
similarity index 100%
rename from compilerplugins/clang/checkunusedparams.cxx
rename to compilerplugins/clang/store/checkunusedparams.cxx
diff --git a/compilerplugins/clang/comparisonwithconstant.cxx 
b/compilerplugins/clang/store/comparisonwithconstant.cxx
similarity index 100%
rename from compilerplugins/clang/comparisonwithconstant.cxx
rename to compilerplugins/clang/store/comparisonwithconstant.cxx
diff --git a/compilerplugins/clang/constfields.cxx 
b/compilerplugins/clang/store/constfields.cxx
similarity index 100%
rename from compilerplugins/clang/constfields.cxx
rename to compilerplugins/clang/store/constfields.cxx
diff --git a/compilerplugins/clang/constfields.py 
b/compilerplugins/clang/store/constfields.py
similarity index 100%
rename from compilerplugins/clang/constfields.py
rename to compilerplugins/clang/store/constfields.py
diff --git a/compilerplugins/clang/constfieldsrewrite.cxx 
b/compilerplugins/clang/store/constfieldsrewrite.cxx
similarity index 100%
rename from compilerplugins/clang/constfieldsrewrite.cxx
rename to compilerplugins/clang/store/constfieldsrewrite.cxx
diff --git a/compilerplugins/clang/constparams.cxx 
b/compilerplugins/clang/store/constparams.cxx
similarity index 100%
rename from compilerplugins/clang/constparams.cxx
rename to compilerplugins/clang/store/constparams.cxx
diff --git a/compilerplugins/clang/constvars.cxx 
b/compilerplugins/clang/store/constvars.cxx
similarity index 100%
rename from compilerplugins/clang/constvars.cxx
rename to compilerplugins/clang/store/constvars.cxx
diff --git a/compilerplugins/clang/convertlong.cxx 
b/compilerplugins/clang/store/convertlong.cxx
similarity index 100%
rename from compilerplugins/clang/convertlong.cxx
rename to compilerplugins/clang/store/convertlong.cxx
diff --git a/compilerplugins/clang/countusersofdefaultparams.cxx 
b/compilerplugins/clang/store/countusersofdefaultparams.cxx
similarity index 100%
rename from compilerplugins/clang/countusersofdefaultparams.cxx
rename to compilerplugins/clang/store/countusersofdefaultparams.cxx
diff --git a/compilerplugins/clang/countusersofdefaultparams.py 
b/compilerplugins/clang/store/countusersofdefaultparams.py
similarity index 100%
rename from compilerplugins/clang/countusersofdefaultparams.py
rename to compilerplugins/clang/store/countusersofdefaultparams.py
diff --git a/compilerplugins/clang/dodgyswitch.cxx 
b/compilerplugins/clang/store/dodgyswitch.cxx
similarity index 100%
rename from compilerplugins/clang/dodgyswitch.cxx
rename to compilerplugins/clang/store/dodgyswitch.cxx
diff --git a/compilerplugins/clang/doubleconvert.cxx 
b/compilerplugins/clang/store/doubleconvert.cxx
similarity index 100%
rename from compilerplugins/clang/doubleconvert.cxx
rename to compilerplugins/clang/store/doubleconvert.cxx
diff --git a/compilerplugins/clang/inlinefields.cxx 
b/compilerplugins/clang/store/inlinefields.cxx
similarity index 100%
rename from compilerplugins/clang/inlinefields.cxx
rename to compilerplugins/clang/store/inlinefields.cxx
diff --git a/compilerplugins/clang/inlinefields.py 
b/compilerplugins/clang/store/inlinefields.py
similarity index 100%
rename from compilerplugins/clang/inlinefields.py
rename to compilerplugins/clang/store/inlinefields.py
diff --git a/compilerplugins/clang/inlinesimplememberfunctions.cxx 
b/compilerplugins/clang/store/inlinesimplememberfunctions.cxx
similarity index 100%
rename from compilerplugins/clang/inlinesimplememberfunctions.cxx
rename to compilerplugins/clang/store/inlinesimplememberfunctions.cxx
diff --git a/compilerplugins/clang/memoryvar.cxx 
b/compilerplugins/clang/store/memoryvar.cxx
similarity index 100%
rename from compilerplugins/clang/memoryvar.cxx
rename to compilerplugins/clang/store/memoryvar.cxx
diff --git a/compilerplugins/clang/namespaceindentation.cxx 
b/compilerplugins/clang/store/namespaceindentation.cxx
similarity index 100%
rename from compilerplugins/clang/namespaceindentation.cxx
rename to compilerplugins/clang/store/namespaceindentation.cxx
diff --git a/compilerplugins/clang/oncevar.cxx 
b/compilerplugins/clang/store/oncevar.cxx
similarity index 100%
rename from compilerplugins/clang/oncevar.cxx
rename to

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

2021-11-17 Thread Luboš Luňák (via logerrit)

 compilerplugins/clang/test/simplifybool.cxx  |  176 ---
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 solenv/clang-format/excludelist  |2 
 3 files changed, 1 insertion(+), 178 deletions(-)

New commits:
commit eb515f11caae5d1b30f7c306fc32111a0cf617b2
Author: Luboš Luňák 
AuthorDate: Wed Nov 17 10:02:06 2021 +0100
Commit: Luboš Luňák 
CommitDate: Wed Nov 17 12:48:36 2021 +0100

retire loplugin:simplifybool

The plugin was originally written to rewrite dumb old OOo code
like 'variable != 1 ? true : false'. All that code has already
been rewritten, and now this plugin just enforces matter-of-taste
stylistics on new code.

Change-Id: I8cd2accd7c0ac365b75dcba51a9049bf9e293869
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125346
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/compilerplugins/clang/simplifybool.cxx 
b/compilerplugins/clang/store/simplifybool.cxx
similarity index 100%
rename from compilerplugins/clang/simplifybool.cxx
rename to compilerplugins/clang/store/simplifybool.cxx
diff --git a/compilerplugins/clang/test/simplifybool.cxx 
b/compilerplugins/clang/test/simplifybool.cxx
deleted file mode 100644
index a32acccd6c19..
--- a/compilerplugins/clang/test/simplifybool.cxx
+++ /dev/null
@@ -1,176 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include 
-// expected-note@rtl/ustring.hxx:* 2 {{the presumed corresponding negated 
operator for 'rtl::OUString' and 'rtl::OUString' is declared here 
[loplugin:simplifybool]}}
-#include 
-// expected-note@rtl/string.hxx:* {{the presumed corresponding negated 
operator for 'rtl::OString' and 'rtl::OString' is declared here 
[loplugin:simplifybool]}}
-#include 
-// expected-note@basegfx/tuple/b3dtuple.hxx:* {{the presumed corresponding 
negated operator for 'basegfx::B3DVector' and 'basegfx::B3DVector' is declared 
here [loplugin:simplifybool]}}
-
-#include 
-
-#pragma clang diagnostic ignored "-Wunknown-warning-option" // for Clang < 13
-#pragma clang diagnostic ignored "-Wunused-but-set-variable"
-
-namespace group1
-{
-void f1(int a, int b)
-{
-if (!(a < b))
-{ // expected-error@-1 {{logical negation of comparison operator, can be 
simplified by inverting operator [loplugin:simplifybool]}}
-a = b;
-}
-};
-
-void f2(float a, float b)
-{
-// no warning expected
-if (!(a < b))
-{
-a = b;
-}
-};
-};
-
-// Consistently either warn about all or none of the below occurrences of "!!":
-namespace group2
-{
-enum E1
-{
-E1_1 = 1
-};
-
-enum E2
-{
-E2_1 = 1
-};
-E2 operator&(E2 e1, E2 e2);
-bool operator!(E2 e);
-
-enum class E3
-{
-E1 = 1
-};
-struct W
-{
-operator bool();
-};
-W operator&(E3 e1, E3 e2);
-
-bool f0(int n) { return !!(n & 1); }
-
-bool f1(E1 e) { return !!(e & E1_1); }
-
-bool f2(E2 e) { return !!(e & E2_1); }
-
-bool f3(E3 e) { return !!(e & E3::E1); }
-};
-
-// record types
-namespace group3
-{
-struct Record1
-{
-bool operator==(const Record1&) const;
-};
-
-struct Record2
-{
-bool operator==(const Record2&) const;
-bool operator!=(const Record2&) const;
-// expected-note@-1 {{the presumed corresponding negated operator for 
'group3::Record2' and 'group3::Record2' is declared here 
[loplugin:simplifybool]}}
-};
-
-struct Record3
-{
-};
-
-bool operator==(const Record3&, const Record3&);
-bool operator!=(const Record3&, const Record3&);
-// expected-note@-1 {{the presumed corresponding negated operator for 
'group3::Record3' and 'group3::Record3' is declared here 
[loplugin:simplifybool]}}
-
-void testRecord()
-{
-Record1 a1;
-Record1 a2;
-// no warning expected, because a negated operator does not exist
-bool v = !(a1 == a2);
-Record2 b1;
-Record2 b2;
-v = !(b1 == b2);
-// expected-error@-1 {{logical negation of comparison operator, can be 
simplified by inverting operator [loplugin:simplifybool]}}
-Record3 c1;
-Record3 c2;
-v = !(c1 == c2);
-// expected-error@-1 {{logical negation of comparison operator, can be 
simplified by inverting operator [loplugin:simplifybool]}}
-OUString d1;
-OUString d2;
-v = !(d1 == d2);
-// expected-error@-1 {{logical negation of comparison operator, can be 
simplified by inverting operator [loplugin:simplifybool]}}
-OString e1;
-OString e2;
-v = !(e1 == e2);
-// expected-error@-1 {{logical negation of comparison operator, can be 
simplified by inverting operator [loplugin:simplifybool]}}
-
-// the operator != is in a base-class, and the param is a base-type
-basegfx::B3DVector f1;
-

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

2021-11-17 Thread Luboš Luňák (via logerrit)

 compilerplugins/clang/test/finalprotected.cxx |   35 --
 solenv/CompilerTest_compilerplugins_clang.mk  |1 
 solenv/clang-format/excludelist   |2 -
 3 files changed, 1 insertion(+), 37 deletions(-)

New commits:
commit bfe589d13fafc0801d709a79144114d289958cae
Author: Luboš Luňák 
AuthorDate: Wed Nov 17 10:04:35 2021 +0100
Commit: Luboš Luňák 
CommitDate: Wed Nov 17 12:48:20 2021 +0100

remove loplugin:finalprotected

It just forces a custom rule that serves no real purpose. There's
no technical difference. If one day a class gets inherited from
then this information will be lost/incorrect. And mixing access
on a virtual function is poor style.

Change-Id: I0c27db8d694ad191a118d4e1d3d4a240e00456fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125337
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/compilerplugins/clang/finalprotected.cxx 
b/compilerplugins/clang/store/finalprotected.cxx
similarity index 100%
rename from compilerplugins/clang/finalprotected.cxx
rename to compilerplugins/clang/store/finalprotected.cxx
diff --git a/compilerplugins/clang/test/finalprotected.cxx 
b/compilerplugins/clang/test/finalprotected.cxx
deleted file mode 100644
index c15564874447..
--- a/compilerplugins/clang/test/finalprotected.cxx
+++ /dev/null
@@ -1,35 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-
-class S final {
-protected:
-void f(int f) { f1 = f; }  // expected-error {{final class should not have 
protected members - convert them to private [loplugin:finalprotected]}}
-int f1;  // expected-error {{final class should not have protected 
members - convert them to private [loplugin:finalprotected]}}
-public:
-void g();
-int g1;
-private:
-void h();
-int h1;
-};
-
-class S2 {
-protected:
-void f(int f) { f1 = f; }
-int f1;
-public:
-void g();
-int g1;
-private:
-void h();
-int h1;
-};
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk 
b/solenv/CompilerTest_compilerplugins_clang.mk
index 53f51e0759ba..75afd793843e 100644
--- a/solenv/CompilerTest_compilerplugins_clang.mk
+++ b/solenv/CompilerTest_compilerplugins_clang.mk
@@ -38,7 +38,6 @@ $(eval $(call 
gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
 compilerplugins/clang/test/external \
 compilerplugins/clang/test/faileddyncast \
 compilerplugins/clang/test/fakebool \
-compilerplugins/clang/test/finalprotected \
 compilerplugins/clang/test/flatten \
 compilerplugins/clang/test/fragiledestructor \
 compilerplugins/clang/test/getstr \
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 2608eb588055..1fd086ffb285 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -1484,7 +1484,6 @@ compilerplugins/clang/externandnotdefined.cxx
 compilerplugins/clang/faileddyncast.cxx
 compilerplugins/clang/fakebool.cxx
 compilerplugins/clang/finalclasses.cxx
-compilerplugins/clang/finalprotected.cxx
 compilerplugins/clang/flatten.cxx
 compilerplugins/clang/fragiledestructor.cxx
 compilerplugins/clang/functionaddress.hxx
@@ -1541,6 +1540,7 @@ compilerplugins/clang/store/deadclass.cxx
 compilerplugins/clang/store/defaultparams.cxx
 compilerplugins/clang/store/deletedspecial.cxx
 compilerplugins/clang/store/derivedclass.cxx
+compilerplugins/clang/store/finalprotected.cxx
 compilerplugins/clang/store/findoncontainer.cxx
 compilerplugins/clang/store/fpcomparison.cxx
 compilerplugins/clang/store/lclstaticfix.cxx

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format sw/inc sw/Library_sw.mk sw/source

2021-10-09 Thread Julien Nabet (via logerrit)

 compilerplugins/clang/constantparam.numbers.results   |4 ++--
 compilerplugins/clang/unusedvariablemore.cxx  |2 +-
 solenv/clang-format/excludelist   |4 ++--
 sw/Library_sw.mk  |2 +-
 sw/inc/pch/precompiled_sw.hxx |2 +-
 sw/source/core/crsr/DateFormFieldButton.cxx   |2 +-
 sw/source/core/crsr/DropDownFormFieldButton.cxx   |2 +-
 sw/source/core/crsr/FormFieldButton.cxx   |2 +-
 sw/source/core/crsr/bookmark.cxx  |2 +-
 sw/source/core/crsr/swcrsr.cxx|2 +-
 sw/source/core/doc/CntntIdxStore.cxx  |2 +-
 sw/source/core/doc/DocumentContentOperationsManager.cxx   |2 +-
 sw/source/core/doc/DocumentLinksAdministrationManager.cxx |2 +-
 sw/source/core/doc/docbm.cxx  |2 +-
 sw/source/core/doc/swserv.cxx |2 +-
 sw/source/core/inc/annotationmark.hxx |2 +-
 sw/source/core/inc/crossrefbookmark.hxx   |2 +-
 sw/source/core/text/porfld.cxx|2 +-
 sw/source/core/text/redlnitr.cxx  |2 +-
 sw/source/core/undo/rolbck.cxx|2 +-
 sw/source/core/view/viewsh.cxx|2 +-
 sw/source/filter/basflt/fltshell.cxx  |2 +-
 sw/source/uibase/shells/textsh1.cxx   |2 +-
 23 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit 21b2c6b7d8f4661dcbd40df4f8b9126d331cbd7f
Author: Julien Nabet 
AuthorDate: Sat Oct 9 21:48:41 2021 +0200
Commit: Julien Nabet 
CommitDate: Sat Oct 9 23:17:06 2021 +0200

Rename bookmrk* -> bookmark*

Change-Id: I9dec77b2af8abe5abb286ff76ed85d1e4078ee6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123325
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/compilerplugins/clang/constantparam.numbers.results 
b/compilerplugins/clang/constantparam.numbers.results
index baacd2131d57..faa5ad0485a6 100644
--- a/compilerplugins/clang/constantparam.numbers.results
+++ b/compilerplugins/clang/constantparam.numbers.results
@@ -2886,11 +2886,11 @@ sw/source/core/access/accmap.cxx:469
 void SwAccessibleEvent_Impl::SwAccessibleEvent_Impl(enum 
SwAccessibleEvent_Impl::EventType,const class SwFrame *,const class 
sw::access::SwAccessibleChild &,const class SwRect &)
 enum SwAccessibleEvent_Impl::EventType eT
 3
-sw/source/core/crsr/bookmrk.cxx:160
+sw/source/core/crsr/bookmark.cxx:160
 void lcl_SetFieldMarks(class sw::mark::Fieldmark &,class SwDoc &,const 
char16_t,const char16_t,const struct SwPosition *const)
 const char16_t aStartMark
 7
-sw/source/core/crsr/bookmrk.cxx:216
+sw/source/core/crsr/bookmark.cxx:216
 void lcl_RemoveFieldMarks(const class sw::mark::Fieldmark &,class SwDoc 
&,const char16_t,const char16_t)
 const char16_t aStartMark
 7
diff --git a/compilerplugins/clang/unusedvariablemore.cxx 
b/compilerplugins/clang/unusedvariablemore.cxx
index b4394b31f8d6..f165a6d6b50c 100644
--- a/compilerplugins/clang/unusedvariablemore.cxx
+++ b/compilerplugins/clang/unusedvariablemore.cxx
@@ -98,7 +98,7 @@ void UnusedVariableMore::run()
 if (fn == SRCDIR "/sc/source/ui/miscdlgs/simpref.cxx")
 return;
 // Using an SwPaM to do stuff
-if (fn == SRCDIR "/sw/source/core/crsr/bookmrk.cxx")
+if (fn == SRCDIR "/sw/source/core/crsr/bookmark.cxx")
 return;
 // index variable in for loop?
 if (fn == SRCDIR "/sw/source/uibase/docvw/edtwin.cxx")
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 92219dba46ae..163d778fb3b1 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -12401,7 +12401,7 @@ sw/source/core/bastyp/swregion.cxx
 sw/source/core/bastyp/tabcol.cxx
 sw/source/core/crsr/BlockCursor.hxx
 sw/source/core/crsr/annotationmark.cxx
-sw/source/core/crsr/bookmrk.cxx
+sw/source/core/crsr/bookmark.cxx
 sw/source/core/crsr/callnk.cxx
 sw/source/core/crsr/callnk.hxx
 sw/source/core/crsr/crbm.cxx
@@ -12600,7 +12600,7 @@ sw/source/core/inc/anchoredobjectposition.hxx
 sw/source/core/inc/annotationmark.hxx
 sw/source/core/inc/ascharanchoredobjectposition.hxx
 sw/source/core/inc/bodyfrm.hxx
-sw/source/core/inc/bookmrk.hxx
+sw/source/core/inc/bookmark.hxx
 sw/source/core/inc/cellfrm.hxx
 sw/source/core/inc/cntfrm.hxx
 sw/source/core/inc/crossrefbookmark.hxx
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index 8f9398d2ab8b..87018ce438b9 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -147,7 +147,7 @@ $(eval $(call gb_Library_add_exception_objects,sw,\
 sw/source/core/bastyp/tabcol \
 sw/source/core/crsr/annotationmark \
 sw/source/core/crsr/BlockCursor \
-sw/source/core/crsr/bookmrk \
+

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format vcl/Library_vclplug_gtk3.mk vcl/unx

2021-05-10 Thread Caolán McNamara (via logerrit)

 compilerplugins/clang/badstatics.cxx   |2 
 compilerplugins/clang/store/constantfunction.cxx   |2 
 compilerplugins/clang/useuniqueptr.cxx |3 
 solenv/clang-format/excludelist|   56 -
 vcl/Library_vclplug_gtk3.mk|   54 
 vcl/unx/gtk3/gtkcairo.cxx  |2 
 vcl/unx/gtk3/salnativewidgets-gtk.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkaction.cxx |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkbridge.cxx |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkcomponent.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkeditabletext.cxx   |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkfactory.cxx|2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkhypertext.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkimage.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atklistener.cxx   |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkregistry.cxx   |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkselection.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktable.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktext.cxx   |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktextattributes.cxx |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkutil.cxx   |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkvalue.cxx  |2 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkwrapper.cxx|2 
 vcl/unx/gtk3_kde5/gtk3_kde5_cairo.cxx  |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gloactiongroup.cxx |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_glomenu.cxx|2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkdata.cxx|2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkframe.cxx   |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.cxx|2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkobject.cxx  |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtksalmenu.cxx |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtksys.cxx |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_hudawareness.cxx   |2 
 vcl/unx/gtk3_kde5/gtk3_kde5_salnativewidgets-gtk.cxx   |2 
 34 files changed, 87 insertions(+), 88 deletions(-)

New commits:
commit 2dbf36132a8886b94c5fbb2255dfae9e6028a5bd
Author: Caolán McNamara 
AuthorDate: Fri May 7 12:29:47 2021 +0100
Commit: Caolán McNamara 
CommitDate: Mon May 10 10:56:58 2021 +0200

rename to remove the gtk3 prefix

Change-Id: I219798ed42aff11d09fd45c26ca1a018c2d22c08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115239
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/compilerplugins/clang/badstatics.cxx 
b/compilerplugins/clang/badstatics.cxx
index 3f4d6cddecd3..bb6241eafa5e 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -197,7 +197,7 @@ public:
 // sc/source/core/tool/adiasync.cxx, would leak
 // ScAddInAsync* keys if that set is not empty at exit
 || name == "g_aWindowList"
-//vcl/unx/gtk3/a11y/gtk3atkutil.cxx, asserted empty at exit
+//vcl/unx/gtk3/a11y/atkutil.cxx, asserted empty at exit
 || name == "gFontPreviewVirDevs"
 //svtools/source/control/ctrlbox.cxx, empty at exit
 || name == "aLogger" // FormulaLogger& FormulaLogger::get() in 
sc/source/core/tool/formulalogger.cxx
diff --git a/compilerplugins/clang/store/constantfunction.cxx 
b/compilerplugins/clang/store/constantfunction.cxx
index a29556723748..a7b88704c09e 100644
--- a/compilerplugins/clang/store/constantfunction.cxx
+++ b/compilerplugins/clang/store/constantfunction.cxx
@@ -32,7 +32,7 @@ public:
 if 
(strstr(compiler.getSourceManager().getFileEntryForID(mainFileID)->getName(), 
"bootstrapfixture.cxx") != 0) {
 return;
 }
-if 
(strstr(compiler.getSourceManager().getFileEntryForID(mainFileID)->getName(), 
"gtk3gtkinst.cxx") != 0) {
+if 
(strstr(compiler.getSourceManager().getFileEntryForID(mainFileID)->getName(), 
"gtkinst.cxx") != 0) {
 return;
 }*/
 
diff --git a/compilerplugins/clang/useuniqueptr.cxx 
b/compilerplugins/clang/useuniqueptr.cxx
index a25b016c6799..c26e3db11365 100644
--- a/compilerplugins/clang/useuniqueptr.cxx
+++ b/compilerplugins/clang/useuniqueptr.cxx
@@ -351,8 +351,7 @@ void UseUniquePtr::CheckDeleteLocalVar(const FunctionDecl* 
functionDecl, const C
 if 
(loplugin::TypeCheck(varDecl->getType()).Pointer().Class("IMapCompat").GlobalNamespace())
 return;
 // passing data to gtk API and I can't figure out the types
-if (fn == SRCDIR "/vcl/unx/gtk3/gtk3gtkdata.cxx"
-|| fn == SRCDIR "/vcl/unx/gtk/gtkdata.cxx")
+if (fn == SRCDIR "/vcl/unx/gtk3/gtkdata.cxx")
 return;
 // sometimes this stuff is held by tools::SvRef, sometimes by

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format starmath/inc starmath/Library_sm.mk starmath/mathml starmath/source

2021-01-18 Thread dante (via logerrit)

 compilerplugins/clang/constantparam.booleans.results |2 
 compilerplugins/clang/singlevalfields.results|2 
 solenv/clang-format/excludelist  |1 
 starmath/Library_sm.mk   |   11 -
 starmath/inc/cfgitem.hxx |  189 +++
 starmath/mathml/inc/starmathdatabase.hxx |2 
 starmath/mathml/source/mathmlattr.cxx|2 
 starmath/mathml/source/mathmlexport.cxx  |6 
 starmath/mathml/source/mathmlimport.cxx  |6 
 starmath/mathml/source/xparsmlbase.cxx   |2 
 starmath/source/cfgitem.cxx  |2 
 starmath/source/cfgitem.hxx  |  186 --
 starmath/source/dialog.cxx   |2 
 starmath/source/document.cxx |6 
 starmath/source/edit.cxx |2 
 starmath/source/parse.cxx|2 
 starmath/source/smmod.cxx|2 
 starmath/source/symbol.cxx   |2 
 starmath/source/unomodel.cxx |2 
 starmath/source/view.cxx |4 
 20 files changed, 218 insertions(+), 215 deletions(-)

New commits:
commit e552ddda9abf7b9c285972e0d15a5b28d721c530
Author: dante 
AuthorDate: Sun Jan 3 20:47:02 2021 +0100
Commit: Noel Grandin 
CommitDate: Mon Jan 18 13:12:27 2021 +0100

Mathml gets it's own directory

It has grown recently and is going to grow more.
cfgitem.hxx has been moved and clangformated because it is not anymore in 
excludelist

Change-Id: I277837b2c0a90ae4e84028dc6e19962939c1aef3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108645
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/constantparam.booleans.results 
b/compilerplugins/clang/constantparam.booleans.results
index 1a183059a193..18cf2a58bb2e 100644
--- a/compilerplugins/clang/constantparam.booleans.results
+++ b/compilerplugins/clang/constantparam.booleans.results
@@ -3350,7 +3350,7 @@ starmath/inc/rect.hxx:175
 class SmRect & SmRect::ExtendBy(const class SmRect &,enum 
RectCopyMBL,_Bool)
 enum RectCopyMBL eCopyMode
 0
-starmath/source/cfgitem.hxx:85
+starmath/inc/cfgitem.hxx:85
 class rtl::OUString SmFontFormatList::GetFontFormatId(const struct 
SmFontFormat &,_Bool)
 _Bool bAdd
 1
diff --git a/compilerplugins/clang/singlevalfields.results 
b/compilerplugins/clang/singlevalfields.results
index 5434059344e7..cd8595bef3b8 100644
--- a/compilerplugins/clang/singlevalfields.results
+++ b/compilerplugins/clang/singlevalfields.results
@@ -655,7 +655,7 @@ soltools/mkdepend/def.h:189
 starmath/inc/edit.hxx:57
 SmEditWindow aModifyIdle
 SmEditWindow ModifyIdle
-starmath/source/cfgitem.hxx:102
+starmath/inc/cfgitem.hxx:109
 SmMathConfig vFontPickList
 5
 stoc/source/corereflection/lrucache.hxx:52
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index bef00255118e..edd2eb530360 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -11043,7 +11043,6 @@ starmath/source/accessibility.hxx
 starmath/source/action.cxx
 starmath/source/caret.cxx
 starmath/source/cfgitem.cxx
-starmath/source/cfgitem.hxx
 starmath/source/cursor.cxx
 starmath/source/dialog.cxx
 starmath/source/document.cxx
diff --git a/starmath/Library_sm.mk b/starmath/Library_sm.mk
index cc3dab8875e7..204072aff092 100644
--- a/starmath/Library_sm.mk
+++ b/starmath/Library_sm.mk
@@ -17,6 +17,7 @@ $(eval $(call 
gb_Library_set_precompiled_header,sm,starmath/inc/pch/precompiled_
 
 $(eval $(call gb_Library_set_include,sm,\
 -I$(SRCDIR)/starmath/inc \
+-I$(SRCDIR)/starmath/mathml/inc \
 -I$(WORKDIR)/SdiTarget/starmath/sdi \
 $$(INCLUDE) \
 ))
@@ -74,10 +75,6 @@ $(eval $(call gb_Library_add_exception_objects,sm,\
 starmath/source/document \
 starmath/source/edit \
 starmath/source/format \
-starmath/source/xparsmlbase \
-starmath/source/mathmlattr \
-starmath/source/mathmlexport \
-starmath/source/mathmlimport \
 starmath/source/mathtype \
 starmath/source/node \
 starmath/source/ooxmlexport \
@@ -99,7 +96,11 @@ $(eval $(call gb_Library_add_exception_objects,sm,\
 starmath/source/view \
 starmath/source/visitors \
 starmath/source/wordexportbase \
-starmath/source/starmathdatabase \
+starmath/mathml/source/xparsmlbase \
+starmath/mathml/source/mathmlattr \
+starmath/mathml/source/mathmlexport \
+starmath/mathml/source/mathmlimport \
+starmath/mathml/source/starmathdatabase \
 ))
 
 
diff --git a/starmath/inc/cfgitem.hxx b/starmath/inc/cfgitem.hxx
new file mode 100644
index ..35f0955c243a
--- /dev/null

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

2020-11-21 Thread Philipp Hofer (via logerrit)

 compilerplugins/clang/expressionalwayszero.cxx  |   54 +++-
 compilerplugins/clang/store/cascadingcondop.cxx |   25 +--
 compilerplugins/clang/store/test/deadclass.cxx  |3 -
 compilerplugins/clang/test/datamembershadow.cxx |6 +-
 compilerplugins/clang/test/external.hxx |5 --
 compilerplugins/clang/test/oslendian-1.cxx  |   12 ++---
 compilerplugins/clang/test/redundantcast.hxx|   11 ++--
 compilerplugins/clang/test/stringconcatauto.cxx |   34 ++-
 solenv/clang-format/excludelist |8 ---
 9 files changed, 72 insertions(+), 86 deletions(-)

New commits:
commit c096ab87c8a11e8d75dc689ea7024288419cfd22
Author: Philipp Hofer 
AuthorDate: Thu Nov 12 12:51:50 2020 +0100
Commit: Christian Lohmaier 
CommitDate: Sun Nov 22 01:56:05 2020 +0100

tdf#123936 Formatting files in module compilerplugins with clang-format

Change-Id: Ie6e23d3d2a20849e47d048b439d72fd7376c53db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105654
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/compilerplugins/clang/expressionalwayszero.cxx 
b/compilerplugins/clang/expressionalwayszero.cxx
index 067aa9cc6dbd..24e7287615ba 100644
--- a/compilerplugins/clang/expressionalwayszero.cxx
+++ b/compilerplugins/clang/expressionalwayszero.cxx
@@ -21,13 +21,15 @@
 Generally a mistake when people meant to use | or operator|
 */
 
-namespace {
-
-class ExpressionAlwaysZero:
-public loplugin::FilteringPlugin
+namespace
+{
+class ExpressionAlwaysZero : public 
loplugin::FilteringPlugin
 {
 public:
-explicit ExpressionAlwaysZero(loplugin::InstantiationData const & data): 
FilteringPlugin(data) {}
+explicit ExpressionAlwaysZero(loplugin::InstantiationData const& data)
+: FilteringPlugin(data)
+{
+}
 
 virtual void run() override
 {
@@ -57,15 +59,16 @@ public:
 TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
 }
 
-bool VisitBinaryOperator(BinaryOperator const *);
-bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const *);
-bool TraverseStaticAssertDecl(StaticAssertDecl *);
+bool VisitBinaryOperator(BinaryOperator const*);
+bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const*);
+bool TraverseStaticAssertDecl(StaticAssertDecl*);
+
 private:
 // note, abusing std::unique_ptr as a std::optional lookalike
 std::unique_ptr getExprValue(const Expr* arg);
 };
 
-bool ExpressionAlwaysZero::VisitBinaryOperator( BinaryOperator const * 
binaryOperator )
+bool ExpressionAlwaysZero::VisitBinaryOperator(BinaryOperator const* 
binaryOperator)
 {
 if (ignoreLocation(binaryOperator))
 return true;
@@ -86,16 +89,14 @@ bool ExpressionAlwaysZero::VisitBinaryOperator( 
BinaryOperator const * binaryOpe
 ; // ok
 else
 return true;
-report(
-DiagnosticsEngine::Warning, "expression always evaluates to zero, 
lhs=%0 rhs=%1",
-compat::getBeginLoc(binaryOperator))
+report(DiagnosticsEngine::Warning, "expression always evaluates to zero, 
lhs=%0 rhs=%1",
+   compat::getBeginLoc(binaryOperator))
 << (lhsValue ? lhsValue->toString(10) : "unknown")
-<< (rhsValue ? rhsValue->toString(10) : "unknown")
-<< binaryOperator->getSourceRange();
+<< (rhsValue ? rhsValue->toString(10) : "unknown") << 
binaryOperator->getSourceRange();
 return true;
 }
 
-bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr( CXXOperatorCallExpr const 
* cxxOperatorCallExpr )
+bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr(CXXOperatorCallExpr const* 
cxxOperatorCallExpr)
 {
 if (ignoreLocation(cxxOperatorCallExpr))
 return true;
@@ -103,7 +104,7 @@ bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr( 
CXXOperatorCallExpr const *
 return true;
 
 auto op = cxxOperatorCallExpr->getOperator();
-if ( !(op == OO_Amp || op == OO_AmpEqual || op == OO_AmpAmp))
+if (!(op == OO_Amp || op == OO_AmpEqual || op == OO_AmpAmp))
 return true;
 
 if (cxxOperatorCallExpr->getNumArgs() != 2)
@@ -118,20 +119,19 @@ bool ExpressionAlwaysZero::VisitCXXOperatorCallExpr( 
CXXOperatorCallExpr const *
 ; // ok
 else
 return true;
-report(
-DiagnosticsEngine::Warning, "expression always evaluates to zero, 
lhs=%0 rhs=%1",
-compat::getBeginLoc(cxxOperatorCallExpr))
+report(DiagnosticsEngine::Warning, "expression always evaluates to zero, 
lhs=%0 rhs=%1",
+   compat::getBeginLoc(cxxOperatorCallExpr))
 << (lhsValue ? lhsValue->toString(10) : "unknown")
-<< (rhsValue ? rhsValue->toString(10) : "unknown")
-<< cxxOperatorCallExpr->getSourceRange();
+<< (rhsValue ? rhsValue->toString(10) : "unknown") << 
cxxOperatorCallExpr->getSourceRange();
 return true;
 }
 
-std::unique_ptr ExpressionAlwaysZero::getExprValue(Expr const * expr)
+std::unique_ptr

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format vcl/inc

2020-08-24 Thread Caolán McNamara (via logerrit)

 compilerplugins/clang/unusedenumconstants.py |1 
 compilerplugins/clang/unusedfields.py|4 
 solenv/clang-format/excludelist  |1 
 vcl/inc/unx/XIM.h|  111 ---
 4 files changed, 117 deletions(-)

New commits:
commit 4557f04ee9aadc0b399a3bd2e08133d4929221b9
Author: Caolán McNamara 
AuthorDate: Mon Aug 24 16:07:27 2020 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 24 18:16:52 2020 +0200

remove unused XIM.h

Change-Id: Icf15604a2d449159fceb212717264952e8cacb33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101282
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/compilerplugins/clang/unusedenumconstants.py 
b/compilerplugins/clang/unusedenumconstants.py
index 34a459bd0b54..aff9efd12ef4 100755
--- a/compilerplugins/clang/unusedenumconstants.py
+++ b/compilerplugins/clang/unusedenumconstants.py
@@ -183,7 +183,6 @@ def is_ignore(srcLoc):
 # represents constants from an external API
  "opencl/inc/opencl_device_selection.h",
  "vcl/inc/sft.hxx",
- "vcl/inc/unx/XIM.h",
  "vcl/unx/gtk/xid_fullscreen_on_all_monitors.c",
  "vcl/unx/gtk/salnativewidgets-gtk.cxx",
  "sc/inc/callform.hxx", # ParamType
diff --git a/compilerplugins/clang/unusedfields.py 
b/compilerplugins/clang/unusedfields.py
index f98f2777ced1..6dcf3a85b7bc 100755
--- a/compilerplugins/clang/unusedfields.py
+++ b/compilerplugins/clang/unusedfields.py
@@ -70,7 +70,6 @@ for d in definitionSet:
 or srcLoc.startswith("sw/source/filter/ww8/")
 or srcLoc.startswith("vcl/source/filter/sgvmain.hxx")
 or srcLoc.startswith("vcl/source/filter/sgfbram.hxx")
-or srcLoc.startswith("vcl/inc/unx/XIM.h")
 or srcLoc.startswith("vcl/inc/unx/gtk/gloactiongroup.h")
 or srcLoc.startswith("include/svl/svdde.hxx")
 or srcLoc.startswith("lotuswordpro/source/filter/lwpsdwdrawheader.hxx")
@@ -108,7 +107,6 @@ for d in definitionSet:
 or srcLoc.startswith("sw/source/filter/ww8/")
 or srcLoc.startswith("vcl/source/filter/sgvmain.hxx")
 or srcLoc.startswith("vcl/source/filter/sgfbram.hxx")
-or srcLoc.startswith("vcl/inc/unx/XIM.h")
 or srcLoc.startswith("vcl/inc/unx/gtk/gloactiongroup.h")
 or srcLoc.startswith("include/svl/svdde.hxx")
 or srcLoc.startswith("lotuswordpro/source/filter/lwpsdwdrawheader.hxx")
@@ -146,7 +144,6 @@ for d in definitionSet:
 or srcLoc.startswith("sw/source/filter/ww8/")
 or srcLoc.startswith("vcl/source/filter/sgvmain.hxx")
 or srcLoc.startswith("vcl/source/filter/sgfbram.hxx")
-or srcLoc.startswith("vcl/inc/unx/XIM.h")
 or srcLoc.startswith("vcl/inc/unx/gtk/gloactiongroup.h")
 or srcLoc.startswith("include/svl/svdde.hxx")
 or srcLoc.startswith("lotuswordpro/source/filter/lwpsdwdrawheader.hxx")
@@ -200,7 +197,6 @@ for d in definitionSet:
 or srcLoc.startswith("sw/source/filter/ww8/")
 or srcLoc.startswith("vcl/source/filter/sgvmain.hxx")
 or srcLoc.startswith("vcl/source/filter/sgfbram.hxx")
-or srcLoc.startswith("vcl/inc/unx/XIM.h")
 or srcLoc.startswith("vcl/inc/unx/gtk/gloactiongroup.h")
 or srcLoc.startswith("include/svl/svdde.hxx")):
 continue
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index f080951b0d8c..e30a82513bfa 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -16654,7 +16654,6 @@ vcl/inc/textlayout.hxx
 vcl/inc/textlineinfo.hxx
 vcl/inc/textrender.hxx
 vcl/inc/toolbox.h
-vcl/inc/unx/XIM.h
 vcl/inc/unx/cairotextrender.hxx
 vcl/inc/unx/cpdmgr.hxx
 vcl/inc/unx/cupsmgr.hxx
diff --git a/vcl/inc/unx/XIM.h b/vcl/inc/unx/XIM.h
deleted file mode 100644
index 97379ed03c0b..
--- a/vcl/inc/unx/XIM.h
+++ /dev/null
@@ -1,111 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#ifndef INCLUDED_VCL_INC_UNX_XIM_H
-#define INCLUDED_VCL_INC_UNX_XIM_H
-
-#include 
-
-#ifndef XIMCallback1
-typedef int

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

2020-07-02 Thread Stephan Bergmann (via logerrit)

 compilerplugins/clang/check.cxx   |   10 ++
 compilerplugins/clang/check.hxx   |2 
 compilerplugins/clang/redundantstatic.cxx |  123 ++
 compilerplugins/clang/staticanonymous.cxx |   70 -
 solenv/clang-format/blacklist |2 
 5 files changed, 136 insertions(+), 71 deletions(-)

New commits:
commit f4c126da920b06d273ddd375d7f77faa39f01cb5
Author: Stephan Bergmann 
AuthorDate: Thu Jul 2 21:12:04 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Thu Jul 2 23:27:05 2020 +0200

Improved loplugin:staticanonymous -> redundantstatic

...now also covering variables with internal linkage that don't need a 
redundant
"static".  (Unlike with functions, with variables there are also cases that 
are
not in an unnamed namespace, hence the rename of the plugin.)

All the relevant changes across the code base have been done in the 
preceding
"Upcoming improved loplugin:staticanonymous -> redundantstatic" commits.
Ideally the changes would have been done with a rewriting plugin, but it 
can be
quite tedious in general to identify the correct occurrence of "static" that
must be removed, consider e.g.

  struct { int init() { static int n; return n++; } int x = init(); } static
  const a[10] = {};

However, it turned out that in all cases across the code base, the relevant
"static" was either at the start of the declaration or came after an initial
"const".  So I temporarily changed the plugin with

> --- a/compilerplugins/clang/redundantstatic.cxx
> +++ b/compilerplugins/clang/redundantstatic.cxx
> @@ -59,7 +59,7 @@ class RedundantStatic
>  }
>  report(
>  DiagnosticsEngine::Warning, "redundant 'static' 
keyword in unnamed namespace",
> -decl->getLocation())
> +decl->getBeginLoc())
>  << decl->getSourceRange();
>  return true;
>  }
> @@ -73,7 +73,7 @@ class RedundantStatic
>  DiagnosticsEngine::Warning,
>  "non-inline variable of non-volatile const-qualified 
type is redundantly marked as"
>  " 'static'",
> -decl->getLocation())
> +decl->getBeginLoc())
>  << decl->getSourceRange();
>  return true;
>  }

to report the diagnostics at the start of the declarations (instead of at a 
more
natural place which is typically somewhere in the middle of the 
declaration),
compiled LO from within Emacs and then ran a function

> (defun doit ()
>   (interactive)
>   (while t
> (next-error)
> (with-current-buffer (window-buffer)
>   (when (re-search-forward
>  "\\=\\(s *\\|\\()\\s 
+)"
>  nil t)
> (replace-match "\\2")

to do all the replacements.  (Plus 
solenv/clang-format/reformat-formatted-files
where necessary.)

Change-Id: Ie7efc8e0593a407c390a6a7a08c81e547410f18a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97779
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/check.cxx b/compilerplugins/clang/check.cxx
index b4317c07bcf7..2ae58504fe3b 100644
--- a/compilerplugins/clang/check.cxx
+++ b/compilerplugins/clang/check.cxx
@@ -64,6 +64,16 @@ TypeCheck TypeCheck::ConstVolatile() const {
 // checking for
 }
 
+TypeCheck TypeCheck::ConstNonVolatile() const {
+return
+(!type_.isNull() && type_.isConstQualified()
+ && !type_.isVolatileQualified())
+? *this : TypeCheck();
+// returning TypeCheck(type_.getUnqualifiedType()) instead of *this
+// may look tempting, but could remove sugar we might be interested in
+// checking for
+}
+
 TerminalCheck TypeCheck::Void() const {
 return TerminalCheck(
 !type_.isNull()
diff --git a/compilerplugins/clang/check.hxx b/compilerplugins/clang/check.hxx
index 8e835b8b6a96..f8793e14216c 100644
--- a/compilerplugins/clang/check.hxx
+++ b/compilerplugins/clang/check.hxx
@@ -51,6 +51,8 @@ public:
 
 TypeCheck ConstVolatile() const;
 
+TypeCheck ConstNonVolatile() const;
+
 TerminalCheck Void() const;
 
 TerminalCheck Char() const;
diff --git a/compilerplugins/clang/redundantstatic.cxx 
b/compilerplugins/clang/redundantstatic.cxx
new file mode 100644
index ..95a3c85c9d17
--- /dev/null
+++ b/compilerplugins/clang/redundantstatic.cxx
@@ -0,0 +1,123 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * Based on LLVM/Clang.
+ *
+ */
+#ifndef LO_CLANG_SHARED_PLUGINS
+
+#include "check.hxx"
+#include "compat.hxx"
+#include "plugin.hxx"
+
+/*
+This

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

2020-07-01 Thread Stephan Bergmann (via logerrit)

 compilerplugins/clang/external.cxx   |   13 +++
 compilerplugins/clang/externvar.cxx  |   95 ---
 compilerplugins/clang/test/external.cxx  |   70 +++
 compilerplugins/clang/test/external.hxx  |7 -
 compilerplugins/clang/test/externvar.cxx |   61 -
 solenv/CompilerTest_compilerplugins_clang.mk |1 
 solenv/clang-format/blacklist|4 -
 7 files changed, 84 insertions(+), 167 deletions(-)

New commits:
commit 631cec87e2da1925246e4a1902cec6f2952f939e
Author: Stephan Bergmann 
AuthorDate: Wed Jul 1 16:45:28 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Jul 1 19:50:42 2020 +0200

loplugin:externvar is covered by loplugin:external

...so drop the former.  But keep the relevant externvar tests by moving them
into compilerplugins/clang/test/external.cxx.  (Which revealed one 
difference
between the two plugins, regarding certain extern "C" variables in unnamed
namespaces, where Clang (and for that matter also e.g. GCC, it appears)
deliberately deviates from the Standard and considers them to have external
linkage.  Add clarifying comments that loplugin:external keeps considering 
these
as having internal linkage, following the Standard.)

Change-Id: I344fcd0135fdaf6bf08a4b396af2ed2299389a7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97639
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/external.cxx 
b/compilerplugins/clang/external.cxx
index 6ec2cfdb1c8d..bc75237a15fd 100644
--- a/compilerplugins/clang/external.cxx
+++ b/compilerplugins/clang/external.cxx
@@ -471,8 +471,17 @@ private:
 {
 return true;
 }
-//TODO: in some cases getLinkageInternal() appears to report 
ExternalLinkage instead of
-// UniqueExternalLinkage:
+// In some cases getLinkageInternal() arguably wrongly reports 
ExternalLinkage, see the
+// commit message of  "DR1113: anonymous 
namespaces formally give
+// their contents internal linkage":
+//
+//  "We still deviate from the standard in one regard here: extern "C" 
declarations
+//   in anonymous namespaces are still granted external linkage. 
Changing those does
+//   not appear to have been an intentional consequence of the 
standard change in
+//   DR1113."
+//
+// Do not warn about such "wrongly external" declarations here:
 if (decl->isInAnonymousNamespace())
 {
 return true;
diff --git a/compilerplugins/clang/externvar.cxx 
b/compilerplugins/clang/externvar.cxx
deleted file mode 100644
index 05e9820d4da3..
--- a/compilerplugins/clang/externvar.cxx
+++ /dev/null
@@ -1,95 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#ifndef LO_CLANG_SHARED_PLUGINS
-
-#include "check.hxx"
-#include "plugin.hxx"
-
-// Find variable declarations at namespace scope that need not have external
-// linkage.
-
-namespace {
-
-class ExternVar: public loplugin::FilteringPlugin
-{
-public:
-explicit ExternVar(loplugin::InstantiationData const & data): 
FilteringPlugin(data)
-{}
-
-void run() override
-{ TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
-
-bool VisitVarDecl(VarDecl const * decl) {
-if (ignoreLocation(decl)) {
-return true;
-}
-if (decl->isStaticDataMember()) {
-return true;
-}
-if (!(decl->isFirstDecl()
-  && compiler.getSourceManager().isInMainFile(decl->getLocation())
-  && loplugin::hasExternalLinkage(decl)))
-{
-return true;
-}
-auto def = decl->getDefinition();
-if (def == nullptr) {
-// Code like
-//
-//   namespace { extern int v; }
-//   int f() { return sizeof(v); }
-//
-// is already handled by Clang itself with an error "variable 'v' 
is
-// not needed and will not be emitted"
-return true;
-}
-if (loplugin::DeclCheck(def).Var("_pRawDllMain").GlobalNamespace()) {
-return true;
-}
-SourceLocation argLoc;
-if 
(compiler.getSourceManager().isMacroArgExpansion(def->getLocation(), )
-&& (Lexer::getImmediateMacroName(
-argLoc, compiler.getSourceManager(), 
compiler.getLangOpts())
-== "DEFINE_GUID"))
-{
-

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

2020-02-03 Thread Luboš Luňák (via logerrit)

 compilerplugins/clang/pluginhandler.cxx |6 +
 compilerplugins/clang/sharedvisitor/dummyplugin.hxx |   73 
 compilerplugins/clang/sharedvisitor/generator.cxx   |   10 ++
 compilerplugins/clang/unusedmember.cxx  |4 -
 compilerplugins/clang/vclwidgets.cxx|4 -
 solenv/clang-format/blacklist   |1 
 6 files changed, 89 insertions(+), 9 deletions(-)

New commits:
commit 81bd3b4a85c7ae6e642969596701bbed645752ff
Author: Luboš Luňák 
AuthorDate: Mon Jan 27 22:25:13 2020 +0100
Commit: Luboš Luňák 
CommitDate: Mon Feb 3 11:26:43 2020 +0100

significantly reduce build time of sharedvisitor.cxx

In the sharedvisitor.cxx mode all plugins need just one shared
RecursiveASTVisitor template instance, but as long as they use another
instance each as the base class, Clang still instantiates those templates
and then spends a lot of time optimizing each of them, even though they
should never get used.
So when compiling using sharedvisitor.cxx simply use dummy base classes
that do not do anything. As an additional check they abort() if any
of the functions get called, this needed removing vclwidgets and
unusedmember from shared plugins, because they call TraverseStmt(),
maybe this can get handled somehow later.

Change-Id: Ic5a350da2c3ba31521f71077b1776b1ee8f06dea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87561
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/compilerplugins/clang/pluginhandler.cxx 
b/compilerplugins/clang/pluginhandler.cxx
index 492561fb3a3e..54dba3e3bcc0 100644
--- a/compilerplugins/clang/pluginhandler.cxx
+++ b/compilerplugins/clang/pluginhandler.cxx
@@ -146,7 +146,11 @@ void PluginHandler::createPlugins( std::set< std::string > 
rewriters )
 const char* name = plugins[i].optionName;
 // When in unit-test mode, ignore plugins whose names don't match the 
filename of the test,
 // so that we only generate warnings for the plugin that we want to 
test.
-if (unitTestMode && mainFileName.find(plugins[ i ].optionName) == 
StringRef::npos)
+// Sharedvisitor plugins still need to remain enabled, they don't do 
anything on their own,
+// but sharing-capable plugins need them to actually work (if compiled 
so) and they register
+// with them in the code below.
+if (unitTestMode && mainFileName.find(plugins[ i ].optionName) == 
StringRef::npos
+&& !plugins[ i ].isSharedPlugin)
 continue;
 if( rewriters.erase( name ) != 0 )
 plugins[ i ].object = plugins[ i ].create( InstantiationData { 
name, *this, compiler,  } );
diff --git a/compilerplugins/clang/sharedvisitor/dummyplugin.hxx 
b/compilerplugins/clang/sharedvisitor/dummyplugin.hxx
new file mode 100644
index ..7ea085c752de
--- /dev/null
+++ b/compilerplugins/clang/sharedvisitor/dummyplugin.hxx
@@ -0,0 +1,73 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * Based on LLVM/Clang.
+ *
+ * This file is distributed under the University of Illinois Open Source
+ * License. See LICENSE.TXT for details.
+ *
+ */
+
+#ifndef DUMMYPLUGIN_H
+#define DUMMYPLUGIN_H
+
+#include "../plugin.hxx"
+
+using namespace clang;
+using namespace llvm;
+
+namespace loplugin
+{
+
+// These classes are used as base classes when building with 
LO_CLANG_SHARED_PLUGINS.
+// Since plugin classes in that case should use just one shared 
RecursiveASTVisitor,
+// sharedvisitor/generator.cxx will make these to be the base classes used, so 
that
+// compiling the code doesn't spend a several minutes optimizing instances
+// of RecursiveASTVisitor that will never get used.
+
+template
+class DummyRecursiveASTVisitor
+{
+public:
+// These need to be reimplemented, because plugins contain calls to them,
+// but they should actually never get called in the shared-visitor mode.
+// This could be autogenerated too, but it's probably simpler to just 
extend
+// manually as needed.
+bool TraverseDecl( Decl* ) { abort(); }
+bool TraverseLinkageSpecDecl( LinkageSpecDecl* ) { abort(); }
+bool TraverseStmt( Stmt* ) { abort(); }
+bool TraverseUnaryLNot( UnaryOperator* ) { abort(); }
+bool TraverseBinLAnd( BinaryOperator* ) { abort(); }
+bool TraverseCXXCatchStmt( CXXCatchStmt* ) { abort(); }
+bool TraverseCXXDestructorDecl( CXXDestructorDecl* ) { abort(); }
+bool TraverseFunctionDecl( FunctionDecl* ) { abort(); }
+bool TraverseSwitchStmt( SwitchStmt* ) { abort(); }
+bool TraverseImplicitCastExpr( ImplicitCastExpr* ) { abort(); }
+bool TraverseCStyleCastExpr( CStyleCastExpr* ) { abort(); }
+bool TraverseCXXStaticCastExpr( CXXStaticCastExpr* ) { abort(); }
+bool TraverseCXXFunctionalCastExpr( CXXFunctionalCastExpr* ) { abort(); }
+bool

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

2019-09-24 Thread Luboš Luňák (via logerrit)

 compilerplugins/clang/stringconcatauto.cxx  |  112 
 compilerplugins/clang/stringconcatliterals.cxx  |   12 +-
 compilerplugins/clang/test/stringconcatauto.cxx |   57 
 solenv/CompilerTest_compilerplugins_clang.mk|3 
 solenv/clang-format/blacklist   |4 
 5 files changed, 180 insertions(+), 8 deletions(-)

New commits:
commit a7d40f575463467698df76f041e558cb3bea7c85
Author: Luboš Luňák 
AuthorDate: Thu Sep 12 15:38:05 2019 +0200
Commit: Luboš Luňák 
CommitDate: Tue Sep 24 12:53:39 2019 +0200

compiler check for rtl::OUStringConcat instances

Something like auto str = "string" + OUString::number( 10 ); will
not be OUString but actually rtl::OUStringConcat (which gets implicitly
converted to OUString, but not with auto). Since those refer to temporaries
from the expression, they should not outlive the expression.

Change-Id: Ib4cde4b38befb3d49927d0cf01c52ebb2d36df89
Reviewed-on: https://gerrit.libreoffice.org/78830
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/compilerplugins/clang/stringconcatauto.cxx 
b/compilerplugins/clang/stringconcatauto.cxx
new file mode 100644
index ..1437b7537323
--- /dev/null
+++ b/compilerplugins/clang/stringconcatauto.cxx
@@ -0,0 +1,112 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * Based on LLVM/Clang.
+ *
+ * This file is distributed under the University of Illinois Open Source
+ * License. See LICENSE.TXT for details.
+ *
+ */
+
+/*
+This is a compile check.
+
+Warns about 'auto' declarations becoming rtl::OUStringConcat, such as
+auto str = "string" + OUString::number( 10 );
+The type of the expression is rtl::OUStringConcat and those refer to 
temporaries
+and so their lifecycle should not extend the lifecycle of those temporaries.
+*/
+
+#ifndef LO_CLANG_SHARED_PLUGINS
+
+#include "plugin.hxx"
+#include "check.hxx"
+
+#include 
+
+namespace loplugin
+{
+
+class StringConcatAuto
+: public FilteringPlugin< StringConcatAuto >
+{
+public:
+StringConcatAuto( const InstantiationData& data );
+virtual void run() override;
+bool shouldVisitTemplateInstantiations () const { return true; }
+bool VisitVarDecl( const VarDecl* decl );
+bool VisitFunctionDecl( const FunctionDecl* decl );
+private:
+enum class Check { Var, Return };
+bool checkDecl( const DeclaratorDecl* decl, const QualType type, const 
SourceRange& range, Check check );
+};
+
+StringConcatAuto::StringConcatAuto( const InstantiationData& data )
+: FilteringPlugin( data )
+{
+}
+
+void StringConcatAuto::run()
+{
+TraverseDecl( compiler.getASTContext().getTranslationUnitDecl());
+}
+
+bool StringConcatAuto::VisitVarDecl( const VarDecl* decl )
+{
+return checkDecl( decl, decl->getType(),
+decl->getTypeSourceInfo()
+? decl->getTypeSourceInfo()->getTypeLoc().getSourceRange()
+: decl->getSourceRange(),
+Check::Var );
+}
+
+bool StringConcatAuto::VisitFunctionDecl( const FunctionDecl* decl )
+{
+return checkDecl( decl, decl->getReturnType(), 
decl->getReturnTypeSourceRange(), Check::Return );
+}
+
+bool StringConcatAuto::checkDecl( const DeclaratorDecl* decl, QualType type, 
const SourceRange& range, Check check )
+{
+if( ignoreLocation( decl ))
+return true;
+if( isa< ParmVarDecl >( decl )) // parameters should be fine, temporaries 
should exist during the call
+return true;
+std::string fileName = getFileNameOfSpellingLoc(
+compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(decl)));
+loplugin::normalizeDotDotInFilePath(fileName);
+if (fileName == SRCDIR "/include/rtl/string.hxx"
+|| fileName == SRCDIR "/include/rtl/ustring.hxx"
+|| fileName == SRCDIR "/include/rtl/strbuf.hxx"
+|| fileName == SRCDIR "/include/rtl/ustrbuf.hxx"
+|| fileName == SRCDIR "/include/rtl/stringconcat.hxx")
+return true;
+auto const tc = loplugin::TypeCheck( 
type.getNonReferenceType().getCanonicalType());
+const char* typeString = nullptr;
+if( tc.Struct("OUStringConcat").Namespace("rtl").GlobalNamespace())
+typeString = "OUString";
+else if( tc.Struct("OStringConcat").Namespace("rtl").GlobalNamespace())
+typeString = "OString";
+else
+return true;
+report( DiagnosticsEngine::Warning,
+check == Check::Var
+? "creating a variable of type %0 will make it reference 
temporaries"
+: "returning a variable of type %0 will make it reference 
temporaries",
+decl->getLocation())
+<< type;
+report( DiagnosticsEngine::Note,
+"use %0 instead",
+range.getBegin())
+<< typeString
+<< FixItHint::CreateReplacement( range, typeString );
+

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format sw/inc sw/source

2018-01-04 Thread Michael Stahl

 compilerplugins/clang/badstatics.cxx |4 -
 solenv/clang-format/blacklist|1 
 sw/inc/fesh.hxx  |   11 ++
 sw/inc/tabcol.hxx|   13 +++
 sw/source/core/bastyp/init.cxx   |2 
 sw/source/core/docnode/ndtbl.cxx |   12 +--
 sw/source/core/docnode/ndtbl1.cxx|5 -
 sw/source/core/edit/edtab.cxx|4 -
 sw/source/core/frmedt/fetab.cxx  |  130 ++-
 sw/source/core/frmedt/fews.cxx   |1 
 sw/source/core/inc/fetab.hxx |   28 ---
 sw/source/core/layout/tabfrm.cxx |   16 
 sw/source/core/undo/untbl.cxx|   24 +++---
 13 files changed, 117 insertions(+), 134 deletions(-)

New commits:
commit 334601603aa04ea968e8a850f4e7f6cf52f7735b
Author: Michael Stahl 
Date:   Thu Jan 4 11:37:37 2018 +0100

sw: move some globals in fetab.cxx into SwFEShell

It looks like the main point of these being globals is so that they can
be cleared from various places when tables or table frames are destroyed.

Add a SwDoc parameter to ClearFEShellTabCols() and just iterate
over all shells.

Change-Id: I75ad6b695ee1bfa76b9a05c606b07a3574c70ac4

diff --git a/compilerplugins/clang/badstatics.cxx 
b/compilerplugins/clang/badstatics.cxx
index bf3f4be4b66f..697a50c8f9b0 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -168,10 +168,6 @@ public:
 || name == "s_pVout" // FrameFinit()
 || name == "s_pPaintQueue" // SwPaintQueue::Remove()
 || name == "gProp" // only owned (VclPtr) member cleared again
-|| name == "g_pColumnCacheLastTabFrame" // not owning
-|| name == "g_pColumnCacheLastCellFrame" // not owning
-|| name == "g_pRowCacheLastTabFrame" // not owning
-|| name == "g_pRowCacheLastCellFrame" // not owning
 || name == "g_OszCtrl" // SwCrsrOszControl::Exit()
 || name == "g_pSpellIter" // SwEditShell::SpellEnd()
 || name == "g_pConvIter" // SwEditShell::SpellEnd()
diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index cecc5025d84c..c5e56cefbf4f 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -15567,7 +15567,6 @@ sw/source/core/inc/dumpfilter.hxx
 sw/source/core/inc/dview.hxx
 sw/source/core/inc/environmentofanchoredobject.hxx
 sw/source/core/inc/fefly.hxx
-sw/source/core/inc/fetab.hxx
 sw/source/core/inc/fieldhint.hxx
 sw/source/core/inc/flowfrm.hxx
 sw/source/core/inc/flyfrm.hxx
diff --git a/sw/inc/fesh.hxx b/sw/inc/fesh.hxx
index 5149bb478a27..3e5b719d5a9f 100644
--- a/sw/inc/fesh.hxx
+++ b/sw/inc/fesh.hxx
@@ -198,10 +198,13 @@ enum class SwTab
 };
 
 class SdrDropMarkerOverlay;
+struct SwColCache;
 
 class SW_DLLPUBLIC SwFEShell : public SwEditShell
 {
 private:
+mutable std::unique_ptr m_pColumnCache;
+mutable std::unique_ptr m_pRowCache;
 std::unique_ptr m_pChainTo;
 std::unique_ptr m_pChainFrom;
 bool m_bCheckForOLEInCaption;
@@ -223,8 +226,8 @@ private:
 SAL_DLLPRIVATE static sal_uInt16 GetCurColNum_( const SwFrame *pFrame,
   SwGetCurColNumPara* pPara );
 
-SAL_DLLPRIVATE static void GetTabCols_( SwTabCols , const SwFrame 
*pBox );
-SAL_DLLPRIVATE static void GetTabRows_( SwTabCols , const SwFrame 
*pBox );
+SAL_DLLPRIVATE void GetTabCols_(SwTabCols , const SwFrame *pBox) 
const;
+SAL_DLLPRIVATE void GetTabRows_(SwTabCols , const SwFrame *pBox) 
const;
 
 SAL_DLLPRIVATE bool ImpEndCreate();
 
@@ -809,9 +812,11 @@ public:
 
 void ToggleHeaderFooterEdit( );
 static void SetLineEnds(SfxItemSet& rAttr, SdrObject const * pObj, 
sal_uInt16 nSlotId);
+
+SAL_DLLPRIVATE void ClearColumnRowCache(SwTabFrame const*);
 };
 
-void ClearFEShellTabCols();
+void ClearFEShellTabCols(SwDoc & rDoc, SwTabFrame const*const pFrame);
 
 #endif
 
diff --git a/sw/inc/tabcol.hxx b/sw/inc/tabcol.hxx
index 07644cfecf36..51aa940b99aa 100644
--- a/sw/inc/tabcol.hxx
+++ b/sw/inc/tabcol.hxx
@@ -22,6 +22,8 @@
 #include 
 
 #include 
+#include 
+
 #include "swdllapi.h"
 
 struct SwTabColsEntry
@@ -87,6 +89,17 @@ public:
 void SetLastRowAllowedToChange( bool bNew ) { bLastRowAllowedToChange = 
bNew; }
 };
 
+class SwTable;
+class SwTabFrame;
+class SwFrame;
+
+struct SwColCache {
+std::unique_ptr pLastCols;
+SwTable const* pLastTable  = nullptr;
+SwTabFrame const* pLastTabFrame = nullptr;
+SwFrame const* pLastCellFrame = nullptr;
+};
+
 #endif // INCLUDED_SW_INC_TABCOL_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/bastyp/init.cxx b/sw/source/core/bastyp/init.cxx
index a17a1d31b98c..399309fd6a88 100644
--- a/sw/source/core/bastyp/init.cxx
+++ b/sw/source/core/bastyp/init.cxx
@@ -735,8 +735,6 @@ void FinitCore()
 delete pHt;
 }
 
-::ClearFEShellTabCols();
-

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

2017-11-30 Thread Stephan Bergmann

 solenv/clang-format/blacklist |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bf59f89d8818f62b03acaf7820e1a9560a388252
Author: Stephan Bergmann 
Date:   Thu Nov 30 08:43:10 2017 +0100

Move loplugin:fpcomparison to store/

...after bc4e8de8eea1ccebda479c8e2db2f3c6dfff60d2 "Silence new
loplugin:fpcomparison for now":

> Nov 30 08:33:16  noelgrandin, thoughts on whether fpcomparison is 
actually worth it, seeing the lng blacklist there?
> Nov 30 08:34:11  sberg, that's wasn't my idea, can't 
remember who came up with it. vmiklos was that you?
> Nov 30 08:34:36  sberg, the original commit message was 
"Find code that compares floating point values with == or !=
> Nov 30 08:34:36  It should rather use 
rtl::math::approxEqual"
> Nov 30 08:34:45  so in theory the replacement should be 
fairly manual
> Nov 30 08:34:48  i don't think so :)
> Nov 30 08:35:15  might have been moggi, but he's not around 
so just disable it
> Nov 30 08:36:19  noelgrandin, yeah, in theory; in practice, I 
guess there's also cases where x==1.0 is what you want exactly (given x tends 
not to be a computed value after all, but some literal that's being passed 
around)
> Nov 30 08:36:33  noelgrandin, yeah, I'll disable it then

Change-Id: I35f5328efa0ec02d9be837c12efab2b03a3dae52
Reviewed-on: https://gerrit.libreoffice.org/45550
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/fpcomparison.cxx 
b/compilerplugins/clang/store/fpcomparison.cxx
similarity index 100%
rename from compilerplugins/clang/fpcomparison.cxx
rename to compilerplugins/clang/store/fpcomparison.cxx
diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 762ac3506c34..272dc4e5c295 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -1741,7 +1741,6 @@ compilerplugins/clang/faileddyncast.cxx
 compilerplugins/clang/finalclasses.cxx
 compilerplugins/clang/finalprotected.cxx
 compilerplugins/clang/flatten.cxx
-compilerplugins/clang/fpcomparison.cxx
 compilerplugins/clang/fragiledestructor.cxx
 compilerplugins/clang/functionaddress.hxx
 compilerplugins/clang/getimplementationname.cxx
@@ -1800,6 +1799,7 @@ compilerplugins/clang/store/defaultparams.cxx
 compilerplugins/clang/store/deletedspecial.cxx
 compilerplugins/clang/store/derivedclass.cxx
 compilerplugins/clang/store/findoncontainer.cxx
+compilerplugins/clang/store/fpcomparison.cxx
 compilerplugins/clang/store/lclstaticfix.cxx
 compilerplugins/clang/store/lclstaticfix.hxx
 compilerplugins/clang/store/manualrefcount.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format svx/source

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format vcl/Library_vcl.mk vcl/source

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format sw/inc sw/Library_sw.mk sw/source

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format vcl/Library_vclplug_gtk3.mk vcl/unx

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format starmath/inc starmath/Library_sm.mk starmath/mathml starmath/source

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format vcl/inc

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format solenv/CompilerTest_compilerplugins_clang.mk

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format sw/inc sw/source

[Libreoffice-commits] core.git: compilerplugins/clang solenv/clang-format

18 matches

Site Navigation

Mail list logo

Footer information