[Libreoffice-commits] core.git: forms/source fpicker/source framework/source
forms/source/component/ComboBox.cxx|2 -
forms/source/component/Filter.cxx |3 --
forms/source/component/FormComponent.cxx |4 ---
forms/source/component/FormattedField.cxx |3 --
forms/source/component/ImageControl.cxx|2 -
forms/source/component/ListBox.cxx |2 -
forms/source/component/cachedrowset.cxx|4 ---
forms/source/component/clickableimage.cxx |1
forms/source/richtext/richtextcontrol.cxx |1
forms/source/solar/component/navbarcontrol.cxx |2 -
forms/source/xforms/binding.cxx|5 ---
forms/source/xforms/boolexpression.cxx |5 ---
forms/source/xforms/computedexpression.cxx |6 +---
forms/source/xforms/convert.cxx|1
forms/source/xforms/model.cxx |1
forms/source/xforms/pathexpression.cxx |2 -
forms/source/xforms/submission.cxx | 13
--
fpicker/source/office/PlacesListBox.cxx|3 --
fpicker/source/office/contentenumeration.cxx |1
framework/source/accelerators/presethandler.cxx|3 --
framework/source/fwe/classes/actiontriggercontainer.cxx|3 --
framework/source/fwe/classes/actiontriggerpropertyset.cxx |1
framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx |1
framework/source/fwe/classes/rootactiontriggercontainer.cxx|3 --
framework/source/fwe/dispatch/interaction.cxx |1
framework/source/fwe/helper/propertysetcontainer.cxx |2 -
framework/source/fwe/helper/titlehelper.cxx|4 ---
framework/source/fwe/helper/undomanagerhelper.cxx |9
+-
framework/source/helper/titlebarupdate.cxx |1
framework/source/interaction/quietinteraction.cxx |1
framework/source/layoutmanager/layoutmanager.cxx |4 +--
framework/source/services/ContextChangeEventMultiplexer.cxx|3 --
framework/source/services/desktop.cxx | 11
framework/source/services/frame.cxx|7 -
framework/source/services/pathsettings.cxx |6
framework/source/uielement/buttontoolbarcontroller.cxx |1
framework/source/uielement/genericstatusbarcontroller.cxx |1
framework/source/uifactory/uicontrollerfactory.cxx |1
38 files changed, 17 insertions(+), 107 deletions(-)
New commits:
commit 1875b3d9f2a3873b592d5d207a46a6771649ca95
Author: Noel Grandin
AuthorDate: Tue Aug 31 15:12:18 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Sep 1 08:54:41 2021 +0200
clang-tidy:readability-redundant-member-init
Change-Id: I67edbea77b12940ac807ccbadfd74b250902809d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121378
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/ComboBox.cxx
b/forms/source/component/ComboBox.cxx
index 6ef66237a174..9b1bd9b9c7bd 100644
--- a/forms/source/component/ComboBox.cxx
+++ b/forms/source/component/ComboBox.cxx
@@ -112,7 +112,6 @@ OComboBoxModel::OComboBoxModel(const
Reference& _rxFactory)
// use the old control name for compatibility reasons
,OEntryListHelper( static_cast(*this) )
,OErrorBroadcaster( OComponentHelper::rBHelper )
-,m_aListRowSet()
,m_eListSourceType(ListSourceType_TABLE)
,m_bEmptyIsNull(true)
{
@@ -125,7 +124,6 @@ OComboBoxModel::OComboBoxModel( const OComboBoxModel*
_pOriginal, const Referenc
:OBoundControlModel( _pOriginal, _rxFactory )
,OEntryListHelper( *_pOriginal, static_cast(*this) )
,OErrorBroadcaster( OComponentHelper::rBHelper )
-,m_aListRowSet()
,m_aListSource( _pOriginal->m_aListSource )
,m_aDefaultText( _pOriginal->m_aDefaultText )
,m_eListSourceType( _pOriginal->m_eListSourceType )
diff --git a/forms/source/component/Filter.cxx
b/forms/source/component/Filter.cxx
index 141e011ad792..0bf85648ddba 100644
--- a/forms/source/component/Filter.cxx
+++ b/forms/source/component/Filter.cxx
@@ -78,8 +78,7 @@ namespace frm
using namespace ::connectivity;
OFilterControl::OFilterControl( const Reference< XComponentContext >&
_rxORB )
-:UnoControl()
-,m_aTextListeners( *this )
+:m_aTextListeners( *this )
,m_xContext( _rxORB )
,m_nControlClass( FormComponentType::TEXTFIELD )
[Libreoffice-commits] core.git: forms/source fpicker/source framework/source i18npool/source oox/source
forms/source/component/ComboBox.cxx |7 ---
forms/source/component/DatabaseForm.cxx |5 +++--
forms/source/component/Edit.cxx |2 +-
forms/source/component/FormComponent.cxx|4 ++--
forms/source/component/ListBox.cxx |2 +-
fpicker/source/office/OfficeControlAccess.cxx |2 +-
fpicker/source/office/fpsmartcontent.cxx|6 --
framework/source/jobs/jobdata.cxx |2 +-
framework/source/uielement/generictoolbarcontroller.cxx |2 +-
framework/source/uielement/newmenucontroller.cxx|2 +-
i18npool/source/localedata/localedata.cxx |2 +-
oox/source/core/filterbase.cxx |2 +-
oox/source/crypto/AgileEngine.cxx |3 ++-
oox/source/export/shapes.cxx|6 +++---
14 files changed, 26 insertions(+), 21 deletions(-)
New commits:
commit cf3fb54debffeab546085e648c73c576343be9f4
Author: Noel Grandin
AuthorDate: Thu Aug 15 11:40:13 2019 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 15 13:15:50 2019 +0200
loplugin:sequenceloop in forms..oox
Change-Id: Id742001211e916e7709918e7112902a0c35bac95
Reviewed-on: https://gerrit.libreoffice.org/77501
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/ComboBox.cxx
b/forms/source/component/ComboBox.cxx
index 62a0b54b1e14..912834f6d89d 100644
--- a/forms/source/component/ComboBox.cxx
+++ b/forms/source/component/ComboBox.cxx
@@ -415,7 +415,7 @@ void SAL_CALL OComboBoxModel::read(const
Reference&
m_aListSource.clear();
css::uno::Sequence aListSource;
_rxInStream >> aListSource;
-for (const OUString& rToken : aListSource)
+for (const OUString& rToken : std::as_const(aListSource))
m_aListSource += rToken;
}
@@ -642,7 +642,8 @@ void OComboBoxModel::loadData( bool _bForce )
Reference xFieldNames =
getTableFields(xConnection, m_aListSource);
if (xFieldNames.is())
{
-for (const OUString& rustrNames :
xFieldNames->getElementNames())
+const Sequence aFieldNames =
xFieldNames->getElementNames();
+for (const OUString& rustrNames : aFieldNames)
aStringList.push_back(rustrNames);
}
}
@@ -763,7 +764,7 @@ bool OComboBoxModel::commitControlValueToDbColumn( bool
_bPostReset )
if ( getPropertyValue( PROPERTY_STRINGITEMLIST ) >>= aStringItemList )
{
bool bFound = false;
-for (const OUString& rStringItem : aStringItemList)
+for (const OUString& rStringItem : std::as_const(aStringItemList))
{
if ( (bFound = rStringItem == sNewValue) )
break;
diff --git a/forms/source/component/DatabaseForm.cxx
b/forms/source/component/DatabaseForm.cxx
index a24e9eee91da..4f621a7d5e60 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -305,7 +305,7 @@ ODatabaseForm::ODatabaseForm( const ODatabaseForm&
_cloneSource )
Reference< XPropertySetInfo > xDestPSI( getPropertySetInfo(),
UNO_SET_THROW );
-Sequence< Property > aSourceProperties(
xSourcePSI->getProperties() );
+const Sequence< Property > aSourceProperties(
xSourcePSI->getProperties() );
for ( auto const & sourceProperty : aSourceProperties )
{
if ( xDestPSI->hasPropertyByName( sourceProperty.Name ) )
@@ -631,7 +631,8 @@ void ODatabaseForm::AppendComponent(HtmlSuccessfulObjList&
rList, const Referenc
// Find the right control
bool bFound = false;
-for( auto const& xControl : xControlContainer->getControls() )
+const Sequence> aControls =
xControlContainer->getControls();
+for( auto const& xControl : aControls )
{
Reference xModel(xControl->getModel(),
UNO_QUERY);
if ((bFound = xModel == xComponentSet))
diff --git a/forms/source/component/Edit.cxx b/forms/source/component/Edit.cxx
index 3573224206b1..4ab433ff4fcf 100644
--- a/forms/source/component/Edit.cxx
+++ b/forms/source/component/Edit.cxx
@@ -418,7 +418,7 @@ namespace
return;
}
-Sequence< Property > aSourceProps( xSourceInfo->getProperties() );
+const Sequence< Property > aSourceProps(
xSourceInfo->getProperties() );
for ( auto const & sourceprop : aSourceProps )
{
if ( !xDestInfo->hasPropertyByName( sourceprop.Name ) )
diff --git a/forms/source/component/FormComponent.cxx
b/forms/source/component/FormComponent.cxx
index
