[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann (via logerrit)]

 qadevOOo/tests/java/ifc/io/_XPersistObject.java |   10 ++
 qadevOOo/tests/java/ifc/util/_XCloneable.java   |6 ++
 2 files changed, 16 insertions(+)

New commits:
commit f9ac0d25d6587e2b38d763e49e65e0529f3d
Author: Stephan Bergmann 
AuthorDate: Tue Nov 14 17:21:11 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Nov 14 18:48:47 2023 +0100

Dispose some test components

Otherwise, JunitTest_forms_unoapi_2 left behind two instances of
frm::OGridControlModel.

Change-Id: Idaf7bae26b18e20821968ebf52e7864043963e03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159422
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/qadevOOo/tests/java/ifc/io/_XPersistObject.java 
b/qadevOOo/tests/java/ifc/io/_XPersistObject.java
index 083d0f71c692..717a611eb8e2 100644
--- a/qadevOOo/tests/java/ifc/io/_XPersistObject.java
+++ b/qadevOOo/tests/java/ifc/io/_XPersistObject.java
@@ -33,6 +33,7 @@ import com.sun.star.io.XObjectInputStream;
 import com.sun.star.io.XObjectOutputStream;
 import com.sun.star.io.XOutputStream;
 import com.sun.star.io.XPersistObject;
+import com.sun.star.lang.XComponent;
 import com.sun.star.uno.UnoRuntime;
 
 
@@ -154,6 +155,11 @@ public class _XPersistObject extends MultiMethodTest {
 }
 bResult &= locRes;
 }
+
+XComponent comp = UnoRuntime.queryInterface(XComponent.class, 
oCopy);
+if (comp != null) {
+comp.dispose();
+}
 } else {
 Object oCopy = tParam.getMSF().createInstance(sname);
 XPersistObject persCopy = 
UnoRuntime.queryInterface(XPersistObject.class, oCopy);
@@ -162,6 +168,10 @@ public class _XPersistObject extends MultiMethodTest {
 
 bResult = persCopy.getServiceName().equals(sname);
 
+XComponent comp = UnoRuntime.queryInterface(XComponent.class, 
oCopy);
+if (comp != null) {
+comp.dispose();
+}
 }
 
 } catch (com.sun.star.uno.Exception e) {
diff --git a/qadevOOo/tests/java/ifc/util/_XCloneable.java 
b/qadevOOo/tests/java/ifc/util/_XCloneable.java
index 62de17b010a0..1f446d801aee 100644
--- a/qadevOOo/tests/java/ifc/util/_XCloneable.java
+++ b/qadevOOo/tests/java/ifc/util/_XCloneable.java
@@ -22,6 +22,7 @@ import lib.MultiMethodTest;
 
 import java.util.Arrays;
 
+import com.sun.star.lang.XComponent;
 import com.sun.star.lang.XServiceInfo;
 import com.sun.star.lang.XTypeProvider;
 import com.sun.star.uno.UnoRuntime;
@@ -57,6 +58,11 @@ public class _XCloneable extends MultiMethodTest {
 result &= checkImplementationID(oObj, clone);
 
 tRes.tested("createClone()", result) ;
+
+XComponent comp = UnoRuntime.queryInterface(XComponent.class, clone);
+if (comp != null) {
+comp.dispose();
+}
 }
 
 protected byte[] getImplementationID(XInterface ifc) {

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/ucb/_XSimpleFileAccess.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c58f9dac4ed9123bed2869957f866e409b6db9fe
Author: Andrea Gelmini 
AuthorDate: Tue Jun 27 14:22:40 2023 +0200
Commit: Julien Nabet 
CommitDate: Wed Jun 28 07:05:44 2023 +0200

Fix typo

Change-Id: I0b4abdb362b86a3e1f622a04411e9f9ea0062295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153674
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/ucb/_XSimpleFileAccess.java 
b/qadevOOo/tests/java/ifc/ucb/_XSimpleFileAccess.java
index 2f633122e9bd..b1886f9650dc 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XSimpleFileAccess.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XSimpleFileAccess.java
@@ -404,7 +404,7 @@ public class _XSimpleFileAccess extends MultiMethodTest {
 * existence, second file I_do_not_exists.txt is checked
 * for existence. 
 * Has  OK  status if in the first case method returns
-* true and in the second - flase
+* true and in the second - false
 * and no exceptions were thrown. 
 */
 public void _exists() {

[Libreoffice-commits] core.git: qadevOOo/tests

[Julien Nabet (via logerrit)]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleExtendedComponent.java |   
23 --
 1 file changed, 23 deletions(-)

New commits:
commit 074c62b4e47c1e595f08d90e3811a8baab102dd5
Author: Julien Nabet 
AuthorDate: Tue May 16 18:40:51 2023 +0200
Commit: Julien Nabet 
CommitDate: Tue May 16 23:11:26 2023 +0200

Remove remnant commented code concerning recently dropped 
"XAccessibleStateSet"

Change-Id: Ib11e37dbc6bf9bfc7ba8cdf3b5cb28d5a11f31a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151847
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git 
a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleExtendedComponent.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleExtendedComponent.java
index dc6355e76554..2156c09a00dc 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleExtendedComponent.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleExtendedComponent.java
@@ -69,29 +69,6 @@ public class _XAccessibleExtendedComponent extends 
MultiMethodTest {
 tRes.tested("getFont()", true);
 }
 
-/**
- * Calls the method and compares returned value with value that was
- * returned by the method
- * XAccessibleStateSet & AccessibleStateType.ENABLED.
- * Has OK status if returned values are equal.
- * deprecated from version srx644g 29.10.02 on
- *
-public void _isEnabled() {
-boolean isEnabled = oObj.isEnabled();
-log.println("isEnabled(): " + isEnabled);
-
-boolean res = true;
-
-XAccessibleStateSet accStateSet = (XAccessibleStateSet)
-UnoRuntime.queryInterface(XAccessibleStateSet.class, oObj);
-
-if (accStateSet != null) {
-res = ((accStateSet &  AccessibleStateType.ENABLED) != 0) == 
isEnabled;
-}
-
-tRes.tested("isEnabled()", res);
-}
-
 /**
  * Calls the method and checks returned value.
  * Has OK status if returned value isn't null.

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann (via logerrit)]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 12d8dc31b003f6a4d466d3547ab342b85ac84bf0
Author: Stephan Bergmann 
AuthorDate: Wed Nov 30 15:04:22 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 30 16:44:07 2022 +0100

Add some more failure information

...which will hopefully give more of a clue than when
 recently 
failed
JunitTest_starmath_unoapi with just

> checking: 
[sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent] is 
iface: [com.sun.star.accessibility.XAccessibleComponent] testcode:
[...]
> LOG> Execute: getAccessibleAtPoint()
> LOG> Checking child with bounds (0,0),(2,18): 41,(Paragraph: 0 ):
> LOG>  StateType containsPoint SHOWING: true
> LOG> finding the point which lies on the component
> LOG> Child found at point (1,9) - OK
> LOG> The children found is not the same
> LOG> Expected:
> LOG> Description:  Paragraph: 0 sum hat a
> LOG> Found:
> LOG> Description:  Paragraph: 0 sum hat a
> LOG> ... FAILED
> LOG> No children found at point (-1,-1) - OK
> Method getAccessibleAtPoint() finished with state FAILED
> LOG> getAccessibleAtPoint(): COMPLETED.FAILED
[...]
> * State for 
sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent **
> 
[sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent::getAccessibleAtPoint()]
 is testcode: [getAccessibleAtPoint()] - COMPLETED.FAILED
>
> Whole interface: COMPLETED.FAILED

Change-Id: I5015e7a9d94bb838c6331ff9e74a6aec858d148a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143496
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
index 2bf4caf14bdf..8faccfe447bc 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
@@ -337,6 +337,9 @@ public class _XAccessibleComponent extends MultiMethodTest {
 if (MightBeCovered) {
 log.println("... Child is covered by another - 
OK");
 } else {
+log.println(
+"(xAccCh==null: " + (xAccCh == null) + "; 
expIndex: " + expIndex
++ "; gotIndex: " + gotIndex + ")");
 log.println("... FAILED");
 result = false;
 }

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/i18n/_XTransliteration.java |   14 ++
 1 file changed, 2 insertions(+), 12 deletions(-)

New commits:
commit 45e54afffa40c1f2bf3c98a3229a2137c050c0fc
Author: Caolán McNamara 
AuthorDate: Sat Aug 27 10:15:07 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sat Aug 27 12:46:16 2022 +0200

cid#1509234 DCN: Don't Catch NullPointer Exception

and

cid#1509229 DCN: Don't Catch NullPointer Exception

Change-Id: I113de964ff07fc771ac64acb8583341cd518d0e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138921
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/i18n/_XTransliteration.java 
b/qadevOOo/tests/java/ifc/i18n/_XTransliteration.java
index eff58351f20e..49ee580d3b32 100644
--- a/qadevOOo/tests/java/ifc/i18n/_XTransliteration.java
+++ b/qadevOOo/tests/java/ifc/i18n/_XTransliteration.java
@@ -321,12 +321,7 @@ public class _XTransliteration extends MultiMethodTest {
 
 boolean ret = true ;
 
-int res = -666 ;
-try {
-res = oObj.compareSubstring(str1, p1, len1, str2, p2, len2);
-} catch (NullPointerException e) {
-log.println("Exception while method calling occurs :" + e);
-}
+int res = oObj.compareSubstring(str1, p1, len1, str2, p2, len2);
 
 if (res != expRes) {
 log.print("Comparing FAILED; return: " + res + ", expected: " +
@@ -402,12 +397,7 @@ public class _XTransliteration extends MultiMethodTest {
 
 boolean ret = true ;
 
-int res = -666 ;
-try {
-res = oObj.compareString(str1, str2);
-} catch (NullPointerException e) {
-log.println("Exception while method calling occurs :" + e);
-}
+int res = oObj.compareString(str1, str2);
 
 if (res == expRes) {
 log.println("Comparing of '" + str1 + "' and '" + str2 + "' OK" );

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java |   56 +++--
 1 file changed, 34 insertions(+), 22 deletions(-)

New commits:
commit 28f9791b9649f700971624700aa0ecc25b2eae79
Author: Caolán McNamara 
AuthorDate: Mon Aug 22 10:07:48 2022 +0100
Commit: Caolán McNamara 
CommitDate: Mon Aug 22 15:07:15 2022 +0200

cid#1509396 Explicit null dereferenced

and

cid#1509395 Explicit null dereferenced

Change-Id: Ifd8dffe2ff2432ee2f0ef18bb2a480c2f042910b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138674
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java 
b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
index dc775c6e1d8c..c7009a88ab18 100644
--- a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
+++ b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
@@ -318,21 +318,27 @@ public class _XMultiSelectionSupplier extends 
MultiMethodTest {
 Object shouldElement = selections[i];
 i++;
 
-if (ObjCompare != null) {
-compRes = ObjCompare.compare(shouldElement, nextElement) == 0;
-} else {
-compRes = util.ValueComparer.equalValue(shouldElement, 
nextElement);
-}
+if (nextElement != null)
+{
+if (ObjCompare != null) {
+compRes = ObjCompare.compare(shouldElement, nextElement) 
== 0;
+} else {
+compRes = util.ValueComparer.equalValue(shouldElement, 
nextElement);
+}
 
-log.println("nextElement()-object and expected object 
'selections["+i+"]' are equal: "+compRes);
+log.println("nextElement()-object and expected object 
'selections["+i+"]' are equal: "+compRes);
 
-if (!compRes && (selections[i]) instanceof Object[]) {
-if (((Object[])selections[i])[0] instanceof Integer) {
-log.println("Getting: "+((Integer) 
((Object[])shouldElement)[0]).intValue());
-log.println("Expected: "+((Integer) 
((Object[])selections[i])[0]).intValue());
+if (!compRes && (selections[i]) instanceof Object[]) {
+if (((Object[])selections[i])[0] instanceof Integer) {
+log.println("Getting: "+((Integer) 
((Object[])shouldElement)[0]).intValue());
+log.println("Expected: "+((Integer) 
((Object[])selections[i])[0]).intValue());
+}
 }
+bOK &= compRes;
+
+} else {
+bOK = false;
 }
-bOK &= compRes;
 }
 
 tRes.tested("createSelectionEnumeration()", bOK);
@@ -389,21 +395,27 @@ public class _XMultiSelectionSupplier extends 
MultiMethodTest {
 Object shouldElement = selections[i];
 i--;
 
-if (ObjCompare != null) {
-compRes = ObjCompare.compare(shouldElement, nextElement) == 0;
-} else {
-compRes = util.ValueComparer.equalValue(shouldElement, 
nextElement);
-}
+if (nextElement != null) {
+if (ObjCompare != null) {
+compRes = ObjCompare.compare(shouldElement, nextElement) 
== 0;
+} else {
+compRes = util.ValueComparer.equalValue(shouldElement, 
nextElement);
+}
 
-log.println("nextElement()-object and expected object 
'selections["+i+"]' are equal: "+compRes);
+log.println("nextElement()-object and expected object 
'selections["+i+"]' are equal: "+compRes);
 
-if (!compRes && (selections[i]) instanceof Object[]){
-if (((Object[])selections[i])[0] instanceof Integer) {
-log.println("Getting: "+((Integer) 
((Object[])shouldElement)[0]).intValue());
-log.println("Expected: "+((Integer) 
((Object[])selections[i])[0]).intValue());
+if (!compRes && (selections[i]) instanceof Object[]){
+if (((Object[])selections[i])[0] instanceof Integer) {
+log.println("Getting: "+((Integer) 
((Object[])shouldElement)[0]).intValue());
+log.println("Expected: "+((Integer) 
((Object[])selections[i])[0]).intValue());
+}
 }
+bOK &= compRes;
+
+} else {
+bOK = false;
 }
-bOK &= compRes;
+
 }
 
 tRes.tested("createReverseSelectionEnumeration()", bOK);

[Libreoffice-commits] core.git: qadevOOo/tests

[Colomban Wendling (via logerrit)]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 920558267bbd1e91e1639dd854beb8d56fc7b5c3
Author: Colomban Wendling 
AuthorDate: Thu Mar 17 11:18:12 2022 +0100
Commit: Christian Lohmaier 
CommitDate: Tue May 10 16:13:03 2022 +0200

qa: Fix occlusion check coordinates in _XAccessibleComponent.java

This could erroneously skip a check because the child was erroneously
deemed obscured by another object.

Change-Id: I67d76ea272874671ae328266bdbdeb037c0dc625
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133842
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
index 574b4763bac5..52dad680183e 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
@@ -265,7 +265,7 @@ public class _XAccessibleComponent extends MultiMethodTest {
  chBnd.Y + curY));
 
 
-Point p = new Point(chBnd.X + curX,chBnd.X + curX);
+Point p = new Point(chBnd.X + curX,chBnd.Y + curY);
 
 if (isCovered(p)) {
 log.println(

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/text/_NumberingLevel.java |9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 8032e4692b518a0189705f748267f08e3e412976
Author: Caolán McNamara 
AuthorDate: Mon Oct 11 09:06:31 2021 +0100
Commit: Caolán McNamara 
CommitDate: Mon Oct 11 11:37:40 2021 +0200

cid#1492820 WMI: Inefficient Map Iterator

Change-Id: I2a220d5f8178dc96bb930600d51884c245128324
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123366
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/text/_NumberingLevel.java 
b/qadevOOo/tests/java/ifc/text/_NumberingLevel.java
index 7c8ca73591a5..e3eace4209aa 100644
--- a/qadevOOo/tests/java/ifc/text/_NumberingLevel.java
+++ b/qadevOOo/tests/java/ifc/text/_NumberingLevel.java
@@ -20,6 +20,7 @@ package ifc.text;
 
 import java.util.HashMap;
 import java.util.Iterator;
+import java.util.Map;
 
 import lib.StatusException;
 import lib.TestParameters;
@@ -136,11 +137,9 @@ public class _NumberingLevel {
 
 // get rest of properties and check if they are optional
 if (! NumberingLevel.isEmpty()){
-for (Iterator e = NumberingLevel.keySet().iterator() ; 
e.hasNext() ;) {
-String property = e.next();
-
+for (Map.Entry e : NumberingLevel.entrySet()) {
 // if some elements are not optional -> failed
-if ( ! NumberingLevel.get(property).booleanValue() ){
+if (!e.getValue().booleanValue()) {
 
 if ( status ) {
 log.println("FAILED: 
com.sun.star.text.NumberingLevel -> " +
@@ -148,7 +147,7 @@ public class _NumberingLevel {
 }
 
 status = false;
-log.println("-> '" + property + "'");
+log.println("-> '" + e.getKey() + "'");
 }
 }
 }

[Libreoffice-commits] core.git: qadevOOo/tests

[Julien Nabet (via logerrit)]

 qadevOOo/tests/java/ifc/text/_NumberingLevel.java |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a4eecf033edad84fa01700ca1aafb9bf06890deb
Author: Julien Nabet 
AuthorDate: Sat Oct 9 11:12:43 2021 +0200
Commit: Julien Nabet 
CommitDate: Sat Oct 9 12:17:21 2021 +0200

Typos in qadevOOo/_NumberingLevel.java

Change-Id: Id4ea4b27c527c34f9d4b6b4658486b189f9089c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123307
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/text/_NumberingLevel.java 
b/qadevOOo/tests/java/ifc/text/_NumberingLevel.java
index 0ef72a656985..7c8ca73591a5 100644
--- a/qadevOOo/tests/java/ifc/text/_NumberingLevel.java
+++ b/qadevOOo/tests/java/ifc/text/_NumberingLevel.java
@@ -32,7 +32,7 @@ import com.sun.star.beans.PropertyValue;
 * Testing com.sun.star.text.NumberingLevel
 * This service is currently known as property value of
 * com.sun.star.text.ParagraphProperties.NumberingRules
-* This test checks only for completnes of implemented properties.
+* This test checks only for completeness of implemented properties.
 * service properties :
 * 
 *   Adjust
@@ -107,7 +107,7 @@ public class _NumberingLevel {
 }
 
 /**
- * This methods checks the PropertyValue for completnes. If one or more 
properties
+ * This method checks the PropertyValue for completeness. If one or more 
properties
  * are missing the return value is FALSE, else TRUE
  * @return returns TRUE if PropertyValue[] is complete, else FALSE
  */

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e8059e707012c8352f7349c4ebf46b56e01c4b4f
Author: Andrea Gelmini 
AuthorDate: Fri Sep 25 13:21:31 2020 +0200
Commit: Julien Nabet 
CommitDate: Sat Sep 26 12:50:19 2020 +0200

Fix typo in code

It passed "make check" on Linux

Change-Id: I8945fc73085afb6e4cdfe5083f3732191341a1d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103459
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java 
b/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
index 4ca3a43aa8dd..1124d12f96d7 100644
--- a/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
+++ b/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
@@ -161,7 +161,7 @@ public class OQueryDesign extends TestCase {
 
 tEnv.addObjRelation("Frame", xFrame);
 
-tEnv.addObjRelation("XInitialization.xIni", 
getUnititializedObj(Param));
+tEnv.addObjRelation("XInitialization.xIni", 
getUninitializedObj(Param));
 
 log.println("ImplementationName: "+util.utils.getImplName(oObj));
 
@@ -169,7 +169,7 @@ public class OQueryDesign extends TestCase {
 
 } // finish method getTestEnvironment
 
-private XInitialization getUnititializedObj(TestParameters Param) throws 
Exception {
+private XInitialization getUninitializedObj(TestParameters Param) throws 
Exception {
 // creating an object which ist not initialized
 
 // get a model of a DataSource
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e913cbadb291c25a0199ad8db3f529309e41f5d6
Author: Andrea Gelmini 
AuthorDate: Fri Sep 25 13:22:12 2020 +0200
Commit: Julien Nabet 
CommitDate: Sat Sep 26 09:58:16 2020 +0200

Fix typo

It passed "make check"

Change-Id: Ifdea79506b69c316869fff4b78e496a090f77c5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103466
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java 
b/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
index 53f8f8c03038..f0ca8ae9f654 100644
--- a/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
+++ b/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
@@ -194,7 +194,7 @@ public class _XTreeNode extends MultiMethodTest {
 try {
 DisplayValue = AnyConverter.toString(dispVal);
 } catch (com.sun.star.lang.IllegalArgumentException ex) {
-log.println("ERROR: could not convert the returned object of 
'getDisplyValue()' " +
+log.println("ERROR: could not convert the returned object of 
'getDisplayValue()' " +
 "to String with AnyConverter: " + ex.toString());
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Draw/XMLSettingsExporter.java |4 ++--
 solenv/bin/native-code.py |1 -
 xmloff/source/draw/sdxmlexp.cxx   |8 
 xmloff/util/xo.component  |4 
 4 files changed, 2 insertions(+), 15 deletions(-)

New commits:
commit 681fb06143e6bbb679282bac071aa3113bc1bd8f
Author: Miklos Vajna 
AuthorDate: Thu Sep 17 21:02:20 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Sep 18 09:08:38 2020 +0200

xmloff: remove dead com.sun.star.comp.Draw.XMLSettingsExporter

And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in
JunitTest_xmloff_unoapi. Note that the test code is also dead at the
moment, because xmloff/qa/unoapi/xmloff.sce disables the
xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in
that code.

Change-Id: I2152f32fd798b7a7df7086b125e77fe804185157
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102973
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLSettingsExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLSettingsExporter.java
index d4368af7454a..261852b8eb51 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLSettingsExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLSettingsExporter.java
@@ -41,7 +41,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Draw.XMLSettingsExporter. 
+ * com.sun.star.comp.Draw.XMLOasisSettingsExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -118,7 +118,7 @@ public class XMLSettingsExporter extends TestCase {
 Any arg = new Any(new Type(XDocumentHandler.class),filter);
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Draw.XMLSettingsExporter",
+"com.sun.star.comp.Draw.XMLOasisSettingsExporter",
 new Object[] {arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class, oObj);
 xEx.setSourceDocument(xDrawDoc);
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 060c01033f7a..87b29db10c4e 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -471,7 +471,6 @@ core_constructor_list = [
 "com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation",
 "com_sun_star_comp_Impress_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLExporter_get_implementation",
-"com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisMetaExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisContentExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index 4b30b508b4cd..708dfb3fa085 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2659,14 +2659,6 @@ 
com_sun_star_comp_Draw_XMLExporter_get_implementation(uno::XComponentContext* pC
 | SvXMLExportFlags::EMBEDDED));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation(
-uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(
-new SdXMLExport(pCtx, "XMLDrawSettingsExportOOO", true, 
SvXMLExportFlags::SETTINGS));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 com_sun_star_comp_Draw_XMLOasisSettingsExporter_get_implementation(
 uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index c1fce200cfb1..db63a5cd0519 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -83,10 +83,6 @@
 
constructor="com_sun_star_comp_Draw_XMLOasisMetaExporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Draw/XMLContentExporter.java |6 +++---
 solenv/bin/native-code.py|1 -
 xmloff/source/draw/sdxmlexp.cxx  |   10 --
 xmloff/util/xo.component |4 
 4 files changed, 3 insertions(+), 18 deletions(-)

New commits:
commit 72b5478390457fa2dcf90e310bb3903e910ca8f2
Author: Miklos Vajna 
AuthorDate: Thu Sep 10 21:13:38 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Sep 11 09:03:31 2020 +0200

xmloff: remove dead com.sun.star.comp.Draw.XMLContentExporter

And test com.sun.star.comp.Draw.XMLOasisContentExporter instead in
JunitTest_xmloff_unoapi.

Change-Id: I22bf816d08bcd04b277e461a5055883b730811b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102401
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLContentExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLContentExporter.java
index 98992f53ce5b..e0e26b710920 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLContentExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLContentExporter.java
@@ -42,7 +42,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Draw.XMLContentExporter. 
+ * com.sun.star.comp.Draw.XMLOasisContentExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -88,7 +88,7 @@ public class XMLContentExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Draw.XMLContentExporter with
+* com.sun.star.comp.Draw.XMLOasisContentExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -125,7 +125,7 @@ public class XMLContentExporter extends TestCase {
 filter.addTag(new XMLTools.Tag("draw:page","draw:name","NewSlide2"));
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Draw.XMLContentExporter",
+"com.sun.star.comp.Draw.XMLOasisContentExporter",
 new Object[] {arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class,oObj);
 
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index e104ea067fa9..060c01033f7a 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -471,7 +471,6 @@ core_constructor_list = [
 "com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation",
 "com_sun_star_comp_Impress_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLExporter_get_implementation",
-"com_sun_star_comp_Draw_XMLContentExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisMetaExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index dbb761e9ddec..4b30b508b4cd 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2659,16 +2659,6 @@ 
com_sun_star_comp_Draw_XMLExporter_get_implementation(uno::XComponentContext* pC
 | SvXMLExportFlags::EMBEDDED));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Draw_XMLContentExporter_get_implementation(uno::XComponentContext*
 pCtx,
-
uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(new SdXMLExport(pCtx, "XMLDrawContentExportOOO", true,
- SvXMLExportFlags::AUTOSTYLES | 
SvXMLExportFlags::CONTENT
- | SvXMLExportFlags::SCRIPTS
- | SvXMLExportFlags::FONTDECLS));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation(
 uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index 4f08390ed5f8..c1fce200cfb1 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -63,10 +63,6 @@
   
constructor="com_sun_star_comp_Chart_XMLOasisStylesImporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Draw/XMLStylesExporter.java |6 +++---
 solenv/bin/native-code.py   |1 -
 xmloff/source/draw/sdxmlexp.cxx |   10 --
 xmloff/util/xo.component|4 
 4 files changed, 3 insertions(+), 18 deletions(-)

New commits:
commit 739ce73e9957fa1f553f3246e5ed67de0f3eb47f
Author: Miklos Vajna 
AuthorDate: Thu Sep 3 21:35:16 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Sep 4 09:11:39 2020 +0200

xmloff: remove dead com.sun.star.comp.Draw.XMLStylesExporter

And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in
JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment,
because xmloff/qa/unoapi/xmloff.sce disables the
xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in 
that
code.

Change-Id: I04eb38aad193dfbfde5df42f3e367aa47dfd12ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102019
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLStylesExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLStylesExporter.java
index b139fff75ac9..2fbf238ca67c 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLStylesExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLStylesExporter.java
@@ -42,7 +42,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Draw.XMLStylesExporter. 
+ * com.sun.star.comp.Draw.XMLOasisStylesExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -91,7 +91,7 @@ public class XMLStylesExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Draw.XMLStylesExporter with
+* com.sun.star.comp.Draw.XMLOasisStylesExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -121,7 +121,7 @@ public class XMLStylesExporter extends TestCase {
 final String STYLE_NAME = "New style" + counter++ ;
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Draw.XMLStylesExporter", new Object[] {arg});
+"com.sun.star.comp.Draw.XMLOasisStylesExporter", new Object[] 
{arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class,oObj);
 xEx.setSourceDocument(xDrawDoc);
 
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index b3a7828460d0..e104ea067fa9 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -471,7 +471,6 @@ core_constructor_list = [
 "com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation",
 "com_sun_star_comp_Impress_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLExporter_get_implementation",
-"com_sun_star_comp_Draw_XMLStylesExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLContentExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisSettingsExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index 0297c6f4e285..d5b8463b0d6e 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2661,16 +2661,6 @@ 
com_sun_star_comp_Draw_XMLExporter_get_implementation(uno::XComponentContext* pC
 | SvXMLExportFlags::EMBEDDED));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Draw_XMLStylesExporter_get_implementation(uno::XComponentContext*
 pCtx,
-
uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(new SdXMLExport(pCtx, "XMLDrawStylesExportOOO", true,
- SvXMLExportFlags::STYLES | 
SvXMLExportFlags::MASTERSTYLES
- | SvXMLExportFlags::AUTOSTYLES
- | SvXMLExportFlags::FONTDECLS));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 
com_sun_star_comp_Draw_XMLContentExporter_get_implementation(uno::XComponentContext*
 pCtx,
 
uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index 12ffcad76bc2..4f08390ed5f8 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -95,10 +95,6 @@
 
constructor="com_sun_star_comp_Draw_XMLOasisSettingsExporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/container/_XHierarchicalName.java |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit bf6d42803a8977ba881da3b44e3e871cb9b84a5f
Author: Andrea Gelmini 
AuthorDate: Fri Aug 28 12:15:06 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Aug 30 13:55:44 2020 +0200

Fix typo in code

It passed "make check" on Linux

Change-Id: Id837205b0e6a7efa091a5b9ead75d767ceddcefa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101598
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/container/_XHierarchicalName.java 
b/qadevOOo/tests/java/ifc/container/_XHierarchicalName.java
index 83897bc43fb4..f828c1f61830 100644
--- a/qadevOOo/tests/java/ifc/container/_XHierarchicalName.java
+++ b/qadevOOo/tests/java/ifc/container/_XHierarchicalName.java
@@ -28,7 +28,7 @@ public class _XHierarchicalName extends MultiMethodTest {
 public XHierarchicalName oObj;
 
 public void _composeHierarchicalName() {
-String expName = (String) tEnv.getObjRelation("HierachicalName");
+String expName = (String) tEnv.getObjRelation("HierarchicalName");
 String element = (String) tEnv.getObjRelation("ElementName");
 boolean res = false;
 
@@ -51,7 +51,7 @@ public class _XHierarchicalName extends MultiMethodTest {
 
 public void _getHierarchicalName() {
 String hName = oObj.getHierarchicalName();
-String expName = (String) tEnv.getObjRelation("HierachicalName");
+String expName = (String) tEnv.getObjRelation("HierarchicalName");
 boolean res = true;
 System.out.println("### "+hName);
 if (expName != null) {
@@ -63,9 +63,9 @@ System.out.println("### "+hName);
 }
 } else {
 throw new StatusException(Status.failed(
-  "ObjectRelation 
'HierachicalName' missing"));
+  "ObjectRelation 
'HierarchicalName' missing"));
 }
 
 tRes.tested("getHierarchicalName()", res);
 }
-}
\ No newline at end of file
+}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sw/qa

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/awt/_XScrollBar.java |2 +-
 qadevOOo/tests/java/ifc/awt/_XSpinValue.java |2 +-
 sw/qa/uitest/writer_tests2/formatBulletsNumbering.py |   14 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit e20c899ec83fdf88ab4d39ada1e830f05f798341
Author: Andrea Gelmini 
AuthorDate: Sat Aug 29 19:17:58 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Aug 30 13:52:29 2020 +0200

Fix typos

Change-Id: I041e65166eab9fc497742635fe59e11f63d55c6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101645
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/qadevOOo/tests/java/ifc/awt/_XScrollBar.java 
b/qadevOOo/tests/java/ifc/awt/_XScrollBar.java
index 5dfae24fad4b..a298ed082904 100644
--- a/qadevOOo/tests/java/ifc/awt/_XScrollBar.java
+++ b/qadevOOo/tests/java/ifc/awt/_XScrollBar.java
@@ -51,7 +51,7 @@ public class _XScrollBar extends MultiMethodTest {
 }
 
 public void _removeAdjustmentListener() {
-//this method is checked in addAjustmentListener
+//this method is checked in addAdjustmentListener
 //so that method is required here and if it works
 //this method is given OK too
 requiredMethod("addAdjustmentListener()");
diff --git a/qadevOOo/tests/java/ifc/awt/_XSpinValue.java 
b/qadevOOo/tests/java/ifc/awt/_XSpinValue.java
index bc19d4fdaba7..a8a65e2db305 100644
--- a/qadevOOo/tests/java/ifc/awt/_XSpinValue.java
+++ b/qadevOOo/tests/java/ifc/awt/_XSpinValue.java
@@ -50,7 +50,7 @@ public class _XSpinValue extends MultiMethodTest {
 }
 
 public void _removeAdjustmentListener() {
-//this method is checked in addAjustmentListener
+//this method is checked in addAdjustmentListener
 //so that method is required here and if it works
 //this method is given OK too
 requiredMethod("addAdjustmentListener()");
diff --git a/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py 
b/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py
index f10f543af047..a7e3421e267e 100644
--- a/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py
+++ b/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py
@@ -306,12 +306,12 @@ class formatBulletsNumbering(UITestCase):
 xBulletPage = xDialog.getChild("PickBulletPage")
 xselector = xBulletPage.getChild("valueset")
 self.assertEqual(get_state_as_dict(xselector)["ItemsCount"], "8")
-# Select elemet num 3
+# Select element num 3
 xselector.executeAction("CHOOSE", mkPropertyValues({"POS": "3"}))
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemPos"], "2")
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemId"], "3")
 self.assertEqual(get_state_as_dict(xselector)["ItemText"], "Solid 
diamond bullets")
-# Select elemet num 7
+# Select element num 7
 xselector.executeAction("CHOOSE", mkPropertyValues({"POS": "7"}))
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemPos"], "6")
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemId"], "7")
@@ -329,12 +329,12 @@ class formatBulletsNumbering(UITestCase):
 xNumberingPage = xDialog.getChild("PickNumberingPage")
 xselector = xNumberingPage.getChild("valueset")
 self.assertEqual(get_state_as_dict(xselector)["ItemsCount"], "8")
-# Select elemet num 5
+# Select element num 5
 xselector.executeAction("CHOOSE", mkPropertyValues({"POS": "5"}))
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemPos"], "4")
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemId"], "5")
 self.assertEqual(get_state_as_dict(xselector)["ItemText"], "Uppercase 
letter A) B) C)")
-# Select elemet num 8
+# Select element num 8
 xselector.executeAction("CHOOSE", mkPropertyValues({"POS": "8"}))
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemPos"], "7")
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemId"], "8")
@@ -346,7 +346,7 @@ class formatBulletsNumbering(UITestCase):
 xOutlinePage = xDialog.getChild("PickOutlinePage")
 xselector = xOutlinePage.getChild("valueset")
 self.assertEqual(get_state_as_dict(xselector)["ItemsCount"], "8")
-# Select elemet num 1
+# Select element num 1
 xselector.executeAction("CHOOSE", mkPropertyValues({"POS": "1"}))
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemPos"], "0")
 self.assertEqual(get_state_as_dict(xselector)["SelectedItemId"], "1")
@@ -358,11 +358,11 @@ class formatBulletsNumbering(UITestCase):
 xGraphicPage = xDialog.getChild("PickGraphicPage")
 xselector = xGraphicPage.getChild("valueset")
 self.assertEqual(get_state_as_dict(xselector)["ItemsCount"], "92")
-# Select elemet num 22
+# Select element num 22
 

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/awt/tree/_XMutableTreeNode.java |6 +++---
 qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java|2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 40a9f3df19fc8ab3a75535bddeb423e70076a40e
Author: Andrea Gelmini 
AuthorDate: Sat Aug 29 19:21:03 2020 +0200
Commit: Noel Grandin 
CommitDate: Sun Aug 30 08:18:17 2020 +0200

Fix typo in code

Change-Id: I84b15806a01b7a7ce6c10274ee066b4256a2e7c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101648
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/qadevOOo/tests/java/ifc/awt/tree/_XMutableTreeNode.java 
b/qadevOOo/tests/java/ifc/awt/tree/_XMutableTreeNode.java
index 712c23bc7604..76c7e6cac8de 100644
--- a/qadevOOo/tests/java/ifc/awt/tree/_XMutableTreeNode.java
+++ b/qadevOOo/tests/java/ifc/awt/tree/_XMutableTreeNode.java
@@ -251,7 +251,7 @@ public class _XMutableTreeNode extends MultiMethodTest {
 String sDataValue = (String) oObj.getDataValue();
 
 if ( ! sDataValue.equals("myDataValue")) {
-log.println("ERROR: getDataVlaue does not return the value which 
is inserted before:\n" +
+log.println("ERROR: getDataValue does not return the value which 
is inserted before:\n" +
 "\texpected: myDataValue\n" +
 "\tgot: " + sDataValue);
 bOK = false;
@@ -262,7 +262,7 @@ public class _XMutableTreeNode extends MultiMethodTest {
 
 Object oDataValue = oObj.getDataValue();
 if ( oDataValue != null) {
-log.println("ERROR: getDataVlaue does not return the value which 
is inserted before:\n" +
+log.println("ERROR: getDataValue does not return the value which 
is inserted before:\n" +
 "\texpected: null\n" +
 "\tgot: " + oDataValue.toString());
 bOK = false;
@@ -273,7 +273,7 @@ public class _XMutableTreeNode extends MultiMethodTest {
 
 oDataValue = oObj.getDataValue();
 if ( oDataValue != null) {
-log.println("ERROR: getDataVlaue does not return the value which 
is inserted before:\n" +
+log.println("ERROR: getDataValue does not return the value which 
is inserted before:\n" +
 "\texpected: " + oObj.toString() +"\n" +
 "\tgot: " + oDataValue.toString());
 bOK = false;
diff --git a/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java 
b/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
index eb2b8877e9a9..53f8f8c03038 100644
--- a/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
+++ b/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
@@ -58,7 +58,7 @@ public class _XTreeNode extends MultiMethodTest {
 msDisplayValue = (String) 
tEnv.getObjRelation("XTreeNode_DisplayValue");
 if (msDisplayValue == null){
 throw new StatusException(Status.failed(
-"Couldn't get relation 'XTreeNode_DisplayVlaue'"));
+"Couldn't get relation 'XTreeNode_DisplayValue'"));
 }
 
 msExpandedGraphicURL = (String) 
tEnv.getObjRelation("XTreeNode_ExpandedGraphicURL");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/mod/_forms/GenericModelTest.java |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit cfefaafc1c988e964e06d15f9cdeada6cfbea32d
Author: Andrea Gelmini 
AuthorDate: Sat Aug 22 18:43:02 2020 +0200
Commit: Julien Nabet 
CommitDate: Sun Aug 23 12:46:15 2020 +0200

Fix typo in code

Change-Id: I9a81d265a99aee896a71c14e3a3ee6ba863b4d5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101199
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/mod/_forms/GenericModelTest.java 
b/qadevOOo/tests/java/mod/_forms/GenericModelTest.java
index b24a951c30b3..c5ffe1ee55f8 100644
--- a/qadevOOo/tests/java/mod/_forms/GenericModelTest.java
+++ b/qadevOOo/tests/java/mod/_forms/GenericModelTest.java
@@ -133,7 +133,7 @@ public class GenericModelTest extends TestCase {
 private static final String m_TestDB = "TestDB";
 private DBTools m_dbTools = null;
 
-private boolean m_ConnectionColsed = false;
+private boolean m_ConnectionClosed = false;
 
 /**
  * describes the kind of the shape which should be created.
@@ -217,7 +217,7 @@ public class GenericModelTest extends TestCase {
 protected void initialize(TestParameters tParam, PrintWriter log) throws 
Exception {
 log.println("creating a textdocument");
 m_xTextDoc = WriterTools.createTextDoc(tParam.getMSF());
-m_ConnectionColsed = false;
+m_ConnectionClosed = false;
 debug = tParam.getBool(util.PropertyName.DEBUG_IS_ACTIVE);
 m_propertiesToSet.clear();
 }
@@ -237,7 +237,7 @@ public class GenericModelTest extends TestCase {
 // some interface tests call cleanup to reset the environment. If such
 // a test is the last one cleanup was called twice. The second call
 // causes then nasty exceptions...
-if (m_ConnectionColsed) return;
+if (m_ConnectionClosed) return;
 
 try {
 XIndexAccess forms = UnoRuntime.queryInterface( XIndexAccess.class,
@@ -329,7 +329,7 @@ public class GenericModelTest extends TestCase {
 log.println("ERROR: Error while object test cleaning up: " + 
e.toString());
 }
 
-m_ConnectionColsed = true;
+m_ConnectionClosed = true;
 }
 
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fcb9e950fb65923e362cf8b2d3382ce39bb94e06
Author: Andrea Gelmini 
AuthorDate: Thu Aug 20 13:18:06 2020 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 21 19:50:04 2020 +0200

Fix typo in code

Change-Id: I88f0562699c99730c29e269845d5b5e5e31953a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101121
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java
index d9ab32613249..b72874768ab2 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleValue.java
@@ -127,7 +127,7 @@ public class _XAccessibleValue extends MultiMethodTest {
 String noMax = "com.sun.star.comp.toolkit.AccessibleScrollBar";
 String implName = util.utils.getImplName(oObj);
 
-if (tEnv.getObjRelation("ValueNotPersitent")!=null) {
+if (tEnv.getObjRelation("ValueNotPersistent")!=null) {
 log.println("Excluded since it works like AccessibleAction");
 tRes.tested("setCurrentValue()",Status.skipped(true));
 return;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/awt/_UnoControlFileControlModel.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1622014ebf7ce46b4cea02e44c7d5de06d8e3662
Author: Andrea Gelmini 
AuthorDate: Thu Aug 20 13:18:33 2020 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 21 18:17:47 2020 +0200

Fix typo in code

Change-Id: I6e3b4ca90b88e192e8fde29c578d29fdd42093f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101122
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/awt/_UnoControlFileControlModel.java 
b/qadevOOo/tests/java/ifc/awt/_UnoControlFileControlModel.java
index 4e4e3ae7f1f8..3226f392a835 100644
--- a/qadevOOo/tests/java/ifc/awt/_UnoControlFileControlModel.java
+++ b/qadevOOo/tests/java/ifc/awt/_UnoControlFileControlModel.java
@@ -29,7 +29,7 @@ import util.utils;
 *   Border
 *   HelpText
 *   HelpURL
-*   FontEmphsisMark
+*   FontEmphasisMark
 *   FontRelief
 *   Enabled
 *   FontDescriptor
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2b683d68a09d9f85f9fc06d9582964c72d73a5ab
Author: Andrea Gelmini 
AuthorDate: Thu Aug 20 13:17:44 2020 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 21 12:32:28 2020 +0200

Fix typo in code

Change-Id: I9762e33948af64067f25add657f4a64cd19bd467
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101120
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java 
b/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java
index fee7668c7917..c3417118e2b2 100644
--- a/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java
+++ b/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java
@@ -164,7 +164,7 @@ public class _XDocumentInsertable extends MultiMethodTest {
 if (result) {
 try {
 PropertyValue [] szEmptyArgs = new PropertyValue [0];
-String docURL = "file:///c:/ThisIsAnInvaldURL";
+String docURL = "file:///c:/ThisIsAnInvalidURL";
 log.println("Inserting document from URL '" + docURL + "'");
 oObj.insertDocumentFromURL(docURL, szEmptyArgs);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaExporter.java |6 +++---
 solenv/bin/native-code.py |1 -
 xmloff/source/draw/sdxmlexp.cxx   |8 
 xmloff/util/xo.component  |4 
 4 files changed, 3 insertions(+), 16 deletions(-)

New commits:
commit b8285ae5133cd74df6930ada54bf12bdd22fce36
Author: Miklos Vajna 
AuthorDate: Thu Aug 13 21:53:22 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Aug 14 08:40:49 2020 +0200

xmloff: remove dead com.sun.star.comp.Draw.XMLMetaExporter

And test com.sun.star.comp.Draw.XMLOasisMetaExporter instead in
JunitTest_xmloff_unoapi.

Change-Id: I1cd485378097b094e6773a7c37798b9aadf3070f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100687
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaExporter.java
index 8a731cfcdfa7..0e2835d41570 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaExporter.java
@@ -40,7 +40,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Draw.XMLMetaExporter. 
+ * com.sun.star.comp.Draw.XMLOasisMetaExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -88,7 +88,7 @@ public class XMLMetaExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Draw.XMLMetaExporter with
+* com.sun.star.comp.Draw.XMLOasisMetaExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -118,7 +118,7 @@ public class XMLMetaExporter extends TestCase {
 Any arg = new Any(new Type(XDocumentHandler.class),filter);
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Draw.XMLMetaExporter", new Object[] {arg});
+"com.sun.star.comp.Draw.XMLOasisMetaExporter", new Object[] {arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class, oObj);
 xEx.setSourceDocument(xDrawDoc);
 
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index d283c4043110..d0ebd3147d42 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -473,7 +473,6 @@ core_constructor_list = [
 "com_sun_star_comp_Draw_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLStylesExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLContentExporter_get_implementation",
-"com_sun_star_comp_Draw_XMLMetaExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisSettingsExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLOasisMetaExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index 8d9ef7e21eed..1061aee617cc 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2681,14 +2681,6 @@ 
com_sun_star_comp_Draw_XMLContentExporter_get_implementation(uno::XComponentCont
  | SvXMLExportFlags::FONTDECLS));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Draw_XMLMetaExporter_get_implementation(uno::XComponentContext*
 pCtx,
-
uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(
-new SdXMLExport(pCtx, "XMLDrawMetaExportOOO", true, 
SvXMLExportFlags::META));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 com_sun_star_comp_Draw_XMLSettingsExporter_get_implementation(
 uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index 4ff1cff861c7..12ffcad76bc2 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -83,10 +83,6 @@
 constructor="com_sun_star_comp_Draw_XMLOasisImporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Impress/XMLSettingsExporter.java |6 +++---
 solenv/bin/native-code.py|1 -
 xmloff/source/draw/sdxmlexp.cxx  |8 

 xmloff/util/xo.component |4 
 4 files changed, 3 insertions(+), 16 deletions(-)

New commits:
commit e87fb75453b26f8f452f4db1130f672a681eaf71
Author: Miklos Vajna 
AuthorDate: Thu Aug 6 21:05:10 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Aug 7 09:19:58 2020 +0200

xmloff: remove dead com.sun.star.comp.Impress.XMLSettingsExporter

And test com.sun.star.comp.Impress.XMLOasisSettingsExporter instead in
JunitTest_xmloff_unoapi. Note that the test code is also dead at the
moment, because xmloff/qa/unoapi/xmloff.sce disables the
xmloff.Impress.XMLSettingsExporter line, but let's not regress even more
in that code.

Change-Id: Ibca21fddc051253adef40df6f1da584c23b4423d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100269
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLSettingsExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLSettingsExporter.java
index 60177f670b53..b733d67fd983 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLSettingsExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLSettingsExporter.java
@@ -41,7 +41,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Impress.XMLSettingsExporter. 
+ * com.sun.star.comp.Impress.XMLOasisSettingsExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -87,7 +87,7 @@ public class XMLSettingsExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Impress.XMLSettingsExporter with
+* com.sun.star.comp.Impress.XMLOasisSettingsExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -115,7 +115,7 @@ public class XMLSettingsExporter extends TestCase {
 final boolean NewDataValue;
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Impress.XMLSettingsExporter",
+"com.sun.star.comp.Impress.XMLOasisSettingsExporter",
 new Object[] {arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class,oObj);
 xEx.setSourceDocument(xImpressDoc);
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index c7e664c8c270..198768b9c28a 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -419,7 +419,6 @@ core_constructor_list = [
 "com_sun_star_comp_Impress_XMLOasisStylesImporter_get_implementation",
 "com_sun_star_comp_Impress_XMLOasisSettingsExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation",
-"com_sun_star_comp_Impress_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLStylesExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index cc5a588cdc76..8d9ef7e21eed 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2637,14 +2637,6 @@ 
com_sun_star_comp_Impress_XMLOasisSettingsExporter_get_implementation(
  SvXMLExportFlags::OASIS | 
SvXMLExportFlags::SETTINGS));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Impress_XMLSettingsExporter_get_implementation(
-uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(
-new SdXMLExport(pCtx, "XMLImpressSettingsExportOOO", false, 
SvXMLExportFlags::SETTINGS));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 
com_sun_star_comp_Impress_XMLExporter_get_implementation(uno::XComponentContext*
 pCtx,
  
uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index 9e84d6f3b382..4ff1cff861c7 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -151,10 +151,6 @@
 
constructor="com_sun_star_comp_Impress_XMLOasisMetaImporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Impress/XMLContentExporter.java |6 +++---
 solenv/bin/native-code.py   |1 -
 xmloff/source/draw/sdxmlexp.cxx |   10 
--
 xmloff/util/xo.component|4 
 4 files changed, 3 insertions(+), 18 deletions(-)

New commits:
commit 8e62e20f1f4da93f84b135d0b221ecd39667b0e4
Author: Miklos Vajna 
AuthorDate: Thu Jul 23 20:03:49 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jul 24 09:03:22 2020 +0200

xmloff: remove dead com.sun.star.comp.Impress.XMLContentExporter

And test com.sun.star.comp.Impress.XMLOasisContentExporter instead in
JunitTest_xmloff_unoapi. Note that the test code is also dead at the
moment, because xmloff/qa/unoapi/xmloff.sce disables the
xmloff.Impress.XMLContentExporter line, but let's not regress even more
in that code.

Change-Id: I5bbffaf512ea803c9265050cbe587f2e9743f09b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99336
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLContentExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLContentExporter.java
index eae3f905ec16..b5a46cfffa03 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLContentExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLContentExporter.java
@@ -41,7 +41,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Impress.XMLContentExporter. 
+ * com.sun.star.comp.Impress.XMLOasisContentExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -89,7 +89,7 @@ public class XMLContentExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Impress.XMLContentExporter with
+* com.sun.star.comp.Impress.XMLOasisContentExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -119,7 +119,7 @@ public class XMLContentExporter extends TestCase {
 Any arg = new Any(new Type(XDocumentHandler.class),filter);
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Impress.XMLContentExporter",
+"com.sun.star.comp.Impress.XMLOasisContentExporter",
 new Object[] {arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class,oObj);
 xEx.setSourceDocument(xImpressDoc);
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index c7c3f952446f..748f84dc4256 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -403,7 +403,6 @@ core_constructor_list = [
 "com_sun_star_comp_Impress_XMLOasisStylesImporter_get_implementation",
 "com_sun_star_comp_Impress_XMLOasisSettingsExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation",
-"com_sun_star_comp_Impress_XMLContentExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLExporter_get_implementation",
 "com_sun_star_comp_Draw_XMLExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index f00d1702b6dd..c56272c2570d 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2633,16 +2633,6 @@ 
com_sun_star_comp_Impress_XMLOasisSettingsExporter_get_implementation(
  SvXMLExportFlags::OASIS | 
SvXMLExportFlags::SETTINGS));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Impress_XMLContentExporter_get_implementation(
-uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(new SdXMLExport(pCtx, "XMLImpressContentExportOOO", 
false,
- SvXMLExportFlags::AUTOSTYLES | 
SvXMLExportFlags::CONTENT
- | SvXMLExportFlags::SCRIPTS
- | SvXMLExportFlags::FONTDECLS));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 com_sun_star_comp_Impress_XMLSettingsExporter_get_implementation(
 uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index 84c9a4e2fe26..9e84d6f3b382 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -115,10 +115,6 @@
 
constructor="com_sun_star_comp_Impress_XMLClipboardExporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: qadevOOo/tests solenv/bin xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Impress/XMLStylesExporter.java |6 +++---
 solenv/bin/native-code.py  |1 -
 xmloff/source/draw/sdxmlexp.cxx|   10 
--
 xmloff/util/xo.component   |4 
 4 files changed, 3 insertions(+), 18 deletions(-)

New commits:
commit 39bdb12a57b7606029bae33e3fe26634ca8a891b
Author: Miklos Vajna 
AuthorDate: Thu Jul 16 21:45:36 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jul 17 09:08:11 2020 +0200

xmloff: remove dead com.sun.star.comp.Impress.XMLStylesExporter

And test com.sun.star.comp.Impress.XMLOasisStylesExporter instead in
JunitTest_xmloff_unoapi. Note that the test code is also dead at the
moment, because xmloff/qa/unoapi/xmloff.sce disables the
xmloff.Impress.XMLStylesExporter line, but let's not regress even more
in that code.

Change-Id: I7912ce45421b9a2d5209696c6ec4074b15111f86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98930
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLStylesExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLStylesExporter.java
index 588909433618..2a44f8a8ed6b 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLStylesExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLStylesExporter.java
@@ -42,7 +42,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Impress.XMLStylesExporter. 
+ * com.sun.star.comp.Impress.XMLOasisStylesExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -90,7 +90,7 @@ public class XMLStylesExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Impress.XMLStylesExporter with
+* com.sun.star.comp.Impress.XMLOasisStylesExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -125,7 +125,7 @@ public class XMLStylesExporter extends TestCase {
 filter.addTag(new XMLTools.Tag("style:style","style:name", newName));
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Impress.XMLStylesExporter",
+"com.sun.star.comp.Impress.XMLOasisStylesExporter",
 new Object[] {arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class,oObj);
 xEx.setSourceDocument(xImpressDoc);
diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py
index 164b8039735d..2f1255248d44 100755
--- a/solenv/bin/native-code.py
+++ b/solenv/bin/native-code.py
@@ -399,7 +399,6 @@ core_constructor_list = [
 "com_sun_star_comp_Impress_XMLOasisStylesImporter_get_implementation",
 "com_sun_star_comp_Impress_XMLOasisSettingsExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation",
-"com_sun_star_comp_Impress_XMLStylesExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLContentExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLSettingsExporter_get_implementation",
 "com_sun_star_comp_Impress_XMLExporter_get_implementation",
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index 57c42fa23c33..f00d1702b6dd 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2633,16 +2633,6 @@ 
com_sun_star_comp_Impress_XMLOasisSettingsExporter_get_implementation(
  SvXMLExportFlags::OASIS | 
SvXMLExportFlags::SETTINGS));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Impress_XMLStylesExporter_get_implementation(
-uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(new SdXMLExport(pCtx, "XMLImpressStylesExportOOO", 
false,
- SvXMLExportFlags::STYLES | 
SvXMLExportFlags::MASTERSTYLES
- | SvXMLExportFlags::AUTOSTYLES
- | SvXMLExportFlags::FONTDECLS));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 com_sun_star_comp_Impress_XMLContentExporter_get_implementation(
 uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index 809ecf340ae5..84c9a4e2fe26 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -171,10 +171,6 @@
 
constructor="com_sun_star_comp_Impress_XMLOasisSettingsImporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: qadevOOo/tests xmloff/source xmloff/util

[Miklos Vajna (via logerrit)]

 qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaExporter.java |6 +++---
 xmloff/source/draw/sdxmlexp.cxx  |8 
 xmloff/util/xo.component |4 
 3 files changed, 3 insertions(+), 15 deletions(-)

New commits:
commit 46308ce281ae93e22c0b051b68dad1ee21c6646e
Author: Miklos Vajna 
AuthorDate: Thu Jun 25 21:10:44 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Jun 26 08:50:17 2020 +0200

xmloff: remove dead com.sun.star.comp.Impress.XMLMetaExporter

And test com.sun.star.comp.Impress.XMLOasisMetaExporter instead in
JunitTest_xmloff_unoapi.

Change-Id: Iec2da56b569c283686de1bd4aad5fb7ebebfbc2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97183
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaExporter.java 
b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaExporter.java
index a63767f6a99a..360a3ac3a09c 100644
--- a/qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaExporter.java
+++ b/qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaExporter.java
@@ -40,7 +40,7 @@ import com.sun.star.xml.sax.XDocumentHandler;
 
 /**
  * Test for object which is represented by service
- * com.sun.star.comp.Impress.XMLMetaExporter. 
+ * com.sun.star.comp.Impress.XMLOasisMetaExporter. 
  * Object implements the following interfaces :
  * 
  *  com::sun::star::lang::XInitialization
@@ -88,7 +88,7 @@ public class XMLMetaExporter extends TestCase {
 /**
 * Creating a TestEnvironment for the interfaces to be tested.
 * Creates an instance of the service
-* com.sun.star.comp.Impress.XMLMetaExporter with
+* com.sun.star.comp.Impress.XMLOasisMetaExporter with
 * argument which is an implementation of XDocumentHandler
 * and which can check if required tags and character data is
 * exported. 
@@ -118,7 +118,7 @@ public class XMLMetaExporter extends TestCase {
 final String NAME = "XMLMetaExporter";
 
 oObj = (XInterface) xMSF.createInstanceWithArguments(
-"com.sun.star.comp.Impress.XMLMetaExporter",
+"com.sun.star.comp.Impress.XMLOasisMetaExporter",
 new Object[]{arg});
 XExporter xEx = UnoRuntime.queryInterface(XExporter.class,oObj);
 xEx.setSourceDocument(xImpressDoc);
diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index 417aac6d75c2..cbeb6a6b4096 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2653,14 +2653,6 @@ 
com_sun_star_comp_Impress_XMLContentExporter_get_implementation(
  | SvXMLExportFlags::FONTDECLS));
 }
 
-extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
-com_sun_star_comp_Impress_XMLMetaExporter_get_implementation(
-uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
-{
-return cppu::acquire(
-new SdXMLExport(pCtx, "XMLImpressMetaExportOOO", false, 
SvXMLExportFlags::META));
-}
-
 extern "C" SAL_DLLPUBLIC_EXPORT uno::XInterface*
 com_sun_star_comp_Impress_XMLSettingsExporter_get_implementation(
 uno::XComponentContext* pCtx, uno::Sequence const& /*rSeq*/)
diff --git a/xmloff/util/xo.component b/xmloff/util/xo.component
index f0130e8cd84d..7e0564eacef6 100644
--- a/xmloff/util/xo.component
+++ b/xmloff/util/xo.component
@@ -143,10 +143,6 @@
 
constructor="com_sun_star_comp_Impress_XMLOasisImporter_get_implementation">
 
   
-  
-
-  
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/form/binding/_XBindableValue.java |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 16009226cde955e0e280fc21ed719b4faf284b69
Author: Andrea Gelmini 
AuthorDate: Sun Feb 9 16:06:27 2020 +0100
Commit: Julien Nabet 
CommitDate: Mon Feb 17 09:50:54 2020 +0100

Fix typo

Change-Id: I74b65394367a11a07d104bfbab6afbfe49919b3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88336
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/form/binding/_XBindableValue.java 
b/qadevOOo/tests/java/ifc/form/binding/_XBindableValue.java
index da35e5cc7c97..e0131bb45461 100644
--- a/qadevOOo/tests/java/ifc/form/binding/_XBindableValue.java
+++ b/qadevOOo/tests/java/ifc/form/binding/_XBindableValue.java
@@ -52,7 +52,7 @@ public class _XBindableValue extends MultiMethodTest {
 boolean res = rightOne.equals("MyValueBinding");
 
 if (!res) {
-log.println("Excepted: MyValueBinding");
+log.println("Expected: MyValueBinding");
 log.println("getting: " + rightOne);
 }
 
@@ -103,4 +103,4 @@ public class _XBindableValue extends MultiMethodTest {
 return true;
 }
 }
-}
\ No newline at end of file
+}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/io/_XConnectable.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 08036972a770f9f48dc4f9695b90edee0eba6c85
Author: Andrea Gelmini 
AuthorDate: Sun Feb 9 16:06:28 2020 +0100
Commit: Julien Nabet 
CommitDate: Sun Feb 9 19:41:10 2020 +0100

Fix typo

Change-Id: I0e9155804a79e0eb97b86f4cfe930e4a0185dd61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88337
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/io/_XConnectable.java 
b/qadevOOo/tests/java/ifc/io/_XConnectable.java
index 35742e8d4dee..8efb86defe7a 100644
--- a/qadevOOo/tests/java/ifc/io/_XConnectable.java
+++ b/qadevOOo/tests/java/ifc/io/_XConnectable.java
@@ -37,7 +37,7 @@ import com.sun.star.uno.XInterface;
 * 
 *   'Connectable' (supports the XConnectable
 *   interface):
-*   another 0bject to connect 
+*   another object to connect 
 * 
 * After test completion object environment has to be recreated.
 * @see com.sun.star.io.XConnectable
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/drawing/_XShapeBinder.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 32bd978bb02127820e133a02180db6ec48a36f10
Author: Andrea Gelmini 
AuthorDate: Sun Feb 9 11:10:10 2020 +0100
Commit: Julien Nabet 
CommitDate: Sun Feb 9 12:24:30 2020 +0100

Fix typo

Change-Id: I0a56f044b24158e2b44bb3550a97ea6bc21d3feb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88317
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/drawing/_XShapeBinder.java 
b/qadevOOo/tests/java/ifc/drawing/_XShapeBinder.java
index c75b96cb05fa..5ebe37e1ca6f 100644
--- a/qadevOOo/tests/java/ifc/drawing/_XShapeBinder.java
+++ b/qadevOOo/tests/java/ifc/drawing/_XShapeBinder.java
@@ -52,7 +52,7 @@ public class _XShapeBinder extends MultiMethodTest {
 * Retrieves draw page collection from relation and binds them. 
 *
 * Has  OK  status if the shape group returned is not null
-* number of shapes in collection is 1 (shapes are binded into a single
+* number of shapes in collection is 1 (shapes are bound into a single
 * shape). 
 */
 public void _bind () {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/lang/_XMultiComponentFactory.java |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit bf2f1adfd2e4725518147657c6b57eb5697a29d5
Author: Caolán McNamara 
AuthorDate: Thu Feb 6 09:53:46 2020 +
Commit: Caolán McNamara 
CommitDate: Thu Feb 6 18:16:47 2020 +0100

cid#1458159 Dereference after null check

Change-Id: I5ec0f9571f3b551e716899cc86a57c2c91369641
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88083
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/lang/_XMultiComponentFactory.java 
b/qadevOOo/tests/java/ifc/lang/_XMultiComponentFactory.java
index 0b8fdb561fad..424e3d576470 100644
--- a/qadevOOo/tests/java/ifc/lang/_XMultiComponentFactory.java
+++ b/qadevOOo/tests/java/ifc/lang/_XMultiComponentFactory.java
@@ -110,8 +110,10 @@ public class _XMultiComponentFactory extends 
MultiMethodTest {
 }
 
 log.println("Available service names:");
-for(int i = 0; i < availableServiceNames.length; i++) {
-log.println("   " + availableServiceNames[i]);
+if (availableServiceNames != null) {
+for(int i = 0; i < availableServiceNames.length; i++) {
+log.println("   " + availableServiceNames[i]);
+}
 }
 
 tRes.tested("getAvailableServiceNames()", result);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/bridge/_XBridgeFactory.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3d22c0601455a78a5fdea6cf70b52156689bda4a
Author: Caolán McNamara 
AuthorDate: Thu Feb 6 09:48:10 2020 +
Commit: Caolán McNamara 
CommitDate: Thu Feb 6 14:47:43 2020 +0100

cid#1458158 Dereference before null check

Change-Id: I6fbcbce28cbd472a48556ba107e604a09c8cbe30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88081
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/bridge/_XBridgeFactory.java 
b/qadevOOo/tests/java/ifc/bridge/_XBridgeFactory.java
index 9272f9660437..fe0f28d695b6 100644
--- a/qadevOOo/tests/java/ifc/bridge/_XBridgeFactory.java
+++ b/qadevOOo/tests/java/ifc/bridge/_XBridgeFactory.java
@@ -128,7 +128,7 @@ public class _XBridgeFactory extends MultiMethodTest {
 
 if (bridges.length > 0) bridgeName = bridges[0].getName() ;
 
-tRes.tested("getExistingBridges()", bridges != null) ;
+tRes.tested("getExistingBridges()", true) ;
 }
 
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/lang/_XMultiServiceFactory.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5683dfcf49f6018739e52ea0e25ca062c4d31697
Author: Caolán McNamara 
AuthorDate: Thu Feb 6 09:50:13 2020 +
Commit: Caolán McNamara 
CommitDate: Thu Feb 6 14:23:59 2020 +0100

cid#1458157 Dereference before null check

Change-Id: I36317f40a789cfb5915bd92cca75c01e4e53a782
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88082
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/lang/_XMultiServiceFactory.java 
b/qadevOOo/tests/java/ifc/lang/_XMultiServiceFactory.java
index 51e4a31e13cd..ac5898edb21c 100644
--- a/qadevOOo/tests/java/ifc/lang/_XMultiServiceFactory.java
+++ b/qadevOOo/tests/java/ifc/lang/_XMultiServiceFactory.java
@@ -75,7 +75,7 @@ public class _XMultiServiceFactory extends MultiMethodTest {
 log.println("Service" + i + ": " + services[i]);
 }
 
-tRes.tested("getAvailableServiceNames()", services != null);
+tRes.tested("getAvailableServiceNames()", true);
 }
 
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3803f2adb77d69b53c05c542c366a25fe0177952
Author: Andrea Gelmini 
AuthorDate: Thu Dec 19 13:07:30 2019 +0100
Commit: Julien Nabet 
CommitDate: Thu Dec 19 14:18:36 2019 +0100

Fix typo

Change-Id: Ic6ec67b7a13506c6242b2863360b065724844c5a
Reviewed-on: https://gerrit.libreoffice.org/85520
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git 
a/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java 
b/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
index 54eef94be428..cb38aff5b393 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
@@ -117,7 +117,7 @@ public class _XCachedDynamicResultSetStubFactory extends 
MultiMethodTest {
 * Connection is checked by retrieving and comparing of row numbers
 * of connected set and its source set. 
 * Has OK status if row numbers are equal and they are
-* greater then 0 (because JAR file contains at least one entry).
+* greater than 0 (because JAR file contains at least one entry).
 */
 public void _connectToCache() throws Exception {
 boolean result = true ;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/frame/_XController.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 335852ffcf72e2ef6c4b02ebe645492bb7bc36d3
Author: Andrea Gelmini 
AuthorDate: Sat Nov 16 23:01:58 2019 +0100
Commit: Julien Nabet 
CommitDate: Sun Nov 17 08:44:14 2019 +0100

Fix typo

Change-Id: I59877df3c75d8423ae81a7d877b3144e65526253
Reviewed-on: https://gerrit.libreoffice.org/83007
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/frame/_XController.java 
b/qadevOOo/tests/java/ifc/frame/_XController.java
index 0419976a8ca2..48ecad772f07 100644
--- a/qadevOOo/tests/java/ifc/frame/_XController.java
+++ b/qadevOOo/tests/java/ifc/frame/_XController.java
@@ -67,7 +67,7 @@ public class _XController extends MultiMethodTest {
 * previously obtained object relation 'Frame'.
 * The following method tests are to be completed successfully before:
 * 
-*attachFrame()  : attachs frame obtained object
+*attachFrame()  : attaches frame obtained object
 * relation 'Frame' 
 * 
 */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/ucb/_XDataContainer.java |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 0f4d60ea931e9949a8d6c1ac6c60e331ad53eb66
Author: Andrea Gelmini 
AuthorDate: Thu Sep 12 13:00:42 2019 +0200
Commit: Julien Nabet 
CommitDate: Thu Sep 12 14:37:27 2019 +0200

Fix typo

Change-Id: If79519d6540b97549cc0dacce3621c03e7f9d9b7
Reviewed-on: https://gerrit.libreoffice.org/78828
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/ucb/_XDataContainer.java 
b/qadevOOo/tests/java/ifc/ucb/_XDataContainer.java
index 0f07c41ef532..d077d1be4a71 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XDataContainer.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XDataContainer.java
@@ -44,7 +44,7 @@ public class _XDataContainer extends MultiMethodTest {
 
 /**
 * Sets the content type to some value. 
-* Has OK status if no runtime exseptions occurred.
+* Has OK status if no runtime exceptions occurred.
 */
 public void _setContentType() {
 oObj.setContentType("image/jpeg") ;
@@ -68,7 +68,7 @@ public class _XDataContainer extends MultiMethodTest {
 
 /**
 * Sets the data to some byte array. 
-* Has OK status if no runtime exseptions occurred.
+* Has OK status if no runtime exceptions occurred.
 */
 public void _setData() {
 oObj.setData(data) ;
@@ -99,7 +99,7 @@ public class _XDataContainer extends MultiMethodTest {
 
 /**
 * Sets the data URL to some URL. 
-* Has OK status if no runtime exseptions occurred.
+* Has OK status if no runtime exceptions occurred.
 */
 public void _setDataURL() {
 dataURL = util.utils.getOfficeTemp(tParam.getMSF()) ;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/mod/_sc/XMLContentExporter.java |2 +-
 qadevOOo/tests/java/mod/_sc/XMLExporter.java|2 +-
 qadevOOo/tests/java/mod/_sc/XMLMetaExporter.java|2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5bcf85f6569b37461aa542387b70d422b36b627c
Author: Andrea Gelmini 
AuthorDate: Tue Sep 3 18:36:57 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Sep 3 21:46:30 2019 +0200

Fix typo

Change-Id: I63b774a1c8f64c2f736202ed73acfe2fe2718591
Reviewed-on: https://gerrit.libreoffice.org/78572
Reviewed-by: Julien Nabet 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/qadevOOo/tests/java/mod/_sc/XMLContentExporter.java 
b/qadevOOo/tests/java/mod/_sc/XMLContentExporter.java
index 0d29876246c6..098866ff058d 100644
--- a/qadevOOo/tests/java/mod/_sc/XMLContentExporter.java
+++ b/qadevOOo/tests/java/mod/_sc/XMLContentExporter.java
@@ -130,7 +130,7 @@ public class XMLContentExporter extends TestCase {
 XCell xCell = xSheet.getCellByPosition(0, 0);
 xCell.setFormula(CELL_TEXT);
 
-log.println("fill sheet 1 with contnet...");
+log.println("fill sheet 1 with content...");
 util.CalcTools.fillCalcSheetWithContent(xSheetDoc, 1, 1, 1, 5, 5);
 
 // adding tags which must be contained in XML output
diff --git a/qadevOOo/tests/java/mod/_sc/XMLExporter.java 
b/qadevOOo/tests/java/mod/_sc/XMLExporter.java
index bddb0701d6ba..c9edb37ab54e 100644
--- a/qadevOOo/tests/java/mod/_sc/XMLExporter.java
+++ b/qadevOOo/tests/java/mod/_sc/XMLExporter.java
@@ -129,7 +129,7 @@ public class XMLExporter extends TestCase {
 XNamed xSheetNamed = UnoRuntime.queryInterface(XNamed.class, xSheet);
 xSheetNamed.setName(SHEET_NAME);
 
-log.println("fill sheet with contnet...");
+log.println("fill sheet with content...");
 util.CalcTools.fillCalcSheetWithContent(xSheet, 3, 3, 50, 50);
 
 // adding tags which must be contained in XML output
diff --git a/qadevOOo/tests/java/mod/_sc/XMLMetaExporter.java 
b/qadevOOo/tests/java/mod/_sc/XMLMetaExporter.java
index 7ebdca4b7e5f..0f49662c1cbd 100644
--- a/qadevOOo/tests/java/mod/_sc/XMLMetaExporter.java
+++ b/qadevOOo/tests/java/mod/_sc/XMLMetaExporter.java
@@ -133,7 +133,7 @@ public class XMLMetaExporter extends TestCase {
 final XDocumentProperties xDocProps = xPropSup.getDocumentProperties();
 xDocProps.setTitle("TestDocument");
 
-log.println("fill sheet 1 with contnet...");
+log.println("fill sheet 1 with content...");
 util.CalcTools.fillCalcSheetWithContent(xSheetDoc,1, 3, 3, 50, 50);
 
 // create testobject here
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests starmath/source

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_sm/SmEditAccessible.java |4 ++--
 starmath/source/accessibility.cxx |5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 815afb06b78b8fbf83f6a48b89500fb34dc4b40b
Author: Caolán McNamara 
AuthorDate: Mon Sep 2 20:45:14 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Sep 3 12:44:50 2019 +0200

indicate that SmEditAccessible is editable

and use TEXT_FRAME like calc and other similar users of
of an EditEngine as a frame do.

Change-Id: I9d73362aa44273f87b283fcfc508d27abb50cb40
Reviewed-on: https://gerrit.libreoffice.org/78420
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_sm/SmEditAccessible.java 
b/qadevOOo/tests/java/mod/_sm/SmEditAccessible.java
index 710027706969..7b7a2c28d25a 100644
--- a/qadevOOo/tests/java/mod/_sm/SmEditAccessible.java
+++ b/qadevOOo/tests/java/mod/_sm/SmEditAccessible.java
@@ -63,7 +63,7 @@ public class SmEditAccessible extends TestCase {
 
 /**
  * Creates a StarMath document and obtains an accessibility
- * component with the role AccessibleRole.PANEL.
+ * component with the role AccessibleRole.TEXT_FRAME.
  */
 @Override
 protected TestEnvironment createTestEnvironment(final TestParameters 
Param, PrintWriter log) throws Exception {
@@ -86,7 +86,7 @@ public class SmEditAccessible extends TestCase {
 XAccessible xRoot = AccessibilityTools.getAccessibleObject(xWindow);
 
 oObj = AccessibilityTools.getAccessibleObjectForRole
-(xRoot, AccessibleRole.PANEL, "", "SmEditAccessible");
+(xRoot, AccessibleRole.TEXT_FRAME, "", "SmEditAccessible");
 
 log.println("ImplementationName " + utils.getImplName(oObj));
 AccessibilityTools.printAccessibleTree(log, xRoot, 
Param.getBool(util.PropertyName.DEBUG_IS_ACTIVE));
diff --git a/starmath/source/accessibility.cxx 
b/starmath/source/accessibility.cxx
index 8fb20618c701..98868df14a55 100644
--- a/starmath/source/accessibility.cxx
+++ b/starmath/source/accessibility.cxx
@@ -1648,7 +1648,7 @@ sal_Int32 SAL_CALL 
SmEditAccessible::getAccessibleChildCount(  )
 {
 SolarMutexGuard aGuard;
 if (!pTextHelper)
-throw RuntimeException();
+return 0;
 return pTextHelper->GetChildCount();
 }
 
@@ -1688,7 +1688,7 @@ sal_Int32 SAL_CALL 
SmEditAccessible::getAccessibleIndexInParent(  )
 
 sal_Int16 SAL_CALL SmEditAccessible::getAccessibleRole(  )
 {
-return AccessibleRole::PANEL /*TEXT ?*/;
+return AccessibleRole::TEXT_FRAME;
 }
 
 OUString SAL_CALL SmEditAccessible::getAccessibleDescription(  )
@@ -1723,6 +1723,7 @@ uno::Reference< XAccessibleStateSet > SAL_CALL 
SmEditAccessible::getAccessibleSt
 {
 pStateSet->AddState( AccessibleStateType::MULTI_LINE );
 pStateSet->AddState( AccessibleStateType::ENABLED );
+pStateSet->AddState( AccessibleStateType::EDITABLE );
 pStateSet->AddState( AccessibleStateType::FOCUSABLE );
 if (pWin->HasFocus())
 pStateSet->AddState( AccessibleStateType::FOCUSED );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/frame/_XController.java|2 +-
 qadevOOo/tests/java/ifc/inspection/_XObjectInspectorModel.java |2 +-
 qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java|4 ++--
 qadevOOo/tests/java/ifc/linguistic2/_XSupportedLocales.java|2 +-
 qadevOOo/tests/java/ifc/style/_PageProperties.java |2 +-
 qadevOOo/tests/java/ifc/table/_XCellRange.java |4 ++--
 qadevOOo/tests/java/mod/_sc/ScShapeObj.java|2 +-
 qadevOOo/tests/java/mod/_sd/AccessibleSlideView.java   |2 +-
 qadevOOo/tests/java/mod/_sd/SdUnoOutlineView.java  |2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 9bf27c757f92777585300bf6a145717c2cc0b74f
Author: Andrea Gelmini 
AuthorDate: Sun Aug 11 19:36:08 2019 +0200
Commit: Julien Nabet 
CommitDate: Mon Aug 12 16:23:45 2019 +0200

Fix typos

Change-Id: I33effc62e69861d6751a152ff292dcb75802f33c
Reviewed-on: https://gerrit.libreoffice.org/77304
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/frame/_XController.java 
b/qadevOOo/tests/java/ifc/frame/_XController.java
index 1ad53a60e25c..af467456e9e6 100644
--- a/qadevOOo/tests/java/ifc/frame/_XController.java
+++ b/qadevOOo/tests/java/ifc/frame/_XController.java
@@ -47,7 +47,7 @@ import com.sun.star.util.XModifiable;
 *   'SecondModel' (of type XModel):
 *   other model, used for tests 
 *   'HasViewData' (of type Boolean):
-*   (optional relation) if it exsists, so controller has no view data
+*   (optional relation) if it exists, so controller has no view data
 *   'SecondController' (of type XController):
 *   other controller, used for tests 
 *  
diff --git a/qadevOOo/tests/java/ifc/inspection/_XObjectInspectorModel.java 
b/qadevOOo/tests/java/ifc/inspection/_XObjectInspectorModel.java
index e0f3ff97545f..afca1175cc0a 100644
--- a/qadevOOo/tests/java/ifc/inspection/_XObjectInspectorModel.java
+++ b/qadevOOo/tests/java/ifc/inspection/_XObjectInspectorModel.java
@@ -62,7 +62,7 @@ public class _XObjectInspectorModel extends MultiMethodTest {
 int index = 0;
 boolean result = true;
 
-log.println("try to get index of INvalid property name 
'InvalidPropertyName' ...");
+log.println("try to get index of Invalid property name 
'InvalidPropertyName' ...");
 index = oObj.getPropertyOrderIndex("InvalidPropertyName");
 log.println("index is: " + index);
 result = (index == 0);
diff --git a/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java 
b/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java
index 642444e2c98e..75eaf86267c0 100644
--- a/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java
+++ b/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java
@@ -50,7 +50,7 @@ public class _XSpellChecker extends MultiMethodTest {
 
 /**
 * Test calls the method for a correctly spelled word and
-* for a incorrectly spelled word and checks returned values. 
+* for an incorrectly spelled word and checks returned values. 
 * Has  OK  status if returned value is equal to true in first case,
 * if returned value is equal to false in second case and no exceptions
 * were thrown. 
@@ -75,7 +75,7 @@ public class _XSpellChecker extends MultiMethodTest {
 }
 
 /**
-* Test calls the method for a incorrectly spelled word
+* Test calls the method for an incorrectly spelled word
 * and checks returned values. 
 * Has  OK  status if at least one spell alternative exists
 * and no exceptions were thrown. 
diff --git a/qadevOOo/tests/java/ifc/linguistic2/_XSupportedLocales.java 
b/qadevOOo/tests/java/ifc/linguistic2/_XSupportedLocales.java
index 269e07c8ac15..a9536b8d26e8 100644
--- a/qadevOOo/tests/java/ifc/linguistic2/_XSupportedLocales.java
+++ b/qadevOOo/tests/java/ifc/linguistic2/_XSupportedLocales.java
@@ -68,7 +68,7 @@ public class _XSupportedLocales extends MultiMethodTest {
 res &= oObj.hasLocale(locales[i]);
 }
 
-// now create a invalid locale
+// now create an invalid locale
 Locale invalid = new Locale("myLanguage","myCountry","");
 res &= !oObj.hasLocale(invalid);
 
diff --git a/qadevOOo/tests/java/ifc/style/_PageProperties.java 
b/qadevOOo/tests/java/ifc/style/_PageProperties.java
index 69c15f0359af..f8896c6d4095 100644
--- a/qadevOOo/tests/java/ifc/style/_PageProperties.java
+++ b/qadevOOo/tests/java/ifc/style/_PageProperties.java
@@ -57,7 +57,7 @@ public class _PageProperties  extends MultiPropertyTest {
 /**
  * This property is system dependent and printer dependent.
  * So only reading it does make sense, since it cannot be determined, if
- * it is set to a allowed value.
+ * it is set to an allowed value.
  */
 public void _PrinterPaperTray() {
 boolean res = false;
diff --git 

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/mod/_sd/SdUnoSlideView.java   |2 +-
 qadevOOo/tests/java/mod/_simplereg/uno/SimpleRegistry.java|2 +-
 qadevOOo/tests/java/mod/_simreg/SimpleRegistry.java   |2 +-
 qadevOOo/tests/java/mod/_svx/SvxShapeCollection.java  |2 +-
 qadevOOo/tests/java/mod/_svx/SvxShapeConnector.java   |2 +-
 qadevOOo/tests/java/mod/_svx/SvxShapeControl.java |2 +-
 qadevOOo/tests/java/mod/_svx/SvxShapeDimensioning.java|2 +-
 qadevOOo/tests/java/mod/_svx/SvxShapePolyPolygon.java |2 +-
 qadevOOo/tests/java/mod/_sw/SwAccessibleDocumentPageView.java |2 +-
 qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java  |4 ++--
 10 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit a8960b2eb558b7e3a6a5c9d7c940e5b3dbc9911e
Author: Andrea Gelmini 
AuthorDate: Sun Aug 11 19:35:31 2019 +0200
Commit: Julien Nabet 
CommitDate: Mon Aug 12 16:22:48 2019 +0200

Fix typos

Change-Id: I0164d554e52225a6c6e9bece47a96a2ff3c85612
Reviewed-on: https://gerrit.libreoffice.org/77303
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/mod/_sd/SdUnoSlideView.java 
b/qadevOOo/tests/java/mod/_sd/SdUnoSlideView.java
index 8a3862293e00..25016309a8e8 100644
--- a/qadevOOo/tests/java/mod/_sd/SdUnoSlideView.java
+++ b/qadevOOo/tests/java/mod/_sd/SdUnoSlideView.java
@@ -104,7 +104,7 @@ public class SdUnoSlideView extends TestCase {
 // get a soffice factory object
 SOfficeFactory SOF = SOfficeFactory.getFactory( Param.getMSF());
 XDrawPages xDP = null;
-log.println( "creating a impress document" );
+log.println( "creating an impress document" );
 xImpressDoc = SOF.createImpressDoc(null);
 util.utils.waitForEventIdle(Param.getMSF());
 xDP = DrawTools.getDrawPages(xImpressDoc);
diff --git a/qadevOOo/tests/java/mod/_simplereg/uno/SimpleRegistry.java 
b/qadevOOo/tests/java/mod/_simplereg/uno/SimpleRegistry.java
index d209cac4aedf..99146f159e3d 100644
--- a/qadevOOo/tests/java/mod/_simplereg/uno/SimpleRegistry.java
+++ b/qadevOOo/tests/java/mod/_simplereg/uno/SimpleRegistry.java
@@ -54,7 +54,7 @@ public class SimpleRegistry extends TestCase {
 * @param src Source file path.
 * @param dst Destination file path.
 * @param log The log writer.
-* @throws java.io.IOException If any problems occur during copiing.
+* @throws java.io.IOException If any problems occur during copying.
 */
 protected void copyFile(String src, String dst, PrintWriter log)
 throws java.io.IOException {
diff --git a/qadevOOo/tests/java/mod/_simreg/SimpleRegistry.java 
b/qadevOOo/tests/java/mod/_simreg/SimpleRegistry.java
index 779019bb5050..8c513d7b595c 100644
--- a/qadevOOo/tests/java/mod/_simreg/SimpleRegistry.java
+++ b/qadevOOo/tests/java/mod/_simreg/SimpleRegistry.java
@@ -57,7 +57,7 @@ public class SimpleRegistry extends TestCase {
 * @param src Source file path.
 * @param dst Destination file path.
 * @param log The log writer.
-* @throws java.io.IOException If any problems occur during copiing.
+* @throws java.io.IOException If any problems occur during copying.
 */
 protected void copyFile(String src, String dst, PrintWriter log)
 throws java.io.IOException {
diff --git a/qadevOOo/tests/java/mod/_svx/SvxShapeCollection.java 
b/qadevOOo/tests/java/mod/_svx/SvxShapeCollection.java
index 151caf5eeb4d..5cbad5230053 100644
--- a/qadevOOo/tests/java/mod/_svx/SvxShapeCollection.java
+++ b/qadevOOo/tests/java/mod/_svx/SvxShapeCollection.java
@@ -115,7 +115,7 @@ public class SvxShapeCollection extends TestCase {
 
 }
 catch (Exception e) {
-log.println("Couldn't create insance");
+log.println("Couldn't create instance");
 e.printStackTrace(log);
 }
 
diff --git a/qadevOOo/tests/java/mod/_svx/SvxShapeConnector.java 
b/qadevOOo/tests/java/mod/_svx/SvxShapeConnector.java
index 7340da22a30c..7236bcc18c29 100644
--- a/qadevOOo/tests/java/mod/_svx/SvxShapeConnector.java
+++ b/qadevOOo/tests/java/mod/_svx/SvxShapeConnector.java
@@ -131,7 +131,7 @@ public class SvxShapeConnector extends TestCase {
 DrawTools.getShapes(DrawTools.getDrawPage(xDrawDoc,0)).add(oShape);
 }
 catch (Exception e) {
-log.println("Couldn't create insance");
+log.println("Couldn't create instance");
 e.printStackTrace(log);
 }
 
diff --git a/qadevOOo/tests/java/mod/_svx/SvxShapeControl.java 
b/qadevOOo/tests/java/mod/_svx/SvxShapeControl.java
index aac416f0c5a4..fe07d05789e1 100644
--- a/qadevOOo/tests/java/mod/_svx/SvxShapeControl.java
+++ b/qadevOOo/tests/java/mod/_svx/SvxShapeControl.java
@@ -108,7 +108,7 @@ public class SvxShapeControl extends TestCase {
 DrawTools.getShapes(DrawTools.getDrawPage(xDrawDoc,0)).add(oShape) 
;
 }
 

[Libreoffice-commits] core.git: qadevOOo/tests registry/test ridljar/com sax/source sc/qa

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/mod/_sw/SwAccessibleFooterView.java   |2 +-
 qadevOOo/tests/java/mod/_sw/SwAccessibleFootnoteView.java |2 +-
 qadevOOo/tests/java/mod/_sw/SwXAutoTextContainer.java |2 +-
 qadevOOo/tests/java/mod/_sw/SwXEndnoteProperties.java |2 +-
 registry/test/testregcpp.cxx  |2 +-
 ridljar/com/sun/star/uno/Enum.java|2 +-
 ridljar/com/sun/star/uno/UnoRuntime.java  |2 +-
 sax/source/expatwrap/saxwriter.cxx|4 ++--
 sax/source/tools/fastserializer.hxx   |2 +-
 sc/qa/extras/check_xcell_ranges_query.cxx |8 
 10 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 38719c3341bf4244fcaf835a3933c922e9153251
Author: Andrea Gelmini 
AuthorDate: Sun Aug 11 19:35:07 2019 +0200
Commit: Julien Nabet 
CommitDate: Mon Aug 12 11:36:05 2019 +0200

Fix typos

Change-Id: Ia40e7a9031ae5a8385a84f177a9444f4d4f348b4
Reviewed-on: https://gerrit.libreoffice.org/77302
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/mod/_sw/SwAccessibleFooterView.java 
b/qadevOOo/tests/java/mod/_sw/SwAccessibleFooterView.java
index c68079738bc1..24ee0035824f 100644
--- a/qadevOOo/tests/java/mod/_sw/SwAccessibleFooterView.java
+++ b/qadevOOo/tests/java/mod/_sw/SwAccessibleFooterView.java
@@ -93,7 +93,7 @@ public class SwAccessibleFooterView extends TestCase {
 PropSet.setPropertyValue("FooterIsOn", Boolean.TRUE);
 
 //change zoom value to 10%
-//footer should be in the vissible area of the document
+//footer should be in the visible area of the document
 XController xController = xTextDoc.getCurrentController();
 XViewSettingsSupplier xViewSetSup = 
UnoRuntime.queryInterface(XViewSettingsSupplier.class,
 xController);
diff --git a/qadevOOo/tests/java/mod/_sw/SwAccessibleFootnoteView.java 
b/qadevOOo/tests/java/mod/_sw/SwAccessibleFootnoteView.java
index 29f36a6185ea..0899108a83d3 100644
--- a/qadevOOo/tests/java/mod/_sw/SwAccessibleFootnoteView.java
+++ b/qadevOOo/tests/java/mod/_sw/SwAccessibleFootnoteView.java
@@ -85,7 +85,7 @@ public class SwAccessibleFootnoteView extends TestCase {
 XPropertySet xPropSet = xViewSetSup.getViewSettings();
 
 //change zoom value to 10%
-//footer should be in the vissible area of the document
+//footer should be in the visible area of the document
 xPropSet.setPropertyValue("ZoomValue", Short.valueOf("10"));
 
 XModel aModel = UnoRuntime.queryInterface(XModel.class, xTextDoc);
diff --git a/qadevOOo/tests/java/mod/_sw/SwXAutoTextContainer.java 
b/qadevOOo/tests/java/mod/_sw/SwXAutoTextContainer.java
index eb132c78037b..edaa1aed98e4 100644
--- a/qadevOOo/tests/java/mod/_sw/SwXAutoTextContainer.java
+++ b/qadevOOo/tests/java/mod/_sw/SwXAutoTextContainer.java
@@ -59,7 +59,7 @@ public class SwXAutoTextContainer extends TestCase {
 
 // creation of testobject here
 // first we write what we are intend to do to log file
-log.println("creating a AutoTextContainer");
+log.println("creating an AutoTextContainer");
 XMultiServiceFactory myMSF = Param.getMSF();
 Object oInst = myMSF.createInstance
 ("com.sun.star.text.AutoTextContainer");
diff --git a/qadevOOo/tests/java/mod/_sw/SwXEndnoteProperties.java 
b/qadevOOo/tests/java/mod/_sw/SwXEndnoteProperties.java
index 1d2d296d965e..c2dbba2d744f 100644
--- a/qadevOOo/tests/java/mod/_sw/SwXEndnoteProperties.java
+++ b/qadevOOo/tests/java/mod/_sw/SwXEndnoteProperties.java
@@ -86,7 +86,7 @@ public class SwXEndnoteProperties extends TestCase {
 
 log.println( "Creating a test environment" );
 XMultiServiceFactory msf = 
UnoRuntime.queryInterface(XMultiServiceFactory.class, xTextDoc);
-log.println("creating a endnote");
+log.println("creating an endnote");
 oEndnote = UnoRuntime.queryInterface(XInterface.class,
 msf.createInstance("com.sun.star.text.Endnote"));
 
diff --git a/registry/test/testregcpp.cxx b/registry/test/testregcpp.cxx
index fa038c19d4d6..064eb40137a2 100644
--- a/registry/test/testregcpp.cxx
+++ b/registry/test/testregcpp.cxx
@@ -152,7 +152,7 @@ void test_coreReflection()
 
 aReadConst = reader.getFieldConstValue(10);
 OString aConstStr = OUStringToOString(aConst.m_value.aString, 
RTL_TEXTENCODING_ASCII_US);
-REG_ENSURE(aConstStr.equals("this is an unicode string"), 
"testCoreReflection error 9b");
+REG_ENSURE(aConstStr.equals("this is a unicode string"), 
"testCoreReflection error 9b");
 }
 
 }
diff --git a/ridljar/com/sun/star/uno/Enum.java 
b/ridljar/com/sun/star/uno/Enum.java
index f18015d9558d..8bd50876dd9e 100644
--- a/ridljar/com/sun/star/uno/Enum.java
+++ b/ridljar/com/sun/star/uno/Enum.java
@@ -24,7 +24,7 @@ package 

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_forms/ODatabaseForm.java |4 
 1 file changed, 4 deletions(-)

New commits:
commit 14daeaa9c15f5c9278f861d5109f26d366cc0897
Author: Caolán McNamara 
AuthorDate: Sat Aug 10 16:23:41 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Aug 10 18:12:53 2019 +0200

cid#1448392 silence Dereference before null check

Change-Id: I9c9d24217cad66c06df3d0e54df6254f54238798
Reviewed-on: https://gerrit.libreoffice.org/77244
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_forms/ODatabaseForm.java 
b/qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
index ac2dd166df73..0683ab01cffa 100644
--- a/qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
+++ b/qadevOOo/tests/java/mod/_forms/ODatabaseForm.java
@@ -526,10 +526,6 @@ public class ODatabaseForm extends TestCase {
 // adding relation for XPersistObject
 tEnv.addObjRelation("OBJNAME", "stardiv.one.form.component.Form");
 
-if (the_set != null) {
-log.println("The Form has a not empty ResultSet");
-}
-
 // Adding obj relation for XRowSetApproveBroadcaster test
 final XResultSet xResSet = UnoRuntime.queryInterface(
XResultSet.class, oObj);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests registry/source

[Andrea Gelmini (via logerrit)]

 qadevOOo/tests/java/ifc/text/_XTextContent.java |2 +-
 qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java|4 ++--
 qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java |2 +-
 qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java   |2 +-
 qadevOOo/tests/java/ifc/util/_XStringSubstitution.java  |4 ++--
 qadevOOo/tests/java/ifc/view/_XScreenCursor.java|2 +-
 qadevOOo/tests/java/mod/_defreg/NestedRegistry.java |4 ++--
 qadevOOo/tests/java/mod/_fwk/JobExecutor.java   |2 +-
 qadevOOo/tests/java/mod/_fwk/JobHandler.java|2 +-
 qadevOOo/tests/java/mod/_fwk/ModuleManager.java |2 +-
 qadevOOo/tests/java/mod/_nestedreg/uno/NestedRegistry.java  |4 ++--
 qadevOOo/tests/java/mod/_sc/ScTabViewObj.java   |6 +++---
 qadevOOo/tests/java/mod/_sch/ChXDiagram.java|2 +-
 registry/source/keyimpl.cxx |2 +-
 14 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit ca6df519a78e5bfc96030c916f242b86306194e5
Author: Andrea Gelmini 
AuthorDate: Tue Jul 30 08:03:32 2019 +0200
Commit: Andrea Gelmini 
CommitDate: Tue Jul 30 23:47:47 2019 +0200

Fix typos

Change-Id: Ia5fba032635adbf85bdfcb1eb0b3ffb9cf9d4a6a
Reviewed-on: https://gerrit.libreoffice.org/76548
Reviewed-by: Julien Nabet 
Tested-by: Andrea Gelmini 

diff --git a/qadevOOo/tests/java/ifc/text/_XTextContent.java 
b/qadevOOo/tests/java/ifc/text/_XTextContent.java
index 3b6a5e0a4578..bcb65b806343 100644
--- a/qadevOOo/tests/java/ifc/text/_XTextContent.java
+++ b/qadevOOo/tests/java/ifc/text/_XTextContent.java
@@ -52,7 +52,7 @@ public class _XTextContent extends MultiMethodTest {
 /**
  * Tries to get the anchor of the text content
  * an XTextRange is returned. 
- * The test is OK if an not null text range is returned
+ * The test is OK if a not null text range is returned
  */
 public void _getAnchor() {
 log.println("getAnchor()");
diff --git a/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java 
b/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
index 4dedd74cf6d9..47d389c9a4af 100644
--- a/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
+++ b/qadevOOo/tests/java/ifc/text/_XTextRangeCompare.java
@@ -67,7 +67,7 @@ public class _XTextRangeCompare extends MultiMethodTest {
 /**
  * Retrieves XText interface from relation 'TEXTDOC'
  * or from 'TEXT'.
- * @throws StatusException If neither 'TEXTDOC' nore 'TEXT'
+ * @throws StatusException If neither 'TEXTDOC' nor 'TEXT'
  * relation exists.
  */
 @Override
@@ -87,7 +87,7 @@ public class _XTextRangeCompare extends MultiMethodTest {
 
 if (oText == null) {
 throw new StatusException(Status.failed
-("Neither 'TEXTDOC' nore 'TEXT' relation not found")) ;
+("Neither 'TEXTDOC' nor 'TEXT' relation not found")) ;
 }
 }
 
diff --git a/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java 
b/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
index d129579e1ff4..6a66dae9ee63 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XContentIdentifierFactory.java
@@ -43,7 +43,7 @@ public class _XContentIdentifierFactory extends 
MultiMethodTest {
 /**
  * Calls the tested method with a file url and
  * gets an identifier. 
- * Has  OK  status if content identifier an provider sheme are
+ * Has  OK  status if content identifier and provider scheme are
  * proper. 
  */
 public void _createContentIdentifier() {
diff --git a/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java 
b/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
index 8b880e67cf7c..73290288c89c 100644
--- a/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
+++ b/qadevOOo/tests/java/ifc/ui/_XUIConfiguration.java
@@ -63,7 +63,7 @@ public class _XUIConfiguration extends MultiMethodTest {
 }
 
 /**
- * adds a listener an fire an event
+ * adds a listener and fires an event
  * Has OK status if listener was called
  */
 public void _addConfigurationListener() {
diff --git a/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java 
b/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
index a19ecbaf467c..77d5fe5fbb43 100644
--- a/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
+++ b/qadevOOo/tests/java/ifc/util/_XStringSubstitution.java
@@ -37,7 +37,7 @@ public class _XStringSubstitution extends MultiMethodTest {
 tRes.tested("getSubstituteVariableValue()",false);
 }
 try {
-log.println("try to get a invalid variable...");
+log.println("try to get an invalid variable...");
 String toCheck = "$(ThisVariableShouldNoExist)";
 oObj.getSubstituteVariableValue(toCheck);
 

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_remotebridge/various.java |   40 -
 1 file changed, 40 deletions(-)

New commits:
commit 130c2b80520b92353d9e1fc4626277bab9af3b6c
Author: Caolán McNamara 
AuthorDate: Fri Jul 26 09:02:24 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jul 26 21:37:09 2019 +0200

cid#1448357 RV: Bad use of return value

Change-Id: I7bbc81e0b01e90c368a29ac505418471f640cdf6
Reviewed-on: https://gerrit.libreoffice.org/76360
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_remotebridge/various.java 
b/qadevOOo/tests/java/mod/_remotebridge/various.java
index c18d6a4ef1eb..21f3c0892955 100644
--- a/qadevOOo/tests/java/mod/_remotebridge/various.java
+++ b/qadevOOo/tests/java/mod/_remotebridge/various.java
@@ -76,44 +76,6 @@ public class various extends TestCase {
 public XInterface bridge = null;
 
 /**
- * Implementation of interface XInstanceProvider
- *
- * @see com.sun.star.bridge.XInstanceProvider
- */
-private static class MyInstanceProvider implements XInstanceProvider {
-/**
- * a MultiServiceFactory for creating instances
- *
- * @see com.sun.star.lang.MultiServiceFactory
- */
-private final XMultiServiceFactory xMSF;
-
-/**
- * Construct object with a MultiServiceFactory
- *
- * @see com.sun.star.lang.MultiServiceFactory
- */
-private MyInstanceProvider(XMultiServiceFactory xMSF) {
-this.xMSF = xMSF;
-}
-
-/**
- * get an instance by name
- */
-public Object getInstance(String aInstanceName)
-throws com.sun.star.container.NoSuchElementException
-{
-System.out.println(" Try to get "+aInstanceName);
-try {
-return xMSF.createInstance(aInstanceName);
-}
-catch(com.sun.star.uno.Exception e) {
-throw new StatusException("Unexpected exception", e);
-}
-}
-}
-
-/**
 * Calls accept() method in a separate thread.
 * Then stores exception thrown by call if it occurred, or
 * return value.
@@ -196,8 +158,6 @@ public class various extends TestCase {
 "com.sun.star.bridge.BridgeFactory") ;
 xBrdgFctr = UnoRuntime.queryInterface(XBridgeFactory.class, oBrdg);
 
-// create own implementation of XInstanceProvider
-new MyInstanceProvider(xMSF);
 // create waiting acceptor thread
 accThread = new AcceptorThread(xAcctr);
 accThread.start();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_fwl/FilterFactory.java |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 8b533ac06c302c68ccc78552ab3b9ef578c3e8d9
Author: Caolán McNamara 
AuthorDate: Fri Jul 26 09:10:34 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jul 26 21:24:03 2019 +0200

cid#1448221 RV: Bad use of return value

Change-Id: I3284cf35b28edc1fb08579f707bbf76fcde8b054
Reviewed-on: https://gerrit.libreoffice.org/76362
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_fwl/FilterFactory.java 
b/qadevOOo/tests/java/mod/_fwl/FilterFactory.java
index 9d21625f331d..1ed9869b1832 100644
--- a/qadevOOo/tests/java/mod/_fwl/FilterFactory.java
+++ b/qadevOOo/tests/java/mod/_fwl/FilterFactory.java
@@ -79,11 +79,7 @@ public class FilterFactory extends TestCase {
 
 // XNameContainer; XNameReplace
 String filterName = filterNames[0];
-Object[] instance = null;
-new PropertyValue();
-instance = (Object[]) xNA.getByName(filterName);
-getPropertyValue
-(((PropertyValue[]) instance), "FilterService");
+Object[] instance = (Object[]) xNA.getByName(filterName);
 
 log.println("adding INSTANCE 1 as obj relation to environment");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 436d30ed57cc9f6122137cdba30afe5935c8bb34
Author: Caolán McNamara 
AuthorDate: Fri Jul 26 08:58:08 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Jul 26 12:57:40 2019 +0200

cid#1448530 RV: Bad use of return value

Change-Id: Id84149b619b39d71bc8fb2d01774afd085245a0b
Reviewed-on: https://gerrit.libreoffice.org/76357
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java 
b/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
index 80f9b5b17c34..4ca3a43aa8dd 100644
--- a/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
+++ b/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
@@ -21,6 +21,8 @@ import com.sun.star.sdbc.XConnection;
 import com.sun.star.uno.Exception;
 import java.io.PrintWriter;
 
+import lib.Status;
+import lib.StatusException;
 import lib.TestCase;
 import lib.TestEnvironment;
 import lib.TestParameters;
@@ -190,7 +192,13 @@ public class OQueryDesign extends TestCase {
 XController xCont = UnoRuntime.queryInterface(XController.class, 
oQueryDesign);
 
 // marry them all
-xCont.attachModel(xMod);
+boolean bSuccess = xCont.attachModel(xMod);
+if (!bSuccess)
+{
+throw new StatusException (Status.failed (
+"Couldn't attach model"));
+}
+
 xMod.connectController(xCont);
 xMod.setCurrentController(xCont);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/text/_XSimpleText.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ceac24b4a140a471a36f423bf48dce32860e8911
Author: Caolán McNamara 
AuthorDate: Wed Jul 24 10:53:42 2019 +0100
Commit: Caolán McNamara 
CommitDate: Wed Jul 24 21:34:01 2019 +0200

cid#1448461 RV: Bad use of return value

Change-Id: I11dce56c00931b0e04c5fa52f2598a8f80625d5b
Reviewed-on: https://gerrit.libreoffice.org/76243
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/text/_XSimpleText.java 
b/qadevOOo/tests/java/ifc/text/_XSimpleText.java
index 8f1c32d40911..f4ab856f3b5d 100644
--- a/qadevOOo/tests/java/ifc/text/_XSimpleText.java
+++ b/qadevOOo/tests/java/ifc/text/_XSimpleText.java
@@ -98,7 +98,7 @@ public class _XSimpleText extends MultiMethodTest {
 }
 catch(com.sun.star.lang.IllegalArgumentException e ) {
 // Some exception.FAILED
-Status.failed( e.toString() );
+log.println(e.toString());
 bOK = false;
 }
 String gStr = oObj.getString() ;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/style/_ParagraphProperties.java |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 426eff7c6652033518c22d124f22c423e1ae054b
Author: Caolán McNamara 
AuthorDate: Wed Jul 24 11:31:58 2019 +0100
Commit: Caolán McNamara 
CommitDate: Wed Jul 24 18:14:12 2019 +0200

cid#1448303 RV: Bad use of return value

Change-Id: I779ba87054cbfc10d2d1b26159c5c4873364ebfa
Reviewed-on: https://gerrit.libreoffice.org/76250
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java 
b/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
index d1f134b9f258..88b1cae74dce 100644
--- a/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
+++ b/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
@@ -329,23 +329,23 @@ public class _ParagraphProperties extends 
MultiPropertyTest {
 NumberingRules = (XIndexReplace) AnyConverter.toObject(
new Type(XIndexReplace.class), 
oObj.getPropertyValue("NumberingRules"));
 } catch (com.sun.star.lang.IllegalArgumentException ex) {
-Status.failed( "could not get NumberingRuels: "+ ex.toString() );
+log.println("could not get NumberingRules: "+ ex.toString() );
 return;
 } catch (UnknownPropertyException ex) {
-Status.failed( "could not get NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberingRules: "+ ex.toString() );
 return;
 } catch (WrappedTargetException ex) {
-Status.failed( "could not get NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberingRules: "+ ex.toString() );
 return;
 }
 try {
 propertyValues = (PropertyValue[]) NumberingRules.getByIndex(0);
 
 } catch (com.sun.star.lang.IndexOutOfBoundsException ex) {
-Status.failed( "could not get NumberlingLevel-Array from 
NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberlingLevel-Array from 
NumberingRules: "+ ex.toString() );
 return;
 } catch (WrappedTargetException ex) {
-Status.failed( "could not get NumberlingLevel-Array from 
NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberlingLevel-Array from 
NumberingRules: "+ ex.toString() );
 return;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_forms/OTimeModel.java |4 
 1 file changed, 4 deletions(-)

New commits:
commit 0e6b23bd9cb69e753093ae9e8854a5a94ca6656c
Author: Caolán McNamara 
AuthorDate: Mon Jul 22 12:30:49 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Jul 23 09:32:54 2019 +0200

cid#1448364 UC: Useless code

Change-Id: I583b4d947b18147bcfac7c518002c2bd676e0bb3
Reviewed-on: https://gerrit.libreoffice.org/76139
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_forms/OTimeModel.java 
b/qadevOOo/tests/java/mod/_forms/OTimeModel.java
index 999ae6e606ed..8dda139e5fea 100644
--- a/qadevOOo/tests/java/mod/_forms/OTimeModel.java
+++ b/qadevOOo/tests/java/mod/_forms/OTimeModel.java
@@ -159,10 +159,6 @@ public class OTimeModel extends GenericModelTest {
  PrintWriter 
log) throws Exception {
 TestEnvironment tEnv = super.createTestEnvironment(Param, log);
 
-HashSet exclude = new HashSet();
-
-exclude.add("FormatKey");
-
 tEnv.addObjRelation("XUpdateBroadcaster.Checker",
 new Checker(m_XFormLoader, m_XPS, m_XCtrl));
 return tEnv;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/mod/_sw/SwXMailMerge.java |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit b6455d16e05fc417c2d1d55ef674ce521c2fdd14
Author: Caolán McNamara 
AuthorDate: Mon Jul 22 12:31:55 2019 +0100
Commit: Caolán McNamara 
CommitDate: Tue Jul 23 09:31:06 2019 +0200

cid#1448354 UC: Useless code

Change-Id: Ic4bac0378ee71550d5581a2c8e4c1cb5108b0a58
Reviewed-on: https://gerrit.libreoffice.org/76140
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/mod/_sw/SwXMailMerge.java 
b/qadevOOo/tests/java/mod/_sw/SwXMailMerge.java
index 53eb110cf924..f3bb2b2f242c 100644
--- a/qadevOOo/tests/java/mod/_sw/SwXMailMerge.java
+++ b/qadevOOo/tests/java/mod/_sw/SwXMailMerge.java
@@ -86,9 +86,6 @@ public class SwXMailMerge extends TestCase {
 String cOutputURL = utils.getOfficeTemp( Param.getMSF());
 String cDataSourceName  = "Bibliography";
 String cDataCommand = "biblio";
-Object[] sel = new Object[2];
-sel[0] = new int[2];
-sel[1] = new int[5];
 Object[] myBookMarks = new Object[2];
 // 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara (via logerrit)]

 qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 74ce2c90ecc6f6375ff6743efdd0b84358ebd6a3
Author: Caolán McNamara 
AuthorDate: Sat Jul 20 15:57:59 2019 +0100
Commit: Caolán McNamara 
CommitDate: Sat Jul 20 21:13:29 2019 +0200

cid#1448454 RV: Bad use of return value

Change-Id: I704b432a09bb4bbd0192bd0a3ae6b39012a14110
Reviewed-on: https://gerrit.libreoffice.org/76024
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java 
b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
index e262a15c8a33..dc775c6e1d8c 100644
--- a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
+++ b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java
@@ -319,7 +319,7 @@ public class _XMultiSelectionSupplier extends 
MultiMethodTest {
 i++;
 
 if (ObjCompare != null) {
-ObjCompare.compare(shouldElement, nextElement);
+compRes = ObjCompare.compare(shouldElement, nextElement) == 0;
 } else {
 compRes = util.ValueComparer.equalValue(shouldElement, 
nextElement);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sw/source

[Libreoffice Gerrit user]

 qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java   |   12 
+-
 qadevOOo/tests/java/mod/_sw/SwAccessibleTextGraphicObject.java |4 +--
 sw/source/uibase/uno/unomod.cxx|2 -
 3 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 6287a4f0d18df7f195d1f14b7c24536317463a23
Author: Stephan Bergmann 
AuthorDate: Tue Feb 5 20:40:54 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Feb 7 09:21:50 2019 +0100

[API CHANGE] Synchronize supported Writer document zoom ranges

On the one hand, SvxZoomSliderItem/SvxZoomSliderControl as used by SwView's
SID_ATTR_ZOOMSLIDER support a range from MINZOOM (20) to MAXZOOM (600) 
(defined
in sw/inc/view.hxx).  Setting a zoom value outside that range for one 
causes the
DBG_ASSERT "Looks like the zoom slider item is corrupted" in
SvxZoomSliderControl::StateChanged (svx/source/stbctrls/zoomsliderctrl.cxx) 
to
fire, and for another (when setting a too small value) tries to assign a
negative value (which wraps around, and gets flagged by Clang's
-fsanitize=implicit-signed-integer-truncation) to sal_uInt16 nCurrentZoom at

  nCurrentZoom = nCurrentZoom - mxImpl->mnMinZoom;

in SvxZoomSliderControl::Zoom2Offset 
(svx/source/stbctrls/zoomsliderctrl.cxx).

On the other hand, SwXViewSettings' support of css.text.ViewSettings' 
ZoomValue
property allowed values in the range from 5 to 1000 (cf.
SwXViewSettings::_setSingleValue in sw/source/uibase/uno/unomod.cxx), and 
some
JunitTests actually set such values (10, 15) below the MINZOOM value of 20.

The incompatible 5--1000 range was there ever since
7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import", but looks rather
random, so change it to match the 20--600 range instead.  (And lets flag 
this as
an [API CHANGE], to be on the safe side.)

One of the JunitTests files that needed to be adapted,
qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java, oddly mentioned a
zoom value of 130% in a comment while using the value 15 in the actual code.
(And did so ever since the test code's introduction in
26ebdfc472be16f0eb4110aab0335666d2ba5e62 "NEW: initial version".)  Changing 
the
code to 130 would cause JunitTest_sw_unoapi_1 to fail in strange ways, with
disposed UNO objects, while changing the code (and comment) to 21 appears to
work.  Go figure.

Change-Id: Id944ffdce501448312e008436e7038bf2aec63ac
Reviewed-on: https://gerrit.libreoffice.org/67427
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
Reviewed-by: Stephan Bergmann 

diff --git a/qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java 
b/qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java
index 15c42c68310d..9d12789ca1e8 100644
--- a/qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java
+++ b/qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java
@@ -83,9 +83,9 @@ public class SwAccessibleEndnoteView extends TestCase {
 xController);
 XPropertySet xPropSet = xViewSetSup.getViewSettings();
 
-//change zoom value to 10%
+//change zoom value to 20%
 //footer should be in the vissible area of the document
-xPropSet.setPropertyValue("ZoomValue", Short.valueOf("10"));
+xPropSet.setPropertyValue("ZoomValue", Short.valueOf("20"));
 
 XModel aModel = UnoRuntime.queryInterface(XModel.class, xTextDoc);
 
@@ -105,10 +105,10 @@ public class SwAccessibleEndnoteView extends TestCase {
 new ifc.accessibility._XAccessibleEventBroadcaster.EventProducer() 
{
 public void fireEvent() {
 try {
-//change zoom value to 130%
-PropSet.setPropertyValue("ZoomValue", 
Short.valueOf("15"));
-//and back to 10%
-PropSet.setPropertyValue("ZoomValue", 
Short.valueOf("10"));
+//change zoom value to 21%
+PropSet.setPropertyValue("ZoomValue", 
Short.valueOf("21"));
+//and back to 20%
+PropSet.setPropertyValue("ZoomValue", 
Short.valueOf("20"));
 } catch ( com.sun.star.lang.WrappedTargetException e ) {
 
 }  catch ( com.sun.star.lang.IllegalArgumentException e ) {
diff --git a/qadevOOo/tests/java/mod/_sw/SwAccessibleTextGraphicObject.java 
b/qadevOOo/tests/java/mod/_sw/SwAccessibleTextGraphicObject.java
index 0292396eaa80..f3b23fbdf7cc 100644
--- a/qadevOOo/tests/java/mod/_sw/SwAccessibleTextGraphicObject.java
+++ b/qadevOOo/tests/java/mod/_sw/SwAccessibleTextGraphicObject.java
@@ -104,8 +104,8 @@ public class SwAccessibleTextGraphicObject extends TestCase 
{
 new ifc.accessibility._XAccessibleEventBroadcaster.EventProducer() 
{
 public void fireEvent() {
 try {
-  

[Libreoffice-commits] core.git: qadevOOo/tests sc/source

[Libreoffice Gerrit user]

 qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java |   44 +---
 sc/source/core/data/docpool.cxx |2 
 2 files changed, 16 insertions(+), 30 deletions(-)

New commits:
commit d08e63fb1ab16d96e3d1404c4b82267447104a0f
Author: Heiko Tietze 
AuthorDate: Thu Dec 6 17:09:20 2018 +0100
Commit: Heiko Tietze 
CommitDate: Fri Dec 7 08:40:31 2018 +0100

tdf#121759 Revert "tdf#99296 - Disable headers/footers by default"

This reverts commit 08b5048198d59441cb8033ed14cd17e68c943004.

Disabled h/f lead to an inactive menu entry (tdf#121759).
Also, the change was not accepted by the OP (tdf#99296).
See discussion on the mailing list, Gerrit, and BZ.

Change-Id: Ie3dcf14c173a1813da05d8f2a9c8f2eda14cee46
Reviewed-on: https://gerrit.libreoffice.org/64727
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java 
b/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java
index d7ff676f5a0e..74670742c8ae 100644
--- a/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java
+++ b/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java
@@ -106,35 +106,6 @@ public class ScAccessiblePageHeader extends TestCase {
 e.printStackTrace(log);
 }
 
-XStyleFamiliesSupplier StyleFam = UnoRuntime.queryInterface(
-XStyleFamiliesSupplier.class,
-xSpreadsheetDoc );
-XNameAccess StyleFamNames = StyleFam.getStyleFamilies();
-XStyle StdStyle = null;
-
-XNameAccess PageStyles = (XNameAccess) AnyConverter.toObject(
-new Type(XNameAccess.class),
-StyleFamNames.getByName("PageStyles"));
-StdStyle = (XStyle) AnyConverter.toObject(
-new Type(XStyle.class), PageStyles.getByName("Default"));
-
-//get the property-set
-final XPropertySet PropSet = 
UnoRuntime.queryInterface(XPropertySet.class, StdStyle);
-
-// tdf#99296 - Disable headers/footers by default
-try {
-PropSet.setPropertyValue("HeaderIsOn", Boolean.TRUE);
-PropSet.setPropertyValue("FooterIsOn", Boolean.TRUE);
-} catch (com.sun.star.beans.UnknownPropertyException upe) {
-log.println("Don't know the Property 'HeaderIsOn' or 
'FooterIsOn'");
-} catch (com.sun.star.lang.WrappedTargetException wte) {
-log.println("WrappedTargetException while setting Property 
'HeaderIsOn' or 'FooterIsOn'");
-} catch (com.sun.star.lang.IllegalArgumentException iae) {
-log.println("IllegalArgumentException while setting Property 
'HeaderIsOn' or 'FooterIsOn'");
-} catch (com.sun.star.beans.PropertyVetoException pve) {
-log.println("PropertyVetoException while setting Property 
'HeaderIsOn' or 'FooterIsOn'");
-}
-
 XModel aModel = UnoRuntime.queryInterface(XModel.class, 
xSpreadsheetDoc);
 
 XController xController = aModel.getCurrentController();
@@ -180,6 +151,21 @@ public class ScAccessiblePageHeader extends TestCase {
 
 TestEnvironment tEnv = new TestEnvironment(oObj);
 
+XStyleFamiliesSupplier StyleFam = UnoRuntime.queryInterface(
+XStyleFamiliesSupplier.class,
+xSpreadsheetDoc );
+XNameAccess StyleFamNames = StyleFam.getStyleFamilies();
+XStyle StdStyle = null;
+
+XNameAccess PageStyles = (XNameAccess) AnyConverter.toObject(
+new Type(XNameAccess.class),
+StyleFamNames.getByName("PageStyles"));
+StdStyle = (XStyle) AnyConverter.toObject(
+new Type(XStyle.class), PageStyles.getByName("Default"));
+
+//get the property-set
+final XPropertySet PropSet = 
UnoRuntime.queryInterface(XPropertySet.class, StdStyle);
+
 XHeaderFooterContent RPHC = null;
 // creation of testobject here
 // first we write what we are intend to do to log file
diff --git a/sc/source/core/data/docpool.cxx b/sc/source/core/data/docpool.cxx
index 530c79e11d92..0a0819b533e0 100644
--- a/sc/source/core/data/docpool.cxx
+++ b/sc/source/core/data/docpool.cxx
@@ -290,7 +290,7 @@ ScDocumentPool::ScDocumentPool()
 mvPoolDefaults[ ATTR_PAGE_SIZE   - ATTR_STARTINDEX ] = new 
SvxSizeItem( ATTR_PAGE_SIZE );
 mvPoolDefaults[ ATTR_PAGE_HORCENTER  - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_HORCENTER );
 mvPoolDefaults[ ATTR_PAGE_VERCENTER  - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_VERCENTER );
-mvPoolDefaults[ ATTR_PAGE_ON - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_ON, false );
+mvPoolDefaults[ ATTR_PAGE_ON - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_ON, true );
 mvPoolDefaults[ ATTR_PAGE_DYNAMIC- ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_DYNAMIC, true );
 mvPoolDefaults[ ATTR_PAGE_SHARED - ATTR_STARTINDEX ] = new 

[Libreoffice-commits] core.git: qadevOOo/tests sd/qa sw/source

[Libreoffice Gerrit user]

 qadevOOo/tests/java/mod/_dbaccess/ODatasourceBrowser.java |2 +-
 sd/qa/unit/misc-tests.cxx |2 +-
 sw/source/uibase/utlui/navipi.cxx |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 79c4c5dfc1df4b8b80f7d3a6343aa6af9458819d
Author: Andrea Gelmini 
AuthorDate: Thu Sep 13 12:13:27 2018 +0200
Commit: Julien Nabet 
CommitDate: Thu Sep 13 14:53:04 2018 +0200

Fix typos

Change-Id: I4cea59a00029af5cdbd75ab12476d7b0c08419c0
Reviewed-on: https://gerrit.libreoffice.org/60428
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/mod/_dbaccess/ODatasourceBrowser.java 
b/qadevOOo/tests/java/mod/_dbaccess/ODatasourceBrowser.java
index 21f3e1f44bdd..1f5329dc 100644
--- a/qadevOOo/tests/java/mod/_dbaccess/ODatasourceBrowser.java
+++ b/qadevOOo/tests/java/mod/_dbaccess/ODatasourceBrowser.java
@@ -161,7 +161,7 @@ public class ODatasourceBrowser extends TestCase {
  *  DataSourceBrowser has no view data. 
  *   'XInitialization.args' for
  *  {@link ifc.lang._XInitialization} : the arguments for
- *  tbe initialization
+ *  the initialization
  * 
  *
  * @see com.sun.star.frame.Desktop
diff --git a/sd/qa/unit/misc-tests.cxx b/sd/qa/unit/misc-tests.cxx
index 270a0f527178..a3e717cca5e6 100644
--- a/sd/qa/unit/misc-tests.cxx
+++ b/sd/qa/unit/misc-tests.cxx
@@ -520,7 +520,7 @@ void SdMiscTest::testTdf119392()
 sBase64 = getXPathContent(pXmlDoc, sPathStart + 
"/config:config-item[@config:name='VisibleLayers']");
 CPPUNIT_ASSERT_MESSAGE( "Item VisibleLayers does not exists.", 
!sBase64.isEmpty());
 comphelper::Base64::decode(aDecodedSeq, sBase64);
-CPPUNIT_ASSERT_EQUAL( 0xbF, static_cast(aDecodedSeq[0]) & 
0xff); // & 0xff forces unambigious types for CPPUNIT_ASSERT_EQUAL
+CPPUNIT_ASSERT_EQUAL( 0xbF, static_cast(aDecodedSeq[0]) & 
0xff); // & 0xff forces unambiguous types for CPPUNIT_ASSERT_EQUAL
 
 sBase64 = getXPathContent(pXmlDoc, sPathStart + 
"/config:config-item[@config:name='PrintableLayers']");
 CPPUNIT_ASSERT_MESSAGE( "Item PrintableLayers does not exists.", 
!sBase64.isEmpty());
diff --git a/sw/source/uibase/utlui/navipi.cxx 
b/sw/source/uibase/utlui/navipi.cxx
index e7e79bb5e510..14dae916f7d2 100644
--- a/sw/source/uibase/utlui/navipi.cxx
+++ b/sw/source/uibase/utlui/navipi.cxx
@@ -869,7 +869,7 @@ void SwNavigationPI::StateChanged(StateChangedType 
nStateChange)
 PanelLayout::StateChanged(nStateChange);
 if (nStateChange == StateChangedType::InitShow)
 {
-// if the parent isn't a float, then then the navigator is displayed in
+// if the parent isn't a float, then the navigator is displayed in
 // the sidebar or is otherwise docked. While the navigator could change
 // its size, the sidebar can not, and the navigator would just waste
 // space. Therefore hide this button.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sc/source

[Libreoffice Gerrit user]

 qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java |   44 ++--
 sc/source/core/data/docpool.cxx |2 
 2 files changed, 30 insertions(+), 16 deletions(-)

New commits:
commit 08b5048198d59441cb8033ed14cd17e68c943004
Author: heiko tietze 
AuthorDate: Tue Aug 28 11:09:03 2018 +0200
Commit: Heiko Tietze 
CommitDate: Mon Sep 3 09:05:31 2018 +0200

tdf#99296 - Disable headers/footers by default

Change-Id: I9232c879cebdcb92236322e4d4a12048d9fec00f
Reviewed-on: https://gerrit.libreoffice.org/59696
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java 
b/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java
index 74670742c8ae..d7ff676f5a0e 100644
--- a/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java
+++ b/qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeader.java
@@ -106,6 +106,35 @@ public class ScAccessiblePageHeader extends TestCase {
 e.printStackTrace(log);
 }
 
+XStyleFamiliesSupplier StyleFam = UnoRuntime.queryInterface(
+XStyleFamiliesSupplier.class,
+xSpreadsheetDoc );
+XNameAccess StyleFamNames = StyleFam.getStyleFamilies();
+XStyle StdStyle = null;
+
+XNameAccess PageStyles = (XNameAccess) AnyConverter.toObject(
+new Type(XNameAccess.class),
+StyleFamNames.getByName("PageStyles"));
+StdStyle = (XStyle) AnyConverter.toObject(
+new Type(XStyle.class), PageStyles.getByName("Default"));
+
+//get the property-set
+final XPropertySet PropSet = 
UnoRuntime.queryInterface(XPropertySet.class, StdStyle);
+
+// tdf#99296 - Disable headers/footers by default
+try {
+PropSet.setPropertyValue("HeaderIsOn", Boolean.TRUE);
+PropSet.setPropertyValue("FooterIsOn", Boolean.TRUE);
+} catch (com.sun.star.beans.UnknownPropertyException upe) {
+log.println("Don't know the Property 'HeaderIsOn' or 
'FooterIsOn'");
+} catch (com.sun.star.lang.WrappedTargetException wte) {
+log.println("WrappedTargetException while setting Property 
'HeaderIsOn' or 'FooterIsOn'");
+} catch (com.sun.star.lang.IllegalArgumentException iae) {
+log.println("IllegalArgumentException while setting Property 
'HeaderIsOn' or 'FooterIsOn'");
+} catch (com.sun.star.beans.PropertyVetoException pve) {
+log.println("PropertyVetoException while setting Property 
'HeaderIsOn' or 'FooterIsOn'");
+}
+
 XModel aModel = UnoRuntime.queryInterface(XModel.class, 
xSpreadsheetDoc);
 
 XController xController = aModel.getCurrentController();
@@ -151,21 +180,6 @@ public class ScAccessiblePageHeader extends TestCase {
 
 TestEnvironment tEnv = new TestEnvironment(oObj);
 
-XStyleFamiliesSupplier StyleFam = UnoRuntime.queryInterface(
-XStyleFamiliesSupplier.class,
-xSpreadsheetDoc );
-XNameAccess StyleFamNames = StyleFam.getStyleFamilies();
-XStyle StdStyle = null;
-
-XNameAccess PageStyles = (XNameAccess) AnyConverter.toObject(
-new Type(XNameAccess.class),
-StyleFamNames.getByName("PageStyles"));
-StdStyle = (XStyle) AnyConverter.toObject(
-new Type(XStyle.class), PageStyles.getByName("Default"));
-
-//get the property-set
-final XPropertySet PropSet = 
UnoRuntime.queryInterface(XPropertySet.class, StdStyle);
-
 XHeaderFooterContent RPHC = null;
 // creation of testobject here
 // first we write what we are intend to do to log file
diff --git a/sc/source/core/data/docpool.cxx b/sc/source/core/data/docpool.cxx
index f117d783c35a..f199e49a26e2 100644
--- a/sc/source/core/data/docpool.cxx
+++ b/sc/source/core/data/docpool.cxx
@@ -293,7 +293,7 @@ ScDocumentPool::ScDocumentPool()
 mvPoolDefaults[ ATTR_PAGE_SIZE   - ATTR_STARTINDEX ] = new 
SvxSizeItem( ATTR_PAGE_SIZE );
 mvPoolDefaults[ ATTR_PAGE_HORCENTER  - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_HORCENTER );
 mvPoolDefaults[ ATTR_PAGE_VERCENTER  - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_VERCENTER );
-mvPoolDefaults[ ATTR_PAGE_ON - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_ON, true );
+mvPoolDefaults[ ATTR_PAGE_ON - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_ON, false );
 mvPoolDefaults[ ATTR_PAGE_DYNAMIC- ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_DYNAMIC, true );
 mvPoolDefaults[ ATTR_PAGE_SHARED - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_SHARED, true );
 mvPoolDefaults[ ATTR_PAGE_NOTES  - ATTR_STARTINDEX ] = new 
SfxBoolItem( ATTR_PAGE_NOTES, false );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-commits] core.git: qadevOOo/tests

[Libreoffice Gerrit user]

 qadevOOo/tests/java/mod/_sw/CharacterStyle.java|4 ++--
 qadevOOo/tests/java/mod/_sw/ConditionalParagraphStyle.java |6 +++---
 qadevOOo/tests/java/mod/_sw/PageStyle.java |6 +++---
 qadevOOo/tests/java/mod/_sw/ParagraphStyle.java|4 ++--
 4 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 94acf17472c9a1560b5a745fcbed3a9e9506ac53
Author: Julien Nabet 
AuthorDate: Thu Aug 30 19:35:14 2018 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 31 07:17:17 2018 +0200

Typo: skipPropetiesNamed->skipPropertiesNamed

Change-Id: I28810ca142f9b4dcc4bf76305c7fa4e3504adf3b
Reviewed-on: https://gerrit.libreoffice.org/59837
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/mod/_sw/CharacterStyle.java 
b/qadevOOo/tests/java/mod/_sw/CharacterStyle.java
index 1671a39b99ed..8f7c3b18169b 100644
--- a/qadevOOo/tests/java/mod/_sw/CharacterStyle.java
+++ b/qadevOOo/tests/java/mod/_sw/CharacterStyle.java
@@ -137,10 +137,10 @@ public class CharacterStyle extends TestCase {
 
 XPropertySet xStyleProp = 
UnoRuntime.queryInterface(XPropertySet.class, oMyStyle);
 
-String[] skipPropetiesNamed = {};
+String[] skipPropertiesNamed = {};
 
 short exclude = PropertyAttribute.READONLY;
-
tEnv.addObjRelation("PropertyNames",utils.getFilteredPropertyNames(xStyleProp, 
(short)0, exclude, skipPropetiesNamed));
+
tEnv.addObjRelation("PropertyNames",utils.getFilteredPropertyNames(xStyleProp, 
(short)0, exclude, skipPropertiesNamed));
 
 return tEnv;
 }
diff --git a/qadevOOo/tests/java/mod/_sw/ConditionalParagraphStyle.java 
b/qadevOOo/tests/java/mod/_sw/ConditionalParagraphStyle.java
index 0ccff31ed554..fbcc9e2b0f64 100644
--- a/qadevOOo/tests/java/mod/_sw/ConditionalParagraphStyle.java
+++ b/qadevOOo/tests/java/mod/_sw/ConditionalParagraphStyle.java
@@ -129,12 +129,12 @@ public class ConditionalParagraphStyle extends TestCase {
 
 XPropertySet xStyleProp = 
UnoRuntime.queryInterface(XPropertySet.class, oMyStyle);
 short exclude = PropertyAttribute.READONLY;
-String[] skipPropetiesNamed = { "ParaBackGraphicURL" };
+String[] skipPropertiesNamed = { "ParaBackGraphicURL" };
 
-String[] names = utils.getFilteredPropertyNames(xStyleProp, (short)0, 
exclude, skipPropetiesNamed);
+String[] names = utils.getFilteredPropertyNames(xStyleProp, (short)0, 
exclude, skipPropertiesNamed);
 
 tEnv.addObjRelation("PropertyNames", names);
-tEnv.addObjRelation("SkipProperties", skipPropetiesNamed);
+tEnv.addObjRelation("SkipProperties", skipPropertiesNamed);
 
 return tEnv;
 }
diff --git a/qadevOOo/tests/java/mod/_sw/PageStyle.java 
b/qadevOOo/tests/java/mod/_sw/PageStyle.java
index fdfac78b1dee..7de28b2019a7 100644
--- a/qadevOOo/tests/java/mod/_sw/PageStyle.java
+++ b/qadevOOo/tests/java/mod/_sw/PageStyle.java
@@ -127,13 +127,13 @@ public class PageStyle extends TestCase {
 
 short exclude = PropertyAttribute.READONLY;
 
-String[] skipPropetiesNamed = {
+String[] skipPropertiesNamed = {
 "BackGraphicURL", "HeaderBackGraphicURL", "FooterBackGraphicURL"
 };
 
-String[] names = utils.getFilteredPropertyNames(xStyleProp, (short)0, 
exclude, skipPropetiesNamed);
+String[] names = utils.getFilteredPropertyNames(xStyleProp, (short)0, 
exclude, skipPropertiesNamed);
 tEnv.addObjRelation("PropertyNames", names);
-tEnv.addObjRelation("SkipProperties", skipPropetiesNamed);
+tEnv.addObjRelation("SkipProperties", skipPropertiesNamed);
 
 return tEnv;
 }
diff --git a/qadevOOo/tests/java/mod/_sw/ParagraphStyle.java 
b/qadevOOo/tests/java/mod/_sw/ParagraphStyle.java
index e52daed43c02..b85a83ab32a2 100644
--- a/qadevOOo/tests/java/mod/_sw/ParagraphStyle.java
+++ b/qadevOOo/tests/java/mod/_sw/ParagraphStyle.java
@@ -120,9 +120,9 @@ public class ParagraphStyle extends TestCase  {
 XPropertySet xStyleProp = 
UnoRuntime.queryInterface(XPropertySet.class, oMyStyle);
 short exclude = PropertyAttribute.READONLY;
 
-String[] skipPropetiesNamed = { "ParaBackGraphicURL" };
+String[] skipPropertiesNamed = { "ParaBackGraphicURL" };
 
-String[] names = utils.getFilteredPropertyNames(xStyleProp, (short)0, 
exclude, skipPropetiesNamed);
+String[] names = utils.getFilteredPropertyNames(xStyleProp, (short)0, 
exclude, skipPropertiesNamed);
 tEnv.addObjRelation("PropertyNames", names);
 
 return tEnv;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Jens Carl]

 qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bd2705650d3af810c7bd9680d0627b44c3a6510f
Author: Jens Carl 
Date:   Fri Jun 29 06:02:57 2018 +

tdf#39468 Translate German term

Change-Id: Id2ac80d1e66b2a4dacf40e51f33ced05fec2c223
Reviewed-on: https://gerrit.libreoffice.org/56656
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster.java 
b/qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster.java
index 6dec94584ecd..fbed0d1f9307 100644
--- a/qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster.java
+++ b/qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster.java
@@ -99,7 +99,7 @@ public class _XEnhancedMouseClickBroadcaster extends 
MultiMethodTest {
 System.out.println("Release Button");
 rob.mouseRelease(InputEvent.BUTTON3_MASK);
 System.out.println("done");
-System.out.println("warte");
+System.out.println("wait");
 waitForEventIdle();
 System.out.println("Press Button");
 rob.mousePress(InputEvent.BUTTON1_MASK);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/chart/_ChartDataPointProperties.java |8 
 1 file changed, 8 deletions(-)

New commits:
commit 3988bd9dc8339aa32f1721df6b256def5e94f786
Author: Caolán McNamara 
Date:   Sun May 6 14:49:59 2018 +0100

coverity#1435440 UrF: Unread field

Change-Id: Ia8aa697261f92779077b1f91eeedfa1d7edcb327
Reviewed-on: https://gerrit.libreoffice.org/53914
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/chart/_ChartDataPointProperties.java 
b/qadevOOo/tests/java/ifc/chart/_ChartDataPointProperties.java
index c78d87951750..e7872378c746 100644
--- a/qadevOOo/tests/java/ifc/chart/_ChartDataPointProperties.java
+++ b/qadevOOo/tests/java/ifc/chart/_ChartDataPointProperties.java
@@ -68,14 +68,6 @@ public class _ChartDataPointProperties extends 
MultiPropertyTest {
 doc.setDiagram(Line);
 }
 
-protected PropertyTester URLTester = new PropertyTester() {
-@Override
-protected Object getNewValue(String propName, Object oldValue)
-throws java.lang.IllegalArgumentException {
-return utils.getFullTestURL("space-metal.jpg");
-}
-};
-
 /**
 * Tests property 'SymbolBitmapURL' using file polibal.gif.
 */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/chart/_LineDiagram.java |   10 --
 1 file changed, 10 deletions(-)

New commits:
commit ace53eb17c6e2a2e614bb2ff5d99fa5ccfe79358
Author: Caolán McNamara 
Date:   Sun May 6 14:46:45 2018 +0100

coverity#1435436 UrF: Unread field

Change-Id: Ic119dc27d5d0e54a1af5e5acebb13e7fbc85b1f7
Reviewed-on: https://gerrit.libreoffice.org/53913
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/chart/_LineDiagram.java 
b/qadevOOo/tests/java/ifc/chart/_LineDiagram.java
index aaade8f9bc29..ef48ee877b82 100644
--- a/qadevOOo/tests/java/ifc/chart/_LineDiagram.java
+++ b/qadevOOo/tests/java/ifc/chart/_LineDiagram.java
@@ -86,16 +86,6 @@ public class _LineDiagram extends MultiPropertyTest {
 doc.setDiagram(oldDiagram);
 }
 
-protected PropertyTester URLTester = new PropertyTester() {
-@Override
-protected Object getNewValue(String propName, Object oldValue)
-throws java.lang.IllegalArgumentException {
-if (oldValue.equals(util.utils.getFullTestURL("space-metal.jpg")))
-return util.utils.getFullTestURL("crazy-blue.jpg"); else
-return util.utils.getFullTestURL("space-metal.jpg");
-}
-} ;
-
 protected PropertyTester SymbolTester = new PropertyTester() {
 @Override
 protected Object getNewValue(String propName, Object oldValue)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests scripting/source vcl/source

[Andrea Gelmini]

 qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java |4 ++--
 scripting/source/pyprov/pythonscript.py  |4 ++--
 vcl/source/window/toolbox.cxx|2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit d633e80334b2472e7d99e253b761acd9b72f290b
Author: Andrea Gelmini 
Date:   Fri Apr 27 15:14:18 2018 +0200

Fix typos

Change-Id: Id7d66c06e18dbccd5c85ba36143bdb6cee7a5197
Reviewed-on: https://gerrit.libreoffice.org/53564
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java 
b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
index 6ddee8e5e62d..ff422b059896 100644
--- a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
+++ b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
@@ -183,7 +183,7 @@ public class _XSingleSelectQueryAnalyzer extends 
MultiMethodTest {
 }
 
 /**
-* Method getGroupColumns retunrs a XIndexAccess
+* Method getGroupColumns returns a XIndexAccess
 * Test has ok status if returned value is an usable 
XIndexAccess
 */
 public void _getGroupColumns() {
@@ -267,7 +267,7 @@ public class _XSingleSelectQueryAnalyzer extends 
MultiMethodTest {
 }
 
 /**
-* Method getGroupColumns retunrs a XIndexAccess
+* Method getGroupColumns returns a XIndexAccess
 * Test has ok status if returned value is an usable 
XIndexAccess
 */
 public void _getOrderColumns() {
diff --git a/scripting/source/pyprov/pythonscript.py 
b/scripting/source/pyprov/pythonscript.py
index b1ef0aa7e324..722dc24b9b07 100644
--- a/scripting/source/pyprov/pythonscript.py
+++ b/scripting/source/pyprov/pythonscript.py
@@ -984,7 +984,7 @@ class PythonScriptProvider( unohelper.Base, XBrowseNode, 
XScriptProvider, XNameC
 def getType( self ):
 return self.dirBrowseNode.getType()
 
-# retreive function args in parenthesis
+# retrieve function args in parenthesis
 def getFunctionArguments(self, func_signature):
 nOpenParenthesis = func_signature.find( "(" )
 if -1 == nOpenParenthesis:
@@ -1013,7 +1013,7 @@ class PythonScriptProvider( unohelper.Base, XBrowseNode, 
XScriptProvider, XNameC
 fileUri = storageUri[0:storageUri.find( "$" )]
 funcName = storageUri[storageUri.find( "$" )+1:len(storageUri)]
 
-# retreive arguments in parenthesis
+# retrieve arguments in parenthesis
 funcName, funcArgs = self.getFunctionArguments(funcName)
 log.debug( " getScript : parsed funcname " + str(funcName) )
 log.debug( " getScript : func args " + str(funcArgs) )
diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index 9ff745b27dcb..974f56f837b6 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -4877,7 +4877,7 @@ static bool ImplIsValidItem( const ImplToolItem* pItem, 
bool bNotClipped )
 
 bool ToolBox::ChangeHighlightUpDn( bool bUp )
 {
-return ImplChangeHighlightUpDn(bUp, /*bNoCyle*/ false);
+return ImplChangeHighlightUpDn(bUp, /*bNoCycle*/ false);
 }
 
 bool ToolBox::ImplChangeHighlightUpDn( bool bUp, bool bNoCycle )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini]

 qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 90a46122dc0ce401919914cb79f11081d6cc6b24
Author: Andrea Gelmini 
Date:   Sat Feb 10 10:29:32 2018 +0100

Fix typos

Change-Id: Id61c75a4d3df173e21a264e0997a9076141b772e
Reviewed-on: https://gerrit.libreoffice.org/49587
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java 
b/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java
index 1645b28bc34d..642444e2c98e 100644
--- a/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java
+++ b/qadevOOo/tests/java/ifc/linguistic2/_XSpellChecker.java
@@ -50,7 +50,7 @@ public class _XSpellChecker extends MultiMethodTest {
 
 /**
 * Test calls the method for a correctly spelled word and
-* for a uncorrectly spelled word and checks returned values. 
+* for a incorrectly spelled word and checks returned values. 
 * Has  OK  status if returned value is equal to true in first case,
 * if returned value is equal to false in second case and no exceptions
 * were thrown. 
@@ -75,7 +75,7 @@ public class _XSpellChecker extends MultiMethodTest {
 }
 
 /**
-* Test calls the method for a uncorrectly spelled word
+* Test calls the method for a incorrectly spelled word
 * and checks returned values. 
 * Has  OK  status if at least one spell alternative exists
 * and no exceptions were thrown. 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Julien Nabet]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit b70c2e2a4c9e42b6d7fd891e6bcef1a6510d4f63
Author: Julien Nabet 
Date:   Sat Jan 13 22:56:55 2018 +0100

Typo: Unexepected->Unexpected

Change-Id: Id87b14e8cca80c7cc03ff9977fac3effc6f61a52
Reviewed-on: https://gerrit.libreoffice.org/47847
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
index 9150a3ac0a39..d83b231ebe66 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
@@ -67,7 +67,7 @@ public class _XAccessibleAction extends lib.MultiMethodTest {
 log.println("Did action: "+act);
 res &= act ;
 } catch (com.sun.star.lang.IndexOutOfBoundsException ioe) {
-log.println("Unexepected exception -- FAILED");
+log.println("Unexpected exception -- FAILED");
 res &= false;
 }
 
@@ -102,7 +102,7 @@ public class _XAccessibleAction extends lib.MultiMethodTest 
{
 log.println("Found action: "+desc);
 res &= desc!=null ;
 } catch (com.sun.star.lang.IndexOutOfBoundsException ioe) {
-log.println("Unexepected exception -- FAILED");
+log.println("Unexpected exception -- FAILED");
 res &= false;
 }
 }
@@ -140,7 +140,7 @@ public class _XAccessibleAction extends lib.MultiMethodTest 
{
 }
 res &= true;
 } catch (com.sun.star.lang.IndexOutOfBoundsException ioe) {
-log.println("Unexepected exception -- FAILED");
+log.println("Unexpected exception -- FAILED");
 res &= false;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini]

 qadevOOo/tests/java/ifc/container/_XIndexContainer.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 928e79901dc362fe62c34d0db73357e89bed4a35
Author: Andrea Gelmini 
Date:   Sun Nov 5 17:05:18 2017 +0100

Fix typo

Change-Id: Ic3db50be939b7f64268da912159f325e5f60e061
Reviewed-on: https://gerrit.libreoffice.org/44329
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/container/_XIndexContainer.java 
b/qadevOOo/tests/java/ifc/container/_XIndexContainer.java
index c5823280aa75..9b3a23f97409 100644
--- a/qadevOOo/tests/java/ifc/container/_XIndexContainer.java
+++ b/qadevOOo/tests/java/ifc/container/_XIndexContainer.java
@@ -72,7 +72,7 @@ public class _XIndexContainer extends MultiMethodTest {
 * First tries to insert proper object. Second tries to insert
 * null value. For each test thread different objects are inserted
 * on different indexes. For example for the first started test index
-* is 0 and object is get from relation 'INCTANCE1', and so on. 
+* is 0 and object is get from relation 'INSTANCE1', and so on. 
 * Has OK status if in the first case getByIndex
 * method returns non null value and in the second 
 * IndexOutOfBoundsException was thrown.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sd/source test/source

[Andrea Gelmini]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java |2 +-
 sd/source/ui/inc/DrawViewShell.hxx|4 ++--
 test/source/sheet/xspreadsheets.cxx   |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1dddfbbdce43203284bdf874c2ef5662d9cacb51
Author: Andrea Gelmini 
Date:   Mon Aug 7 17:17:08 2017 +0200

Fix typos

Change-Id: I1ba1886b47f89916be387603d5cb959ddd5f9e84
Reviewed-on: https://gerrit.libreoffice.org/40844
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
index bc0de990ced7..9150a3ac0a39 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
@@ -27,7 +27,7 @@ public class _XAccessibleAction extends lib.MultiMethodTest {
 
 /**
  * calls the method and stores the result in the 
- * variable count. Is OK if no excpetion occurs
+ * variable count. It is OK if no exception occurs
  */
 
 public void _getAccessibleActionCount() {
diff --git a/sd/source/ui/inc/DrawViewShell.hxx 
b/sd/source/ui/inc/DrawViewShell.hxx
index cc71ee554cbf..b4e7ddeb0207 100644
--- a/sd/source/ui/inc/DrawViewShell.hxx
+++ b/sd/source/ui/inc/DrawViewShell.hxx
@@ -327,8 +327,8 @@ public:
 @param nId
 The id is expected to be a number between zero (inclusive) and
 the number of layers as returned by the
-GetTabLayerCount method (exclusive).  Note that
-Invalid values are ignored.  No excpetion is thrown in that case.
+GetTabLayerCount method (exclusive). Note that
+Invalid values are ignored. No exception is thrown in that case.
 */
 void SetActiveTabLayerIndex (int nId);
 
diff --git a/test/source/sheet/xspreadsheets.cxx 
b/test/source/sheet/xspreadsheets.cxx
index 8c59258c1711..17e1a372ce9a 100644
--- a/test/source/sheet/xspreadsheets.cxx
+++ b/test/source/sheet/xspreadsheets.cxx
@@ -37,7 +37,7 @@ void XSpreadsheets::testInsertNewByNameBadName()
 {
 uno::Reference< sheet::XSpreadsheets > xSpreadsheets(init(), 
UNO_QUERY_THROW);
 
-CPPUNIT_ASSERT_THROW_MESSAGE("No excpetion thrown",
+CPPUNIT_ASSERT_THROW_MESSAGE("No exception thrown",
  xSpreadsheets->insertNewByName("$%#/?\\", 0),
  uno::RuntimeException);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java |   60 
++
 1 file changed, 12 insertions(+), 48 deletions(-)

New commits:
commit 737e6c248ae015b7fced059257f2faa9cf4c0703
Author: Caolán McNamara 
Date:   Sat Jul 22 19:45:39 2017 +0100

make JunitTest_svx_unoapi more reliable by checking against current bounds

we've been here before with...

commit a9cf50c24dd10a20e1288828e2a59c193bb582cb
Date:   Mon Sep 30 15:28:02 2013 +0100

junit: make tests robust by compensating for intermittent sizing race.

so lets fetch the bounds fresh when checking its consistency with the
other measurements and placements rather than comparing against its
earlier perhaps now changed value

Change-Id: I24585901fedfd710fee194fab697b445f8633e73
Reviewed-on: https://gerrit.libreoffice.org/40318
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
index f9c0d8b6965a..574b4763bac5 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
@@ -48,7 +48,6 @@ import com.sun.star.uno.UnoRuntime;
 public class _XAccessibleComponent extends MultiMethodTest {
 
 public XAccessibleComponent oObj = null;
-private Rectangle bounds = null;
 private final ArrayList KnownBounds = new 
ArrayList();
 
 
@@ -67,7 +66,7 @@ public class _XAccessibleComponent extends MultiMethodTest {
  * 
  */
 public void _containsPoint() {
-requiredMethod("getBounds()");
+Rectangle bounds = oObj.getBounds();
 
 boolean result = true;
 
@@ -375,7 +374,7 @@ public class _XAccessibleComponent extends MultiMethodTest {
 }
 
 /**
- * Retrieves the component bounds and stores it. 
+ * Retrieves the component bounds and discards it. 
  *
  * Has  OK  status if boundary position (x,y) is not negative
  * and size (Width, Height) is greater than 0.
@@ -383,7 +382,7 @@ public class _XAccessibleComponent extends MultiMethodTest {
 public void _getBounds() {
 boolean result = true;
 
-bounds = oObj.getBounds();
+Rectangle bounds = oObj.getBounds();
 result &= ((bounds != null) && (bounds.X >= 0) && (bounds.Y >= 0) && 
(bounds.Width > 0) && (bounds.Height > 0));
 
 log.println("Bounds = " +
@@ -399,22 +398,14 @@ public class _XAccessibleComponent extends 
MultiMethodTest {
  *
  * Has  OK  status if the location is the same as location
  * of boundary obtained by getBounds() method.
- *
- * The following method tests are to be completed successfully before :
- * 
- *getBounds()  : to have bounds 
- * 
  */
 public void _getLocation() {
-requiredMethod("getBounds()");
-
+Rectangle bounds = oObj.getBounds();
 Point loc = oObj.getLocation();
 boolean result = loc.X == bounds.X && loc.Y == bounds.Y;
-if (!result) {
-log.println(
-"loc.X=" + loc.X + " vs. bounds.X=" + bounds.X + ", loc.Y="
-+ loc.Y + " vs. bounds.Y=" + bounds.Y);
-}
+log.println(
+"loc.X=" + loc.X + " vs. bounds.X=" + bounds.X + ", loc.Y="
++ loc.Y + " vs. bounds.Y=" + bounds.Y);
 tRes.tested("getLocation()", result);
 }
 
@@ -425,19 +416,12 @@ public class _XAccessibleComponent extends 
MultiMethodTest {
  * Has  OK  status if component screen location equals
  * to screen location of its parent plus location of the component
  * relative to the parent. 
- *
- * The following method tests are to be completed successfully before :
- * 
- *getBounds()  : to have location of the component
- *  relative to its parent
- * 
  */
 public void _getLocationOnScreen() {
-requiredMethod("getBounds()");
-
 XAccessibleComponent parent = getParentComponent();
 
 boolean result = true;
+Rectangle bounds = oObj.getBounds();
 Point loc = oObj.getLocationOnScreen();
 log.println("Location is (" + loc.X + "," + loc.Y + ")");
 
@@ -457,36 +441,16 @@ public class _XAccessibleComponent extends 
MultiMethodTest {
  * Obtains the size of the component. 
  *
  * Has  OK  status if the size is the same as in bounds. 
- *
- * The following method tests are to be completed successfully before :
- * 
- *getBounds()   
- * 
  */
 public void _getSize() {
 requiredMethod("getBounds()");
 
-boolean result = false;
+boolean result = true;
+Rectangle bounds = oObj.getBounds();
 Size size = oObj.getSize();
 
-for (int i = 0; i < 2 && !result; i++)
-{
-

[Libreoffice-commits] core.git: qadevOOo/tests

[Jens Carl]

 qadevOOo/tests/java/ifc/sheet/_XCellAddressable.java |   50 ---
 1 file changed, 50 deletions(-)

New commits:
commit 01a51eb77ce97c79b897f842051c6704dada0494
Author: Jens Carl 
Date:   Wed Jul 5 04:14:59 2017 +

tdf#45904 Move Java XCellAddressable test to C++

Remove now obsolete file _XCellAddressable.java

Change-Id: I8a1c979c447d81e489114a0c1a947b2458ae31a0
Reviewed-on: https://gerrit.libreoffice.org/39546
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/qadevOOo/tests/java/ifc/sheet/_XCellAddressable.java 
b/qadevOOo/tests/java/ifc/sheet/_XCellAddressable.java
deleted file mode 100644
index 2933f57fbb6d..
--- a/qadevOOo/tests/java/ifc/sheet/_XCellAddressable.java
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package ifc.sheet;
-
-import lib.MultiMethodTest;
-
-import com.sun.star.sheet.XCellAddressable;
-import com.sun.star.table.CellAddress;
-
-/**
-* Testing com.sun.star.sheet.XCellAddressable
-* interface methods :
-* 
-*   getCellAddress()
-*  
-* @see com.sun.star.sheet.XCellAddressable
-*/
-public class _XCellAddressable extends MultiMethodTest {
-
-public XCellAddressable oObj = null;
-   CellAddress sAddr = null;
-
-/**
- * Test calls the method and checks returned value.
- * Has  OK  status if returned value isn't null. 
- */
-public void _getCellAddress(){
-sAddr = oObj.getCellAddress() ;
-tRes.tested("getCellAddress()", sAddr != null) ;
-}
-
-
-} //EOC _XCellAddressable
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[dennisroczek]

 qadevOOo/tests/java/ifc/beans/_XPropertyAccess.java |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 809d136e741891488409df670384e2663006b020
Author: dennisroczek 
Date:   Fri Mar 10 18:51:36 2017 +

fix typo: exptected --> expected

Change-Id: Ibefaed54c8fdce22fbae0116b4df5db4023ef7d6
Reviewed-on: https://gerrit.libreoffice.org/35057
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/qadevOOo/tests/java/ifc/beans/_XPropertyAccess.java 
b/qadevOOo/tests/java/ifc/beans/_XPropertyAccess.java
index a2faae3..10c2600 100644
--- a/qadevOOo/tests/java/ifc/beans/_XPropertyAccess.java
+++ b/qadevOOo/tests/java/ifc/beans/_XPropertyAccess.java
@@ -150,20 +150,20 @@ public class _XPropertyAccess extends MultiMethodTest {
 newProps[0] = failedProp;
 oObj.setPropertyValues(newProps);
 } catch (PropertyVetoException ex) {
-log.println("ERROR: unexptected exception was thrown while trying 
to set null value: " +
+log.println("ERROR: unexpected exception was thrown while trying 
to set null value: " +
 ex.toString());
 exp = true;
 } catch (WrappedTargetException ex) {
-log.println("ERROR: unexptected exception was thrown while trying 
to set null value: " +
+log.println("ERROR: unexpected exception was thrown while trying 
to set null value: " +
 ex.toString());
 exp = true;
 } catch (com.sun.star.lang.IllegalArgumentException ex) {
-log.println("OK: exptected exception was thrown while trying to 
set null value: " +
+log.println("OK: expected exception was thrown while trying to set 
null value: " +
 ex.toString());
 test = true;
 exp = true;
 } catch (UnknownPropertyException ex) {
-log.println("ERROR: unexptected exception was thrown while trying 
to set null value: " +
+log.println("ERROR: unexpected exception was thrown while trying 
to set null value: " +
 ex.toString());
 exp = true;
 }
@@ -191,19 +191,19 @@ public class _XPropertyAccess extends MultiMethodTest {
 oObj.setPropertyValues(newProps);
 
 } catch (WrappedTargetException ex) {
-log.println("ERROR: unexptected exception was thrown while trying 
to set invalid value: " +
+log.println("ERROR: unexpected exception was thrown while trying 
to set invalid value: " +
 ex.toString());
 exp = true;
 } catch (com.sun.star.lang.IllegalArgumentException ex) {
-log.println("ERROR: unexptected exception was thrown while trying 
to set invalid value: " +
+log.println("ERROR: unexpected exception was thrown while trying 
to set invalid value: " +
 ex.toString());
 exp = true;
 } catch (PropertyVetoException ex) {
-log.println("ERROR: unexptected exception was thrown while trying 
to set invalid value: " +
+log.println("ERROR: unexpected exception was thrown while trying 
to set invalid value: " +
 ex.toString());
 exp = true;
 } catch (UnknownPropertyException ex) {
-log.println("OK: Exptected exception was thrown while trying to 
set invalid value: " +
+log.println("OK: Expected exception was thrown while trying to set 
invalid value: " +
 ex.toString());
 exp = true;
 test = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java |   28 ++---
 qadevOOo/tests/java/ifc/sheet/_XFunctionDescriptions.java  |   16 ---
 2 files changed, 23 insertions(+), 21 deletions(-)

New commits:
commit efd58e2b7286645db66e22abe1cd234a98010bf5
Author: Caolán McNamara 
Date:   Sat Jan 21 21:25:50 2017 +

coverity#1399435 Unused value

and

coverity#1399438 Unused value
coverity#1399439 Unused value

its all ok as it was, but doesn't hurt to skip the exception test
if the previous test failed anyway

Change-Id: I110ac062d72514c51d415944a2250c3095584531

diff --git a/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java 
b/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java
index 767125c..860eedd 100644
--- a/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java
+++ b/qadevOOo/tests/java/ifc/document/_XDocumentInsertable.java
@@ -161,21 +161,22 @@ public class _XDocumentInsertable extends MultiMethodTest 
{
 result = false ;
 }
 
-try {
-PropertyValue [] szEmptyArgs = new PropertyValue [0];
-String docURL = "file:///c:/ThisIsAnInvaldURL";
-log.println("Inserting document from URL '" + docURL + "'");
-oObj.insertDocumentFromURL(docURL, szEmptyArgs);
-
-result=false;
-
-} catch (IOException ex) {
-log.println("expected exception was thrown -> ok");
-} catch (com.sun.star.lang.IllegalArgumentException ex) {
-log.println("expected exception was thrown -> ok");
+if (result) {
+try {
+PropertyValue [] szEmptyArgs = new PropertyValue [0];
+String docURL = "file:///c:/ThisIsAnInvaldURL";
+log.println("Inserting document from URL '" + docURL + "'");
+oObj.insertDocumentFromURL(docURL, szEmptyArgs);
+
+result=false;
+
+} catch (IOException ex) {
+log.println("expected exception was thrown -> ok");
+} catch (com.sun.star.lang.IllegalArgumentException ex) {
+log.println("expected exception was thrown -> ok");
+}
 }
 
-
 tRes.tested("insertDocumentFromURL()", result);
 }
 
@@ -187,4 +188,3 @@ public class _XDocumentInsertable extends MultiMethodTest {
 disposeEnvironment();
 }
 }  // finish class _XDocumentInsertable
-
diff --git a/qadevOOo/tests/java/ifc/sheet/_XFunctionDescriptions.java 
b/qadevOOo/tests/java/ifc/sheet/_XFunctionDescriptions.java
index 27c320c..20c4240 100644
--- a/qadevOOo/tests/java/ifc/sheet/_XFunctionDescriptions.java
+++ b/qadevOOo/tests/java/ifc/sheet/_XFunctionDescriptions.java
@@ -106,13 +106,15 @@ public class _XFunctionDescriptions extends 
MultiMethodTest {
 
 log.println("OK.");
 
-try {
-log.println("Now trying to get description with wrong id ... ");
-oObj.getById(-1);
-bResult = false;
-log.println("Exception expected! - FAILED");
-} catch (com.sun.star.lang.IllegalArgumentException e) {
-log.println("Expected exception " + e + " - OK!");
+if (bResult) {
+try {
+log.println("Now trying to get description with wrong id ... 
");
+oObj.getById(-1);
+bResult = false;
+log.println("Exception expected! - FAILED");
+} catch (com.sun.star.lang.IllegalArgumentException e) {
+log.println("Expected exception " + e + " - OK!");
+}
 }
 
 tRes.tested("getById()", bResult);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sw/source

[Stephan Bergmann]

 qadevOOo/tests/java/mod/_sw/SwXAutoTextEntry.java |6 ++
 sw/source/uibase/inc/unoatxt.hxx  |7 ++-
 sw/source/uibase/uno/unoatxt.cxx  |7 +++
 3 files changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 1677faabbf7ae56e233205251b78b77d28937c35
Author: Stephan Bergmann 
Date:   Wed Jan 4 11:58:19 2017 +0100

SwXAutoTextEntry needs a disposal protocol

SwXAutoTextEntry::GetBodyText calls SwGlossaries::EditGroupDoc to create a
Sw[Web]GlosDocShell (which it then stores in xDocSh), and there must be a 
call
to that shell's DoClose to clean up its resources.  However, if a reference 
to
the SwXAutoTextEntry is still held during XDesktop::terminate (as can 
happen in
JunitTest_sw_unoapi_1, where such a reference is held from Java, thus
arbitrarily delaying destruction of the SwXAutoTextEntry until the JVM does 
GC),
SwXAutoTextEntry::Notify's PrepareCloseDoc case will release xDocSh without
calling DoClose, so an eventual ~SwXAutoTextEntry will not call DoClose 
either.
(And calling DoClose from withing SwXAutoTextEntry::Notify would cause a 
crash,
as it would destroy the SwGlosDocShell recursively from within its
SfxBroadcaster::Broadcast call.)

So introduce a disposal protocol for XAutoTextEntry and call it at least in 
the
place that caused the resource leak in JunitTest_sw_unoapi_1.  For lack of a
better inerface, reuse css.lang.XComponent for that protocol, even though 
this
scenario doesn't involve breaking cyclic references among UNO objects 
caused by
listener patterns.

Change-Id: Id6501b84e562950e40b83e0b1afd1b3184807856

diff --git a/qadevOOo/tests/java/mod/_sw/SwXAutoTextEntry.java 
b/qadevOOo/tests/java/mod/_sw/SwXAutoTextEntry.java
index 188307e..30a7ada 100644
--- a/qadevOOo/tests/java/mod/_sw/SwXAutoTextEntry.java
+++ b/qadevOOo/tests/java/mod/_sw/SwXAutoTextEntry.java
@@ -87,11 +87,17 @@ public class SwXAutoTextEntry extends TestCase {
 try {
 if ( oGroup.hasByName("NewEntryName") ) {
 log.println("Removing 'NewEntryName' element");
+((com.sun.star.lang.XComponent) AnyConverter.toObject(
+new Type(com.sun.star.lang.XComponent.class),
+oGroup.getByName("NewEntryName"))).dispose();
 oGroup.removeByName("NewEntryName");
 }
 } catch ( com.sun.star.container.NoSuchElementException e ) {
 log.println("Cannot remove TextEntry from group...");
 e.printStackTrace(log);
+} catch ( com.sun.star.lang.WrappedTargetException e ) {
+log.println("Cannot remove TextEntry from group...");
+e.printStackTrace(log);
 }
 log.println( "disposing xTextDoc " );
 util.DesktopTools.closeDoc(xTextDoc);
diff --git a/sw/source/uibase/inc/unoatxt.hxx b/sw/source/uibase/inc/unoatxt.hxx
index 02e49d0..a991b1d 100644
--- a/sw/source/uibase/inc/unoatxt.hxx
+++ b/sw/source/uibase/inc/unoatxt.hxx
@@ -31,6 +31,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 class SwTextBlocks;
@@ -155,7 +157,8 @@ public:
 
 class SwXAutoTextEntry
 :public SfxListener
-,public cppu::WeakImplHelper
+,public cppu::BaseMutex
+,public cppu::WeakComponentImplHelper
 <
 css::text::XAutoTextEntry,
 css::lang::XServiceInfo,
@@ -178,6 +181,8 @@ class SwXAutoTextEntry
 }
 void GetBodyText ();
 
+void SAL_CALL disposing() override;
+
 protected:
 /** ensure that the current content (which may only be in-memory so far) 
is flushed to the auto text group file
 
diff --git a/sw/source/uibase/uno/unoatxt.cxx b/sw/source/uibase/uno/unoatxt.cxx
index f984a3e..ef41ed8 100644
--- a/sw/source/uibase/uno/unoatxt.cxx
+++ b/sw/source/uibase/uno/unoatxt.cxx
@@ -718,6 +718,7 @@ sal_Int64 SAL_CALL SwXAutoTextEntry::getSomething( const 
uno::Sequence< sal_Int8
 
 SwXAutoTextEntry::SwXAutoTextEntry(SwGlossaries* pGlss, const OUString& 
rGroupName,
 const OUString& rEntryName) :
+WeakComponentImplHelper(m_aMutex),
 pGlossaries(pGlss),
 sGroupName(rGroupName),
 sEntryName(rEntryName),
@@ -801,6 +802,12 @@ void SwXAutoTextEntry::GetBodyText ()
 xBodyText.set( *pBodyText, uno::UNO_QUERY);
 }
 
+void SwXAutoTextEntry::disposing()
+{
+SolarMutexGuard g;
+implFlushDocument(true);
+}
+
 uno::Reference< text::XTextCursor >  SwXAutoTextEntry::createTextCursor() 
throw( uno::RuntimeException, std::exception )
 {
 SolarMutexGuard aGuard;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/mod/_dbaccess/OSQLMessageDialog.java |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 63133848be96df0a22de5b51a9b8d1cb2565c28a
Author: Stephan Bergmann 
Date:   Sat Dec 31 09:59:56 2016 +0100

Dispose XWindow when done

Change-Id: Ia71b4f1c9963ab3aa52f05dd98e9215d69b5402e

diff --git a/qadevOOo/tests/java/mod/_dbaccess/OSQLMessageDialog.java 
b/qadevOOo/tests/java/mod/_dbaccess/OSQLMessageDialog.java
index 0d1d659..2fe0224 100644
--- a/qadevOOo/tests/java/mod/_dbaccess/OSQLMessageDialog.java
+++ b/qadevOOo/tests/java/mod/_dbaccess/OSQLMessageDialog.java
@@ -114,5 +114,14 @@ public class OSQLMessageDialog extends TestCase {
 return tEnv;
 } // finish method getTestEnvironment
 
+@Override public void disposeTestEnvironment(
+TestEnvironment tEnv, TestParameters tParam)
+{
+UnoRuntime.queryInterface(
+com.sun.star.lang.XComponent.class,
+(com.sun.star.awt.XWindow) tEnv.getObjRelation("ERR_XWindow"))
+.dispose();
+super.disposeTestEnvironment(tEnv, tParam);
+}
 } // finish class OSQLMessageDialog
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 7f45ebf7fa209a974032a6c695f194d9a20baaef
Author: Stephan Bergmann 
Date:   Thu Oct 27 11:52:30 2016 +0200

Add link to bug describing such a race

Change-Id: Idd3e325c1240905649e04333fadcde9ac4a4ad0f

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
index a91e1d6d..18d2cf1 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
@@ -478,6 +478,11 @@ public class _XAccessibleComponent extends MultiMethodTest 
{
 log.println( "potential race bounds " + bounds.Width + "x" + 
bounds.Height +
  " vs. size " + size.Width + "x" + size.Height);
 // Possibily we hit a race condition and it re-sized (?) ...
+// One such race is described in
+// 
+// "SvpSalInstance::CheckTimeout -> ScTable::SetRowHeightRange
+// breaks JunitTest_sc_unoapi sc.ScAccessibleCell::com::sun::
+// star::accessibility::XAccessibleComponent::getSize()".
 bounds = oObj.getBounds();
 size = oObj.getSize();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java |   24 
+-
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 97c4f06d097b31e96bd27bb13f1366a02a5c0064
Author: Stephan Bergmann 
Date:   Thu Oct 27 11:51:53 2016 +0200

untabify

Change-Id: I090f63d93166de9bee2527e0e75248916204be5a

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
index 48bd9b2..a91e1d6d 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleComponent.java
@@ -469,18 +469,18 @@ public class _XAccessibleComponent extends 
MultiMethodTest {
 boolean result = false;
 Size size = oObj.getSize();
 
-   for (int i = 0; i < 2 && !result; i++)
-   {
-   result = true;
-   result &= (size.Width == bounds.Width);
-   result &= (size.Height == bounds.Height);
-   if (!result) {
-   log.println( "potential race bounds " + bounds.Width + "x" + 
bounds.Height +
-" vs. size " + size.Width + "x" + size.Height);
-   // Possibily we hit a race condition and it re-sized (?) ...
-   bounds = oObj.getBounds();
-   size = oObj.getSize();
-   }
+for (int i = 0; i < 2 && !result; i++)
+{
+result = true;
+result &= (size.Width == bounds.Width);
+result &= (size.Height == bounds.Height);
+if (!result) {
+log.println( "potential race bounds " + bounds.Width + "x" + 
bounds.Height +
+ " vs. size " + size.Width + "x" + size.Height);
+// Possibily we hit a race condition and it re-sized (?) ...
+bounds = oObj.getBounds();
+size = oObj.getSize();
+}
 }
 
 tRes.tested("getSize()", result);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Samuel Mehrbrodt]

 qadevOOo/tests/java/mod/_toolkit/AccessiblePopupMenu.java |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleRadioButton.java   |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleScrollBar.java |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleStatusBarItem.java |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleTabControl.java|2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleTabPage.java   |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleToolBox.java   |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleToolBoxItem.java   |2 --
 qadevOOo/tests/java/mod/_toolkit/AccessibleWindow.java|2 --
 9 files changed, 18 deletions(-)

New commits:
commit 949fa9a462d1f5fa59dd845fb93d55c77d8b153f
Author: Samuel Mehrbrodt 
Date:   Fri Sep 23 10:42:46 2016 +0200

qadevOOo: Remove unused imports

Change-Id: I5295ba9af550d14f56f218765d43ce01a8177247
Reviewed-on: https://gerrit.libreoffice.org/29223
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/qadevOOo/tests/java/mod/_toolkit/AccessiblePopupMenu.java 
b/qadevOOo/tests/java/mod/_toolkit/AccessiblePopupMenu.java
index 730ebe9..ed60cb7 100644
--- a/qadevOOo/tests/java/mod/_toolkit/AccessiblePopupMenu.java
+++ b/qadevOOo/tests/java/mod/_toolkit/AccessiblePopupMenu.java
@@ -25,7 +25,6 @@ import com.sun.star.awt.Point;
 import com.sun.star.awt.Rectangle;
 import com.sun.star.awt.XExtendedToolkit;
 import com.sun.star.awt.XWindow;
-import com.sun.star.frame.XDesktop;
 import com.sun.star.frame.XModel;
 import com.sun.star.text.XTextDocument;
 import com.sun.star.uno.UnoRuntime;
@@ -39,7 +38,6 @@ import lib.TestCase;
 import lib.TestEnvironment;
 import lib.TestParameters;
 import util.AccessibilityTools;
-import util.DesktopTools;
 import util.SOfficeFactory;
 
 public class AccessiblePopupMenu extends TestCase {
diff --git a/qadevOOo/tests/java/mod/_toolkit/AccessibleRadioButton.java 
b/qadevOOo/tests/java/mod/_toolkit/AccessibleRadioButton.java
index fd184ab..c0c541e 100644
--- a/qadevOOo/tests/java/mod/_toolkit/AccessibleRadioButton.java
+++ b/qadevOOo/tests/java/mod/_toolkit/AccessibleRadioButton.java
@@ -28,7 +28,6 @@ import com.sun.star.awt.XExtendedToolkit;
 import com.sun.star.awt.XWindow;
 import com.sun.star.beans.PropertyValue;
 import com.sun.star.frame.XController;
-import com.sun.star.frame.XDesktop;
 import com.sun.star.frame.XDispatch;
 import com.sun.star.frame.XDispatchProvider;
 import com.sun.star.frame.XModel;
@@ -44,7 +43,6 @@ import lib.TestCase;
 import lib.TestEnvironment;
 import lib.TestParameters;
 import util.AccessibilityTools;
-import util.DesktopTools;
 import util.SOfficeFactory;
 
 
diff --git a/qadevOOo/tests/java/mod/_toolkit/AccessibleScrollBar.java 
b/qadevOOo/tests/java/mod/_toolkit/AccessibleScrollBar.java
index 210e416..e06c734 100644
--- a/qadevOOo/tests/java/mod/_toolkit/AccessibleScrollBar.java
+++ b/qadevOOo/tests/java/mod/_toolkit/AccessibleScrollBar.java
@@ -21,7 +21,6 @@ import com.sun.star.accessibility.AccessibleRole;
 import com.sun.star.accessibility.XAccessible;
 import com.sun.star.accessibility.XAccessibleAction;
 import com.sun.star.awt.XWindow;
-import com.sun.star.frame.XDesktop;
 import com.sun.star.frame.XModel;
 import com.sun.star.lang.XComponent;
 import com.sun.star.uno.UnoRuntime;
@@ -33,7 +32,6 @@ import lib.TestCase;
 import lib.TestEnvironment;
 import lib.TestParameters;
 import util.AccessibilityTools;
-import util.DesktopTools;
 import util.SOfficeFactory;
 
 
diff --git a/qadevOOo/tests/java/mod/_toolkit/AccessibleStatusBarItem.java 
b/qadevOOo/tests/java/mod/_toolkit/AccessibleStatusBarItem.java
index f20ed26..aa10a8b 100644
--- a/qadevOOo/tests/java/mod/_toolkit/AccessibleStatusBarItem.java
+++ b/qadevOOo/tests/java/mod/_toolkit/AccessibleStatusBarItem.java
@@ -21,7 +21,6 @@ import com.sun.star.accessibility.AccessibleRole;
 import com.sun.star.accessibility.XAccessible;
 import com.sun.star.accessibility.XAccessibleContext;
 import com.sun.star.awt.XWindow;
-import com.sun.star.frame.XDesktop;
 import com.sun.star.frame.XModel;
 import com.sun.star.text.XTextDocument;
 import com.sun.star.uno.UnoRuntime;
@@ -33,7 +32,6 @@ import lib.TestCase;
 import lib.TestEnvironment;
 import lib.TestParameters;
 import util.AccessibilityTools;
-import util.DesktopTools;
 import util.SOfficeFactory;
 
 
diff --git a/qadevOOo/tests/java/mod/_toolkit/AccessibleTabControl.java 
b/qadevOOo/tests/java/mod/_toolkit/AccessibleTabControl.java
index 145d1f2..f73b348 100644
--- a/qadevOOo/tests/java/mod/_toolkit/AccessibleTabControl.java
+++ b/qadevOOo/tests/java/mod/_toolkit/AccessibleTabControl.java
@@ -26,7 +26,6 @@ import com.sun.star.awt.XExtendedToolkit;
 import com.sun.star.awt.XWindow;
 import com.sun.star.beans.PropertyValue;
 import com.sun.star.frame.XController;
-import com.sun.star.frame.XDesktop;
 import 

[Libreoffice-commits] core.git: qadevOOo/tests

[Luke Deller]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleText.java |5 
 qadevOOo/tests/java/mod/_toolkit/AccessibleFixedText.java   |   14 +++-
 2 files changed, 13 insertions(+), 6 deletions(-)

New commits:
commit e28d52387383d5b9b3554f364e885a20f4292d81
Author: Luke Deller 
Date:   Fri Sep 16 23:49:24 2016 +1000

Fix JUnit test case for AccessibleFixedText

This test case was failing on platforms where the default font
does not fit inside the default size of a fixed text control
(hard coded to be 12px high in UnoFixedTextControl's constructor)

 - Adjust the test case to explicitly set the text control's size
   to its preferred size.

 - Re-enable this checking on Mac OS X, where it had been disabled
   in 2013 due to this issue

Change-Id: I469a733f0a2719c60564d61c89bb64ab3ab622ba
Reviewed-on: https://gerrit.libreoffice.org/28961
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleText.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleText.java
index 92082d3..a28592c 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleText.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleText.java
@@ -402,11 +402,6 @@ public class _XAccessibleText extends MultiMethodTest {
 log.println("Component rect: " + bounds.X + ", " +
 bounds.Y + ", " + bounds.Width + ", " +
 bounds.Height);
-//TODO: For some reason that still needs to be 
investigated,
-// the above test keeps failing on Mac OS X:
-if (!System.getProperty("os.name").equals("Mac OS X")) {
-res &= localres;
-}
 }
 }
 } catch (com.sun.star.lang.IndexOutOfBoundsException e) {
diff --git a/qadevOOo/tests/java/mod/_toolkit/AccessibleFixedText.java 
b/qadevOOo/tests/java/mod/_toolkit/AccessibleFixedText.java
index fc2aca6..0fc71d6 100644
--- a/qadevOOo/tests/java/mod/_toolkit/AccessibleFixedText.java
+++ b/qadevOOo/tests/java/mod/_toolkit/AccessibleFixedText.java
@@ -26,6 +26,8 @@ import com.sun.star.awt.XControlContainer;
 import com.sun.star.awt.XControlModel;
 import com.sun.star.awt.XFixedText;
 import com.sun.star.awt.XWindow;
+import com.sun.star.awt.XLayoutConstrains;
+import com.sun.star.awt.Size;
 import com.sun.star.lang.XMultiServiceFactory;
 import com.sun.star.uno.UnoRuntime;
 import com.sun.star.uno.XInterface;
@@ -109,6 +111,16 @@ public class AccessibleFixedText extends TestCase {
  XFixedText.class, txtControl);
 xFT.setText("FxedText");
 
+/* Set the text control to its preferred size, otherwise it
+ * defaults to the size hard coded in its constructor (100 x 12) */
+XLayoutConstrains xLCTxt = UnoRuntime.queryInterface(
+XLayoutConstrains.class, txtControl);
+Size textSize = xLCTxt.getPreferredSize();
+XWindow xWinTxt = UnoRuntime.queryInterface(
+XWindow.class, txtControl);
+xWinTxt.setPosSize(0, 0, textSize.Width, textSize.Height,
+   PosSize.SIZE);
+
 XControlContainer ctrlCont = UnoRuntime.queryInterface(
  XControlContainer.class,
  dlgControl);
@@ -173,4 +185,4 @@ public class AccessibleFixedText extends TestCase {
 log.println("Closing dialog ... ");
 xWinDlg.dispose();
 }
-}
\ No newline at end of file
+}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests testtools/source

[Andrea Gelmini]

 qadevOOo/tests/java/ifc/beans/_XHierarchicalPropertySet.java |4 ++--
 testtools/source/bridgetest/pyuno/core.py|2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 2bdb8da2dc6806bac79ede6875680ca5c7b27044
Author: Andrea Gelmini 
Date:   Sun May 1 00:26:30 2016 +0200

Fix typos in code

Change-Id: I24f7b812fe625f3d91a49fb57701a36a8c68eb36
Reviewed-on: https://gerrit.libreoffice.org/24542
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/qadevOOo/tests/java/ifc/beans/_XHierarchicalPropertySet.java 
b/qadevOOo/tests/java/ifc/beans/_XHierarchicalPropertySet.java
index 16ce506..c7cc8fa 100644
--- a/qadevOOo/tests/java/ifc/beans/_XHierarchicalPropertySet.java
+++ b/qadevOOo/tests/java/ifc/beans/_XHierarchicalPropertySet.java
@@ -62,7 +62,7 @@ public class _XHierarchicalPropertySet extends 
MultiMethodTest {
 } catch (com.sun.star.lang.IllegalArgumentException e) {
 log.println(" is illegal");
 } catch (com.sun.star.lang.WrappedTargetException e) {
-log.println(" throws expeption " + e.getMessage());
+log.println(" throws exception " + e.getMessage());
 }
 }
 
@@ -140,4 +140,4 @@ public class _XHierarchicalPropertySet extends 
MultiMethodTest {
 
 return result;
 }
-}
\ No newline at end of file
+}
diff --git a/testtools/source/bridgetest/pyuno/core.py 
b/testtools/source/bridgetest/pyuno/core.py
index 9ef8c80..b45e10f 100644
--- a/testtools/source/bridgetest/pyuno/core.py
+++ b/testtools/source/bridgetest/pyuno/core.py
@@ -210,7 +210,7 @@ class TestCase( unittest.TestCase):
 raise ioExc( "huhuh" , self.tobj )
   except unoExc , instance:
 wasHere = 1
-self.failUnless( wasHere , "exceptiont test 1" )
+self.failUnless( wasHere , "exception test 1" )
 
   wasHere = 0
   try:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/i18n/_XCalendar.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 513d5c5781ec14f8512432f31290a3d54c8d57df
Author: Stephan Bergmann 
Date:   Mon Feb 1 11:20:38 2016 +0100

Don't silently suppress calling loadDefaultCalendar

Change-Id: I0335f42ca5bc3110a819fb2aee44f571dcf1d61c

diff --git a/qadevOOo/tests/java/ifc/i18n/_XCalendar.java 
b/qadevOOo/tests/java/ifc/i18n/_XCalendar.java
index 129339b..2aaeb92 100644
--- a/qadevOOo/tests/java/ifc/i18n/_XCalendar.java
+++ b/qadevOOo/tests/java/ifc/i18n/_XCalendar.java
@@ -80,11 +80,11 @@ public class _XCalendar extends MultiMethodTest {
 installed_locales = locData.getAllInstalledLocaleNames();
 calendars = new String[installed_locales.length][];
 count = new int[installed_locales.length];
-oObj.loadDefaultCalendar(installed_locales[0]);
 } catch (com.sun.star.uno.Exception e) {
 
 }
 
+oObj.loadDefaultCalendar(installed_locales[0]);
 aOriginalDTime = oObj.getDateTime();
 debug = tParam.getBool("DebugIsActive");
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests xmerge/source

[jan iversen]

 qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
  |2 ++
 
xmerge/source/xmerge/java/org/openoffice/xmerge/util/registry/ConverterInfo.java
 |6 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 4b368564091a0023e1981bd8346716db2474b068
Author: jan iversen 
Date:   Sat Jan 23 18:38:24 2016 +0100

cid#1326176, 1326270, 1326271, 1326272, 1326273, 1326274, 1326275

null pointer used to dereference, add "if"

Change-Id: I37173f252a3b3da44976581ccefd0ed54aa8aa0d
Reviewed-on: https://gerrit.libreoffice.org/21735
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java 
b/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
index 322138d..faa0274 100644
--- a/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
+++ b/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
@@ -110,6 +110,8 @@ public class _XSynchronousFrameLoader extends 
MultiMethodTest {
 URL[] urlS = new URL[1];
 urlS[0] = new URL();
 urlS[0].Complete = url;
+if (xURLTrans == null)
+  throw new IllegalStateException("xURLTrans unexpected null");
 boolean res = xURLTrans.parseStrict(urlS);
 log.println("Parsing URL '" + url + "': " + res);
 descr = new PropertyValue[1] ;
diff --git 
a/xmerge/source/xmerge/java/org/openoffice/xmerge/util/registry/ConverterInfo.java
 
b/xmerge/source/xmerge/java/org/openoffice/xmerge/util/registry/ConverterInfo.java
index b549743..de377ec 100644
--- 
a/xmerge/source/xmerge/java/org/openoffice/xmerge/util/registry/ConverterInfo.java
+++ 
b/xmerge/source/xmerge/java/org/openoffice/xmerge/util/registry/ConverterInfo.java
@@ -153,6 +153,10 @@ public class ConverterInfo {
 String version, String vendor, String impl)
 throws RegistryException {
 
+if (officeMime == null || displayName == null || description == null ||
+version== null || vendor  == null || impl== null)
+  throw new IllegalArgumentException("arguments unexpected null");
+
 if (!isValidOfficeType(officeMime.trim())) {
 RegistryException re = new RegistryException(
 "Invalid office type");
@@ -387,4 +391,4 @@ public class ConverterInfo {
 public String getXsltDeserial() {
 return piXsltDeserial;
 }
-}
\ No newline at end of file
+}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/io/_XOutputStream.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ca27812e67663574cbc8a56b43e482dfaf3debc0
Author: Caolán McNamara 
Date:   Wed Jan 20 16:36:05 2016 +

logic inverted

thanks to noelg for noticing

Change-Id: I0e8bdb1e10bc8341b4f38d93c08ff77ea9aadf9b

diff --git a/qadevOOo/tests/java/ifc/io/_XOutputStream.java 
b/qadevOOo/tests/java/ifc/io/_XOutputStream.java
index c183002..9f619f3 100644
--- a/qadevOOo/tests/java/ifc/io/_XOutputStream.java
+++ b/qadevOOo/tests/java/ifc/io/_XOutputStream.java
@@ -85,7 +85,7 @@ public class _XOutputStream extends MultiMethodTest {
 
 byte[][] readData = new byte[1][data.length];
 XInputStream xInStream = checker.getInStream();
-if (xInStream == null) {
+if (xInStream != null) {
 try {
 xInStream.readBytes(readData, data.length);
 } catch(com.sun.star.io.IOException e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[jan iversen]

 qadevOOo/tests/java/ifc/io/_XDataOutputStream.java |   31 +
 1 file changed, 8 insertions(+), 23 deletions(-)

New commits:
commit b0ef4a1618624dc506075aab789581e270a47654
Author: jan iversen 
Date:   Wed Dec 9 11:10:40 2015 +0100

cid#1326581-8 useless calls.

Rebuild the type check to one set of "or" and a throw

Change-Id: I99bf688bdf60c357be4cc5dcd9b7be2532b6fbdb
Reviewed-on: https://gerrit.libreoffice.org/20491
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java 
b/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java
index 3643c06..3ea1119 100644
--- a/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java
+++ b/qadevOOo/tests/java/ifc/io/_XDataOutputStream.java
@@ -69,29 +69,14 @@ public class _XDataOutputStream extends MultiMethodTest {
 for (int i = 0; i < data.size(); i++) {
 dataElem = data.get(i) ;
 
-if (dataElem instanceof Boolean) {
-((Boolean)dataElem).booleanValue();
-}
-else if (dataElem instanceof Byte) {
-((Byte)dataElem).byteValue();
-}
-else if (dataElem instanceof Character) {
-((Character)dataElem).charValue();
-}
-else if (dataElem instanceof Short) {
-((Short)dataElem).shortValue();
-}
-else if (dataElem instanceof Integer) {
-((Integer)dataElem).intValue();
-}
-else if (dataElem instanceof Long) {
-((Long)dataElem).longValue();
-}
-else if (dataElem instanceof Float) {
-((Float)dataElem).floatValue();
-}
-else if (dataElem instanceof Double) {
-((Double)dataElem).doubleValue();
+if (!(dataElem instanceof Boolean   ||
+  dataElem instanceof Byte) ||
+  dataElem instanceof Character ||
+  dataElem instanceof Short ||
+  dataElem instanceof Integer   ||
+  dataElem instanceof Float ||
+  dataElem instanceof Double)   {
+throw new RuntimeException("Object dataElem type not found.");
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[jan iversen]

 qadevOOo/tests/java/ifc/awt/_XTabController.java |1 -
 1 file changed, 1 deletion(-)

New commits:
commit d118979da4a44691268dbfb1fb01b6ed3954885e
Author: jan iversen 
Date:   Wed Dec 9 11:18:47 2015 +0100

cid#1326589 useless call

Removed function call, the function changes nothing or controls anything

Change-Id: Ia243c31134ee5a32d50140faf8e64f55b30c218f
Reviewed-on: https://gerrit.libreoffice.org/20493
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/qadevOOo/tests/java/ifc/awt/_XTabController.java 
b/qadevOOo/tests/java/ifc/awt/_XTabController.java
index 1271b72..8b64978 100644
--- a/qadevOOo/tests/java/ifc/awt/_XTabController.java
+++ b/qadevOOo/tests/java/ifc/awt/_XTabController.java
@@ -101,7 +101,6 @@ public class _XTabController extends MultiMethodTest {
 public void _getContainer() {
 requiredMethod( "setContainer()");
 oObj.getContainer();
-tEnv.getObjRelation("CONTAINER");
 tRes.tested("getContainer()", Status.skipped(true) );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[jan iversen]

 qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java   |4 ++--
 qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit e1fc599eb764186e5d511ace9785463eebbc7028
Author: jan iversen 
Date:   Fri Nov 6 09:15:51 2015 +0100

cid#1326599, cid#1326598: added throw (status generation)

Status.failed( ... ); is prepended with a throw
added import
and removed the return;

Change-Id: I73bc971e054c8726e45db0d5a37613c871691eab
Reviewed-on: https://gerrit.libreoffice.org/19793
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java 
b/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java
index 2ba5bb6..1f3eb73 100644
--- a/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java
+++ b/qadevOOo/tests/java/ifc/drawing/_XDrawPageExpander.java
@@ -19,6 +19,7 @@
 package ifc.drawing;
 
 import lib.MultiMethodTest;
+import lib.StatusException;
 import lib.Status;
 
 import com.sun.star.drawing.XDrawPage;
@@ -51,8 +52,7 @@ public class _XDrawPageExpander extends MultiMethodTest {
 XDrawPage oDrawPage = (XDrawPage) tEnv.getObjRelation("DrawPage");
 if ( oDrawPage == null ) {
 // SKIPPED.FAILED - the ObjectRelation is not available
-Status.failed( "ObjectRelation('DrawPages') XDrawPages n.a.");
-return;
+throw new StatusException(Status.failed( 
"ObjectRelation('DrawPages') XDrawPages n.a."));
 }
 log.println("testing expand() ... ");
 
diff --git a/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java 
b/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java
index dca8370..b346f93 100644
--- a/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java
+++ b/qadevOOo/tests/java/ifc/drawing/_XDrawPageSummarizer.java
@@ -19,6 +19,7 @@
 package ifc.drawing;
 
 import lib.MultiMethodTest;
+import lib.StatusException;
 import lib.Status;
 
 import com.sun.star.drawing.XDrawPageSummarizer;
@@ -50,8 +51,7 @@ public class _XDrawPageSummarizer extends MultiMethodTest {
 XDrawPages oDrawPages = (XDrawPages) tEnv.getObjRelation("DrawPages");
 if ( oDrawPages == null ) {
 // SKIPPED.FAILED - the ObjectRelation is not available
-Status.failed( "ObjectRelation('DrawPages') XDrawPages n.a." );
-return;
+throw new StatusException(Status.failed( 
"ObjectRelation('DrawPages') XDrawPages n.a." ));
 }
 log.println("testing summarize() ... ");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/table/_XCell.java |   11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 95b3a6c722dd39668ac812d39ee7b4c6a78ac01e
Author: Caolán McNamara 
Date:   Wed Nov 4 15:30:43 2015 +

coverity#1326893 silence FE: Test for floating point equality

Change-Id: I8a0b657942cbe3de559a6b115fad2229490f8985

diff --git a/qadevOOo/tests/java/ifc/table/_XCell.java 
b/qadevOOo/tests/java/ifc/table/_XCell.java
index 00c393e..353e8d6b 100644
--- a/qadevOOo/tests/java/ifc/table/_XCell.java
+++ b/qadevOOo/tests/java/ifc/table/_XCell.java
@@ -143,15 +143,14 @@ public class _XCell extends MultiMethodTest {
 * Has  OK  status if the value set is equal to value get. 
 */
 public void _setValue() {
-boolean result = true;
-double cellValue = 0;
 log.println("setValue() ...");
 
-oObj.setValue(222.333) ;
-cellValue = oObj.getValue() ;
+double inValue = 222.333;
+oObj.setValue(inValue) ;
+double cellValue = oObj.getValue() ;
 
-result &= (cellValue == 222.333);
+boolean result = Double.valueOf(cellValue).equals(inValue);
 tRes.tested("setValue()", result);
-   } // end setValue()
+} // end setValue()
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/frame/_XFramesSupplier.java |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit ad05955de0710a2b76fe6423d37a0a58243f1355
Author: Caolán McNamara 
Date:   Thu Oct 15 14:26:44 2015 +0100

coverity#1326276 Explicit null dereferenced

Change-Id: Iec9b5cbb50385e30d1fe8cda0a24285da5e15506

diff --git a/qadevOOo/tests/java/ifc/frame/_XFramesSupplier.java 
b/qadevOOo/tests/java/ifc/frame/_XFramesSupplier.java
index 64997de..a54718b 100644
--- a/qadevOOo/tests/java/ifc/frame/_XFramesSupplier.java
+++ b/qadevOOo/tests/java/ifc/frame/_XFramesSupplier.java
@@ -149,7 +149,6 @@ public class _XFramesSupplier extends MultiMethodTest {
 * 
 */
 public void _setActiveFrame() {
-boolean result = true ;
 XFrame sFrame = null ;
 
 requiredMethod("getActiveFrame()") ;
@@ -184,9 +183,16 @@ public class _XFramesSupplier extends MultiMethodTest {
 
 oObj.setActiveFrame(sFrame) ;
 XFrame gFrame = oObj.getActiveFrame() ;
-if (!(gFrame == null && sFrame == null
-  || sFrame.equals(gFrame))) {
 
+boolean result;
+if (gFrame == null && sFrame == null)
+result = true;
+else if (gFrame != null && sFrame != null)
+result = sFrame.equals(gFrame);
+else
+result = false;
+
+if (!result) {
 log.println("Active frame set is not equal frame get: FAILED");
 result = false ;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/util/_XCloneable.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9fd1338d6a6e4778ba636f24fb22ba4102f16293
Author: Stephan Bergmann 
Date:   Wed Oct 14 17:05:06 2015 +0200

Make _XCloneable.checkImplementationID return a useful value again

...it happened to return a value that would match one's expectaions until
f1dfc5690a2b1a24e2d2f707a50c34d7df61dc4d "cid#1326854 EC: Comparing 
incompatible
types for equality" fixed the method but failed to also straighten its odd
return value.

Change-Id: I9b98be8c86a176fec37505d4337b708ac9bbf5de

diff --git a/qadevOOo/tests/java/ifc/util/_XCloneable.java 
b/qadevOOo/tests/java/ifc/util/_XCloneable.java
index c37dcca..62de17b 100644
--- a/qadevOOo/tests/java/ifc/util/_XCloneable.java
+++ b/qadevOOo/tests/java/ifc/util/_XCloneable.java
@@ -74,7 +74,7 @@ public class _XCloneable extends MultiMethodTest {
 log.println("ImplementationID equals the clone has the same id as 
the original Object");
 
log.println("");
 }
-return !res;
+return res;
 }
 
 protected String getImplementationName(XInterface ifc) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Andrea Gelmini]

 qadevOOo/tests/java/complex/unoapi/CheckModuleAPI.java|2 +-
 qadevOOo/tests/java/ifc/accessibility/_XAccessibleSelection.java  |4 ++--
 qadevOOo/tests/java/ifc/awt/_XControl.java|6 +++---
 qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java  |2 +-
 qadevOOo/tests/java/ifc/beans/_XMultiPropertySet.java |2 +-
 qadevOOo/tests/java/ifc/connection/_XAcceptor.java|2 +-
 qadevOOo/tests/java/ifc/form/_XChangeBroadcaster.java |2 +-
 qadevOOo/tests/java/ifc/frame/_XDispatchProviderInterception.java |2 +-
 qadevOOo/tests/java/ifc/frame/_XDispatchRecorder.java |2 +-
 qadevOOo/tests/java/ifc/frame/_XModuleManager.java|4 ++--
 qadevOOo/tests/java/ifc/frame/_XNotifyingDispatch.java|2 +-
 qadevOOo/tests/java/ifc/io/_XObjectInputStream.java   |2 +-
 qadevOOo/tests/java/ifc/linguistic2/_XDictionaryList.java |4 ++--
 qadevOOo/tests/java/ifc/reflection/_XProxyFactory.java|4 ++--
 qadevOOo/tests/java/ifc/sheet/_XRangeSelection.java   |2 +-
 15 files changed, 21 insertions(+), 21 deletions(-)

New commits:
commit 6d623c9ebca074df4ad46c6316e901eff71c0502
Author: Andrea Gelmini 
Date:   Wed Sep 30 12:52:38 2015 +0200

Fix typos

Change-Id: Ibe0a436f38da760267d9b33893e3c2e8fef2f1d5
Reviewed-on: https://gerrit.libreoffice.org/18964
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/qadevOOo/tests/java/complex/unoapi/CheckModuleAPI.java 
b/qadevOOo/tests/java/complex/unoapi/CheckModuleAPI.java
index 0d0841c..28e3624 100644
--- a/qadevOOo/tests/java/complex/unoapi/CheckModuleAPI.java
+++ b/qadevOOo/tests/java/complex/unoapi/CheckModuleAPI.java
@@ -357,7 +357,7 @@ public class CheckModuleAPI extends ComplexTestCase
 aModuleHashMap.put("sfx", "sfx2");
 aModuleHashMap.put("sm", "starmath");
 
-// it could the that the parameter looks like "fwk,fwl". This results 
in double "famework,framework".
+// it could be that the parameter looks like "fwk,fwl". This results 
in double "famework,framework".
 // The following loop correct this to only one "framework"
 
 final Set keys = aModuleHashMap.keySet();
diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleSelection.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleSelection.java
index d7e84b7..edbf477 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleSelection.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleSelection.java
@@ -45,7 +45,7 @@ import lib.StatusException;
  * 
  *   'XAccessibleSelection.multiSelection'
  *  (of type Boolean)  optional :
- *   Indicates whether or not mutiply children could be selected.
+ *   Indicates whether or not multiply children could be selected.
  *   If the relation is false then more than 1 child
  *   couldn't be selected. 
  *  
@@ -583,4 +583,4 @@ public class _XAccessibleSelection extends MultiMethodTest {
 
 return res;
 }
-}
\ No newline at end of file
+}
diff --git a/qadevOOo/tests/java/ifc/awt/_XControl.java 
b/qadevOOo/tests/java/ifc/awt/_XControl.java
index 67f4a67..1dd1da4 100644
--- a/qadevOOo/tests/java/ifc/awt/_XControl.java
+++ b/qadevOOo/tests/java/ifc/awt/_XControl.java
@@ -110,12 +110,12 @@ public class _XControl extends MultiMethodTest {
 tRes.tested("createPeer()",true);
 }
 
-/**
-* Test calls the method. Then the object ralation 'WINPEER' is
+/*
+* Test calls the method. Then the object relation 'WINPEER' is
 * obtained, and compared with the peer, gotten from (XControl) oObj
 * variable.
 * Has  OK  status if peer gotten isn't null
-* The following method tests are to be completed successfully before :
+* The following method tests are to be completed successfully before:
 */
 public void _getPeer() {
 requiredMethod("createPeer()");
diff --git a/qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java 
b/qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java
index e06959d..1b91aed 100644
--- a/qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java
+++ b/qadevOOo/tests/java/ifc/awt/_XUserInputInterception.java
@@ -92,7 +92,7 @@ public class _XUserInputInterception extends MultiMethodTest {
 /** indicates if the mouseReleased event was called*/
 private boolean m_keyReleased2 = false;
 
-/** get the object rlation XUserInputInterception.XModel from the
+/** get the object relation XUserInputInterception.XModel from the
  * test environment
  */
 @Override
diff --git a/qadevOOo/tests/java/ifc/beans/_XMultiPropertySet.java 
b/qadevOOo/tests/java/ifc/beans/_XMultiPropertySet.java
index 24c6ab4..6328614 100644
--- a/qadevOOo/tests/java/ifc/beans/_XMultiPropertySet.java
+++ 

[Libreoffice-commits] core.git: qadevOOo/tests registry/inc

[Andrea Gelmini]

 qadevOOo/tests/java/ifc/sheet/_XSheetCellRangeContainer.java  |2 +-
 qadevOOo/tests/java/ifc/sheet/_XSheetFilterableEx.java|4 ++--
 qadevOOo/tests/java/ifc/ucb/_XCommandProcessor.java   |2 +-
 qadevOOo/tests/java/ifc/ucb/_XRemoteContentProviderAcceptor.java  |2 +-
 qadevOOo/tests/java/ifc/ui/dialogs/_XFilePickerControlAccess.java |4 ++--
 qadevOOo/tests/java/ifc/view/_XPrintable.java |2 +-
 qadevOOo/tests/java/mod/_dbaccess/ODatasourceBrowser.java |2 +-
 qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java   |2 +-
 qadevOOo/tests/java/mod/_forms/GenericModelTest.java  |2 +-
 qadevOOo/tests/java/mod/_sc/ScCellCursorObj.java  |2 +-
 qadevOOo/tests/java/mod/_sc/ScHeaderFieldsObj.java|2 +-
 qadevOOo/tests/java/mod/_sc/ScTabViewObj.java |4 ++--
 qadevOOo/tests/java/mod/_sw/XMLStylesExporter.java|4 ++--
 qadevOOo/tests/java/mod/_toolkit/AccessibleCheckBox.java  |4 ++--
 registry/inc/regapi.hxx   |2 +-
 15 files changed, 20 insertions(+), 20 deletions(-)

New commits:
commit 8e4388f6dcd12173a2f354332fdfb758eb612393
Author: Andrea Gelmini 
Date:   Wed Sep 30 12:50:46 2015 +0200

Fix typos

Change-Id: I42c0ab2012553e11f8c1372103488ba1d291d5a9
Reviewed-on: https://gerrit.libreoffice.org/18965
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/qadevOOo/tests/java/ifc/sheet/_XSheetCellRangeContainer.java 
b/qadevOOo/tests/java/ifc/sheet/_XSheetCellRangeContainer.java
index a852daf..ee5fbcc 100644
--- a/qadevOOo/tests/java/ifc/sheet/_XSheetCellRangeContainer.java
+++ b/qadevOOo/tests/java/ifc/sheet/_XSheetCellRangeContainer.java
@@ -165,7 +165,7 @@ public class _XSheetCellRangeContainer extends 
MultiMethodTest {
 }
 
 /**
- * All ranges are remover from contaier.
+ * All ranges are remover from container.
  *
  * Has  OK  status if there are no more ranges in the container.
  */
diff --git a/qadevOOo/tests/java/ifc/sheet/_XSheetFilterableEx.java 
b/qadevOOo/tests/java/ifc/sheet/_XSheetFilterableEx.java
index 7204ca3..84cdd22 100644
--- a/qadevOOo/tests/java/ifc/sheet/_XSheetFilterableEx.java
+++ b/qadevOOo/tests/java/ifc/sheet/_XSheetFilterableEx.java
@@ -27,7 +27,7 @@ import com.sun.star.uno.UnoRuntime;
 
 
 /**
- * Inteface test for XSheetFilterableEx
+ * Interface test for XSheetFilterableEx
  *
  * methods:
  *
@@ -87,4 +87,4 @@ public class _XSheetFilterableEx extends MultiMethodTest {
 
 return res;
 }
-}
\ No newline at end of file
+}
diff --git a/qadevOOo/tests/java/ifc/ucb/_XCommandProcessor.java 
b/qadevOOo/tests/java/ifc/ucb/_XCommandProcessor.java
index 72bc025..a677794 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XCommandProcessor.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XCommandProcessor.java
@@ -100,7 +100,7 @@ public class _XCommandProcessor extends MultiMethodTest {
 
 /**
  * First executes 'geCommandInfo' command and examines returned
- * command info information. Second tries to execute inproper
+ * command info information. Second tries to execute improper
  * command. 
  * Has  OK  status if in the first case returned information
  * contains info about 'getCommandInfo' command and in the second
diff --git a/qadevOOo/tests/java/ifc/ucb/_XRemoteContentProviderAcceptor.java 
b/qadevOOo/tests/java/ifc/ucb/_XRemoteContentProviderAcceptor.java
index abf5b54..2a4d1a2 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XRemoteContentProviderAcceptor.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XRemoteContentProviderAcceptor.java
@@ -71,7 +71,7 @@ public class _XRemoteContentProviderAcceptor extends 
MultiMethodTest {
  *
  * The following method tests are to be completed successfully before :
  * 
- *addRemoteContentProvider()  : rovider must
+ *addRemoteContentProvider()  : provider must
  *  be added first 
  * 
  */
diff --git a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePickerControlAccess.java 
b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePickerControlAccess.java
index 69776de..9a9905f 100644
--- a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePickerControlAccess.java
+++ b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilePickerControlAccess.java
@@ -144,9 +144,9 @@ public class _XFilePickerControlAccess extends 
MultiMethodTest {
 /**
 * Changes the label gotten by getLabel method,
 * set this label and then check if it was properly set. 
-* Has OK status if getLael method returns
+* Has OK status if getLabel method returns
 * the same value which was set. 
-* The following method tests are to be completed successfully before :
+* The following method tests are to be completed successfully before:
 * 
 *

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java |   22 
+++---
 1 file changed, 17 insertions(+), 5 deletions(-)

New commits:
commit 2a583603dec40090289ddb5b4b70d800794cf57b
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Jul 3 16:57:50 2015 +0200

Make test code more robust

Change-Id: If3b58c02b289224938b1dfd8074f9802ea6d2474

diff --git 
a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java
index a5d0740..2971669 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java
@@ -77,7 +77,9 @@ public class _XAccessibleEventBroadcaster extends 
MultiMethodTest {
 if (nev instanceof com.sun.star.accessibility.XAccessible) {
 System.out.println(New: 
+((XAccessible)nev).getAccessibleContext().getAccessibleName());
 }
-notifiedEvent = ev;
+synchronized (this) {
+notifiedEvent = ev;
+}
 }
 
 public void disposing(EventObject ev) {}
@@ -118,7 +120,11 @@ public class _XAccessibleEventBroadcaster extends 
MultiMethodTest {
 
 boolean works = true;
 
-if (list.notifiedEvent == null) {
+AccessibleEventObject ne;
+synchronized (list) {
+ne = list.notifiedEvent;
+}
+if (ne == null) {
 if (!isTransient) {
 log.println(listener wasn't called);
 works = false;
@@ -151,17 +157,23 @@ public class _XAccessibleEventBroadcaster extends 
MultiMethodTest {
 public void _removeEventListener() throws Exception {
 requiredMethod(addEventListener());
 
-list.notifiedEvent = null;
-
 log.println(remove listener);
 oObj.removeAccessibleEventListener(list);
 
+synchronized (list) {
+list.notifiedEvent = null;
+}
+
 log.println(fire event);
 prod.fireEvent() ;
 
 waitForEventIdle();
 
-if (list.notifiedEvent == null) {
+AccessibleEventObject ne;
+synchronized (list) {
+ne = list.notifiedEvent;
+}
+if (ne == null) {
 log.println(listener wasn't called -- OK);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/chart/_ChartAxis.java |   12 
 1 file changed, 12 insertions(+)

New commits:
commit 9cc52266bd1a4d01552675f151ce2da8c5210f84
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Jun 17 16:58:33 2015 +0200

Try make JunitTest_chart2_unoapi sch.ChXChartAxis more robust

...setting a new StepHelp value sometimes did not change the old value at 
all,
for whatever reason.

Change-Id: Id859091679bff96c1a3337bf32da42e7054cc166

diff --git a/qadevOOo/tests/java/ifc/chart/_ChartAxis.java 
b/qadevOOo/tests/java/ifc/chart/_ChartAxis.java
index f63413e..8c8e17c 100644
--- a/qadevOOo/tests/java/ifc/chart/_ChartAxis.java
+++ b/qadevOOo/tests/java/ifc/chart/_ChartAxis.java
@@ -184,5 +184,17 @@ public class _ChartAxis extends MultiPropertyTest {
 
 testProperty(StepMain, StepMainTester);
 }
+
+public void _StepHelp() {
+try {
+oObj.setPropertyValue(AutoStepMain, Boolean.FALSE);
+oObj.setPropertyValue(Logarithmic,Boolean.FALSE);
+oObj.setPropertyValue(StepMain, 100.0);
+oObj.setPropertyValue(StepHelpCount, 10);
+} catch (com.sun.star.uno.Exception e) {
+throw new StatusException(Couldn't set property value, e);
+}
+testProperty(StepHelp);
+}
 }  // finish class _ChartAxis
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Julien Nabet]

 qadevOOo/tests/java/ifc/ui/dialogs/_XFilterGroupManager.java |2 +-
 qadevOOo/tests/java/ifc/ui/dialogs/_XFilterManager.java  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 45aaec8206182c16025cbcb20651ddbdf558b95d
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Mar 1 13:37:40 2015 +0100

Typo: ocured-occured

Change-Id: Ic99caa7fc5189228b95b1f776dbc8c7ee835242e

diff --git a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterGroupManager.java 
b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterGroupManager.java
index 9a2e905..956be36 100644
--- a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterGroupManager.java
+++ b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterGroupManager.java
@@ -33,7 +33,7 @@ public class _XFilterGroupManager extends MultiMethodTest {
 
 /**
 * Appends a new FilterGroup (for extension 'txt'). p
-* Has bOK/b status if no runtime exceptions ocured.
+* Has bOK/b status if no runtime exceptions occured.
 */
 public void _appendFilterGroup() {
 boolean res = true;
diff --git a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterManager.java 
b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterManager.java
index b19db84..aa92f5d 100644
--- a/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterManager.java
+++ b/qadevOOo/tests/java/ifc/ui/dialogs/_XFilterManager.java
@@ -39,7 +39,7 @@ public class _XFilterManager extends MultiMethodTest {
 
 /**
 * Appends a new filter (for extension 'txt'). p
-* Has bOK/b status if no runtime exceptions ocured.
+* Has bOK/b status if no runtime exceptions occured.
 */
 public void _appendFilter() {
 boolean res = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/sheet/_XDocumentAuditing.java |9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 48f704c3e1c08ae6e3eee450bf08712dc4caf460
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Feb 2 16:33:20 2015 +0100

Revert fdo#55997: Work around slight offset causing sc_unoapi failure

This reverts commit ed851f1316d34d1ecd60e75d04ed21b7bffdbf00, the underlying
problem causing JunitTest_sc_unoapi's

 checking: [sc.ScModelObj::com::sun::star::sheet::XDocumentAuditing] is 
iface: [com.sun.star.sheet.XDocumentAuditing] testcode: 
[ifc.sheet._XDocumentAuditing]
 Shape Type: com.sun.star.drawing.LineShape
 LOG Execute: refreshArrows()
 Shape Type: com.sun.star.drawing.LineShape
 Shape Type: com.sun.star.drawing.LineShape
 Method refreshArrows() finished with state OK

to fail appears to be fixed meanwhile.

diff --git a/qadevOOo/tests/java/ifc/sheet/_XDocumentAuditing.java 
b/qadevOOo/tests/java/ifc/sheet/_XDocumentAuditing.java
index f87d381..2d35679 100644
--- a/qadevOOo/tests/java/ifc/sheet/_XDocumentAuditing.java
+++ b/qadevOOo/tests/java/ifc/sheet/_XDocumentAuditing.java
@@ -138,11 +138,6 @@ public class _XDocumentAuditing extends MultiMethodTest {
 dispatch(xModel.getCurrentController().getFrame(), tParam.getMSF(), 
.uno:AutoRefreshArrows, props);
 }
 
-private static boolean maxDelta(int x, int y, int max) {
-assert max = 0;
-return Math.abs(((long) x) - ((long) y)) = max;
-}
-
 public void _refreshArrows() {
 boolean result = true;
 
@@ -161,7 +156,7 @@ public class _XDocumentAuditing extends MultiMethodTest {
 Point p1 = pos;
 
 // points have to be the same: if not we have an auto update
-boolean res = maxDelta(p0.X, p1.X, 1)  maxDelta(p0.Y, p1.Y, 1);
+boolean res = (p0.X == p1.X  p0.Y == p1.Y);
 result = res;
 if (!res)
 log.println(Arrow has been refreshed, but this should have been 
switched off.);
@@ -172,7 +167,7 @@ public class _XDocumentAuditing extends MultiMethodTest {
 Point p2 = pos;
 
 // points have to differ
-res = !(maxDelta(p1.X, p2.X, 1)  maxDelta(p1.Y, p2.Y, 1));
+res = (p1.X != p2.X || p1.Y != p2.Y);
 result = res;
 if (!res)
 log.println(Arrow has not been refreshed.);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/sdbc/_XRowSet.java |   15 ---
 1 file changed, 12 insertions(+), 3 deletions(-)

New commits:
commit e18c3848d1140f94a3d264b60426788596725a05
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Jun 16 10:18:09 2014 +0200

Improve test failure output

Change-Id: Icfb4af890548a2a11d638c59bb0fb54aaa01a2ed

diff --git a/qadevOOo/tests/java/ifc/sdbc/_XRowSet.java 
b/qadevOOo/tests/java/ifc/sdbc/_XRowSet.java
index 0cc5d43..1c77be8 100644
--- a/qadevOOo/tests/java/ifc/sdbc/_XRowSet.java
+++ b/qadevOOo/tests/java/ifc/sdbc/_XRowSet.java
@@ -157,15 +157,24 @@ public class _XRowSet extends MultiMethodTest {
 oObj.removeRowSetListener(listener) ;
 
 checker.moveCursor() ;
-result = !listener.cursorMoved ;
+if (listener.cursorMoved) {
+log.println(cursorMoved is erroneously set);
+result = false;
+}
 listener.reset() ;
 
 checker.changeRow() ;
-result = !listener.rowChanged ;
+if (listener.rowChanged) {
+log.println(rowChanged is erroneously set);
+result = false;
+}
 listener.reset() ;
 
 checker.changeRowSet() ;
-result = !listener.rowSetChanged ;
+if (listener.rowSetChanged) {
+log.println(rowSetChanged is erroneously set);
+result = false;
+}
 
 tRes.tested(removeRowSetListener(), result) ;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests scripting/examples sc/source sd/source

[Julien Nabet]

 qadevOOo/tests/java/ifc/frame/_XFrameLoader.java|4 ++--
 qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java |2 +-
 sc/source/ui/src/scfuncs.src|4 ++--
 scripting/examples/python/Capitalise.py |2 +-
 sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx   |4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 55d3127f6cb146d4064a70f128c058f6c954c923
Author: Julien Nabet serval2...@yahoo.fr
Date:   Wed Feb 12 20:08:03 2014 +0100

Typo: omited/ommitted/ommited - omitted

Change-Id: Icc690b0ae1fc8f7165082774720d265798815faa

diff --git a/qadevOOo/tests/java/ifc/frame/_XFrameLoader.java 
b/qadevOOo/tests/java/ifc/frame/_XFrameLoader.java
index 4e016bf..a6c1d1c 100644
--- a/qadevOOo/tests/java/ifc/frame/_XFrameLoader.java
+++ b/qadevOOo/tests/java/ifc/frame/_XFrameLoader.java
@@ -48,11 +48,11 @@ import com.sun.star.uno.UnoRuntime;
 *  li code'FrameLoader.Frame'/code b(optional)/b
 *  (of type codecom.sun.star.frame.XFrame/code):
 *   a target frame where component to be loaded. If this
-*   relation is ommited then a text document created and its
+*   relation is omitted then a text document created and its
 *   frame is used. /li
 *  li code'FrameLoader.args'/code b(optional)/b
 *   (of type codeObject[]/code):
-*   necessary arguuments for loading  a component. If ommited
+*   necessary arguuments for loading  a component. If omitted
 *   then zero length array is passed as parameter/li
 * ul p
 * Test is b NOT /b multithread compilant. p
diff --git a/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java 
b/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
index 15f4208..7233ce9 100644
--- a/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
+++ b/qadevOOo/tests/java/ifc/frame/_XSynchronousFrameLoader.java
@@ -47,7 +47,7 @@ import com.sun.star.util.XURLTransformer;
  *  li code'FrameLoader.Frame'/code b(optional)/b
  *  (of type codecom.sun.star.frame.XFrame/code):
  *   a target frame where component to be loaded. If this
- *   relation is ommited then a text document created and its
+ *   relation is omitted then a text document created and its
  *   frame is used. /li
  * ul p
  *
diff --git a/sc/source/ui/src/scfuncs.src b/sc/source/ui/src/scfuncs.src
index 53f29ce..e57b618 100644
--- a/sc/source/ui/src/scfuncs.src
+++ b/sc/source/ui/src/scfuncs.src
@@ -5948,7 +5948,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS2
 };
 String 7 // Description of Parameter 3
 {
-Text [ en-US ] = The number of significant digits for the 
returned percentage: if ommitted, a value of 3 is used. ;
+Text [ en-US ] = The number of significant digits for the 
returned percentage: if omitted, a value of 3 is used. ;
 };
 };
  // -=*# Resource for function PERCENTRANK.INC #*=-
@@ -5988,7 +5988,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS2
 };
 String 7 // Description of Parameter 3
 {
-Text [ en-US ] = The number of significant digits for the 
returned percentage: if ommitted, a value of 3 is used. ;
+Text [ en-US ] = The number of significant digits for the 
returned percentage: if omitted, a value of 3 is used. ;
 };
 };
  // -=*# Resource for function RANG #*=-
diff --git a/scripting/examples/python/Capitalise.py 
b/scripting/examples/python/Capitalise.py
index d9c6f07..aa14e84 100644
--- a/scripting/examples/python/Capitalise.py
+++ b/scripting/examples/python/Capitalise.py
@@ -73,6 +73,6 @@ def capitalisePython( ):
 i+= 1
 
 
-# lists the scripts, that shall be visible inside OOo. Can be omited, if
+# lists the scripts, that shall be visible inside OOo. Can be omitted, if
 # all functions shall be visible, however here getNewString shall be surpressed
 g_exportedScripts = capitalisePython,
diff --git a/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx 
b/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx
index 312363e..1ceae6b 100644
--- a/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx
+++ b/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx
@@ -155,11 +155,11 @@ public:
 @param bIncludePrecious
 When this flag is TRUE/ entries with the precious flag set are
 included in the index.  When the flag is FALSE/ these entries
-are ommited.
+are omitted.
 @param bIncludeNoPreview
 When this flag is TRUE/ entries with that have no preview
 bitmaps are included in the index.  When the flag is FALSE/ 
these entries
-are ommited.
+are omitted.
 */
 ::std::auto_ptrCacheIndex GetCacheIndex (
 bool bIncludePrecious,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Julien Nabet]

 qadevOOo/tests/java/ifc/awt/_XUnoControlContainer.java   |2 +-
 qadevOOo/tests/java/ifc/inspection/_XObjectInspector.java|2 +-
 qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java |8 
 qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java   |2 +-
 qadevOOo/tests/java/mod/_dbaccess/OInteractionHandler.java   |2 +-
 qadevOOo/tests/java/mod/_dbaccess/SbaXGridControl.java   |2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 4ed804d92850ceeacedf861865c32bf233d46924
Author: Julien Nabet serval2...@yahoo.fr
Date:   Thu Feb 6 21:25:21 2014 +0100

Typo: realtion - relation

Change-Id: I2ec2d716eaff6c6dc03bf657e77daa8e4d57cb53

diff --git a/qadevOOo/tests/java/ifc/awt/_XUnoControlContainer.java 
b/qadevOOo/tests/java/ifc/awt/_XUnoControlContainer.java
index c2f4fc6..55c21c1 100644
--- a/qadevOOo/tests/java/ifc/awt/_XUnoControlContainer.java
+++ b/qadevOOo/tests/java/ifc/awt/_XUnoControlContainer.java
@@ -56,7 +56,7 @@ public class _XUnoControlContainer extends MultiMethodTest {
 tabControl1 = (XTabController) tEnv.getObjRelation(TABCONTROL1);
 tabControl2 = (XTabController) tEnv.getObjRelation(TABCONTROL2);
 if ((tabControl1 == null) || (tabControl2 == null)){
-log.println(ERROR: Needed object realtions 'TABCONTROL1' and 
+log.println(ERROR: Needed object relations 'TABCONTROL1' and 
 + 'TABCONTROL2' are not found.);
 }
 TabControllers[0] = tabControl1;
diff --git a/qadevOOo/tests/java/ifc/inspection/_XObjectInspector.java 
b/qadevOOo/tests/java/ifc/inspection/_XObjectInspector.java
index d22df5d..93ee985 100644
--- a/qadevOOo/tests/java/ifc/inspection/_XObjectInspector.java
+++ b/qadevOOo/tests/java/ifc/inspection/_XObjectInspector.java
@@ -83,7 +83,7 @@ public class _XObjectInspector extends MultiMethodTest {
 }
 
 /**
- * Inspects a new collection of one or more objects given by object 
realtion
+ * Inspects a new collection of one or more objects given by object 
relation
  * CODEXObjectInspector.toInspect/CODEbr
  * Has bOK/b status if no runtime exceptions occurred.
  */
diff --git a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java 
b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
index b08c5e1..c4ee58c 100644
--- a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
+++ b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
@@ -151,7 +151,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * At first the object relation codexProp/code was set as parameter.
-* Relation codexQueryAna/code was used to check if realtion
+* Relation codexQueryAna/code was used to check if relation
 * codecolName/code was found.
 * Second an empty codeXPropertySet/code was used as parameter. A
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
@@ -195,7 +195,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * At first the object relation codexProp/code was used as parameter.
-* Relation codexQueryAna/code was used to check if realtion
+* Relation codexQueryAna/code was used to check if relation
 * codecolName/code was found.
 * Second an empty codeXPropertySet/code was used as parameter. An
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
@@ -299,7 +299,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * First object relation codexProp/code was used as parameter. Relation
-* codexQueryAna/code was used to check if realtion codecolName/code
+* codexQueryAna/code was used to check if relation codecolName/code
 * was found.
 * Second an empty codeXPropertySet/code was given as parameter. An
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
@@ -331,7 +331,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * First object relation codexProp/code was set as parameter. Relation
-* codexQueryAna/code was used to check if realtion codecolName/code
+* codexQueryAna/code was used to check if relation codecolName/code
 * was found.
 * Second an empty codeXPropertySet/code was given as parameter. An
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
diff --git a/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java 
b/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java
index 649f5df..8f88f25 100644
--- a/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java
+++ b/qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java
@@ -150,7 +150,7 @@ public class _XDocumentHandler extends MultiMethodTest {
 if (targetDocSet != null){
 
 }else{
-log.println(object realtion 
'XDocumentHandler.TargetDocumentSetter' not used.);
+log.println(object relation 
'XDocumentHandler.TargetDocumentSetter' not used.);

[Libreoffice-commits] core.git: qadevOOo/tests

[Julien Nabet]

 qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit f0c24877ed7cc3046bc69deb46b0cf7e2b919bcc
Author: Julien Nabet serval2...@yahoo.fr
Date:   Thu Feb 6 21:23:57 2014 +0100

Typo: chek - check

Change-Id: I979956276a9d2d76604576d8b92e8f48a9f46c74

diff --git a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java 
b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
index 3b82fec..b08c5e1 100644
--- a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
+++ b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
@@ -151,7 +151,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * At first the object relation codexProp/code was set as parameter.
-* Relation codexQueryAna/code was used to chek if realtion
+* Relation codexQueryAna/code was used to check if realtion
 * codecolName/code was found.
 * Second an empty codeXPropertySet/code was used as parameter. A
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
@@ -195,7 +195,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * At first the object relation codexProp/code was used as parameter.
-* Relation codexQueryAna/code was used to chek if realtion
+* Relation codexQueryAna/code was used to check if realtion
 * codecolName/code was found.
 * Second an empty codeXPropertySet/code was used as parameter. An
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
@@ -299,7 +299,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * First object relation codexProp/code was used as parameter. Relation
-* codexQueryAna/code was used to chek if realtion codecolName/code
+* codexQueryAna/code was used to check if realtion codecolName/code
 * was found.
 * Second an empty codeXPropertySet/code was given as parameter. An
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
@@ -331,7 +331,7 @@ public class _XSingleSelectQueryComposer extends 
MultiMethodTest {
 
 /**
 * First object relation codexProp/code was set as parameter. Relation
-* codexQueryAna/code was used to chek if realtion codecolName/code
+* codexQueryAna/code was used to check if realtion codecolName/code
 * was found.
 * Second an empty codeXPropertySet/code was given as parameter. An
 * codecom.sun.star.sdbc.SQLException/code must be thrown.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sc/source vcl/source

[Takeshi Abe]

 qadevOOo/tests/java/ifc/awt/_XButton.java |2 +-
 sc/source/core/opencl/openclwrapper.cxx   |2 +-
 vcl/source/gdi/pdfwriter_impl.cxx |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 180271e987de9b80b4ecd826df960353b036b9fd
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Tue Jan 14 15:13:16 2014 +0900

Fix typo

Change-Id: Idb7ce105bf347d7cfee039da8939aecf743f2c16

diff --git a/qadevOOo/tests/java/ifc/awt/_XButton.java 
b/qadevOOo/tests/java/ifc/awt/_XButton.java
index f26f925..c9ea36e 100644
--- a/qadevOOo/tests/java/ifc/awt/_XButton.java
+++ b/qadevOOo/tests/java/ifc/awt/_XButton.java
@@ -99,7 +99,7 @@ public class _XButton extends MultiMethodTest {
 public void _setActionCommand() {
 
 boolean result = true ;
-oObj.setActionCommand(XButtonComand) ;
+oObj.setActionCommand(XButtonCommand) ;
 
 tRes.tested(setActionCommand(), result) ;
 }
diff --git a/sc/source/core/opencl/openclwrapper.cxx 
b/sc/source/core/opencl/openclwrapper.cxx
index 5925440..ce6191f 100644
--- a/sc/source/core/opencl/openclwrapper.cxx
+++ b/sc/source/core/opencl/openclwrapper.cxx
@@ -493,7 +493,7 @@ int OpenclDevice::initOpenclRunEnv( int argc )
 if ( !isInited )
 {
 registOpenclKernel();
-//initialize devices, context, comand_queue
+//initialize devices, context, command_queue
 int status = initOpenclRunEnv( gpuEnv );
 if ( status )
 {
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 8259cbf..f7a73ea 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -1908,7 +1908,7 @@ void PDFWriterImpl::computeDocumentIdentifier( 
std::vector sal_uInt8  o_rIden
 // according to ISO 19005-1:2005 6.7.3 the date is corrected for
 // local time zone offset UTC only, whereas Acrobat 8 seems
 // to use the localtime notation only
-// according to a raccomandation in XMP Specification (Jan 2004, page 75)
+// according to a recommendation in XMP Specification (Jan 2004, page 75)
 // the Acrobat way seems the right approach
 aCreationMetaDateString.append( (sal_Char)('0' + ((aDT.Year/1000)%10)) );
 aCreationMetaDateString.append( (sal_Char)('0' + ((aDT.Year/100)%10)) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/accessibility/_XAccessibleContext.java |   17 
--
 1 file changed, 7 insertions(+), 10 deletions(-)

New commits:
commit 8d74243a65da4b0e28a68018657e9b1375ae14d4
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Dec 4 15:06:40 2013 +0100

Improve test code

Change-Id: I196a7f654bf8f061a4b050ea1fbe01fae9f450c2

diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleContext.java 
b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleContext.java
index 7ec0c58..bfcee4d 100644
--- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleContext.java
+++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleContext.java
@@ -206,24 +206,21 @@ public class _XAccessibleContext extends MultiMethodTest {
 XAccessibleContext parentAC = parent.getAccessibleContext();
 
 try {
-if (parentAC.getAccessibleChild(idx) == null) {
+XAccessible child = parentAC.getAccessibleChild(idx);
+XAccessibleContext childAC = null;
+if (child == null) {
 log.println(Parent has no child with this index);
 bOK = false;
 } else {
-bOK = AccessibilityTools.equals(parentAC.getAccessibleChild(
- idx)
- 
.getAccessibleContext(),
- oObj);
+childAC = child.getAccessibleContext();
+bOK = AccessibilityTools.equals(childAC, oObj);
 }
 
 if (!bOK) {
 log.println(Expected:  + util.utils.getImplName(oObj));
 
-if (parentAC.getAccessibleChild(idx) != null) {
-log.println(Getting:  +
-util.utils.getImplName(
-parentAC.getAccessibleChild(idx)
-.getAccessibleContext()));
+if (childAC != null) {
+log.println(Getting:  + util.utils.getImplName(childAC));
 }
 }
 } catch (com.sun.star.lang.IndexOutOfBoundsException e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewTable.java |   48 --
 1 file changed, 29 insertions(+), 19 deletions(-)

New commits:
commit a25d360b3e08751ea24f1c5ae4dea799d38a668b
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Nov 4 18:24:25 2013 +0100

Try make this more robust in slow environments

...where the previous .uno:PrintPreview request has not yet been processed, 
the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 Try make this more robust in slow
environments plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 Also cope with
intermittend DisposedExceptions.

Change-Id: I5244e8f8af9560ae986ed3a836bdf9571574420f

diff --git a/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewTable.java 
b/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewTable.java
index 7b93d27..9f5b3b0 100644
--- a/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewTable.java
+++ b/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewTable.java
@@ -39,6 +39,7 @@ import com.sun.star.frame.XController;
 import com.sun.star.frame.XDispatch;
 import com.sun.star.frame.XDispatchProvider;
 import com.sun.star.frame.XModel;
+import com.sun.star.lang.DisposedException;
 import com.sun.star.lang.XComponent;
 import com.sun.star.lang.XMultiServiceFactory;
 import com.sun.star.sheet.XSpreadsheet;
@@ -113,7 +114,6 @@ public class ScAccessiblePreviewTable extends TestCase {
  */
 protected synchronized TestEnvironment 
createTestEnvironment(TestParameters Param, PrintWriter log) {
 
-XInterface oObj = null;
 XCell xCell = null;
 
 try {
@@ -163,16 +163,34 @@ public class ScAccessiblePreviewTable extends TestCase {
 throw new StatusException(Status.failed(Couldn't change mode));
 }
 
-shortWait();
-
-AccessibilityTools at = new AccessibilityTools();
-
-XWindow xWindow = 
AccessibilityTools.getCurrentContainerWindow((XMultiServiceFactory)Param.getMSF(),
 xModel);
-XAccessible xRoot = AccessibilityTools.getAccessibleObject(xWindow);
-
-AccessibilityTools.printAccessibleTree(log,xRoot, 
Param.getBool(PropertyName.DEBUG_IS_ACTIVE));
-
-oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot, 
AccessibleRole.TABLE);
+XAccessible xRoot;
+XInterface oObj;
+for (int i = 0;; ++i) {
+try {
+Thread.sleep(500);
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+try {
+xRoot = AccessibilityTools.getAccessibleObject(
+AccessibilityTools.getCurrentContainerWindow(
+(XMultiServiceFactory)Param.getMSF(), xModel));
+if (xRoot != null) {
+oObj = AccessibilityTools.getAccessibleObjectForRole(
+xRoot, AccessibleRole.TABLE);
+if (oObj != null) {
+break;
+}
+}
+} catch (DisposedException e) {
+log.println(Ignoring DisposedException);
+}
+if (i == 20) { // give up after 10 sec
+throw new RuntimeException(
+Couldn't get AccessibleRole.TABLE/PUSH_BUTTON object);
+}
+log.println(No TABLE/PUSH_BUTTON found yet, retrying);
+}
 
 log.println(ImplementationName  + utils.getImplName(oObj));
 
@@ -195,12 +213,4 @@ public class ScAccessiblePreviewTable extends TestCase {
 
 return tEnv;
 }
-
-protected void shortWait() {
-try {
-Thread.sleep(1000) ;
-} catch (InterruptedException e) {
-System.out.println(While waiting : + e);
-}
-}
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewCell.java |   46 +--
 1 file changed, 28 insertions(+), 18 deletions(-)

New commits:
commit baa68e4e89c81b20f79576734cdbfa63665b3ff5
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Nov 1 09:41:30 2013 +0100

Try make this more robust in slow environments

...where the previous .uno:PrintPreview request has not yet been processed, 
the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 Try make this more robust in slow
environments plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 Also cope with
intermittend DisposedExceptions.

Change-Id: I64389b817d91a2bed8dfe1b8d92bafec42eba21a

diff --git a/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewCell.java 
b/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewCell.java
index e0897dd..d56f8e8 100644
--- a/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewCell.java
+++ b/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewCell.java
@@ -37,6 +37,7 @@ import com.sun.star.frame.XController;
 import com.sun.star.frame.XDispatch;
 import com.sun.star.frame.XDispatchProvider;
 import com.sun.star.frame.XModel;
+import com.sun.star.lang.DisposedException;
 import com.sun.star.lang.XComponent;
 import com.sun.star.lang.XMultiServiceFactory;
 import com.sun.star.sheet.XSpreadsheet;
@@ -109,8 +110,6 @@ public class ScAccessiblePreviewCell extends TestCase {
  * Obtains the accessible object for a one of cell in preview mode.
  */
 protected synchronized TestEnvironment 
createTestEnvironment(TestParameters Param, PrintWriter log) {
-
-XInterface oObj = null;
 XCell xCell = null;
 
 try {
@@ -160,14 +159,33 @@ public class ScAccessiblePreviewCell extends TestCase {
 throw new StatusException(Status.failed(Couldn't change mode));
 }
 
-shortWait();
-
-AccessibilityTools at = new AccessibilityTools();
-
-XWindow xWindow = 
AccessibilityTools.getCurrentWindow((XMultiServiceFactory)Param.getMSF(), 
xModel);
-XAccessible xRoot = AccessibilityTools.getAccessibleObject(xWindow);
-
-oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot, 
AccessibleRole.TABLE_CELL, true);
+XInterface oObj = null;
+for (int i = 0;; ++i) {
+try {
+Thread.sleep(500);
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+try {
+XAccessible xRoot = AccessibilityTools.getAccessibleObject(
+AccessibilityTools.getCurrentWindow(
+(XMultiServiceFactory) Param.getMSF(), xModel));
+if (xRoot != null) {
+oObj = AccessibilityTools.getAccessibleObjectForRole(
+xRoot, AccessibleRole.TABLE_CELL, true);
+if (oObj != null) {
+break;
+}
+}
+} catch (DisposedException e) {
+log.println(Ignoring DisposedException);
+}
+if (i == 20) { // give up after 10 sec
+throw new RuntimeException(
+Couldn't get AccessibleRole.TABLE_CELL object);
+}
+log.println(No TABLE_CELL found yet, retrying);
+}
 
 log.println(ImplementationName  + utils.getImplName(oObj));
 
@@ -182,12 +200,4 @@ public class ScAccessiblePreviewCell extends TestCase {
 
 return tEnv;
 }
-
-protected void shortWait() {
-try {
-Thread.sleep(1000) ;
-} catch (InterruptedException e) {
-System.out.println(While waiting : + e);
-}
-}
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell.java |   60 
+-
 1 file changed, 32 insertions(+), 28 deletions(-)

New commits:
commit ee337e7ed61d1ee6fe37520eed30805329c44fb6
Author: Stephan Bergmann sberg...@redhat.com
Date:   Tue Oct 22 12:24:31 2013 +0200

Try make this more robust in slow environments

...where the previous .uno:PrintPreview request has not yet been processed, 
the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 Try make this more robust in slow
environments plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 Also cope with
intermittend DisposedExceptions.

Change-Id: I4b0ca00c04c2b1c8ffbfe4aaf926305ee9b51f30

diff --git a/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell.java 
b/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell.java
index 0419b9e..e9fea34 100644
--- a/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell.java
+++ b/qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell.java
@@ -38,6 +38,7 @@ import com.sun.star.frame.XController;
 import com.sun.star.frame.XDispatch;
 import com.sun.star.frame.XDispatchProvider;
 import com.sun.star.frame.XModel;
+import com.sun.star.lang.DisposedException;
 import com.sun.star.lang.XComponent;
 import com.sun.star.lang.XMultiServiceFactory;
 import com.sun.star.sheet.XSpreadsheet;
@@ -118,8 +119,6 @@ public class ScAccessiblePreviewHeaderCell extends TestCase 
{
  */
 protected synchronized TestEnvironment 
createTestEnvironment(TestParameters Param,
  PrintWriter 
log) {
-XInterface oObj = null;
-
 if (xSheetDoc != null) {
 XComponent oComp = UnoRuntime.queryInterface(
XComponent.class, xSheetDoc);
@@ -241,20 +240,37 @@ public class ScAccessiblePreviewHeaderCell extends 
TestCase {
 throw new StatusException(Status.failed(Couldn't change mode));
 }
 
-shortWait();
-
-AccessibilityTools at = new AccessibilityTools();
-
-XWindow xWindow = AccessibilityTools.getCurrentWindow( 
(XMultiServiceFactory) Param.getMSF(), xModel);
-XAccessible xRoot = AccessibilityTools.getAccessibleObject(xWindow);
-
-oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot, 
AccessibleRole.TABLE, A);
-
-if (oObj == null) {
-log.println(Version with a fixed #103863#);
-oObj = AccessibilityTools.getAccessibleObjectForRole(xRoot,
- AccessibleRole.TABLE_CELL,
- true);
+XInterface oObj = null;
+for (int i = 0;; ++i) {
+try {
+Thread.sleep(500);
+} catch (InterruptedException e) {
+throw new RuntimeException(e);
+}
+try {
+XAccessible xRoot = AccessibilityTools.getAccessibleObject(
+AccessibilityTools.getCurrentWindow(
+(XMultiServiceFactory) Param.getMSF(), xModel));
+if (xRoot != null) {
+oObj = AccessibilityTools.getAccessibleObjectForRole(
+xRoot, AccessibleRole.TABLE, A);
+if (oObj == null) {
+log.println(Version with a fixed #103863#?);
+oObj = AccessibilityTools.getAccessibleObjectForRole(
+xRoot, AccessibleRole.TABLE_CELL, true);
+}
+if (oObj != null) {
+break;
+}
+}
+} catch (DisposedException e) {
+log.println(Ignoring DisposedException);
+}
+if (i == 20) { // give up after 10 sec
+throw new RuntimeException(
+Couldn't get AccessibleRolte.TABLE/TABLE_CELL object);
+}
+log.println(No TABLE/TABLE_CELL found yet, retrying);
 }
 
 log.println(ImplementationName  + utils.getImplName(oObj));
@@ -269,16 +285,4 @@ public class ScAccessiblePreviewHeaderCell extends 
TestCase {
 
 return tEnv;
 }
-
-/**
-* Sleeps for 0.5 sec. to allow StarOffice to react on code
-* reset/code call.
-*/
-private void shortWait() {
-try {
-Thread.sleep(500);
-} catch (InterruptedException e) {
-System.out.println(While waiting : + e);
-}
-}
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests

[Stephan Bergmann]

 qadevOOo/tests/java/ifc/form/validation/_XValidatableFormComponent.java |6 
+-
 qadevOOo/tests/java/mod/_forms/ODateModel.java  |2 
+-
 2 files changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 8dbfb3bfb1b06abfdc99d483f1a9aa948d6efa6e
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Aug 5 11:51:23 2013 +0200

More little fixes for JunitTest_forms_unoapi

...needed since 8ee69b0ba13f74d1515fac71df92947eb6328ab1 fdo#67235 adapt 
form
control code to time nanosecond API change, step 3.

Change-Id: If0fc8109d6da56c8e8df181ae0b35a4d9b34e767

diff --git 
a/qadevOOo/tests/java/ifc/form/validation/_XValidatableFormComponent.java 
b/qadevOOo/tests/java/ifc/form/validation/_XValidatableFormComponent.java
index 1433a7a..3580a02 100644
--- a/qadevOOo/tests/java/ifc/form/validation/_XValidatableFormComponent.java
+++ b/qadevOOo/tests/java/ifc/form/validation/_XValidatableFormComponent.java
@@ -110,12 +110,16 @@ public class _XValidatableFormComponent extends 
MultiMethodTest
 
 if (
 testPropsNames[i].equals(Value)
-|| testPropsNames[i].equals(Time)
 || testPropsNames[i].equals(EffectiveValue)
 )
 {
 oldValue = new Integer(10);
 }
+else if (testPropsNames[i].equals(Time))
+{
+oldValue = new com.sun.star.util.Time(
+10, (short) 10, (short) 10, (short) 10, false);
+}
 
 Object newValue = ValueChanger.changePValue(oldValue);
 gValues[i] = newValue;
diff --git a/qadevOOo/tests/java/mod/_forms/ODateModel.java 
b/qadevOOo/tests/java/mod/_forms/ODateModel.java
index f5c7445..79d24c1 100644
--- a/qadevOOo/tests/java/mod/_forms/ODateModel.java
+++ b/qadevOOo/tests/java/mod/_forms/ODateModel.java
@@ -140,7 +140,7 @@ public class ODateModel extends GenericModelTest {
 
 NamedValue Date = new NamedValue();
 Date.Name = Date;
-Date.Value = new Integer(DBTools.TST_DATE);
+Date.Value = new com.sun.star.util.Date();
 super.m_propertiesToSet.add(Date);
 
 super.m_LCShape_Type = FixedText;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: qadevOOo/tests sfx2/source sw/source wizards/com

[Thomas Klausner]

 qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java |2 +-
 sfx2/source/dialog/basedlgs.cxx  |4 ++--
 sw/source/ui/app/appenv.cxx  |4 ++--
 sw/source/ui/inc/envimg.hxx  |6 +++---
 wizards/com/sun/star/wizards/common/SystemDialog.java|2 +-
 wizards/com/sun/star/wizards/web/ProcessStatusRenderer.py|4 ++--
 6 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 0b59f6953a57e4785c9fc3e4da33ebd801946339
Author: Thomas Klausner w...@netbsd.org
Date:   Wed Jul 31 00:09:46 2013 +0200

Fix some typos.

Signed-off-by: Thomas Klausner w...@netbsd.org

diff --git a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java 
b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
index 18f03be..f0ff547 100644
--- a/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
+++ b/qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryAnalyzer.java
@@ -55,7 +55,7 @@ public class _XSingleSelectQueryAnalyzer extends 
MultiMethodTest {
 private XSingleSelectQueryComposer xComposer = null;
 
 /**
- * Recieves the object relations:
+ * Receives the object relations:
 * ul
 *  licodeXSingleSelectQueryComposer xCompoer/code/li
 * /ul p
diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index ff44f01..24cfb9e 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -803,7 +803,7 @@ void SfxSingleTabDialog::setTabPage(SfxTabPage* pTabPage,
 if (!sTitle.isEmpty())
 SetText(sTitle);
 
-// Dialog recieves the HelpId of TabPage if there is any
+// Dialog receives the HelpId of TabPage if there is any
 OString sHelpId(pImpl-m_pSfxPage-GetHelpId());
 if (!sHelpId.isEmpty())
 SetHelpId(sHelpId);
@@ -873,7 +873,7 @@ void SfxNoLayoutSingleTabDialog::SetTabPage( SfxTabPage* 
pTabPage,
 // Set TabPage text in the Dialog
 SetText( pImpl-m_pSfxPage-GetText() );
 
-// Dialog recieves the HelpId of TabPage
+// Dialog receives the HelpId of TabPage
 SetHelpId( pImpl-m_pSfxPage-GetHelpId() );
 SetUniqueId( pImpl-m_pSfxPage-GetUniqueId() );
 }
diff --git a/sw/source/ui/app/appenv.cxx b/sw/source/ui/app/appenv.cxx
index af2bda4..6d6eab0 100644
--- a/sw/source/ui/app/appenv.cxx
+++ b/sw/source/ui/app/appenv.cxx
@@ -164,7 +164,7 @@ void SwModule::InsertEnv( SfxRequest rReq )
 aTmp += OUString::number( ++nTitleNo );
 xDocSh-SetTitle( aTmp );
 
-// if applicable, copy the old Collections Sender and Reciever to
+// if applicable, copy the old Collections Sender and Receiver to
 // a new document
 if ( pOldSh )
 {
@@ -312,7 +312,7 @@ void SwModule::InsertEnv( SfxRequest rReq )
 pSh-StartAllAction();
 pSh-DoUndo(sal_False);
 
-// Again, copy the new collections Sender and Reciever to
+// Again, copy the new collections Sender and Receiver to
 // a new document
 if ( pOldSh )
 {
diff --git a/sw/source/ui/inc/envimg.hxx b/sw/source/ui/inc/envimg.hxx
index 1c072c7..c9902fc 100644
--- a/sw/source/ui/inc/envimg.hxx
+++ b/sw/source/ui/inc/envimg.hxx
@@ -42,11 +42,11 @@ class SW_DLLPUBLIC SwEnvItem : public SfxPoolItem
 {
 public:
 
-OUString   aAddrText;   // text for reciever
+OUString   aAddrText;   // text for receiver
 sal_BoolbSend;   // sender?
 OUString   aSendText;   // text for sender
-sal_Int32   lAddrFromLeft;   // left gap for reciever (twips)
-sal_Int32   lAddrFromTop;// upper gap for reciever (twips)
+sal_Int32   lAddrFromLeft;   // left gap for receiver (twips)
+sal_Int32   lAddrFromTop;// upper gap for receiver (twips)
 sal_Int32   lSendFromLeft;   // left gap for sender (twips)
 sal_Int32   lSendFromTop;// upper gap for sender (twips)
 sal_Int32   lWidth;  // envelope's width (twips)
diff --git a/wizards/com/sun/star/wizards/common/SystemDialog.java 
b/wizards/com/sun/star/wizards/common/SystemDialog.java
index 58b9e52..575bd90 100644
--- a/wizards/com/sun/star/wizards/common/SystemDialog.java
+++ b/wizards/com/sun/star/wizards/common/SystemDialog.java
@@ -348,7 +348,7 @@ public class SystemDialog
 }
 
 /**
- * just like the other showMessageBox(...) method, but recieves a
+ * just like the other showMessageBox(...) method, but receives a
  * peer argument to use to create the message box.
  * @param xMSF
  * @param peer
diff --git a/wizards/com/sun/star/wizards/web/ProcessStatusRenderer.py 
b/wizards/com/sun/star/wizards/web/ProcessStatusRenderer.py
index f123785..722a1b6 100644
--- a/wizards/com/sun/star/wizards/web/ProcessStatusRenderer.py
+++ b/wizards/com/sun/star/wizards/web/ProcessStatusRenderer.py
@@ -20,8 +20,8 @@