[Libreoffice-commits] core.git: svx/sdi sw/sdi

2023-01-18 Thread Justin Luth (via logerrit)
 svx/sdi/svx.sdi|   13 +
 sw/sdi/swriter.sdi |2 ++
 2 files changed, 15 insertions(+)

New commits:
commit ec6d1156b70b0abeb60d2c481392e538328eabac
Author: Justin Luth 
AuthorDate: Mon Jan 16 13:17:42 2023 -0500
Commit: Miklos Vajna 
CommitDate: Wed Jan 18 14:13:52 2023 +

document svx.sdi with link to SDI slot config details

UI stuff is a total black box,
so most of the config is just copy/pasted from a similar function,
with nothing to indicate what any of it means or does.

Miklos pointed me to this documentation,
so I've dumped it here so that there are a few breadcrumbs
pointing to the specs for what this stuff means.

Change-Id: Iccbc0ff5b400328af8ae683fdcf42203e4029d48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145624
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index 6710fdf145a7..d86ce1df20f4 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -15,6 +15,19 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
+
+/*
+ * See 
https://wiki.openoffice.org/wiki/Framework/Article/Implementation_of_the_Dispatch_API_In_SFX2#Slot_definitions
+ * for details on what these mean, and what values to use.
+ * Likely many of the existing ones are not defined correctly.
+ *
+ * Items defined here tend to be used throughout the office suite.
+ * Other locations for application-specific slots can exist too.
+ *  - sw/sdi/swriter.sdis
+ *  - sc/sdi/scalc.sdi
+ *  - sd/sdi/sdraw.sdi
+ */
+
 SfxInt32Item AbsoluteRecord SID_FM_RECORD_ABSOLUTE
 (SfxInt32Item Position FN_PARAM_1)
 [
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index 49f181d9b377..8b0f7b2364a7 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -16,6 +16,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+// See svx/sdi/svx.sdi for hints on how to define these
+
 SfxVoidItem CreateSWDrawView SID_CREATE_SW_DRAWVIEW
 ()
 [


[Libreoffice-commits] core.git: svx/sdi sw/sdi sw/uiconfig

2020-01-06 Thread Mike Kaganski (via logerrit)
 svx/sdi/svx.sdi  |4 ++--
 sw/sdi/swriter.sdi   |6 +++---
 sw/uiconfig/sglobal/menubar/menubar.xml  |2 +-
 sw/uiconfig/sglobal/toolbar/numobjectbar.xml |2 +-
 sw/uiconfig/sweb/menubar/menubar.xml |2 +-
 sw/uiconfig/sweb/toolbar/numobjectbar.xml|2 +-
 sw/uiconfig/swform/menubar/menubar.xml   |2 +-
 sw/uiconfig/swform/toolbar/numobjectbar.xml  |2 +-
 sw/uiconfig/swreport/menubar/menubar.xml |2 +-
 sw/uiconfig/swreport/toolbar/numobjectbar.xml|2 +-
 sw/uiconfig/swriter/menubar/menubar.xml  |2 +-
 sw/uiconfig/swriter/toolbar/numobjectbar.xml |2 +-
 sw/uiconfig/swriter/ui/notebookbar.ui|2 +-
 sw/uiconfig/swriter/ui/notebookbar_compact.ui|2 +-
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui |2 +-
 sw/uiconfig/swriter/ui/notebookbar_groupedbar_full.ui|6 +++---
 sw/uiconfig/swxform/menubar/menubar.xml  |2 +-
 sw/uiconfig/swxform/toolbar/numobjectbar.xml |2 +-
 18 files changed, 23 insertions(+), 23 deletions(-)

New commits:
commit d1133d71a6109d1999121fd6a91573d12dc4852b
Author: Mike Kaganski 
AuthorDate: Sun Jan 5 20:48:16 2020 +0300
Commit: Mike Kaganski 
CommitDate: Mon Jan 6 16:34:08 2020 +0100

tdf#129549: hide .uno:BulletsAndNumberingDialog from customization UI

... and replace its uses with universal .uno:OutlineBullet

Change-Id: Ia6bc1c5ca23440af333ffeed9fcd2c8dd47a6af4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86245
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 
Reviewed-by: Mike Kaganski 

diff --git a/svx/sdi/svx.sdi b/svx/sdi/svx.sdi
index c2ceb08f7c0c..2567e08906b0 100644
--- a/svx/sdi/svx.sdi
+++ b/svx/sdi/svx.sdi
@@ -5905,8 +5905,8 @@ SfxVoidItem OutlineBullet SID_OUTLINE_BULLET
 RecordAbsolute = FALSE,
 RecordPerSet;
 
-AccelConfig = FALSE,
-MenuConfig = FALSE,
+AccelConfig = TRUE,
+MenuConfig = TRUE,
 ToolBoxConfig = TRUE,
 GroupId = SfxGroupId::Format;
 ]
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index d063a0dd5441..489b6b698336 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -461,9 +461,9 @@ SfxVoidItem BulletsAndNumberingDialog FN_NUMBER_BULLETS
 RecordPerSet;
 Asynchron;
 
-AccelConfig = TRUE,
-MenuConfig = TRUE,
-ToolBoxConfig = TRUE,
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
 GroupId = SfxGroupId::Enumeration;
 ]
 
diff --git a/sw/uiconfig/sglobal/menubar/menubar.xml 
b/sw/uiconfig/sglobal/menubar/menubar.xml
index e74fcb8f60ec..268b30cf68b8 100644
--- a/sw/uiconfig/sglobal/menubar/menubar.xml
+++ b/sw/uiconfig/sglobal/menubar/menubar.xml
@@ -440,7 +440,7 @@
   
   
   
-  
+  
   
   
   
diff --git a/sw/uiconfig/sglobal/toolbar/numobjectbar.xml 
b/sw/uiconfig/sglobal/toolbar/numobjectbar.xml
index 14a05ef6f62a..9fcd5ed70c74 100644
--- a/sw/uiconfig/sglobal/toolbar/numobjectbar.xml
+++ b/sw/uiconfig/sglobal/toolbar/numobjectbar.xml
@@ -39,5 +39,5 @@
  
  
  
- 
+ 
 
diff --git a/sw/uiconfig/sweb/menubar/menubar.xml 
b/sw/uiconfig/sweb/menubar/menubar.xml
index 9c0ac3e88a3a..8f773df0c8c2 100644
--- a/sw/uiconfig/sweb/menubar/menubar.xml
+++ b/sw/uiconfig/sweb/menubar/menubar.xml
@@ -313,7 +313,7 @@
   
   
   
-  
+  
   
   
   
diff --git a/sw/uiconfig/sweb/toolbar/numobjectbar.xml 
b/sw/uiconfig/sweb/toolbar/numobjectbar.xml
index 14a05ef6f62a..9fcd5ed70c74 100644
--- a/sw/uiconfig/sweb/toolbar/numobjectbar.xml
+++ b/sw/uiconfig/sweb/toolbar/numobjectbar.xml
@@ -39,5 +39,5 @@
  
  
  
- 
+ 
 
diff --git a/sw/uiconfig/swform/menubar/menubar.xml 
b/sw/uiconfig/swform/menubar/menubar.xml
index 973cfd9ade65..aaea61d9b1da 100644
--- a/sw/uiconfig/swform/menubar/menubar.xml
+++ b/sw/uiconfig/swform/menubar/menubar.xml
@@ -392,7 +392,7 @@
   
   
   
-  
+  
   
   
   
diff --git a/sw/uiconfig/swform/toolbar/numobjectbar.xml 
b/sw/uiconfig/swform/toolbar/numobjectbar.xml
index 14a05ef6f62a..9fcd5ed70c74 100644
--- a/sw/uiconfig/swform/toolbar/numobjectbar.xml
+++ b/sw/uiconfig/swform/toolbar/numobjectbar.xml
@@ -39,5 +39,5 @@
  
  
  
- 
+ 
 
diff --git a/sw/uiconfig/swreport/menubar/menubar.xml 
b/sw/uiconfig/swreport/menubar/menubar.xml
index a81e5dd14d42..d2c1c629182a 100644
--- a/sw/uiconfig/swreport/menubar/menubar.xml
+++ b/sw/uiconfig/swreport/menubar/menubar.xml
@@ -378,7 +378,7 @@
   
   
   
-  
+  
   
   
   
diff --git a/sw/uiconfig/swreport/toolbar/numobjectbar.xml 
b/sw/uiconfig/swreport/toolbar/numobjectbar.xml
index d7adb625dc18..87aa2432dadf 100644
--- a/sw/uiconfig/swreport/toolbar/numobjectbar.xml
+++