Re: [Libreoffice-ux-advise] [PATCH] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-14 Thread Muhammad Haggag
On Sun, Feb 12, 2012 at 3:38 PM, Cor Nouws  wrote:

> Korrawit Pruegsanusak wrote (12-02-12 13:30)
>
>  IMHO the case which 'file open' would be useful is already described
>> in the bug comment 0 and 4: saving with a new name doesn't get old
>> name into the list.
>>
>
> Yes, if that is the technical reason, and can't be (easily) solved
> different (as suggested below) I do not object to have it in!
>
>
It's possible to solve that without having to update the list on open. We
can intercept the beginning of the "Save As" operation and update the list
with the old document. I uploaded a new patch that does that (and removed
the list update on document open).

Patch:
https://bugs.freedesktop.org/attachment.cgi?id=57016

Patch review:
https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=37775&attachment=57016

Regards,
--Muhammad
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-ux-advise] [PATCH] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-12 Thread Cor Nouws

Korrawit Pruegsanusak wrote (12-02-12 13:30)

IMHO the case which 'file open' would be useful is already described
in the bug comment 0 and 4: saving with a new name doesn't get old
name into the list.


Yes, if that is the technical reason, and can't be (easily) solved 
different (as suggested below) I do not object to have it in!



But if it isn't renamed, could we place a check somewhere before
putting the file into the list?


Cheers,

--
 - Cor
 - http://nl.libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-ux-advise] [PATCH] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-12 Thread Korrawit Pruegsanusak
Hello Cor, all,

On Sun, Feb 12, 2012 at 17:16, Cor Nouws  wrote:
> Indeed, me thinks that the real improvement is the change of the recent
> documents with all types of saving and closing. File Open does not look
> useful to me.

IMHO the case which 'file open' would be useful is already described
in the bug comment 0 and 4: saving with a new name doesn't get old
name into the list.

But if it isn't renamed, could we place a check somewhere before
putting the file into the list?

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice