Re: [PATCH] Add HarfBuzz support to the build system

2013-04-24 Thread Jan Holesovsky
Hi Khaled, Khaled Hosny píše v Ne 21. 04. 2013 v 10:51 +0200: I didn't know that it will submit each commit separately (git review), should I abandon this and the next commits and squash them into one? No problem - better to keep the logical grouping of the commits, with more traffic, than to

[PATCH] Add HarfBuzz support to the build system

2013-04-21 Thread Khaled Hosny (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3517 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/3517/1 Add HarfBuzz support to the build system To be used in the next commit. No support for non-system build, yet.

Re: [PATCH] Add HarfBuzz support to the build system

2013-04-21 Thread Khaled Hosny
Hi, I didn't know that it will submit each commit separately (git review), should I abandon this and the next commits and squash them into one? Also, there are some unresolved issues that I can't handle, may be submitting to gerrit wasn't the best idea after all. Regards, Khaled On Sun, Apr